Hi Rajat,
> -Original Message-
> From: Rajat Jain
> Sent: Thursday, February 20, 2020 1:39 PM
> >
> > For this particular issue what is the best way to contribute and get
> > involved? We'd like to make it so ePrivacy can be used more easily from
> > Linux. I agree a more generic way of c
e if the two need to be connected
somehow (or if handling the event is actually not important and polling is
acceptable)?
As a note Nitin has been working with the Red Hat folk and is looking at the
user space aspect of this (in particularl gnome settings) as well.
Thanks
Mark Pearson
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
functionality
Co-developed-by: Nitin Joshi
Signed-off-by: Nitin Joshi
Reviewed-by: Sugumaran
Signed-off-by: Mark Pearson
---
drivers/platform/x86/thinkpad_acpi.c | 120 +++
1 file changed, 120 insertions(+)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86
Thanks Henrique
On 6/1/2020 6:42 PM, Henrique de Moraes Holschuh wrote:
On Mon, 01 Jun 2020, Mark Pearson wrote:
Newer Lenovo Thinkpad platforms have support to identify whether the
system is on-lap or not using an ACPI DYTC event from the firmware.
This patch provides the ability to
functionality
Co-developed-by: Nitin Joshi
Signed-off-by: Nitin Joshi
Reviewed-by: Sugumaran
Signed-off-by: Mark Pearson
---
Changes in v2:
- cleaned up initialisation sequence to be cleaner and avoid spamming
platforms that don't have DYTC with warning message. Tested on P52
- Adding platform-d
functionality
Co-developed-by: Nitin Joshi
Signed-off-by: Nitin Joshi
Reviewed-by: Sugumaran
Signed-off-by: Mark Pearson
---
Resend:
- Adding Bastien Nocera to cc list as requested
Changes in v2:
- cleaned up initialisation sequence to be cleaner and avoid spamming
platforms that don't have DYTC
Hi Bastien
On 6/19/2020 9:52 AM, Bastien Nocera wrote:
Hey Mark,
- Original Message -
+/*
+ * DYTC subdriver, for the Lenovo performace mode feature
+ */
I don't think this should mention the performance mod
functionality
Co-developed-by: Nitin Joshi
Signed-off-by: Nitin Joshi
Reviewed-by: Sugumaran
Signed-off-by: Mark Pearson
---
Changes in v3:
- Fixed inaccurate comments
- Used BIT macro to check lapmode bit setting as recommended and update
define name
- Check for new_state == dytc_lapmode in
functionality
Co-developed-by: Nitin Joshi
Signed-off-by: Nitin Joshi
Reviewed-by: Sugumaran
Signed-off-by: Mark Pearson
---
Changes in v4:
- Correct hotkey event comment as we're handling event
- Remove unnecessary check in dytc_lapmode_refresh
Changes in v3:
- Fixed inaccurate comments
- Use
Thanks Andy
On 7/2/2020 5:29 AM, Andy Shevchenko wrote:
On Mon, Jun 29, 2020 at 10:23 PM Mark Pearson wrote:
Thanks for the patch, my comments below.
Newer Lenovo Thinkpad platforms have support to identify whether the
system is on-lap or not using an ACPI DYTC event from the firmware
-developed-by: Nitin Joshi
Signed-off-by: Nitin Joshi
Reviewed-by: Sugumaran
Reviewed-by: Bastien Nocera
Signed-off-by: Mark Pearson
---
Changes in v5:
- Updated with review changes from Andy Shevchenko
- Added ABI information to thinkpad-acpi.rst
- improved error handling and parameter passing
On 7/10/2020 8:20 AM, Andy Shevchenko wrote:
On Fri, Jul 10, 2020 at 11:00 AM Hans de Goede wrote:
Hi,
On 7/9/20 8:02 PM, Andy Shevchenko wrote:
On Fri, Jul 3, 2020 at 4:24 AM Mark Pearson wrote:
Newer Lenovo Thinkpad platforms have support to identify whether the
system is on-lap or
ontrol the transmission level safely
Co-developed-by: Nitin Joshi
Signed-off-by: Nitin Joshi
Signed-off-by: Mark Pearson
---
.../admin-guide/laptops/thinkpad-acpi.rst | 19
drivers/platform/x86/thinkpad_acpi.c | 104 +-
2 files changed, 121 insertions(+), 2
also
allow the setting of the mode through the dytc_perfmode sysfs entry. This
can be used by userspace for improved control.
Reviewed-by: Nitin Joshi
Signed-off-by: Mark Pearson
---
.../admin-guide/laptops/thinkpad-acpi.rst | 35 +++
drivers/platform/x86/thinkpad_acpi.c
Hi Mario
On 7/22/2020 2:46 PM, Limonciello, Mario wrote:
+DYTC Thermal mode status and control
+
+
+sysfs: dytc_perfmode
+
+Lenovo Thinkpad platforms with DYTC version 5 and newer have enhanced
firmware to
+provide improved performance control.
+
+The firmwa
On 7/22/2020 3:46 PM, Limonciello, Mario wrote:
On 7/22/2020 2:46 PM, Limonciello, Mario wrote:
+DYTC Thermal mode status and control
+
+
+sysfs: dytc_perfmode
+
+Lenovo Thinkpad platforms with DYTC version 5 and newer have enhanced
firmware to
+provide imp
Hi Elvis,
On 8/3/2020 9:20 AM, Elvis Stansvik wrote:
Den sön 2 aug. 2020 kl 23:10 skrev Elvis Stansvik
:
(Apologies in advance for missing In-Reply-To header in this
reply. I subscribed to the list just now.)
Den fre 3 juli 2020 kl 01:24 skrev Mark Pearson
:
Newer Lenovo Thinkpad
On 8/3/2020 10:46 AM, Elvis Stansvik wrote:
Thanks Mark. I know the X1C6 firmware did not get the new thermal
mode implementation, but thought that I would still be able to query
its lap mode.
The reason I wanted query the lap mode is actually because I'm
trying to help Matthew Garrett out
ssage-
From: Andy Shevchenko
Sent: Monday, July 27, 2020 7:35 PM
On Thu, Jul 16, 2020 at 2:53 AM Mark Pearson
wrote:
case TP_HKEY_EV_PALM_DETECTED:
case TP_HKEY_EV_PALM_UNDETECTED:
- /* palm detected hovering the keyboard, forward to user-
ontrol the transmission level safely
Co-developed-by: Nitin Joshi
Signed-off-by: Nitin Joshi
Signed-off-by: Mark Pearson
---
Changes in v2:
- addressed formatting and coding style errors identified during review
drivers/platform/x86/thinkpad_acpi.c | 107 ++-
1 file ch
ontrol the transmission level safely
Co-developed-by: Nitin Joshi
Signed-off-by: Nitin Joshi
Signed-off-by: Mark Pearson
---
Changes in v2:
- addressed formatting and coding style errors identified during review
Changes in v3:
- I had missed updating thinkpad-acpi.rst in the v2 update so addi
also
allow the setting of the mode through the dytc_perfmode sysfs entry. This
can be used by userspace for improved control.
Reviewed-by: Nitin Joshi
Signed-off-by: Mark Pearson
---
Changes in v2:
- Add userspace notification to hkey event handler. Note this got
somewhat more complicated tha
Hi Mario
On 8/21/2020 3:15 PM, Limonciello, Mario wrote:
Thanks for adapting a lot of my feedback, this looks much better to me.
No problems and genuinely thank you for the feedback. Sorry it took so
long to get this update out - PTO and other things got in the way :)
+
+The sysfs
On 8/21/2020 4:00 PM, Limonciello, Mario wrote:
+ +The sysfs entry provides the ability to return the current
status and to set
the +desired mode. For example:: + +echo H >
/sys/devices/platform/thinkpad_acpi/dytc_perfmode +echo
M > /sys/devices/platform/thinkpad_acpi/dytc_perfmo
On 8/21/2020 4:43 PM, Limonciello, Mario wrote:
-Original Message- From: Mark Pearson
Sent: Friday, August 21, 2020 15:06
On 8/21/2020 4:00 PM, Limonciello, Mario wrote:
+ +The sysfs entry provides the ability to return the
current status and to set the +desired mode. For example
Thanks Benjamin!
On 9/16/2020 5:31 AM, Benjamin Berg wrote:
Hi Mark,
On Fri, 2020-08-21 at 13:53 -0400, Mark Pearson wrote:
+ H - High performance mode. Maximum power and temperature
available.
+ M* - High performance mode but performance is limited to medium
as
Hi Hans,
On 9/17/2020 7:39 AM, Hans de Goede wrote:
Hi,
On 8/21/20 7:53 PM, Mark Pearson wrote:
Lenovo Thinkpad platforms with DYTC version 5 and newer have enhanced
firmware to provide different performance/thermal modes.
So we recently had another driver show up with almost the same
Thanks Hans
On 18/03/2021 12:49, Hans de Goede wrote:
> Hi,
>
> On 3/15/21 8:58 PM, Esteve Varela Colominas wrote:
>> On many recent ThinkPad laptops, there's a new LED next to the ESC key,
>> that indicates the FnLock status.
>> When the Fn+ESC combo is pressed, FnLock is toggled, which causes t
On 2021-08-12 7:35 a.m., Slark Xiao wrote:
At 2021-08-12 16:03:50, "Hans de Goede" wrote:
Hi,
On 8/11/21 11:34 AM, Slark Xiao wrote:
When WWAN device wake from S3 deep, under thinkpad platform,
WWAN would be disabled. This disable status could be checked
by command 'nmcli r wwan' or 'rfkill
Thanks Jimmy,
On 2021-11-07 21:55, Jimmy Wang wrote:
This adds dual fan control for P1 / X1 Extreme Gen4
Signed-off-by: Jimmy Wang
---
drivers/platform/x86/thinkpad_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/th
Hi Thomas,
On 2021-11-13 05:42, Thomas Weißschuh wrote:
> This adds support for the force-discharge charge_behaviour through the
> embedded controller of ThinkPads.
>
> Signed-off-by: Thomas Weißschuh
>
> ---
>
> This patch is based on
> https://lore.kernel.org/platform-driver-x86/c2504700-06
Hi Thomas,
On 2021-11-13 05:42, Thomas Weißschuh wrote:
> This adds support for the inhibit-charge charge_behaviour through the
> embedded controller of ThinkPads.
>
> Signed-off-by: Thomas Weißschuh
>
> ---
>
> This patch is based on
> https://lore.kernel.org/platform-driver-x86/d2808930-584
Hi Thomas
On 2021-11-16 18:44, Thomas Weißschuh wrote:
> Hi Mark,
>
> On 2021-11-16 15:52-0500, Mark Pearson wrote:
>> On 2021-11-13 05:42, Thomas Weißschuh wrote:
>>> This adds support for the inhibit-charge charge_behaviour through the
>>> embedded controller
OK
>> - Reading: OK
>>
>> - Battery discharging: OK
>> - Disengaging with "auto": OK
>>
>> 2. inhibit-charge
>>
>> Works as expected:
>> - Writing: OK
>>
>> - Disengaging with "auto": OK
>>
>>
>>
Hi Hans
On 2022-01-11 06:09, Hans de Goede wrote:
> Hi David,
>
> On 1/4/22 04:41, David Dreschner wrote:
>> Hey guys,
>>
>> the attached patch updates the list of whitelisted ThinkPad models with dual
>> fan support.
>>
>> The changes were tested on my ThinkPad T15g Gen 2. According to Lenovo,
FW fixes released.
I believe these changes are benign even once the FW is fixed so think
this is a great idea.
I'll push updates removing platform quirks once FW is released though.
Tested-by: Mark Pearson
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
l
> Fixes: bf779aaf56ea ("platform/x86: thinkpad_acpi: Add dual fan probe")
> Cc: Mark Pearson
> Cc: Hans de Goede
> Cc: Henrique de Moraes Holschuh
> Cc: Mark Gross
> Cc: ibm-acpi-devel@lists.sourceforge.net
> Cc: platform-driver-...@vger.kernel.org
> ---
>
On 4/30/22 08:13, Thomas Weißschuh wrote:
> Hi Mark,
>
> On 2022-04-29 21:25-0400, Mark Pearson wrote:
>> Hi Lyude
>>
>> On 4/29/22 17:14, Lyude Paul wrote:
>>> The new method of probing dual fan support introduced in:
>>>
>>> bf779aaf
On 5/2/22 13:42, Lyude Paul wrote:
> Some answers/comments down below
>
> On Fri, 2022-04-29 at 21:25 -0400, Mark Pearson wrote:
>> Hi Lyude
>>
>> On 4/29/22 17:14, Lyude Paul wrote:
>>> The new method of probing dual fan support introduced in:
>>>
&
On 5/2/22 13:44, Mark Pearson wrote:
>
>
> On 5/2/22 13:42, Lyude Paul wrote:
>> Some answers/comments down below
>>
>> On Fri, 2022-04-29 at 21:25 -0400, Mark Pearson wrote:
>>> Hi Lyude
>>>
>>> On 4/29/22 17:14, Lyude Paul wrote:
>>
On 2022-08-19 10:01, Mario Limonciello wrote:
> It was observed that on a Thinkpad T14 Gen1 (AMD) that the platform
> profile is starting up in 'low-power' mode after refreshing what the
> firmware had. This is most likely a firmware bug, but as a harmless
> workaround set the default profile t
On Wed, Sep 13, 2023, at 11:58 AM, Hans de Goede wrote:
> Hi Fernando,
>
> On 9/6/23 21:52, Fernando Eckhardt Valle wrote:
>> Newer Thinkpads have a feature called Mac Address Passthrough.
>> This patch provides a sysfs interface that userspace can use
>> to get this auxiliary mac address.
>>
>
Thanks Hans & Jiri,
On Mon, Sep 25, 2023, at 5:15 AM, Jiri Slaby wrote:
> Hi,
>
> On 25. 09. 23, 10:57, Hans de Goede wrote:
>> Jiri, Thank you for all the debugging you have done on this. Can you please
>> file
>> a bug with the details / summary here:
>>
>> https://bugzilla.kernel.org/enter_bu
Hi Hans
On Mon, Sep 25, 2023, at 4:57 AM, Hans de Goede wrote:
>
> Mark, can you please take a look at this (it is a thinkpad_acpi dytc issue)?
Ack
> Regards,
>
> Hans
>
> p.s.
>
> Mark, maybe should add you to the MAINTAINERS section for thinkpad_acpi ?
Happy to do so if that makes sense and i
struct thinkpad_id_data *tp)
> {
> const struct dmi_device *dev = NULL;
> - char ec_fw_string[18] = {0};
> + char ec_fw_string[EC_FW_STRING_LEN] = {0};
> char const *s;
> char t;
>
>
> ---
> base-commit: dab3e01664eaddae965699f1fec776609db0ea9d
> change-id: 20231019-strncpy-drivers-platform-x86-thinkpad_acpi-c-7a733d087ef7
>
> Best regards,
> --
> Justin Stitt
Looks good to me.
Reviewed-by: Mark Pearson
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Some new Thinkpads have a new improved performance mode available.
Add support to make this mode usable.
To avoid having to create a new profile, just use the improved performance
mode in place of the existing performance mode, when available.
Tested on T14 AMD G4 AMD.
Signed-off-by: Mark
Hi Ilpo,
On Thu, Nov 9, 2023, at 5:10 AM, Ilpo Järvinen wrote:
> On Wed, 8 Nov 2023, Mark Pearson wrote:
>
>> Some new Thinkpads have a new improved performance mode available.
>> Add support to make this mode usable.
>>
>> To avoid having to create a new
Some new Thinkpads have a new improved performance mode available.
Add support to make this mode usable.
To avoid having to create a new profile, just use the improved performance
mode in place of the existing performance mode, when available.
Tested on P14s AMD G4 AMD.
Signed-off-by: Mark
Hi Ilpo
On Fri, Nov 10, 2023, at 7:37 AM, Ilpo Järvinen wrote:
> On Thu, 9 Nov 2023, Mark Pearson wrote:
>> On Thu, Nov 9, 2023, at 5:10 AM, Ilpo Järvinen wrote:
>> > On Wed, 8 Nov 2023, Mark Pearson wrote:
>>
>> >
>> > Looking into the driver a bit
On Mon, Nov 13, 2023, at 9:20 AM, Ilpo Järvinen wrote:
> On Mon, 13 Nov 2023, Mark Pearson wrote:
>
>> Some new Thinkpads have a new improved performance mode available.
>> Add support to make this mode usable.
>>
>> To avoid having to create a new profile, jus
Some new Thinkpads have a new improved performance mode available.
Add support to make this mode usable.
To avoid having to create a new profile, just use the improved performance
mode in place of the existing performance mode, when available.
Tested on P14s AMD G4 AMD.
Signed-off-by: Mark
Thanks Ilpo,
On Mon, Nov 13, 2023, at 11:59 AM, Ilpo Järvinen wrote:
> On Mon, 13 Nov 2023, Mark Pearson wrote:
>
>> Some new Thinkpads have a new improved performance mode available.
>> Add support to make this mode usable.
>>
>> To avoid having to create a new
On Mon, Nov 13, 2023, at 12:15 PM, Mark Pearson wrote:
> Thanks Ilpo,
>
> On Mon, Nov 13, 2023, at 11:59 AM, Ilpo Järvinen wrote:
>> On Mon, 13 Nov 2023, Mark Pearson wrote:
>>
>>> Some new Thinkpads have a new improved performance mode available.
>>&g
Hi Breno,
Thanks for the review!
On Wed, Nov 22, 2023, at 2:44 PM, Breno Leitao wrote:
> On Mon, Nov 13, 2023 at 11:54:33AM -0500, Mark Pearson wrote:
>> @@ -10355,6 +10361,17 @@ static int dytc_profile_set(struct
>> platform_profile_handler *pprof,
>> if (err)
>&g
Hi Randy
On Wed, Dec 6, 2023, at 1:01 AM, Randy Dunlap wrote:
> Add a function's return description and don't misuse "/**" for
> non-kernel-doc comments to prevent warnings from scripts/kernel-doc.
>
> thinkpad_acpi.c:523: warning: No description found for return value of
> 'tpacpi_check_quirks'
On Wed, Dec 6, 2023, at 11:45 AM, Randy Dunlap wrote:
> Hi Mark,
>
> On 12/6/23 07:30, Mark Pearson wrote:
>> Hi Randy
>>
>> On Wed, Dec 6, 2023, at 1:01 AM, Randy Dunlap wrote:
>>> Add a function's return description and don't misuse "/**&q
know.
I will see if I can scrounge some HW from somewhere in the meantime.
I will need to rebase before proposing this officially, so please ignore
the fact that this is based off 6.7-rc1 and therefore a bit out of date.
Signed-off-by: Mark Pearson
---
.../admin-guide/laptops/thinkpad-acpi.rst
Thanks for the review Hans,
On Mon, Jan 8, 2024, at 9:17 AM, Hans de Goede wrote:
> Hi Mark,
>
> On 1/4/24 01:37, Mark Pearson wrote:
>> Looking for feedback if this is a good idea or not, and if I've missed
>> anything important.
>>
>> Over the holidays i
cases. Add a keycode so that we'll be able to provide similar
support on Linux.
Suggested-by: Peter Hutterer
Signed-off-by: Mark Pearson
Signed-off-by: Nitin Joshi
Signed-off-by: Vishnu Sankar
---
include/uapi/linux/input-event-codes.h | 2 ++
1 file changed, 2 insertions(+)
diff --
New Lenovo platforms are adding the FN+N key to generate system debug
details that support can use for collecting important details on any
customer cases for Windows.
Add the infrastructure so we can do the same on Linux by generating a
SYS_DEBUG_INFO keycode to userspace.
Signed-off-by: Mark
The hotkey combination FN+G can be used to disable the trackpoint
doubletap feature on Windows.
Add matching functionality for Linux.
Signed-off-by: Mark Pearson
Signed-off-by: Vishnu Sankar
---
drivers/platform/x86/thinkpad_acpi.c | 24 +---
1 file changed, 17 insertions
Lenovo trackpoints are adding the ability to generate a doubletap event.
This handles the doubletap event and sends the KEY_DOUBLECLICK event to
userspace.
Signed-off-by: Mark Pearson
Signed-off-by: Vishnu Sankar
---
drivers/platform/x86/thinkpad_acpi.c | 17 +
1 file changed
. Any mistakes are ours :)
Features have been tested on Z13 G2 (doubletap & FN+G) and X1 Carbon
G12 (FN+N)
Mark Pearson (4):
Input: Add trackpoint doubletap and system debug info keycodes
platform/x86: thinkpad_acpi: Support for trackpoint doubletap
platform/x86: thinkpad_acpi: Support
Hi Hans,
Many thanks for the review.
On Mon, Apr 8, 2024, at 9:04 AM, Hans de Goede wrote:
> Hi Mark,
>
> On 3/24/24 10:07 PM, Mark Pearson wrote:
>> Lenovo trackpoints are adding the ability to generate a doubletap event.
>> This handles the doubletap event and sends the
Thanks Hans
On Mon, Apr 8, 2024, at 9:11 AM, Hans de Goede wrote:
> Hi,
>
> On 3/24/24 10:08 PM, Mark Pearson wrote:
>> New Lenovo platforms are adding the FN+N key to generate system debug
>> details that support can use for collecting important details on any
>>
Hi Dmitry
On Mon, Apr 8, 2024, at 7:31 PM, Dmitry Torokhov wrote:
> Hi Mark,
>
> On Sun, Mar 24, 2024 at 05:07:58PM -0400, Mark Pearson wrote:
>> Add support for new input events on Lenovo laptops that need exporting to
>> user space.
>>
>> Lenovo trackpoints are
>> > >
>> > > On Sun, Mar 24, 2024 at 05:07:58PM -0400, Mark Pearson wrote:
>> > > > Add support for new input events on Lenovo laptops that need exporting
>> > > > to
>> > > > user space.
>> > > >
>> >
Hi Dmitry,
On Wed, Apr 10, 2024, at 8:02 PM, Dmitry Torokhov wrote:
> On Tue, Apr 09, 2024 at 10:17:05PM -0400, Mark Pearson wrote:
>> Hi Dmitry
>>
>> On Tue, Apr 9, 2024, at 9:20 PM, Dmitry Torokhov wrote:
>> > On Tue, Apr 09, 2024 at 02:47:05PM -0700, Dmitry Tor
Hi
On Mon, Apr 15, 2024, at 3:58 PM, Dmitry Torokhov wrote:
> On Mon, Apr 15, 2024 at 09:50:37PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 4/15/24 9:40 PM, Dmitry Torokhov wrote:
>> > On Wed, Apr 10, 2024 at 10:48:10PM -0400, Mark Pearson wrote:
>> >>
Hi Dmitry,
On Mon, Apr 15, 2024, at 6:54 PM, Dmitry Torokhov wrote:
> On Mon, Apr 15, 2024 at 04:28:19PM -0400, Mark Pearson wrote:
>> Hi
>>
>> On Mon, Apr 15, 2024, at 3:58 PM, Dmitry Torokhov wrote:
>> > On Mon, Apr 15, 2024 at 09:50:37PM +0200, Hans de Goede wrot
Hi Hans
On Tue, Apr 16, 2024, at 4:33 AM, Hans de Goede wrote:
> Hi Mark,
>
> On 4/16/24 1:57 AM, Mark Pearson wrote:
>> Hi Dmitry,
>>
>> On Mon, Apr 15, 2024, at 6:54 PM, Dmitry Torokhov wrote:
>>> On Mon, Apr 15, 2024 at 04:28:19PM -0400, Mark Pearson wro
Modify how known_ev event is handled in preparation for adding new keycode
range.
Signed-off-by: Mark Pearson
---
Changes in v2:
- New addition to series based on recommendations from review.
- Note previous input patch was dropped so in numbering gets replaced by this.
drivers/platform/x86
New Lenovo platforms are adding the FN+N key to generate system debug
details that support can use for collecting important details on any
customer cases for Windows.
Add the infrastructure so we can do the same on Linux by generating a
SYS_VENDOR keycode to userspace.
Signed-off-by: Mark Pearson
The hotkey combination FN+G can be used to disable the trackpoint
doubletap feature on Windows.
Add matching functionality for Linux.
Signed-off-by: Mark Pearson
Signed-off-by: Vishnu Sankar
---
Changes in v2:
- Improved comments on keycodes in init function
drivers/platform/x86
Lenovo trackpoints are adding the ability to generate a doubletap event.
This handles the doubletap event and sends the KEY_PROG1 event to
userspace.
Signed-off-by: Mark Pearson
Signed-off-by: Vishnu Sankar
---
Changes in v2:
- Use KEY_PROG1 instead of KEY_DOUBLETAP as input maintainer doesn&#
Hi Hans,
On Wed, Apr 17, 2024, at 4:06 PM, Hans de Goede wrote:
> Hi Mark,
>
> On 4/17/24 9:39 PM, Hans de Goede wrote:
>> Hi Mark,
>>
>> Thank you for the new version of this series, overall this looks good,
>> one small remark below.
>>
>> On 4/
Hi Hans,
On Thu, Apr 18, 2024, at 7:34 AM, Hans de Goede wrote:
> Hi Mark,
>
> On 4/18/24 1:57 AM, Mark Pearson wrote:
>> Hi Hans,
>>
>> On Wed, Apr 17, 2024, at 4:06 PM, Hans de Goede wrote:
>>> Hi Mark,
>>>
>>> On 4/17/24 9:39 PM, Hans de
Hi Hans
On Thu, Apr 18, 2024, at 10:42 AM, Hans de Goede wrote:
> Hi,
>
> On 4/18/24 2:24 PM, Mark Pearson wrote:
>> Hi Hans,
>>
>> On Thu, Apr 18, 2024, at 7:34 AM, Hans de Goede wrote:
>>> Hi Mark,
>>>
>>> On 4/18/24 1:57 AM, Mark Pearson w
pacpi_driver_event() call to
> tpacpi_input_send_key()
> platform/x86: thinkpad_acpi: Do not send ACPI netlink events for
> unknown hotkeys
> platform/x86: thinkpad_acpi: Change hotkey_reserved_mask
> initialization
> platform/x86: thinkpad_acpi: Use correct keycode
On Sun, Apr 21, 2024, at 1:17 PM, Mark Pearson wrote:
> Thanks Hans!
>
> On Sun, Apr 21, 2024, at 11:44 AM, Hans de Goede wrote:
>> Hi All,
>>
>> My reply in the "[PATCH v2 1/4] platform/x86: thinkpad_acpi:
>> simplify known_ev handling" handlin
Hi Hans,
On Sun, Apr 21, 2024, at 11:45 AM, Hans de Goede wrote:
> Factor out the adaptive kbd non hotkey event handling into
> adaptive_keyboard_change_row() and adaptive_keyboard_s_quickview_row()
> helpers and move the handling of TP_HKEY_EV_DFR_CHANGE_ROW and
> TP_HKEY_EV_DFR_S_QUICKVIEW_ROW t
Hi Hans
On Tue, Apr 23, 2024, at 4:35 AM, Hans de Goede wrote:
> Hi Mark,
>
> On 4/22/24 9:27 PM, Mark Pearson wrote:
>> Hi Hans,
>>
>> On Sun, Apr 21, 2024, at 11:45 AM, Hans de Goede wrote:
>>> Factor out the adaptive kbd non hotkey event handling into
&g
Hi Hans,
On Wed, Apr 24, 2024, at 8:28 AM, Hans de Goede wrote:
> Change the hotkey_reserved_mask initialization to hardcode the list
> of reserved keys. There are only a few reserved keys and the code to
> iterate over the keymap will be removed when moving to sparse-keymaps.
>
>
On Wed, Apr 24, 2024, at 10:47 AM, Hans de Goede wrote:
> Hi Mark,
>
> On 4/24/24 4:17 PM, Mark Pearson wrote:
>> Hi Hans,
>>
>> On Wed, Apr 24, 2024, at 8:28 AM, Hans de Goede wrote:
>>> Change the hotkey_reserved_mask initialization to hardcode the list
&g
Hi Hans,
On Wed, Apr 24, 2024, at 8:28 AM, Hans de Goede wrote:
> From: Mark Pearson
>
> Lenovo trackpoints are adding the ability to generate a doubletap event.
> This handles the doubletap event and sends the KEY_PROG4 event to
> userspace. Despite the driver itself not
gt; platform/x86: thinkpad_acpi: Do not send ACPI netlink events for
> unknown hotkeys
> platform/x86: thinkpad_acpi: Change hotkey_reserved_mask
> initialization
> platform/x86: thinkpad_acpi: Use correct keycodes for volume and
> brightness keys
> platform/x86
On Mon, Apr 29, 2024, at 5:57 AM, Hans de Goede wrote:
> Hi Mark,
>
> On 4/24/24 8:19 PM, Mark Pearson wrote:
>> Hi Hans,
>>
>> On Wed, Apr 24, 2024, at 8:28 AM, Hans de Goede wrote:
>>> From: Mark Pearson
>>>
>>> Lenovo trackpoint
Hi Pellaeon,
On Mon, Jun 3, 2024, at 7:46 AM, Pellaeon Lin wrote:
> Hi,
>
> I have a ThinkPad X13 Gen 2 AMD with PrivacyGuard. But by pressing the
> combination key Fn+D it does not toggle the PrivacyGuard, the PrivacyGuard
> stays on. I've tested:
>
> - Fn+D does toggle PrivacyGuard when I'm in t
On Mon, Oct 28, 2024, at 1:35 PM, Mario Limonciello wrote:
> On 10/28/2024 12:20, Mark Pearson wrote:
>> Thanks Mario,
>>
>> On Mon, Oct 28, 2024, at 10:10 AM, Mario Limonciello wrote:
>>> On 10/28/2024 06:01, Mark Pearson wrote:
>>>> Hi Mario,
>>
elete mode 100644 drivers/platform/x86/amd/pmf/pmf-quirks.c
>
>
> base-commit: d68cb6023356af3bd3193983ad4ec03954a0b3e2
> --
> 2.43.0
For the series - I tried it out on my T14s G6 AMD, and it all looks to be
working nicely and as expected.
The thinkpad-acpi and amd-pmf classes sh
Hi Mario,
On Tue, Nov 5, 2024, at 10:33 AM, Mario Limonciello wrote:
> The class interface allows changing multiple platform profiles on a system
> to different values. The semantics of it are similar to the legacy
> interface.
>
> Signed-off-by: Mario Limonciello
> ---
> .../userspace-api/sysfs
On Thu, Oct 31, 2024, at 4:55 PM, Armin Wolf wrote:
> Am 31.10.24 um 05:09 schrieb Mario Limonciello:
>
>> The "platform_profile" class device has the exact same semantics as the
>> platform profile files in /sys/firmware/acpi/ but it reflects values only
>> present for a single platform profile
pacpi_dytc_profile_init(struct
> ibm_init_struct *iibm)
> dbg_printk(TPACPI_DBG_INIT,
> "DYTC version %d: thermal mode available\n",
> dytc_version);
>
> + dytc_profile.dev = &tpacpi_pdev->dev;
> /* Create platform_profile structure and register */
> err = platform_profile_register(&dytc_profile);
> /*
> diff --git a/include/linux/platform_profile.h
> b/include/linux/platform_profile.h
> index 6fa988e417428..daec6b9bad81f 100644
> --- a/include/linux/platform_profile.h
> +++ b/include/linux/platform_profile.h
> @@ -28,6 +28,7 @@ enum platform_profile_option {
>
> struct platform_profile_handler {
> const char *name;
> + struct device *dev;
> unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
> int (*profile_get)(struct platform_profile_handler *pprof,
> enum platform_profile_option *profile);
> --
> 2.43.0
Looks good to me.
Reviewed-by: Mark Pearson
Mark
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
On Thu, Oct 31, 2024, at 12:09 AM, Mario Limonciello wrote:
> If multiple platform profile handlers have been registered, don't allow
> switching to profiles unique to only one handler.
>
> Tested-by: Matthew Schwartz
> Signed-off-by: Mario Limonciello
> ---
> drivers/acpi/platform_profile.c | 3
> - err = cur_profile->profile_get(cur_profile, &profile);
> + err = platform_profile_get_active(&profile);
> if (err)
> return err;
> }
>
> - /* Check that profile is valid inde
gt; + sysfs_notify(acpi_kobj, NULL, "platform_profile");
> + return 0;
> }
> EXPORT_SYMBOL_GPL(platform_profile_cycle);
>
> --
> 2.43.0
For patches 8 to 11 - Looks good to me (guards are new to me - I had to go read
up on them. Very cool and a nice clean-up)
Reviewed-by: Mark Pearson
Mark
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
*/
> - if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) ||
> - !pprof->profile_set || !pprof->profile_get) {
> - mutex_unlock(&profile_lock);
> - return -EINVAL;
> - }
> -
> err = sysfs_create_
gt; PLATFORM_PROFILE_BALANCED,
> PLATFORM_PROFILE_BALANCED_PERFORMANCE,
> PLATFORM_PROFILE_PERFORMANCE,
> + PLATFORM_PROFILE_CUSTOM,
> PLATFORM_PROFILE_LAST, /*must always be last */
> };
>
> --
> 2.43.0
Looks good to me.
Reviewed-by: Mark Pearson
Mark
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
= NULL;
> +
> + sysfs_notify(acpi_kobj, NULL, "platform_profile");
> if (!platform_profile_is_registered())
> sysfs_remove_group(acpi_kobj, &platform_profile_group);
>
> --
> 2.43.0
Looks good to me.
Reviewed-by: Mark Pearson
Mark
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
On Thu, Oct 31, 2024, at 12:09 AM, Mario Limonciello wrote:
> As multiple platform profile handlers might not all support the same
> profile, cycling to the next profile could have a different result
> depending on what handler are registered.
>
> Check what is active and supported by all handlers
1 - 100 of 148 matches
Mail list logo
