[infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread William Burns
Recently while working on some ISPN 7 features, there were some public API inconsistencies. I wanted to bring these up just in case if someone had concerns. The first few are pretty trivial, but can cause compilation errors between versions if user code implements these interfaces and defines

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread Pedro Ruivo
Hi, #1 and #2 are ok to me but, IMO, the filter package should be in commons module Cheers, Pedro On 03/13/2014 12:07 PM, William Burns wrote: Recently while working on some ISPN 7 features, there were some public API inconsistencies. I wanted to bring these up just in case if someone had

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread William Burns
On Thu, Mar 13, 2014 at 8:31 AM, Pedro Ruivo pe...@infinispan.org wrote: Hi, #1 and #2 are ok to me but, IMO, the filter package should be in commons module Sorry I forgot to detail why I said core. I originally planned for commons package as well, however the KeyValueFilter class needs the

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread Pedro Ruivo
On 03/13/2014 12:35 PM, William Burns wrote: On Thu, Mar 13, 2014 at 8:31 AM, Pedro Ruivo pe...@infinispan.org wrote: Hi, #1 and #2 are ok to me but, IMO, the filter package should be in commons module Sorry I forgot to detail why I said core. I originally planned for commons package as

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread William Burns
On Thu, Mar 13, 2014 at 8:37 AM, Pedro Ruivo pe...@infinispan.org wrote: On 03/13/2014 12:35 PM, William Burns wrote: On Thu, Mar 13, 2014 at 8:31 AM, Pedro Ruivo pe...@infinispan.org wrote: Hi, #1 and #2 are ok to me but, IMO, the filter package should be in commons module Sorry I

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread Sanne Grinovero
Is there a migration guide? This should be documented in some wiki page similar to - https://community.jboss.org/wiki/HibernateSearchMigrationGuide On 13 March 2014 12:45, William Burns mudokon...@gmail.com wrote: On Thu, Mar 13, 2014 at 8:37 AM, Pedro Ruivo pe...@infinispan.org wrote: On

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread Mircea Markus
On Mar 13, 2014, at 12:45, William Burns mudokon...@gmail.com wrote: On Thu, Mar 13, 2014 at 8:37 AM, Pedro Ruivo pe...@infinispan.org wrote: On 03/13/2014 12:35 PM, William Burns wrote: On Thu, Mar 13, 2014 at 8:31 AM, Pedro Ruivo pe...@infinispan.org wrote: Hi, #1 and #2 are ok to

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread Vladimir Blagojevic
Mircea and I wanted to promote AdvancedCacheLoader.KeyFilter or merge it with one filter we all choose to use because we have so many of these internal filter classes it is ridiculous. The filter you wrote is THE one? Vladimir On 3/13/2014, 8:35 AM, William Burns wrote: On Thu, Mar 13, 2014 at

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread William Burns
On Thu, Mar 13, 2014 at 11:14 AM, Vladimir Blagojevic vblag...@redhat.com wrote: Mircea and I wanted to promote AdvancedCacheLoader.KeyFilter or merge it with one filter we all choose to use because we have so many of these internal filter classes it is ridiculous. The filter you wrote is THE

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread Vladimir Blagojevic
On 3/13/2014, 11:39 AM, William Burns wrote: On Thu, Mar 13, 2014 at 11:14 AM, Vladimir Blagojevic vblag...@redhat.com wrote: Mircea and I wanted to promote AdvancedCacheLoader.KeyFilter or merge it with one filter we all choose to use because we have so many of these internal filter classes

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread William Burns
On Thu, Mar 13, 2014 at 11:54 AM, Vladimir Blagojevic vblag...@redhat.com wrote: On 3/13/2014, 11:39 AM, William Burns wrote: On Thu, Mar 13, 2014 at 11:14 AM, Vladimir Blagojevic vblag...@redhat.com wrote: Mircea and I wanted to promote AdvancedCacheLoader.KeyFilter or merge it with one

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread William Burns
On Thu, Mar 13, 2014 at 10:25 AM, Sanne Grinovero sa...@infinispan.org wrote: Is there a migration guide? This should be documented in some wiki page similar to - https://community.jboss.org/wiki/HibernateSearchMigrationGuide I have created https://issues.jboss.org/browse/ISPN-4109 to address

Re: [infinispan-dev] Proposed ISPN 7 compilation incompatibilities with ISPN 6

2014-03-13 Thread Dan Berindei
On Thu, Mar 13, 2014 at 5:58 PM, William Burns mudokon...@gmail.com wrote: On Thu, Mar 13, 2014 at 11:54 AM, Vladimir Blagojevic vblag...@redhat.com wrote: On 3/13/2014, 11:39 AM, William Burns wrote: On Thu, Mar 13, 2014 at 11:14 AM, Vladimir Blagojevic vblag...@redhat.com wrote: