Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is not restored

2011-11-16 Thread Takashi Iwai
At Tue, 15 Nov 2011 13:54:44 -0800, Kamal Mostafa wrote: On Tue, 2011-11-15 at 21:28 +0100, Takashi Iwai wrote: My rough guess is the inconsistency of property taken during the backlight disabled. How about the patch below (untested!) in addition to the fix in 3.2? Takashi Yes

[Intel-gfx] [PATCH] drm/i915: Fix inconsistent backlight level during disabled

2011-11-16 Thread Takashi Iwai
When the brightness property is inquired while the backlight is disabled, the driver returns a wrong value (zero) because it probes the value after the backlight was turned off. This caused a black screen even after the backlight is enabled again. It should return the internal backlight_level

Re: [Intel-gfx] [PATCH 2/2 v2] hda - delayed ELD repoll

2011-11-16 Thread Paul Menzel
Dear Fengguang, Am Mittwoch, den 16.11.2011, 00:57 +0800 schrieb Wu Fengguang: The Intel HDMI chips (ironlake at least) are found to have ~250ms delay between the ELD_Valid=1 hotplug event is send and the ELD buffer becomes actually readable. During the time the ELD buffer is mysteriously all

Re: [Intel-gfx] [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user

2011-11-16 Thread Michel Alexandre Salim
Hi Keith, That patch is still not in 3.2-rc2, drm-intel-fixes or drm-intel-next. I've been using it successfully on i915 (both SSC-blacklisted and not) and non-i915 machines; feel free to set the Tested-by and Reviewed-by tags. Thanks, -- Michel On 11/09/2011 07:07 PM, Keith Packard wrote:

[Intel-gfx] [PATCH 0/3] HDMI ELD fixes for 3.2

2011-11-16 Thread Wu Fengguang
Keith, Here are 3 fixes on HDMI/ELD audio. The third one adds a -hot_remove hook to drm_connector_funcs. Please review. [PATCH 1/3] drm/i915: fix ELD writing for SandyBridge [PATCH 2/3] drm/i915: dont trigger hotplug events on unchanged ELD [PATCH 3/3] drm/i915: hot removal notification to HDMI

[Intel-gfx] [PATCH 2/3] drm/i915: dont trigger hotplug events on unchanged ELD

2011-11-16 Thread Wu Fengguang
The ELD may or may not change when switching the video mode. If unchanged, don't trigger hot plug events to HDMI audio driver. This avoids disturbing the user with repeated printks. Reported-by: Nick Bowler nbow...@elliptictech.com Signed-off-by: Wu Fengguang fengguang...@intel.com ---

[Intel-gfx] [PATCH 1/3] drm/i915: fix ELD writing for SandyBridge

2011-11-16 Thread Wu Fengguang
SandyBridge should be using the same register addresses as IvyBridge. Signed-off-by: Wu Fengguang fengguang...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |6 +++--- drivers/gpu/drm/i915/intel_display.c | 10 +- 2 files changed, 8 insertions(+), 8 deletions(-) ---

[Intel-gfx] [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
On monitor hot removal: 1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE 2) clear ELD Valid bit So that the audio driver will receive hot plug events and take action to refresh its device state and ELD contents. cc: Wang Zhenyu zhenyu.z.w...@intel.com Signed-off-by: Wu Fengguang

Re: [Intel-gfx] [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
Sorry forgot to remove this left over chunk... Note that I've not yet got the hardware to test the DisplayPort part of this patch, but should be able to do so this week. --- linux.orig/drivers/gpu/drm/i915/intel_drv.h 2011-11-16 20:54:27.0 +0800 +++

[Intel-gfx] [PATCH 3/3 v2] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
On monitor hot removal: 1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE 2) clear ELD Valid bit So that the audio driver will receive hot plug events and take action to refresh its device state and ELD contents. cc: Wang Zhenyu zhenyu.z.w...@intel.com Signed-off-by: Wu Fengguang

[Intel-gfx] [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Matthew Garrett
The drm core currently waits 5 seconds from userspace dropping a request for vblanks to vblanks actually being disabled. This appears to be a workaround for broken hardware, but results in a mostly idle desktop generating a huge number of wakeups that are entirely unnecessary but which consume

[Intel-gfx] [RFC 2/3] drm: Handle the vblank_offdelay=0 case properly

2011-11-16 Thread Matthew Garrett
Right now if vblank_offdelay is 0, vblanks won't be disabled after the last user. Fix that case up. Signed-off-by: Matthew Garrett m...@redhat.com --- drivers/gpu/drm/drm_irq.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c

[Intel-gfx] [RFC 3/3] i915: Drop vblank_offdelay

2011-11-16 Thread Matthew Garrett
Sandybridge, at least, seems to manage without any vblank offdelay. Dropping this reduces the number of wakeups on an otherwise idle system dramatically. Signed-off-by: Matthew Garrett m...@redhat.com --- drivers/gpu/drm/i915/i915_dma.c |3 +++ 1 files changed, 3 insertions(+), 0

Re: [Intel-gfx] [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Adam Jackson
On Wed, 2011-11-16 at 09:20 -0500, Matthew Garrett wrote: The drm core currently waits 5 seconds from userspace dropping a request for vblanks to vblanks actually being disabled. This appears to be a workaround for broken hardware, but results in a mostly idle desktop generating a huge number

[Intel-gfx] How to disable the internal graphics device of Q45 for lower power consumption

2011-11-16 Thread joseph wang
Hi all, I wonder if there is a way to disable or power off the built-in graphics device that is integrated in chipset if it is not used for most of the time, for instance, on servers. What I have tried is, experiment on Q45 chipset, set bit 3 and 4 of register 'deven' at offset 54-57h in the PCI

Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default

2011-11-16 Thread Daniel Vetter
On Mon, Nov 14, 2011 at 21:39, Eugeni Dodonov eugeni.dodo...@intel.com wrote: Semaphores seem to fix most of the hangs on SNB and IVB, and do not cause any known regressions as of now. Let's re-enable them by default to provide a wider testing and coverage. Acked-by: Keith Packard

Re: [Intel-gfx] [PATCH 2/2] drm/i915: re-enable rc6 by default

2011-11-16 Thread Daniel Vetter
On Mon, Nov 14, 2011 at 21:39, Eugeni Dodonov eugeni.dodo...@intel.com wrote: Most of the rc6-related hangs and major issues were addressed for the past months. Let's re-enable it by default to provide a more wider testing, and catch the remaining problems. According to tests, enablement of

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-16 Thread Takashi Iwai
At Wed, 16 Nov 2011 07:51:28 -0800, Stephen Warren wrote: 250mS almost sounds like it's setting ELDV in the audio HW, then going and reading the EDID, then writing the EDID to the audio HW; perhaps the graphics driver is accidentally setting PRESENT+ELDV when it's meant to be setting

Re: [Intel-gfx] [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v2

2011-11-16 Thread Daniel Vetter
On Mon, Nov 14, 2011 at 21:22, Jesse Barnes jbar...@virtuousgeek.org wrote: The video sprites support various video surface formats natively and can handle scaling as well.  So add support for them using the new DRM core sprite support functions. v2: use drm specific fourcc header and defines

Re: [Intel-gfx] [PATCH 3/3] drm/i915: track sprite coverage and disable primary plane if possible

2011-11-16 Thread Daniel Vetter
On Mon, Nov 14, 2011 at 21:22, Jesse Barnes jbar...@virtuousgeek.org wrote: To save power when the sprite is full screen, we can disable the primary plane on the same pipe.  Track the sprite status and enable/disable the primary opportunistically. Signed-off-by: Jesse Barnes Imo the

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add destination color key support

2011-11-16 Thread Daniel Vetter
On Mon, Nov 14, 2011 at 21:22, Jesse Barnes jbar...@virtuousgeek.org wrote: Add new ioctls for getting and setting the current destination color key.  This allows for simple overlay display control by matching a color key value in the primary plane before blending the overlay on top.

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-16 Thread Takashi Iwai
At Wed, 16 Nov 2011 08:12:04 -0800, Stephen Warren wrote: Takashi Iwai wrote at Wednesday, November 16, 2011 8:58 AM: At Wed, 16 Nov 2011 07:51:28 -0800, Stephen Warren wrote: ... [ 424.263258] HDMI hot plug event: Codec=3 Pin=6 Presence_Detect=1 ELD_Valid=0 That line makes

Re: [Intel-gfx] [PATCH 3/3] drm/i915: track sprite coverage and disable primary plane if possible

2011-11-16 Thread Jesse Barnes
On Wed, 16 Nov 2011 17:05:50 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Mon, Nov 14, 2011 at 21:22, Jesse Barnes jbar...@virtuousgeek.org wrote: To save power when the sprite is full screen, we can disable the primary plane on the same pipe.  Track the sprite status and enable/disable the

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add destination color key support

2011-11-16 Thread Jesse Barnes
On Wed, 16 Nov 2011 17:10:53 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Mon, Nov 14, 2011 at 21:22, Jesse Barnes jbar...@virtuousgeek.org wrote: Add new ioctls for getting and setting the current destination color key.  This allows for simple overlay display control by matching a color

[Intel-gfx] [PATCH] drm/i915: Fix invalid backpanel values for GEN3 or older chips

2011-11-16 Thread Takashi Iwai
While refactoring of backlight control code in commit [a95735569: drm/i915: Refactor panel backlight controls], the handling of the bit 0 of duty-cycle was gone except for pineview. This resulted in invalid register values for old chips like 915GM. When the bit 0 is set, the backlight is turned

Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default

2011-11-16 Thread Keith Packard
On Wed, 16 Nov 2011 16:49:40 +0100, Daniel Vetter daniel.vet...@ffwll.ch wrote: So we need to check whether DMAR is enabled (on the entire system, i.e. the variable exported for the ilk workaround is not good enough) Can you figure out what *would* be sufficient? Getting semaphores turned on

Re: [Intel-gfx] [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Matthew Garrett
On Wed, Nov 16, 2011 at 06:03:15PM +0100, Michel Dänzer wrote: I thought the main reason for the delay wasn't broken hardware but to avoid constantly ping-ponging the vblank IRQ between on and off with apps which regularly neeed the vblank counter value, as that could make the counter

Re: [Intel-gfx] [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Andrew Lutomirski
2011/11/16 Matthew Garrett mj...@srcf.ucam.org: On Wed, Nov 16, 2011 at 06:03:15PM +0100, Michel Dänzer wrote: I thought the main reason for the delay wasn't broken hardware but to avoid constantly ping-ponging the vblank IRQ between on and off with apps which regularly neeed the vblank

Re: [Intel-gfx] [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Matthew Garrett
On Wed, Nov 16, 2011 at 07:27:51PM +0100, Mario Kleiner wrote: It's not broken hardware, but fast ping-ponging it on and off can make the vblank counter and vblank timestamps unreliable for apps that need high timing precision, especially for the ones that use the OML_sync_control extensions

Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default

2011-11-16 Thread Eugeni Dodonov
On Wed, Nov 16, 2011 at 15:24, Andrew Lutomirski l...@mit.edu wrote: AFAICT my snb laptop has always been stable with semaphores and VT-d enabled. Is this problem possibly restricted to just desktop machines? I'm happy to test, since my box that can reproduce the hang instantly is still

Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default

2011-11-16 Thread Jesse Barnes
On Wed, 16 Nov 2011 17:05:37 -0200 Eugeni Dodonov eug...@dodonov.net wrote: On Wed, Nov 16, 2011 at 15:24, Andrew Lutomirski l...@mit.edu wrote: AFAICT my snb laptop has always been stable with semaphores and VT-d enabled. Is this problem possibly restricted to just desktop machines?

Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default

2011-11-16 Thread Daniel Vetter
On Wed, Nov 16, 2011 at 18:16, Keith Packard kei...@keithp.com wrote: On Wed, 16 Nov 2011 16:49:40 +0100, Daniel Vetter daniel.vet...@ffwll.ch wrote: So we need to check whether DMAR is enabled (on the entire system, i.e. the variable exported for the ilk workaround is not good enough)

Re: [Intel-gfx] [PATCH 2/2] drm/i915: re-enable rc6 by default

2011-11-16 Thread Daniel Vetter
On Wed, Nov 16, 2011 at 16:59, Andrew Lutomirski a...@luto.us wrote: On Nov 16, 2011 7:54 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Mon, Nov 14, 2011 at 21:39, Eugeni Dodonov eugeni.dodo...@intel.com wrote: Most of the rc6-related hangs and major issues were addressed for the

Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default

2011-11-16 Thread Nicolas Kalkhof
Not quite. On my i7 2620M (Lenovo T420) the gpu frequently hangs when decoding videos (vaapi) and running OpenGL apps/games at the same time. Disabling iommu makes my system relatively stable even with rc6 enabled. I haven't played with the semaphores however. -- Nic -Ursprüngliche

Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default

2011-11-16 Thread Daniel Vetter
On Wed, Nov 16, 2011 at 21:56, Nicolas Kalkhof nkalk...@web.de wrote: Not quite. On my i7 2620M (Lenovo T420) the gpu frequently hangs when decoding videos (vaapi) and running OpenGL apps/games at the same time. Disabling iommu makes my system relatively stable even with rc6 enabled. I

Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default

2011-11-16 Thread Keith Packard
On Wed, 16 Nov 2011 21:18:13 +0100, Daniel Vetter daniel.vet...@ffwll.ch wrote: Last time I've played around with all the combinations, only intel_iommu=off was good enough to prevent the hang. intel_iommu=igd_off still hangs (which is what the current value exported by the dmar code dopends

Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default

2011-11-16 Thread Keith Packard
On Wed, 16 Nov 2011 21:56:37 +0100 (CET), Nicolas Kalkhof nkalk...@web.de wrote: Not quite. On my i7 2620M (Lenovo T420) the gpu frequently hangs when decoding videos (vaapi) and running OpenGL apps/games at the same time. Disabling iommu makes my system relatively stable even with rc6

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-16 Thread Wu Fengguang
On Wed, Nov 16, 2011 at 11:51:28PM +0800, Stephen Warren wrote: Wu Fengguang wrote at Tuesday, November 15, 2011 7:48 PM: On Wed, Nov 16, 2011 at 02:25:00AM +0800, Stephen Warren wrote: Wu Fengguang wrote at Tuesday, November 15, 2011 7:33 AM: The Intel HDMI chips (ironlake at least) are

[Intel-gfx] [Mesa-dev] Mesa/Gallium overall design

2011-11-16 Thread Allen Leinwand
In a posting to intel-gfx on Mon Apr 12 10:12:12 PDT 2010, Jesse Barnes gave several reasons why the Intel Mesa drivers team was not supporting the Gallium drivers at that time. Here is an excerpt from that email: Moving to Gallium would be a huge effort for us. We've invested a lot into

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-16 Thread Wu Fengguang
Below is the dmesg representing a video mode set. ELD writes from the graphics driver [ 424.254958] [drm:intel_write_eld], ELD on [CONNECTOR:12:HDMI-A-2], [ENCODER:11:TMDS-11] [ 424.257670] [drm:ironlake_write_eld], ELD on pipe B [ 424.259833]

[Intel-gfx] [ANNOUNCE] xf86-video-intel 2.17.0

2011-11-16 Thread Chris Wilson
A few months have passed, and we have accumulated a surprising number of bug fixes. Oops! We would strongly encourage everyone to upgrade. -Chris Bugs fixed in this release (compared to 2.16.0) --- * Video clobbering composite batch state

[Intel-gfx] [PATCH 1/3] drm/i915: support for per-device semaphores settings

2011-11-16 Thread Eugeni Dodonov
This allows to enable semaphores by default on devices which support them. By default, let's enable them on IVB only for now. When DMAR issues on SNB will be solved, we can enable them on SNB as well. For IVB, it should fix many hangs and issues. Bugzilla:

[Intel-gfx] [PATCH 2/3] drm/i915: allow semaphores on SNB if DMAR is disabled

2011-11-16 Thread Eugeni Dodonov
Semaphores cause issues when DMAR is enabled. So if we are set to per-chip default, and we are on SNB, we can enable semaphores as long as SMAR is disabled. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_drv.c|2 ++

[Intel-gfx] [PATCH 3/3] drm/i915: re-enable rc6 by default when GMAR is disabled

2011-11-16 Thread Eugeni Dodonov
Most of the rc6-related hangs and major issues were addressed for the past months. Let's re-enable it by default to provide a more wider testing, and catch the remaining problems. According to tests, enablement of rc6 results in up to +50% improvements in power usage and battery life, so it

[Intel-gfx] [PATCH] drm/i915: Hook up Ivybridge eDP

2011-11-16 Thread Keith Packard
The Ivybridge eDP control register looks like a cross between a Cougarpoint PCH DP control register and a Sandybridge eDP control register. Where things trivially match, share the code. Where there are any tricky bits, just split things out into two obviously separate code paths. Signed-off-by:

Re: [Intel-gfx] [PATCH 3/3] drm/i915: re-enable rc6 by default when GMAR is disabled

2011-11-16 Thread Ben Widawsky
On Wed, Nov 16, 2011 at 10:17:55PM -0200, Eugeni Dodonov wrote: Most of the rc6-related hangs and major issues were addressed for the past months. Let's re-enable it by default to provide a more wider testing, and catch the remaining problems. According to tests, enablement of rc6 results

Re: [Intel-gfx] [PATCH 2/3] drm/i915: allow semaphores on SNB if DMAR is disabled

2011-11-16 Thread Ben Widawsky
On Wed, Nov 16, 2011 at 10:17:54PM -0200, Eugeni Dodonov wrote: Semaphores cause issues when DMAR is enabled. So if we are set to per-chip default, and we are on SNB, we can enable semaphores as long as SMAR is disabled. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com See my response

Re: [Intel-gfx] [PATCH 0/2] Introduce Glamor to UXA framework.

2011-11-16 Thread Chris Wilson
On Wed, 16 Nov 2011 15:04:35 +0800, Zhigang Gong zhigang.g...@linux.intel.com wrote: This patchset initially enable glamor with UXA. And two functions ,fill_spans and poly_fill_rects, go to the glamor path. I tested it with render check, and it works fine. I split your patches slightly

Re: [Intel-gfx] [PATCH 0/2] Introduce Glamor to UXA framework.

2011-11-16 Thread Zhigang Gong
-Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Thursday, November 17, 2011 9:14 AM To: Zhigang Gong; intel-gfx@lists.freedesktop.org Cc: zhigang.g...@linux.intel.com Subject: Re: [PATCH 0/2] Introduce Glamor to UXA framework. On Wed, 16 Nov 2011

Re: [Intel-gfx] [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Andrew Lutomirski
On Wed, Nov 16, 2011 at 6:19 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Nov 17, 2011 at 01:26:37AM +0100, Mario Kleiner wrote: On Nov 16, 2011, at 7:48 PM, Matthew Garrett wrote: For Radeon, I'd have thought you could handle this by scheduling an irq for the beginning of scanout

Re: [Intel-gfx] [PATCH 3/3] drm/i915: re-enable rc6 by default when GMAR is disabled

2011-11-16 Thread Ben Widawsky
On Wed, 16 Nov 2011 22:11:06 -0800 keith.pack...@intel.com wrote: On Wed, 16 Nov 2011 16:56:16 -0800, Ben Widawsky b...@bwidawsk.net wrote: The variable you want is: !intel_iommu_gfx_mapped From what Daniel Vetter said: Last time I've played around with all the combinations, only