On Thu, Mar 07, 2013 at 12:26:23AM +0100, Daniel Vetter wrote:
> On Wed, Mar 06, 2013 at 08:03:10PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni
> >
> > It returns true if we're not supposed to touch the registers on the
> > power down well.
> >
> > For now there's just one caller, but I'm
On Wed, Mar 06, 2013 at 08:03:11PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> This solves some "unclaimed register" messages when booting the
> machine with eDP attached.
>
> Signed-off-by: Paulo Zanoni
> ---
> drivers/gpu/drm/i915/intel_display.c |6 --
> 1 file changed, 4 in
On Wed, Mar 06, 2013 at 08:03:10PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> It returns true if we're not supposed to touch the registers on the
> power down well.
>
> For now there's just one caller, but I'm going to add more.
>
> Signed-off-by: Paulo Zanoni
> ---
> drivers/gpu/drm
On Wed, Mar 06, 2013 at 08:03:16PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> So don't read it when capturing the error state. This solves
> "unclaimed register" messages on Haswell when we have a GPU hang.
>
> Signed-off-by: Paulo Zanoni
Iirc pipestat exists on vlv, so I think this n
From: Paulo Zanoni
To avoid this:
[ 256.798060] [drm] capturing error event; look for more information
in/sys/kernel/debug/dri/0/i915_error_state
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_irq.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/
From: Paulo Zanoni
This fixes "unclaimed register" messages when the power well is
disabled and there's a GPU hang.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_irq.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i
From: Paulo Zanoni
Because the register does not exist on LPT. The interesting fact is
that reading/writing PCH_LVDS on LPT does *not* give us "unclaimed
register" messages, but the register value is always 0.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_suspend.c |7 ---
From: Paulo Zanoni
Now it returns false for all platforms unless they're explicitly
listed on the function. There should be no real difference, except for
the fact that it now returns false on Haswell.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_lvds.c | 10 +-
1 file
From: Paulo Zanoni
We're starting to add many IS_HASWELL checks for the power well code,
so add a HAS_POWER_WELL macro to properly document that we're checking
for hardware that has the power down well.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/
From: Paulo Zanoni
This solves many "unclaimed register" messages when the power well is
down and we get a GPU hang.
Also print the power well register and each pipe's CPU transcoder on
the error state to allow proper interpratation of the registers. And
kzalloc the error state structure since w
From: Paulo Zanoni
So don't read it when capturing the error state. This solves
"unclaimed register" messages on Haswell when we have a GPU hang.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_irq.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/
From: Paulo Zanoni
I couldn't find any evidence that this register exists on Gen2+. On
Gen 2/3/4 documents this register is listed as reserved and read-only.
On the newer Gens this register is not even documented.
Also all we do with this register is:
- Write 0 to it on i9xx_crtc_mode_set
-
From: Paulo Zanoni
So don't read it when we hang the GPU. This solves "unclaimed
register" messages.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_display.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers
From: Paulo Zanoni
So don't read it when capturing the error state. This solves some
"unclaimed register" messages on Haswell when we hang the GPU.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_display.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/
From: Paulo Zanoni
This solves some "unclaimed register" messages when there's a GPU hang
on Haswell.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_display.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/
From: Paulo Zanoni
This solves some "unclaimed register" messages when booting the
machine with eDP attached.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_display.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
From: Paulo Zanoni
It returns true if we're not supposed to touch the registers on the
power down well.
For now there's just one caller, but I'm going to add more.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_display.c |4 ++--
drivers/gpu/drm/i915/intel_drv.h |1 +
From: Paulo Zanoni
Our mode set sequence documentation says audio must be disabled before
the backlight.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_ddi.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/driver
From: Paulo Zanoni
We already have the same check on intel_enable_ddi. This patch
prevents "unclaimed register" messages when the power well is
disabled.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_ddi.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --g
From: Paulo Zanoni
Hi
This series fixes a few more "unclaimed register" problems. Some of them are
only visible if you're only using eDP (i.e., the power well is down) and most of
them are only visible if you get a GPU hang. The good thing is that I only get
GPU hangs when I run ZZ_hangman :)
N
On Wed, Mar 6, 2013 at 7:39 PM, Hans de Bruin wrote:
> On 03/06/2013 03:00 PM, Daniel Vetter wrote:
>>
>> Hi Hans,
>>
>> Can you please test with 3.9-rc1? That contains an additional patch
>> which might prevent the regression. Specifically
>>
>> commit 9d6d9f19e8146fa24903cb561e204a22232740e3
>>
On Wed, Mar 6, 2013 at 9:55 PM, Jesse Barnes wrote:
> On Wed, 6 Mar 2013 20:05:59 +0100
> Daniel Vetter wrote:
>
>> On Fri, Mar 01, 2013 at 01:14:31PM -0800, Jesse Barnes wrote:
>> > Allows us to detect eDP panels that may not have the hotplug pin wired up.
>> >
>> > Signed-off-by: Jesse Barnes
Hi Dave,
A bunch of fixes, nothing truely horrible:
- Fix PCH irq handling race which resulted in missed gmbus/dp aux irqs
and subsequent fallout (Paulo)
- Fixup off-by-one in our hsw id table (Kenneth)
- Fixup ilk rc6 support (disabled by default), regression introduced in
3.8
- g4x plane w/a
On Wed, 6 Mar 2013 20:05:59 +0100
Daniel Vetter wrote:
> On Fri, Mar 01, 2013 at 01:14:31PM -0800, Jesse Barnes wrote:
> > Allows us to detect eDP panels that may not have the hotplug pin wired up.
> >
> > Signed-off-by: Jesse Barnes
>
> Historically the lid status is horribly broken which is
On Wed, 6 Mar 2013 20:10:42 +0100
Daniel Vetter wrote:
> On Wed, Mar 06, 2013 at 10:33:34AM -0800, Jesse Barnes wrote:
> > On Wed, 6 Mar 2013 20:28:07 +0200
> > Ville Syrjälä wrote:
> >
> > > On Fri, Mar 01, 2013 at 02:08:31PM -0800, Jesse Barnes wrote:
> > > > We could split this out into a se
On Wed, Mar 06, 2013 at 09:19:27PM +0200, Ville Syrjälä wrote:
> On Wed, Mar 06, 2013 at 08:14:54PM +0100, Daniel Vetter wrote:
> > On Wed, Mar 06, 2013 at 09:09:06PM +0200, Ville Syrjälä wrote:
> > > On Wed, Mar 06, 2013 at 07:56:33PM +0100, Daniel Vetter wrote:
> > > > On Fri, Mar 01, 2013 at 01:
Hi Daniel,
I've just tried drm-intel-fixes merged into v3.9-rc1, and so far it's
looking good. No suspicious timeouts.
Thanks for the quick response!
Benson
On Wed, Mar 6, 2013 at 12:14 AM, Daniel Vetter wrote:
> On Wed, Mar 6, 2013 at 3:35 AM, Benson Leung wrote:
>> I'm working on touch devic
On Wed, Mar 06, 2013 at 08:14:54PM +0100, Daniel Vetter wrote:
> On Wed, Mar 06, 2013 at 09:09:06PM +0200, Ville Syrjälä wrote:
> > On Wed, Mar 06, 2013 at 07:56:33PM +0100, Daniel Vetter wrote:
> > > On Fri, Mar 01, 2013 at 01:14:17PM -0800, Jesse Barnes wrote:
> > > > For current usage, not neede
On Wed, Mar 06, 2013 at 11:09:08AM -0800, Jesse Barnes wrote:
> On Wed, 6 Mar 2013 21:00:11 +0200
> Ville Syrjälä wrote:
>
> > On Fri, Mar 01, 2013 at 01:14:23PM -0800, Jesse Barnes wrote:
> > > Signed-off-by: Jesse Barnes
> > > ---
> > > drivers/gpu/drm/i915/intel_display.c |3 ++-
> > > 1
On Wed, Mar 06, 2013 at 09:09:06PM +0200, Ville Syrjälä wrote:
> On Wed, Mar 06, 2013 at 07:56:33PM +0100, Daniel Vetter wrote:
> > On Fri, Mar 01, 2013 at 01:14:17PM -0800, Jesse Barnes wrote:
> > > For current usage, not needed.
> > >
> > > Signed-off-by: Vijay Purushothaman
> > > ---
> > > dr
On Wed, 6 Mar 2013 20:02:43 +0100
Daniel Vetter wrote:
> On Fri, Mar 01, 2013 at 01:14:27PM -0800, Jesse Barnes wrote:
> > We need it for some DP training related bits.
> >
> > Signed-off-by: Jesse Barnes
>
> Maintainer-bikeshed: Imo having such unstatic-only patches doesn't really
> add value
On Wed, 6 Mar 2013 20:00:37 +0100
Daniel Vetter wrote:
> On Fri, Mar 01, 2013 at 01:14:26PM -0800, Jesse Barnes wrote:
> > Signed-off-by: Jesse Barnes
> > ---
> > drivers/gpu/drm/i915/intel_hdmi.c |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm
On Wed, Mar 06, 2013 at 07:56:33PM +0100, Daniel Vetter wrote:
> On Fri, Mar 01, 2013 at 01:14:17PM -0800, Jesse Barnes wrote:
> > For current usage, not needed.
> >
> > Signed-off-by: Vijay Purushothaman
> > ---
> > drivers/gpu/drm/i915/intel_pm.c |4 +++-
> > 1 file changed, 3 insertions(+
On Wed, 6 Mar 2013 21:00:11 +0200
Ville Syrjälä wrote:
> On Fri, Mar 01, 2013 at 01:14:23PM -0800, Jesse Barnes wrote:
> > Signed-off-by: Jesse Barnes
> > ---
> > drivers/gpu/drm/i915/intel_display.c |3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gp
On Wed, Mar 06, 2013 at 10:33:34AM -0800, Jesse Barnes wrote:
> On Wed, 6 Mar 2013 20:28:07 +0200
> Ville Syrjälä wrote:
>
> > On Fri, Mar 01, 2013 at 02:08:31PM -0800, Jesse Barnes wrote:
> > > We could split this out into a separate routine at some point as an
> > > optimization.
> >
> > BTW d
On Wed, Mar 06, 2013 at 08:45:47PM +0200, Ville Syrjälä wrote:
> On Fri, Mar 01, 2013 at 02:08:29PM -0800, Jesse Barnes wrote:
> > It uses the same bit definitions.
> >
> > Signed-off-by: Jesse Barnes
>
> Matches what I see in the docs.
>
> Reviewed-by: Ville Syrjälä
Queued for -next, thanks f
On Fri, Mar 01, 2013 at 01:14:31PM -0800, Jesse Barnes wrote:
> Allows us to detect eDP panels that may not have the hotplug pin wired up.
>
> Signed-off-by: Jesse Barnes
Historically the lid status is horribly broken which is why it's disabled
by default. What changed to now enable it unconditi
On Fri, Mar 01, 2013 at 01:14:30PM -0800, Jesse Barnes wrote:
> Fix up a couple of places where we messed with PCH bits on VLV.
>
> Signed-off-by: Jesse Barnes
We might want ot untangle the cpu vs. pch dp port question from the dp vs.
edp question eventually. Anyway, I've merged this patch here
On Fri, Mar 01, 2013 at 01:14:23PM -0800, Jesse Barnes wrote:
> Signed-off-by: Jesse Barnes
> ---
> drivers/gpu/drm/i915/intel_display.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
>
On Fri, Mar 01, 2013 at 01:14:27PM -0800, Jesse Barnes wrote:
> We need it for some DP training related bits.
>
> Signed-off-by: Jesse Barnes
Maintainer-bikeshed: Imo having such unstatic-only patches doesn't really
add value, I prefer it squashed with the new use-site (with a small
comment in t
On Fri, Mar 01, 2013 at 01:14:26PM -0800, Jesse Barnes wrote:
> Signed-off-by: Jesse Barnes
> ---
> drivers/gpu/drm/i915/intel_hdmi.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
> b/drivers/gpu/drm/i915/intel_hdmi.c
> index fcb36
On Fri, Mar 01, 2013 at 01:14:23PM -0800, Jesse Barnes wrote:
> Signed-off-by: Jesse Barnes
> ---
> drivers/gpu/drm/i915/intel_display.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
>
On Fri, Mar 01, 2013 at 01:14:17PM -0800, Jesse Barnes wrote:
> For current usage, not needed.
>
> Signed-off-by: Vijay Purushothaman
> ---
> drivers/gpu/drm/i915/intel_pm.c |4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/
On Wed, Mar 06, 2013 at 10:33:34AM -0800, Jesse Barnes wrote:
> On Wed, 6 Mar 2013 20:28:07 +0200
> Ville Syrjälä wrote:
>
> > On Fri, Mar 01, 2013 at 02:08:31PM -0800, Jesse Barnes wrote:
> > > We could split this out into a separate routine at some point as an
> > > optimization.
> >
> > BTW d
On Fri, Mar 01, 2013 at 01:14:15PM -0800, Jesse Barnes wrote:
> From: Ben Widawsky
>
> Disable all Gunit clock gating and make set the "allow force wake" bit.
>
> Signed-off-by: Jesse Barnes
Can we make the in-code comments here a bit louder to explain that this is
pre-production w/a stuff whi
On Fri, Mar 01, 2013 at 01:14:13PM -0800, Jesse Barnes wrote:
> Signed-off-by: Jesse Barnes
Commit message is a bit sparse given that the only thing this does is
enable the forcewake duct-tape for more coherent seqno waiting. I've
pimped the commit message a bit.
Applied, thanks.
-Daniel
> ---
>
On Fri, Mar 01, 2013 at 02:08:29PM -0800, Jesse Barnes wrote:
> It uses the same bit definitions.
>
> Signed-off-by: Jesse Barnes
Matches what I see in the docs.
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On Wed, 6 Mar 2013 20:28:07 +0200
Ville Syrjälä wrote:
> On Fri, Mar 01, 2013 at 02:08:31PM -0800, Jesse Barnes wrote:
> > We could split this out into a separate routine at some point as an
> > optimization.
>
> BTW did anyone try to gang wakeup thing instead?
Not afaik.
>
> >
> > Signed-of
On Fri, Mar 01, 2013 at 02:08:31PM -0800, Jesse Barnes wrote:
> We could split this out into a separate routine at some point as an
> optimization.
BTW did anyone try to gang wakeup thing instead?
>
> Signed-off-by: Jesse Barnes
> ---
> drivers/gpu/drm/i915/i915_reg.h |2 ++
> drivers/gpu/
On Wed, 6 Mar 2013 20:20:21 +0200
Ville Syrjälä wrote:
> On Fri, Mar 01, 2013 at 02:08:23PM -0800, Jesse Barnes wrote:
> > Can prevent a hang when we get to tessellation.
> >
> > Signed-off-by: Jesse Barnes
> > ---
> > drivers/gpu/drm/i915/intel_pm.c |4 +++-
> > 1 file changed, 3 insertio
On Fri, Mar 01, 2013 at 02:08:23PM -0800, Jesse Barnes wrote:
> Can prevent a hang when we get to tessellation.
>
> Signed-off-by: Jesse Barnes
> ---
> drivers/gpu/drm/i915/intel_pm.c |4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c
On Tue, Mar 05, 2013 at 02:24:48PM +0100, Patrik Jakobsson wrote:
> According to PRM we need to disable hsync and vsync even though ADPA is
> disabled. The previous code did infact do the opposite so we fix it.
>
> Signed-off-by: Patrik Jakobsson
Bugreporter confirmed that it works, so merged to
From: Ville Syrjälä
Currently all scanout buffers must be uncached because the
display controller doesn't snoop the LLC. SNB introduced another
method to guarantee coherency for the display controller. It's
called the GFDT or graphics data type.
Pages that have the GFDT bit enabled in their PTEs
Hello Hans,
Daniel Vetter writes:
> Hi Hans,
>
> Can you please test with 3.9-rc1? That contains an additional patch
> which might prevent the regression. Specifically
>
> commit 9d6d9f19e8146fa24903cb561e204a22232740e3
> Author: Mika Kuoppala
> Date: Fri Feb 8 16:35:38 2013 +0200
>
> dr
On Wed, Feb 06, 2013 at 03:19:03PM +0200, Jani Nikula wrote:
> On Sat, 02 Feb 2013, Jesse Barnes wrote:
> > Signed-off-by: Jesse Barnes
>
> Reviewed-by: Jani Nikula
Queued for -next, thanks for the patch. And Paulo promised to fix up the
confusion around LVDS presence checks.
-Daniel
>
> > --
Hi Hans,
Can you please test with 3.9-rc1? That contains an additional patch
which might prevent the regression. Specifically
commit 9d6d9f19e8146fa24903cb561e204a22232740e3
Author: Mika Kuoppala
Date: Fri Feb 8 16:35:38 2013 +0200
drm/i915: clean up panel fitter handling in lvds
Thanks,
Since
commit 24a1f16de97c4cf0029d9acd04be06db32208726
Author: Mika Kuoppala
Date: Fri Feb 8 16:35:37 2013 +0200
drm/i915: disable shared panel fitter for pipe
We clear the single panel fitter when disabling the pipe it's attached to, so no
need to additionally clear it when there's no lvd
On Wed, Mar 6, 2013 at 12:17 AM, Paul Menzel
wrote:
> Dear Patrik,
Hi Paul
> Am Dienstag, den 05.03.2013, 19:09 +0100 schrieb Patrik Jakobsson:
>> Disable bits for ADPA HSYNC and VSYNC where mixed up resulting in suspend
>> becoming standby and vice versa.
>
> nice find. Could you elaborate on t
On Wed, Mar 06, 2013 at 10:56:05AM +, Chris Wilson wrote:
> On Thu, Feb 21, 2013 at 11:35:00PM +0200, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > struct drm_region represents a two dimensional region. The utility
> > functions are there to help driver writers.
> >
>
On Thu, Feb 21, 2013 at 11:35:00PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> struct drm_region represents a two dimensional region. The utility
> functions are there to help driver writers.
>
> v2: Moved the region stuff into its own file, made the smaller funcs
>
Am Montag, den 04.03.2013, 17:17 +0100 schrieb Daniel Vetter:
> On Mon, Mar 04, 2013 at 09:24:38AM -0500, Egbert Eich wrote:
> > On G45 some low res modes (800x600 and 1024x768) produce a blank
> > screen when the display plane is enabled with with cursor plane
> > off.
> > Experiments showed that
On Tue, Mar 05, 2013 at 02:19:31PM -0800, Eric Anholt wrote:
> Patrik Jakobsson writes:
>
> > Disable bits for ADPA HSYNC and VSYNC where mixed up resulting in suspend
> > becoming standby and vice versa. Fixed by swapping their bit position.
> >
> > Reported-by: Ville Syrjälä
> > Signed-off-by:
On Wed, 06 Mar 2013, Daniel Vetter wrote:
> On Wed, Mar 6, 2013 at 3:35 AM, Benson Leung wrote:
>> I'm working on touch devices Chromium OS, and I've noticed a
>> regression between 3.8 and 3.9-rc1, which was posted yesterday.
>>
>> The hardware in question is a Chromebook Pixel. For this device,
On Wed, Mar 6, 2013 at 3:35 AM, Benson Leung wrote:
> I'm working on touch devices Chromium OS, and I've noticed a
> regression between 3.8 and 3.9-rc1, which was posted yesterday.
>
> The hardware in question is a Chromebook Pixel. For this device, we
> have i2c input devices: atmel mxt224s touch
64 matches
Mail list logo
