Hi,
We have reviewed the patch overall it seems to be fine.
Although this patch has really simplified the scan-out calculation, but
we do have few doubts/opens.
There is a particular change :-
*position = (position + htotal - hsync_start) % vtotal;*
This adjustment could
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
lib/igt_core.c | 32
1 file changed, 32 insertions(+)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index ff4711785654..3e2350e9982a 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -83,6 +83,38 @@
* To
This regression has been introduced in
commit 8232644ccf099548710843e97360a3fcd6d28e04
Author: Chris Wilson ch...@chris-wilson.co.uk
Date: Wed Mar 5 12:00:39 2014 +
drm/i915: Convert the forcewake worker into a timer func
which started to use the delayed forcewake put also for the
On Fri, Mar 14, 2014 at 08:48:46AM +0100, Daniel Vetter wrote:
This regression has been introduced in
commit 8232644ccf099548710843e97360a3fcd6d28e04
Author: Chris Wilson ch...@chris-wilson.co.uk
Date: Wed Mar 5 12:00:39 2014 +
drm/i915: Convert the forcewake worker into a timer
On Fri, Mar 14, 2014 at 10:18:47AM +0200, Ville Syrjälä wrote:
On Fri, Mar 14, 2014 at 08:48:46AM +0100, Daniel Vetter wrote:
This regression has been introduced in
commit 8232644ccf099548710843e97360a3fcd6d28e04
Author: Chris Wilson ch...@chris-wilson.co.uk
Date: Wed Mar 5 12:00:39
On Fri, Mar 14, 2014 at 08:24:00AM +, Chris Wilson wrote:
On Fri, Mar 14, 2014 at 10:18:47AM +0200, Ville Syrjälä wrote:
On Fri, Mar 14, 2014 at 08:48:46AM +0100, Daniel Vetter wrote:
This regression has been introduced in
commit 8232644ccf099548710843e97360a3fcd6d28e04
Author:
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/intel_uncore.c | 9 ++---
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 5a0d34c47885..3fbf8aa8d119 100644
---
Across a device reset, we try to restore and user forcewake reference
counts. This is complicated by our deferred forcewake put adding an
extra reference, that may or may not be flushed when we call
del_timer_sync. So we have to take that pending reference into account
when restoring the
Daniel stopped that we lose track of the user forcewake across suspend
and resume, so hook up the code to restore it.
Reported-by: Daniel Vetter daniel.ve...@ffwll.ch
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
Cc: Daniel Vetter daniel.ve...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.c
On Fri, Mar 14, 2014 at 9:34 AM, Ville Syrjälä
ville.syrj...@linux.intel.com wrote:
Heh, I went the other way round, dropped the runtime pm put from the
timer and flushed the forcewaker timer when we suspended the device...
That's what I meant. No delayed runtime_pm_put.
Well I've figured we
There's no need to be fancy here.
Cc: Jeff McGee jeff.mc...@intel.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
tests/pm_rps.c | 33 +++--
1 file changed, 7 insertions(+), 26 deletions(-)
diff --git a/tests/pm_rps.c b/tests/pm_rps.c
index
We don't call cleanup handlers when exiting a subtest currently, only
when exiting the entire binary. Which means pm_rps falls over when it
fails more than one subtest.
Cc: Jeff McGee jeff.mc...@intel.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
tests/pm_rps.c | 32
Big core platforms need some seriuos omph to break a sweat.
This fixes min-max-config-loaded here on my ivb.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75146
Cc: Jeff McGee jeff.mc...@intel.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
tests/pm_rps.c | 13 +
Big cores seem to take forever to idle, at least my ivb here. Fairly
ridiculous, so maybe there's more room for our debooster to kick in.
Anyway, this gets the min-max-config-idle and reset subtests going
somewhat reliably on my ivb. They still occasionally fail with the
current frequency pegged
Much better debug output almost for free.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
tests/pm_rps.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/tests/pm_rps.c b/tests/pm_rps.c
index b5dd494443ff..f5af9c2e92e8 100644
---
On Thu, Mar 06, 2014 at 01:12:31PM -0800, Kenneth Graunke wrote:
These command packets grew on Gen8.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/uxa/i830_reg.h | 12 ++--
src/uxa/intel_uxa.c | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff
On Thu, Mar 06, 2014 at 01:12:32PM -0800, Kenneth Graunke wrote:
This supports solid, copy, put_image, and get_image acceleration via the
BLT engine. RENDER acceleration (composite) would be piles of work,
which is not worth doing since SNA exists, and Glamor is coming.
Only thing I spotted
On Sat, 08 Mar 2014, Paulo Zanoni przan...@gmail.com wrote:
From: Paulo Zanoni paulo.r.zan...@intel.com
Commit b3064154dfd37deb386b1e459c54e1ca2460b3d5 tried to revert commit
dff392dbd258381a6c3164f38420593f2d291e3b, but wasn't complete, which
resulted in regressions on Haswell. So this
On Thu, 13 Mar 2014, Daniel Vetter dan...@ffwll.ch wrote:
On Thu, Mar 13, 2014 at 07:52:45PM +0200, Jani Nikula wrote:
On Thu, 13 Mar 2014, Daniel Vetter daniel.vet...@ffwll.ch wrote:
It's been in there since forever, and no one cared. Doesn't put a too
good light onto our bug handling and
On Wed, 05 Mar 2014, Daniel Vetter dan...@ffwll.ch wrote:
On Wed, Mar 05, 2014 at 03:32:54PM +, Chris Wilson wrote:
On Wed, Mar 05, 2014 at 04:17:17PM +0100, Daniel Vetter wrote:
On Fri, Feb 28, 2014 at 12:14:02PM +, Chris Wilson wrote:
We have reports of heavy screen corruption if
On Fri, Mar 14, 2014 at 2:07 PM, Jani Nikula
jani.nik...@linux.intel.com wrote:
The bug report complains that the crc stuff doesn't work on byt edp, but
dmesg contains a pile of these WARNs. Hence just references, since this
likely won't fix the actual bug.
Pushed to -fixes, thanks for the
On Fri, Mar 14, 2014 at 1:07 PM, Jani Nikula
jani.nik...@linux.intel.com wrote:
Fixes regression introduced by:
commit b3064154dfd37deb386b1e459c54e1ca2460b3d5
Author: Patrik Jakobsson patrik.r.jakobs...@gmail.com
Date: Tue Mar 4 00:42:44 2014 +0100
drm/i915: Don't just say it, actually
On Fri, 14 Mar 2014, Daniel Vetter dan...@ffwll.ch wrote:
On Fri, Mar 14, 2014 at 2:07 PM, Jani Nikula
jani.nik...@linux.intel.com wrote:
The bug report complains that the crc stuff doesn't work on byt edp, but
dmesg contains a pile of these WARNs. Hence just references, since this
likely
On Fri, Mar 14, 2014 at 10:27:46AM +0100, Daniel Vetter wrote:
We don't call cleanup handlers when exiting a subtest currently, only
when exiting the entire binary. Which means pm_rps falls over when it
fails more than one subtest.
Cc: Jeff McGee jeff.mc...@intel.com
Signed-off-by: Daniel
If hw_contexts are disabled, we always return the per file
descriptor default context stats. Make sure that the context
is correctly given and fail accordingly if not.
Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com
---
drivers/gpu/drm/i915/i915_gem_context.c |6 +-
1 file changed,
We used to have per file descriptor hang stats for the
i915_get_reset_stats_ioctl() and for default context banning.
commit 0eea67eb26000657079b7fc41079097942339452
Author: Ben Widawsky b...@bwidawsk.net
Date: Fri Dec 6 14:11:19 2013 -0800
drm/i915: Create a per file_priv default context
On Fri, Mar 14, 2014 at 10:27:47AM +0100, Daniel Vetter wrote:
There's no need to be fancy here.
Cc: Jeff McGee jeff.mc...@intel.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
tests/pm_rps.c | 33 +++--
1 file changed, 7 insertions(+), 26
On Fri, Mar 14, 2014 at 10:27:48AM +0100, Daniel Vetter wrote:
Big core platforms need some seriuos omph to break a sweat.
This fixes min-max-config-loaded here on my ivb.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75146
Cc: Jeff McGee jeff.mc...@intel.com
Signed-off-by:
On Fri, 14 Mar 2014, Mika Kuoppala mika.kuopp...@linux.intel.com wrote:
We used to have per file descriptor hang stats for the
i915_get_reset_stats_ioctl() and for default context banning.
commit 0eea67eb26000657079b7fc41079097942339452
Author: Ben Widawsky b...@bwidawsk.net
Date: Fri Dec
On 03/14/2014 07:18 AM, Daniel Vetter wrote:
[snip]
+ * # Magic Control Blocks
+ *
+ * i-g-t makes heavy use of C macros which serve as magic control blocks. They
+ * work fairly well and transparently but since C doesn't have full-blown
+ * closures there are caveats:
+ *
+ * - Asynchronous
Introduce _edp_panel_vdd_on() that returns true if the call enabled vdd,
and a matching disable is needed. Keep edp_panel_vdd_on() as a helper
for when it is expected the vdd is off.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 22
Let the drivers specify the name of the I2C-over-AUX adapter to maintain
backwards compatibility in the sysfs when converting to the new
I2C-over-AUX helper infrastructure.
The i915 driver currently uses DPDDC-A to DPDDC-D as names for the DP
i2c adapters. These names show up in the i2c sysfs
Functionality remains largely the same as before.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 257 +-
drivers/gpu/drm/i915/intel_drv.h |1 +
2 files changed, 116 insertions(+), 142 deletions(-)
diff --git
The functionality remains largerly the same. The main difference is that
i2c-over-aux defer timeouts are increased to be safe for all use cases
instead of depending on DP device type and properties.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 197
Switch over to using Thierry's drm dp aux helpers.
The previous RFC series (from before the helpers were merged) is at
[1]. I specifically decided to dodge the sleep state issues pointed out
by Ville [2] for now; this series does not make us better or worse in
this regard.
Only briefly tested on
Do a slight rearrangement of the switch to prep for follow-up.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 42 ---
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c
This is prep work for conversion to generic drm i2c-over-aux helpers
where we won't have the function to do this at.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git
I didn't know that this also works for the varargs versions of
format strings. But gcc was kind enough to let me know.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
lib/igt_core.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/igt_core.h b/lib/igt_core.h
index
I suspect that currently we have an issue in there with the runtime PM
refcounting, but silly me developed this on a machine with runtime PM
support ...
Cc: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
tests/drv_suspend.c | 15 +++
1
... and I immediately regret that I've killed the return value
for igt_debugfs_init, since we have callers which need to work
without the forcewake stuff, e.g. the reg dumper needs to work
without i915 loaded.
Put this new helper to good use in the mmio code and the pm_pc8
testcase.
Cc: Paulo
On Fri, Mar 14, 2014 at 02:49:16PM +, Tvrtko Ursulin wrote:
On 03/14/2014 07:18 AM, Daniel Vetter wrote:
[snip]
+ * # Magic Control Blocks
+ *
+ * i-g-t makes heavy use of C macros which serve as magic control blocks.
They
+ * work fairly well and transparently but since C doesn't
On Fri, Mar 14, 2014 at 3:34 PM, Jeff McGee jeff.mc...@intel.com wrote:
My intent here was to allow a subtest which doesn't require the load helper to
run and pass even if the loader helper failed to initialize for whatever
reason. I'm fine if we'd rather avoid the complexity, but can we state
On Fri, Mar 14, 2014 at 3:29 PM, Jeff McGee jeff.mc...@intel.com wrote:
Unfortunately there are probably several ways in which a failed subtest will
contaminate subsequent subtests if all are run in the same process instance.
I asked about that earlier and you said that we don't concern too
On Fri, Mar 14, 2014 at 04:22:11PM +0200, Mika Kuoppala wrote:
If hw_contexts are disabled, we always return the per file
descriptor default context stats. Make sure that the context
is correctly given and fail accordingly if not.
Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com
Hm,
On Fri, Mar 14, 2014 at 04:43:16PM +0200, Jani Nikula wrote:
On Fri, 14 Mar 2014, Mika Kuoppala mika.kuopp...@linux.intel.com wrote:
We used to have per file descriptor hang stats for the
i915_get_reset_stats_ioctl() and for default context banning.
commit
On Fri, Mar 14, 2014 at 04:42:21PM +0100, Daniel Vetter wrote:
On Fri, Mar 14, 2014 at 04:43:16PM +0200, Jani Nikula wrote:
On Fri, 14 Mar 2014, Mika Kuoppala mika.kuopp...@linux.intel.com wrote:
We used to have per file descriptor hang stats for the
i915_get_reset_stats_ioctl() and for
On Fri, Mar 14, 2014 at 09:41:13AM -0500, Jeff McGee wrote:
On Fri, Mar 14, 2014 at 10:27:48AM +0100, Daniel Vetter wrote:
Big core platforms need some seriuos omph to break a sweat.
This fixes min-max-config-loaded here on my ivb.
Bugzilla:
On Fri, Mar 14, 2014 at 08:37:15AM +, Chris Wilson wrote:
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/intel_uncore.c | 9 ++---
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
On Fri, Mar 14, 2014 at 08:47:14AM +, Chris Wilson wrote:
Daniel stopped that we lose track of the user forcewake across suspend
and resume, so hook up the code to restore it.
Reported-by: Daniel Vetter daniel.ve...@ffwll.ch
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
Cc:
On Fri, Mar 14, 2014 at 04:51:56PM +0100, Daniel Vetter wrote:
On Fri, Mar 14, 2014 at 08:47:14AM +, Chris Wilson wrote:
Daniel stopped that we lose track of the user forcewake across suspend
and resume, so hook up the code to restore it.
Reported-by: Daniel Vetter
On Fri, Mar 14, 2014 at 04:51:16PM +0100, Daniel Vetter wrote:
On Fri, Mar 14, 2014 at 08:37:15AM +, Chris Wilson wrote:
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/intel_uncore.c | 9 ++---
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git
The preliminary HW support check is no longer needed, and the
calculation is simplified while here.
Reported-by: David Woodhouse david.woodho...@intel.com
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 9 +
1 file changed, 1 insertion(+), 8
On Tue, 11 Mar 2014 12:21:32 +0100
Daniel Vetter dan...@ffwll.ch wrote:
Hi all,
So I guess people have seen the writing on the wall since a while ;-)
So with my latest drm kerneldoc series we'll have fairly nice interface
docs for most of the still relevant drm core subsystems. Which
On Fri, 14 Mar 2014 19:16:01 +0100
Daniel Vetter dan...@ffwll.ch wrote:
On Fri, Mar 14, 2014 at 7:03 PM, Jesse Barnes jbar...@virtuousgeek.org
wrote:
Yeah just saying a man page should be required as part of any new
ioctl.
Yeah I agree and long-term we'll get there. Otherwise I wouldn't
On Fri, 14 Mar 2014 09:52:47 +0100
Daniel Vetter daniel.vet...@ffwll.ch wrote:
On Fri, Mar 14, 2014 at 9:34 AM, Ville Syrjälä
ville.syrj...@linux.intel.com wrote:
Heh, I went the other way round, dropped the runtime pm put from the
timer and flushed the forcewaker timer when we suspended
On Fri, Mar 14, 2014 at 09:58:06AM -0700, Ben Widawsky wrote:
The preliminary HW support check is no longer needed, and the
calculation is simplified while here.
Reported-by: David Woodhouse david.woodho...@intel.com
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
On Fri, Mar 14, 2014 at 5:13 PM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Fri, Mar 14, 2014 at 04:51:16PM +0100, Daniel Vetter wrote:
On Fri, Mar 14, 2014 at 08:37:15AM +, Chris Wilson wrote:
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/intel_uncore.c |
On Fri, Mar 14, 2014 at 5:07 PM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Fri, Mar 14, 2014 at 04:51:56PM +0100, Daniel Vetter wrote:
On Fri, Mar 14, 2014 at 08:47:14AM +, Chris Wilson wrote:
Daniel stopped that we lose track of the user forcewake across suspend
and resume, so
On Fri, Mar 14, 2014 at 2:57 PM, Daniel Vetter dan...@ffwll.ch wrote:
On Fri, Mar 14, 2014 at 1:07 PM, Jani Nikula
jani.nik...@linux.intel.com wrote:
Fixes regression introduced by:
commit b3064154dfd37deb386b1e459c54e1ca2460b3d5
Author: Patrik Jakobsson patrik.r.jakobs...@gmail.com
Date:
On Fri, Mar 14, 2014 at 07:40:30PM +0100, Daniel Vetter wrote:
On Fri, Mar 14, 2014 at 09:58:06AM -0700, Ben Widawsky wrote:
The preliminary HW support check is no longer needed, and the
calculation is simplified while here.
Reported-by: David Woodhouse david.woodho...@intel.com
60 matches
Mail list logo
