[Intel-gfx] [PATCH I-g-t 1/2] Rendercopy/skl: Remove redundant field to fix GPU hang

2014-11-06 Thread Zhao Yakui
After applying the commit(982f7eb238a0898c456e0574dee7c4507738d75f), the OUT_RELOC is updated on Broadwell and later, which is to handle the 64-bit field of gfx address internally. In such case some commands should be fixed, otherwise GPU hang will be triggered when running rendercopy. (It is

[Intel-gfx] [PATCH I-g-t 2/2] Mediafill/skl: Remove redundant field to fix GPU hang

2014-11-06 Thread Zhao Yakui
After applying the commit(982f7eb238a0898c456e0574dee7c4507738d75f), the OUT_RELOC is updated on Broadwell and later, which is to handle the 64-bit field of gfx address internally. In such case some commands should be fixed, otherwise GPU hang will be triggered when running gem_media_fill. (It

Re: [Intel-gfx] [PATCH] drm/i915: Add haswell_pcode_write function

2014-11-06 Thread Ville Syrjälä
On Wed, Nov 05, 2014 at 05:32:44PM -0800, Tom.O'rou...@intel.com wrote: From: Tom O'Rourke Tom.O'rou...@intel.com Based on sandybridge_pcode_write, haswell_pcode_write has an additional field for address control. It's already there in snb. Do you have an actual use case for this? If so I

Re: [Intel-gfx] [PATCH I-g-t 1/2] Rendercopy/skl: Remove redundant field to fix GPU hang

2014-11-06 Thread Damien Lespiau
On Thu, Nov 06, 2014 at 04:02:30PM +0800, Zhao Yakui wrote: After applying the commit(982f7eb238a0898c456e0574dee7c4507738d75f), the OUT_RELOC is updated on Broadwell and later, which is to handle the 64-bit field of gfx address internally. In such case some commands should be fixed,

Re: [Intel-gfx] [PATCH 06/10] drm/i915: Enable vblank interrupts for CRC generation

2014-11-06 Thread Damien Lespiau
On Tue, Nov 04, 2014 at 04:51:44AM -0800, Rodrigo Vivi wrote: From: Chris Wilson ch...@chris-wilson.co.uk Pineview requires this. But this changes the debug API... References: https://bugs.freedesktop.org/show_bug.cgi?id=82280 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk

[Intel-gfx] [PATCH] drm/i915: Fix obj-map_and_fenceable across tiling changes

2014-11-06 Thread Chris Wilson
As obj-map_and_fenceable computation has changed to only be set when the object is bound inside the global GTT (and is suitable aligned to a fence region) we need to accommodate those changes when the tiling is adjusted. The easiest solution is to unbind from the global GTT if we are currently

Re: [Intel-gfx] [PATCH 6/6] drm/i915: calculate pfit changes in

2014-11-06 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform: baseline_drm_intel_nightly_pass_rate-patch_applied_pass_rate BYT: pass/total=348/348-348/348 PNV:

[Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-06 Thread Ander Conselvan de Oliveira
This simplifies the code quite a bit compared to iterating over all rings during the ring interrupt. Also, it allows us to drop the mmio_flip spinlock, since the mmio_flip struct is only accessed in two places. The first is when the flip is queued and the other when the mmio writes are done.

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3

2014-11-06 Thread Chris Wilson
On Wed, Nov 05, 2014 at 02:26:06PM -0800, Jesse Barnes wrote: +static int intel_set_mode(struct drm_crtc *crtc, + struct drm_display_mode *mode, + int x, int y, struct drm_framebuffer *fb) +{ + struct intel_crtc_config *pipe_config; +

[Intel-gfx] 3.18.0-rc3: i915: eDP connected Display stays blank

2014-11-06 Thread Arnd Hannemann
Hi, I have a Thinkpad T440s (Haswell) connected to two additional Monitors via a Docking Station (MST). During Bootup all three displays work, even when X is started. However, if the laptop display is turned off once (either because of power saving, or via xrandr), it fails to come back. That is

Re: [Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-06 Thread Chris Wilson
On Thu, Nov 06, 2014 at 11:03:40AM +0200, Ander Conselvan de Oliveira wrote: This simplifies the code quite a bit compared to iterating over all rings during the ring interrupt. Also, it allows us to drop the mmio_flip spinlock, since the mmio_flip struct is only accessed in two places. The

Re: [Intel-gfx] 3.18.0-rc3: i915: eDP connected Display stays blank

2014-11-06 Thread Jani Nikula
On Thu, 06 Nov 2014, Arnd Hannemann a...@arndnet.de wrote: Hi, I have a Thinkpad T440s (Haswell) connected to two additional Monitors via a Docking Station (MST). During Bootup all three displays work, even when X is started. However, if the laptop display is turned off once (either because

[Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-06 Thread Daniel Vetter
Hi all, After a few atomic irc chats I've shockingly realized that I've completely ignored dpms handling in my helper series. Oops. But there's a few things which are seriously wrong with DPMS, so I've figured I'll start a discussion about them first - converting to atomic looks like a good time

Re: [Intel-gfx] 3.18.0-rc3: i915: eDP connected Display stays blank

2014-11-06 Thread Arnd Hannemann
Hi, thanks for your quick response. Am 06.11.2014 um 10:39 schrieb Jani Nikula: On Thu, 06 Nov 2014, Arnd Hannemann a...@arndnet.de wrote: Hi, I have a Thinkpad T440s (Haswell) connected to two additional Monitors via a Docking Station (MST). During Bootup all three displays work, even

Re: [Intel-gfx] [PATCH] sna: Use VMask in 3DSTATE_PS

2014-11-06 Thread Chris Wilson
On Thu, Nov 06, 2014 at 08:22:54AM +0200, Timo Aaltonen wrote: On 06.11.2014 01:48, Rodrigo Vivi wrote: Using dispatch mask cause hangs waiting PS Done on some cases like bug #83207, with larger screen or when scaling it. Also mesa uses VMask instead of Dmask for 3DSTATE_PS because in

Re: [Intel-gfx] [PATCH] drm/i915: Disable caches for Global GTT.

2014-11-06 Thread Chris Wilson
On Wed, Nov 05, 2014 at 12:11:41PM +0100, Daniel Vetter wrote: On Thu, Oct 30, 2014 at 5:18 PM, Rodrigo Vivi rodrigo.v...@intel.com wrote: Global GTT doesn't have pat_sel[2:0] so it always point to pat_sel = 000; So the only way to avoid screen corruptions is setting PAT 0 to Uncached.

[Intel-gfx] [PATCH 2/2] drm/i915: Capture module params on hang

2014-11-06 Thread Mika Kuoppala
as it helps with bug triaging. Suggested-by: Chris Wilson ch...@chris-wilson.co.uk Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gpu_error.c | 32 2 files changed, 33 insertions(+)

[Intel-gfx] [PATCH 1/2] drm/i915: Add gen to the gpu hang ecode

2014-11-06 Thread Mika Kuoppala
for the Brothers in Triage Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_gpu_error.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index d17360b..89a2f3d

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add gen to the gpu hang ecode

2014-11-06 Thread Chris Wilson
On Thu, Nov 06, 2014 at 01:03:46PM +0200, Mika Kuoppala wrote: for the Brothers in Triage Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_gpu_error.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Capture module params on hang

2014-11-06 Thread Chris Wilson
On Thu, Nov 06, 2014 at 01:03:47PM +0200, Mika Kuoppala wrote: as it helps with bug triaging. Suggested-by: Chris Wilson ch...@chris-wilson.co.uk Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gpu_error.c |

[Intel-gfx] [PATCH 2/2] drm/i915: Capture module params on hang

2014-11-06 Thread Mika Kuoppala
as it helps with bug triaging. v2: Use PAGE_SIZE on alloc, don't spam to dmesg (Chris Wilson) Suggested-by: Chris Wilson ch...@chris-wilson.co.uk Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gpu_error.c | 31

[Intel-gfx] [PATCH v2 2/3] drm/i915: Move the .global_resources() hook call into modeset_update_crtc_power_domains()

2014-11-06 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com We may need to access various hardware bits in the .global_resources() hook, so move the call to occur after enabling all the newly required power wells, but before disabling all the now unneeded wells. This should guarantee that we have all the

Re: [Intel-gfx] 3.18.0-rc3: i915: eDP connected Display stays blank

2014-11-06 Thread Jani Nikula
On Thu, 06 Nov 2014, Arnd Hannemann a...@arndnet.de wrote: Hi, thanks for your quick response. Am 06.11.2014 um 10:39 schrieb Jani Nikula: On Thu, 06 Nov 2014, Arnd Hannemann a...@arndnet.de wrote: Hi, I have a Thinkpad T440s (Haswell) connected to two additional Monitors via a Docking

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Move the .global_resources() hook call into modeset_update_crtc_power_domains()

2014-11-06 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 02:49:12PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We may need to access various hardware bits in the .global_resources() hook, so move the call to occur after enabling all the newly required power wells, but

Re: [Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-06 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 09:25:22AM +, Chris Wilson wrote: On Thu, Nov 06, 2014 at 11:03:40AM +0200, Ander Conselvan de Oliveira wrote: This simplifies the code quite a bit compared to iterating over all rings during the ring interrupt. Also, it allows us to drop the mmio_flip

Re: [Intel-gfx] [PATCH v3 2/5] drm/i915: Use batch pools with the command parser

2014-11-06 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 07:36:55AM +, Chris Wilson wrote: On Wed, Nov 05, 2014 at 02:42:00PM -0800, Volkin, Bradley D wrote: For this part, I've got an implementation that works ok but one difference is that if we stop submitting batches, and therefore stop calling batch_pool_get,

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Cache HPLL frequency on VLV/CHV

2014-11-06 Thread Imre Deak
On Tue, 2014-10-07 at 17:41 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We need the HPLL frequency when calculating cdclk. Currently we read that out from the hardware every single time, which isn't going to fly very well if the device is

Re: [Intel-gfx] [PATCH] Revert drm/i915/vlv: Remove check for Old Ack during forcewake

2014-11-06 Thread Daniel Vetter
On Wed, Nov 05, 2014 at 05:30:52PM +0200, Mika Kuoppala wrote: This reverts commit 5cb13c07dae73380d8b3ddc792740487b8742938. While the relevance for WaRsDontPollForAckOnClearingFWBits is under investigation, revert this as regression. Bugzilla:

Re: [Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-06 Thread Chris Wilson
On Thu, Nov 06, 2014 at 02:53:09PM +0100, Daniel Vetter wrote: On Thu, Nov 06, 2014 at 09:25:22AM +, Chris Wilson wrote: On Thu, Nov 06, 2014 at 11:03:40AM +0200, Ander Conselvan de Oliveira wrote: This simplifies the code quite a bit compared to iterating over all rings during the

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3

2014-11-06 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 09:04:14AM +, Chris Wilson wrote: On Wed, Nov 05, 2014 at 02:26:06PM -0800, Jesse Barnes wrote: +static int intel_set_mode(struct drm_crtc *crtc, + struct drm_display_mode *mode, + int x, int y, struct drm_framebuffer *fb)

[Intel-gfx] [RFC] drm/i915: Infrastructure for supporting different GGTT views per object

2014-11-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Things like reliable GGTT mmaps and mirrored 2d-on-3d display will need to map objects into the same address space multiple times. This also means that objects now can have multiple VMA entries. Added a GGTT view concept and linked it with the VMA

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Cache HPLL frequency on VLV/CHV

2014-11-06 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 04:02:10PM +0200, Imre Deak wrote: On Tue, 2014-10-07 at 17:41 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We need the HPLL frequency when calculating cdclk. Currently we read that out from the hardware every

Re: [Intel-gfx] [PATCH] drm/i915: Support creation of unbound wc user mappings for objects

2014-11-06 Thread Daniel Vetter
On Wed, Nov 05, 2014 at 12:48:35PM +, Chris Wilson wrote: On Thu, Oct 23, 2014 at 05:55:47PM +0100, Chris Wilson wrote: From: Akash Goel akash.g...@intel.com This patch provides support to create write-combining virtual mappings of GEM object. It intends to provide the same

Re: [Intel-gfx] [PATCH] drm/i915: safeguard against too high minimum brightness

2014-11-06 Thread Jani Nikula
On Wed, 05 Nov 2014, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Nov 05, 2014 at 02:46:31PM +0200, Jani Nikula wrote: Never trust (your interpretation of) the VBT. Regression from commit 6dda730e55f412a6dfb181cae6784822ba463847 Author: Jani Nikula jani.nik...@intel.com Date: Tue Jun 24

Re: [Intel-gfx] [PATCH] drm/i915: Disable caches for Global GTT.

2014-11-06 Thread Jani Nikula
On Thu, 06 Nov 2014, Rodrigo Vivi rodrigo.v...@intel.com wrote: Global GTT doesn't have pat_sel[2:0] so it always point to pat_sel = 000; So the only way to avoid screen corruptions is setting PAT 0 to Uncached. MOCS can still be used though. But if userspace is trusting PTE for cache

Re: [Intel-gfx] [PATCH] drm/i915: Add haswell_pcode_write function

2014-11-06 Thread O'Rourke, Tom
On Thu, Nov 06, 2014 at 10:28:53AM +0200, Ville Syrjälä wrote: On Wed, Nov 05, 2014 at 05:32:44PM -0800, Tom.O'rou...@intel.com wrote: From: Tom O'Rourke Tom.O'rou...@intel.com Based on sandybridge_pcode_write, haswell_pcode_write has an additional field for address control. It's

Re: [Intel-gfx] [PATCH v3 2/5] drm/i915: Use batch pools with the command parser

2014-11-06 Thread Volkin, Bradley D
On Thu, Nov 06, 2014 at 05:56:36AM -0800, Daniel Vetter wrote: On Thu, Nov 06, 2014 at 07:36:55AM +, Chris Wilson wrote: On Wed, Nov 05, 2014 at 02:42:00PM -0800, Volkin, Bradley D wrote: For this part, I've got an implementation that works ok but one difference is that if we stop

Re: [Intel-gfx] [PATCH 15/17] drm/atomic-helpers: functions for state duplicate/destroy/reset

2014-11-06 Thread Sean Paul
On Sun, Nov 02, 2014 at 02:19:28PM +0100, Daniel Vetter wrote: The atomic users and helpers assume that there is always a obj-state structure around. Which means drivers need to somehow create that at driver load time. Also it should obviously reset hardware state, so needs to be reset upon

Re: [Intel-gfx] [PATCH 14/17] drm/atomic-helper: implement -page_flip

2014-11-06 Thread Sean Paul
On Sun, Nov 02, 2014 at 02:19:27PM +0100, Daniel Vetter wrote: Currently there is no way to implement async flips using atomic, that essentially requires us to be able to cancel pending requests mid-flight. To be able to do that (and I guess we want this since vblank synced updates whic

Re: [Intel-gfx] [PATCH 13/17] drm/atomic-helpers: document how to implement async commit

2014-11-06 Thread Sean Paul
On Sun, Nov 02, 2014 at 02:19:26PM +0100, Daniel Vetter wrote: No helper function to do it all yet provided since no driver has support for driver core fences yet. Which we'd need to make the implementation really generic. v2: Clarify async howto a bit per the discussion With Rob Clark. Cc:

Re: [Intel-gfx] [PATCH 16/17] drm: Docbook integration and over sections for all the new helpers

2014-11-06 Thread Sean Paul
On Sun, Nov 02, 2014 at 02:19:29PM +0100, Daniel Vetter wrote: In all cases the text requires that new drivers are converted to the atomic interfaces. v2: Add overview for state handling. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- Documentation/DocBook/drm.tmpl | 20

Re: [Intel-gfx] [PATCH 17/17] drm/atomic: Refcounting for plane_state-fb

2014-11-06 Thread Sean Paul
On Sun, Nov 02, 2014 at 02:19:30PM +0100, Daniel Vetter wrote: So my original plan was that the drm core refcounts framebuffers like with the legacy ioctls. But that doesn't work for a bunch of reasons: - State objects might live longer than until the next fb change happens for a plane. For

Re: [Intel-gfx] [PATCH 14/17] drm/atomic-helper: implement -page_flip

2014-11-06 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 12:43:34PM -0500, Sean Paul wrote: On Sun, Nov 02, 2014 at 02:19:27PM +0100, Daniel Vetter wrote: + state-acquire_ctx = drm_modeset_legacy_acquire_ctx(crtc); +retry: + crtc_state = drm_atomic_get_crtc_state(state, crtc); + if (IS_ERR(crtc_state)) { + ret =

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Add PSR registers for PSR VLV/CHV.

2014-11-06 Thread R, Durgadoss
Hi Rodrigo, -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Rodrigo Vivi Sent: Wednesday, October 29, 2014 12:16 AM To: intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: [Intel-gfx] [PATCH 01/10] drm/i915: Add PSR registers for PSR

Re: [Intel-gfx] [PATCH] drm/i915: Add haswell_pcode_write function

2014-11-06 Thread Ville Syrjälä
On Thu, Nov 06, 2014 at 09:35:48AM -0800, O'Rourke, Tom wrote: On Thu, Nov 06, 2014 at 10:28:53AM +0200, Ville Syrjälä wrote: On Wed, Nov 05, 2014 at 05:32:44PM -0800, Tom.O'rou...@intel.com wrote: From: Tom O'Rourke Tom.O'rou...@intel.com Based on sandybridge_pcode_write,

Re: [Intel-gfx] [PATCH 02/10] drm/i915: VLV PSR: Status/enabled function.

2014-11-06 Thread R, Durgadoss
-Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Rodrigo Vivi Sent: Wednesday, October 29, 2014 12:16 AM To: intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: [Intel-gfx] [PATCH 02/10] drm/i915: VLV PSR: Status/enabled function.

Re: [Intel-gfx] [PATCH 10/17] drm: Atomic crtc/connector updates using crtc/plane helper interfaces

2014-11-06 Thread Sean Paul
On Wed, Nov 5, 2014 at 4:44 PM, Daniel Vetter dan...@ffwll.ch wrote: I've applied all the other nits, replies to the more interesting bits below. On Wed, Nov 05, 2014 at 01:53:48PM -0500, Sean Paul wrote: On Sun, Nov 02, 2014 at 02:19:23PM +0100, Daniel Vetter wrote: + if (new_encoder !=

Re: [Intel-gfx] [PATCH] drm/atomic-helper: implementatations for legacy interfaces

2014-11-06 Thread Sean Paul
On Wed, Nov 5, 2014 at 5:01 PM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Nov 05, 2014 at 02:48:48PM -0500, Sean Paul wrote: + if (!crtc crtc != set-crtc) I think this should be an || Hm. My idea idea was actually something along the lines of diff --git

Re: [Intel-gfx] [PATCH 04/10] drm/i915: PSR VLV/CHV: Introduce setup, enable and disable functions

2014-11-06 Thread R, Durgadoss
-Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Rodrigo Vivi Sent: Wednesday, October 29, 2014 12:16 AM To: intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: [Intel-gfx] [PATCH 04/10] drm/i915: PSR VLV/CHV: Introduce setup, enable

Re: [Intel-gfx] [PATCH 07/10] drm/i915: VLV/CHV PSR: Increase wait delay time before active PSR.

2014-11-06 Thread R, Durgadoss
-Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Rodrigo Vivi Sent: Wednesday, October 29, 2014 12:16 AM To: intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: [Intel-gfx] [PATCH 07/10] drm/i915: VLV/CHV PSR: Increase wait delay time

Re: [Intel-gfx] [PATCH 06/10] drm/i915: VLV/CHV PSR Software timer mode control

2014-11-06 Thread R, Durgadoss
-Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Rodrigo Vivi Sent: Wednesday, October 29, 2014 12:16 AM To: intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: [Intel-gfx] [PATCH 06/10] drm/i915: VLV/CHV PSR Software timer mode

Re: [Intel-gfx] [PATCH 08/10] drm/i915: VLV/CHV PSR debugfs.

2014-11-06 Thread R, Durgadoss
-Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Rodrigo Vivi Sent: Wednesday, October 29, 2014 12:16 AM To: intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: [Intel-gfx] [PATCH 08/10] drm/i915: VLV/CHV PSR debugfs. Add debugfs

Re: [Intel-gfx] [PATCH 14/17] drm/atomic-helper: implement -page_flip

2014-11-06 Thread Sean Paul
On Thu, Nov 6, 2014 at 1:13 PM, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Nov 06, 2014 at 12:43:34PM -0500, Sean Paul wrote: On Sun, Nov 02, 2014 at 02:19:27PM +0100, Daniel Vetter wrote: + state-acquire_ctx = drm_modeset_legacy_acquire_ctx(crtc); +retry: + crtc_state =

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Enable PSR for Baytrail and Braswell.

2014-11-06 Thread R, Durgadoss
-Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Rodrigo Vivi Sent: Wednesday, October 29, 2014 12:16 AM To: intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: [Intel-gfx] [PATCH 10/10] drm/i915: Enable PSR for Baytrail and

Re: [Intel-gfx] [PATCH] drm/i915: Disable caches for Global GTT.

2014-11-06 Thread Ville Syrjälä
On Thu, Nov 06, 2014 at 10:55:12AM +, Chris Wilson wrote: On Wed, Nov 05, 2014 at 12:11:41PM +0100, Daniel Vetter wrote: On Thu, Oct 30, 2014 at 5:18 PM, Rodrigo Vivi rodrigo.v...@intel.com wrote: Global GTT doesn't have pat_sel[2:0] so it always point to pat_sel = 000; So the only

[Intel-gfx] [PATCH] drm/atomic-helpers: functions for state duplicate/destroy/reset

2014-11-06 Thread Daniel Vetter
The atomic users and helpers assume that there is always a obj-state structure around. Which means drivers need to somehow create that at driver load time. Also it should obviously reset hardware state, so needs to be reset upon resume. Finally the destroy/duplicate_state functions are an awful

Re: [Intel-gfx] [PATCH 15/17] drm/atomic-helpers: functions for state duplicate/destroy/reset

2014-11-06 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 12:43:43PM -0500, Sean Paul wrote: On Sun, Nov 02, 2014 at 02:19:28PM +0100, Daniel Vetter wrote: The atomic users and helpers assume that there is always a obj-state structure around. Which means drivers need to somehow create that at driver load time. Also it

[Intel-gfx] [PATCH] drm: Docbook integration and over sections for all the new helpers

2014-11-06 Thread Daniel Vetter
In all cases the text requires that new drivers are converted to the atomic interfaces. v2: Add overview for state handling. v3: Review from Sean: Some spelling fixes and drop the misguided hunk to remove rgba from the plane helpers compat list. Cc: Sean Paul seanp...@chromium.org

Re: [Intel-gfx] [PATCH 15/17] drm/atomic-helpers: functions for state duplicate/destroy/reset

2014-11-06 Thread Sean Paul
On Thu, Nov 6, 2014 at 2:57 PM, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Nov 06, 2014 at 12:43:43PM -0500, Sean Paul wrote: On Sun, Nov 02, 2014 at 02:19:28PM +0100, Daniel Vetter wrote: The atomic users and helpers assume that there is always a obj-state structure around. Which means

Re: [Intel-gfx] [PATCH] drm: Docbook integration and over sections for all the new helpers

2014-11-06 Thread Sean Paul
On Thu, Nov 6, 2014 at 3:00 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: In all cases the text requires that new drivers are converted to the atomic interfaces. v2: Add overview for state handling. v3: Review from Sean: Some spelling fixes and drop the misguided hunk to remove rgba

Re: [Intel-gfx] [PATCH] drm/i915: Add haswell_pcode_write function

2014-11-06 Thread O'Rourke, Tom
On Thu, Nov 06, 2014 at 08:18:46PM +0200, Ville Syrjälä wrote: On Thu, Nov 06, 2014 at 09:35:48AM -0800, O'Rourke, Tom wrote: On Thu, Nov 06, 2014 at 10:28:53AM +0200, Ville Syrjälä wrote: On Wed, Nov 05, 2014 at 05:32:44PM -0800, Tom.O'rou...@intel.com wrote: From: Tom O'Rourke

Re: [Intel-gfx] [PATCH] drm/i915: Disable caches for Global GTT.

2014-11-06 Thread Ville Syrjälä
On Thu, Nov 06, 2014 at 09:09:52PM +0200, Ville Syrjälä wrote: On Thu, Nov 06, 2014 at 10:55:12AM +, Chris Wilson wrote: On Wed, Nov 05, 2014 at 12:11:41PM +0100, Daniel Vetter wrote: On Thu, Oct 30, 2014 at 5:18 PM, Rodrigo Vivi rodrigo.v...@intel.com wrote: Global GTT doesn't

Re: [Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

2014-11-06 Thread Jesse Barnes
On Tue, 21 Oct 2014 16:50:12 +0300 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Thu, Sep 11, 2014 at 07:15:27AM -0700, Jesse Barnes wrote: On Thu, 11 Sep 2014 14:59:35 +0300 Imre Deak imre.d...@intel.com wrote: On Thu, 2014-09-11 at 08:49 +0100, Chris Wilson wrote: On Wed,

Re: [Intel-gfx] [PATCH] drm/i915: Disable caches for Global GTT.

2014-11-06 Thread Rodrigo Vivi
On Thu, Nov 6, 2014 at 12:53 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Thu, Nov 06, 2014 at 09:09:52PM +0200, Ville Syrjälä wrote: On Thu, Nov 06, 2014 at 10:55:12AM +, Chris Wilson wrote: On Wed, Nov 05, 2014 at 12:11:41PM +0100, Daniel Vetter wrote: On Thu, Oct 30,

Re: [Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-06 Thread Rob Clark
On Thu, Nov 6, 2014 at 4:43 AM, Daniel Vetter dan...@ffwll.ch wrote: Hi all, After a few atomic irc chats I've shockingly realized that I've completely ignored dpms handling in my helper series. Oops. But there's a few things which are seriously wrong with DPMS, so I've figured I'll start a

Re: [Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-06 Thread Sean Paul
On Thu, Nov 6, 2014 at 5:06 PM, Rob Clark robdcl...@gmail.com wrote: On Thu, Nov 6, 2014 at 4:43 AM, Daniel Vetter dan...@ffwll.ch wrote: Hi all, After a few atomic irc chats I've shockingly realized that I've completely ignored dpms handling in my helper series. Oops. But there's a few

Re: [Intel-gfx] [PATCH 1/2] tests/gem_exec_parse: fix batch_len setting for cmd-crossing-page

2014-11-06 Thread Volkin, Bradley D
Ping on this series. They're related to the batch copy series, but the changes are valid and tests should still pass even without the kernel changes being merged. On Mon, Nov 03, 2014 at 11:18:59AM -0800, Volkin, Bradley D wrote: From: Brad Volkin bradley.d.vol...@intel.com The size of the

Re: [Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-06 Thread Daniel Vetter
2. Cloned configurations Currently dpms is set per-connector, and the crtc helpers only shut down the specific encoder. Only when all connectors are off will it shut down the crtc, too. That pretty much defeats the point of the new helpers of always enabling/disabling a given output pipeline

Re: [Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-06 Thread Stéphane Marchesin
On Thu, Nov 6, 2014 at 1:43 AM, Daniel Vetter dan...@ffwll.ch wrote: Hi all, After a few atomic irc chats I've shockingly realized that I've completely ignored dpms handling in my helper series. Oops. But there's a few things which are seriously wrong with DPMS, so I've figured I'll start

Re: [Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-06 Thread Daniel Vetter
On Thu, Nov 6, 2014 at 11:35 PM, Sean Paul seanp...@chromium.org wrote: Proposal: Only shut down anything (and then the hole output pipe with all cloned outputs) when all connector's dpms property is set to off. And enable it again as soon as one property goes to on. Well, it isn't quite the

Re: [Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-06 Thread Daniel Vetter
On Fri, Nov 7, 2014 at 12:33 AM, Daniel Vetter dan...@ffwll.ch wrote: All this only matters for cloned configs anyway only, which is about i915 for gen2, roughly. Well Ville implemented cloning for some more recent stuff too. Ok, I've grepped: Beside i915 there's only radeon which has a

Re: [Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-06 Thread Daniel Vetter
On Fri, Nov 7, 2014 at 12:31 AM, Stéphane Marchesin stephane.marche...@gmail.com wrote: On Thu, Nov 6, 2014 at 1:43 AM, Daniel Vetter dan...@ffwll.ch wrote: Hi all, After a few atomic irc chats I've shockingly realized that I've completely ignored dpms handling in my helper series. Oops.

Re: [Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-06 Thread Rob Clark
On Thu, Nov 6, 2014 at 6:29 PM, Daniel Vetter dan...@ffwll.ch wrote: Proposal. Add a new boolean -active to the crtc state, which will track the dpms state of the crtc. Add a helper to the atomic core functions which will compute -active from the state update according to the proposals for

[Intel-gfx] Sandy Bridge GPU hangs after mode switch

2014-11-06 Thread Sanchez, AdolfoX
Hello here are some details about the problem. -Operative System: QNX -Symptoms: Aproximately 1 out of 200 video mode switches will cause the CPU to hang during the next 30-60 VSYNC signals after the mode switches.After hang up most motherboards switch power off after 5-10 seconds. The mode