Re: [Intel-gfx] [PATCH v4 14/18] drm/i915: object size needs to be u64

2015-07-08 Thread Michel Thierry
On 7/7/2015 9:08 PM, Chris Wilson wrote: On Tue, Jul 07, 2015 at 04:44:30PM +0100, Michel Thierry wrote: On 7/7/2015 4:27 PM, Chris Wilson wrote: On Tue, Jul 07, 2015 at 04:14:59PM +0100, Michel Thierry wrote: In a 48b world, users can try to allocate buffers bigger than 4GB; in these cases it

Re: [Intel-gfx] [PATCH] drm/i915: Resign firmware loading for dmc

2015-07-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6744 -Summary- Platform Delta drm-intel-nightly Series Applied ILK

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use crtc_state->active in primary check_plane func

2015-07-08 Thread Maarten Lankhorst
Op 07-07-15 om 11:15 schreef Daniel Vetter: > Since > > commit 8c7b5ccb729870e606321b3703e2c2e698c49a95 > Author: Ander Conselvan de Oliveira > Date: Tue Apr 21 17:13:19 2015 +0300 > > drm/i915: Use atomic helpers for computing changed flags > > we compute the plane state for a modeset befor

Re: [Intel-gfx] [PATCH] drm/i915: Restore all GGTT VMAs on resume

2015-07-08 Thread Daniel Vetter
On Wed, Jul 08, 2015 at 10:45:23AM +0100, Tvrtko Ursulin wrote: > > On 07/08/2015 10:32 AM, Daniel Vetter wrote: > >On Mon, Jul 06, 2015 at 04:19:01PM +0100, Chris Wilson wrote: > >>On Mon, Jul 06, 2015 at 03:15:01PM +0100, Tvrtko Ursulin wrote: > >>>From: Tvrtko Ursulin > >>> > >>>When rotated a

Re: [Intel-gfx] [PATCH 4/6] drm/i915: add FBC_IN_DBG_MASTER no_fbc_reason

2015-07-08 Thread Chris Wilson
On Wed, Jul 08, 2015 at 11:38:02AM +0200, Daniel Vetter wrote: > On Tue, Jul 07, 2015 at 03:26:06PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > The poor in_dbg_master() check was the only one without a reason > > string. Give it a reason string so it won't feel excluded. > > > > Si

Re: [Intel-gfx] [PATCH] drm/i915: Restore all GGTT VMAs on resume

2015-07-08 Thread Tvrtko Ursulin
On 07/08/2015 10:32 AM, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 04:19:01PM +0100, Chris Wilson wrote: On Mon, Jul 06, 2015 at 03:15:01PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When rotated and partial views were added no one spotted the resume path which assumes only one GGTT

Re: [Intel-gfx] [PATCH 3/7] drm/i915: PSR: dirty fb operation flushsing frontbuffer

2015-07-08 Thread Daniel Vetter
On Tue, Jul 07, 2015 at 04:28:53PM -0700, Rodrigo Vivi wrote: > Let's do a frontbuffer flush on dirty fb. > To be used for DIRTYFB drm ioctl. > > This patch solves the biggest PSR known issue, that is > missed screen updates during boot, mainly when there is a splash > screen involved like Plymout

Re: [Intel-gfx] [PATCH 6/7] drm/i915: fbdev_set_par reliably invalidating frontbuffer

2015-07-08 Thread Daniel Vetter
On Tue, Jul 07, 2015 at 04:28:56PM -0700, Rodrigo Vivi wrote: > fbdev_set_par is called when fbcon is taking over control, but > frontbuffer was being invalidated only on the first time when > moving obj to GTT domain. > However on the following calls write domain was already GTT > so invalidate wa

Re: [Intel-gfx] [PATCH] drm/i915: Adjust BXT HDMI port clock limits

2015-07-08 Thread Kannan, Vandana
On 7/6/2015 5:14 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Since commit e62925567c7926e78bc8ca976cde5c28ea265a49 Author: Vandana Kannan Date: Wed Jul 1 17:02:57 2015 +0530 drm/i915/bxt: BUNs related to port PLL BXT DPLL can now generate frequencies in the 21

Re: [Intel-gfx] [PATCH 0/6] FBC bikesheds

2015-07-08 Thread Daniel Vetter
On Tue, Jul 07, 2015 at 08:53:23PM +0100, Chris Wilson wrote: > On Tue, Jul 07, 2015 at 03:26:02PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > Before I continue sending fixes, let's just do some small adjustments to the > > codebase. I really think these changes make the code better

Re: [Intel-gfx] [PATCH] drm/i915: Update wa_ctx_emit() macro as per kernel coding guidelines

2015-07-08 Thread Chris Wilson
On Wed, Jul 08, 2015 at 10:27:05AM +0100, Arun Siluvery wrote: > wa_ctx_emit() depends on the name of a local variable; if the name of that > variable is changed then we get compile errors. In this case it is unlikely > to be changed as this macro is only used in this set of functions but > Kernel

Re: [Intel-gfx] [PATCH 4/6] drm/i915: add FBC_IN_DBG_MASTER no_fbc_reason

2015-07-08 Thread Daniel Vetter
On Tue, Jul 07, 2015 at 03:26:06PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > The poor in_dbg_master() check was the only one without a reason > string. Give it a reason string so it won't feel excluded. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + >

Re: [Intel-gfx] [PATCH v2 06/20] drm/i915: Allow fuzzy matching in pipe_config_compare.

2015-07-08 Thread Daniel Vetter
On Wed, Jul 08, 2015 at 11:18:27AM +0200, Maarten Lankhorst wrote: > Op 08-07-15 om 11:09 schreef Daniel Vetter: > > On Wed, Jul 08, 2015 at 10:38:33AM +0200, Maarten Lankhorst wrote: > >> Op 07-07-15 om 12:11 schreef Daniel Vetter: > >>> On Tue, Jul 07, 2015 at 09:08:17AM +0200, Maarten Lankhorst

[Intel-gfx] [PATCH] drm/i915: Update wa_ctx_emit() macro as per kernel coding guidelines

2015-07-08 Thread Arun Siluvery
wa_ctx_emit() depends on the name of a local variable; if the name of that variable is changed then we get compile errors. In this case it is unlikely to be changed as this macro is only used in this set of functions but Kernel coding guidelines doesn't recommend doing this. It was my mistake as I

Re: [Intel-gfx] [PATCH] drm/i915: Restore all GGTT VMAs on resume

2015-07-08 Thread Daniel Vetter
On Mon, Jul 06, 2015 at 04:19:01PM +0100, Chris Wilson wrote: > On Mon, Jul 06, 2015 at 03:15:01PM +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > When rotated and partial views were added no one spotted the resume > > path which assumes only one GGTT VMA per object and hence is now

Re: [Intel-gfx] [PATCH v2 07/20] drm/i915: Rework primary plane stuff slightly.

2015-07-08 Thread Daniel Vetter
On Tue, Jul 07, 2015 at 04:02:32PM +0200, Maarten Lankhorst wrote: > Op 07-07-15 om 13:16 schreef Daniel Vetter: > > On Tue, Jul 07, 2015 at 09:08:18AM +0200, Maarten Lankhorst wrote: > >> Make sure the primary plane is set up correctly. This is done by > >> setting plane_state->src and plane_state

Re: [Intel-gfx] [PATCH v2 06/20] drm/i915: Allow fuzzy matching in pipe_config_compare.

2015-07-08 Thread Maarten Lankhorst
Op 08-07-15 om 11:09 schreef Daniel Vetter: > On Wed, Jul 08, 2015 at 10:38:33AM +0200, Maarten Lankhorst wrote: >> Op 07-07-15 om 12:11 schreef Daniel Vetter: >>> On Tue, Jul 07, 2015 at 09:08:17AM +0200, Maarten Lankhorst wrote: @@ -12392,27 +12379,124 @@ static bool intel_fuzzy_clock_check(

Re: [Intel-gfx] [PATCH v2 06/20] drm/i915: Allow fuzzy matching in pipe_config_compare.

2015-07-08 Thread Daniel Vetter
On Wed, Jul 08, 2015 at 10:38:33AM +0200, Maarten Lankhorst wrote: > Op 07-07-15 om 12:11 schreef Daniel Vetter: > > On Tue, Jul 07, 2015 at 09:08:17AM +0200, Maarten Lankhorst wrote: > >> @@ -12392,27 +12379,124 @@ static bool intel_fuzzy_clock_check(int clock1, > >> int clock2) > >>

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make fb user dirty operation to invalidate frontbuffer

2015-07-08 Thread Daniel Vetter
On Tue, Jul 07, 2015 at 08:23:46PM +, Vivi, Rodrigo wrote: > On Tue, 2015-07-07 at 13:24 +0200, Daniel Vetter wrote: > > On Mon, Jul 06, 2015 at 11:19:03PM +, Vivi, Rodrigo wrote: > > > On Mon, 2015-07-06 at 19:56 +0200, Daniel Vetter wrote: > > > > On Mon, Jul 06, 2015 at 02:11:55PM -0300,

Re: [Intel-gfx] [PATCH v2 02/20] drm: Don't update plane properties for atomic planes if it stays the same

2015-07-08 Thread Daniel Vetter
On Wed, Jul 08, 2015 at 10:00:22AM +0200, Maarten Lankhorst wrote: > Op 07-07-15 om 18:43 schreef Daniel Vetter: > > On Tue, Jul 07, 2015 at 05:08:34PM +0200, Maarten Lankhorst wrote: > >> Op 07-07-15 om 14:10 schreef Daniel Vetter: > >>> On Tue, Jul 07, 2015 at 12:20:10PM +0200, Maarten Lankhorst

Re: [Intel-gfx] [PATCH v2 03/20] drm/i915: Fix noatomic crtc disabling.

2015-07-08 Thread Maarten Lankhorst
Op 08-07-15 om 10:12 schreef Patrik Jakobsson: > On Tue, Jul 07, 2015 at 04:14:01PM +0200, Maarten Lankhorst wrote: >> Op 07-07-15 om 14:39 schreef Patrik Jakobsson: >>> On Tue, Jul 07, 2015 at 12:22:12PM +0200, Maarten Lankhorst wrote: Op 07-07-15 om 11:18 schreef Daniel Vetter: > On Tue,

Re: [Intel-gfx] [PATCH] drm/i915: Handle HPD when it has actually occurred

2015-07-08 Thread Ville Syrjälä
On Wed, Jul 08, 2015 at 10:40:18AM +0530, Jindal, Sonika wrote: > > > On 7/7/2015 6:51 PM, Ville Syrjälä wrote: > > On Tue, Jul 07, 2015 at 02:22:20PM +0530, Sonika Jindal wrote: > >> Writing to PCH_PORT_HOTPLUG for each interrupt is not required. > >> Handle it only if hpd has actually occurred

Re: [Intel-gfx] [PATCH v2 06/20] drm/i915: Allow fuzzy matching in pipe_config_compare.

2015-07-08 Thread Maarten Lankhorst
Op 07-07-15 om 12:11 schreef Daniel Vetter: > On Tue, Jul 07, 2015 at 09:08:17AM +0200, Maarten Lankhorst wrote: >> Instead of doing ad-hoc checks we already have a way of checking >> if the state is compatible or not. Use this to force a modeset. >> >> Only during modesets, or with PIPE_CONFIG_QUI

Re: [Intel-gfx] [PATCH] drm/i915: Handle HPD when it has actually occurred

2015-07-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6740 -Summary- Platform Delta drm-intel-nightly Series Applied ILK

Re: [Intel-gfx] [PATCH v2 03/20] drm/i915: Fix noatomic crtc disabling.

2015-07-08 Thread Patrik Jakobsson
On Tue, Jul 07, 2015 at 04:14:01PM +0200, Maarten Lankhorst wrote: > Op 07-07-15 om 14:39 schreef Patrik Jakobsson: > > On Tue, Jul 07, 2015 at 12:22:12PM +0200, Maarten Lankhorst wrote: > >> Op 07-07-15 om 11:18 schreef Daniel Vetter: > >>> On Tue, Jul 07, 2015 at 09:08:14AM +0200, Maarten Lankhor

Re: [Intel-gfx] [PATCH v2 02/20] drm: Don't update plane properties for atomic planes if it stays the same

2015-07-08 Thread Maarten Lankhorst
Op 07-07-15 om 18:43 schreef Daniel Vetter: > On Tue, Jul 07, 2015 at 05:08:34PM +0200, Maarten Lankhorst wrote: >> Op 07-07-15 om 14:10 schreef Daniel Vetter: >>> On Tue, Jul 07, 2015 at 12:20:10PM +0200, Maarten Lankhorst wrote: Op 07-07-15 om 11:18 schreef Daniel Vetter: > On Tue, Jul 0

Re: [Intel-gfx] WARNING: CPU: 0 PID: 3634 at drivers/gpu/drm/drm_irq.c:1141 drm_wait_one_vblank

2015-07-08 Thread Michal Hocko
On Wed 08-07-15 09:32:18, Daniel Vetter wrote: [...] > Ok that's starting to get nasty. Can you please test what happens when you > boot with drm.vblankoffdelay=0 and whether drm.vblankoffdelay=1000 has an > effect on reproduction rate? No debug output needed. No difference. See the kernel log fro

Re: [Intel-gfx] WARNING: CPU: 0 PID: 3634 at drivers/gpu/drm/drm_irq.c:1141 drm_wait_one_vblank

2015-07-08 Thread Daniel Vetter
On Wed, Jul 08, 2015 at 08:40:17AM +0200, Michal Hocko wrote: > I have just tried to boot 4.2-rc1 and cannot seem to reproduce the issue > anymore. > > On Tue 07-07-15 10:43:58, Daniel Vetter wrote: > [...] > > Can you please > > boot with drm.debug=0xf (lots more nois in dmesg with this) and repr

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Convert execlist_submit_contexts() for requests

2015-07-08 Thread Mika Kuoppala
Yu Dai writes: > On 07/07/2015 09:49 AM, Yu Dai wrote: >> On 07/03/2015 07:09 AM, Mika Kuoppala wrote: >> > Pass around requests to carry context deeper in callchain. >> > >> > Signed-off-by: Mika Kuoppala >> > --- >> > drivers/gpu/drm/i915/intel_lrc.c | 30 ++ >> >

[Intel-gfx] [PATCH v3 0/2] Extending GET_APERTURE ioctl

2015-07-08 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma When constructing a batchbuffer, it is sometimes crucial to know the largest hole into which we can fit a fenceable buffer (for example when handling very large objects on gen2 and gen3). This depends on the fragmentation of pinned buffers inside the aperture, a question

[Intel-gfx] [PATCH 1/2] drm/i915: Extend GET_APERTURE ioctl to report available map space

2015-07-08 Thread ankitprasad . r . sharma
From: Rodrigo Vivi When constructing a batchbuffer, it is sometimes crucial to know the largest hole into which we can fit a fenceable buffer (for example when handling very large objects on gen2 and gen3). This depends on the fragmentation of pinned buffers inside the aperture, a question only t

[Intel-gfx] [PATCH 2/2] drm/i915: Extend GET_APERTURE ioctl to report size of the stolen region

2015-07-08 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch extends the GET_APERTURE ioctl to add support for getting total size and available size of the stolen region as well as single largest block available in the stolen region. Also adds debugfs support to retieve the size information of the stolen area. v2: respi

<    1   2