Re: [Intel-gfx] [PATCH 03/12] drm/i915: Framework for capturing command stream based OA reports and ctx id info.

Hi Chis, Understood the need to handle request reordering. Are you suggesting following paths: 1. cs samples list for stream be read based on the order of submission from submit timestamps/OA capture timestamps. 2. put the commands to capture during eb_submit and patch the offset in vma where

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Framework for capturing command stream based OA reports and ctx id info.

From: sourab gupta [mailto:sourabgu...@gmail.com] Sent: Wednesday, August 2, 2017 8:17 AM To: Landwerlin, Lionel G Cc: Kamble, Sagar A ; intel-gfx@lists.freedesktop.org; Sourab Gupta Subject: Re: [Intel-gfx]

Re: [Intel-gfx] [PATCH 0/8] Adding NV12 support

> -Original Message- > From: Paauwe, Bob J > Sent: Tuesday, August 1, 2017 11:04 PM > To: Daniel Vetter > Cc: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 0/8] Adding NV12 support > > On Mon, 31 Jul

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Framework for capturing command stream based OA reports and ctx id info.

On Wed, Aug 2, 2017 at 2:28 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 01/08/17 19:05, sourab gupta wrote: > > > > On Tue, Aug 1, 2017 at 2:59 PM, Kamble, Sagar A > wrote: > >> >> >> -Original Message- >> From: Landwerlin, Lionel G >>

[Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/nouveau/nv50_display.c between commit: 4a5431af19bc ("drm/nouveau/kms/nv50: update vblank state in response to modeset actions") from Linus' tree and commit: 3c847d6cdadb ("drm/nouveau: Convert

Re: [Intel-gfx] [PATCH] drm/i915: Update the status of connector when receiving MST unplug event

On Wed, 2017-08-02 at 01:49 +, Pandiyan, Dhinakaran wrote: > On Tue, 2017-08-01 at 16:51 +0800, Ethan Hsieh wrote: > > We do not update the status of connector when receiving MST unplug event. > > Call detect function to get latest status and then update status of > > connector. > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Update the status of connector when receiving MST unplug event

On Tue, 2017-08-01 at 16:51 +0800, Ethan Hsieh wrote: > We do not update the status of connector when receiving MST unplug event. > Call detect function to get latest status and then update status of connector. > Cc'ing Daniel and Chris. Thanks for sending this to the list. The issue is

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Get alternate aux for port E from VBT.

== Series Details == Series: drm/i915: Get alternate aux for port E from VBT. URL : https://patchwork.freedesktop.org/series/28216/ State : warning == Summary == Series 28216v1 drm/i915: Get alternate aux for port E from VBT.

[Intel-gfx] [PATCH] drm/i915: Get alternate aux for port E from VBT.

If VBT states that it uses an alternate aux for port E, let's use it since even on new platforms there is no dedicated aux for port E and it is being used for VGA with DP-to-VGA converter by some OEMs. Let's assume that port A is in use for eDP so let's keep the default to port D to minimize the

Re: [Intel-gfx] [PATCH] Add drm ioctl DRM_IOCTL_MODE_GETFB2 & associated helpers.

On Tue, Aug 1, 2017 at 1:46 PM, Laurent Pinchart < laurent.pinch...@ideasonboard.com> wrote: > Hi Joe, > > On Tuesday 01 Aug 2017 10:24:25 Joe Kniss wrote: > > On Tue, Aug 1, 2017 at 5:09 AM, Laurent Pinchart wrote: > > > On Monday 31 Jul 2017 11:29:13 Joe Kniss wrote: > > >> New getfb2

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

On Mon, 2017-07-31 at 15:41 -0700, Puthikorn Voravootivat wrote: > > But now you're suggesting another arbitrary narrow selection of panels > > based on limited evidence. > > I understand your point that the panel I observe is not the > representative of the real world. > > My point is that

Re: [Intel-gfx] [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

On Tuesday, August 1, 2017 3:47:53 PM PDT Ben Widawsky wrote: > On 17-08-01 15:43:50, Kenneth Graunke wrote: > >On Tuesday, August 1, 2017 9:58:17 AM PDT Ben Widawsky wrote: > >> v2: > >> - Support sprite plane. > >> - Support pipe C/D limitation on GEN9. > >> > >> v3: > >> - Rename

Re: [Intel-gfx] [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

On Tuesday, August 1, 2017 9:58:17 AM PDT Ben Widawsky wrote: > v2: > - Support sprite plane. > - Support pipe C/D limitation on GEN9. > > v3: > - Rename structure (Ville) > - Handle GLK (Ville) > > v4: > - Fix PIPE_C check, introduced in v2 (Daniel) > - Whitespace fix (Daniel) > >

Re: [Intel-gfx] [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

On 17-08-01 15:43:50, Kenneth Graunke wrote: On Tuesday, August 1, 2017 9:58:17 AM PDT Ben Widawsky wrote: v2: - Support sprite plane. - Support pipe C/D limitation on GEN9. v3: - Rename structure (Ville) - Handle GLK (Ville) v4: - Fix PIPE_C check, introduced in v2 (Daniel) -

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

On Tue, 25 Jul 2017 17:28:18 +0800 Tina Zhang wrote: > Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user mode query and > get the plan and its related information. > > The dma-buf's life cycle is handled by user mode and tracked by kernel. > The returned fd in

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Framework for capturing command stream based OA reports and ctx id info.

On 01/08/17 19:05, sourab gupta wrote: On Tue, Aug 1, 2017 at 2:59 PM, Kamble, Sagar A > wrote: -Original Message- From: Landwerlin, Lionel G Sent: Monday, July 31, 2017 9:16 PM To: Kamble, Sagar A

Re: [Intel-gfx] [PATCH] Add drm ioctl DRM_IOCTL_MODE_GETFB2 & associated helpers.

Hi Joe, On Tuesday 01 Aug 2017 10:24:25 Joe Kniss wrote: > On Tue, Aug 1, 2017 at 5:09 AM, Laurent Pinchart wrote: > > On Monday 31 Jul 2017 11:29:13 Joe Kniss wrote: > >> New getfb2 functionality uses drm_mode_fb_cmd2 struct to be symmetric > >> with addfb2. > > > > What's the use case for this

Re: [Intel-gfx] [PATCH] drm/i915/cnl: DDIA Lane capability bit not set in clone mode

+ Art, couple questions below On Tue, 2017-08-01 at 09:56 -0700, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > DDIA Lane capability control 4 lane bit is not being set by firmware during > clone mode boot. This occurs when multiple monitors are connected

Re: [Intel-gfx] [PATCH 0/4] Userptr bo slab use optimization

On 17-07-27 10:25:51, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-07-27 10:05:00) From: Tvrtko Ursulin Yet another attempt to get this series reviewed and merged... I've heard Vulkan might be creating a lot of userptr objects so might be interesting to check

Re: [Intel-gfx] [PATCH 0/8] Adding NV12 support

On Mon, 31 Jul 2017 10:41:48 +0200 Daniel Vetter wrote: > On Mon, Jul 31, 2017 at 12:34:45PM +0530, Vidya Srinivas wrote: > > This patch series is adding NV12 support for Broxton display after > > rebasing on latest drm-intel-nightly. Initial series of the patches > > can be

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Implement .get_format_info() hook for CCS

== Series Details == Series: series starting with [1/6] drm/i915: Implement .get_format_info() hook for CCS URL : https://patchwork.freedesktop.org/series/28205/ State : success == Summary == Series 28205v1 Series without cover letter

Re: [Intel-gfx] [PATCH] Add drm ioctl DRM_IOCTL_MODE_GETFB2 & associated helpers.

Thanks for the quick review! On Tue, Aug 1, 2017 at 5:09 AM, Laurent Pinchart wrote: > Hi Joe, > > Thank you for the patch. > > On Monday 31 Jul 2017 11:29:13 Joe Kniss wrote: > > New getfb2 functionality uses drm_mode_fb_cmd2 struct to be symmetric > > with

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: DDIA Lane capability bit not set in clone mode

== Series Details == Series: drm/i915/cnl: DDIA Lane capability bit not set in clone mode URL : https://patchwork.freedesktop.org/series/28204/ State : success == Summary == Series 28204v1 drm/i915/cnl: DDIA Lane capability bit not set in clone mode

[Intel-gfx] [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

v2: - Support sprite plane. - Support pipe C/D limitation on GEN9. v3: - Rename structure (Ville) - Handle GLK (Ville) v4: - Fix PIPE_C check, introduced in v2 (Daniel) - Whitespace fix (Daniel) Cc: Daniel Stone Cc: Kristian Høgsberg

[Intel-gfx] [PATCH 5/6] [v10] drm/i915: Add format modifiers for Intel

This was based on a patch originally by Kristian. It has been modified pretty heavily to use the new callbacks from the previous patch. v2: - Add LINEAR and Yf modifiers to list (Ville) - Combine i8xx and i965 into one list of formats (Ville) - Allow 1010102 formats for Y/Yf tiled (Ville)

[Intel-gfx] [PATCH 4/6] [v5] drm: Create a format/modifier blob

Updated blob layout (Rob, Daniel, Kristian, xerpi) v2: * Removed __packed, and alignment (.+) * Fix indent in drm_format_modifier fields (Liviu) * Remove duplicated modifier > 64 check (Liviu) * Change comment about modifier (Liviu) * Remove arguments to blob creation, use plane instead (Liviu) *

[Intel-gfx] [PATCH 2/6] drm/i915: Add render decompression support

From: Ville Syrjälä SKL+ display engine can scan out certain kinds of compressed surfaces produced by the render engine. This involved telling the display engine the location of the color control surfae (CCS) which describes which parts of the main surface are

[Intel-gfx] [PATCH 3/6] [v7] drm: Plumb modifiers through plane init

This is the plumbing for supporting fb modifiers on planes. Modifiers have already been introduced to some extent, but this series will extend this to allow querying modifiers per plane. Based on this, the client to enable optimal modifications for framebuffers. This patch simply allows the DRM

[Intel-gfx] [PATCH 1/6] drm/i915: Implement .get_format_info() hook for CCS

From: Ville Syrjälä SKL+ display engine can scan out certain kinds of compressed surfaces produced by the render engine. This involved telling the display engine the location of the color control surfae (CCS) which describes which parts of the main surface are

[Intel-gfx] [PATCH] drm/i915/cnl: DDIA Lane capability bit not set in clone mode

From: Clint Taylor DDIA Lane capability control 4 lane bit is not being set by firmware during clone mode boot. This occurs when multiple monitors are connected during boot. The driver will configure the port for 2 lane maximum width if this bit is not set. Once

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

On 17-07-31 10:29:55, Daniel Vetter wrote: On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote: On 17-07-29 13:53:10, Daniel Stone wrote: > Hi Ben, > > On 26 July 2017 at 19:08, Ben Widawsky wrote: > > + } else if (INTEL_GEN(dev_priv) >= 9) { > >

Re: [Intel-gfx] [PATCH 1/4] fbcon: Make fbcon a built-time depency for fbdev

On Wednesday, July 12, 2017 12:40:45 PM Bartlomiej Zolnierkiewicz wrote: > On Thursday, July 06, 2017 02:57:32 PM Daniel Vetter wrote: > > There's a bunch of folks who're trying to make printk less > > contended and faster, but there's a problem: printk uses the > > console_lock, and the console

Re: [Intel-gfx] [PATCH] fbdev: Nuke FBINFO_MODULE

On Thursday, July 13, 2017 04:01:50 PM Bartlomiej Zolnierkiewicz wrote: > On Wednesday, July 12, 2017 05:07:42 PM Daniel Vetter wrote: > > On Wed, Jul 12, 2017 at 2:54 PM, Bartlomiej Zolnierkiewicz > > wrote: > > > On Wednesday, July 12, 2017 02:42:14 PM Daniel Vetter

Re: [Intel-gfx] [PATCH v8 6/6] drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONFIG interface

On 1 August 2017 at 11:58, Lionel Landwerlin wrote: > On 31/07/17 18:36, Matthew Auld wrote: >> >> On 28 July 2017 at 18:10, Lionel Landwerlin >> wrote: >>> >>> The motivation behind this new interface is expose at runtime the >>>

Re: [Intel-gfx] [PATCH] Add drm ioctl DRM_IOCTL_MODE_GETFB2 & associated helpers.

Hi Joe, Thank you for the patch. On Monday 31 Jul 2017 11:29:13 Joe Kniss wrote: > New getfb2 functionality uses drm_mode_fb_cmd2 struct to be symmetric > with addfb2. What's the use case for this ? We haven't needed such an ioctl for so long that it seemed to me that userspace doesn't really

Re: [Intel-gfx] [PATCH v8 6/6] drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONFIG interface

On 31/07/17 18:36, Matthew Auld wrote: On 28 July 2017 at 18:10, Lionel Landwerlin wrote: The motivation behind this new interface is expose at runtime the creation of new OA configs which can be used as part of the i915 perf open interface. This will enable the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unnecessary scaler output max size check

== Series Details == Series: drm/i915: Remove unnecessary scaler output max size check URL : https://patchwork.freedesktop.org/series/28187/ State : success == Summary == Series 28187v1 drm/i915: Remove unnecessary scaler output max size check

Re: [Intel-gfx] [PATCH v8 6/6] drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONFIG interface

Hi Andrzej, Okay, I'll remove 0x20CC from the Haswell whitelist. Those changes are supposed to cover gen7.5->gen9. The difference from your initial request should be Gen10 registers. Cheers, - Lionel On 01/08/17 10:33, Datczuk, Andrzej wrote: Hi Lionel, Despite the fact the current

[Intel-gfx] [PATCH] drm/i915: Remove unnecessary scaler output max size check

There is no upper limit of maximum size of scaler output. Check is removed. Signed-off-by: Nabendu Maiti --- drivers/gpu/drm/i915/intel_display.c | 4 +--- drivers/gpu/drm/i915/intel_drv.h | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v2 4/7] drm/omapdrm: Fix omap_atomic_wait_for_completion

Op 25-07-17 om 10:27 schreef Daniel Vetter: > On Wed, Jul 19, 2017 at 04:39:17PM +0200, Maarten Lankhorst wrote: >> Use the new iterator macro and look for crtc_state->active instead of >> enable, only crtc_state->enable implies that vblanks will happen. > s/enable/active/, since enable only means

Re: [Intel-gfx] [PATCH v8 6/6] drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONFIG interface

Hi Lionel, Despite the fact the current whitelist covers less registers than we sent, it looks like it covers all we need. One comment, according to Marek, whitelisting 0x20CC (selective slice programming) makes sense only since gen8. Just to make sure, are these changes intended also for

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Framework for capturing command stream based OA reports and ctx id info.

-Original Message- From: Landwerlin, Lionel G Sent: Monday, July 31, 2017 9:16 PM To: Kamble, Sagar A ; intel-gfx@lists.freedesktop.org Cc: Sourab Gupta Subject: Re: [Intel-gfx] [PATCH 03/12] drm/i915: Framework for capturing command

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Prevent compiler warning on unchecked printf format

On Thu, 2017-07-27 at 01:51 -0300, Gabriel Krisman Bertazi wrote: > Commit 34a54192e1fb ("lib/igt_debugfs: Add extended helper to format > crc to string") introduced the following compiler warning: > > igt_debugfs.c: In function ‘igt_crc_to_string_extended’: > igt_debugfs.c:373:4: warning:

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Prevent compiler warning on unchecked printf format

On Thu, Jul 27, 2017 at 01:51:28AM -0300, Gabriel Krisman Bertazi wrote: > Commit 34a54192e1fb ("lib/igt_debugfs: Add extended helper to format > crc to string") introduced the following compiler warning: > > igt_debugfs.c: In function ‘igt_crc_to_string_extended’: > igt_debugfs.c:373:4:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Update the status of connector when receiving MST unplug event

== Series Details == Series: drm/i915: Update the status of connector when receiving MST unplug event URL : https://patchwork.freedesktop.org/series/28181/ State : success == Summary == Series 28181v1 drm/i915: Update the status of connector when receiving MST unplug event

[Intel-gfx] [PATCH] drm/i915: Update the status of connector when receiving MST unplug event

We do not update the status of connector when receiving MST unplug event. Call detect function to get latest status and then update status of connector. Before applying the patch: [313.665321] [drm:intel_get_hpd_pins [i915]] hotplug event received, stat 0x0020, dig 0x10101012, pins

Re: [Intel-gfx] [PATCH i-g-t] tests: kms_pipe_color: only test existing properties

On Thu, Jul 27, 2017 at 05:45:28PM +0100, Lionel Landwerlin wrote: > Some platforms might not have degamma or ctm support. > We can only verify whether those properties behave properly > if they're available. > > Fixes: aa55641d4 ("tests/kms_color: New test for pipe level color management") >

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Change get_existing_crtc_state to old state

On Tuesday 01 August 2017 01:23 PM, Maarten Lankhorst wrote: Hey, Op 01-08-17 om 08:46 schreef Mahesh Kumar: Hi, As per my understanding "get_existing_*_state == get_new_*_state" It looks like you are trying to use currently available unused wrapper for completely different purpose. But

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Use intel_atomic_get_new_crtc_state in intel_fbc.c

Hi, patch looks ok to me. Reviewed-by: Mahesh Kumar On Thursday 20 July 2017 06:45 PM, Maarten Lankhorst wrote: The previous commit added intel_atomic_get_new_crtc_state, convert intel_fbc.c to the new helper. Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Change use get_new_plane_state instead of existing plane state

Op 01-08-17 om 08:36 schreef Mahesh Kumar: > Hi, > > > On Thursday 20 July 2017 06:45 PM, Maarten Lankhorst wrote: >> The get_existing macros are deprecated and should be replaced by >> get_old/new_state for clarity. >> >> Signed-off-by: Maarten Lankhorst >> ---

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Change get_existing_crtc_state to old state

Hey, Op 01-08-17 om 08:46 schreef Mahesh Kumar: > Hi, > > As per my understanding "get_existing_*_state == get_new_*_state" > > It looks like you are trying to use currently available unused wrapper for > completely different purpose. But IMHO you should create a new wrapper for > get_old_state

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Use new atomic helpers in intel_plane_atomic_check

Hi, On Thursday 20 July 2017 06:45 PM, Maarten Lankhorst wrote: Remove the use of plane->state and drm_atomic_get_existing_state, instead use the new helpers, and also add intel_atomic_get_new_crtc_state as it's needed. Signed-off-by: Maarten Lankhorst ---

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Change get_existing_crtc_state to old state

Hi, As per my understanding "get_existing_*_state == get_new_*_state" It looks like you are trying to use currently available unused wrapper for completely different purpose. But IMHO you should create a new wrapper for get_old_state & this should be renamed to get_new_state. :) -Mahesh

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Change use get_new_plane_state instead of existing plane state

Hi, On Thursday 20 July 2017 06:45 PM, Maarten Lankhorst wrote: The get_existing macros are deprecated and should be replaced by get_old/new_state for clarity. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic.c | 4 ++--