[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add ppgtt to GVT GEM context

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915: Add ppgtt to GVT GEM context URL : https://patchwork.freedesktop.org/series/51156/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5ad4fca13845 drm/i915: Add ppgtt to GVT GEM context -:54: CHECK:BRACES: braces {} should be used on all arms

[Intel-gfx] [PATCH] drm/i915: Add ppgtt to GVT GEM context

2018-10-17 Thread Xiong Zhang
Currently the guest couldn't boot up under GVT-g environment as the following call trace exists: [ 272.504762] BUG: unable to handle kernel NULL pointer dereference at 0100 [ 272.504834] Call Trace: [ 272.504852] execlists_context_pin+0x2b2/0x520 [i915] [ 272.504869]

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/6] drm/i915/guc: drop negative doorbell alloc selftest

2018-10-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915/guc: drop negative doorbell alloc selftest URL : https://patchwork.freedesktop.org/series/51153/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5000 -> Patchwork_10499 = == Summary - FAILURE == Serious

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/6] drm/i915/guc: drop negative doorbell alloc selftest

2018-10-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915/guc: drop negative doorbell alloc selftest URL : https://patchwork.freedesktop.org/series/51153/ State : warning == Summary == $ dim checkpatch origin/drm-tip fa13f8331474 drm/i915/guc: drop negative doorbell alloc selftest

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix signal_levels

2018-10-17 Thread Rodrigo Vivi
On Wed, Oct 17, 2018 at 03:09:54PM -0700, Manasi Navare wrote: > On Wed, Oct 17, 2018 at 02:56:52PM -0700, Rodrigo Vivi wrote: > > Since when it was introduced we forgot to add > > this case so ICL was using a wrong signal_levels > > as reference. > > > > Fixes: fb5c8e9d4350 ("drm/i915/icl:

[Intel-gfx] [PATCH v2 1/6] drm/i915/guc: drop negative doorbell alloc selftest

2018-10-17 Thread Daniele Ceraolo Spurio
The test requires driver tweaks to avoid causing error messages on intentionally-triggered errors and to stop accessing non existing register. However, this is a pure GuC FW interface test and should be covered by FW validation, so it isn't really worth tweaking the driver for it and we're better

[Intel-gfx] [PATCH v2 5/6] drm/i915/guc: fix comment about fallback to execlists

2018-10-17 Thread Daniele Ceraolo Spurio
We stopped supporting fallback to execlists in commit 121981fafe69 (drm/i915/guc: Combine enable_guc_loading|submission modparams). We do instead reset and retry in some cases, depending on the workarounds required by the platform. Cc: Michal Wajdeczko Cc: Chris Wilson Signed-off-by: Daniele

[Intel-gfx] [PATCH v2 4/6] drm/i915/guc: doorbell checking cleanup

2018-10-17 Thread Daniele Ceraolo Spurio
A collection of very small cleanups/improvements around doorbell checking that do not deserve their own patch: - Move doorbell-related HW defs to intel_guc_reg.h - use GUC_NUM_DOORBELLS instead of GUC_DOORBELL_INVALID where appropriate - do not stop on error in guc_verify_doorbells - do not

[Intel-gfx] [PATCH v2 2/6] drm/i915/guc: rename __create/destroy_doorbell

2018-10-17 Thread Daniele Ceraolo Spurio
The 2 functions don't create or destroy anything, they just update the doorbell state in memory. Use init and fini instead for clarity. Cc: Michal Wajdeczko Reviewed-by: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/intel_guc_submission.c | 12 ++-- 1

[Intel-gfx] [PATCH v2 3/6] drm/i915/guc: reserve the doorbell before selecting the cacheline

2018-10-17 Thread Daniele Ceraolo Spurio
Cacheline selection is only needed if we actually manage to reserve a doorbell. Cc: Michal Wajdeczko Reviewed-by: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/intel_guc_submission.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH v2 6/6] HAX enable GuC for CI

2018-10-17 Thread Daniele Ceraolo Spurio
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 7e56c516c815..c681537bcb92 100644 ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Fix signal_levels

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix signal_levels URL : https://patchwork.freedesktop.org/series/51143/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5000_full -> Patchwork_10496_full = == Summary - SUCCESS == No regressions found. == Known issues ==

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: Limit number of scratch registers used for H2G

2018-10-17 Thread Daniele Ceraolo Spurio
On 17/10/18 13:05, Michal Wajdeczko wrote: We wrongly assumed that GuC is only using last scratch register for G2H messages, but in fact it is also using register [14] to report sleep state status. Remove that register from our H2G send registers pool. v2: No message from host to GuC uses

Re: [Intel-gfx] [PATCH] drm/i915/guc: Propagate the fw xfer timeout

2018-10-17 Thread Michal Wajdeczko
On Thu, 18 Oct 2018 01:09:19 +0200, Daniele Ceraolo Spurio wrote: On 17/10/18 13:29, Chris Wilson wrote: Propagate the timeout on transferring the fw back to the caller where it may act upon it, usually by restarting the xfer before failing. Did you see any case where we failed the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdmi: Detect HDMI 2.0 monitors using multiple EDID capabilities

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: Detect HDMI 2.0 monitors using multiple EDID capabilities URL : https://patchwork.freedesktop.org/series/51150/ State : failure == Summary == CALLscripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M]

[Intel-gfx] [PATCH] drm/i915/hdmi: Detect HDMI 2.0 monitors using multiple EDID capabilities

2018-10-17 Thread clinton . a . taylor
From: Clint Taylor HDMI 2.0 monitors may not support SCDC and still be able to accept VICs above 63. Use multiple EDID capbilities to determine if the SINK is actually an HDMI 2.0 device. The QD980B HDMI 2.0 Analyzer generates unique EDIDs during CTS tests that don't contain a HDMI Forum VSDB if

Re: [Intel-gfx] [PATCH] drm/i915/guc: Propagate the fw xfer timeout

2018-10-17 Thread Daniele Ceraolo Spurio
On 17/10/18 13:29, Chris Wilson wrote: Propagate the timeout on transferring the fw back to the caller where it may act upon it, usually by restarting the xfer before failing. Did you see any case where we failed the xfer and didn't get a timeout out of guc_wait_ucode? that'd be quite

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/drm_vblank: Change EINVAL by the correct errno

2018-10-17 Thread Patchwork
== Series Details == Series: drm/drm_vblank: Change EINVAL by the correct errno URL : https://patchwork.freedesktop.org/series/51147/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5000 -> Patchwork_10497 = == Summary - FAILURE == Serious unknown changes coming with

[Intel-gfx] [FOR CI] drm/drm_vblank: Change EINVAL by the correct errno

2018-10-17 Thread Rodrigo Siqueira
For historical reason, the function drm_wait_vblank_ioctl always return -EINVAL if something gets wrong. This scenario limits the flexibility for the userspace make detailed verification of the problem and take some action. In particular, the validation of “if (!dev->irq_enabled)” in the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Fix signal_levels

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix signal_levels URL : https://patchwork.freedesktop.org/series/51143/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5000 -> Patchwork_10496 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Propagate the fw xfer timeout

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/guc: Propagate the fw xfer timeout URL : https://patchwork.freedesktop.org/series/51140/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5000_full -> Patchwork_10495_full = == Summary - SUCCESS == No regressions found. == Known

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915/icl: Add WaEnable32PlaneMode

2018-10-17 Thread Srivatsa, Anusha
>-Original Message- >From: Sripada, Radhakrishna >Sent: Thursday, October 4, 2018 11:30 AM >To: intel-gfx@lists.freedesktop.org >Cc: Sripada, Radhakrishna ; Chris Wilson >; Thierry, Michel ; Ausmus, >James ; Srivatsa, Anusha > >Subject: [PATCH v2 1/6] drm/i915/icl: Add

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix signal_levels

2018-10-17 Thread Manasi Navare
On Wed, Oct 17, 2018 at 02:56:52PM -0700, Rodrigo Vivi wrote: > Since when it was introduced we forgot to add > this case so ICL was using a wrong signal_levels > as reference. > > Fixes: fb5c8e9d4350 ("drm/i915/icl: Implement voltage swing programming > sequence for Combo PHY DDI") > Cc: José

[Intel-gfx] [PATCH] drm/i915/icl: Fix signal_levels

2018-10-17 Thread Rodrigo Vivi
Since when it was introduced we forgot to add this case so ICL was using a wrong signal_levels as reference. Fixes: fb5c8e9d4350 ("drm/i915/icl: Implement voltage swing programming sequence for Combo PHY DDI") Cc: José Roberto de Souza Cc: Manasi Navare Signed-off-by: Rodrigo Vivi ---

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/icl: Implement Display WA_1405510057

2018-10-17 Thread Srivatsa, Anusha
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Radhakrishna Sripada >Sent: Thursday, October 4, 2018 11:30 AM >To: intel-gfx@lists.freedesktop.org >Cc: Vivi, Rodrigo ; Zanoni, Paulo R > >Subject: [Intel-gfx] [PATCH v2 2/6]

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/huc: Normalize HuC status returned by I915_PARAM_HAS_HUC (rev2)

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/huc: Normalize HuC status returned by I915_PARAM_HAS_HUC (rev2) URL : https://patchwork.freedesktop.org/series/51060/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5000_full -> Patchwork_10493_full = == Summary - WARNING == Minor

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Propagate the fw xfer timeout

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/guc: Propagate the fw xfer timeout URL : https://patchwork.freedesktop.org/series/51140/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5000 -> Patchwork_10495 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/guc: Limit number of scratch registers used for H2G

2018-10-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/guc: Limit number of scratch registers used for H2G URL : https://patchwork.freedesktop.org/series/51137/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5000 -> Patchwork_10494 = == Summary - FAILURE ==

Re: [Intel-gfx] [RFC] GuC firmware versioning change

2018-10-17 Thread Srivatsa, Anusha
>-Original Message- >From: Mcgee, Jeff >Sent: Friday, October 12, 2018 2:33 PM >To: Vivi, Rodrigo >Cc: intel-gfx@lists.freedesktop.org; Srivatsa, Anusha >; Spotswood, John A >; joonas.lahti...@linux.intel.com >Subject: Re: [RFC] GuC firmware versioning change > >On Fri, Oct 12, 2018 at

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-17 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-10-17 17:40:50) > On Wed, 17 Oct 2018 00:46:47 +0200, Daniele Ceraolo Spurio > wrote: > > > The ENTER/EXIT_S_STATE actions queue the save/restore operation in GuC > > FW and then return, so waiting on the H2G is not enough to guarantee > > GuC is done. > > When

[Intel-gfx] [PATCH] drm/i915/guc: Propagate the fw xfer timeout

2018-10-17 Thread Chris Wilson
Propagate the timeout on transferring the fw back to the caller where it may act upon it, usually by restarting the xfer before failing. Testcase: igt/drv_selftest/live_hangcheck Signed-off-by: Chris Wilson Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/huc: Normalize HuC status returned by I915_PARAM_HAS_HUC (rev2)

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/huc: Normalize HuC status returned by I915_PARAM_HAS_HUC (rev2) URL : https://patchwork.freedesktop.org/series/51060/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5000 -> Patchwork_10493 = == Summary - SUCCESS == No regressions

[Intel-gfx] [PULL] drm-misc-next-fixes

2018-10-17 Thread Sean Paul
Hi Dave, Just one quirk this week, things are shaping up nicely for the upcoming merge window! drm-misc-next-fixes-2018-10-17: - Add quirk to fix orientation of Acer One 10 (S1003) panel (Hans) Cc: Hans de Goede Cheers, Sean The following changes since commit

[Intel-gfx] [PATCH v2 2/2] HAX: Enable GuC for CI

2018-10-17 Thread Michal Wajdeczko
GuC is disabled by default. Enable it. Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 7e56c51..c681537 100644 ---

[Intel-gfx] [PATCH v2 1/2] drm/i915/guc: Limit number of scratch registers used for H2G

2018-10-17 Thread Michal Wajdeczko
We wrongly assumed that GuC is only using last scratch register for G2H messages, but in fact it is also using register [14] to report sleep state status. Remove that register from our H2G send registers pool. v2: No message from host to GuC uses more than 8 registers and the GuC FW itself uses

[Intel-gfx] [PATCH v2] drm/i915/huc: Normalize HuC status returned by I915_PARAM_HAS_HUC

2018-10-17 Thread Michal Wajdeczko
In response for I915_PARAM_HAS_HUC we are returning value that indicates if HuC firmware was loaded and verified. However, our previously used positive value was based on specific register bit which is about to change on future platform. Let's normalize our return values to 0 and 1 before clients

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/guc: rename __create/destroy_doorbell (rev2)

2018-10-17 Thread Daniele Ceraolo Spurio
On 17/10/18 12:10, Patchwork wrote: == Series Details == Series: series starting with [1/4] drm/i915/guc: rename __create/destroy_doorbell (rev2) URL : https://patchwork.freedesktop.org/series/51090/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5000 -> Patchwork_10492

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/guc: rename __create/destroy_doorbell (rev2)

2018-10-17 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/guc: rename __create/destroy_doorbell (rev2) URL : https://patchwork.freedesktop.org/series/51090/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5000 -> Patchwork_10492 = == Summary - FAILURE == Serious

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-17 Thread Patchwork
== Series Details == Series: drm: Get ref on CRTC commit object when waiting for flip_done URL : https://patchwork.freedesktop.org/series/51079/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4998_full -> Patchwork_10491_full = == Summary - SUCCESS == No regressions

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/guc: rename __create/destroy_doorbell (rev2)

2018-10-17 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/guc: rename __create/destroy_doorbell (rev2) URL : https://patchwork.freedesktop.org/series/51090/ State : warning == Summary == $ dim checkpatch origin/drm-tip f79da532bd81 drm/i915/guc: rename __create/destroy_doorbell

Re: [Intel-gfx] [RFC] drm/i915/guc: New GuC stage descriptors

2018-10-17 Thread Lis, Tomasz
On 2018-10-12 20:25, Daniele Ceraolo Spurio wrote: With the new interface, GuC now requires every lrc to be registered in one of the stage descriptors, which have been re-designed so that each descriptor can store up to 64 lrc per class (i.e. equal to the possible SW counter values). Similarly

[Intel-gfx] [PATCH v2] drm/i915/guc: doorbell checking cleanup

2018-10-17 Thread Daniele Ceraolo Spurio
A collection of very small cleanups/improvements around doorbell checking that do not deserve their own patch: - Move doorbell-related HW defs to intel_guc_reg.h - use GUC_NUM_DOORBELLS instead of GUC_DOORBELL_INVALID where appropriate - do not stop on error in guc_verify_doorbells - do not

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Add shmem GEM library

2018-10-17 Thread Patchwork
== Series Details == Series: drm: Add shmem GEM library URL : https://patchwork.freedesktop.org/series/51120/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4998_full -> Patchwork_10490_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_10490_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-17 Thread Patchwork
== Series Details == Series: drm: Get ref on CRTC commit object when waiting for flip_done URL : https://patchwork.freedesktop.org/series/51079/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4998 -> Patchwork_10491 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: do not print drbreg on error

2018-10-17 Thread Daniele Ceraolo Spurio
On 17/10/18 09:37, Michal Wajdeczko wrote: On Wed, 17 Oct 2018 02:17:17 +0200, Daniele Ceraolo Spurio wrote: The only content of the register apart from the valid bit is the lower part of the physical memory address. If the valid bit is 0 the address is meaningless, while if it is 1 we

Re: [Intel-gfx] [PATCH v5 20/28] drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling

2018-10-17 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Tuesday, October 16, 2018 2:03 PM >To: Srivatsa, Anusha >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Jani >Nikula >; Ville Syrjala >Subject: Re: [PATCH v5 20/28] drm/i915/dp: Configure i915 Picture parameter

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-17 Thread Michal Wajdeczko
On Wed, 17 Oct 2018 00:46:47 +0200, Daniele Ceraolo Spurio wrote: The ENTER/EXIT_S_STATE actions queue the save/restore operation in GuC FW and then return, so waiting on the H2G is not enough to guarantee GuC is done. When all the processing is done, GuC writes 0 to scratch register 14, so

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: do not print drbreg on error

2018-10-17 Thread Michal Wajdeczko
On Wed, 17 Oct 2018 02:17:17 +0200, Daniele Ceraolo Spurio wrote: The only content of the register apart from the valid bit is the lower part of the physical memory address. If the valid bit is 0 the address is meaningless, while if it is 1 we don't know which descriptor it came from (since

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-17 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Li, Sun peng (Leo) > Sent: keskiviikko 17. lokakuuta 2018 17.39 > To: intel-gfx@lists.freedesktop.org > Cc: Li, Sun peng (Leo) ; Daniel Vetter > ; Wentland, Harry > Subject: Re:

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: reserve the doorbell before selecting the cacheline

2018-10-17 Thread Michal Wajdeczko
On Wed, 17 Oct 2018 02:17:16 +0200, Daniele Ceraolo Spurio wrote: Cacheline selection is only needed if we actually manage to reserve a doorbell. Cc: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio --- Reviewed-by: Michal Wajdeczko ___

Re: [Intel-gfx] [PATCH 1/4] drm/i915/guc: rename __create/destroy_doorbell

2018-10-17 Thread Michal Wajdeczko
On Wed, 17 Oct 2018 02:17:15 +0200, Daniele Ceraolo Spurio wrote: The 2 functions don't create or destroy anything, they just update the doorbell state in memory. Use init and fini instead for clarity. Cc: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio --- Reviewed-by: Michal

Re: [Intel-gfx] [PATCH v5 4/5] drm: Add library for shmem backed GEM objects

2018-10-17 Thread Daniel Vetter
On Wed, Oct 17, 2018 at 03:04:53PM +0200, Noralf Trønnes wrote: > This adds a library for shmem backed GEM objects. > > v5: > - Drop drm_gem_shmem_prime_mmap() (Daniel Vetter) > - drm_gem_shmem_mmap(): Subtract drm_vma_node_start() to get the real > vma->vm_pgoff > - drm_gem_shmem_fault(): Use

Re: [Intel-gfx] [PATCH v5 2/5] drm/prime: Add drm_gem_prime_mmap()

2018-10-17 Thread Daniel Vetter
On Wed, Oct 17, 2018 at 03:04:51PM +0200, Noralf Trønnes wrote: > Add a generic PRIME GEM mmap function. > > Suggested-by: Daniel Vetter > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_prime.c | 37 + > include/drm/drm_prime.h | 1 + > 2

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/intel_dsi: Read back pclk set by GOP and use that as plck

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/intel_dsi: Read back pclk set by GOP and use that as plck URL : https://patchwork.freedesktop.org/series/51114/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4996_full -> Patchwork_10488_full = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-17 Thread Li, Sun peng (Leo)
On 2018-10-16 06:48 PM, Patchwork wrote: > == Series Details == > > Series: drm: Get ref on CRTC commit object when waiting for flip_done > URL : https://patchwork.freedesktop.org/series/51079/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4990_full ->

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Add shmem GEM library

2018-10-17 Thread Patchwork
== Series Details == Series: drm: Add shmem GEM library URL : https://patchwork.freedesktop.org/series/51120/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4998 -> Patchwork_10490 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Add shmem GEM library

2018-10-17 Thread Patchwork
== Series Details == Series: drm: Add shmem GEM library URL : https://patchwork.freedesktop.org/series/51120/ State : warning == Summary == $ dim checkpatch origin/drm-tip fe745f1947c0 drm/driver: Add defaults for .gem_prime_export/import callbacks 26dcb4c0c861 drm/prime: Add

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: dsi enabling (rev2)

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/icl: dsi enabling (rev2) URL : https://patchwork.freedesktop.org/series/51011/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4995_full -> Patchwork_10486_full = == Summary - WARNING == Minor unknown changes coming with

[Intel-gfx] [PATCH v5 4/5] drm: Add library for shmem backed GEM objects

2018-10-17 Thread Noralf Trønnes
This adds a library for shmem backed GEM objects. v5: - Drop drm_gem_shmem_prime_mmap() (Daniel Vetter) - drm_gem_shmem_mmap(): Subtract drm_vma_node_start() to get the real vma->vm_pgoff - drm_gem_shmem_fault(): Use vmf->pgoff now that vma->vm_pgoff is correct v4: - Drop cache modes (Thomas

[Intel-gfx] [PATCH v5 5/5] drm/tinydrm: Switch from CMA to shmem buffers

2018-10-17 Thread Noralf Trønnes
This move makes tinydrm useful for more drivers. tinydrm doesn't need continuous memory, but at the time it was convenient to use the CMA library. The spi core can do dma on is_vmalloc() addresses making this possible. Cc: David Lechner Signed-off-by: Noralf Trønnes Acked-by: David Lechner

Re: [Intel-gfx] [PATCH v2] drm/i915: GEM_WARN_ON considered harmful

2018-10-17 Thread Lis, Tomasz
On 2018-10-12 08:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin GEM_WARN_ON currently has dangerous semantics where it is completely compiled out on !GEM_DEBUG builds. This can leave users who expect it to be more like a WARN_ON, just without a warning in non-debug builds, in complete

[Intel-gfx] [PATCH v5 0/5] drm: Add shmem GEM library

2018-10-17 Thread Noralf Trønnes
This patchset adds a library for shmem backed GEM objects and makes use of it in tinydrm. Daniel suggested that I make a generic mmap function for GEM PRIME. I wondered if I could make it the default for drm_driver->gem_prime_mmap so I looked at all the drivers that don't set that callback: -

[Intel-gfx] [PATCH v5 3/5] drm/gem: Add drm_gem_object_funcs

2018-10-17 Thread Noralf Trønnes
This adds an optional function table on GEM objects. The main benefit is for drivers that support more than one type of memory (shmem,vram,cma) for their buffers depending on the hardware it runs on. With the callbacks attached to the GEM object itself, it is easier to have core helpers for the

[Intel-gfx] [PATCH v5 1/5] drm/driver: Add defaults for .gem_prime_export/import callbacks

2018-10-17 Thread Noralf Trønnes
The majority of drivers use drm_gem_prime_export() and drm_gem_prime_import() for these callbacks so let's make them the default. Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- Documentation/gpu/todo.rst | 7 +++ drivers/gpu/drm/drm_prime.c | 10 --

[Intel-gfx] [PATCH v5 2/5] drm/prime: Add drm_gem_prime_mmap()

2018-10-17 Thread Noralf Trønnes
Add a generic PRIME GEM mmap function. Suggested-by: Daniel Vetter Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_prime.c | 37 + include/drm/drm_prime.h | 1 + 2 files changed, 38 insertions(+) diff --git a/drivers/gpu/drm/drm_prime.c

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Remove crtc->config dereference from drrs_ctl

2018-10-17 Thread Maarten Lankhorst
Op 16-10-18 om 22:13 schreef Ville Syrjälä: > On Thu, Oct 11, 2018 at 12:04:48PM +0200, Maarten Lankhorst wrote: >> Wait for idle, and iterate over connectors instead of encoders. >> With this information we know crtc->state is the actual state, >> and we can enable/disable drrs safely. >> >>

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/quirks: pass dev_priv instead of drm dev to quirk code

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/quirks: pass dev_priv instead of drm dev to quirk code URL : https://patchwork.freedesktop.org/series/5/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4995_full -> Patchwork_10485_full = == Summary - SUCCESS == No regressions

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enabling the IGT for HDCP1.4 (rev2)

2018-10-17 Thread Patchwork
== Series Details == Series: Enabling the IGT for HDCP1.4 (rev2) URL : https://patchwork.freedesktop.org/series/51113/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4996 -> Patchwork_10489 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_10489

[Intel-gfx] [PATCH v2 2/4] drm/i915: Detect the hdcp capability of sink and src

2018-10-17 Thread Ramalingam C
Implements a function to detect the sink and src's hdcp1.4 capabilities. v2: const qualifier is maintained at init. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_hdcp.c | 33 +++-- 2 files changed, 28

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/intel_dsi: Read back pclk set by GOP and use that as plck

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/intel_dsi: Read back pclk set by GOP and use that as plck URL : https://patchwork.freedesktop.org/series/51114/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4996 -> Patchwork_10488 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/intel_dsi: Read back pclk set by GOP and use that as plck

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/intel_dsi: Read back pclk set by GOP and use that as plck URL : https://patchwork.freedesktop.org/series/51114/ State : warning == Summary == $ dim checkpatch origin/drm-tip 671e7f756caa drm/i915/intel_dsi: Move initialization of encoder variables up a

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enabling the IGT for HDCP1.4

2018-10-17 Thread Patchwork
== Series Details == Series: Enabling the IGT for HDCP1.4 URL : https://patchwork.freedesktop.org/series/51113/ State : failure == Summary == CALLscripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/intel_hdcp.o

[Intel-gfx] [PATCH v2 1/2] drm/i915/intel_dsi: Move initialization of encoder variables up a bit

2018-10-17 Thread Hans de Goede
Move the initialization of encoder variables a bit higher inside the intel_dsi_init() function. So that can call intel_encoder_current_mode() from intel_dsi_vbt_init(). This is a preparation patch for reading back the GOP configured pclk from intel_dsi_vbt_init(). Signed-off-by: Hans de Goede

[Intel-gfx] [PATCH v2 2/2] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk v2

2018-10-17 Thread Hans de Goede
On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) different frequency then the pclk which we've calculated. This commit makes the DSI code read-back the pclk set by the GOP and if that is within a reasonable margin of the calculated pclk, uses that instead. This fixes the

[Intel-gfx] [PATCH v2 0/2] drm/i915/intel_dsi: Read back pclk set by GOP and use that as plck

2018-10-17 Thread Hans de Goede
Hi All, I've send v1 of this a while ago. Unfortunately I did not have time to respin this until now. This version uses intel_encoder_current_mode() as suggested in the discussion of v1. This allows dropping 2 of the 4 original patches and makes the remaining patches quite small :) Regards,

[Intel-gfx] [PATCH 3/4] drm/i915: hdcp_check_link only on CP_IRQ

2018-10-17 Thread Ramalingam C
HDCP check link is invoked only on CP_IRQ detection, instead of all short pulses. v3: No Changes. v4: Added sean in cc and collected the reviewed-by received. v5: No Change. v6: No Change. v7: No Change. v8: Rebased. Signed-off-by: Ramalingam C cc: Sean Paul Reviewed-by: Uma

[Intel-gfx] [PATCH 2/4] drm/i915: Detect the hdcp capability of sink and src

2018-10-17 Thread Ramalingam C
Implements a function to detect the sink and src's hdcp1.4 capabilities. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_hdcp.c | 33 +++-- 2 files changed, 28 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 4/4] drm/i915/debugfs: sinks hdcp capabilities

2018-10-17 Thread Ramalingam C
debugfs entry for providing the hdcp capabilities of the sinks connected to the HDCP capable connectors. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/i915_debugfs.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH 1/4] drm/i915: Pullout the bksv read and validation

2018-10-17 Thread Ramalingam C
For reusability purpose, this patch implements the hdcp1.4 bksv's read and validation as a functions. For detecting the HDMI panel's HDCP capability this fucntions will be used. v2: Rebased. v3: No Changes. v4: inline tag is removed with modified error msg. v5: No Changes. v6: No

[Intel-gfx] [PATCH 0/4] Enabling the IGT for HDCP1.4

2018-10-17 Thread Ramalingam C
Adding a debugfs entry for detecting the valid HDCP sinks to perform kms_content_protection. In case of dummy HDMI/DP sinks(EDID whisperers without any parsers) IGT will skip the HDCP test on that connector instead of failing it. Hence false alarm are avoided. For serving above purpose this

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: dsi enabling (rev2)

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/icl: dsi enabling (rev2) URL : https://patchwork.freedesktop.org/series/51011/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4995 -> Patchwork_10486 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gen9+: Fix initial readout for Y tiled framebuffers

2018-10-17 Thread Imre Deak
On Tue, Oct 16, 2018 at 09:26:05PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gen9+: Fix initial readout for Y tiled framebuffers > URL : https://patchwork.freedesktop.org/series/51075/ > State : success Pushed to -dinq, thanks for the report, review and testing. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/quirks: pass dev_priv instead of drm dev to quirk code

2018-10-17 Thread Patchwork
== Series Details == Series: drm/i915/quirks: pass dev_priv instead of drm dev to quirk code URL : https://patchwork.freedesktop.org/series/5/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4995 -> Patchwork_10485 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH v2] drm/i915/quirks: pass dev_priv instead of drm dev to quirk code

2018-10-17 Thread Chris Wilson
Quoting Jani Nikula (2018-10-17 10:35:39) > Pass the type we want to simplify. No functional changes. > > v2: s/dev_priv/i915/g (Chris) > > Cc: Chris Wilson > Signed-off-by: Jani Nikula Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH 1/2] drm/i915: split out display quirks to a new file

2018-10-17 Thread Jani Nikula
On Tue, 16 Oct 2018, Chris Wilson wrote: > Quoting Jani Nikula (2018-10-16 15:42:27) >> Reduce intel_display.c by splitting out intel_quirks.c. No functional >> changes. >> >> Signed-off-by: Jani Nikula > > I was thinking intel_display_quirks, but it is dev_priv->quirks so that > seems over

[Intel-gfx] [PATCH v2] drm/i915/quirks: pass dev_priv instead of drm dev to quirk code

2018-10-17 Thread Jani Nikula
Pass the type we want to simplify. No functional changes. v2: s/dev_priv/i915/g (Chris) Cc: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_quirks.c | 39

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/fbdev: Use an ordinary worker to avoid async deadlock

2018-10-17 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/fbdev: Use an ordinary worker to avoid async deadlock URL : https://patchwork.freedesktop.org/series/51000/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4995 -> Patchwork_10484 = == Summary - FAILURE ==

Re: [Intel-gfx] [RFC v1 00/31] kunit: Introducing KUnit, the Linux kernel unit testing framework

2018-10-17 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 04:50:49PM -0700, Brendan Higgins wrote: > This patch set proposes KUnit, a lightweight unit testing and mocking > framework for the Linux kernel. > > Unlike Autotest and kselftest, KUnit is a true unit testing framework; > it does not require installing the kernel on a

[Intel-gfx] [PATCH v2] shmem, drm/i915: mark pinned shmemfs pages as unevictable

2018-10-17 Thread Kuo-Hsin Yang
The i915 driver uses shmemfs to allocate backing storage for gem objects. These shmemfs pages can be pinned (increased ref count) by shmem_read_mapping_page_gfp(). When a lot of pages are pinned, vmscan wastes a lot of time scanning these pinned pages. In some extreme case, all pages in the

Re: [Intel-gfx] [PATCH] drm/i915/huc: Normalize HuC status returned by I915_PARAM_HAS_HUC

2018-10-17 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-10-16 12:34:14) > In response for I915_PARAM_HAS_HUC we are returning value that > indicates if HuC firmware was loaded and verified. However, our > previously used positive value was based on specific register bit > which is about to change on future platform. Let's

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds

2018-10-17 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2018-10-17 00:03:38) > > > On 16/10/18 01:59, Michal Wajdeczko wrote: > > In commit 4502e9ec820d ("drm/i915/uc: Unify firmware loading") we > > stopped converting errors detected during firmware transfer into > > -EAGAIN and this indirectly killed our workarounds

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ensure intel_engine_init_execlist() builds with Clang

2018-10-17 Thread Jani Nikula
On Tue, 16 Oct 2018, Nick Desaulniers wrote: > On Tue, Oct 16, 2018 at 8:35 AM Stephen Boyd wrote: >> >> Quoting Jani Nikula (2018-10-16 05:29:38) >> > Clang build with UBSAN enabled leads to the following build error: > > I'm overjoyed that you're testing this configuration! If you find more >

Re: [Intel-gfx] [PATCH] drm/i915: rename and move intel_get_pipe_from_connector()

2018-10-17 Thread Jani Nikula
On Tue, 16 Oct 2018, Ville Syrjälä wrote: > On Tue, Oct 16, 2018 at 05:50:44PM +0300, Jani Nikula wrote: >> Rename intel_get_pipe_from_connector() to intel_connector_get_pipe() and >> move it near its connector function friends in intel_connector.c. No >> functional changes. >> >> Signed-off-by:

Re: [Intel-gfx] [PATCH v2] drm/atomic_helper: Stop modesets on unregistered connectors harder

2018-10-17 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 04:39:46PM -0400, Lyude Paul wrote: > Unfortunately, it appears our fix in: > commit b5d29843d8ef ("drm/atomic_helper: Allow DPMS On<->Off changes > for unregistered connectors") > > Which attempted to work around the problems introduced by: > commit 4d80273976bf