On 08/11/2019 01:34, Umesh Nerlige Ramappa wrote:
It turns out that the OAR CONTROL register is not getting configured
correctly in conjunction with the context save/restore bit. When
measuring work for a single context, the OAR counters do not increment.
- Configure OAR format and enable OAR
Hi Jani,
> -Original Message-
> From: Jani Nikula
> Sent: Thursday, November 07, 2019 5:46 PM
> To: Linus Torvalds ; Yamada, Masahiro/山田
> 真弘 ; linux-kbu...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 1/2] kbuild: remove
d forward
> struct declarations.
>
> Signed-off-by: Masahiro Yamada
> ---
I confirmed this patch is applicable to next-20191107
but CI fails to apply it.
Which branch should I base my patch on?
>
> drivers/gpu/drm/i915/gem/selftests/mock_context.h | 3 +++
> drivers/gpu/dr
Commit a096883dda2c ("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object
VMA")
fixed it, remove the hack.
---
baseline: f681b0ac20073c08e34f5987800b35f45fb69e29
pile-commit: 3f2a85eed3a5be81b1ab3e02426c368f20e5be82
range-diff:
156: 31c4b0cc66c6 < -: INTEL_DII: drm/i915/dg1:
== Series Details ==
Series: series starting with [1/2] drm/i915: change to_mock() to an inline
function
URL : https://patchwork.freedesktop.org/series/69169/
State : failure
== Summary ==
Applying: drm/i915: change to_mock() to an inline function
Applying: drm/i915: make more headers
== Series Details ==
Series: drm/i915/gt: Cleanup heartbeat systole first
URL : https://patchwork.freedesktop.org/series/69095/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7277_full -> Patchwork_15167_full
Summary
Since this function is defined in a header file, it should be
'static inline' instead of 'static'.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/i915/gem/selftests/mock_dmabuf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The headers in the gem/selftests/, gt/selftests, gvt/, selftests/
directories have never been compile-tested, but it would be possible
to make them self-contained.
This commit only addresses missing and forward
struct declarations.
Signed-off-by: Masahiro Yamada
---
== Series Details ==
Series: Start removing legacy guc code
URL : https://patchwork.freedesktop.org/series/69094/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7277_full -> Patchwork_15166_full
Summary
---
== Series Details ==
Series: drm/i915: Leave the aliasing-ppgtt size alone
URL : https://patchwork.freedesktop.org/series/69093/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7276_full -> Patchwork_15165_full
Summary
== Series Details ==
Series: series starting with [1/4] drm/i915/opregion: fix leaking fw on error
path
URL : https://patchwork.freedesktop.org/series/69167/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7290 -> Patchwork_15190
== Series Details ==
Series: series starting with [1/4] drm/i915/opregion: fix leaking fw on error
path
URL : https://patchwork.freedesktop.org/series/69167/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915/opregion: fix leaking fw on error
== Series Details ==
Series: drm/i915/perf: Configure OAR controls for specific context (rev2)
URL : https://patchwork.freedesktop.org/series/69165/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7290 -> Patchwork_15189
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Add GuC method to determine if
submission is active.
URL : https://patchwork.freedesktop.org/series/69086/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7276_full -> Patchwork_15163_full
== Series Details ==
Series: drm/i915/perf: Configure OAR controls for specific context (rev2)
URL : https://patchwork.freedesktop.org/series/69165/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
351573b952cc drm/i915/perf: Configure OAR controls for specific context
-:65:
== Series Details ==
Series: drm/i915/selftests: Mark up sole accessor to ctx->vm as being protected
URL : https://patchwork.freedesktop.org/series/69161/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7290 -> Patchwork_15188
== Series Details ==
Series: series starting with [1/3] drm/i915/display: Fix
TRANS_DDI_MST_TRANSPORT_SELECT definition
URL : https://patchwork.freedesktop.org/series/69160/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7290 -> Patchwork_15187
On Thu, Nov 07, 2019 at 11:22:34PM +0200, Stanislav Lisovskiy wrote:
> Also implemented algorithm for choosing DBuf slice configuration
> based on active pipes, pipe ratio as stated in BSpec 12716.
>
> Now pipe allocation still stays proportional to pipe width as before,
> however within allowed
Hi all,
This is now a conflict between the drm tree and Linus' tree.
On Thu, 31 Oct 2019 11:33:15 +1100 Stephen Rothwell
wrote:
>
> Today's linux-next merge of the drm tree got a conflict in:
>
> drivers/gpu/drm/i915/i915_drv.h
>
> between commit:
>
> 59cd826fb5e7 ("drm/i915: Fix PCH
oprom is actually a better name to use when using
pci_map_rom(). "bios" is way too generic and confusing.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/display/intel_bios.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
When we call intel_bios_is_valid_vbt(), size may not actually be the
size of the VBT, but rather the size of the blob the VBT is contained
in. For example, when mapping the PCI oprom, size will be the entire
oprom size. We don't want to read beyond what is reported to be the
VBT. So make sure we
Convert the code to return-early style and fix missing calls
to release_firmware() if vbt is not valid.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/display/intel_opregion.c | 28 +++
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git
When we are mapping the VBT through pci_map_rom() we may not be allowed
to simply discard the address space and go on reading the memory. After
checking on my test system that dumping the rom via sysfs I could
actually get the correct vbt, I decided to change the implementation to
use the same
== Series Details ==
Series: drm/i915/selftests: Complete transition to a real struct file mock
URL : https://patchwork.freedesktop.org/series/69159/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7290 -> Patchwork_15186
19. 8. 1. 오전 1:58에 Andrzej Pietrasiewicz 이(가) 쓴 글:
> Switch to using the ddc provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz
> Acked-by: Sam Ravnborg
> Reviewed-by: Emil Velikov
Acked-by: Inki Dae
Thanks,
Inki Dae
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c
== Series Details ==
Series: drm/i915: Enable second dbuf slice for ICL and TGL (rev2)
URL : https://patchwork.freedesktop.org/series/69124/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7290 -> Patchwork_15185
Summary
== Series Details ==
Series: drm/i915/selftests: Complete transition to a real struct file mock
URL : https://patchwork.freedesktop.org/series/69159/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7013ed43c85d drm/i915/selftests: Complete transition to a real struct file mock
== Series Details ==
Series: drm/i915/gvt: fix dropping obj reference twice
URL : https://patchwork.freedesktop.org/series/69084/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7275_full -> Patchwork_15162_full
Summary
== Series Details ==
Series: drm/i915: Enable second dbuf slice for ICL and TGL (rev2)
URL : https://patchwork.freedesktop.org/series/69124/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915: Enable second dbuf slice for ICL and TGL
== Series Details ==
Series: drm/i915: Enable second dbuf slice for ICL and TGL (rev2)
URL : https://patchwork.freedesktop.org/series/69124/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f9ab97f3257e drm/i915: Enable second dbuf slice for ICL and TGL
-:260:
On Thu, Nov 07, 2019 at 11:30:51PM +, Chris Wilson wrote:
Quoting Umesh Nerlige Ramappa (2019-11-07 23:22:34)
It turns out that the OAR CONTROL register is not getting configured
correctly in conjunction with the context save/restore bit. When
measuring work for a single context, the OAR
It turns out that the OAR CONTROL register is not getting configured
correctly in conjunction with the context save/restore bit. When
measuring work for a single context, the OAR counters do not increment.
- Configure OAR format and enable OAR counters at the same time as
enabling context
Quoting Umesh Nerlige Ramappa (2019-11-07 23:22:34)
> It turns out that the OAR CONTROL register is not getting configured
> correctly in conjunction with the context save/restore bit. When
> measuring work for a single context, the OAR counters do not increment.
>
> Configure OAR format and
On Wed, Nov 06, 2019 at 11:26:36PM +0200, Gwan-gyeong Mun wrote:
The setting of MSA is done by the DDI .pre_enable() hook. And when we are
using MST, the MSA is only set to first mst stream by calling of
DDI .pre_eanble() hook. It raies issues to non-first mst streams.
Wrong MSA or missed MSA
It turns out that the OAR CONTROL register is not getting configured
correctly in conjunction with the context save/restore bit. When
measuring work for a single context, the OAR counters do not increment.
Configure OAR format and enable OAR counters at the same time as
enabling context
On Thu, 2019-11-07 at 15:10 -0800, Lucas De Marchi wrote:
> On Thu, Nov 07, 2019 at 10:56:09PM +, Jose Souza wrote:
> > On Thu, 2019-11-07 at 14:44 -0800, Lucas De Marchi wrote:
> > > On Thu, Nov 07, 2019 at 01:45:59PM -0800, Jose Souza wrote:
> > > > This register was being enabled after
== Series Details ==
Series: drm/i915: Don't test plane stride with !INTEL_DISPLAY_ENABLED
URL : https://patchwork.freedesktop.org/series/69155/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7290 -> Patchwork_15184
Summary
On Thu, Nov 07, 2019 at 10:56:09PM +, Jose Souza wrote:
On Thu, 2019-11-07 at 14:44 -0800, Lucas De Marchi wrote:
On Thu, Nov 07, 2019 at 01:45:59PM -0800, Jose Souza wrote:
> This register was being enabled after enable TRANS_DDI_FUNC_CTL and
> PIPECONF/TRANS_CONF while BSpec states that
== Series Details ==
Series: drm/i915: Don't oops in dumb_create ioctl if we have no crtcs
URL : https://patchwork.freedesktop.org/series/69081/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7275_full -> Patchwork_15160_full
On 8/28/2019 11:50 PM, Daniel Vetter wrote:
> On Wed, Aug 28, 2019 at 08:31:27PM +, Souza, Jose wrote:
>> On Wed, 2019-08-28 at 21:13 +0100, Chris Wilson wrote:
>>> Quoting Souza, Jose (2019-08-28 21:11:53)
Reviewed-by: José Roberto de Souza
>>>
>>> It's using a non-standard for i915
On Thu, 2019-11-07 at 14:44 -0800, Lucas De Marchi wrote:
> On Thu, Nov 07, 2019 at 01:45:59PM -0800, Jose Souza wrote:
> > This register was being enabled after enable TRANS_DDI_FUNC_CTL and
> > PIPECONF/TRANS_CONF while BSpec states that it should be set when
> > enabling TRANS_DDI_FUNC_CTL.
> >
On Thu, Nov 07, 2019 at 01:45:59PM -0800, Jose Souza wrote:
This register was being enabled after enable TRANS_DDI_FUNC_CTL and
PIPECONF/TRANS_CONF while BSpec states that it should be set when
enabling TRANS_DDI_FUNC_CTL.
BSpec: 49190
not what I read here.
8j. Configure TRANS_DDI_FUNC_CTL2
On Thu, Nov 07, 2019 at 12:16:13PM -0800, Souza, Jose wrote:
> On Thu, 2019-11-07 at 09:45 -0800, Matt Roper wrote:
> > Rather than just specifying the bullet numbers from the bspec (e.g.,
> > "4.b") actually include the description of what the bspec wants us to
> > do. Steps can be renumbered or
On Thu, Nov 07, 2019 at 01:45:57PM -0800, Jose Souza wrote:
TRANS_DDI_MST_TRANSPORT_SELECT is 2 bits wide not 3, it was taking
one bit from EDP/DSI Input Select.
Fixes: b3545e086877 ("drm/i915/tgl: add support to one DP-MST stream")
Cc: Lucas De Marchi
Signed-off-by: José Roberto de Souza
In the selftests, where we are accessing a private ctx from within the
confines of a single test, we know that the ctx->vm pointer is static
and bounded by the lifetime of the test. We can use a simple helper to
provide the RCU annotations to keep sparse happy.
Signed-off-by: Chris Wilson
---
== Series Details ==
Series: drm/i915: Split a setting of MSA to MST and SST (rev3)
URL : https://patchwork.freedesktop.org/series/69092/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15183
Summary
This register was being enabled after enable TRANS_DDI_FUNC_CTL and
PIPECONF/TRANS_CONF while BSpec states that it should be set when
enabling TRANS_DDI_FUNC_CTL.
BSpec: 49190
BSpec: 22243
Cc: Lucas De Marchi
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/intel_ddi.c
Adding pipe D support to DSI transcoder.
Not adding it for EDP transcoder code paths as only TGL has 4 pipes
and it do not have a EDP transcoder.
Cc: Lucas De Marchi
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/icl_dsi.c | 6 ++
drivers/gpu/drm/i915/i915_reg.h
TRANS_DDI_MST_TRANSPORT_SELECT is 2 bits wide not 3, it was taking
one bit from EDP/DSI Input Select.
Fixes: b3545e086877 ("drm/i915/tgl: add support to one DP-MST stream")
Cc: Lucas De Marchi
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/i915_reg.h | 2 +-
1 file changed, 1
Since drm provided us with a real struct file we can use for our
anonymous internal clients (mock_file), complete our transition to using
that as the primary interface (and not the mocked up struct drm_file we
previous were using).
Signed-off-by: Chris Wilson
Cc: Matthew Auld
---
Also implemented algorithm for choosing DBuf slice configuration
based on active pipes, pipe ratio as stated in BSpec 12716.
Now pipe allocation still stays proportional to pipe width as before,
however within allowed DBuf slice for this particular configuration.
v2: Remove unneeded check from
== Series Details ==
Series: series starting with [CI,1/5] drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY
under a separate Kconfig
URL : https://patchwork.freedesktop.org/series/69147/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15182
== Series Details ==
Series: series starting with [v4,1/2] drm/i915: lookup for mem_region of a
mem_type
URL : https://patchwork.freedesktop.org/series/69075/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7274_full -> Patchwork_15158_full
On Wed, 2019-11-06 at 23:26 +0200, Gwan-gyeong Mun wrote:
> The setting of MSA is done by the DDI .pre_enable() hook. And when we
> are
> using MST, the MSA is only set to first mst stream by calling of
> DDI .pre_eanble() hook. It raies issues to non-first mst streams.
> Wrong MSA or missed MSA
Quoting Arkadiusz Hiler (2019-11-07 17:38:20)
> We don't want you to translate C into English, we want you to provide a bit of
> that extra information that you would have put in the comments anyway.
The comments should exist and are _inline_ with the code. In all the
examples of igt_describe() I
== Series Details ==
Series: series starting with [CI,1/5] drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY
under a separate Kconfig
URL : https://patchwork.freedesktop.org/series/69147/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
fe079a2c7f06 drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY
== Series Details ==
Series: drm/i915: Expand documentation for gen12 DP pre-enable sequence
URL : https://patchwork.freedesktop.org/series/69146/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15181
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/bios: store child devices in a
list
URL : https://patchwork.freedesktop.org/series/69143/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15179
If INTEL_DISPLAY_ENABLED is false, then the modesetting resources were
never initialized. Userspace may still call DRM_IOCTL_MODE_CREATE_DUMB
which will eventually lead i915_gem_dumb_create() to try to dereference
a non-existent pipe A primary plane while figuring out a proper pitch.
We could
== Series Details ==
Series: drm/i915: Taint the kernel on dumping the GEM ftrace buffer
URL : https://patchwork.freedesktop.org/series/69144/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK
On Thu, 2019-11-07 at 09:45 -0800, Matt Roper wrote:
> Rather than just specifying the bullet numbers from the bspec (e.g.,
> "4.b") actually include the description of what the bspec wants us to
> do. Steps can be renumbered or moved so including the description
> will
> help us match the code
On Thu, Nov 07, 2019 at 09:45:27AM -0800, Matt Roper wrote:
Rather than just specifying the bullet numbers from the bspec (e.g.,
"4.b") actually include the description of what the bspec wants us to
do. Steps can be renumbered or moved so including the description will
help us match the code up
== Series Details ==
Series: Refactor Gen11+ SAGV support (rev10)
URL : https://patchwork.freedesktop.org/series/68028/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15178
Summary
---
**SUCCESS**
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -22,6 +22,8 @@
> *
> */
>
> +#include
> +
> #include "display/intel_frontbuffer.h"
> #include "gt/intel_gt.h"
> #include "i915_drv.h"
> @@ -52,6 +54,14 @@ void
On Thu, Nov 07, 2019 at 05:01:14PM +, Chris Wilson wrote:
Quoting Niranjan Vishwanathapura (2019-11-07 16:09:31)
On Wed, Nov 06, 2019 at 09:13:12AM +, Chris Wilson wrote:
>As we read the ctx->vm unlocked before cloning/exporting, we should
>validate our reference is correct before
== Series Details ==
Series: Refactor Gen11+ SAGV support (rev10)
URL : https://patchwork.freedesktop.org/series/68028/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
___
Intel-gfx mailing list
On 11/7/2019 8:41 PM, Jason Wang wrote:
This patch implements basic support for mdev driver that supports
virtio transport for kernel virtio driver.
Reviewed-by: Cornelia Huck
Signed-off-by: Jason Wang
I'm not expert on virtio part, my ack is from mdev perspective.
Reviewed-by: Kirti
== Series Details ==
Series: Refactor Gen11+ SAGV support (rev10)
URL : https://patchwork.freedesktop.org/series/68028/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a731ea6228dd drm/i915: Refactor intel_can_enable_sagv
-:191: CHECK:PARENTHESIS_ALIGNMENT: Alignment should
== Series Details ==
Series: drm/i915: Gamma cleanups
URL : https://patchwork.freedesktop.org/series/69136/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15177
Summary
---
**FAILURE**
Serious
On 11/7/2019 8:41 PM, Jason Wang wrote:
Currently, except for the create and remove, the rest of
mdev_parent_ops is designed for vfio-mdev driver only and may not help
for kernel mdev driver. With the help of class id, this patch
introduces device specific callbacks inside mdev_device
On 11/7/2019 8:41 PM, Jason Wang wrote:
Add support to parse mdev class id table.
Reviewed-by: Parav Pandit
Reviewed-by: Cornelia Huck
Signed-off-by: Jason Wang
Reviewed-by: Kirti Wankhede
Thanks,
Kirti
---
drivers/vfio/mdev/vfio_mdev.c | 2 ++
On 11/7/2019 8:41 PM, Jason Wang wrote:
Mdev bus only supports vfio driver right now, so it doesn't implement
match method. But in the future, we may add drivers other than vfio,
the first driver could be virtio-mdev. This means we need to add
device class id support in bus match method to
== Series Details ==
Series: drm/i915: Gamma cleanups
URL : https://patchwork.freedesktop.org/series/69136/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm: Inline drm_color_lut_extract()
+./include/drm/drm_color_mgmt.h:48:28: warning: shift count
== Series Details ==
Series: drm/i915: Gamma cleanups
URL : https://patchwork.freedesktop.org/series/69136/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
aab7b7b6ba2e drm: Inline drm_color_lut_extract()
1250c5426804 drm/i915: Polish CHV .load_luts() a bit
a30aa9a2a86a
== Series Details ==
Series: mdev based hardware virtio offloading support
URL : https://patchwork.freedesktop.org/series/69135/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15176
Summary
---
== Series Details ==
Series: mdev based hardware virtio offloading support
URL : https://patchwork.freedesktop.org/series/69135/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9507b5357d7b mdev: class id support
58af09c8da00 modpost: add support for mdev class id
e94f948040f5
== Series Details ==
Series: series starting with [1/5] drm: Add
__drm_atomic_helper_crtc_state_reset() & co.
URL : https://patchwork.freedesktop.org/series/69129/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15175
== Series Details ==
Series: drm/i915: Enable second dbuf slice for ICL and TGL
URL : https://patchwork.freedesktop.org/series/69124/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15174
Summary
---
As drm now exports a method to create an anonymous struct file around a
drm_device for internal use, make use of it to avoid our horrible hacks.
Danial suggested that the mock_file_put() wrapper was suitable for
drm-core, along with the mock_drm_getfile() [and that the vestigal
mock_drm_file() in
Whenever, we unbind (or change fence registers) on an object, we must
revoke any and all mmap_gtt using the previous bindings. Those user PTEs
point at the GGTT which know points into a new object, the wrong object.
Ergo, those PTEs must be cleared so that any user access provokes a new
page
Currently, we only export symbols for drm-selftests which are either
compiled as modules or into the main drm builtin. However, if we want to
export symbols from drm.ko for the drivers' selftests, we require a
means of controlling that export separately. So we add a new Kconfig to
determine
Provide a utility function to create a vma corresponding to an mmap() of
our device. And use it to exercise the equivalent of userspace
performing a GTT mmap of our objects.
Signed-off-by: Chris Wilson
Cc: Abdiel Janulgue
Reviewed-by: Abdiel Janulgue
---
drivers/gpu/drm/i915/Makefile
Sometimes we need to create a struct file to wrap a drm_device, as it
the user were to have opened /dev/dri/card0 but to do so anonymously
(i.e. for internal use). Provide a utility method to create a struct
file with the drm_device->driver.fops, that wrap the drm_device.
v2: Restrict usage to
Hi Ram,
Can you point me to the: "additional kernel patch for your product to set the
desired state as default state of the property at the creation".
Mikhail Voldman
System Architect
Teledyne LeCroy, Protocol Solutions Group
2111 Big Timber Road
Elgin, IL 60123
Note new email address:
Rather than just specifying the bullet numbers from the bspec (e.g.,
"4.b") actually include the description of what the bspec wants us to
do. Steps can be renumbered or moved so including the description will
help us match the code up to the spec. Plus if we add support for new
platforms, some
== Series Details ==
Series: drm/i915: Enable second dbuf slice for ICL and TGL
URL : https://patchwork.freedesktop.org/series/69124/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915: Enable second dbuf slice for ICL and TGL
== Series Details ==
Series: drm/i915: Enable second dbuf slice for ICL and TGL
URL : https://patchwork.freedesktop.org/series/69124/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2fdfc3b51c5b drm/i915: Enable second dbuf slice for ICL and TGL
-:221:
On Thu, Nov 07, 2019 at 05:17:14PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> This thing can get called several thousand times per LUT
> so seems like we want to inline it to:
> - avoid the function call overhead
> - allow constant folding
>
> A quick synthetic test (w/o any hardware
On Thu, Nov 07, 2019 at 04:24:13PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Annoyingly __drm_atomic_helper_crtc_reset() does two
> totally separate things:
> a) reset the state to defaults values
> b) assign the crtc->state pointer
>
> I just want a) without the b) so let's split
Hey all,
IGT tests are largely undocumented and a lot of them are quite enigmatic if you
haven't internalized the whole framework and are not familiar with naming
conventions that some people use.
To tackle this we require[0] documenting new tests with igt_describe()[1].
The idea is to provide
On Thu, Nov 07, 2019 at 05:17:00PM +, Chris Wilson wrote:
> Quoting Daniel Vetter (2019-11-07 08:39:24)
> > On Wed, Nov 06, 2019 at 02:24:30PM +, Chris Wilson wrote:
> > > As drm now exports a method to create an anonymous struct file around a
> > > drm_device for internal use, make use of
On Wed, 6 Nov 2019 at 14:24, Chris Wilson wrote:
>
> As drm now exports a method to create an anonymous struct file around a
> drm_device for internal use, make use of it to avoid our horrible hacks.
>
> Signed-off-by: Chris Wilson
As per your eventual plan, fwiw,
Reviewed-by: Matthew Auld
Quoting Daniel Vetter (2019-11-07 08:39:24)
> On Wed, Nov 06, 2019 at 02:24:30PM +, Chris Wilson wrote:
> > As drm now exports a method to create an anonymous struct file around a
> > drm_device for internal use, make use of it to avoid our horrible hacks.
> >
> > Signed-off-by: Chris Wilson
== Series Details ==
Series: drm/i915: Split a setting of MSA to MST and SST (rev2)
URL : https://patchwork.freedesktop.org/series/69092/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7286 -> Patchwork_15173
Summary
Quoting Niranjan Vishwanathapura (2019-11-07 16:09:31)
> On Wed, Nov 06, 2019 at 09:13:12AM +, Chris Wilson wrote:
> >As we read the ctx->vm unlocked before cloning/exporting, we should
> >validate our reference is correct before returning it. We already do for
> >clone_vm() but were not so
On Wed, Nov 06, 2019 at 09:13:12AM +, Chris Wilson wrote:
As we read the ctx->vm unlocked before cloning/exporting, we should
validate our reference is correct before returning it. We already do for
clone_vm() but were not so strict around get_ppgtt().
Signed-off-by: Chris Wilson
---
On Thu, Nov 07, 2019 at 06:08:53PM +0200, Jani Nikula wrote:
> Using the array is getting clumsy. Make things a bit more dynamic.
>
> Remove early returns on not having child devices when the end result
> after "iterating" the empty list would be the same.
>
> v2:
> - stick to previous naming of
As the ftrace buffer is single shot, once dumped it will not update. As
such, it only provides information for the first bug and all subsequent
bugs are noise. The goal of CI is to have zero bugs, so taint the kernel
causing CI to reboot the machine; fix the bug and move on.
Signed-off-by: Chris
Allow accessing the parent structure later on. Drop const for allowing
future modification as well.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
Using the array is getting clumsy. Make things a bit more dynamic.
Remove early returns on not having child devices when the end result
after "iterating" the empty list would be the same.
v2:
- stick to previous naming of child devices (Ville)
- use kzalloc, handle failure
- initialize list head
1 - 100 of 219 matches
Mail list logo
