[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: replace X86_FEATURE_PAT with pat_enabled()

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: replace X86_FEATURE_PAT with pat_enabled() URL : https://patchwork.freedesktop.org/series/97482/ State : success == Summary == CI Bug Log - changes from CI_DRM_10952_full -> Patchwork_21723_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix error pointer dereference in i915_gem_do_execbuffer() (rev4)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Fix error pointer dereference in i915_gem_do_execbuffer() (rev4) URL : https://patchwork.freedesktop.org/series/96969/ State : success == Summary == CI Bug Log - changes from CI_DRM_10953 -> Patchwork_21725

Re: [Intel-gfx] [v3 0/3] Introduce Raptor Lake S

2021-12-01 Thread Srivatsa, Anusha
> -Original Message- > From: Jani Nikula > Sent: Wednesday, December 1, 2021 5:52 PM > To: Srivatsa, Anusha ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [v3 0/3] Introduce Raptor Lake S > > On Wed, 01 Dec 2021, Anusha Srivatsa wrote: > > Raptor Lake S(RPL-S) is a

[Intel-gfx] ✓ Fi.CI.BAT: success for static analysis failure

2021-12-01 Thread Patchwork
== Series Details == Series: static analysis failure URL : https://patchwork.freedesktop.org/series/97486/ State : success == Summary == CI Bug Log - changes from CI_DRM_10953 -> Patchwork_21724 Summary --- **SUCCESS** No

[Intel-gfx] [PATCH] drm/i915: Fix error pointer dereference in i915_gem_do_execbuffer()

2021-12-01 Thread Matthew Brost
From: Dan Carpenter Originally "out_fence" was set using out_fence = sync_file_create() but which returns NULL, but now it is set with out_fence = eb_requests_create() which returns error pointers. The error path needs to be modified to avoid an Oops in the "goto err_request;" path. Fixes:

Re: [Intel-gfx] [PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.16-rc3] [cannot apply to drm/drm-next drm-tip/drm-tip next-20211201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[Intel-gfx] [PATCH 1/1] static analysis failure

2021-12-01 Thread Pallavi Mishra
fix for null ptr dereferences. Signed-off-by: Pallavi Mishra --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +++ drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c

[Intel-gfx] [PATCH 0/1] static analysis failure

2021-12-01 Thread Pallavi Mishra
fix for null ptr dereferences Pallavi Mishra (1): static analysis failure drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +++ drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) -- 2.25.1

[Intel-gfx] ✓ Fi.CI.IGT: success for Bump DMC to v2.14 on ADL-P (rev2)

2021-12-01 Thread Patchwork
== Series Details == Series: Bump DMC to v2.14 on ADL-P (rev2) URL : https://patchwork.freedesktop.org/series/97477/ State : success == Summary == CI Bug Log - changes from CI_DRM_10951_full -> Patchwork_21722_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width

2021-12-01 Thread Srinivas, Vidya
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, December 1, 2021 8:33 PM > To: Srinivas, Vidya > Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam > > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width > > On Wed, Dec 01, 2021 at 09:17:27AM

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Plane register cleanup

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Plane register cleanup URL : https://patchwork.freedesktop.org/series/97467/ State : success == Summary == CI Bug Log - changes from CI_DRM_10950_full -> Patchwork_21718_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: replace X86_FEATURE_PAT with pat_enabled()

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: replace X86_FEATURE_PAT with pat_enabled() URL : https://patchwork.freedesktop.org/series/97482/ State : success == Summary == CI Bug Log - changes from CI_DRM_10952 -> Patchwork_21723 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Disable IRQ for timestamp calculation

2021-12-01 Thread Dixit, Ashutosh
On Tue, 30 Nov 2021 05:20:05 -0800, Anshuman Gupta wrote: > > gt_pm selftest calculates engine ticks cycles and wall time > cycles by delta of respective engine elapsed TIMESTAMP and ktime > for period of 1000us. > It compares the engine ticks cycles with wall time cycles. > > Disable local cpu

Re: [Intel-gfx] [PATCH] drm/i915/display/tgl: Implement Wa_14013120569

2021-12-01 Thread Tolakanahalli Pradeep, Madhumitha
@Jani @Manasi Bump. On Mon, 2021-11-08 at 15:52 -0800, Navare, Manasi wrote: > On Mon, Nov 01, 2021 at 12:25:21PM +0200, Jani Nikula wrote: > > On Mon, 28 Jun 2021, Madhumitha Tolakanahalli Pradeep > > wrote: > > > PCH display HPD IRQ is not detected with default filter value. > > > So,

[Intel-gfx] i915 Updates: ADL-P DMC v2.14

2021-12-01 Thread Tolakanahalli Pradeep, Madhumitha
Hi Ben, Josh, Kyle, Kindly add the below i915 changes to linux-firmware: The following changes since commit b0e898fbaf377c99a36aac6fdeb7250003648ca4: linux-firmware: Update firmware file for Intel Bluetooth 9462 (2021- 11-23 12:31:45 -0500) are available in the Git repository at:

Re: [Intel-gfx] [PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.16-rc3] [cannot apply to drm/drm-next drm-tip/drm-tip next-20211201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [Intel-gfx] [v2 1/1] drm/i915/dmc: Update DMC to v2.14 on ADL-P

2021-12-01 Thread Lucas De Marchi
On Wed, Dec 01, 2021 at 02:24:04PM -0800, Madhumitha Tolakanahalli Pradeep wrote: Changes since v2.12: - Release notes for v2.13: 1. Fix for simple flip queue with DC6v - Release notes for v2.14: 1. Fix for flip queue roll over cases with DC6v 2. Enhancement for residency

[Intel-gfx] linux-next: manual merge of the drm-intel-gt tree with the drm-intel tree

2021-12-01 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel-gt tree got a conflict in: drivers/gpu/drm/i915/display/intel_fbc.c between commit: d06188234427 ("drm/i915/fbc: s/dev_priv/i915/") from the drm-intel tree and commit: cca084692394 ("drm/i915: Use per device iommu check") from the

[Intel-gfx] [PATCH] drm/i915: replace X86_FEATURE_PAT with pat_enabled()

2021-12-01 Thread Lucas De Marchi
PAT can be disabled on boot with "nopat" in the command line. Replace one x86-ism with another, which is slightly more correct to prepare for supporting other architectures. Cc: Matt Roper Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 8

[Intel-gfx] ✓ Fi.CI.BAT: success for Bump DMC to v2.14 on ADL-P (rev2)

2021-12-01 Thread Patchwork
== Series Details == Series: Bump DMC to v2.14 on ADL-P (rev2) URL : https://patchwork.freedesktop.org/series/97477/ State : success == Summary == CI Bug Log - changes from CI_DRM_10951 -> Patchwork_21722 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Re-use i915 macros for checking PTEs (rev9)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Re-use i915 macros for checking PTEs (rev9) URL : https://patchwork.freedesktop.org/series/97090/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10951 -> Patchwork_21721 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Re-use i915 macros for checking PTEs (rev9)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Re-use i915 macros for checking PTEs (rev9) URL : https://patchwork.freedesktop.org/series/97090/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3809a1d72d34 drm/i915: Re-use i915 macros for checking PTEs -:6: WARNING:COMMIT_LOG_LONG_LINE:

[Intel-gfx] [v2 0/1] Bump DMC to v2.14 on ADL-P

2021-12-01 Thread Madhumitha Tolakanahalli Pradeep
Adding PR for CI to pick the firmware, The following changes since commit f5d519563ac9d2d1f382a817aae5ec5473811ac8: linux-firmware: Update AMD cpu microcode (2021-11-15 12:49:19 -0500) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware adlp_dmc_v2.14

[Intel-gfx] [v2 1/1] drm/i915/dmc: Update DMC to v2.14 on ADL-P

2021-12-01 Thread Madhumitha Tolakanahalli Pradeep
Changes since v2.12: - Release notes for v2.13: 1. Fix for simple flip queue with DC6v - Release notes for v2.14: 1. Fix for flip queue roll over cases with DC6v 2. Enhancement for residency 3. Workaround for 3Dlut restore issue v2: Commit message update (Imre)

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v4,1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread Patchwork
== Series Details == Series: series starting with [v4,1/6] drm: move the buddy allocator from i915 into common drm URL : https://patchwork.freedesktop.org/series/97476/ State : failure == Summary == Applying: drm: move the buddy allocator from i915 into common drm Using index info to

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Re-use i915 macros for checking PTEs (rev8)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Re-use i915 macros for checking PTEs (rev8) URL : https://patchwork.freedesktop.org/series/97090/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10951 -> Patchwork_21719 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Re-use i915 macros for checking PTEs (rev8)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Re-use i915 macros for checking PTEs (rev8) URL : https://patchwork.freedesktop.org/series/97090/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6a888e8bac16 drm/i915: Re-use i915 macros for checking PTEs -:6: WARNING:COMMIT_LOG_LONG_LINE:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2) URL : https://patchwork.freedesktop.org/series/97173/ State : success == Summary == CI Bug Log - changes from CI_DRM_10949_full -> Patchwork_21716_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Plane register cleanup

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Plane register cleanup URL : https://patchwork.freedesktop.org/series/97467/ State : success == Summary == CI Bug Log - changes from CI_DRM_10950 -> Patchwork_21718 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] Revert "drm/i915: Implement Wa_1508744258" (rev2)

2021-12-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] Revert "drm/i915: Implement Wa_1508744258" (rev2) URL : https://patchwork.freedesktop.org/series/97105/ State : success == Summary == CI Bug Log - changes from CI_DRM_10949_full -> Patchwork_21715_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Plane register cleanup

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Plane register cleanup URL : https://patchwork.freedesktop.org/series/97467/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Plane register cleanup

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Plane register cleanup URL : https://patchwork.freedesktop.org/series/97467/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2a489c8cf0ae drm/i915: Get rid of the 64bit PLANE_CC_VAL mmio -:69: WARNING:LONG_LINE: line length of 102 exceeds

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Re-use i915 macros for checking PTEs (rev7)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Re-use i915 macros for checking PTEs (rev7) URL : https://patchwork.freedesktop.org/series/97090/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10950 -> Patchwork_21717 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Re-use i915 macros for checking PTEs (rev7)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Re-use i915 macros for checking PTEs (rev7) URL : https://patchwork.freedesktop.org/series/97090/ State : warning == Summary == $ dim checkpatch origin/drm-tip 68b441f63a8e drm/i915: Re-use i915 macros for checking PTEs -:6: WARNING:COMMIT_LOG_LONG_LINE:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/adl_p: Add adl-p ddc pin mapping (rev2)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915/adl_p: Add adl-p ddc pin mapping (rev2) URL : https://patchwork.freedesktop.org/series/97009/ State : success == Summary == CI Bug Log - changes from CI_DRM_10949_full -> Patchwork_21714_full Summary

Re: [Intel-gfx] [PATCH 14/14] drm/i915: Nuke pointless middle men for skl+ plane programming

2021-12-01 Thread Souza, Jose
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > There is no real point in having this two stage > skl_program_plane*() vs. skl_plane_update*() wrapper stuff. > All we need to do is determine the correct color plane and > we're done. Reviewed-by: José Roberto de

Re: [Intel-gfx] [PATCH 13/14] drm/i915: Declutter color key register stuff

2021-12-01 Thread Souza, Jose
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a few small helpers to calculate the color key register > values. Cleans up skl_program_plane_arm() a bit. Reviewed-by: José Roberto de Souza > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 12/14] drm/i915: Extract skl_plane_aux_dist()

2021-12-01 Thread Souza, Jose
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Extract the PLANE_AUX_DIST stuff into a small helper to > dclutter skl_program_plane_arm() a bit. Reviewed-by: José Roberto de Souza > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Use REG_BIT() & co. for universal plane bits

2021-12-01 Thread Souza, Jose
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Polish the skl+ universal plane register defines by > using REG_BIT() & co. > > The defines are also currently spread around in some > semi-random fashion. Collect them up into one place. > > Signed-off-by: Ville

Re: [Intel-gfx] [PATCH 03/14] drm/i915: Get rid of the "sizes are 0 based" stuff

2021-12-01 Thread Souza, Jose
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the "sizes are 0 based" stuff with just straight > up -1 where needed. Less confusing all around. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_sprite.c | 26

Re: [Intel-gfx] [PATCH 05/14] drm/i915: Rename PLANE_CUS_CTL Y plane bits

2021-12-01 Thread Souza, Jose
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename the PLANE_CUS_CTL Y plane selection bits to actually > say "Y plane". > Reviewed-by: José Roberto de Souza > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.c | 8

Re: [Intel-gfx] [PATCH 01/14] drm/i915: Get rid of the 64bit PLANE_CC_VAL mmio

2021-12-01 Thread Souza, Jose
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Let's just stick to 32bit mmio accesses so we can get rid > of the bare "uncore" reg access in display code. The register > are defined as 32bit in the spec anyway. > > We could define a 64bit "de" variant I

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Rename plane YUV order bits

2021-12-01 Thread Souza, Jose
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename the YUV byte order bits to be a bit more consistent. Why rename bits not used? Would be better already nuke it. Anyways up to you. Reviewed-by: José Roberto de Souza > > Signed-off-by: Ville Syrjälä >

[Intel-gfx] [PATCH 09/14] drm/i915: Clean up vlv/chv sprite plane registers

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Use REG_BIT() & co. to polish the vlv/chv sprite plane registers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 9 +- drivers/gpu/drm/i915/i915_reg.h | 103 2 files changed, 70 insertions(+), 42

Re: [Intel-gfx] [PATCH v2 10/10] drm/i915/display: stop including i915_drv.h from intel_display_types.h

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 03:57:12PM +0200, Jani Nikula wrote: > Break the dependency on i915_drv.h. > > Signed-off-by: Jani Nikula Looks reasonable. Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display_types.h| 9 - >

Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 09:17:27AM +0530, Vidya Srinivas wrote: > PLANE_CUS_CTL has a restriction of 4096 width even though > PLANE_SIZE and scaler size registers supports max 5120. > Take care of this restriction in max_width. > > Without this patch, when 5k content is sent on HDR plane > with

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add workaround numbers to GEN7_COMMON_SLICE_CHICKEN1 whitelisting

2021-12-01 Thread Matt Atwood
On Fri, Nov 19, 2021 at 06:09:31AM -0800, José Roberto de Souza wrote: > Those two workarounds needs to be implemented in UMD, KMD only needs > to whitelist the registers, so here only adding the workaround number > to facilitate future workaroud table checks. > > Signed-off-by: José Roberto de

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4) URL : https://patchwork.freedesktop.org/series/96855/ State : success == Summary == CI Bug Log - changes from CI_DRM_10949_full -> Patchwork_21713_full

[Intel-gfx] ✓ Fi.CI.IGT: success for Introduce Raptor Lake S (rev4)

2021-12-01 Thread Patchwork
== Series Details == Series: Introduce Raptor Lake S (rev4) URL : https://patchwork.freedesktop.org/series/96869/ State : success == Summary == CI Bug Log - changes from CI_DRM_10949_full -> Patchwork_21712_full Summary ---

[Intel-gfx] [PATCH 12/14] drm/i915: Extract skl_plane_aux_dist()

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Extract the PLANE_AUX_DIST stuff into a small helper to dclutter skl_program_plane_arm() a bit. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/skl_universal_plane.c| 35 --- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git

[Intel-gfx] [PATCH 05/14] drm/i915: Rename PLANE_CUS_CTL Y plane bits

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Rename the PLANE_CUS_CTL Y plane selection bits to actually say "Y plane". Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 8 drivers/gpu/drm/i915/i915_reg.h | 8 2 files changed, 8 insertions(+), 8

[Intel-gfx] [PATCH 02/14] drm/i915: Rename plane YUV order bits

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Rename the YUV byte order bits to be a bit more consistent. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_universal_plane.c | 8 drivers/gpu/drm/i915/i915_reg.h| 14 +++--- 2 files changed, 11 insertions(+), 11

[Intel-gfx] [PATCH 14/14] drm/i915: Nuke pointless middle men for skl+ plane programming

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä There is no real point in having this two stage skl_program_plane*() vs. skl_plane_update*() wrapper stuff. All we need to do is determine the correct color plane and we're done. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/skl_universal_plane.c| 53

[Intel-gfx] [PATCH 13/14] drm/i915: Declutter color key register stuff

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Add a few small helpers to calculate the color key register values. Cleans up skl_program_plane_arm() a bit. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/skl_universal_plane.c| 45 +-- 1 file changed, 32 insertions(+), 13 deletions(-) diff

[Intel-gfx] [PATCH 11/14] drm/i915: Clean up cursor registers

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Use REG_BIT() & co. to polish the cursor plane registers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cursor.c | 25 --- drivers/gpu/drm/i915/display/intel_display.c | 4 +- drivers/gpu/drm/i915/i915_reg.h | 71

[Intel-gfx] [PATCH 10/14] drm/i915: Clean up g4x+ sprite plane registers

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Use REG_BIT() & co. to polish the g4x+ sprite plane registers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 12 ++-- drivers/gpu/drm/i915/i915_reg.h | 73 + 2 files changed, 53 insertions(+), 32 deletions(-)

[Intel-gfx] [PATCH 03/14] drm/i915: Get rid of the "sizes are 0 based" stuff

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Replace the "sizes are 0 based" stuff with just straight up -1 where needed. Less confusing all around. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 26 --- .../drm/i915/display/skl_universal_plane.c| 6 + 2

[Intel-gfx] [PATCH 08/14] drm/i915: Clean up ivb+ sprite plane registers

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Use REG_BIT() & co. to polish the ivb+ sprite plane registers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 20 +++-- drivers/gpu/drm/i915/i915_reg.h | 81 + 2 files changed, 62 insertions(+), 39

[Intel-gfx] [PATCH 04/14] drm/i915: Sipmplify PLANE_STRIDE masking

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä There's no need to have separate masks for the stride bitfield in PLANE_STRIDE for different platforms. All the extra bits are hardcoded to zero anyway. Also the masks we're using now don't even match the actual hardware since the bitfield was only 10 bits on

[Intel-gfx] [PATCH 07/14] drm/i915: Clean up pre-skl primary plane registers

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Use REG_BIT() & co. for the pre-skl primary plane registers. Also give everything a consistent namespace. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i9xx_plane.c| 99 + drivers/gpu/drm/i915/display/intel_display.c | 13 +--

[Intel-gfx] [PATCH 06/14] drm/i915: Use REG_BIT() & co. for universal plane bits

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Polish the skl+ universal plane register defines by using REG_BIT() & co. The defines are also currently spread around in some semi-random fashion. Collect them up into one place. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/skl_universal_plane.c| 36 ++--

[Intel-gfx] [PATCH 01/14] drm/i915: Get rid of the 64bit PLANE_CC_VAL mmio

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Let's just stick to 32bit mmio accesses so we can get rid of the bare "uncore" reg access in display code. The register are defined as 32bit in the spec anyway. We could define a 64bit "de" variant I suppose, but doesn't really make much sense just for this one case, and

[Intel-gfx] [PATCH 00/14] drm/i915: Plane register cleanup

2021-12-01 Thread Ville Syrjala
From: Ville Syrjälä Bunch of cleanup around plane registers, and a bit of reshuffling in the skl+ universal plane code. Ville Syrjälä (14): drm/i915: Get rid of the 64bit PLANE_CC_VAL mmio drm/i915: Rename plane YUV order bits drm/i915: Get rid of the "sizes are 0 based" stuff drm/i915:

Re: [Intel-gfx] [PATCH v2 09/10] drm/i915/display: convert dp_to_i915() to a macro

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 03:57:11PM +0200, Jani Nikula wrote: > Avoid looking into the guts of struct drm_i915_private in > headers. Again, converting an inline function to a macro is less than > ideal, but avoids having to pull in i915_drv.h just for the to_i915() > part. Ugly, but gets the job

Re: [Intel-gfx] [PATCH v2 08/10] drm/i915: move enum hpd_pin to intel_display.h

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 03:57:10PM +0200, Jani Nikula wrote: > It's not the ideal location, but a better alternative than > i915_drv.h. The goal is to break the intel_display_types.h to i915_drv.h > dependency. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH v2 07/10] drm/i915: split out intel_pm_types.h

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 03:57:09PM +0200, Jani Nikula wrote: > This is far from ideal, but it reduces the i915_drv.h dependency from > intel_display_types.h. Maybe in the future we'll need a better split. Yeah, looks pretty temporary until we move the wm code into some actually sensible place.

Re: [Intel-gfx] [PATCH v2 05/10] drm/i915/crtc: un-inline some crtc functions and move to intel_crtc.[ch]

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 03:57:07PM +0200, Jani Nikula wrote: > Move a number of crtc/pipe related functions to intel_crtc.[ch], and > un-inline to avoid looking into struct drm_i915_private guts in header > files. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH v2 06/10] drm/i915/fb: move intel_fb_uses_dpt to intel_fb.c and un-inline

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 03:57:08PM +0200, Jani Nikula wrote: > Move fb functions where they belong, and un-inline to avoid looking into > struct drm_i915_private guts in header files. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH v2 04/10] drm/i915/display: remove intel_wait_for_vblank()

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 03:57:06PM +0200, Jani Nikula wrote: > There are only three call sites remaining for > intel_wait_for_vblank(). Remove the function, and open code it to avoid > new users from showing up. > > v2: > - Use intel_crtc_wait_for_next_vblank() (Ville) > > Signed-off-by: Jani

Re: [Intel-gfx] [PATCH v2 03/10] drm/i915/crtc: rename intel_get_crtc_for_plane() to intel_crtc_for_plane()

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 03:57:05PM +0200, Jani Nikula wrote: > The "get" in the name implies reference counting, remove it. This also > makes the function conform to naming style. > > Suggested-by: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH v2 01/10] drm/i915/display: add intel_crtc_wait_for_next_vblank() and use it

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 03:57:03PM +0200, Jani Nikula wrote: > intel_wait_for_vblank() goes through a pipe to crtc lookup, while in > most cases we already have the crtc available. Avoid the extra lookups > by adding an intel_crtc based helper. > > v2: > - Add intel_crtc_wait_for_next_vblank()

Re: [Intel-gfx] [PATCH v2 02/10] drm/i915/crtc: rename intel_get_crtc_for_pipe() to intel_crtc_for_pipe()

2021-12-01 Thread Ville Syrjälä
On Wed, Dec 01, 2021 at 03:57:04PM +0200, Jani Nikula wrote: > The "get" in the name implies reference counting, remove it. This also > makes the function conform to naming style. > > Suggested-by: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH] drm/i915: Force ww lock for i915_gem_object_ggtt_pin_ww, v2.

2021-12-01 Thread Matthew Auld
On Tue, 30 Nov 2021 at 09:21, Maarten Lankhorst wrote: > > We will need the lock to unbind the vma, and wait for bind to complete. > Remove the special casing for the !ww path, and force ww locking for all. > > Changes since v1: > - Pass err to for_i915_gem_ww handling for -EDEADLK handling. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2) URL : https://patchwork.freedesktop.org/series/97173/ State : success == Summary == CI Bug Log - changes from CI_DRM_10949 -> Patchwork_21716

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] Revert "drm/i915: Implement Wa_1508744258" (rev2)

2021-12-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] Revert "drm/i915: Implement Wa_1508744258" (rev2) URL : https://patchwork.freedesktop.org/series/97105/ State : success == Summary == CI Bug Log - changes from CI_DRM_10949 -> Patchwork_21715

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2) URL : https://patchwork.freedesktop.org/series/97173/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2) URL : https://patchwork.freedesktop.org/series/97173/ State : warning == Summary == $ dim checkpatch origin/drm-tip e378d10ac676 drm/i915/display: add intel_crtc_wait_for_next_vblank() and use

[Intel-gfx] [PATCH v2 10/10] drm/i915/display: stop including i915_drv.h from intel_display_types.h

2021-12-01 Thread Jani Nikula
Break the dependency on i915_drv.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_types.h| 9 - drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 1 + drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-

[Intel-gfx] [PATCH v2 09/10] drm/i915/display: convert dp_to_i915() to a macro

2021-12-01 Thread Jani Nikula
Avoid looking into the guts of struct drm_i915_private in headers. Again, converting an inline function to a macro is less than ideal, but avoids having to pull in i915_drv.h just for the to_i915() part. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_types.h | 6

[Intel-gfx] [PATCH v2 08/10] drm/i915: move enum hpd_pin to intel_display.h

2021-12-01 Thread Jani Nikula
It's not the ideal location, but a better alternative than i915_drv.h. The goal is to break the intel_display_types.h to i915_drv.h dependency. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.h | 24 drivers/gpu/drm/i915/i915_drv.h |

[Intel-gfx] [PATCH v2 07/10] drm/i915: split out intel_pm_types.h

2021-12-01 Thread Jani Nikula
This is far from ideal, but it reduces the i915_drv.h dependency from intel_display_types.h. Maybe in the future we'll need a better split. Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/i915_drv.h | 64 +---

[Intel-gfx] [PATCH v2 06/10] drm/i915/fb: move intel_fb_uses_dpt to intel_fb.c and un-inline

2021-12-01 Thread Jani Nikula
Move fb functions where they belong, and un-inline to avoid looking into struct drm_i915_private guts in header files. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_types.h | 10 -- drivers/gpu/drm/i915/display/intel_fb.c| 10 ++

[Intel-gfx] [PATCH v2 05/10] drm/i915/crtc: un-inline some crtc functions and move to intel_crtc.[ch]

2021-12-01 Thread Jani Nikula
Move a number of crtc/pipe related functions to intel_crtc.[ch], and un-inline to avoid looking into struct drm_i915_private guts in header files. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crtc.c | 42 ++ drivers/gpu/drm/i915/display/intel_crtc.h

[Intel-gfx] [PATCH v2 04/10] drm/i915/display: remove intel_wait_for_vblank()

2021-12-01 Thread Jani Nikula
There are only three call sites remaining for intel_wait_for_vblank(). Remove the function, and open code it to avoid new users from showing up. v2: - Use intel_crtc_wait_for_next_vblank() (Ville) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-

[Intel-gfx] [PATCH v2 03/10] drm/i915/crtc: rename intel_get_crtc_for_plane() to intel_crtc_for_plane()

2021-12-01 Thread Jani Nikula
The "get" in the name implies reference counting, remove it. This also makes the function conform to naming style. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/intel_pm.c| 4 ++--

[Intel-gfx] [PATCH v2 02/10] drm/i915/crtc: rename intel_get_crtc_for_pipe() to intel_crtc_for_pipe()

2021-12-01 Thread Jani Nikula
The "get" in the name implies reference counting, remove it. This also makes the function conform to naming style. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_atomic_plane.c| 2 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-

[Intel-gfx] [PATCH v2 01/10] drm/i915/display: add intel_crtc_wait_for_next_vblank() and use it

2021-12-01 Thread Jani Nikula
intel_wait_for_vblank() goes through a pipe to crtc lookup, while in most cases we already have the crtc available. Avoid the extra lookups by adding an intel_crtc based helper. v2: - Add intel_crtc_wait_for_next_vblank() helper (Ville) Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH v2 00/10] drm/i915: break intel_display_types.h dependency on i915_drv.h

2021-12-01 Thread Jani Nikula
v2 of https://patchwork.freedesktop.org/series/97173/ BR, Jani. Jani Nikula (10): drm/i915/display: add intel_crtc_wait_for_next_vblank() and use it drm/i915/crtc: rename intel_get_crtc_for_pipe() to intel_crtc_for_pipe() drm/i915/crtc: rename intel_get_crtc_for_plane() to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adl_p: Add adl-p ddc pin mapping (rev2)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915/adl_p: Add adl-p ddc pin mapping (rev2) URL : https://patchwork.freedesktop.org/series/97009/ State : success == Summary == CI Bug Log - changes from CI_DRM_10949 -> Patchwork_21714 Summary ---

Re: [Intel-gfx] [PATCH] lib/stackdepot: always do filter_irq_stacks() in stack_depot_save()

2021-12-01 Thread Andrey Konovalov
On Tue, Nov 30, 2021 at 11:14 AM Marco Elver wrote: > > The non-interrupt portion of interrupt stack traces before interrupt > entry is usually arbitrary. Therefore, saving stack traces of interrupts > (that include entries before interrupt entry) to stack depot leads to > unbounded stackdepot

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4) URL : https://patchwork.freedesktop.org/series/96855/ State : success == Summary == CI Bug Log - changes from CI_DRM_10949 -> Patchwork_21713

Re: [Intel-gfx] [PATCH v2 00/16] drm/i915: Remove short term pins from execbuf.

2021-12-01 Thread Tvrtko Ursulin
On 01/12/2021 11:15, Maarten Lankhorst wrote: On 30-11-2021 19:38, Tvrtko Ursulin wrote: On 30/11/2021 11:17, Maarten Lankhorst wrote: On 30-11-2021 09:54, Tvrtko Ursulin wrote: Hi, On 29/11/2021 13:47, Maarten Lankhorst wrote: New version of the series, with feedback from previous

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Use to_root_gt() to refer to the root tile

2021-12-01 Thread Andi Shyti
Hi Michal, > >> fist of all thanks for taking a look at this, I was eagerly > >> waiting for reviewers. > >> > >> On Tue, Nov 30, 2021 at 01:07:30PM -0800, Lucas De Marchi wrote: > >>> On Sun, Nov 28, 2021 at 01:09:26PM +0200, Andi Shyti wrote: > >>> > Starting from a patch from Matt to_root_gt()

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4) URL : https://patchwork.freedesktop.org/series/96855/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4)

2021-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4) URL : https://patchwork.freedesktop.org/series/96855/ State : warning == Summary == $ dim checkpatch origin/drm-tip e1ed6afae3fa drm/i915: Skip remap_io_mapping() for non-x86 platforms -:63:

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce Raptor Lake S (rev4)

2021-12-01 Thread Patchwork
== Series Details == Series: Introduce Raptor Lake S (rev4) URL : https://patchwork.freedesktop.org/series/96869/ State : success == Summary == CI Bug Log - changes from CI_DRM_10949 -> Patchwork_21712 Summary --- **SUCCESS** No

Re: [Intel-gfx] [v3 0/3] Introduce Raptor Lake S

2021-12-01 Thread Jani Nikula
On Wed, 01 Dec 2021, Anusha Srivatsa wrote: > Raptor Lake S(RPL-S) is a version 12 > Display, Media and Render. For all i915 > purposes it is the same as Alder Lake S (ADL-S). > > The series introduces it as a subplatform > of ADL-S. The one difference is the GuC > submission which is default on

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce Raptor Lake S (rev4)

2021-12-01 Thread Patchwork
== Series Details == Series: Introduce Raptor Lake S (rev4) URL : https://patchwork.freedesktop.org/series/96869/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [Linaro-mm-sig] [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-12-01 Thread Intel
On 12/1/21 12:25, Christian König wrote: Am 01.12.21 um 12:04 schrieb Thomas Hellström (Intel): On 12/1/21 11:32, Christian König wrote: Am 01.12.21 um 11:15 schrieb Thomas Hellström (Intel): [SNIP] What we could do is to avoid all this by not calling the callback with the lock held in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce Raptor Lake S (rev4)

2021-12-01 Thread Patchwork
== Series Details == Series: Introduce Raptor Lake S (rev4) URL : https://patchwork.freedesktop.org/series/96869/ State : warning == Summary == $ dim checkpatch origin/drm-tip 91c35932ece3 drm/i915/rpl-s: Add PCI IDS for Raptor Lake S -:112: ERROR:COMPLEX_MACRO: Macros with complex values

  1   2   >