Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-05-02 Thread Dixit, Ashutosh
On Sun, 01 May 2022 23:22:02 -0700, Andrzej Hajda wrote: > On 29.04.2022 06:25, Dixit, Ashutosh wrote: > > On Thu, 28 Apr 2022 07:36:14 -0700, Andrzej Hajda wrote: > >> See [1], it is quite old, so maybe it is not valid anymore, but I see no > >> code proving sth has changed. > > Hi Andrzej, > > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/3] drm/i915/display: Allow DRRS to be enabled during driver load

2022-05-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915/display: Allow DRRS to be enabled during driver load URL : https://patchwork.freedesktop.org/series/103458/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11588_full -> Patchwork_103458v1_full

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Flat-CCS eviction enhancements (rev4)

2022-05-02 Thread Ramalingam C
On 2022-05-02 at 21:39:56 +, Patchwork wrote: > == Series Details == > > Series: Flat-CCS eviction enhancements (rev4) > URL : https://patchwork.freedesktop.org/series/102916/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11588_full -> Patchwork_102916v4_full >

[Intel-gfx] ✓ Fi.CI.IGT: success for Make the rest of the VFIO driver interface use vfio_device (rev4)

2022-05-02 Thread Patchwork
== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device (rev4) URL : https://patchwork.freedesktop.org/series/102606/ State : success == Summary == CI Bug Log - changes from CI_DRM_11588_full -> Patchwork_102606v4_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: remove superfluous string helper include (rev4)

2022-05-02 Thread Patchwork
== Series Details == Series: drm/i915: remove superfluous string helper include (rev4) URL : https://patchwork.freedesktop.org/series/103086/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11588_full -> Patchwork_103086v4_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/reset: Add Wa_22011802037 for gen11 and execlist backend

2022-05-02 Thread Patchwork
== Series Details == Series: drm/i915/reset: Add Wa_22011802037 for gen11 and execlist backend URL : https://patchwork.freedesktop.org/series/103461/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11589 -> Patchwork_103461v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/reset: Add Wa_22011802037 for gen11 and execlist backend

2022-05-02 Thread Patchwork
== Series Details == Series: drm/i915/reset: Add Wa_22011802037 for gen11 and execlist backend URL : https://patchwork.freedesktop.org/series/103461/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 10/11] drm/i915/pvc: skip all copy engines from aux table invalidate

2022-05-02 Thread Kumar Valsan, Prathap
On Mon, May 02, 2022 at 09:34:16AM -0700, Matt Roper wrote: > From: Lucas De Marchi > > As we have more copy engines now, mask all of them from aux table > invalidate. > > Cc: Prathap Kumar Valsan > Signed-off-by: Lucas De Marchi > Signed-off-by: Matt Roper > --- >

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Introduce Ponte Vecchio

2022-05-02 Thread Patchwork
== Series Details == Series: i915: Introduce Ponte Vecchio URL : https://patchwork.freedesktop.org/series/103443/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11588_full -> Patchwork_103443v1_full Summary ---

Re: [Intel-gfx] [PATCH 02/11] drm/i915/pvc: Add forcewake support

2022-05-02 Thread Summers, Stuart
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > Add PVC's forcewake ranges. > > Bspec: 67609 > Cc: Daniele Ceraolo Spurio > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/intel_uncore.c | 150 > +- > drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 +

Re: [Intel-gfx] [PATCH 08/11] drm/i915/pvc: Interrupt support for new copy engines

2022-05-02 Thread Summers, Stuart
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > This patch adds the interrupt handler support for Imperative: Add the interrupt support for... Otherwise: Reviewed-by: Stuart Summers > new copy engines. > > Bspec: 54030 > Original-author: CQ Tang > Signed-off-by: Matt Roper > --- >

Re: [Intel-gfx] [PATCH 09/11] drm/i915/pvc: Reset support for new copy engines

2022-05-02 Thread Summers, Stuart
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > This patch adds the reset support for new copy engines > in PVC. > > Bspec: 52549 > Original-author: CQ Tang > Signed-off-by: Matt Roper Reviewed-by: Stuart Summers > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 8 + >

[Intel-gfx] [PATCH] drm/i915/reset: Add Wa_22011802037 for gen11 and execlist backend

2022-05-02 Thread Umesh Nerlige Ramappa
Current implementation of Wa_22011802037 is limited to the GuC backend and gen12. Add support for execlist backend and gen11 as well. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/intel_engine.h| 2 + drivers/gpu/drm/i915/gt/intel_engine_cs.c | 81

[Intel-gfx] ✗ Fi.CI.IGT: failure for Flat-CCS eviction enhancements (rev4)

2022-05-02 Thread Patchwork
== Series Details == Series: Flat-CCS eviction enhancements (rev4) URL : https://patchwork.freedesktop.org/series/102916/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11588_full -> Patchwork_102916v4_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915/display: Allow DRRS to be enabled during driver load

2022-05-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915/display: Allow DRRS to be enabled during driver load URL : https://patchwork.freedesktop.org/series/103458/ State : success == Summary == CI Bug Log - changes from CI_DRM_11588 -> Patchwork_103458v1

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Matt Roper
On Mon, May 02, 2022 at 02:03:28PM -0700, Lucas De Marchi wrote: > On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: > > From: Ayaz A Siddiqui ... > > @@ -2002,11 +2002,18 @@ engine_fake_wa_init(struct intel_engine_cs *engine, > > struct i915_wa_list *wal) > > * Streamers on Gen12

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Lucas De Marchi
On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: From: Ayaz A Siddiqui Bspec: 45101, 72161 Signed-off-by: Ayaz A Siddiqui Signed-off-by: Fei Yang Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt_types.h| 1 + drivers/gpu/drm/i915/gt/intel_mocs.c| 24

Re: [Intel-gfx] [PATCH 01/11] drm/i915/pvc: add initial Ponte Vecchio definitions

2022-05-02 Thread Lucas De Marchi
On Mon, May 02, 2022 at 09:34:07AM -0700, Matt Roper wrote: From: Stuart Summers Additional blitter and media engines will be enabled later. Bspec: 44481, 44482 Signed-off-by: Stuart Summers Signed-off-by: Matt Roper Reviewed-by: Lucas De Marchi Lucas De Marchi

[Intel-gfx] [PATCH v2 2/3] drm/i915/display/dp: Try to fallback to previous link config if modeset is not allowed

2022-05-02 Thread José Roberto de Souza
When an atomic commit has changes that allows it to go to a lower DP link configuration it will require a modeset but userspace might not want it, so it would not set the modeset allowed flag causing commit to fail. Here in such case it tries to keep previous and trained link configuration for

[Intel-gfx] [PATCH v2 3/3] drm/i915/display: Implement seamless mode switch

2022-05-02 Thread José Roberto de Souza
So far the i915's DRRS feature was automatically changing between preferred panel mode and downclock mode based on idleness but ChromeOS compositor team is asking to be in control of the mode switch. So for certain types of content it can switch to a mode with a lower refresh rate without the user

[Intel-gfx] [PATCH v2 1/3] drm/i915/display: Allow DRRS to be enabled during driver load

2022-05-02 Thread José Roberto de Souza
When driver takes over display from firmware it does some checks and if possible it tries to avoid a modeset to improve user boot experience. But even if DRRS is supported it was being left disabled as intel_crtc_copy_fastset() was overwritten new state with the old one (hardware readout). So

Re: [Intel-gfx] [PATCH] i915/guc/reset: Make __guc_reset_context aware of guilty engines

2022-05-02 Thread Umesh Nerlige Ramappa
On Thu, Apr 28, 2022 at 09:13:57AM -0700, Teres Alexis, Alan Previn wrote: At a high level, this change looks good and simple. However, inside __guc_reset_context, i think there might be an observed change in behavior for parallel submission. (or perhaps this change is part the intent?):

[Intel-gfx] i915 Updates: DG2 DMC v2.06

2022-05-02 Thread Tolakanahalli Pradeep, Madhumitha
The following changes since commit c3624ebd67c68722e0fabc9cae01397b15310239: Merge branch 'ath10k-20220423' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/linux-firmware into main (2022-05-02 08:31:40 -0400) are available in the Git repository at:

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Matt Roper
On Mon, May 02, 2022 at 12:27:29PM -0700, Lucas De Marchi wrote: > On Mon, May 02, 2022 at 11:50:22AM -0700, Matt Roper wrote: > > On Mon, May 02, 2022 at 11:39:48AM -0700, Lucas De Marchi wrote: > > > On Mon, May 02, 2022 at 09:50:23AM -0700, Matt Roper wrote: > > > > On Mon, May 02, 2022 at

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Lucas De Marchi
On Mon, May 02, 2022 at 11:50:22AM -0700, Matt Roper wrote: On Mon, May 02, 2022 at 11:39:48AM -0700, Lucas De Marchi wrote: On Mon, May 02, 2022 at 09:50:23AM -0700, Matt Roper wrote: > On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: > > From: Ayaz A Siddiqui > > > > Bspec: 45101,

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Harry Wentland
On 2022-05-02 10:29, Harry Wentland wrote: > > > On 2022-05-02 10:27, Modem, Bhanuprakash wrote: >> On Mon-02-05-2022 07:08 pm, Harry Wentland wrote: >>> >>> >>> On 2022-05-02 09:28, Modem, Bhanuprakash wrote: On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: > > >>

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Matt Roper
On Mon, May 02, 2022 at 11:39:48AM -0700, Lucas De Marchi wrote: > On Mon, May 02, 2022 at 09:50:23AM -0700, Matt Roper wrote: > > On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: > > > From: Ayaz A Siddiqui > > > > > > Bspec: 45101, 72161 > > > Signed-off-by: Ayaz A Siddiqui > > >

Re: [Intel-gfx] [PATCH 11/11] drm/i915/pvc: read fuses for link copy engines

2022-05-02 Thread Souza, Jose
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > From: Lucas De Marchi > > The new Link Copy engines in PVC may be fused off according to the > mslice_mask. Each bit of the MEML3_EN_MASK we read from the > GEN10_MIRROR_FUSE3 register disables a pair of link copy engines. Reviewed-by: José

Re: [Intel-gfx] [PATCH 06/11] drm/i915/pvc: Reduce stack usage in reset selftest with extra blitter engine

2022-05-02 Thread Souza, Jose
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > From: John Harrison > > PVC adds extra blitter engines (in the following patch). The reset > selftest has a local array on the stack which is sized by the number > of engines. The increase pushes the size of this array to the point > where

Re: [Intel-gfx] [PATCH 07/11] drm/i915/pvc: Engines definitions for new copy engines

2022-05-02 Thread Souza, Jose
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > This patch adds the basic definitions needed to support > new copy engines. Also updating the cmd_info to accommodate > new engines, as the engine id's of legacy engines have been > changed. Reviewed-by: José Roberto de Souza > >

Re: [Intel-gfx] [PATCH 09/11] drm/i915/pvc: Reset support for new copy engines

2022-05-02 Thread Souza, Jose
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > This patch adds the reset support for new copy engines > in PVC. Reviewed-by: José Roberto de Souza > > Bspec: 52549 > Original-author: CQ Tang > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 8 + >

Re: [Intel-gfx] [PATCH 10/11] drm/i915/pvc: skip all copy engines from aux table invalidate

2022-05-02 Thread Souza, Jose
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > From: Lucas De Marchi > > As we have more copy engines now, mask all of them from aux table > invalidate. Reviewed-by: José Roberto de Souza > > Cc: Prathap Kumar Valsan > Signed-off-by: Lucas De Marchi > Signed-off-by: Matt Roper >

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Lucas De Marchi
On Mon, May 02, 2022 at 09:50:23AM -0700, Matt Roper wrote: On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: From: Ayaz A Siddiqui Bspec: 45101, 72161 Signed-off-by: Ayaz A Siddiqui Signed-off-by: Fei Yang Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt_types.h

[Intel-gfx] ✓ Fi.CI.BAT: success for Make the rest of the VFIO driver interface use vfio_device (rev4)

2022-05-02 Thread Patchwork
== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device (rev4) URL : https://patchwork.freedesktop.org/series/102606/ State : success == Summary == CI Bug Log - changes from CI_DRM_11588 -> Patchwork_102606v4

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Add MMIO range restrictions

2022-05-02 Thread Lucas De Marchi
On Fri, Apr 29, 2022 at 01:49:37PM -0700, Lucas De Marchi wrote: On Fri, Apr 29, 2022 at 01:39:03PM -0700, Anusha Srivatsa wrote: -Original Message- From: De Marchi, Lucas Sent: Tuesday, April 26, 2022 10:42 PM To: Srivatsa, Anusha Cc: intel-gfx@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-05-02 Thread Lionel Landwerlin
On 02/05/2022 20:58, Abodunrin, Akeem G wrote: -Original Message- From: Landwerlin, Lionel G Sent: Monday, May 2, 2022 12:55 AM To: Auld, Matthew ; intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org; Thomas Hellström ; Bloomfield, Jon ; Daniel Vetter ; Justen, Jordan

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Make the rest of the VFIO driver interface use vfio_device (rev4)

2022-05-02 Thread Patchwork
== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device (rev4) URL : https://patchwork.freedesktop.org/series/102606/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Make the rest of the VFIO driver interface use vfio_device (rev4)

2022-05-02 Thread Patchwork
== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device (rev4) URL : https://patchwork.freedesktop.org/series/102606/ State : warning == Summary == Error: dim checkpatch failed ec715bc61dd4 vfio: Make vfio_(un)register_notifier accept a vfio_device -:227:

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-05-02 Thread Abodunrin, Akeem G
> -Original Message- > From: Landwerlin, Lionel G > Sent: Monday, May 2, 2022 12:55 AM > To: Auld, Matthew ; intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Thomas Hellström > ; Bloomfield, Jon > ; Daniel Vetter ; Justen, > Jordan L ; Kenneth Graunke > ;

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove superfluous string helper include (rev4)

2022-05-02 Thread Patchwork
== Series Details == Series: drm/i915: remove superfluous string helper include (rev4) URL : https://patchwork.freedesktop.org/series/103086/ State : success == Summary == CI Bug Log - changes from CI_DRM_11588 -> Patchwork_103086v4

[Intel-gfx] ✗ Fi.CI.IGT: failure for uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-02 Thread Patchwork
== Series Details == Series: uapi/drm/i915: Document memory residency and Flat-CCS capability of obj URL : https://patchwork.freedesktop.org/series/103434/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11586_full -> Patchwork_103434v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Introduce Ponte Vecchio

2022-05-02 Thread Patchwork
== Series Details == Series: i915: Introduce Ponte Vecchio URL : https://patchwork.freedesktop.org/series/103443/ State : success == Summary == CI Bug Log - changes from CI_DRM_11588 -> Patchwork_103443v1 Summary --- **SUCCESS**

Re: [Intel-gfx] [CI] PR for DG2 DMC v2.06

2022-05-02 Thread Tolakanahalli Pradeep, Madhumitha
Hi Timo, Sincere apologies! This slipped through the cracks, I'll be sending the PR request to linux-firmware in the next couple of minutes. Thanks, - Madhumitha On Mon, 2022-05-02 at 16:51 +0300, Timo Aaltonen wrote: > Timo Aaltonen kirjoitti 13.4.2022 klo 13.48: > > Tolakanahalli Pradeep,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Introduce Ponte Vecchio

2022-05-02 Thread Patchwork
== Series Details == Series: i915: Introduce Ponte Vecchio URL : https://patchwork.freedesktop.org/series/103443/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Introduce Ponte Vecchio

2022-05-02 Thread Patchwork
== Series Details == Series: i915: Introduce Ponte Vecchio URL : https://patchwork.freedesktop.org/series/103443/ State : warning == Summary == Error: dim checkpatch failed f0fb02e3d246 drm/i915/pvc: add initial Ponte Vecchio definitions 9db154eb1285 drm/i915/pvc: Add forcewake support -:83:

Re: [Intel-gfx] [PATCH 04/11] drm/i915/pvc: Read correct RP_STATE_CAP register

2022-05-02 Thread Rodrigo Vivi
On Mon, May 02, 2022 at 09:34:10AM -0700, Matt Roper wrote: > The SoC registers, including RP_STATE_CAP, have moved to a new location > in GTTMMADR on Ponte Vecchio. We need to update the register offset > accordingly. > > Cc: Rodrigo Vivi > Signed-off-by: Matt Roper Reviewed-by: Rodrigo Vivi

[Intel-gfx] ✓ Fi.CI.BAT: success for Flat-CCS eviction enhancements (rev4)

2022-05-02 Thread Patchwork
== Series Details == Series: Flat-CCS eviction enhancements (rev4) URL : https://patchwork.freedesktop.org/series/102916/ State : success == Summary == CI Bug Log - changes from CI_DRM_11588 -> Patchwork_102916v4 Summary ---

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Matt Roper
On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: > From: Ayaz A Siddiqui > > Bspec: 45101, 72161 > Signed-off-by: Ayaz A Siddiqui > Signed-off-by: Fei Yang > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_gt_types.h| 1 + >

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915/gt: BUG_ON unexpected NULL at scatterlist walking

2022-05-02 Thread Jani Nikula
On Mon, 02 May 2022, Ramalingam C wrote: > While locating the start of ccs scatterlist in smem scatterlist, that has > to be the size of lmem obj size + corresponding ccs data size, report bug > if scatterlist terminate before that length. > > v2: > s/GEM_BUG_ON/BUG_ON with more commenting

[Intel-gfx] [PATCH 11/11] drm/i915/pvc: read fuses for link copy engines

2022-05-02 Thread Matt Roper
From: Lucas De Marchi The new Link Copy engines in PVC may be fused off according to the mslice_mask. Each bit of the MEML3_EN_MASK we read from the GEN10_MIRROR_FUSE3 register disables a pair of link copy engines. Bspec: 44483 Cc: Matt Roper Signed-off-by: Lucas De Marchi Signed-off-by: Matt

[Intel-gfx] [PATCH 08/11] drm/i915/pvc: Interrupt support for new copy engines

2022-05-02 Thread Matt Roper
This patch adds the interrupt handler support for new copy engines. Bspec: 54030 Original-author: CQ Tang Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 16 drivers/gpu/drm/i915/gt/intel_gt_regs.h | 4 2 files changed, 20 insertions(+) diff --git

[Intel-gfx] [PATCH 10/11] drm/i915/pvc: skip all copy engines from aux table invalidate

2022-05-02 Thread Matt Roper
From: Lucas De Marchi As we have more copy engines now, mask all of them from aux table invalidate. Cc: Prathap Kumar Valsan Signed-off-by: Lucas De Marchi Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] [PATCH 01/11] drm/i915/pvc: add initial Ponte Vecchio definitions

2022-05-02 Thread Matt Roper
From: Stuart Summers Additional blitter and media engines will be enabled later. Bspec: 44481, 44482 Signed-off-by: Stuart Summers Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c | 21 +

[Intel-gfx] [PATCH 09/11] drm/i915/pvc: Reset support for new copy engines

2022-05-02 Thread Matt Roper
This patch adds the reset support for new copy engines in PVC. Bspec: 52549 Original-author: CQ Tang Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 8 + drivers/gpu/drm/i915/gt/intel_gt_regs.h | 44 +-- 2 files changed, 34 insertions(+), 18

[Intel-gfx] [PATCH 05/11] drm/i915/pvc: Remove additional 3D flags from PIPE_CONTROL

2022-05-02 Thread Matt Roper
From: Stuart Summers Although we already strip 3D-specific flags from PIPE_CONTROL instructions when submitting to a compute engine, there are some additional flags that need to be removed when the platform as a whole lacks a 3D pipeline. Add those restrictions here. Bspec: 47112

[Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Matt Roper
From: Ayaz A Siddiqui Bspec: 45101, 72161 Signed-off-by: Ayaz A Siddiqui Signed-off-by: Fei Yang Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt_types.h| 1 + drivers/gpu/drm/i915/gt/intel_mocs.c| 24 -

[Intel-gfx] [PATCH 02/11] drm/i915/pvc: Add forcewake support

2022-05-02 Thread Matt Roper
Add PVC's forcewake ranges. Bspec: 67609 Cc: Daniele Ceraolo Spurio Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_uncore.c | 150 +- drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 + 2 files changed, 151 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 07/11] drm/i915/pvc: Engines definitions for new copy engines

2022-05-02 Thread Matt Roper
This patch adds the basic definitions needed to support new copy engines. Also updating the cmd_info to accommodate new engines, as the engine id's of legacy engines have been changed. Original-author: CQ Tang Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 56

[Intel-gfx] [PATCH 06/11] drm/i915/pvc: Reduce stack usage in reset selftest with extra blitter engine

2022-05-02 Thread Matt Roper
From: John Harrison PVC adds extra blitter engines (in the following patch). The reset selftest has a local array on the stack which is sized by the number of engines. The increase pushes the size of this array to the point where it trips the 'stack too large' compile warning. This patch takes

[Intel-gfx] [PATCH 04/11] drm/i915/pvc: Read correct RP_STATE_CAP register

2022-05-02 Thread Matt Roper
The SoC registers, including RP_STATE_CAP, have moved to a new location in GTTMMADR on Ponte Vecchio. We need to update the register offset accordingly. Cc: Rodrigo Vivi Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_rps.c | 4 +++- drivers/gpu/drm/i915/i915_reg.h | 1 + 2

[Intel-gfx] [PATCH 00/11] i915: Introduce Ponte Vecchio

2022-05-02 Thread Matt Roper
Ponte Vecchio (PVC) is a new GPU based on the Xe_HPC architecture. As a compute-focused platform, PVC has compute engines and enhanced copy engines, but no render engine (there is no geometry pipeline) and no display. This is just a handful of early enablement patches, including some initial

Re: [Intel-gfx] [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-02 Thread Mike Lothian
On Mon, 2 May 2022 at 16:54, Arunpravin Paneer Selvam wrote: > > > > On 5/2/2022 8:41 PM, Mike Lothian wrote: > > On Wed, 27 Apr 2022 at 12:55, Mike Lothian wrote: > >> On Tue, 26 Apr 2022 at 17:36, Christian König > >> wrote: > >>> Hi Mike, > >>> > >>> sounds like somehow stitching together

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Flat-CCS eviction enhancements (rev4)

2022-05-02 Thread Patchwork
== Series Details == Series: Flat-CCS eviction enhancements (rev4) URL : https://patchwork.freedesktop.org/series/102916/ State : warning == Summary == Error: dim checkpatch failed 848866286442 drm/i915/gt: BUG_ON unexpected NULL at scatterlist walking -:35: WARNING:AVOID_BUG: Avoid crashing

[Intel-gfx] ✗ Fi.CI.IGT: failure for lrc selftest fixes (rev6)

2022-05-02 Thread Patchwork
== Series Details == Series: lrc selftest fixes (rev6) URL : https://patchwork.freedesktop.org/series/101353/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11585_full -> Patchwork_101353v6_full Summary ---

Re: [Intel-gfx] [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-02 Thread Mike Lothian
On Wed, 27 Apr 2022 at 12:55, Mike Lothian wrote: > > On Tue, 26 Apr 2022 at 17:36, Christian König > wrote: > > > > Hi Mike, > > > > sounds like somehow stitching together the SG table for PRIME doesn't > > work any more with this patch. > > > > Can you try with P2P DMA disabled? > >

[Intel-gfx] ✓ Fi.CI.BAT: success for uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-02 Thread Patchwork
== Series Details == Series: uapi/drm/i915: Document memory residency and Flat-CCS capability of obj URL : https://patchwork.freedesktop.org/series/103434/ State : success == Summary == CI Bug Log - changes from CI_DRM_11586 -> Patchwork_103434v1

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix race in __i915_vma_remove_closed

2022-05-02 Thread Karol Herbst
friendly ping. I am not even myself completely convinced that this is the correct patch and it might just workaround some issues, but list_debug.c does check if a list was already deleted and throws an error if it was and this patch indeed fixes this one issue as multiple threads could enter

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Harry Wentland
On 2022-05-02 10:27, Modem, Bhanuprakash wrote: > On Mon-02-05-2022 07:08 pm, Harry Wentland wrote: >> >> >> On 2022-05-02 09:28, Modem, Bhanuprakash wrote: >>> On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: > -Original Message- > From: Intel-gfx On Behalf Of >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-02 Thread Patchwork
== Series Details == Series: uapi/drm/i915: Document memory residency and Flat-CCS capability of obj URL : https://patchwork.freedesktop.org/series/103434/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Modem, Bhanuprakash
On Mon-02-05-2022 07:08 pm, Harry Wentland wrote: On 2022-05-02 09:28, Modem, Bhanuprakash wrote: On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: -Original Message- From: Intel-gfx On Behalf Of Bhanuprakash Modem Sent: Monday, April 11, 2022 3:21 PM To:

[Intel-gfx] [PATCH v3 3/3] drm/i915/gt: Document the eviction of the Flat-CCS objects

2022-05-02 Thread Ramalingam C
Capture the eviction details for Flat-CCS capable, lmem objects. v2: Fix the Flat-ccs capbility of lmem obj with smem residency possibility [Thomas] v3: Fixed the suggestions [Matt] Signed-off-by: Ramalingam C cc: Thomas Hellstrom cc: Matthew Auld Reviewed-by: Matthew Auld ---

[Intel-gfx] [PATCH v3 2/3] drm/i915/gt: optimize the ccs_sz calculation per chunk

2022-05-02 Thread Ramalingam C
Calculate the ccs_sz that needs to be emitted based on the src and dst pages emitted per chunk. And handle the return value of emit_pte for the ccs pages. v2: ccs_sz moved to the reduced scope [Matt] Signed-off-by: Ramalingam C Reviewed-by: Matthew Auld ---

[Intel-gfx] [PATCH v3 1/3] drm/i915/gt: BUG_ON unexpected NULL at scatterlist walking

2022-05-02 Thread Ramalingam C
While locating the start of ccs scatterlist in smem scatterlist, that has to be the size of lmem obj size + corresponding ccs data size, report bug if scatterlist terminate before that length. v2: s/GEM_BUG_ON/BUG_ON with more commenting [Matt] v3: Converted GEM_BUG_ON into BUG_ON with more

[Intel-gfx] [PATCH v3 0/3] Flat-CCS eviction enhancements

2022-05-02 Thread Ramalingam C
Flat-CCS eviction enhancements v3: Incorporated the review suggestions [Matt] Ramalingam C (3): drm/i915/gt: BUG_ON unexpected NULL at scatterlist walking drm/i915/gt: optimize the ccs_sz calculation per chunk drm/i915/gt: Document the eviction of the Flat-CCS objects

[Intel-gfx] [PATCH v3] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-02 Thread Ramalingam C
Capture the impact of memory region preference list of the objects, on their memory residency and Flat-CCS capability. v2: Fix the Flat-CCS capability of an obj with {lmem, smem} preference list [Thomas] v3: Reworded the doc [Matt] Signed-off-by: Ramalingam C cc: Matthew Auld cc: Thomas

Re: [Intel-gfx] [CI] PR for DG2 DMC v2.06

2022-05-02 Thread Timo Aaltonen
Timo Aaltonen kirjoitti 13.4.2022 klo 13.48: Tolakanahalli Pradeep, Madhumitha kirjoitti 23.3.2022 klo 20.23: The following changes since commit 681281e49fb6778831370e5d94e6e1d97f0752d6:    amdgpu: update PSP 13.0.8 firmware (2022-03-18 07:35:54 -0400) are available in the Git repository at:

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Harry Wentland
On 2022-05-02 09:28, Modem, Bhanuprakash wrote: > On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: >> >> >>> -Original Message- >>> From: Intel-gfx On Behalf Of >>> Bhanuprakash Modem >>> Sent: Monday, April 11, 2022 3:21 PM >>> To: intel-gfx@lists.freedesktop.org;

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Modem, Bhanuprakash
On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: -Original Message- From: Intel-gfx On Behalf Of Bhanuprakash Modem Sent: Monday, April 11, 2022 3:21 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; amd- g...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-05-02 Thread Rodrigo Vivi
On Fri, Apr 29, 2022 at 12:56:24PM -0700, Ashutosh Dixit wrote: > Each gt contains an independent instance of pcode. Extend pcode functions > to interface with pcode on different gt's. To avoid creating dependency of > display functionality on intel_gt, pcode function interfaces are exposed in >

Re: [Intel-gfx] [PATCH v4 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-05-02 Thread Ramalingam C
On 2022-05-02 at 16:40:00 +0530, Ramalingam C wrote: > From: Chris Wilson > > Even though the initial protocontext we load onto HW has the register > cleared, by the time we save it into the default image, BB_OFFSET has > had the enable bit set. Reclear BB_OFFSET for each new context. > >

Re: [Intel-gfx] PR for new GuC v70.1.2 for DG2

2022-05-02 Thread Josh Boyer
On Thu, Apr 28, 2022 at 3:07 PM wrote: > > The following changes since commit ac21ab5d1de0de34201c90d32eee436f873d1e5b: > > Mellanox: Add lc_ini_bundle for xx.2010.1006 (2022-04-25 07:36:16 -0400) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-firmware

[Intel-gfx] ✓ Fi.CI.BAT: success for lrc selftest fixes (rev6)

2022-05-02 Thread Patchwork
== Series Details == Series: lrc selftest fixes (rev6) URL : https://patchwork.freedesktop.org/series/101353/ State : success == Summary == CI Bug Log - changes from CI_DRM_11585 -> Patchwork_101353v6 Summary --- **SUCCESS** No

Re: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-05-02 Thread Jani Nikula
On Fri, 29 Apr 2022, "Murthy, Arun R" wrote: >> +static int output_bpc_show(struct seq_file *m, void *data) { > > Can we have a meaningful name instead of 'm' ? > Upon changing this parameter name, you can have my > Reviewed-By: Arun R Murthy Please keep 'm'. It's by far the most common name

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for lrc selftest fixes (rev6)

2022-05-02 Thread Patchwork
== Series Details == Series: lrc selftest fixes (rev6) URL : https://patchwork.freedesktop.org/series/101353/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] [PATCH v4 3/4] drm/i915/selftest: Always cancel semaphore on error

2022-05-02 Thread Ramalingam C
From: Chris Wilson Ensure that we always signal the semaphore when timing out, so that if it happens to be stuck waiting for the semaphore we will quickly recover without having to wait for a reset. Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen

[Intel-gfx] [PATCH v4 4/4] drm/i915/selftest: Clear the output buffers before GPU writes

2022-05-02 Thread Ramalingam C
From: Chris Wilson When testing whether we can get the GPU to leak information about non-privileged state, we first need to ensure that the output buffer is set to a known value as the HW may opt to skip the write into memory for a non-privileged read of a sensitive register. We chose

[Intel-gfx] [PATCH v4 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

2022-05-02 Thread Ramalingam C
From: Chris Wilson In order to keep the context image parser simple, we assume that all commands follow a similar format. A few, especially not MI commands on the render engines, have fixed lengths not encoded in a length field. This caused us to incorrectly skip over 3D state commands, and

[Intel-gfx] [PATCH v4 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-05-02 Thread Ramalingam C
From: Chris Wilson Even though the initial protocontext we load onto HW has the register cleared, by the time we save it into the default image, BB_OFFSET has had the enable bit set. Reclear BB_OFFSET for each new context. Testcase: igt/i915_selftests/gt_lrc v2: Extend it for gen8. v3:

[Intel-gfx] [PATCH v4 0/4] lrc selftest fixes

2022-05-02 Thread Ramalingam C
Few bug fixes for lrc selftest. v4: Gen8 don't have per engine recording of BB_OFFSET [Chris] Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Always cancel semaphore on error

Re: [Intel-gfx] [PATCH] drm/i915: move tons of power well initializers to rodata

2022-05-02 Thread Jani Nikula
On Fri, 29 Apr 2022, Imre Deak wrote: > On Fri, Apr 29, 2022 at 05:21:40PM +0300, Jani Nikula wrote: >> Using compound literals for initialization can be tricky. Lacking a >> const qualifier, they won't end up in rodata, which is probably not >> expected or intended. Add const to move a whopping

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-05-02 Thread Lionel Landwerlin
On 02/05/2022 10:54, Lionel Landwerlin wrote: On 20/04/2022 20:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other small tweaks. (Akeem & Thomas)    - Rework error capture interactions, including no longer needing

Re: [Intel-gfx] [PATCH] drm/i915: use IOMEM_ERR_PTR() directly

2022-05-02 Thread Jani Nikula
On Mon, 02 May 2022, Kefeng Wang wrote: > Use IOMEM_ERR_PTR() instead of self defined IO_ERR_PTR(). > > Signed-off-by: Kefeng Wang Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_vma.c | 4 ++-- > drivers/gpu/drm/i915/i915_vma.h | 1 - > 2 files changed, 2 insertions(+), 3

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-05-02 Thread Lionel Landwerlin
On 20/04/2022 20:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture.

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915 private writeback framework

2022-05-02 Thread Patchwork
== Series Details == Series: i915 private writeback framework URL : https://patchwork.freedesktop.org/series/103417/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11584 -> Patchwork_103417v1 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-05-02 Thread Andrzej Hajda
On 29.04.2022 06:25, Dixit, Ashutosh wrote: On Thu, 28 Apr 2022 07:36:14 -0700, Andrzej Hajda wrote: On 27.04.2022 22:46, Dixit, Ashutosh wrote: On Sun, 24 Apr 2022 15:36:23 -0700, Andi Shyti wrote: Hi Andrzej and Ashutosh, b/drivers/gpu/drm/i915/gt/intel_gt_types.h index