[Intel-gfx] [PATCH v1] drm/ttm: Clean up page shift operation

2022-11-21 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. v1 -> v2: fix missing page shift to fpfn and lpfn Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- drivers/gpu/drm/ttm/ttm_range_manager.c| 13

[Intel-gfx] [PATCH v6 03/10] drm/i915/dp: Replace intel_dp.dfp members with the new crtc_state sink_format

2022-11-21 Thread Ankit Nautiyal
The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch uses the members of intel_dp->dfp to only store the format conversion capabilities of the DP device and uses the crtc_state sink_format member, to program the protocol-converter for

[Intel-gfx] [PATCH v5 08/10] drm/i915/dp: Handle BPP where HDMI2.1 DFP doesn't support DSC

2022-11-21 Thread Ankit Nautiyal
Currently we use the highest input BPC supported by DP sink while using DSC.In cases where PCON with HDMI2.1 as branch device, if PCON supports DSC but HDMI2.1 sink does not supports DSC, The PCON tries to use same input BPC that is used between Source and the PCON without DSC, which might not

[Intel-gfx] [PATCH v5 05/10] drm/i915/display: Use sink_format instead of ycbcr420_output flag

2022-11-21 Thread Ankit Nautiyal
Start passing the sink_format, to all functions that take a bool ycbcr420_output as parameter. This will make the functions generic, and will serve as a slight step towards 4:2:2 support later. Suggested-by: Ville Syrj_l_ Signed-off-by: Ankit Nautiyal ---

[Intel-gfx] [PATCH v5 09/10] drm/i915/dp: Fix FRL BW check for HDMI2.1 DFP

2022-11-21 Thread Ankit Nautiyal
During FRL bandwidth check for downstream HDMI2.1 sink, the min BPC supported is incorrectly taken for DP, and the check does not consider ybcr420 only modes. This patch fixes the bandwidth calculation similar to the TMDS case, by taking min 8Bpc and considering Ycbcr420 only modes. v2: Rebase

[Intel-gfx] [PATCH v5 07/10] drm/i915/dp: Avoid DSC with output_format YCBC420

2022-11-21 Thread Ankit Nautiyal
Currently, DSC with YCBCR420 is not supported. Return -EINVAL when trying with DSC with output_format as YCBCR420. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c

[Intel-gfx] [PATCH v5 02/10] drm/i915/display: Add new member in intel_dp to store ycbcr420 passthrough cap

2022-11-21 Thread Ankit Nautiyal
New member to store the YCBCR20 Pass through capability of the DP sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h

[Intel-gfx] [PATCH v5 10/10] drm/i915/dp: Add a wrapper to check frl/tmds downstream constraints

2022-11-21 Thread Ankit Nautiyal
Add a wrapper function to check dp_downstream clock/bandwidth constraints. Based on whether the sink supports FRL/TMDS the wrapper calls the appropriate FRL/TMDS functions. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 51 +++-- 1 file changed,

[Intel-gfx] [PATCH v5 06/10] drm/i915/display: Add helper function to check if sink_format is 420

2022-11-21 Thread Ankit Nautiyal
Add an inline helper function to check if the sink_format is set to YCBCR420 format. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display_types.h | 6 ++ drivers/gpu/drm/i915/display/intel_dp.c| 4 ++-- drivers/gpu/drm/i915/display/intel_hdmi.c |

[Intel-gfx] [PATCH v6 01/10] drm/i915/display: Add new member to configure PCON color conversion

2022-11-21 Thread Ankit Nautiyal
The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch adds new member to crtc_state to represent the final output_format to the sink. In case of a DFP this can be different than the output_format, as per the format conversion done via the

[Intel-gfx] [PATCH v1 04/10] drm/i915/dp: Compute output format with/without DSC

2022-11-21 Thread Ankit Nautiyal
Currently we compute the output format first and later try DSC if the bandwidth without compression is not sufficient for that output format. Since we do not support DSC with YCbCr420 format, this creates problem for YCbCr420 only modes, that can be still be set if DFP has color conversion and DSC

[Intel-gfx] [PATCH v6 00/10] Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes

2022-11-21 Thread Ankit Nautiyal
This series fixes issues faced when an HDMI2.1 sink that does not support DSC is connected via HDMI2.1PCON. It also includes other minor HDMI2.1 PCON fixes/refactoring. Patch 1-2 Have minor fixes/cleanups. Patch 3-6 Pull the decision making to use DFP conversion capabilities for every mode during

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Media GT and Render GT share common GGTT (rev5)

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Media GT and Render GT share common GGTT (rev5) URL : https://patchwork.freedesktop.org/series/110321/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [i-g-t] tests/kms_plane: skip memory demanding modes in test_plane_panning

2022-11-21 Thread Andrzej Hajda
Gently ping. Regards Andrzej On 15.11.2022 08:28, Andrzej Hajda wrote: test_plane_panning requires about 10 times bigger amount of memory than memory required by framebuffer in default display mode. In case of some configurations it can exceed available memory (4k modes on small-bar systems),

[Intel-gfx] [PATCH v4] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-21 Thread Aravind Iddamsetty
On XE_LPM+ platforms the media engines are carved out into a separate GT but have a common GGTMMADR address range which essentially makes the GGTT address space to be shared between media and render GT. As a result any updates in GGTT shall invalidate TLB of GTs sharing it and similarly any

Re: [Intel-gfx] [PATCH 2/2] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2022-11-21 Thread Arunpravin Paneer Selvam
On 11/22/2022 10:48 AM, Somalapuram, Amaranath wrote: On 11/16/2022 2:50 PM, Arunpravin Paneer Selvam wrote: Hi Amar, On 11/16/2022 2:20 PM, Somalapuram Amaranath wrote: ttm_resource allocate size in bytes i.e less than page size. Signed-off-by: Somalapuram Amaranath ---  

Re: [Intel-gfx] [PULL] gvt-fixes

2022-11-21 Thread Zhenyu Wang
ping for this fix pull... On 2022.11.11 17:02:08 +0800, Zhenyu Wang wrote: > Hi, > > Here's two fixes from Sean for 6.1 kernel, which is to fix kvm > reference in gvt. No regression found in our test. > > Thanks! > --- > The following changes since commit

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gvt: Fix for KVM refcounting bug

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Fix for KVM refcounting bug URL : https://patchwork.freedesktop.org/series/49/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12409_full -> Patchwork_49v1_full Summary

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/selftests: Add hwmon support in libpower for dgfx

2022-11-21 Thread Dixit, Ashutosh
On Sun, 20 Nov 2022 23:29:46 -0800, Riana Tauro wrote: > > diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c > b/drivers/gpu/drm/i915/gt/selftest_rc6.c > index 15b84c428f66..845058ed83ed 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_rc6.c > +++ b/drivers/gpu/drm/i915/gt/selftest_rc6.c > @@

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/hwmon: Add helper function to obtain energy values

2022-11-21 Thread Dixit, Ashutosh
On Sun, 20 Nov 2022 23:29:45 -0800, Riana Tauro wrote: > > diff --git a/drivers/gpu/drm/i915/i915_hwmon.h > b/drivers/gpu/drm/i915/i915_hwmon.h > index 7ca9cf2c34c9..a6c8efeb868d 100644 > --- a/drivers/gpu/drm/i915/i915_hwmon.h > +++ b/drivers/gpu/drm/i915/i915_hwmon.h > @@ -12,6 +12,7 @@ struct

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Fix error return code in live_parallel_switch()

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix error return code in live_parallel_switch() URL : https://patchwork.freedesktop.org/series/48/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12409_full -> Patchwork_48v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: unpin on error in intel_vgpu_shadow_mm_pin()

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: unpin on error in intel_vgpu_shadow_mm_pin() URL : https://patchwork.freedesktop.org/series/47/ State : success == Summary == CI Bug Log - changes from CI_DRM_12409_full -> Patchwork_47v1_full

Re: [Intel-gfx] [PATCH 4/6] drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded

2022-11-21 Thread Ceraolo Spurio, Daniele
On 11/21/2022 3:16 PM, Daniele Ceraolo Spurio wrote: If the GSC was loaded, the only way to stop it during the driver unload flow is to do a driver-FLR. The driver-FLR is not the same as PCI config space FLR in that it doesn't reset the SGUnit and doesn't modify the PCI config space. Thus, it

Re: [Intel-gfx] [PATCH 1/2] drm/i915/pxp: Invalidate all PXP fw sessions during teardown

2022-11-21 Thread Juston Li
On Thu, 2022-11-17 at 16:36 -0800, Alan Previn wrote: > A gap was recently discovered where if an application did not > invalidate all of the stream keys (intentionally or not), and the > driver did a full PXP global teardown on the GT subsystem, we > find that future session creation would fail

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add support for GSC FW loading

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Add support for GSC FW loading URL : https://patchwork.freedesktop.org/series/70/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12409 -> Patchwork_70v1 Summary ---

Re: [Intel-gfx] [PATCH v3 0/2] Fix live busy stats selftest failure

2022-11-21 Thread Umesh Nerlige Ramappa
On Mon, Nov 21, 2022 at 08:13:15PM +, Umesh Nerlige Ramappa wrote: Reg: Fi.CI.IGT https://patchwork.freedesktop.org/series/110557/#rev3 shows the below CI failures: igt@i915_module_load@reload-with-fault-injection: shard-snb: PASS -> INCOMPLETE Looks more like a stack corruption, but

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add support for GSC FW loading

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Add support for GSC FW loading URL : https://patchwork.freedesktop.org/series/70/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for GSC FW loading

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Add support for GSC FW loading URL : https://patchwork.freedesktop.org/series/70/ State : warning == Summary == Error: dim checkpatch failed 450d4acc03ed drm/i915/uc: Introduce GSC FW Traceback (most recent call last): File "scripts/spdxcheck.py",

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/2] drm/i915/migrate: Account for the reserved_space

2022-11-21 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915/migrate: Account for the reserved_space URL : https://patchwork.freedesktop.org/series/55/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12409 -> Patchwork_55v1

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix negative value passed as remaining time

2022-11-21 Thread Janusz Krzysztofik
Hi Andrzej, Thanks for providing your R-b. On Monday, 21 November 2022 18:40:51 CET Andrzej Hajda wrote: > On 21.11.2022 15:56, Janusz Krzysztofik wrote: > > Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work > > with GuC") extended the API of

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-21 Thread Janusz Krzysztofik
Hi Andrzej, Thanks for providing your R-b, however, I'd still like to convince you that my approach, which you accepted anyway, is better justified than if we updated 0 timeout with -ETIME immediately after returned by dma_fence_wait_timeout(). On Monday, 21 November 2022 13:12:00 CET Andrzej

[Intel-gfx] [PATCH 6/6] drm/i915/mtl: MTL has one GSC CS on the media GT

2022-11-21 Thread Daniele Ceraolo Spurio
Now that we have the GSC FW support code as a user to the GSC CS, we can add the relevant flag to the engine mask. Note that the engine will still be disabled until we define the GSC FW binary file. Signed-off-by: Daniele Ceraolo Spurio Cc: Matt Roper Cc: Rodrigo Vivi ---

[Intel-gfx] [PATCH 4/6] drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded

2022-11-21 Thread Daniele Ceraolo Spurio
If the GSC was loaded, the only way to stop it during the driver unload flow is to do a driver-FLR. The driver-FLR is not the same as PCI config space FLR in that it doesn't reset the SGUnit and doesn't modify the PCI config space. Thus, it doesn't require a re-enumeration of the PCI BARs.

[Intel-gfx] [PATCH 5/6] drm/i915/gsc: Disable GSC engine and power well if FW is not selected

2022-11-21 Thread Daniele Ceraolo Spurio
From: Jonathan Cavitt The GSC CS is only used for communicating with the GSC FW, so no need to initialize it if we're not going to use the FW. If we're not using neither the engine nor the microcontoller, then we can also disable the power well. IMPORTANT: lack of GSC FW breaks media C6 due to

[Intel-gfx] [PATCH 3/6] drm/i915/gsc: GSC firmware loading

2022-11-21 Thread Daniele Ceraolo Spurio
GSC FW is loaded by submitting a dedicated command via the GSC engine. The memory area used for loading the FW is then re-purposed as local memory for the GSC itself, so we use a separate allocation instead of using the one where we keep the firmware stored for reload. The GSC is not reset as

[Intel-gfx] [PATCH 2/6] drm/i915/gsc: Skip the version check when fetching the GSC FW

2022-11-21 Thread Daniele Ceraolo Spurio
The current exectation from the FW side is that the driver will query the GSC FW version after the FW is loaded, similarly to what the mei driver does on DG2. However, we're discussing with the FW team if there is a way to extract the version from the bin file before loading, so we can keep the

[Intel-gfx] [PATCH 1/6] drm/i915/uc: Introduce GSC FW

2022-11-21 Thread Daniele Ceraolo Spurio
On MTL the GSC FW needs to be loaded on the media GT by the graphics driver. We're going to treat it like a new uc_fw, so add the initial defs and init/fini functions for it. Similarly to the other FWs, the GSC FW path can be overriden via modparam. The modparam can also be used to disable the

[Intel-gfx] [PATCH 0/6] drm/i915: Add support for GSC FW loading

2022-11-21 Thread Daniele Ceraolo Spurio
Starting from MTL, the GSC FW is runtime loaded by the driver, instead of being stored in flash memory. Loading the GSC FW is required to allow the media GT to go into its C6 state and for content protection features (PXP, HDCP). The loading happens via a submission to the GSC engine. All

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/dmc: Update DG2 DMC version to v2.08

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Update DG2 DMC version to v2.08 URL : https://patchwork.freedesktop.org/series/64/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool CC [M] drivers/gpu/drm/i915/display/intel_dmc.o

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pxp: Trigger the global teardown for before suspending

2022-11-21 Thread Juston Li
On Mon, 2022-11-21 at 19:21 +, Teres Alexis, Alan Previn wrote: > > > On Mon, 2022-11-21 at 10:39 -0800, Juston Li wrote: > > On Thu, 2022-11-17 at 16:36 -0800, Alan Previn wrote: > > > A driver bug was recently discovered where the security firmware > > > was > > > receiving internal HW

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915/migrate: Account for the reserved_space

2022-11-21 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915/migrate: Account for the reserved_space URL : https://patchwork.freedesktop.org/series/55/ State : warning == Summary == Error: dim checkpatch failed 889967ecb7d7 drm/i915/migrate: Account for the reserved_space -:35:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Fix for KVM refcounting bug

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Fix for KVM refcounting bug URL : https://patchwork.freedesktop.org/series/49/ State : success == Summary == CI Bug Log - changes from CI_DRM_12409 -> Patchwork_49v1 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Update DG2 DMC version to v2.08

2022-11-21 Thread Tolakanahalli Pradeep, Madhumitha
On Mon, 2022-11-21 at 18:18 -0300, Gustavo Sousa wrote: > Release notes: > > 1. Fixes for Register noclaims and few restore. > > Signed-off-by: Gustavo Sousa Reviewed-by: Madhumitha Tolakanahalli Pradeep > --- >  drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++-- >  1 file

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gvt: Fix for KVM refcounting bug

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Fix for KVM refcounting bug URL : https://patchwork.freedesktop.org/series/49/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for

[Intel-gfx] ✗ Fi.CI.BAT: failure for gpu: vgpu: delete a semicolon

2022-11-21 Thread Patchwork
== Series Details == Series: gpu: vgpu: delete a semicolon URL : https://patchwork.freedesktop.org/series/50/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12409 -> Patchwork_50v1 Summary --- **FAILURE**

[Intel-gfx] [PATCH] drm/i915/dmc: Update DG2 DMC version to v2.08

2022-11-21 Thread Gustavo Sousa
Release notes: 1. Fixes for Register noclaims and few restore. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Fix error return code in live_parallel_switch()

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix error return code in live_parallel_switch() URL : https://patchwork.freedesktop.org/series/48/ State : success == Summary == CI Bug Log - changes from CI_DRM_12409 -> Patchwork_48v1

[Intel-gfx] [CI] PR for DG2 DMC v2.08

2022-11-21 Thread Gustavo Sousa
The following changes since commit 391fb47caabaae8719fb72ba4891d1fc27ca1923: amdgpu: update green sardine DMCUB firmware (2022-11-17 10:42:59 -0500) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware dg2_dmc_v2.8 for you to fetch changes up to

Re: [Intel-gfx] [PATCH v10 18/19] drm/vc4: vec: Add support for more analog TV standards

2022-11-21 Thread Mateusz Kwiatkowski
Hi Mauro, As the author of the original version of this commit, and also a person who argued quite a bit on these descriptions and decisions, let me chip in a bit. W dniu 17.11.2022 o 16:49, Mauro Carvalho Chehab pisze: > On Thu, 17 Nov 2022 10:29:01 +0100 > Maxime Ripard wrote: > >> From:

[Intel-gfx] i915 Updates: MTL DMC v2.10

2022-11-21 Thread Tolakanahalli Pradeep, Madhumitha
The following changes since commit daff40492bd0cd071c7f5521b339e12e4de718c1: linux-firmware: update firmware for MT7986 (2022-11-16 08:53:28 -0500) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware mtl_dmc_v2.10 for you to fetch changes up to

Re: [Intel-gfx] [PATCH v3 0/2] Fix live busy stats selftest failure

2022-11-21 Thread Umesh Nerlige Ramappa
Reg: Fi.CI.IGT https://patchwork.freedesktop.org/series/110557/#rev3 shows the below CI failures: igt@i915_module_load@reload-with-fault-injection: shard-snb: PASS -> INCOMPLETE igt@i915_selftest@live@evict: shard-skl: NOTRUN -> INCOMPLETE

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: unpin on error in intel_vgpu_shadow_mm_pin()

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: unpin on error in intel_vgpu_shadow_mm_pin() URL : https://patchwork.freedesktop.org/series/47/ State : success == Summary == CI Bug Log - changes from CI_DRM_12409 -> Patchwork_47v1 Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: unpin on error in intel_vgpu_shadow_mm_pin()

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: unpin on error in intel_vgpu_shadow_mm_pin() URL : https://patchwork.freedesktop.org/series/47/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: unpin on error in intel_vgpu_shadow_mm_pin()

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: unpin on error in intel_vgpu_shadow_mm_pin() URL : https://patchwork.freedesktop.org/series/47/ State : warning == Summary == Error: dim checkpatch failed 3386877e277c drm/i915: unpin on error in intel_vgpu_shadow_mm_pin() -:22:

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pxp: Trigger the global teardown for before suspending

2022-11-21 Thread Teres Alexis, Alan Previn
On Mon, 2022-11-21 at 10:39 -0800, Juston Li wrote: > On Thu, 2022-11-17 at 16:36 -0800, Alan Previn wrote: > > A driver bug was recently discovered where the security firmware was > > receiving internal HW signals indicating that session key expirations > > had occurred. Architecturally, the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Enable SDP split for DP2.0 (rev3)

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Enable SDP split for DP2.0 (rev3) URL : https://patchwork.freedesktop.org/series/109395/ State : success == Summary == CI Bug Log - changes from CI_DRM_12407_full -> Patchwork_109395v3_full Summary

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pxp: Trigger the global teardown for before suspending

2022-11-21 Thread Juston Li
On Thu, 2022-11-17 at 16:36 -0800, Alan Previn wrote: > A driver bug was recently discovered where the security firmware was > receiving internal HW signals indicating that session key expirations > had occurred. Architecturally, the firmware was expecting a response > from the GuC to acknowledge

Re: [Intel-gfx] [PATCH v2 0/5] Add module oriented dmesg output

2022-11-21 Thread John Harrison
On 11/18/2022 02:52, Jani Nikula wrote: On Thu, 17 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-21 Thread Vivi, Rodrigo
On Sat, 2022-11-19 at 09:02 +0530, Nilawar, Badal wrote: > > > On 19-11-2022 00:07, Vivi, Rodrigo wrote: > > On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > > > From: Vinay Belgaumkar > > > > > > By defaut idle messaging is disabled for GSC CS so to unblock RC6 > > > entry on media

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-21 Thread Vivi, Rodrigo
On Fri, 2022-11-18 at 13:37 -0800, Dixit, Ashutosh wrote: > On Fri, 18 Nov 2022 10:37:37 -0800, Vivi, Rodrigo wrote: > > > > On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > > > From: Vinay Belgaumkar > > > > > > By defaut idle messaging is disabled for GSC CS so to unblock RC6 > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix timeout handling when retiring requests (rev3)

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix timeout handling when retiring requests (rev3) URL : https://patchwork.freedesktop.org/series/110964/ State : success == Summary == CI Bug Log - changes from CI_DRM_12407_full -> Patchwork_110964v3_full

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-21 Thread Teres Alexis, Alan Previn
On Mon, 2022-11-21 at 14:06 +, Vivi, Rodrigo wrote: > On Mon, 2022-11-21 at 11:39 +, Tvrtko Ursulin wrote: > > > > On 17/11/2022 22:34, Teres Alexis, Alan Previn wrote: > > > On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote: > > > > On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix negative value passed as remaining time

2022-11-21 Thread Andrzej Hajda
On 21.11.2022 15:56, Janusz Krzysztofik wrote: Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC") extended the API of intel_gt_retire_requests_timeout() with an extra argument 'remaining_timeout', intended for passing back unconsumed portion of requested timeout

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-21 Thread Teres Alexis, Alan Previn
On Mon, 2022-11-21 at 11:39 +, Tvrtko Ursulin wrote: > On 17/11/2022 22:34, Teres Alexis, Alan Previn wrote: > > On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote: > > > On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote: > > > > In preparation for future MTL-PXP feature

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-21 Thread Teres Alexis, Alan Previn
Thank you Jani - this was clearly my mistake (apologies to Daniele/Rodrigo) - didn't realize we had this documented. I will go through that first. ...alan On Mon, 2022-11-21 at 14:12 +0200, Jani Nikula wrote: > On Mon, 21 Nov 2022, Tvrtko Ursulin wrote: > > On 17/11/2022 22:34, Teres Alexis,

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14

2022-11-21 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14 URL : https://patchwork.freedesktop.org/series/36/ State : success == Summary == CI Bug Log - changes from CI_DRM_12407_full -> Patchwork_36v1_full

[Intel-gfx] [PATCH v3 1/2] drm/i915/migrate: Account for the reserved_space

2022-11-21 Thread Matthew Auld
From: Chris Wilson If the ring is nearly full when calling into emit_pte(), we might incorrectly trample the reserved_space when constructing the packet to emit the PTEs. This then triggers the GEM_BUG_ON(rq->reserved_space > ring->space) when later submitting the request, since the request

[Intel-gfx] [PATCH v3 2/2] drm/i915/selftests: exercise emit_pte() with nearly full ring

2022-11-21 Thread Matthew Auld
Simple regression test to check that we don't trample the rq->reserved_space when returning from emit_pte(), if the ring is nearly full. v2: Make spinner_kill() static v3: Reduce the ring size further, which should mean we need to execute less noops; hopefully this appeases bsw. Also add some

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable SDP split for DP2.0 (rev3)

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Enable SDP split for DP2.0 (rev3) URL : https://patchwork.freedesktop.org/series/109395/ State : success == Summary == CI Bug Log - changes from CI_DRM_12407 -> Patchwork_109395v3 Summary ---

[Intel-gfx] [PATCH i-g-t v2] tests/i915/gem_lmem_evict: verify async eviction with madvise

2022-11-21 Thread Matthew Auld
Simple regression test for lmem to check if an in-progress async unbind and eviction is syncronised with discarding the pages when marking the object as DONTNEED. v2: Convert into new test to avoid damaging other test when forcing the lmem_size and unloading the driver. Signed-off-by: Matthew

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix timeout handling when retiring requests (rev3)

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix timeout handling when retiring requests (rev3) URL : https://patchwork.freedesktop.org/series/110964/ State : success == Summary == CI Bug Log - changes from CI_DRM_12407 -> Patchwork_110964v3

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix timeout handling when retiring requests (rev3)

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix timeout handling when retiring requests (rev3) URL : https://patchwork.freedesktop.org/series/110964/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for

[Intel-gfx] [PATCH 1/2] drm/i915/gvt: Get reference to KVM iff attachment to VM is successful

2022-11-21 Thread Sean Christopherson
Get a reference to KVM if and only if a vGPU is successfully attached to the VM to avoid leaking a reference if there's no available vGPU. On open_device() failure, vfio_device_open() doesn't invoke close_device(). Fixes: 421cfe6596f6 ("vfio: remove VFIO_GROUP_NOTIFY_SET_KVM") Cc:

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/gvt: switch from track_flush_slot to track_remove_slot

2022-11-21 Thread Sean Christopherson
On Fri, Nov 11, 2022, Yan Zhao wrote: > KVMGT only cares about when a slot is indeed removed. > So switch to use track_remove_slot which is called when a slot is removed. This should capture the original motivation, i.e. that the existing ->track_flush_slot() hook is theoretically flawed. I

[Intel-gfx] [PATCH] gpu: vgpu: delete a semicolon

2022-11-21 Thread Li kunyu
Remove extra semicolons at the end of statements to make them look cleaner. Signed-off-by: Li kunyu --- drivers/gpu/drm/i915/gvt/vgpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c index

Re: [Intel-gfx] [Nouveau] [PATCH v7 00/23] drm: Analog TV Improvements

2022-11-21 Thread Lukas Satin
One can switch from NTSC to PAL now using (on vc4) modetest -M vc4 -s 53:720x480i -w 53:'TV mode':1 # NTSC modetest -M vc4 -s 53:720x576i -w 53:'TV mode':4 # PAL NTSC should be 640x480i, not 720. It will probably work on most TV's, but NTSC by the spec is 640x480i. On Mon, Nov 7, 2022 at

Re: [Intel-gfx] [Nouveau] [PATCH v7 06/23] drm/modes: Add a function to generate analog display modes

2022-11-21 Thread Lukas Satin
Hi, your statement: "However, analog display usually have fairly loose timings requirements, the only discrete parameters being the total number of lines and pixel clock frequency." Please do not make it as a rule. You said yourself: "usually". Arcade CRT have more loose timings, but

[Intel-gfx] [PATCH 2/2] drm/i915/gvt: Unconditionally put reference to KVM when detaching vGPU

2022-11-21 Thread Sean Christopherson
Always put the KVM reference when closing a vCPU device, as intel_vgpu_open_device() succeeds if and only if the KVM pointer is valid and a reference to KVM is acquired. And if that doesn't hold true, the call to kvm_page_track_unregister_notifier() a few lines earlier is doomed. Signed-off-by:

[Intel-gfx] [PATCH] drm/i915/selftests: Fix error return code in live_parallel_switch()

2022-11-21 Thread Ziyang Xuan
In live_parallel_switch(), excute intel_context_create() failed, the error code should be set before return from error handling path. Fixes: 50d16d44cce4 ("drm/i915/selftests: Exercise context switching in parallel") Signed-off-by: Ziyang Xuan ---

Re: [Intel-gfx] Nested AVIC design (was:Re: [RFC PATCH v3 04/19] KVM: x86: mmu: allow to enable write tracking externally)

2022-11-21 Thread Sean Christopherson
Sorry for the super slow reply, I don't have a good excuse other than I needed to take break from AVIC code... On Mon, Oct 03, 2022, Maxim Levitsky wrote: > On Thu, 2022-09-29 at 22:38 +, Sean Christopherson wrote: > > On Mon, Aug 08, 2022, Maxim Levitsky wrote: > > > Hi Sean, Paolo, and

[Intel-gfx] [PATCH 0/2] drm/i915/gvt: Fix for KVM refcounting bug

2022-11-21 Thread Sean Christopherson
Bug fix and cleanup related to KVM refcounting. Found by inspection while attempting to clean up KVM's page-tracker APIs. Compile tested only! Sean Christopherson (2): drm/i915/gvt: Get reference to KVM iff attachment to VM is successful drm/i915/gvt: Unconditionally put reference to KVM

Re: [Intel-gfx] KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-21 Thread David Gow
On Thu, Nov 3, 2022 at 11:23 PM Mauro Carvalho Chehab wrote: > > Hi, > > I'm facing a couple of issues when testing KUnit with the i915 driver. > > The DRM subsystem and the i915 driver has, for a long time, his own > way to do unit tests, which seems to be added before KUnit. > > I'm now

Re: [Intel-gfx] [PATCH v2 1/3] KVM: x86: add a new page track hook track_remove_slot

2022-11-21 Thread Sean Christopherson
On Sat, Nov 12, 2022, Yan Zhao wrote: > And I'm also not sure if a slots_arch_lock is required for > kvm_slot_page_track_add_page() and kvm_slot_page_track_remove_page(). It's not required. slots_arch_lock protects interaction between memslot updates mmu_first_shadow_root_alloc(). When

Re: [Intel-gfx] [PATCH v2 1/3] KVM: x86: add a new page track hook track_remove_slot

2022-11-21 Thread Sean Christopherson
On Tue, Nov 15, 2022, Yan Zhao wrote: > On Mon, Nov 14, 2022 at 04:32:34PM +, Sean Christopherson wrote: > > On Mon, Nov 14, 2022, Yan Zhao wrote: > > > On Sat, Nov 12, 2022 at 12:43:07AM +, Sean Christopherson wrote: > > > > On Sat, Nov 12, 2022, Yan Zhao wrote: > > > > > And I'm also not

Re: [Intel-gfx] [Nouveau] [PATCH v7 22/23] drm/vc4: vec: Add support for more analog TV standards

2022-11-21 Thread Lukas Satin
They are important for retrogaming and connecting TV out to CRT TV or using emulator. I have PS1 that is using PAL-60 for example. Can you add 240p and 288p non-interlaced modes for NTSC and PAL, please? Lukas On Mon, Nov 7, 2022 at 3:19 PM Maxime Ripard wrote: > From: Mateusz Kwiatkowski >

Re: [Intel-gfx] [PATCH 26/26] drm/i915/gt: Remove #ifdef guards for PM related functions

2022-11-21 Thread Paul Cercueil
Hi Rodrigo, Le lun. 7 nov. 2022 à 15:31:49 -0500, Rodrigo Vivi a écrit : On Mon, Nov 07, 2022 at 05:55:10PM +, Paul Cercueil wrote: Instead of defining two versions of intel_sysfs_rc6_init(), one for each value of CONFIG_PM, add a check on !IS_ENABLED(CONFIG_PM) early in the

Re: [Intel-gfx] [Nouveau] [PATCH v7 22/23] drm/vc4: vec: Add support for more analog TV standards

2022-11-21 Thread Lukas Satin
That's great, I will test it on Ubuntu + Nouveau x86_64 and Batocera-Linux. I'm not interested in Raspberry Pi. I see you have some commit in RaspberryPi/Linux. Will this go to some Nouveau driver, so I can test it on x86_64 machine? I have some basic experience compiling Linux kernel (nvidia

[Intel-gfx] [PATCH] drm/i915: unpin on error in intel_vgpu_shadow_mm_pin()

2022-11-21 Thread Dan Carpenter
Call intel_vgpu_unpin_mm() on this error path. Fixes: 418741480809 ("drm/i915/gvt: Adding ppgtt to GVT GEM context after shadow pdps settled.") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/gvt/scheduler.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Intel-gfx] [PATCH v2 1/3] KVM: x86: add a new page track hook track_remove_slot

2022-11-21 Thread Sean Christopherson
TL;DR: I'm going to try to add more aggressive patches for this into my series to clean up the KVM side of things, along with many more patches to clean up the page track APIs. I'll post patches next week if things go well (fingers crossed), and if not I'll give an update On Fri, Nov 11,

Re: [Intel-gfx] [PATCH v2 1/3] KVM: x86: add a new page track hook track_remove_slot

2022-11-21 Thread Sean Christopherson
On Mon, Nov 14, 2022, Yan Zhao wrote: > On Sat, Nov 12, 2022 at 12:43:07AM +, Sean Christopherson wrote: > > On Sat, Nov 12, 2022, Yan Zhao wrote: > > > And I'm also not sure if a slots_arch_lock is required for > > > kvm_slot_page_track_add_page() and kvm_slot_page_track_remove_page(). > > >

Re: [Intel-gfx] [PATCH v2 1/3] KVM: x86: add a new page track hook track_remove_slot

2022-11-21 Thread Sean Christopherson
On Tue, Nov 15, 2022, Yan Zhao wrote: > On Mon, Nov 14, 2022 at 11:24:16PM +, Sean Christopherson wrote: > > On Tue, Nov 15, 2022, Yan Zhao wrote: > > > On Mon, Nov 14, 2022 at 04:32:34PM +, Sean Christopherson wrote: > > > > On Mon, Nov 14, 2022, Yan Zhao wrote: > > > > > On Sat, Nov 12,

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915: Export LMEM max memory bandwidth via sysfs

2022-11-21 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915: Export LMEM max memory bandwidth via sysfs URL : https://patchwork.freedesktop.org/series/31/ State : success == Summary == CI Bug Log - changes from CI_DRM_12407_full -> Patchwork_31v1_full

Re: [Intel-gfx] [PATCH v2] drm/i915: Enable SDP split for DP2.0

2022-11-21 Thread Govindapillai, Vinod
Thanks Jani. I updated the patch. Could you please push to the drm-tip. Thanks Vinod On Mon, 2022-11-21 at 15:15 +0200, Jani Nikula wrote: > On Tue, 01 Nov 2022, Vinod Govindapillai > wrote: > > Enable the SDP split configuration for DP2.0. > > > > v2: Move the register handling out of

[Intel-gfx] [PATCH v3] drm/i915: Enable SDP split for DP2.0

2022-11-21 Thread Vinod Govindapillai
Enable the SDP split configuration for DP2.0. v2: Move the register handling out of compute config function (JaniN) v3: Patch styling and register access based on platform support (JaniN) v4: Rebased v5: Use unconditional clear bit in intel_de_rmw (Jani Nikula) Bspec: 67768 Signed-off-by:

[Intel-gfx] [PATCH v3 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-21 Thread Janusz Krzysztofik
Users of intel_gt_retire_requests_timeout() expect 0 return value on success. However, we have no protection from passing back 0 potentially returned by a call to dma_fence_wait_timeout() when it succedes right after its timeout has expired. Replace 0 with -ETIME before potentially using the

[Intel-gfx] [PATCH v3 0/2] drm/i915: Fix timeout handling when retiring requests

2022-11-21 Thread Janusz Krzysztofik
Fixes for issues discovered via code review while working on https://gitlab.freedesktop.org/drm/intel/issues/7349. v3: PATCH 1: don't fail on any error passed back via remaining_timeout, PATCH 2: use conditional expression, more compact but also better reflecting intention standing

[Intel-gfx] [PATCH v3 1/2] drm/i915: Fix negative value passed as remaining time

2022-11-21 Thread Janusz Krzysztofik
Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC") extended the API of intel_gt_retire_requests_timeout() with an extra argument 'remaining_timeout', intended for passing back unconsumed portion of requested timeout when 0 (success) is returned. However, when

Re: [Intel-gfx] [PATCH v10 00/19] drm: Analog TV Improvements

2022-11-21 Thread Daniel Vetter
On Thu, Nov 17, 2022 at 10:28:43AM +0100, Maxime Ripard wrote: > Hi, > > Here's a series aiming at improving the command line named modes support, > and more importantly how we deal with all the analog TV variants. > > The named modes support were initially introduced to allow to specify the >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gsc: Only initialize GSC in tile 0 (rev2)

2022-11-21 Thread Patchwork
== Series Details == Series: drm/i915/gsc: Only initialize GSC in tile 0 (rev2) URL : https://patchwork.freedesktop.org/series/110304/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12407_full -> Patchwork_110304v2_full

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-21 Thread Vivi, Rodrigo
On Mon, 2022-11-21 at 11:39 +, Tvrtko Ursulin wrote: > > On 17/11/2022 22:34, Teres Alexis, Alan Previn wrote: > > On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote: > > > On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote: > > > > In preparation for future MTL-PXP feature

  1   2   >