> -Original Message-
> From: Intel-gfx On Behalf Of Lucas
> De Marchi
> Sent: Friday, January 20, 2023 11:35 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: De Marchi, Lucas ; dri-
> de...@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH v2 1/8] drm/i915: Add _PICK_EVEN_2RANGES()
>
> -Original Message-
> From: Intel-gfx On Behalf Of Lucas
> De Marchi
> Sent: Friday, January 20, 2023 11:35 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: De Marchi, Lucas ; dri-
> de...@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH v2 8/8] drm/i915: Convert PALETTE() to
>
> -Original Message-
> From: Intel-gfx On Behalf Of Lucas
> De Marchi
> Sent: Friday, January 20, 2023 11:35 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: De Marchi, Lucas ; dri-
> de...@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH v2 7/8] drm/i915: Convert MBUS_ABOX_CTL() to
>
> -Original Message-
> From: Intel-gfx On Behalf Of Lucas
> De Marchi
> Sent: Friday, January 20, 2023 11:35 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: De Marchi, Lucas ; dri-
> de...@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH v2 6/8] drm/i915: Convert _FIA() to
>
> -Original Message-
> From: Intel-gfx On Behalf Of Lucas
> De Marchi
> Sent: Friday, January 20, 2023 11:35 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: De Marchi, Lucas ; dri-
> de...@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH v2 5/8] drm/i915: Convert PIPE3/PORT3 to
>
Verified that the new macro evaluates to the right register offsets.
Reviewed-by: Anusha Srivatsa
> -Original Message-
> From: Intel-gfx On Behalf Of Lucas
> De Marchi
> Sent: Friday, January 20, 2023 11:35 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: De Marchi, Lucas ; dri-
>
On Fri, 2023-01-20 at 23:46 +, Teres Alexis, Alan Previn wrote:
> Thanks for the review comment...
>
Replying here with the summary of our offline chat:
So we concluded that for the next rev, lets move the
buffer/vma allocations from patch #2 into this patch
#5-send-message. But for now we
== Series Details ==
Series: Allow error capture without a request & fix locking issues (rev2)
URL : https://patchwork.freedesktop.org/series/113078/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12619 -> Patchwork_113078v2
Thanks for the review comment...
On Wed, 2023-01-18 at 17:40 -0800, Ceraolo Spurio, Daniele wrote:
>
>
> On 1/11/2023 1:42 PM, Alan Previn wrote:
> > Add GSC engine based method for sending PXP firmware packets
> > to the GSC firmware for MTL (and future) products. Use the newly
> > added
On 1/20/2023 15:28, john.c.harri...@intel.com wrote:
From: John Harrison
The debugfs dump of requests was confused about what state requires
the execlist lock versus the GuC lock. There was also a bunch of
duplicated messy code between it and the error capture code.
So refactor the hung
From: John Harrison
Engine resets are supposed to never fail. But in the case when one
does (due to unknown reasons that normally come down to a missing
w/a), it is useful to get as much information out of the system as
possible. Given that the GuC intentionally dies on such a situation,
it is
From: John Harrison
For understanding bug reports, it can be useful to have an explicit
dmesg print when a reset notification is received from GuC. As opposed
to simply inferring that this happened from other messages.
Signed-off-by: John Harrison
Reviewed-by: Tvrtko Ursulin
---
From: John Harrison
When GuC support was added to error capture, the locking around the
request object was broken. Fix it up.
The context based search manages the spinlocking around the search
internally. So it needs to grab the reference count internally as
well. The execlist only request
From: John Harrison
There was a report of error captures occurring without any hung
context being indicated despite the capture being initiated by a 'hung
context notification' from GuC. The problem was not reproducible.
However, it is possible to happen if the context in question has no
active
From: John Harrison
The GuC specific register state entry in the error capture object was
just called 'capture'. Although the companion 'node' entry was called
'guc_capture_node'. Rename the base entry to be 'guc_capture' instead
so that it is a) more consistent and b) more obvious what it is.
From: John Harrison
A hang situation has been observed where the only requests on the
context were either completed or not yet started according to the
breaadcrumbs. However, the register state claimed a batch was (maybe)
in progress. So, allow capture of the pending request on the grounds
that
From: John Harrison
It is technically possible to get a hung context without a valid
request. In such a situation, try to provide as much information in
the error capture as possible rather than just aborting and capturing
nothing.
Similarly, in the case of an engine reset failure the GuC is
From: John Harrison
The debugfs dump of requests was confused about what state requires
the execlist lock versus the GuC lock. There was also a bunch of
duplicated messy code between it and the error capture code.
So refactor the hung request search into a re-usable function. And
reduce the
== Series Details ==
Series: Add DSC fractional bpp support (rev3)
URL : https://patchwork.freedesktop.org/series/111391/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12615_full -> Patchwork_111391v3_full
Summary
---
On 1/19/2023 07:16, Andy Shevchenko wrote:
On Wed, Jan 18, 2023 at 10:49:55PM -0800, john.c.harri...@intel.com wrote:
From: John Harrison
When GuC support was added to error capture, the locking around the
request object was broken. Fix it up.
The context based search manages the spinlocking
== Series Details ==
Series: series starting with [1/2] drm/i915/mtl: Add workarounds
Wa_14017066071, Wa_14017654203
URL : https://patchwork.freedesktop.org/series/113127/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12614_full -> Patchwork_113127v1_full
On Thu, Jan 19, 2023 at 03:03:30PM -0800, Matt Roper wrote:
On Thu, Jan 19, 2023 at 02:28:13PM -0800, Vivi, Rodrigo wrote:
On Thu, 2023-01-19 at 19:24 -0300, Gustavo Sousa wrote:
> On Thu, Jan 19, 2023 at 04:57:09PM -0500, Rodrigo Vivi wrote:
> > On Wed, Jan 18, 2023 at 12:52:49PM -0300,
== Series Details ==
Series: series starting with [1/1] drm/i915/gsc: Fix the Driver-FLR completion
URL : https://patchwork.freedesktop.org/series/113112/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12613_full -> Patchwork_113112v1_full
== Series Details ==
Series: drm/i915: Avoid potential vm use-after-free
URL : https://patchwork.freedesktop.org/series/113105/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12613_full -> Patchwork_113105v1_full
Summary
== Series Details ==
Series: drm/edid: info & modes parsing and drm_edid refactors (rev3)
URL : https://patchwork.freedesktop.org/series/112392/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12613_full -> Patchwork_112392v3_full
On Fri, Jan 20, 2023 at 05:53:50PM -0300, Gustavo Sousa wrote:
> On Tue, Jan 03, 2023 at 11:01:55AM -0500, Rodrigo Vivi wrote:
> > On Mon, Jan 02, 2023 at 08:33:24PM +0200, Imre Deak wrote:
> > > Make sure that PIPEDMCs are enabled whenever the corresponding pipe is
> > > enabled.
> > >
> > >
== Series Details ==
Series: Add _PICK_EVEN_2RANGES
URL : https://patchwork.freedesktop.org/series/113177/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12618 -> Patchwork_113177v1
Summary
---
**SUCCESS**
No
== Series Details ==
Series: Add _PICK_EVEN_2RANGES
URL : https://patchwork.freedesktop.org/series/113177/
State : warning
== Summary ==
Error: dim checkpatch failed
1158a61386b5 drm/i915: Add _PICK_EVEN_2RANGES()
-:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__index' - possible
On Wed, 2023-01-18 at 17:28 -0800, Ceraolo Spurio, Daniele wrote:
> >
> >
> > On 1/11/2023 1:42 PM, Alan Previn wrote:
> > > > Add helper functions into (new) common heci-packet-submission files
> > > > to handle generating the MTL GSC-CS Memory-Header and emitting of
> > > > the Heci-Cmd-Packet
On Tue, Jan 03, 2023 at 11:01:55AM -0500, Rodrigo Vivi wrote:
> On Mon, Jan 02, 2023 at 08:33:24PM +0200, Imre Deak wrote:
> > Make sure that PIPEDMCs are enabled whenever the corresponding pipe is
> > enabled.
> >
> > This is required at least by the latest ADLP v2.18 firmware, which adds
> > a
== Series Details ==
Series: drm/i915: Use uabi engines for the default engine map (rev2)
URL : https://patchwork.freedesktop.org/series/68395/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12618 -> Patchwork_68395v2
Thanks for reviewing.
On Wed, 2023-01-18 at 16:09 -0800, Ceraolo Spurio, Daniele wrote:
> >
> >
Alan: [snip]
> > > > -/* KCR register definitions */
> > > > -#define KCR_INIT _MMIO(0x320f0)
> > > > -/* Setting KCR Init bit is required after system boot */
> > > > -#define
Thanks for reviewing, Daniele. Responses are inline below.
On Wed, 2023-01-18 at 15:55 -0800, Ceraolo Spurio, Daniele wrote:
> >
> >
> > On 1/11/2023 1:42 PM, Alan Previn wrote:
> > > > For MTL, PXP transport back-end uses the GSC engine to submit
> > > > HECI packets for PXP arb session
On 20 January 2023 18:32:47 GMT+03:00, Sean Paul wrote:
>On Thu, Jan 19, 2023 at 11:37:52AM +0100, Krzysztof Kozlowski wrote:
>> On 18/01/2023 20:30, Mark Yacoub wrote:
>> > From: Sean Paul
>> >
>> > This patch moves the hdcp atomic check from i915 to drm_hdcp so other
>> > drivers can use
== Series Details ==
Series: drm/i915/gt: Convert PSS_MODE2 to multicast register (rev2)
URL : https://patchwork.freedesktop.org/series/113159/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12618 -> Patchwork_113159v2
Changes look good.
Reviewed-by: Anusha Srivatsa
> -Original Message-
> From: Intel-gfx On Behalf Of Lucas
> De Marchi
> Sent: Friday, January 20, 2023 11:35 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: De Marchi, Lucas ; dri-
> de...@lists.freedesktop.org
> Subject: [Intel-gfx]
== Series Details ==
Series: GuC oriented print macros
URL : https://patchwork.freedesktop.org/series/113162/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12618 -> Patchwork_113162v1
Summary
---
**SUCCESS**
No
Hi Michal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
url:
https://github.com/intel-lab-lkp/linux/commits/Michal-Wajdeczko/drm-i915-guc-Add-GuC-oriented-print-macros/20230121-004232
base: git://anongit.freedesktop.org/drm/drm-tip
== Series Details ==
Series: GuC oriented print macros
URL : https://patchwork.freedesktop.org/series/113162/
State : warning
== Summary ==
Error: dim checkpatch failed
b54a9b032bdb drm/i915/guc: Add GuC oriented print macros
Traceback (most recent call last):
File "scripts/spdxcheck.py",
_FIA() can use _PICK_EVEN_2RANGES instead of _PICK, which reduces the
size and is safer.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/display/intel_mg_phy_regs.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_mg_phy_regs.h
PALETTE() can use _PICK_EVEN_2RANGES instead of _PICK, which
reduces the size and is safer.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/i915_reg.h | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h
MBUS_ABOX_CTL() can use _PICK_EVEN_2RANGES instead of _PICK, which
reduces the size and is safer.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/i915_reg.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h
As done previously for pll, also convert users of _PHY3() to
_PICK_EVEN_2RANGES(). Size comparison of i915.o:
$ size build64/drivers/gpu/drm/i915/i915.o{.old,.new}
textdata bss dec hex filename
4026997 1857036984 4219684 406324
Abide by the rules in the top of the header: 2 spaces for bitfield,
prefix offsets with underscore and prefer the use of REG_BIT().
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/i915_reg.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
It's a constant pattern in the driver to need to use 2 ranges of MMIOs
based on port, phy, pll, etc. When that happens, instead of using
_PICK_EVEN(), _PICK() needs to be used. Using _PICK() is discouraged
due to some reasons like:
1) It increases the code size since the array is declared
in
Like done for when __var_args__ were used, but size-wise it's also
benefitial to avoid _PICK() used for 3 ports/pipes:
$ size build64/drivers/gpu/drm/i915/i915.o{.old,.new}
textdata bss dec hex filename
4026288 1857036984 4218975 40605f
Avoid the array lookup, converting the PLL macros after ICL to
_PICK_EVEN_RANGES. This provides the following reduction in code size:
$ size build64/drivers/gpu/drm/i915/i915.o{.old,.new}
textdata bss dec hex filename
4027456 1857036984 4220143
Add a new macro, _PICK_EVEN_2RANGES, that supports using 2 address
ranges. This can be considered a v2 of
https://patchwork.freedesktop.org/series/109606/
I think I converted all the _PICK() uses that could be easily done
without making it much harder to read. We do have some cases of 3
ranges: I
== Series Details ==
Series: kvm/vfio: Fix potential deadlock on vfio group_lock
URL : https://patchwork.freedesktop.org/series/113156/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12618 -> Patchwork_113156v1
Summary
From: Tvrtko Ursulin
Default engine map is exactly about uabi engines so no excuse not to use
the appropriate iterator to populate it.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
On Thu, Jan 19, 2023 at 06:19:01PM +0200, Jani Nikula wrote:
> It's a bit confusing to have two cached EDIDs in struct intel_connector
> with slightly different purposes. Make the distinction a bit clearer by
> moving the EDID cached for eDP and LVDS panels at connector init time to
> struct
On Thu, Jan 19, 2023 at 06:19:00PM +0200, Jani Nikula wrote:
> Simplify validation and use by converting to drm_edid.
>
> Cc: Ville Syrjälä
> Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 10 ++-
>
On Thu, Jan 19, 2023 at 06:18:59PM +0200, Jani Nikula wrote:
> Try to use struct drm_edid where possible, even if having to fall back
> to looking into struct edid down low via drm_edid_raw().
>
> v2: Rebase
>
> Cc: Ville Syrjälä
> Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
> ---
On Thu, Jan 19, 2023 at 06:18:58PM +0200, Jani Nikula wrote:
> Convert all the connectors that use cached connector edid and
> detect_edid to drm_edid.
>
> Since drm_get_edid() calls drm_connector_update_edid_property() while
> drm_edid_read*() do not, we need to call drm_edid_connector_update()
On Fri, Jan 20, 2023 at 08:13:16AM -0800, Matt Roper wrote:
> On Fri, Jan 20, 2023 at 01:06:15PM -0300, Gustavo Sousa wrote:
> > That register became a multicast register as of Xe_HP and it is
> > currently used only for DG2. Use a proper prefix since there could be
> > usage of the same register
That register became a multicast register as of Xe_HP and it is
currently used only for DG2. Use a proper prefix since there could be
usage of the same register for previous platforms in the future, which
would require a different definition (i.e. using _MMIO).
Note that, in its current state,
On Fri, 20 Jan 2023 07:05:28 -0800
Yi Liu wrote:
> Currently it is possible that the final put of a KVM reference comes from
> vfio during its device close operation. This occurs while the vfio group
> lock is held; however, if the vfio device is still in the kvm device list,
> then the
On 1/20/2023 09:36, John Harrison wrote:
On 1/19/2023 17:54, Ceraolo Spurio, Daniele wrote:
On 1/18/2023 10:49 PM, john.c.harri...@intel.com wrote:
From: John Harrison
There was a report of error captures occurring without any hung
context being indicated despite the capture being initiated
On 1/19/2023 17:54, Ceraolo Spurio, Daniele wrote:
On 1/18/2023 10:49 PM, john.c.harri...@intel.com wrote:
From: John Harrison
There was a report of error captures occurring without any hung
context being indicated despite the capture being initiated by a 'hung
context notification' from GuC.
On Wed, Dec 21, 2022 at 05:38:16PM +0200, Jouni Högander wrote:
> After splitting generic drm_fb_helper into it's own file it's left to
> helper implementation to have fb_dirty function. Currently intel
> fbdev doesn't have it. This is causing problems to features (PSR, FBC,
> DRRS) relying on
Thanks for reviewing - sounds good - will fix those comments up as per your
recommendation.
On Fri, 2023-01-20 at 11:14 +0200, Jani Nikula wrote:
> On Thu, 19 Jan 2023, Alan Previn wrote:
> > The Driver-FLR flow may inadvertently exit early before the full
> > completion of the re-init of the
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 60 ---
1 file changed, 26 insertions(+), 34 deletions(-)
diff --git
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 31 +-
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 35 +++---
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 74 +--
1 file changed, 36 insertions(+), 38 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
While we do have GT oriented print macros, add few more GuC
specific to have common look and feel across all messages
related to the GuC and to avoid chasing the gt pointer.
We will use these macros shortly in upcoming patches.
Signed-off-by: Michal Wajdeczko
Cc: Tvrtko Ursulin
Cc: John
This is a follow up series for existing commit 67804e48b494
("drm/i915/gt: Start adding module oriented dmesg output")
that was focusing just on the GT.
Now extend changes to uc/ folder and focus on the GuC.
Cc: Tvrtko Ursulin
Cc: John Harrison
Michal Wajdeczko (8):
drm/i915/guc: Add GuC
On Fri, 2023-01-20 at 08:27 +, Gupta, Anshuman wrote:
>
>
> > -Original Message-
> > From: Intel-gfx On Behalf Of Alan
> > Previn
> > Sent: Friday, January 20, 2023 1:20 AM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: v...@freedesktop.org; dri-de...@lists.freedesktop.org; Teres
Hi Dmitry,
Thank you for the patch.
On Wed, Jan 18, 2023 at 01:39:05AM +0200, Dmitry Baryshkov wrote:
> There are two flags attemting to guard connector polling:
> poll_enabled and poll_running. While poll_enabled semantics is clearly
> defined and fully adhered (mark that
On Fri, Jan 20, 2023 at 01:06:15PM -0300, Gustavo Sousa wrote:
> That register became a multicast register as of Xe_HP and it is
> currently used only for DG2. Use a proper prefix since there could be
> usage of the same register for previous platforms in the future, which
> would require a
That register became a multicast register as of Xe_HP and it is
currently used only for DG2. Use a proper prefix since there could be
usage of the same register for previous platforms in the future, which
would require a different definition (i.e. using _MMIO).
Signed-off-by: Gustavo Sousa
Cc:
On Thu, Jan 19, 2023 at 11:35:32AM +0100, Krzysztof Kozlowski wrote:
> On 18/01/2023 20:30, Mark Yacoub wrote:
> > From: Sean Paul
> >
> > This patch adds the register ranges required for HDCP key injection and
>
> Do not use "This commit/patch".
>
On Fri, 20 Jan 2023 10:45:40 -0500
Matthew Rosato wrote:
> On 1/20/23 10:08 AM, Liu, Yi L wrote:
> >> From: Liu, Yi L
> >> Sent: Friday, January 20, 2023 11:05 PM
> >>
> >> Currently it is possible that the final put of a KVM reference comes from
> >> vfio during its device close operation.
On 1/20/23 10:08 AM, Liu, Yi L wrote:
>> From: Liu, Yi L
>> Sent: Friday, January 20, 2023 11:05 PM
>>
>> Currently it is possible that the final put of a KVM reference comes from
>> vfio during its device close operation. This occurs while the vfio group
>> lock is held; however, if the vfio
On Thu, Jan 19, 2023 at 11:37:52AM +0100, Krzysztof Kozlowski wrote:
> On 18/01/2023 20:30, Mark Yacoub wrote:
> > From: Sean Paul
> >
> > This patch moves the hdcp atomic check from i915 to drm_hdcp so other
> > drivers can use it. No functional changes, just cleaned up some of the
> > code
== Series Details ==
Series: drm/i915/debugfs: Get rid of single use macros.
URL : https://patchwork.freedesktop.org/series/113147/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12617 -> Patchwork_113147v1
Summary
---
> From: Liu, Yi L
> Sent: Friday, January 20, 2023 11:05 PM
>
> Currently it is possible that the final put of a KVM reference comes from
> vfio during its device close operation. This occurs while the vfio group
> lock is held; however, if the vfio device is still in the kvm device list,
>
Currently it is possible that the final put of a KVM reference comes from
vfio during its device close operation. This occurs while the vfio group
lock is held; however, if the vfio device is still in the kvm device list,
then the following call chain could result in a deadlock:
VFIO holds
Hi Tvrtko,
On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Avoid trying to dereference null engines on exit when there are either
none which are supported, or kernel does not have i915 PMU support.
Signed-off-by: Tvrtko Ursulin
---
tools/intel_gpu_top.c | 10 +++---
== Series Details ==
Series: drm/i915/display: Pass drm_i915_private as param to i915 funcs
URL : https://patchwork.freedesktop.org/series/113083/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12610_full -> Patchwork_113083v1_full
On Fri, Jan 20, 2023 at 06:06:58AM -0500, Rodrigo Vivi wrote:
> No good reason for these indirection cases.
Agree! One time use definitions should be avoided, they just add
complexity.
> Cc: Jani Nikula
> Signed-off-by: Rodrigo Vivi
Reviewed-by: Andi Shyti
Thanks
Andi
> ---
>
Hi Arnd,
On Tue, Jan 17, 2023 at 05:37:29PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The definition of intel_selftest_modify_policy() does not match the
> declaration, as gcc-13 points out:
>
> drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c:29:5: error:
> conflicting
On Wed, 18 Jan 2023 at 21:30, Mark Yacoub wrote:
>
> From: Sean Paul
>
> This patch adds the register ranges required for HDCP key injection and
> HDCP TrustZone interaction as described in the dt-bindings for the
> sc7180 dp controller. Now that these are supported, change the
> compatible
On 18/01/2023 21:30, Mark Yacoub wrote:
From: Sean Paul
This patch adds HDCP 1.x support to msm DP connectors using the new HDCP
helpers.
Cc: Stephen Boyd
Cc: Abhinav Kumar
Reviewed-by: Stephen Boyd
Signed-off-by: Sean Paul
Signed-off-by: Mark Yacoub
Link:
On 18/01/2023 21:30, Mark Yacoub wrote:
From: Sean Paul
This patch moves the hdcp atomic check from i915 to drm_hdcp so other
drivers can use it. No functional changes, just cleaned up some of the
code when moving it over.
Acked-by: Jani Nikula
Acked-by: Jani Nikula
Reviewed-by: Rodrigo
On 18/01/2023 21:30, Mark Yacoub wrote:
From: Sean Paul
Instead of forcing a modeset in the hdcp atomic check, simply return
true if the content protection value is changing and let the driver
decide whether a modeset is required or not.
I don't think this is a good idea. All
On Wed, 18 Jan 2023 at 21:30, Mark Yacoub wrote:
>
> From: Sean Paul
>
> This patch adds the bindings for the MSM DisplayPort HDCP registers
> which are required to write the HDCP key into the display controller as
> well as the registers to enable HDCP authentication/key
> exchange/encryption.
On 18/01/2023 21:30, Mark Yacoub wrote:
From: Sean Paul
This patch expands upon the HDCP helper library to manage HDCP
enable, disable, and check.
Previous to this patch, the majority of the state management and sink
interaction is tucked inside the Intel driver with the understanding
that
No good reason for these indirection cases.
Cc: Jani Nikula
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_debugfs.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
index
Hi,
Patch looks good. But I see there are few formatting issues and places
where documentation is still mentions MEI FW, I have mentioned the same
inline.
With that fixed:
Reviewed-by: Ankit Nautiyal
On 1/10/2023 4:27 PM, Suraj Kandpal wrote:
From: Anshuman Gupta
Change the
On Thu, Jan 19, 2023 at 05:06:39PM -0800, Radhakrishna Sripada wrote:
> This patch adds the workaround to disable IC prefetch.
>
> Original Author: Madhumitha Tolakanhalli Pradeep
ditto
> Signed-off-by: Radhakrishna Sripada
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 4
> 1
On Thu, Jan 19, 2023 at 05:06:38PM -0800, Radhakrishna Sripada wrote:
> This patch add the workaround to disable Sampler-OOO to avoid hang
> during a benchmark.
>
> Original Author: Madhumitha Tolakanhalli Pradeep
This is not how we handle this. We keep her original authorship email
and
== Series Details ==
Series: drm: override detected status for connectors which are forced on
URL : https://patchwork.freedesktop.org/series/113142/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12616 -> Patchwork_113142v1
On Wed, Jan 18, 2023 at 03:15:37PM +0200, Jani Nikula wrote:
> Declutter i915_drv.h.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 --
> drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
On Wed, Jan 18, 2023 at 03:15:36PM +0200, Jani Nikula wrote:
> Declutter i915_drv.h.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_drv.h | 7 ---
> drivers/gpu/drm/i915/i915_gem.h | 7 +++
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git
On Fri, 20 Jan 2023, Rodrigo Vivi wrote:
> On Wed, Jan 18, 2023 at 03:15:33PM +0200, Jani Nikula wrote:
>> Declutter i915_drv.h. If there's ever a need to use this in more than
>> one place, we can figure out a better spot then. For now, this seems
>> easiest.
>
> why don't we get rid of the
On Wed, Jan 18, 2023 at 03:15:35PM +0200, Jani Nikula wrote:
> There's not that much organization with where the various HAS_FEATURE()
> macros are placed, but at least try to group them closer together.
yeap
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
>
1 - 100 of 107 matches
Mail list logo
