i915: Convert _FIA() to _PICK_EVEN_2RANGES()

Srivatsa, Anusha Fri, 20 Jan 2023 22:01:49 -0800


> -----Original Message-----
> From: Intel-gfx <[email protected]> On Behalf Of Lucas
> De Marchi
> Sent: Friday, January 20, 2023 11:35 AM
> To: [email protected]
> Cc: De Marchi, Lucas <[email protected]>; dri-
> [email protected]
> Subject: [Intel-gfx] [PATCH v2 6/8] drm/i915: Convert _FIA() to
> _PICK_EVEN_2RANGES()
> 
> _FIA() can use _PICK_EVEN_2RANGES instead of _PICK, which reduces the size
> and is safer.
> 
> Signed-off-by: Lucas De Marchi <[email protected]>
Reviewed-by: Anusha Srivatsa <[email protected]>


> ---
>  drivers/gpu/drm/i915/display/intel_mg_phy_regs.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_mg_phy_regs.h
> b/drivers/gpu/drm/i915/display/intel_mg_phy_regs.h
> index 0e8248bce52d..0306ade2bc30 100644
> --- a/drivers/gpu/drm/i915/display/intel_mg_phy_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_mg_phy_regs.h
> @@ -142,7 +142,9 @@
>  #define FIA1_BASE                    0x163000
>  #define FIA2_BASE                    0x16E000
>  #define FIA3_BASE                    0x16F000
> -#define _FIA(fia)                    _PICK((fia), FIA1_BASE, FIA2_BASE,
> FIA3_BASE)
> +#define _FIA(fia)                    _PICK_EVEN_2RANGES((fia), 1,
>       \
> +                                                        FIA1_BASE,
> FIA1_BASE,\
> +                                                        FIA2_BASE,
> FIA3_BASE)
>  #define _MMIO_FIA(fia, off)          _MMIO(_FIA(fia) + (off))
> 
>  /* ICL PHY DFLEX registers */
> --
> 2.39.0

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915: Convert _FIA() to _PICK_EVEN_2RANGES()

Reply via email to