[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: Add a debug statment at hcdp2 capability check (rev3)

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Add a debug statment at hcdp2 capability check (rev3) URL : https://patchwork.freedesktop.org/series/119641/ State : success == Summary == CI Bug Log - changes from CI_DRM_13300_full -> Patchwork_119641v3_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hdcp: Add a debug statment at hcdp2 capability check (rev3)

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Add a debug statment at hcdp2 capability check (rev3) URL : https://patchwork.freedesktop.org/series/119641/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13300_full -> Patchwork_119641v3_full

Re: [Intel-gfx] [PATCH 29/29] mm: shrinker: move shrinker-related code into a separate file

2023-06-22 Thread Sergey Senozhatsky
On (23/06/22 16:53), Qi Zheng wrote: > +/* > + * Remove one > + */ > +void unregister_shrinker(struct shrinker *shrinker) > +{ > + struct dentry *debugfs_entry; > + int debugfs_id; > + > + if (!(shrinker->flags & SHRINKER_REGISTERED)) > + return; > + > +

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: Assign correct hdcp content type

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Assign correct hdcp content type URL : https://patchwork.freedesktop.org/series/119727/ State : success == Summary == CI Bug Log - changes from CI_DRM_13303_full -> Patchwork_119727v1_full

[Intel-gfx] ✗ Fi.CI.BUILD: failure for tentative fix for drm/i915/gt regression on preempt-rt

2023-06-22 Thread Patchwork
== Series Details == Series: tentative fix for drm/i915/gt regression on preempt-rt URL : https://patchwork.freedesktop.org/series/119775/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/119775/revisions/1/mbox/ not applied Applying: tentative fix

[Intel-gfx] [RFC] tentative fix for drm/i915/gt regression on preempt-rt

2023-06-22 Thread Paul Gortmaker
Back in September, I reported a PM regression pinpointed by bisect: https://lore.kernel.org/linux-rt-users/20220916181934.ga16...@windriver.com/T/#u Around Feb, I checked and didn't see any relevant mainline changes, so I decided to take a look at it myself, which is when I saw the eight patches

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gt: Move wal_get_fw_for_rmw()

2023-06-22 Thread Kenneth Graunke
On Thursday, June 22, 2023 11:27:29 AM PDT Lucas De Marchi wrote: > Move helper function to get all the forcewakes required by the wa list > to the top, so it can be re-used by other functions. > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 32

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Fix context workarounds with non-masked regs

2023-06-22 Thread Kenneth Graunke
On Thursday, June 22, 2023 11:27:30 AM PDT Lucas De Marchi wrote: > Most of the context workarounds tweak masked registers, but not all. For > masked registers, when writing the value it's sufficient to just write > the wa->set_bits since that will take care of both the clr and set bits > as well

[Intel-gfx] linux-next: build failure after merge of the drm-misc-fixes tree

2023-06-22 Thread Stephen Rothwell
^ cc1: all warnings being treated as errors Caused by commit 4481913607e5 ("drm/ttm: fix bulk_move corruption when adding a entry") I have used the drm-misc-fixes tree from next-20230622 for today. -- Cheers, Stephen Rothwell pgpOtDee3Xwhe.pgp Description: OpenPGP digital signature

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting

2023-06-22 Thread Yang, Fei
> The previouse i915_gem_object_create_internal already set it with proper > value before function return. This hard coded setting is incorrect for > platforms like MTL, thus need to be removed. > > Signed-off-by: Zhanjun Dong > --- > drivers/gpu/drm/i915/gt/intel_timeline.c | 2 -- > 1 file

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Make intel_crtc_get_vblank_counter use no trace hw reads

2023-06-22 Thread Sripada, Radhakrishna
Hi Lucas, > -Original Message- > From: De Marchi, Lucas > Sent: Thursday, June 22, 2023 12:41 PM > To: Sripada, Radhakrishna > Cc: intel-gfx@lists.freedesktop.org; Maarten Lankhorst > > Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915: Make > intel_crtc_get_vblank_counter use no trace hw

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Make intel_crtc_get_vblank_counter use no trace hw reads

2023-06-22 Thread Lucas De Marchi
On Tue, Jun 13, 2023 at 02:52:44PM -0700, Radhakrishna Sripada wrote: intel_crtc_get_vblank_counter is used in many places in the display tracing infrastructure. For a clean execution of the tracing assignment, ensure that any necessary HW reads would not further trigger another trace, to

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hdcp: Add a debug statment at hcdp2 capability check (rev3)

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Add a debug statment at hcdp2 capability check (rev3) URL : https://patchwork.freedesktop.org/series/119641/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13300_full -> Patchwork_119641v3_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/gt: Move wal_get_fw_for_rmw()

2023-06-22 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Move wal_get_fw_for_rmw() URL : https://patchwork.freedesktop.org/series/119766/ State : success == Summary == CI Bug Log - changes from CI_DRM_13309 -> Patchwork_119766v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev2)

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev2) URL : https://patchwork.freedesktop.org/series/118971/ State : success == Summary == CI Bug Log - changes from CI_DRM_13309 -> Patchwork_118971v2

[Intel-gfx] [PATCH 3/3] drm/i915/gt: Drop read from GEN8_L3CNTLREG in ICL workaround

2023-06-22 Thread Lucas De Marchi
Now that non-masked registers are already read before programming the context reads, the additional read became redudant, so remove it. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH 1/3] drm/i915/gt: Move wal_get_fw_for_rmw()

2023-06-22 Thread Lucas De Marchi
Move helper function to get all the forcewakes required by the wa list to the top, so it can be re-used by other functions. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 32 ++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

[Intel-gfx] [PATCH 2/3] drm/i915/gt: Fix context workarounds with non-masked regs

2023-06-22 Thread Lucas De Marchi
Most of the context workarounds tweak masked registers, but not all. For masked registers, when writing the value it's sufficient to just write the wa->set_bits since that will take care of both the clr and set bits as well as not overwriting other bits. However there are some workarounds, the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Remove incorrect hard coded cache coherrency setting (rev2)

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/gt: Remove incorrect hard coded cache coherrency setting (rev2) URL : https://patchwork.freedesktop.org/series/119485/ State : success == Summary == CI Bug Log - changes from CI_DRM_13309 -> Patchwork_119485v2

Re: [Intel-gfx] [PATCH v2] drm/i915/quirk: Add quirk for devices that cannot be dimmed

2023-06-22 Thread Josh Triplett
On Thu, Jun 22, 2023 at 05:28:15PM +, Allen Ballway wrote: > --- a/drivers/gpu/drm/i915/display/intel_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_backlight.c > @@ -1192,6 +1192,11 @@ static u32 get_backlight_min_vbt(struct > intel_connector *connector) > > drm_WARN_ON(>drm,

Re: [Intel-gfx] [PATCH v12 12/24] vfio: Record devid in vfio_device_file

2023-06-22 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:41AM -0700, Yi Liu wrote: > .bind_iommufd() will generate an ID to represent this bond, which is > needed by userspace for further usage. Store devid in vfio_device_file > to avoid passing the pointer in multiple places. > > Reviewed-by: Kevin Tian > Tested-by:

Re: [Intel-gfx] [PATCH v12 11/24] vfio-iommufd: Split bind/attach into two steps

2023-06-22 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:40AM -0700, Yi Liu wrote: > This aligns the bind/attach logic with the coming vfio device cdev support. > > Reviewed-by: Kevin Tian > Tested-by: Terrence Xu > Tested-by: Nicolin Chen > Tested-by: Yanting Jiang > Tested-by: Shameer Kolothum > Signed-off-by: Yi

Re: [Intel-gfx] [PATCH v12 10/24] vfio-iommufd: Move noiommu compat validation out of vfio_iommufd_bind()

2023-06-22 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:39AM -0700, Yi Liu wrote: > This moves the noiommu compat validation logic into vfio_df_group_open(). > This is more consistent with what will be done in vfio device cdev path. > > Reviewed-by: Kevin Tian > Tested-by: Terrence Xu > Tested-by: Nicolin Chen >

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

2023-06-22 Thread Imre Deak
On Thu, Jun 22, 2023 at 05:35:06PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/4] drm/i915: Add missing forward > declarations/includes to display power headers (rev2) > URL : https://patchwork.freedesktop.org/series/119480/ > State : failure > > ==

Re: [Intel-gfx] [PATCH 11/11] drm/i915/mtl: s/MTL/METEORLAKE for platform/subplatform defines

2023-06-22 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Tvrtko Ursulin > Sent: Friday, June 16, 2023 5:37 PM > To: Bhadane, Dnyaneshwar ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 11/11] drm/i915/mtl: s/MTL/METEORLAKE for > platform/subplatform defines > > > On 16/06/2023 13:05,

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hdcp: Assign correct hdcp content type

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Assign correct hdcp content type URL : https://patchwork.freedesktop.org/series/119727/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13303_full -> Patchwork_119727v1_full

Re: [Intel-gfx] [igt-dev] [PATCH v3 i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

2023-06-22 Thread Dixit, Ashutosh
On Fri, 16 Jun 2023 08:50:48 -0700, Vinay Belgaumkar wrote: > > Verify that SLPC API works as expected after a suspend. Added > another subtest that does multiple GT resets and checks freq api > works as expected after each one. > > We now check requested frequency instead of soft min/max after a

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

2023-06-22 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2) URL : https://patchwork.freedesktop.org/series/119480/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13309 -> Patchwork_119480v2

[Intel-gfx] [PATCH v2] drm/i915/quirk: Add quirk for devices that cannot be dimmed

2023-06-22 Thread Allen Ballway
Cybernet T10C cannot be dimmed without the backlight strobing. Create a new quirk to lock the minimum brightness to the highest supported value. This aligns the device with its behavior on Windows, which will not lower the brightness below maximum. Signed-off-by: Allen Ballway --- V1 -> V2: Fix

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

2023-06-22 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2) URL : https://patchwork.freedesktop.org/series/119480/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

2023-06-22 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2) URL : https://patchwork.freedesktop.org/series/119480/ State : warning == Summary == Error: dim checkpatch failed 5ccc66939606 drm/i915: Add missing

Re: [Intel-gfx] [PATCH 3/4] drm/ttm: Don't leak a resource on eviction error

2023-06-22 Thread Thomas Hellström
On 6/22/23 16:48, Christian König wrote: Am 22.06.23 um 16:08 schrieb Thomas Hellström: On 6/22/23 15:55, Andi Shyti wrote: Hi Thomas, On Thu, Jun 22, 2023 at 12:14:11PM +0200, Thomas Hellström wrote: On eviction errors other than -EMULTIHOP we were leaking a resource. Fix. Fixes:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/ttm: Fixes around resources and bulk moves

2023-06-22 Thread Patchwork
== Series Details == Series: drm/ttm: Fixes around resources and bulk moves URL : https://patchwork.freedesktop.org/series/119740/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13309 -> Patchwork_119740v1 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: avoid unused-but-set-variable warning

2023-06-22 Thread Patchwork
== Series Details == Series: i915: avoid unused-but-set-variable warning URL : https://patchwork.freedesktop.org/series/119738/ State : success == Summary == CI Bug Log - changes from CI_DRM_13309 -> Patchwork_119738v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: avoid unused-but-set-variable warning

2023-06-22 Thread Patchwork
== Series Details == Series: i915: avoid unused-but-set-variable warning URL : https://patchwork.freedesktop.org/series/119738/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update (rev3)

2023-06-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update (rev3) URL : https://patchwork.freedesktop.org/series/119676/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13302_full -> Patchwork_119676v3_full

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting

2023-06-22 Thread Dong, Zhanjun
Resend to restart the CI, https://patchwork.freedesktop.org/series/119485/ Was stuck. Regards, Zhanjun On 2023-06-22 11:26 a.m., Zhanjun Dong wrote: The previouse i915_gem_object_create_internal already set it with proper value before function return. This hard coded setting is incorrect

[Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting

2023-06-22 Thread Zhanjun Dong
The previouse i915_gem_object_create_internal already set it with proper value before function return. This hard coded setting is incorrect for platforms like MTL, thus need to be removed. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/i915/gt/intel_timeline.c | 2 -- 1 file changed, 2

Re: [Intel-gfx] [PATCH v8 08/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-22 Thread Jason Gunthorpe
On Fri, Jun 16, 2023 at 02:30:40AM -0700, Yi Liu wrote: > This allows VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl use the iommufd_ctx > of the cdev device to check the ownership of the other affected devices. > > When VFIO_DEVICE_GET_PCI_HOT_RESET_INFO is called on an IOMMUFD managed > device, the

Re: [Intel-gfx] [PATCH 24/29] mm: vmscan: make global slab shrink lockless

2023-06-22 Thread Vlastimil Babka
On 6/22/23 10:53, Qi Zheng wrote: > The shrinker_rwsem is a global read-write lock in > shrinkers subsystem, which protects most operations > such as slab shrink, registration and unregistration > of shrinkers, etc. This can easily cause problems in > the following cases. > > 1) When the memory

Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Assign correct hdcp content type

2023-06-22 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Please add Fixes tag. Regards, Ankit On 6/22/2023 2:02 PM, Suraj Kandpal wrote: Currently hdcp->content_type is being assigned the content_type field in drm_connector_state which is wrong and instead it needs to be assigned hdcp_content_type field from

Re: [Intel-gfx] [PATCH 29/29] mm: shrinker: move shrinker-related code into a separate file

2023-06-22 Thread Vlastimil Babka
On 6/22/23 10:53, Qi Zheng wrote: > The mm/vmscan.c file is too large, so separate the shrinker-related > code from it into a separate file. No functional changes. > > Signed-off-by: Qi Zheng Maybe do this move as patch 01 so the further changes are done in the new file already?

Re: [Intel-gfx] [PATCH 3/4] drm/ttm: Don't leak a resource on eviction error

2023-06-22 Thread Christian König
Am 22.06.23 um 16:08 schrieb Thomas Hellström: On 6/22/23 15:55, Andi Shyti wrote: Hi Thomas, On Thu, Jun 22, 2023 at 12:14:11PM +0200, Thomas Hellström wrote: On eviction errors other than -EMULTIHOP we were leaking a resource. Fix. Fixes: 403797925768 ("drm/ttm: Fix multihop assert on

Re: [Intel-gfx] [PATCH 01/29] mm: shrinker: add shrinker::private_data field

2023-06-22 Thread Vlastimil Babka
On 6/22/23 10:53, Qi Zheng wrote: > To prepare for the dynamic allocation of shrinker instances > embedded in other structures, add a private_data field to > struct shrinker, so that we can use shrinker::private_data > to record and get the original embedded structure. > > Signed-off-by: Qi Zheng

Re: [Intel-gfx] [PATCH 3/4] drm/ttm: Don't leak a resource on eviction error

2023-06-22 Thread Thomas Hellström
On 6/22/23 15:55, Andi Shyti wrote: Hi Thomas, On Thu, Jun 22, 2023 at 12:14:11PM +0200, Thomas Hellström wrote: On eviction errors other than -EMULTIHOP we were leaking a resource. Fix. Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.") Cc: Andrey Grodzovsky Cc: Christian

Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2 capability check

2023-06-22 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Kandpal, Suraj > Sent: Thursday, June 22, 2023 7:31 PM > To: Borah, Chaitanya Kumar ; intel- > g...@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com > Subject: RE: [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2 > capability check > > > >

Re: [Intel-gfx] [PATCH] drm/i915/display: remove display raw reg read/write micro-optimizations

2023-06-22 Thread Andi Shyti
Hi Jani, On Wed, Jun 21, 2023 at 09:38:05PM +0300, Jani Nikula wrote: > Convert the raw_reg_read() and raw_reg_write() calls in display GU MISC > and INT CTL handling to regular intel_uncore_read() and > intel_uncore_write(). These were neglible micro-optimizations, and /neglible/negligible/ >

Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2 capability check

2023-06-22 Thread Kandpal, Suraj
> -Original Message- > From: Borah, Chaitanya Kumar > Sent: Thursday, June 22, 2023 7:23 PM > To: Kandpal, Suraj ; intel- > g...@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com > Subject: RE: [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2 > capability check > > Hello

Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2 capability check

2023-06-22 Thread Borah, Chaitanya Kumar
Hello Suraj, > -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, June 21, 2023 2:25 PM > To: intel-gfx@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com; Borah, Chaitanya Kumar > ; Kandpal, Suraj > > Subject: [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2 >

Re: [Intel-gfx] [PATCH 4/4] drm/ttm: Don't leak a resource on swapout move error

2023-06-22 Thread Andi Shyti
Hi Thomas, On Thu, Jun 22, 2023 at 12:14:12PM +0200, Thomas Hellström wrote: > If moving the bo to system for swapout failed, we were leaking > a resource. Fix. > > Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding > it v2") > Cc: Christian König > Cc: "Christian

Re: [Intel-gfx] [PATCH 3/4] drm/ttm: Don't leak a resource on eviction error

2023-06-22 Thread Andi Shyti
Hi Thomas, On Thu, Jun 22, 2023 at 12:14:11PM +0200, Thomas Hellström wrote: > On eviction errors other than -EMULTIHOP we were leaking a resource. > Fix. > > Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.") > Cc: Andrey Grodzovsky > Cc: Christian König > Cc: Christian Koenig

Re: [Intel-gfx] [PATCH] i915: avoid unused-but-set-variable warning

2023-06-22 Thread Andi Shyti
Hi Arnd, On Thu, Jun 22, 2023 at 12:18:41PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The mchbar_addr variable is only used inside of an #ifdef: > > drivers/gpu/drm/i915/soc/intel_gmch.c:41:6: error: variable 'mchbar_addr' set > but not used [-Werror,-Wunused-but-set-variable] >

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Update workaround 14018778641

2023-06-22 Thread Andi Shyti
Hi Tejas, On Mon, Jun 19, 2023 at 02:33:26PM +0530, Tejas Upadhyay wrote: > WA 14018778641 needs an update after recent > performance data on MTL, aligning driver here with > HW WA update. > > Signed-off-by: Tejas Upadhyay pushed to drm-intel-gt-next. Thanks, Andi

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Replace kmap() with kmap_local_page() (rev7)

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915: Replace kmap() with kmap_local_page() (rev7) URL : https://patchwork.freedesktop.org/series/107277/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13302_full -> Patchwork_107277v7_full

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting

2023-06-22 Thread Nirmoy Das
Hi Zhanjun, please restart the CI, https://patchwork.freedesktop.org/series/119485/ It seems to be stuck. On 6/17/2023 12:11 AM, Zhanjun Dong wrote: The previouse i915_gem_object_create_internal already set it with proper value before function return. This hard coded setting is incorrect

Re: [Intel-gfx] [PATCH 1/4] drm/ttm: Fix ttm_lru_bulk_move_pos_tail()

2023-06-22 Thread Christian König
Teddy already stumbled over this as well, but this patch here looks better. Going to review and push it to drm-misc-fixes asap. Thanks, Christian. Am 22.06.23 um 12:14 schrieb Thomas Hellström: The value of pos->first was not updated when the first resource of the range was moved. This could

Re: [Intel-gfx] [PATCH 1/4] drm/ttm: Fix ttm_lru_bulk_move_pos_tail()

2023-06-22 Thread Nirmoy Das
Hi Thomas, Saw a fix from Yunxiang for this: https://patchwork.freedesktop.org/patch/543652/?series=119697=1 Regards, Nirmoy On 6/22/2023 12:14 PM, Thomas Hellström wrote: The value of pos->first was not updated when the first resource of the range was moved. This could lead to errors

Re: [Intel-gfx] [PATCH 4/4] drm/ttm: Don't leak a resource on swapout move error

2023-06-22 Thread Nirmoy Das
On 6/22/2023 12:14 PM, Thomas Hellström wrote: If moving the bo to system for swapout failed, we were leaking a resource. Fix. Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding it v2") Cc: Christian König Cc: "Christian König" Cc: dri-de...@lists.freedesktop.org

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Prevent needless toggling of DC states during modesets

2023-06-22 Thread Hogander, Jouni
On Thu, 2023-06-22 at 15:05 +0300, Imre Deak wrote: > On Thu, Jun 22, 2023 at 12:38:17PM +0300, Hogander, Jouni wrote: > > On Fri, 2023-06-16 at 21:51 +0300, Imre Deak wrote: > > > DC states are disabled / re-enabled around each modeset, which > > > may > > > lead to a needless off->on->off

Re: [Intel-gfx] [PATCH 3/4] drm/ttm: Don't leak a resource on eviction error

2023-06-22 Thread Nirmoy Das
On 6/22/2023 12:14 PM, Thomas Hellström wrote: On eviction errors other than -EMULTIHOP we were leaking a resource. Fix. Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.") Cc: Andrey Grodzovsky Cc: Christian König Cc: Christian Koenig Cc: Huang Rui Cc:

Re: [Intel-gfx] [PATCH] drm/i915/display: pre-initialize some values in probe_gmdid_display()

2023-06-22 Thread Coelho, Luciano
On Thu, 2023-06-22 at 10:08 +, Kandpal, Suraj wrote: > > On Tue, 2023-06-20 at 10:30 +, Kandpal, Suraj wrote: > > > > When intel_display_device_probe() (and, subsequently, > > > > probe_gmdid_display()) returns, the caller expects ver, rel and > > > > step > > > > to be initialized. Since

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Prevent needless toggling of DC states during modesets

2023-06-22 Thread Imre Deak
On Thu, Jun 22, 2023 at 12:38:17PM +0300, Hogander, Jouni wrote: > On Fri, 2023-06-16 at 21:51 +0300, Imre Deak wrote: > > DC states are disabled / re-enabled around each modeset, which may > > lead to a needless off->on->off toggling of the DC_off power well. > > This has some overhead as

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Assign correct hdcp content type

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Assign correct hdcp content type URL : https://patchwork.freedesktop.org/series/119727/ State : success == Summary == CI Bug Log - changes from CI_DRM_13303 -> Patchwork_119727v1 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Update workaround 14018778641 (rev2)

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update workaround 14018778641 (rev2) URL : https://patchwork.freedesktop.org/series/119517/ State : success == Summary == CI Bug Log - changes from CI_DRM_13302_full -> Patchwork_119517v2_full

Re: [Intel-gfx] [PATCH v2] drm/i915: Extend Wa_14015795083 platforms

2023-06-22 Thread Kalvala, Haridhar
On 6/17/2023 4:20 AM, Matt Roper wrote: This workaround was already implemented for DG2, PVC, and some steppings of MTL, but the workaround database has now been updated to extend this workaround to TGL, RKL, DG1, and ADL. v2: - Skip readback verification for these extra gen12lp platforms.

[Intel-gfx] [PATCH 4/4] drm/ttm: Don't leak a resource on swapout move error

2023-06-22 Thread Thomas Hellström
If moving the bo to system for swapout failed, we were leaking a resource. Fix. Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding it v2") Cc: Christian König Cc: "Christian König" Cc: dri-de...@lists.freedesktop.org Cc: # v5.14+ Signed-off-by: Thomas Hellström ---

[Intel-gfx] [PATCH 3/4] drm/ttm: Don't leak a resource on eviction error

2023-06-22 Thread Thomas Hellström
On eviction errors other than -EMULTIHOP we were leaking a resource. Fix. Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.") Cc: Andrey Grodzovsky Cc: Christian König Cc: Christian Koenig Cc: Huang Rui Cc: dri-de...@lists.freedesktop.org Cc: # v5.15+ Signed-off-by: Thomas

[Intel-gfx] [PATCH 2/4] drm/ttm: Don't shadow the operation context

2023-06-22 Thread Thomas Hellström
ttm_bo_swapout() shadows the ttm operation context which may cause major confusion in driver callbacks when swapping out !TTM_PL_SYSTEM memory. Fix this by reusing the operation context argument to ttm_bo_swapout(). Cc: "Christian König" Cc: Roger He Cc: Cc: Cc: # v4.16+ Fixes: dc947770cf34

[Intel-gfx] [PATCH 1/4] drm/ttm: Fix ttm_lru_bulk_move_pos_tail()

2023-06-22 Thread Thomas Hellström
The value of pos->first was not updated when the first resource of the range was moved. This could lead to errors like the one below. Fix this by updating pos->first when needed. <3> [218.963342] BUG: KASAN: null-ptr-deref in ttm_lru_bulk_move_del+0xc5/0x180 [ttm] <3> [218.963456] Read of size 8

[Intel-gfx] [PATCH 0/4] drm/ttm: Fixes around resources and bulk moves

2023-06-22 Thread Thomas Hellström
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A couple of ttm fixes for issues that either were hit while developing the xe driver or, for the resource leak patches, discovered during code inspection. Thomas Hellström (4): drm/ttm: Fix

[Intel-gfx] [PATCH] i915: avoid unused-but-set-variable warning

2023-06-22 Thread Arnd Bergmann
From: Arnd Bergmann The mchbar_addr variable is only used inside of an #ifdef: drivers/gpu/drm/i915/soc/intel_gmch.c:41:6: error: variable 'mchbar_addr' set but not used [-Werror,-Wunused-but-set-variable] Change this to an IS_ENABLED() check to let the compiler see how it's used and no

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Add a debug statment at hcdp2 capability check (rev3)

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Add a debug statment at hcdp2 capability check (rev3) URL : https://patchwork.freedesktop.org/series/119641/ State : success == Summary == CI Bug Log - changes from CI_DRM_13300 -> Patchwork_119641v3

Re: [Intel-gfx] [PATCH] drm/i915/display: pre-initialize some values in probe_gmdid_display()

2023-06-22 Thread Kandpal, Suraj
> On Tue, 2023-06-20 at 10:30 +, Kandpal, Suraj wrote: > > > When intel_display_device_probe() (and, subsequently, > > > probe_gmdid_display()) returns, the caller expects ver, rel and step > > > to be initialized. Since there's no way to check that there was a > > > failure and no_display

Re: [Intel-gfx] [PATCH] drm/i915/display: pre-initialize some values in probe_gmdid_display()

2023-06-22 Thread Coelho, Luciano
On Tue, 2023-06-20 at 10:30 +, Kandpal, Suraj wrote: > > When intel_display_device_probe() (and, subsequently, > > probe_gmdid_display()) returns, the caller expects ver, rel and > > step to be > > initialized. Since there's no way to check that there was a > > failure and > > no_display was

Re: [Intel-gfx] [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-22 Thread Tvrtko Ursulin
On 21/06/2023 19:51, Thomas Hellström (Intel) wrote: On 6/21/23 18:35, Ira Weiny wrote: Thomas Hellström (Intel) wrote: I think one thing worth mentioning in the context of this patch is that IIRC kmap_local_page() will block offlining of the mapping CPU until kunmap_local(), so while I

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Assign correct hdcp content type

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Assign correct hdcp content type URL : https://patchwork.freedesktop.org/series/119727/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13303 -> Patchwork_119727v1 Summary ---

Re: [Intel-gfx] [PATCH 11/11] drm/i915/mtl: s/MTL/METEORLAKE for platform/subplatform defines

2023-06-22 Thread Tvrtko Ursulin
On 21/06/2023 22:11, Matt Roper wrote: On Fri, Jun 16, 2023 at 01:05:08PM +0100, Tvrtko Ursulin wrote: On 16/06/2023 12:42, Dnyaneshwar Bhadane wrote: Follow consistent naming convention. Replace MTL with METEORLAKE Signed-off-by: Dnyaneshwar Bhadane ---

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Prevent needless toggling of DC states during modesets

2023-06-22 Thread Hogander, Jouni
On Fri, 2023-06-16 at 21:51 +0300, Imre Deak wrote: > DC states are disabled / re-enabled around each modeset, which may > lead > to a needless off->on->off toggling of the DC_off power well. This > has > some overhead as toggling DC states involves running a DMC firmware > handler and also

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/dp: On AUX xfer timeout restart freshly (rev8)

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/display/dp: On AUX xfer timeout restart freshly (rev8) URL : https://patchwork.freedesktop.org/series/119055/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13302 -> Patchwork_119055v8

[Intel-gfx] [PATCH] drm/i915/hdcp: Assign correct hdcp content type

2023-06-22 Thread Suraj Kandpal
Currently hdcp->content_type is being assigned the content_type field in drm_connector_state which is wrong and instead it needs to be assigned hdcp_content_type field from drm_connector_state Cc: Ankit Nautiyal Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +-

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update (rev3)

2023-06-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update (rev3) URL : https://patchwork.freedesktop.org/series/119676/ State : success == Summary == CI Bug Log - changes from CI_DRM_13302 -> Patchwork_119676v3

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update (rev3)

2023-06-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update (rev3) URL : https://patchwork.freedesktop.org/series/119676/ State : warning == Summary == Error: dim checkpatch failed 6ffa5cd41b20 drm/i915: Swap ggtt_vma during legacy cursor

[Intel-gfx] [DO_NOT_REVIEW PATCH] drm/i915/display/dp: On AUX xfer timeout restart freshly

2023-06-22 Thread Arun R Murthy
At the beginning of the aux transfer a check for aux control busy bit is done. Then as per the spec on aux transfer timeout, need to retry freshly for 3 times with a delay which is taken care by the control register. On each of these 3 trials a check for busy has to be done so as to start freshly.

[Intel-gfx] [PATCH] drm/i915: Handle legacy cursor update as normal update

2023-06-22 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_display.c | 15 ++- .../gpu/drm/i915/display/intel_display_types.h| 2 +- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c

Re: [Intel-gfx] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-06-22 Thread Lucas De Marchi
On Wed, Jun 21, 2023 at 07:20:59PM -0700, Yury Norov wrote: Hi Lucas, all! (Thanks, Andy, for pointing to this thread.) On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create masks for fixed-width types and also the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/dp: On AUX xfer timeout restart freshly (rev7)

2023-06-22 Thread Patchwork
== Series Details == Series: drm/i915/display/dp: On AUX xfer timeout restart freshly (rev7) URL : https://patchwork.freedesktop.org/series/119055/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13302 -> Patchwork_119055v7