Re: [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug

2023-06-26 Thread Belgaumkar, Vinay
On 6/26/2023 8:17 PM, Dixit, Ashutosh wrote: On Mon, 26 Jun 2023 19:12:18 -0700, Vinay Belgaumkar wrote: GuC load takes longer sometimes due to GT frequency not ramping up. Add perf_limit_reasons to the existing warn print to see if frequency is being throttled. Signed-off-by: Vinay

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/vdsc: Remove FIXME in intel_dsc_compute_config

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915/vdsc: Remove FIXME in intel_dsc_compute_config URL : https://patchwork.freedesktop.org/series/119864/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13322_full -> Patchwork_119864v1_full

Re: [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug

2023-06-26 Thread Dixit, Ashutosh
On Mon, 26 Jun 2023 19:12:18 -0700, Vinay Belgaumkar wrote: > > GuC load takes longer sometimes due to GT frequency not ramping up. > Add perf_limit_reasons to the existing warn print to see if frequency > is being throttled. > > Signed-off-by: Vinay Belgaumkar > --- >

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915/display/hotplug: use drm_kms_helper_connector_hotplug_event() (rev3)

2023-06-26 Thread Patchwork
== Series Details == Series: i915/display/hotplug: use drm_kms_helper_connector_hotplug_event() (rev3) URL : https://patchwork.freedesktop.org/series/119603/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13322_full -> Patchwork_119603v3_full

[Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug

2023-06-26 Thread Vinay Belgaumkar
GuC load takes longer sometimes due to GT frequency not ramping up. Add perf_limit_reasons to the existing warn print to see if frequency is being throttled. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Intel-gfx] linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2023-06-26 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: include/drm/gpu_scheduler.h between commit: db8b4968a8d0 ("drm/sched: Call drm_sched_fence_set_parent() from drm_sched_fence_scheduled()") from the drm-misc-fixes tree and commit: 539f9ee4b52a ("drm/scheduler:

[Intel-gfx] [linux-next:master] BUILD REGRESSION 60e7c4a25da68cd826719b685babbd23e73b85b0

2023-06-26 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 60e7c4a25da68cd826719b685babbd23e73b85b0 Add linux-next specific files for 20230626 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/20230613.hher4zoo-...@intel.com https

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/ttm: Fixes around resources and bulk moves (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: drm/ttm: Fixes around resources and bulk moves (rev2) URL : https://patchwork.freedesktop.org/series/119740/ State : success == Summary == CI Bug Log - changes from CI_DRM_13322_full -> Patchwork_119740v2_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Get optimal audio frequency and channels (rev6)

2023-06-26 Thread Patchwork
== Series Details == Series: Get optimal audio frequency and channels (rev6) URL : https://patchwork.freedesktop.org/series/119121/ State : success == Summary == CI Bug Log - changes from CI_DRM_13324 -> Patchwork_119121v6 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Get optimal audio frequency and channels (rev6)

2023-06-26 Thread Patchwork
== Series Details == Series: Get optimal audio frequency and channels (rev6) URL : https://patchwork.freedesktop.org/series/119121/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adlp: Disable display RM unclaimed checks while DC6 is enabled

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915/adlp: Disable display RM unclaimed checks while DC6 is enabled URL : https://patchwork.freedesktop.org/series/119874/ State : success == Summary == CI Bug Log - changes from CI_DRM_13324 -> Patchwork_119874v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/adlp: Disable display RM unclaimed checks while DC6 is enabled

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915/adlp: Disable display RM unclaimed checks while DC6 is enabled URL : https://patchwork.freedesktop.org/series/119874/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Fix spelling mistake "initate" -> "initiate" (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix spelling mistake "initate" -> "initiate" (rev2) URL : https://patchwork.freedesktop.org/series/119063/ State : success == Summary == CI Bug Log - changes from CI_DRM_13321_full -> Patchwork_119063v2_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fail if DSC compression requirement is less than platform supports

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Fail if DSC compression requirement is less than platform supports URL : https://patchwork.freedesktop.org/series/119848/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13321_full -> Patchwork_119848v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Add header file for struct seq_file (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915/display: Add header file for struct seq_file (rev2) URL : https://patchwork.freedesktop.org/series/119845/ State : success == Summary == CI Bug Log - changes from CI_DRM_13321_full -> Patchwork_119845v2_full

Re: [Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-26 Thread Jani Nikula
On Mon, 26 Jun 2023, Mitul Golani wrote: > Currently we do not check if there is enough bandwidth for > audio, and what channels and freq it can really support. > Also sometimes there can be HW constraints e.g. GLK where audio > channels supported are only 2. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vdsc: Remove FIXME in intel_dsc_compute_config

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915/vdsc: Remove FIXME in intel_dsc_compute_config URL : https://patchwork.freedesktop.org/series/119864/ State : success == Summary == CI Bug Log - changes from CI_DRM_13322 -> Patchwork_119864v1 Summary

Re: [Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-26 Thread Jani Nikula
On Mon, 26 Jun 2023, Mitul Golani wrote: > Compute SADs that takes into account the supported rate and channel > based on the capabilities of the audio source. This wrapper function > should encapsulate the logic for determining the supported rate and > channel and should return a set of SADs

Re: [Intel-gfx] [PATCH 1/2] drm/doc: fix duplicate declaration warning

2023-06-26 Thread Jani Nikula
On Mon, 26 Jun 2023, Luca Coelho wrote: > On Wed, 2023-06-21 at 15:31 +0300, Jani Nikula wrote: >> We have duplicate kernel-doc directives for the same struct, leading to: >> >> /home/jani/src/linux/Documentation/gpu/driver-uapi.rst:2279: WARNING: >> Duplicate C declaration, also defined at

Re: [Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-26 Thread Jani Nikula
On Mon, 26 Jun 2023, Mitul Golani wrote: > Initialize the source audio capabilities for HDMI in crtc_state > property by setting them to their maximum supported values, > including max_channel and max_frequency. This allows for the > calculation of HDMI audio source capabilities with respect to >

Re: [Intel-gfx] [RFC 1/3] drm/i915/hdmi: Optimize source audio parameter handling

2023-06-26 Thread Jani Nikula
On Mon, 26 Jun 2023, Mitul Golani wrote: > To enhance the relationship between the has_audio and the source > audio parameter, create a separate crtc_state audio property and > add the has_audio parameter into it. Additionally, update the > access of the has_audio parameter from the crtc_state

[Intel-gfx] [RFC 1/3] drm/i915/hdmi: Optimize source audio parameter handling

2023-06-26 Thread Mitul Golani
To enhance the relationship between the has_audio and the source audio parameter, create a separate crtc_state audio property and add the has_audio parameter into it. Additionally, update the access of the has_audio parameter from the crtc_state pointer as it is wrapped under the audio. These

[Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-26 Thread Mitul Golani
Compute SADs that takes into account the supported rate and channel based on the capabilities of the audio source. This wrapper function should encapsulate the logic for determining the supported rate and channel and should return a set of SADs that are compatible with the source. --v1: - call

[Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-26 Thread Mitul Golani
Initialize the source audio capabilities for HDMI in crtc_state property by setting them to their maximum supported values, including max_channel and max_frequency. This allows for the calculation of HDMI audio source capabilities with respect to the available mode bandwidth. These capabilities

[Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-26 Thread Mitul Golani
Currently we do not check if there is enough bandwidth for audio, and what channels and freq it can really support. Also sometimes there can be HW constraints e.g. GLK where audio channels supported are only 2. https://patchwork.freedesktop.org/series/107647/ Obtain the optimal audio rate and

[Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-26 Thread Mitul Golani
Compute SADs that takes into account the supported rate and channel based on the capabilities of the audio source. This wrapper function should encapsulate the logic for determining the supported rate and channel and should return a set of SADs that are compatible with the source. --v1: - call

[Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-26 Thread Mitul Golani
Initialize the source audio capabilities for HDMI in crtc_state property by setting them to their maximum supported values, including max_channel and max_frequency. This allows for the calculation of HDMI audio source capabilities with respect to the available mode bandwidth. These capabilities

[Intel-gfx] [RFC 1/3] drm/i915/hdmi: Optimize source audio parameter handling

2023-06-26 Thread Mitul Golani
To enhance the relationship between the has_audio and the source audio parameter, create a separate crtc_state audio property and add the has_audio parameter into it. Additionally, update the access of the has_audio parameter from the crtc_state pointer as it is wrapped under the audio. These

[Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-26 Thread Mitul Golani
Currently we do not check if there is enough bandwidth for audio, and what channels and freq it can really support. Also sometimes there can be HW constraints e.g. GLK where audio channels supported are only 2. https://patchwork.freedesktop.org/series/107647/ Obtain the optimal audio rate and

Re: [Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-26 Thread Golani, Mitulkumar Ajitkumar
Hi Kai, > -Original Message- > From: Kai Vehmanen > Sent: 21 June 2023 22:36 > To: Borah, Chaitanya Kumar > Cc: Kai Vehmanen ; Golani, Mitulkumar > Ajitkumar ; intel- > g...@lists.freedesktop.org; jyri.sa...@linux.intel.com > Subject: RE: [Intel-gfx] [RFC 2/3] drm/i915/display:

[Intel-gfx] [PATCH] drm/i915/adlp: Disable display RM unclaimed checks while DC6 is enabled

2023-06-26 Thread Imre Deak
At least on ADLP a DC6 entry/exit sequence may corrupt the FPGA_DBG register's RM_NOCLAIM flag, which is used to detect incorrect MMIO accesses on the display RM bus. Based on my tests this only happens with a non-zero package C10 residency. A related problem is that the DMC firmware's DC6->DC5

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/display/hotplug: use drm_kms_helper_connector_hotplug_event() (rev3)

2023-06-26 Thread Patchwork
== Series Details == Series: i915/display/hotplug: use drm_kms_helper_connector_hotplug_event() (rev3) URL : https://patchwork.freedesktop.org/series/119603/ State : success == Summary == CI Bug Log - changes from CI_DRM_13322 -> Patchwork_119603v3

Re: [Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-26 Thread Golani, Mitulkumar Ajitkumar
Hi Kai, > -Original Message- > From: Kai Vehmanen > Sent: 19 June 2023 16:50 > To: Golani, Mitulkumar Ajitkumar > Cc: intel-gfx@lists.freedesktop.org; jyri.sa...@linux.intel.com > Subject: Re: [Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute > SAD > > Hi, > > [+Jyri] >

Re: [Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-26 Thread Golani, Mitulkumar Ajitkumar
Hi @Kai Vehmanen > -Original Message- > From: Kai Vehmanen > Sent: 19 June 2023 17:56 > To: Golani, Mitulkumar Ajitkumar > Cc: intel-gfx@lists.freedesktop.org; jyri.sa...@linux.intel.com > Subject: Re: [Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize > HDMI audio

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/doc: fix duplicate declaration warning (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/doc: fix duplicate declaration warning (rev2) URL : https://patchwork.freedesktop.org/series/119677/ State : success == Summary == CI Bug Log - changes from CI_DRM_13320_full -> Patchwork_119677v2_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: Add quirk for OSVR HDK 2.0

2023-06-26 Thread Patchwork
== Series Details == Series: drm/edid: Add quirk for OSVR HDK 2.0 URL : https://patchwork.freedesktop.org/series/119858/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13322 -> Patchwork_119858v1 Summary ---

Re: [Intel-gfx] [PATCH v13 03/10] drm/shmem-helper: Add pages_pin_count field

2023-06-26 Thread Dmitry Osipenko
On 6/26/23 18:21, Boris Brezillon wrote: > On Mon, 26 Jun 2023 17:04:57 +0200 > Boris Brezillon wrote: > >> Hi Dmitry, >> >> Sorry for chiming in only now :-/. >> >> On Tue, 14 Mar 2023 05:26:52 +0300 >> Dmitry Osipenko wrote: >> >>> And new pages_pin_count field to struct drm_gem_shmem_object

Re: [Intel-gfx] [Intel-xe] [PATCH v2 2/4] drm/ttm: Don't shadow the operation context

2023-06-26 Thread Thomas Hellström
On Mon, 2023-06-26 at 17:18 +0200, Thomas Hellström wrote: > On Mon, 2023-06-26 at 17:15 +0200, Christian König wrote: > > Am 26.06.23 um 11:14 schrieb Thomas Hellström: > > > ttm_bo_swapout() shadows the ttm operation context which may > > > cause > > > major confusion in driver callbacks when

Re: [Intel-gfx] [PATCH v13 03/10] drm/shmem-helper: Add pages_pin_count field

2023-06-26 Thread Boris Brezillon
On Mon, 26 Jun 2023 17:04:57 +0200 Boris Brezillon wrote: > Hi Dmitry, > > Sorry for chiming in only now :-/. > > On Tue, 14 Mar 2023 05:26:52 +0300 > Dmitry Osipenko wrote: > > > And new pages_pin_count field to struct drm_gem_shmem_object that will > > determine whether pages are evictable

Re: [Intel-gfx] [PATCH v2 2/4] drm/ttm: Don't shadow the operation context

2023-06-26 Thread Thomas Hellström
On Mon, 2023-06-26 at 17:15 +0200, Christian König wrote: > Am 26.06.23 um 11:14 schrieb Thomas Hellström: > > ttm_bo_swapout() shadows the ttm operation context which may cause > > major confusion in driver callbacks when swapping out > > !TTM_PL_SYSTEM > > memory. Fix this by reusing the

Re: [Intel-gfx] [PATCH v2 2/4] drm/ttm: Don't shadow the operation context

2023-06-26 Thread Christian König
Am 26.06.23 um 11:14 schrieb Thomas Hellström: ttm_bo_swapout() shadows the ttm operation context which may cause major confusion in driver callbacks when swapping out !TTM_PL_SYSTEM memory. Fix this by reusing the operation context argument to ttm_bo_swapout(). Cc: "Christian König" Cc: Roger

Re: [Intel-gfx] [PATCH v13 03/10] drm/shmem-helper: Add pages_pin_count field

2023-06-26 Thread Boris Brezillon
Hi Dmitry, Sorry for chiming in only now :-/. On Tue, 14 Mar 2023 05:26:52 +0300 Dmitry Osipenko wrote: > And new pages_pin_count field to struct drm_gem_shmem_object that will > determine whether pages are evictable by memory shrinker. The pages will > be evictable only when

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-26 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Monday, June 26, 2023 9:35 PM > > > From: Jason Gunthorpe > > Sent: Monday, June 26, 2023 8:56 PM > > > > On Mon, Jun 26, 2023 at 08:34:26AM +, Liu, Yi L wrote: > > > > From: Jason Gunthorpe > > > > Sent: Saturday, June 24, 2023 12:15 AM > > > > > > > > } > > > >

Re: [Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

2023-06-26 Thread Jani Nikula
On Mon, 26 Jun 2023, "Borah, Chaitanya Kumar" wrote: > Hello Jani, > >> -Original Message- >> From: Jani Nikula >> Sent: Monday, June 26, 2023 5:37 PM >> To: Borah, Chaitanya Kumar ; intel- >> g...@lists.freedesktop.org >> Cc: Shankar, Uma ; Murthy, Arun R >> ; Borah, Chaitanya Kumar >>

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/ttm: Fixes around resources and bulk moves (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: drm/ttm: Fixes around resources and bulk moves (rev2) URL : https://patchwork.freedesktop.org/series/119740/ State : success == Summary == CI Bug Log - changes from CI_DRM_13322 -> Patchwork_119740v2 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for MTL Degamma implementation

2023-06-26 Thread Patchwork
== Series Details == Series: MTL Degamma implementation URL : https://patchwork.freedesktop.org/series/119844/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13320_full -> Patchwork_119844v1_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/vdsc: Remove FIXME in intel_dsc_compute_config

2023-06-26 Thread Luca Coelho
On Mon, 2023-06-26 at 18:35 +0530, Suraj Kandpal wrote: > Remove the FIXME and the code related to it as after verification > it does seem the previous values were typos and no hardware spec > mentions using these particular rc_params. > > Signed-off-by: Suraj Kandpal > > diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Fail if DSC compression requirement is less than platform supports

2023-06-26 Thread Lisovskiy, Stanislav
On Mon, Jun 26, 2023 at 03:18:52PM +0300, Luca Coelho wrote: > On Mon, 2023-06-26 at 11:28 +0300, Stanislav Lisovskiy wrote: > > Currently we just clamp that value to the highest supported one, however > > that > > means, we are not able to fit this into our available bandwidth range, so we > >

Re: [Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

2023-06-26 Thread Borah, Chaitanya Kumar
Hello Jani, > -Original Message- > From: Jani Nikula > Sent: Monday, June 26, 2023 5:37 PM > To: Borah, Chaitanya Kumar ; intel- > g...@lists.freedesktop.org > Cc: Shankar, Uma ; Murthy, Arun R > ; Borah, Chaitanya Kumar > > Subject: Re: [PATCH] drm/i915/display: Add forward declaration

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-26 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Monday, June 26, 2023 8:56 PM > > On Mon, Jun 26, 2023 at 08:34:26AM +, Liu, Yi L wrote: > > > From: Jason Gunthorpe > > > Sent: Saturday, June 24, 2023 12:15 AM > > > > > > } > > > > > > > > +static void vfio_device_get_kvm_safe(struct vfio_device_file *df)

[Intel-gfx] [PATCH] drm/i915/vdsc: Remove FIXME in intel_dsc_compute_config

2023-06-26 Thread Suraj Kandpal
Remove the FIXME and the code related to it as after verification it does seem the previous values were typos and no hardware spec mentions using these particular rc_params. Signed-off-by: Suraj Kandpal diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c

Re: [Intel-gfx] [PATCH v2 5/5] drm/i915: Try to initialize DDI/ICL+ DSI ports for every VBT child device

2023-06-26 Thread Jani Nikula
On Tue, 20 Jun 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Try to deal with duplicate child devices for the same DDI port > by attempting to initialize them in VBT defined order The first > on to succeed for a specific DDI port will be the one we use. > > We'll also get rid of

Re: [Intel-gfx] [PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-06-26 Thread Dmitry Osipenko
On 6/26/23 12:40, Boris Brezillon wrote: > I think here is the major problem I have with this patch: you've made > drm_gem_shmem_{get_pages,pin}() private, which forces me to call > drm_gem_shmem_pin() in a path where I already acquired the resv lock > (using the drm_exec infra proposed by

Re: [Intel-gfx] [PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-06-26 Thread Dmitry Osipenko
On 6/26/23 12:40, Boris Brezillon wrote: > Same problem with this renaming: it's confusing because this function > was previously taking care of the locking, and it's no longer the case. > That's actually true for other public functions your patching, but I > won't go over all of them. > > I know

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-26 Thread Jason Gunthorpe
On Mon, Jun 26, 2023 at 08:34:26AM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Saturday, June 24, 2023 12:15 AM > > > > } > > > > > > +static void vfio_device_get_kvm_safe(struct vfio_device_file *df) > > > +{ > > > + spin_lock(>kvm_ref_lock); > > > + if (df->kvm) > > > +

Re: [Intel-gfx] [PATCH] drm/i915/display : Remove support for interlace mode

2023-06-26 Thread Jani Nikula
On Wed, 14 Jun 2023, Ville Syrjälä wrote: > On Wed, Jun 14, 2023 at 09:37:49AM +0530, Ankit Nautiyal wrote: >> There are multiple panels with which Interlace mode is seen to cause >> flickering (interlacing artifacts) with different platforms. >> >> The issue is seen with both HDMI, DP with CML,

Re: [Intel-gfx] [PATCH] drm/i915/display/dp: Remove support for UHBR13.5

2023-06-26 Thread Jani Nikula
On Thu, 22 Jun 2023, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Wednesday, June 21, 2023 2:27 PM >> To: Murthy, Arun R ; intel- >> g...@lists.freedesktop.org >> Cc: Deak, Imre ; Kahola, Mika >> ; Murthy, Arun R >> Subject: Re: [PATCH]

Re: [Intel-gfx] [PATCH 2/2] drm/i915/color: For MTL convert 24 bit lut values to 16 bit

2023-06-26 Thread Jani Nikula
On Mon, 26 Jun 2023, Chaitanya Kumar Borah wrote: > For MTL and beyond, convert back the 24 bit lut values > read from HW to 16 bit values to maintain parity with > userspace values. This way we avoid pipe config mismatch > for pre-csc lut values. > > Signed-off-by: Chaitanya Kumar Borah > ---

Re: [Intel-gfx] [PATCH v2 4/4] drm/ttm: Don't leak a resource on swapout move error

2023-06-26 Thread Thomas Hellström
Hi, Christian, Will you take a look at 2/4 as well? Will you merge these? Thanks, Thomas On 6/26/23 13:33, Christian König wrote: Am 26.06.23 um 11:14 schrieb Thomas Hellström: If moving the bo to system for swapout failed, we were leaking a resource. Fix. Fixes: bfa3357ef9ab ("drm/ttm:

Re: [Intel-gfx] [PATCH 1/2] drm/i915/color: Add function to load degamma LUT in MTL

2023-06-26 Thread Jani Nikula
On Mon, 26 Jun 2023, Chaitanya Kumar Borah wrote: > MTL onwards Degamma LUT/PRE-CSC LUT precision has been increased from > 16 bits to 24 bits. Currently, drm framework only supports LUTs up to 16 > bit precision. Until a new uapi comes along to support higher bitdepth, > upscale the values sent

Re: [Intel-gfx] [PATCH] drm/i915: Fail if DSC compression requirement is less than platform supports

2023-06-26 Thread Luca Coelho
On Mon, 2023-06-26 at 11:28 +0300, Stanislav Lisovskiy wrote: > Currently we just clamp that value to the highest supported one, however that > means, we are not able to fit this into our available bandwidth range, so we > might see glitches or FIFO underruns. > While choosing less compressed bpp

Re: [Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

2023-06-26 Thread Jani Nikula
On Mon, 26 Jun 2023, Chaitanya Kumar Borah wrote: > With change [1], visibility of struct seq_file is lost in > intel_display_power.h leading to build errors. Add forward > declaration. > > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo declaration") > > v2: Use forward declaration

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix Sphinx indentation warning

2023-06-26 Thread Luca Coelho
On Wed, 2023-06-21 at 15:31 +0300, Jani Nikula wrote: > Fix Sphinx warning about unexpected indent. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/gt/uc/intel_huc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c >

Re: [Intel-gfx] [PATCH 1/2] drm/doc: fix duplicate declaration warning

2023-06-26 Thread Luca Coelho
On Wed, 2023-06-21 at 15:31 +0300, Jani Nikula wrote: > We have duplicate kernel-doc directives for the same struct, leading to: > > /home/jani/src/linux/Documentation/gpu/driver-uapi.rst:2279: WARNING: > Duplicate C declaration, also defined at rfc/i915_scheduler:3. > Declaration is '..

[Intel-gfx] [PATCH v2] drm/edid: Add quirk for OSVR HDK 2.0

2023-06-26 Thread Ralph Campbell
The OSVR virtual reality headset HDK 2.0 uses a different EDID vendor and device identifier than the HDK 1.1 - 1.4 headsets. Add the HDK 2.0 vendor and device identifier to the quirks table so that window managers do not try to display the desktop screen on the headset display. Signed-off-by:

Re: [Intel-gfx] [PATCH 16/26] drm/i915/gvt: use array_size

2023-06-26 Thread Dan Carpenter
On Mon, Jun 26, 2023 at 11:26:55AM +0200, Andi Shyti wrote: > > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c > > index 4ec85308379a..df52385ad436 100644 > > --- a/drivers/gpu/drm/i915/gvt/gtt.c > > +++ b/drivers/gpu/drm/i915/gvt/gtt.c > > @@ -1969,14 +1969,16 @@

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Fix spelling mistake "initate" -> "initiate" (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix spelling mistake "initate" -> "initiate" (rev2) URL : https://patchwork.freedesktop.org/series/119063/ State : success == Summary == CI Bug Log - changes from CI_DRM_13321 -> Patchwork_119063v2

Re: [Intel-gfx] [PATCH v2 4/4] drm/ttm: Don't leak a resource on swapout move error

2023-06-26 Thread Christian König
Am 26.06.23 um 11:14 schrieb Thomas Hellström: If moving the bo to system for swapout failed, we were leaking a resource. Fix. Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding it v2") Cc: Christian König Cc: "Christian König" Cc: dri-de...@lists.freedesktop.org

Re: [Intel-gfx] [PATCH v2 3/4] drm/ttm: Don't leak a resource on eviction error

2023-06-26 Thread Christian König
Am 26.06.23 um 11:14 schrieb Thomas Hellström: On eviction errors other than -EMULTIHOP we were leaking a resource. Fix. v2: - Avoid yet another goto (Andi Shyti) Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.") Cc: Andrey Grodzovsky Cc: Christian König Cc: Christian Koenig

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

2023-06-26 Thread Imre Deak
On Thu, Jun 22, 2023 at 08:57:28PM +0300, Imre Deak wrote: > On Thu, Jun 22, 2023 at 05:35:06PM +, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [1/4] drm/i915: Add missing forward > > declarations/includes to display power headers (rev2) > > URL :

Re: [Intel-gfx] [PATCH v2 3/4] drm/ttm: Don't leak a resource on eviction error

2023-06-26 Thread Andi Shyti
Hi Thomas, On Mon, Jun 26, 2023 at 11:14:49AM +0200, Thomas Hellström wrote: > On eviction errors other than -EMULTIHOP we were leaking a resource. > Fix. > > v2: > - Avoid yet another goto (Andi Shyti) > > Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.") > Cc: Andrey

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fail if DSC compression requirement is less than platform supports

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Fail if DSC compression requirement is less than platform supports URL : https://patchwork.freedesktop.org/series/119848/ State : success == Summary == CI Bug Log - changes from CI_DRM_13321 -> Patchwork_119848v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fail if DSC compression requirement is less than platform supports

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Fail if DSC compression requirement is less than platform supports URL : https://patchwork.freedesktop.org/series/119848/ State : warning == Summary == Error: dim checkpatch failed aad8f06979e0 drm/i915: Fail if DSC compression requirement is less than

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add header file for struct seq_file (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915/display: Add header file for struct seq_file (rev2) URL : https://patchwork.freedesktop.org/series/119845/ State : success == Summary == CI Bug Log - changes from CI_DRM_13321 -> Patchwork_119845v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Add header file for struct seq_file (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915/display: Add header file for struct seq_file (rev2) URL : https://patchwork.freedesktop.org/series/119845/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Add header file for struct seq_file (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: drm/i915/display: Add header file for struct seq_file (rev2) URL : https://patchwork.freedesktop.org/series/119845/ State : warning == Summary == Error: dim checkpatch failed 2cbe7a6b6366 drm/i915/display: Add forward declaration for struct seq_file -:10:

Re: [Intel-gfx] [PATCH v2 1/4] drm/ttm: Fix ttm_lru_bulk_move_pos_tail()

2023-06-26 Thread Christian König
I've already pushed the version from Teddy to drm-misc-fixes last week. So no need for that one any more. Christian. Am 26.06.23 um 11:14 schrieb Thomas Hellström: The value of pos->first was not updated when the first resource of the range was moved. This could lead to errors like the one

Re: [Intel-gfx] [PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-06-26 Thread Boris Brezillon
On Mon, 26 Jun 2023 11:40:14 +0200 Boris Brezillon wrote: > Hi Dmitry, > > On Tue, 30 May 2023 01:39:35 +0300 > Dmitry Osipenko wrote: > > > Replace all drm-shmem locks with a GEM reservation lock. This makes locks > > consistent with dma-buf locking convention where importers are responsible

Re: [Intel-gfx] [PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-06-26 Thread Boris Brezillon
Hi Dmitry, On Tue, 30 May 2023 01:39:35 +0300 Dmitry Osipenko wrote: > Replace all drm-shmem locks with a GEM reservation lock. This makes locks > consistent with dma-buf locking convention where importers are responsible > for holding reservation lock for all operations performed over

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/doc: fix duplicate declaration warning (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/doc: fix duplicate declaration warning (rev2) URL : https://patchwork.freedesktop.org/series/119677/ State : success == Summary == CI Bug Log - changes from CI_DRM_13320 -> Patchwork_119677v2

Re: [Intel-gfx] [PATCH 16/26] drm/i915/gvt: use array_size

2023-06-26 Thread Andi Shyti
Hi Julia, On Fri, Jun 23, 2023 at 11:14:47PM +0200, Julia Lawall wrote: > Use array_size to protect against multiplication overflows. > > The changes were done using the following Coccinelle semantic patch: > > // > @@ > expression E1, E2; > constant C1, C2; > identifier alloc =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/doc: fix duplicate declaration warning (rev2)

2023-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/doc: fix duplicate declaration warning (rev2) URL : https://patchwork.freedesktop.org/series/119677/ State : warning == Summary == Error: dim checkpatch failed bd9fe8dca640 drm/doc: fix duplicate declaration warning -:8:

[Intel-gfx] [PATCH v2 3/4] drm/ttm: Don't leak a resource on eviction error

2023-06-26 Thread Thomas Hellström
On eviction errors other than -EMULTIHOP we were leaking a resource. Fix. v2: - Avoid yet another goto (Andi Shyti) Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.") Cc: Andrey Grodzovsky Cc: Christian König Cc: Christian Koenig Cc: Huang Rui Cc:

[Intel-gfx] [PATCH v2 4/4] drm/ttm: Don't leak a resource on swapout move error

2023-06-26 Thread Thomas Hellström
If moving the bo to system for swapout failed, we were leaking a resource. Fix. Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding it v2") Cc: Christian König Cc: "Christian König" Cc: dri-de...@lists.freedesktop.org Cc: # v5.14+ Signed-off-by: Thomas Hellström

[Intel-gfx] [PATCH v2 2/4] drm/ttm: Don't shadow the operation context

2023-06-26 Thread Thomas Hellström
ttm_bo_swapout() shadows the ttm operation context which may cause major confusion in driver callbacks when swapping out !TTM_PL_SYSTEM memory. Fix this by reusing the operation context argument to ttm_bo_swapout(). Cc: "Christian König" Cc: Roger He Cc: Cc: Cc: # v4.16+ Fixes: dc947770cf34

[Intel-gfx] [PATCH v2 1/4] drm/ttm: Fix ttm_lru_bulk_move_pos_tail()

2023-06-26 Thread Thomas Hellström
The value of pos->first was not updated when the first resource of the range was moved. This could lead to errors like the one below. Fix this by updating pos->first when needed. <3> [218.963342] BUG: KASAN: null-ptr-deref in ttm_lru_bulk_move_del+0xc5/0x180 [ttm] <3> [218.963456] Read of size 8

[Intel-gfx] [PATCH v2 0/4] drm/ttm: Fixes around resources and bulk moves

2023-06-26 Thread Thomas Hellström
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A couple of ttm fixes for issues that either were hit while developing the xe driver or, for the resource leak patches, discovered during code inspection. v2: - Avoid a goto in patch 3 (Andi Shyti) - Add

Re: [Intel-gfx] [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-26 Thread Tvrtko Ursulin
On 20/06/2023 14:23, Ira Weiny wrote: Sumitra Sharma wrote: On Sun, Jun 18, 2023 at 11:11:08AM -0700, Ira Weiny wrote: Sumitra Sharma wrote: kmap() has been deprecated in favor of the kmap_local_page() due to high cost, restricted mapping space, the overhead of a global lock for

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-26 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Saturday, June 24, 2023 12:15 AM > > } > > > > +static void vfio_device_get_kvm_safe(struct vfio_device_file *df) > > +{ > > + spin_lock(>kvm_ref_lock); > > + if (df->kvm) > > + _vfio_device_get_kvm_safe(df->device, df->kvm); > > +

[Intel-gfx] [PATCH][next] drm/i915/mtl: Fix spelling mistake "initate" -> "initiate"

2023-06-26 Thread Colin Ian King
There is a spelling mistake in a drm_dbg_kms message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/intel_pmdemand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_pmdemand.c

[Intel-gfx] [PATCH] drm/i915: Fail if DSC compression requirement is less than platform supports

2023-06-26 Thread Stanislav Lisovskiy
Currently we just clamp that value to the highest supported one, however that means, we are not able to fit this into our available bandwidth range, so we might see glitches or FIFO underruns. While choosing less compressed bpp than min bpp required to handle the mode is harmless and might even

[Intel-gfx] ✓ Fi.CI.BAT: success for MTL Degamma implementation

2023-06-26 Thread Patchwork
== Series Details == Series: MTL Degamma implementation URL : https://patchwork.freedesktop.org/series/119844/ State : success == Summary == CI Bug Log - changes from CI_DRM_13320 -> Patchwork_119844v1 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH] i915: avoid unused-but-set-variable warning

2023-06-26 Thread Andi Shyti
Hi Arnd, On Thu, Jun 22, 2023 at 12:18:41PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The mchbar_addr variable is only used inside of an #ifdef: > > drivers/gpu/drm/i915/soc/intel_gmch.c:41:6: error: variable 'mchbar_addr' set > but not used [-Werror,-Wunused-but-set-variable] >

Re: [Intel-gfx] [PATCH] drm/i915/display: Add header file for struct seq_file

2023-06-26 Thread Borah, Chaitanya Kumar
Hello Jani, > -Original Message- > From: Jani Nikula > Sent: Monday, June 26, 2023 12:25 PM > To: Borah, Chaitanya Kumar ; intel- > g...@lists.freedesktop.org > Cc: Shankar, Uma ; Murthy, Arun R > ; Borah, Chaitanya Kumar > > Subject: Re: [PATCH] drm/i915/display: Add header file for

[Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

2023-06-26 Thread Chaitanya Kumar Borah
With change [1], visibility of struct seq_file is lost in intel_display_power.h leading to build errors. Add forward declaration. [1] ef104443bffa ("procfs: consolidate arch_report_meminfo declaration") v2: Use forward declaration instead of headerfile inclusion [Jani] Signed-off-by: Chaitanya

Re: [Intel-gfx] [PATCH] drm/i915/display: Add header file for struct seq_file

2023-06-26 Thread Jani Nikula
On Mon, 26 Jun 2023, Chaitanya Kumar Borah wrote: > With change [1], visibility of struct seq_file is lost in > intel_display_power.h leading to build errors. Add header > file explicitly to restore visibility. > > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo declaration") > >

[Intel-gfx] [PATCH] drm/i915/display: Add header file for struct seq_file

2023-06-26 Thread Chaitanya Kumar Borah
With change [1], visibility of struct seq_file is lost in intel_display_power.h leading to build errors. Add header file explicitly to restore visibility. [1] ef104443bffa ("procfs: consolidate arch_report_meminfo declaration") Signed-off-by: Chaitanya Kumar Borah ---