Re: [Intel-gfx] [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-20 Thread Yang, Fei
>>> [snip] > @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct > drm_i915_gem_object *obj) The code change here looks accurate, but while we're here, I have a side question about this function in general...it was originally introduced in commit 48004881f693

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/huc: silence injected failure in the load via GSC path

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915/huc: silence injected failure in the load via GSC path URL : https://patchwork.freedesktop.org/series/121080/ State : success == Summary == CI Bug Log - changes from CI_DRM_13401 -> Patchwork_121080v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/huc: silence injected failure in the load via GSC path

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915/huc: silence injected failure in the load via GSC path URL : https://patchwork.freedesktop.org/series/121080/ State : warning == Summary == Error: dim checkpatch failed 3d5d75464e51 drm/i915/huc: silence injected failure in the load via GSC path -:32:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev7)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev7) URL : https://patchwork.freedesktop.org/series/117713/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13401 -> Patchwork_117713v7

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix connector HPD polling

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix connector HPD polling URL : https://patchwork.freedesktop.org/series/121050/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13399_full -> Patchwork_121050v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev6)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev6) URL : https://patchwork.freedesktop.org/series/117713/ State : success == Summary == CI Bug Log - changes from CI_DRM_13401 -> Patchwork_117713v6

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hotplug: Reduce SHPD_FILTER to 250us (rev3)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915/hotplug: Reduce SHPD_FILTER to 250us (rev3) URL : https://patchwork.freedesktop.org/series/120722/ State : success == Summary == CI Bug Log - changes from CI_DRM_13399_full -> Patchwork_120722v3_full

[Intel-gfx] [PATCH] drm/i915/huc: silence injected failure in the load via GSC path

2023-07-20 Thread Daniele Ceraolo Spurio
If we can't load the HuC due to an injected failure, we don't want to throw and error and trip CI. Using the gt_probe_error macro for logging ensure that the error is only printed if it wasn't explicitly injected. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/7061 Signed-off-by: Daniele

[Intel-gfx] [PATCH v7] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-20 Thread Alan Previn
On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 driver init is done. That said, all subsytems

Re: [Intel-gfx] [PATCH v6] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-20 Thread Teres Alexis, Alan Previn
On Thu, 2023-07-20 at 14:52 -0700, Ceraolo Spurio, Daniele wrote: > > On 7/20/2023 2:40 PM, Alan Previn wrote: > > On MTL, if the GSC Proxy init flows haven't completed, submissions to the > > GSC engine will fail. Those init flows are dependent on the mei's > > gsc_proxy component that is loaded

Re: [Intel-gfx] [PATCH v3] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS

2023-07-20 Thread Ceraolo Spurio, Daniele
On 6/29/2023 6:44 PM, Alan Previn wrote: After recent discussions with Mesa folks, it was requested that we optimize i915's GET_PARAM for the PXP_STATUS without changing the UAPI spec. Add these additional optimizations: - If any PXP initializatoin flow failed, then ensure that we

Re: [Intel-gfx] [PATCH v6] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-20 Thread Ceraolo Spurio, Daniele
On 7/20/2023 2:40 PM, Alan Previn wrote: On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915

[Intel-gfx] ✗ Fi.CI.BAT: failure for Update AUX invalidation sequence (rev8)

2023-07-20 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev8) URL : https://patchwork.freedesktop.org/series/119798/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13400 -> Patchwork_119798v8 Summary ---

[Intel-gfx] [PATCH v6] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-20 Thread Alan Previn
On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 driver init is done. That said, all subsytems

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update AUX invalidation sequence (rev8)

2023-07-20 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev8) URL : https://patchwork.freedesktop.org/series/119798/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update AUX invalidation sequence (rev8)

2023-07-20 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev8) URL : https://patchwork.freedesktop.org/series/119798/ State : warning == Summary == Error: dim checkpatch failed 696c6b239a71 drm/i915/gt: Cleanup aux invalidation registers ba3873d2802a drm/i915: Add the has_aux_ccs device

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix premature release of request's reusable memory (rev3)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix premature release of request's reusable memory (rev3) URL : https://patchwork.freedesktop.org/series/120170/ State : success == Summary == CI Bug Log - changes from CI_DRM_13399_full -> Patchwork_120170v3_full

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/4] drm/xe: Only set PCI d3cold_allowed when we are really allowing.

2023-07-20 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/xe: Only set PCI d3cold_allowed when we are really allowing. URL : https://patchwork.freedesktop.org/series/121071/ State : failure == Summary == Error: patch

[Intel-gfx] [PATCH v7 9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-20 Thread Andi Shyti
Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")

[Intel-gfx] [PATCH v7 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-20 Thread Andi Shyti
Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Matt Roper Cc: # v5.8+ ---

[Intel-gfx] [PATCH v7 8/9] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-07-20 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc:

[Intel-gfx] [PATCH v7 4/9] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-20 Thread Andi Shyti
In preparation of the next patch align with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1. Define also the Bit Group 0 as bit_group_0 where currently only

[Intel-gfx] [PATCH v7 6/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-20 Thread Andi Shyti
Just a trivial refactoring for reducing the number of code duplicate. This will come at handy in the next commits. Signed-off-by: Andi Shyti Cc: # v5.8+ --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 +--- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git

[Intel-gfx] [PATCH v7 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-20 Thread Andi Shyti
Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Nirmoy Das Cc: #

[Intel-gfx] [PATCH v7 3/9] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-20 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: # v5.8+ Reviewed-by:

[Intel-gfx] [PATCH v7 2/9] drm/i915: Add the has_aux_ccs device property

2023-07-20 Thread Andi Shyti
We always assumed that a device might either have AUX or FLAT CCS, but this is an approximation that is not always true as it requires some further per device checks. Add the "has_aux_ccs" flag in the intel_device_info structure in order to have a per device flag indicating of the AUX CCS.

[Intel-gfx] [PATCH v7 0/9] Update AUX invalidation sequence

2023-07-20 Thread Andi Shyti
Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. In this version we support all the engines affected by this change. The stable backport has some challenges because the original patch that this series fixes has had more changes in between.

[Intel-gfx] [PATCH v7 1/9] drm/i915/gt: Cleanup aux invalidation registers

2023-07-20 Thread Andi Shyti
Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also VD1, VD3 and VE1 registers that don't exist

Re: [Intel-gfx] [PATCH v6 0/9] Update AUX invalidation sequence

2023-07-20 Thread Andi Shyti
Ops... sorry... I am realizing that I sent again V6... please ignore this series! Andi On Thu, Jul 20, 2023 at 06:44:45PM +0200, Andi Shyti wrote: > Hi, > > as there are new hardware directives, we need a little adaptation > for the AUX invalidation sequence. > > In this version we support all

[Intel-gfx] [PATCH 4/4] drm/xe: Only init runtime PM after all d3cold config is in place.

2023-07-20 Thread Rodrigo Vivi
We cannot allow runtime pm suspend after we configured the d3cold capable and threshold. Cc: Anshuman Gupta Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_pm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c

[Intel-gfx] [PATCH 3/4] drm/xe: Fix the runtime_idle call and d3cold.allowed decision.

2023-07-20 Thread Rodrigo Vivi
According to Documentation/power/runtime_pm.txt: int pm_runtime_put(struct device *dev); - decrement the device's usage counter; if the result is 0 then run pm_request_idle(dev) and return its result int pm_runtime_put_autosuspend(struct device *dev); - decrement the device's usage

[Intel-gfx] [PATCH 2/4] drm/xe: Move d3cold_allowed decision all together.

2023-07-20 Thread Rodrigo Vivi
And let's use the VRAM threshold to keep d3cold temporarily disabled. With this we have the ability to run D3Cold experiments just by touching the vram_d3cold_threshold sysfs entry. Cc: Anshuman Gupta Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_pci.c | 15 +--

[Intel-gfx] [PATCH 1/4] drm/xe: Only set PCI d3cold_allowed when we are really allowing.

2023-07-20 Thread Rodrigo Vivi
First of all it was strange to see: if (allowed) { ... } else { D3COLD_ENABLE } But besides this misalignment, let's also use the pci d3cold_allowed useful to us and know that we are not really allowing d3cold. Cc: Anshuman Gupta Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_pci.c

Re: [Intel-gfx] [PATCH v6 7/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-20 Thread Matt Roper
On Wed, Jul 19, 2023 at 01:07:27PM +0200, Andi Shyti wrote: > Enable the CCS_FLUSH bit 13 in the control pipe for render and > compute engines in platforms starting from Meteor Lake (BSPEC > 43904 and 47112). The VE and BCS engines need to add the flush > part in their command streamer. > >

Re: [Intel-gfx] [PATCH v6 5/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-20 Thread Matt Roper
On Wed, Jul 19, 2023 at 01:07:25PM +0200, Andi Shyti wrote: > Just a trivial refactoring for reducing the number of code > duplicate. This will come at handy in the next commits. > > Signed-off-by: Andi Shyti > --- > drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 +--- > 1

Re: [Intel-gfx] [PATCH v5] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-20 Thread Ceraolo Spurio, Daniele
On 7/12/2023 4:12 PM, Alan Previn wrote: On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915

Re: [Intel-gfx] [PATCH v6 2/9] drm/i915: Add the has_aux_ccs device property

2023-07-20 Thread Matt Roper
On Wed, Jul 19, 2023 at 01:07:22PM +0200, Andi Shyti wrote: > We always assumed that a device might either have AUX or FLAT > CCS, but this is an approximation that is not always true as it > requires some further per device checks. > > Add the "has_aux_ccs" flag in the intel_device_info

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tc: some clean-ups in max lane count handling code (rev2)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915/tc: some clean-ups in max lane count handling code (rev2) URL : https://patchwork.freedesktop.org/series/120980/ State : success == Summary == CI Bug Log - changes from CI_DRM_13399_full -> Patchwork_120980v2_full

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request"" (rev2)

2023-07-20 Thread Patchwork
== Series Details == Series: Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request"" (rev2) URL : https://patchwork.freedesktop.org/series/120990/ State : success == Summary == CI Bug Log - changes from CI_DRM_13399_full -> Patchwork_120990v2_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add DSC PPS readout (rev4)

2023-07-20 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev4) URL : https://patchwork.freedesktop.org/series/120456/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13399_full -> Patchwork_120456v4_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for Update AUX invalidation sequence (rev7)

2023-07-20 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev7) URL : https://patchwork.freedesktop.org/series/119798/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13399 -> Patchwork_119798v7 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update AUX invalidation sequence (rev7)

2023-07-20 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev7) URL : https://patchwork.freedesktop.org/series/119798/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update AUX invalidation sequence (rev7)

2023-07-20 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev7) URL : https://patchwork.freedesktop.org/series/119798/ State : warning == Summary == Error: dim checkpatch failed 340830609d2b drm/i915/gt: Cleanup aux invalidation registers 5999b07cb5c4 drm/i915: Add the has_aux_ccs device

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix connector HPD polling

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix connector HPD polling URL : https://patchwork.freedesktop.org/series/121050/ State : success == Summary == CI Bug Log - changes from CI_DRM_13399 -> Patchwork_121050v1 Summary ---

[Intel-gfx] [PR] GuC 70.8 for MTL and DG2 + HuC 8.5.1 for MTL

2023-07-20 Thread Daniele Ceraolo Spurio
The following changes since commit d3f66064cf43bd7338a79174bd0ff60c4ecbdf6d: Partially revert "amdgpu: DMCUB updates for DCN 3.1.4 and 3.1.5" (2023-07-07 15:24:32 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware dg2_mtl_guc_70.8 for you to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix connector HPD polling

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix connector HPD polling URL : https://patchwork.freedesktop.org/series/121050/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix connector HPD polling

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix connector HPD polling URL : https://patchwork.freedesktop.org/series/121050/ State : warning == Summary == Error: dim checkpatch failed c3343063ec23 drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume -:9:

Re: [Intel-gfx] [RFC v5 00/17] DRM cgroup controller with scheduling control and memory stats

2023-07-20 Thread T.J. Mercier
On Thu, Jul 20, 2023 at 3:55 AM Tvrtko Ursulin wrote: > > > Hi, > > On 19/07/2023 21:31, T.J. Mercier wrote: > > On Wed, Jul 12, 2023 at 4:47 AM Tvrtko Ursulin > > wrote: > >> > >>drm.memory.stat > >> A nested file containing cumulative memory statistics for the > >> whole > >>

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: use direct alias for i915 in requests (rev2)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: use direct alias for i915 in requests (rev2) URL : https://patchwork.freedesktop.org/series/120991/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13399 -> Patchwork_120991v2 Summary

Re: [Intel-gfx] [PATCH v2] drm/i915/dpt: Use shmem for dpt objects

2023-07-20 Thread Sripada, Radhakrishna
Hi Tvrtko, > -Original Message- > From: Tvrtko Ursulin > Sent: Thursday, July 20, 2023 2:17 AM > To: Yang, Fei ; Sripada, Radhakrishna > ; intel-gfx@lists.freedesktop.org > Cc: sta...@vger.kernel.org; Ville Syrjälä ; > Wilson, > Chris P > Subject: Re: [PATCH v2] drm/i915/dpt: Use shmem

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: use direct alias for i915 in requests (rev2)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: use direct alias for i915 in requests (rev2) URL : https://patchwork.freedesktop.org/series/120991/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: use direct alias for i915 in requests (rev2)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: use direct alias for i915 in requests (rev2) URL : https://patchwork.freedesktop.org/series/120991/ State : warning == Summary == Error: dim checkpatch failed b6ff0087160e drm/i915: use direct alias for i915 in requests -:138: WARNING:AVOID_BUG: Do not

[Intel-gfx] [PATCH v6 9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-20 Thread Andi Shyti
Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")

[Intel-gfx] [PATCH v6 8/9] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-07-20 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc:

[Intel-gfx] [PATCH v6 7/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-20 Thread Andi Shyti
Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). The VE and BCS engines need to add the flush part in their command streamer. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all

[Intel-gfx] [PATCH v6 6/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-20 Thread Andi Shyti
Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Matt Roper ---

[Intel-gfx] [PATCH v6 4/9] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-20 Thread Andi Shyti
In preparation of the next patch align with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1. Define also the Bit Group 0 as bit_group_0 where currently only

[Intel-gfx] [PATCH v6 5/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-20 Thread Andi Shyti
Just a trivial refactoring for reducing the number of code duplicate. This will come at handy in the next commits. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 +--- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git

[Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-20 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: # v5.8+ Reviewed-by:

[Intel-gfx] [PATCH v6 2/9] drm/i915: Add the has_aux_ccs device property

2023-07-20 Thread Andi Shyti
We always assumed that a device might either have AUX or FLAT CCS, but this is an approximation that is not always true as it requires some further per device checks. Add the "has_aux_ccs" flag in the intel_device_info structure in order to have a per device flag indicating of the AUX CCS.

[Intel-gfx] [PATCH v6 0/9] Update AUX invalidation sequence

2023-07-20 Thread Andi Shyti
Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. In this version we support all the engines affected by this change. The stable backport has some challenges because the original patch that this series fixes has had more changes in between.

[Intel-gfx] [PATCH v6 1/9] drm/i915/gt: Cleanup aux invalidation registers

2023-07-20 Thread Andi Shyti
Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also VD1, VD3 and VE1 registers that don't exist

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hotplug: Reduce SHPD_FILTER to 250us (rev3)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915/hotplug: Reduce SHPD_FILTER to 250us (rev3) URL : https://patchwork.freedesktop.org/series/120722/ State : success == Summary == CI Bug Log - changes from CI_DRM_13399 -> Patchwork_120722v3 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix premature release of request's reusable memory (rev3)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix premature release of request's reusable memory (rev3) URL : https://patchwork.freedesktop.org/series/120170/ State : success == Summary == CI Bug Log - changes from CI_DRM_13399 -> Patchwork_120170v3

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()

2023-07-20 Thread Nathan Chancellor
On Thu, Jul 20, 2023 at 09:43:05AM +0100, Tvrtko Ursulin wrote: > > On 18/07/2023 22:44, Nathan Chancellor wrote: > > A proposed update to clang's -Wconstant-logical-operand to warn when the > > left hand side is a constant shows the following instance in > > nsecs_to_jiffies_timeout() when

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix premature release of request's reusable memory (rev3)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix premature release of request's reusable memory (rev3) URL : https://patchwork.freedesktop.org/series/120170/ State : warning == Summary == Error: dim checkpatch failed 9d8a849ef3e3 drm/i915: Fix premature release of request's reusable memory -:189:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix premature release of request's reusable memory (rev3)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix premature release of request's reusable memory (rev3) URL : https://patchwork.freedesktop.org/series/120170/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tc: some clean-ups in max lane count handling code (rev2)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915/tc: some clean-ups in max lane count handling code (rev2) URL : https://patchwork.freedesktop.org/series/120980/ State : success == Summary == CI Bug Log - changes from CI_DRM_13399 -> Patchwork_120980v2

Re: [Intel-gfx] [PATCH v6 6/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-20 Thread Andi Shyti
Hi Nirmoy, > + if (aux_inv) { > + u32 bit_group_0 = 0; > + u32 bit_group_1 = 0; > + > + cmd += 4; > + > + bit_group_0 |= PIPE_CONTROL0_HDC_PIPELINE_FLUSH; > + > + switch

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tc: some clean-ups in max lane count handling code (rev2)

2023-07-20 Thread Patchwork
== Series Details == Series: drm/i915/tc: some clean-ups in max lane count handling code (rev2) URL : https://patchwork.freedesktop.org/series/120980/ State : warning == Summary == Error: dim checkpatch failed 5fc8008c4eed drm/i915/tc: rename mtl_tc_port_get_pin_assignment_mask() -:6:

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request"" (rev2)

2023-07-20 Thread Patchwork
== Series Details == Series: Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request"" (rev2) URL : https://patchwork.freedesktop.org/series/120990/ State : success == Summary == CI Bug Log - changes from CI_DRM_13399 -> Patchwork_120990v2

Re: [Intel-gfx] [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-20 Thread Tvrtko Ursulin
[Here let me just focus on the points which did not get further discussion in follow ups yet.] On 19/07/2023 23:31, Matt Roper wrote: On Wed, Jul 19, 2023 at 01:37:30PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request"" (rev2)

2023-07-20 Thread Patchwork
== Series Details == Series: Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request"" (rev2) URL : https://patchwork.freedesktop.org/series/120990/ State : warning == Summary == Error: dim checkpatch failed ca8235c2712c Revert "Revert "drm/i915: Hold reference to

Re: [Intel-gfx] [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-20 Thread Tvrtko Ursulin
On 20/07/2023 01:22, Matt Roper wrote: On Wed, Jul 19, 2023 at 05:07:15PM -0700, Yang, Fei wrote: [snip] @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct drm_i915_gem_object *obj) The code change here looks accurate, but while we're here, I have a side question about this

[Intel-gfx] ✓ Fi.CI.BAT: success for Add DSC PPS readout (rev4)

2023-07-20 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev4) URL : https://patchwork.freedesktop.org/series/120456/ State : success == Summary == CI Bug Log - changes from CI_DRM_13399 -> Patchwork_120456v4 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add DSC PPS readout (rev4)

2023-07-20 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev4) URL : https://patchwork.freedesktop.org/series/120456/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1:

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Eliminate IS_MTL_GRAPHICS_STEP

2023-07-20 Thread Andrzej Hajda
On 20.07.2023 11:36, Tvrtko Ursulin wrote: On 19/07/2023 23:54, Matt Roper wrote: On Wed, Jul 19, 2023 at 08:28:12AM -0700, Matt Roper wrote: On Wed, Jul 19, 2023 at 09:01:58AM +0100, Tvrtko Ursulin wrote: On 18/07/2023 23:27, Matt Roper wrote: Several workarounds are guarded by

[Intel-gfx] [PATCH v2 5/5] drm/i915: Don't change the status of forced connectors during HPD poll detect

2023-07-20 Thread Imre Deak
As described in the previous patch a connector shouldn't change its status while it's forced to a connected/disconnected state. This can still happen while running the connector detect function to account for lost HPD events in a low-power state. Fix this by reusing the connector detect function

[Intel-gfx] [PATCH v2 4/5] drm/i915: Don't change the status of forced connectors during hotplug detect

2023-07-20 Thread Imre Deak
DRM display connectors forced to a connected/disconnected state via the drm_connector::force member shouldn't change their status. Atm, this can still happen in the connector's detect function when called to handle a hotplug event. This in turn may lead to the GETCONNECTOR ioctl to report the

[Intel-gfx] [PATCH v2 3/5] drm/i915: Fix HPD polling, reenabling the output poll work as needed

2023-07-20 Thread Imre Deak
After the commit in the Fixes: line below, HPD polling stopped working on i915, since after that change calling drm_kms_helper_poll_enable() doesn't restart drm_mode_config::output_poll_work if the work was stopped (no connectors needing polling) and enabling polling for a connector (during

[Intel-gfx] [PATCH v2 2/5] drm: Add an HPD poll helper to reschedule the poll work

2023-07-20 Thread Imre Deak
Add a helper to reschedule drm_mode_config::output_poll_work after polling has been enabled for a connector (and needing a reschedule, since previously polling was disabled for all connectors and hence output_poll_work was not running). This is needed by the next patch fixing HPD polling on i915.

[Intel-gfx] [PATCH v2 1/5] drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume

2023-07-20 Thread Imre Deak
The issue fixed in commit a8ddac7c9f06 ("drm/i915: Avoid HPD poll detect triggering a new detect cycle") on VLV, CHV is still present on platforms where the display hotplug detection functionality is available whenever the device is in D0 state (hence these platforms switch to HPD polling only

[Intel-gfx] [PATCH v2 0/5] drm/i915: Fix connector HPD polling

2023-07-20 Thread Imre Deak
This patchset replaces [1], adding two patches to fix a connector detection issue overriding the state of forced connectors. [1] https://patchwork.freedesktop.org/series/120931/ Imre Deak (5): drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume drm: Add an HPD poll

Re: [Intel-gfx] [PATCH v6 6/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-20 Thread Nirmoy Das
Hi Andi, On 7/19/2023 1:07 PM, Andi Shyti wrote: Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc:

Re: [Intel-gfx] [PATCH v6 5/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-20 Thread Nirmoy Das
Some of the patches are needed to be backported to v5.8 so I wonder if you should do the refactoring later in the series. I guess best way is to check if you can apply the series in v5.8 On 7/19/2023 1:07 PM, Andi Shyti wrote: Just a trivial refactoring for reducing the number of code

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/color: Downscale degamma lut values read from hardware

2023-07-20 Thread Shankar, Uma
> -Original Message- > From: Borah, Chaitanya Kumar > Sent: Monday, July 10, 2023 7:13 PM > To: intel-gfx@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com; Shankar, Uma ; Borah, > Chaitanya Kumar > Subject: [PATCH v2 2/2] drm/i915/color: Downscale degamma lut values read from >

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/color: Upscale degamma values for MTL

2023-07-20 Thread Shankar, Uma
> -Original Message- > From: Borah, Chaitanya Kumar > Sent: Monday, July 10, 2023 7:13 PM > To: intel-gfx@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com; Shankar, Uma ; Borah, > Chaitanya Kumar > Subject: [PATCH v2 1/2] drm/i915/color: Upscale degamma values for MTL > > MTL

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request""

2023-07-20 Thread Andrzej Hajda
On 19.07.2023 20:58, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request"" *URL:* https://patchwork.freedesktop.org/series/120990/ *State:*failure *Details:*

[Intel-gfx] [PATCH v2] drm/i915: use direct alias for i915 in requests

2023-07-20 Thread Andrzej Hajda
i915_request contains direct alias to i915, there is no point to go via rq->engine->i915. v2: added missing rq.i915 initialization in measure_breadcrumb_dw. Signed-off-by: Andrzej Hajda Reviewed-by: Tvrtko Ursulin Acked-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4

Re: [Intel-gfx] [RFC v5 00/17] DRM cgroup controller with scheduling control and memory stats

2023-07-20 Thread Tvrtko Ursulin
Hi, On 19/07/2023 21:31, T.J. Mercier wrote: On Wed, Jul 12, 2023 at 4:47 AM Tvrtko Ursulin wrote: drm.memory.stat A nested file containing cumulative memory statistics for the whole sub-hierarchy, broken down into separate GPUs and separate memory regions

Re: [Intel-gfx] [PATCH] drm/i915: use direct alias for i915 in requests

2023-07-20 Thread Andrzej Hajda
On 20.07.2023 12:07, Tvrtko Ursulin wrote: On 20/07/2023 10:46, Tvrtko Ursulin wrote: On 19/07/2023 16:07, Andrzej Hajda wrote: i915_request contains direct alias to i915, there is no point to go via rq->engine->i915. Signed-off-by: Andrzej Hajda ---  

[Intel-gfx] [PATCH] drm/i915/hotplug: Reduce SHPD_FILTER to 250us

2023-07-20 Thread Suraj Kandpal
On TGP, the RTC (always running) was reduced from 3MHz to 32KHz. As a result of this change, when HPD active going low pulse or HPD IRQ is presented and the refclk (19.2MHz) is not toggling already toggling, there is a 60 to 90us synchronization delay which effectively reduces the duration of the

Re: [Intel-gfx] [PATCH] drm/i915/hotplug: Reduce SHPD_FILTER to 250us

2023-07-20 Thread Kandpal, Suraj
> > > -Original Message- > > From: Kandpal, Suraj > > Sent: Monday, July 17, 2023 2:54 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Kandpal, Suraj ; Shankar, Uma > > ; Ville Syrjala > > Subject: [PATCH] drm/i915/hotplug: Reduce SHPD_FILTER to 250us > > > > On TGP, the RTC (always

Re: [Intel-gfx] [PATCH] drm/i915/hotplug: Reduce SHPD_FILTER to 250us

2023-07-20 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Monday, July 17, 2023 2:54 PM > To: intel-gfx@lists.freedesktop.org > Cc: Kandpal, Suraj ; Shankar, Uma > ; Ville Syrjala > Subject: [PATCH] drm/i915/hotplug: Reduce SHPD_FILTER to 250us > > On TGP, the RTC (always running) was

Re: [Intel-gfx] [PATCH] drm/i915: use direct alias for i915 in requests

2023-07-20 Thread Tvrtko Ursulin
On 20/07/2023 10:46, Tvrtko Ursulin wrote: On 19/07/2023 16:07, Andrzej Hajda wrote: i915_request contains direct alias to i915, there is no point to go via rq->engine->i915. Signed-off-by: Andrzej Hajda ---   drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c |  4 ++--  

Re: [Intel-gfx] [PATCH] drm/i915: use direct alias for i915 in requests

2023-07-20 Thread Nirmoy Das
On 7/19/2023 5:07 PM, Andrzej Hajda wrote: i915_request contains direct alias to i915, there is no point to go via rq->engine->i915. Signed-off-by: Andrzej Hajda Acked-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 ++-- drivers/gpu/drm/i915/gt/gen2_engine_cs.c

Re: [Intel-gfx] [PATCH] drm/i915: use direct alias for i915 in requests

2023-07-20 Thread Tvrtko Ursulin
On 19/07/2023 16:07, Andrzej Hajda wrote: i915_request contains direct alias to i915, there is no point to go via rq->engine->i915. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 ++-- drivers/gpu/drm/i915/gt/gen2_engine_cs.c | 2 +-

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Eliminate IS_MTL_GRAPHICS_STEP

2023-07-20 Thread Tvrtko Ursulin
On 19/07/2023 23:54, Matt Roper wrote: On Wed, Jul 19, 2023 at 08:28:12AM -0700, Matt Roper wrote: On Wed, Jul 19, 2023 at 09:01:58AM +0100, Tvrtko Ursulin wrote: On 18/07/2023 23:27, Matt Roper wrote: Several workarounds are guarded by IS_MTL_GRAPHICS_STEP. However none of these

[Intel-gfx] [PATCH v3] drm/i915: Fix premature release of request's reusable memory

2023-07-20 Thread Janusz Krzysztofik
Infinite waits for completion of GPU activity have been observed in CI, mostly inside __i915_active_wait(), triggered by igt@gem_barrier_race or igt@perf@stress-open-close. Root cause analysis, based of ftrace dumps generated with a lot of extra trace_printk() calls added to the code, revealed

Re: [Intel-gfx] [PATCH 13/19] drm/i915/dp: Avoid left shift of DSC output bpp by 4

2023-07-20 Thread Lisovskiy, Stanislav
On Thu, Jul 13, 2023 at 04:03:40PM +0530, Ankit Nautiyal wrote: > To make way for fractional bpp support, avoid left shifting the > output_bpp by 4 in helper intel_dp_dsc_get_output_bpp. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 10 +++--- >

  1   2   >