Re: [Intel-gfx] [PATCH 0/2] Nuke PAGE_KERNEL_IO

/setup.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 4 ++-- include/asm-generic/fixmap.h | 2 +- 6 files changed, 6 insertions(+), 13 deletions(-) Acked-by: Andy Lutomirski

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Improve PSR activation timing

On Wed, Feb 28, 2018 at 12:26 AM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Andy Lutomirski (2018-02-24 00:07:23) >> On Tue, Feb 13, 2018 at 11:26 PM, Rodrigo Vivi <rodrigo.v...@intel.com> >> wrote: >> > From: Andy Lutomirski <l...@kernel

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Improve PSR activation timing

On Wed, Feb 28, 2018 at 12:22 AM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Rodrigo Vivi (2018-02-28 00:14:08) >> From: Andy Lutomirski <l...@kernel.org> >> >> The current PSR code has a two call sites that each schedule delayed >> work to ac

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Improve PSR activation timing

On Tue, Feb 13, 2018 at 11:26 PM, Rodrigo Vivi <rodrigo.v...@intel.com> wrote: > From: Andy Lutomirski <l...@kernel.org> > > + > + dev_priv->psr.activate_timer.expires = jiffies - 1; That can't possibly be okay. ___ I

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

Vivi wrote: >>>> Hi Andy, >>>> >>>> thanks for getting involved with PSR and sorry for not replying sooner. >>>> >>>> I first saw this patch on that bugzilla entry but only now I stop to >>>> really think why I have writte

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

> >> I first saw this patch on that bugzilla entry but only now I stop to >> really think why I have written the code that way. >> >> So some clarity below. >> >>> On Mon, Feb 05, 2018 at 10:07:09PM +, Andy Lutomirski wrote: >>> The current

Re: [Intel-gfx] i915 PSR test results and cursor lag

> On Feb 5, 2018, at 2:50 PM, Rodrigo Vivi <rodrigo.v...@intel.com> wrote: > >> On Sat, Feb 03, 2018 at 05:33:08PM +0000, Andy Lutomirski wrote: >>> On Fri, Feb 2, 2018 at 7:18 PM, Andy Lutomirski <l...@kernel.org> wrote: >>>> On Fri, Feb 2, 2018

[Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

a new function intel_psr_schedule(), which will enable PSR after the requested time but no sooner. Signed-off-by: Andy Lutomirski <l...@kernel.org> --- drivers/gpu/drm/i915/i915_debugfs.c | 9 +++-- drivers/gpu/drm/i915/i915_drv.h | 4 ++- drivers/gpu/drm/i915/intel_psr.c

Re: [Intel-gfx] i915 PSR test results and cursor lag

On Mon, Feb 5, 2018 at 9:17 PM, Pandiyan, Dhinakaran <dhinakaran.pandi...@intel.com> wrote: > > On Mon, 2018-02-05 at 20:35 +, Andy Lutomirski wrote: >> On Mon, Feb 5, 2018 at 6:53 PM, Pandiyan, Dhinakaran >> <dhinakaran.pandi...@intel.com> wrote: >> >

Re: [Intel-gfx] i915 PSR test results and cursor lag

On Mon, Feb 5, 2018 at 6:53 PM, Pandiyan, Dhinakaran <dhinakaran.pandi...@intel.com> wrote: > > > > On Sun, 2018-02-04 at 21:50 +0000, Andy Lutomirski wrote: >> On Sat, Feb 3, 2018 at 5:08 PM, Andy Lutomirski <l...@kernel.org> wrote: >> > On Sat, Feb 3

Re: [Intel-gfx] i915 PSR test results and cursor lag

On Sat, Feb 3, 2018 at 5:08 PM, Andy Lutomirski <l...@kernel.org> wrote: > On Sat, Feb 3, 2018 at 5:20 AM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: >> >> On Fri, 2018-02-02 at 19:18 +, Andy Lutomirski wrote: >>> I updated t

Re: [Intel-gfx] i915 PSR test results and cursor lag

On Fri, Feb 2, 2018 at 7:18 PM, Andy Lutomirski <l...@kernel.org> wrote: > On Fri, Feb 2, 2018 at 1:24 AM, Andy Lutomirski <l...@kernel.org> wrote: >> On Thu, Feb 1, 2018 at 9:20 PM, Chris Wilson <ch...@chris-wilson.co.uk> >> wrote: >>> Quoting Andy L

Re: [Intel-gfx] i915 PSR test results and cursor lag

On Sat, Feb 3, 2018 at 5:20 AM, Pandiyan, Dhinakaran <dhinakaran.pandi...@intel.com> wrote: > > On Fri, 2018-02-02 at 19:18 +, Andy Lutomirski wrote: >> I updated to 4.15, and the situation is much worse. With >> enable_psr=1, the system survives for several second

Re: [Intel-gfx] i915 PSR test results and cursor lag

On Fri, Feb 2, 2018 at 7:18 PM, Andy Lutomirski <l...@kernel.org> wrote: > On Fri, Feb 2, 2018 at 1:24 AM, Andy Lutomirski <l...@kernel.org> wrote: >> On Thu, Feb 1, 2018 at 9:20 PM, Chris Wilson <ch...@chris-wilson.co.uk> >> wrote: >>> Quoting Andy L

Re: [Intel-gfx] i915 PSR test results and cursor lag

On Fri, Feb 2, 2018 at 1:24 AM, Andy Lutomirski <l...@kernel.org> wrote: > On Thu, Feb 1, 2018 at 9:20 PM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: >> Quoting Andy Lutomirski (2018-02-01 21:04:30) >>> I got this after a recent suspend/resume: >>> &g

Re: [Intel-gfx] i915 PSR test results and cursor lag

On Thu, Feb 1, 2018 at 9:20 PM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Andy Lutomirski (2018-02-01 21:04:30) >> I got this after a recent suspend/resume: >> >> Feb 01 09:44:34 laptop systemd-logind[2412]: Lid closed. >> Feb 01 09:44:34 la

Re: [Intel-gfx] i915 PSR test results and cursor lag

On Thu, Feb 1, 2018 at 9:53 AM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Andy Lutomirski (2018-02-01 17:40:22) >> *However*, I do see one unfortunate side effect of turning on PSR. It >> seems that, when I move my cursor a little bit after a few second

Re: [Intel-gfx] i915 PSR test results and cursor lag

On Thu, Feb 1, 2018 at 9:40 AM, Andy Lutomirski <l...@kernel.org> wrote: > Hi- > > As requested in your blog post, I tested PSR. I see something like > 2.69W with PSR off and 2.17W with PSR on. Screen blanking, > suspend/resume, and the contents of the screen all seem okay.

[Intel-gfx] i915 PSR test results and cursor lag

Hi- As requested in your blog post, I tested PSR. I see something like 2.69W with PSR off and 2.17W with PSR on. Screen blanking, suspend/resume, and the contents of the screen all seem okay. This is a Dell XPS 13 9350, i.e.: System Information Manufacturer: Dell Inc. Product

Re: [Intel-gfx] REGRESSION in c5552fde102f ("nvme: Enable autonomous power state transitions")

On Wed, Jan 24, 2018 at 5:35 AM, Ville Syrjälä wrote: > On Wed, Jan 24, 2018 at 01:42:08PM +0200, Jani Nikula wrote: >> >> Hi Andy, all - >> >> So this is an odd one. >> >> I'm getting display FIFO underruns in a very specific setting: Laptop >> display switched

[Intel-gfx] Skylake underruns on 4.8-rc4

My Dell XPS 13 9350 laptop just got a buffer underrun: [drm:intel_cpu_fifo_underrun_irq_handler [i915]] *ERROR* CPU pipe A FIFO underrun I'm seeing this very occasionally, and they don't come in groups -- I seem to get one underrun with a black flash and that's it. This is with just the laptop

[Intel-gfx] DP link training and performance issues with HDMI USB-C dongle and Skylake

I have a Dell XPS 13 9350 (Skylake) and a Dell DA200 adapter. The latter is a Thunderbolt device that includes an HDMI port and connects over USB Type C. I believe that it's internally using DP Alternate Mode. When I plug it in on 4.7-rc4, I get spew like this: [ 90.718106]

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

On Wed, Feb 17, 2016 at 8:18 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Tue, Feb 16, 2016 at 09:26:35AM -0800, Andy Lutomirski wrote: >> On Tue, Feb 16, 2016 at 9:12 AM, Andy Lutomirski <l...@amacapital.net> wrote: >> > On Tue, Feb 16, 2016 at 8:12 AM, Daniel

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

On Mon, Feb 22, 2016 at 7:13 PM, Andy Lutomirski <l...@amacapital.net> wrote: > On Wed, Feb 17, 2016 at 5:36 PM, Andy Lutomirski <l...@amacapital.net> wrote: >> On Wed, Feb 17, 2016 at 8:18 AM, Daniel Vetter <dan...@ffwll.ch> wrote: >>> On Tue, Feb 16, 2016

Re: [Intel-gfx] [PATCH v1 00/12] PCI: Rework shadow ROM handling

On Fri, Mar 11, 2016 at 3:29 PM, Bjorn Helgaas <helg...@kernel.org> wrote: > On Fri, Mar 11, 2016 at 01:16:09PM -0800, Andy Lutomirski wrote: >> On Tue, Mar 8, 2016 at 9:45 AM, Bjorn Helgaas <helg...@kernel.org> wrote: >> > On Thu, Mar 03, 2016 at 10:53:5

Re: [Intel-gfx] [PATCH v1 00/12] PCI: Rework shadow ROM handling

On Tue, Mar 8, 2016 at 9:45 AM, Bjorn Helgaas wrote: > On Thu, Mar 03, 2016 at 10:53:50AM -0600, Bjorn Helgaas wrote: >> The purpose of this series is to: >> >> - Fix the "BAR 6: [??? 0x flags 0x2] has bogus alignment" >> messages reported by Linus [1], Andy [2],

Re: [Intel-gfx] i915 Skylake: "Invalid ROM contents"

On Sun, Jan 10, 2016 at 11:12 AM, Andy Lutomirski <l...@amacapital.net> wrote: > On Sun, Jan 10, 2016 at 10:41 AM, Andy Lutomirski <l...@amacapital.net> wrote: >> On Wed, Nov 18, 2015 at 8:12 AM, Daniel Stone <dan...@fooishbar.org> wrote: >>> Hi, >&g

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

On Wed, Feb 17, 2016 at 5:36 PM, Andy Lutomirski <l...@amacapital.net> wrote: > On Wed, Feb 17, 2016 at 8:18 AM, Daniel Vetter <dan...@ffwll.ch> wrote: >> On Tue, Feb 16, 2016 at 09:26:35AM -0800, Andy Lutomirski wrote: >>> On Tue, Feb 16, 2016 at 9:12 AM, Andy L

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

On Wed, Feb 17, 2016 at 8:18 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Tue, Feb 16, 2016 at 09:26:35AM -0800, Andy Lutomirski wrote: >> On Tue, Feb 16, 2016 at 9:12 AM, Andy Lutomirski <l...@amacapital.net> wrote: >> > On Tue, Feb 16, 2016 at 8:12 AM, Daniel

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

On Tue, Feb 16, 2016 at 9:12 AM, Andy Lutomirski <l...@amacapital.net> wrote: > On Tue, Feb 16, 2016 at 8:12 AM, Daniel Vetter <dan...@ffwll.ch> wrote: >> On Mon, Feb 15, 2016 at 06:58:33AM -0800, Andy Lutomirski wrote: >>> On Sun, Feb 14, 2016 at 6:59 PM, Andy Luto

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

On Tue, Feb 16, 2016 at 8:12 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Mon, Feb 15, 2016 at 06:58:33AM -0800, Andy Lutomirski wrote: >> On Sun, Feb 14, 2016 at 6:59 PM, Andy Lutomirski <l...@kernel.org> wrote: >> > Hi- >> > >> > On 4.5-rc

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

On Sun, Feb 14, 2016 at 6:59 PM, Andy Lutomirski <l...@kernel.org> wrote: > Hi- > > On 4.5-rc3 on a Dell XPS 13 9350 (Skylake i915, no nvidia on this > model), shortly after resume, I saw a single black flash on the > screen. The log s

Re: [Intel-gfx] i915 Skylake: "Invalid ROM contents"

On Sun, Jan 10, 2016 at 10:41 AM, Andy Lutomirski <l...@amacapital.net> wrote: > On Wed, Nov 18, 2015 at 8:12 AM, Daniel Stone <dan...@fooishbar.org> wrote: >> Hi, >> >> On 18 November 2015 at 15:59, Andy Lutomirski <l...@amacapital.net> wrote: >>>

Re: [Intel-gfx] i915 Skylake: "Invalid ROM contents"

On Wed, Nov 18, 2015 at 8:12 AM, Daniel Stone <dan...@fooishbar.org> wrote: > Hi, > > On 18 November 2015 at 15:59, Andy Lutomirski <l...@amacapital.net> wrote: >> On Wed, Nov 18, 2015 at 2:59 AM, Ville Syrjälä >> <ville.syrj...@linux.intel.com> wrote: >&

[Intel-gfx] i915 Skylake crash on 4.4-rc3

[53834.386369] traps: gnome-session-b[2308] general protection ip:7f10efc1fc2b sp:7ffdfde31880 error:0 in libc-2.22.so[7f10efba1000+1b7000] [53834.687584] [ cut here ] [53834.687607] WARNING: CPU: 0 PID: 23730 at drivers/gpu/drm/i915/i915_gem_context.c:144

Re: [Intel-gfx] i915 Skylake: "Invalid ROM contents"

[adding linux-pci] On Wed, Nov 18, 2015 at 2:59 AM, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Tue, Nov 17, 2015 at 11:43:25AM -0800, Andy Lutomirski wrote: >> Typing: >> >> # cat /sys/devices/pci:00/:00:02.0/rom >> >> Provokes: >&g

[Intel-gfx] i915 Skylake: "Invalid ROM contents"

Typing: # cat /sys/devices/pci:00/:00:02.0/rom Provokes: i915 :00:02.0: Invalid ROM contents This is on a Dell XPS 13 9350 (Skylake). This is 4.3.0 plus some wireless-next bits. --Andy -- Andy Lutomirski AMA Capital Management, LLC

Re: [Intel-gfx] Regression: audit: x86: drop arch from __audit_syscall_entry() interface

On 10/22/2014 11:23 AM, Eric Paris wrote: That's really serious. Looking now. On Wed, 2014-10-22 at 16:08 -0200, Paulo Zanoni wrote: Hi (Cc'ing everybody mentioned in the original patch) I work for Intel, on our Linux Graphics driver - aka i915.ko - and our QA team recently reported a

Re: [Intel-gfx] Regression: audit: x86: drop arch from __audit_syscall_entry() interface

On Wed, Oct 22, 2014 at 12:16 PM, Richard Guy Briggs r...@redhat.com wrote: On 14/10/22, Andy Lutomirski wrote: On 10/22/2014 11:23 AM, Eric Paris wrote: That's really serious. Looking now. On Wed, 2014-10-22 at 16:08 -0200, Paulo Zanoni wrote: Hi (Cc'ing everybody mentioned

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use Write-Through cacheing for the display plane on Iris

On 08/01/2013 10:39 AM, Chris Wilson wrote: Haswell GT3e has the unique feature of supporting Write-Through cacheing of objects within the eLLC/LLC. The purpose of this is to enable the display plane to remain coherent whilst objects lie resident in the eLLC/LLC - so that we, in theory, get

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use Write-Through cacheing for the display plane on Iris

On Fri, Aug 2, 2013 at 12:21 PM, Ben Widawsky b...@bwidawsk.net wrote: On Fri, Aug 02, 2013 at 11:45:22AM -0700, Andy Lutomirski wrote: On 08/01/2013 10:39 AM, Chris Wilson wrote: Haswell GT3e has the unique feature of supporting Write-Through cacheing of objects within the eLLC/LLC

Re: [Intel-gfx] [PULL] drm-intel-next

On 08/03/2011 11:14 PM, Keith Packard wrote: Here's a pile of fixes on top of the stuff already in drm-core-next. * Pile of mode setting fixes which eliminate a selection of bugs and other annoyances. Eliminates the 'stripey' effect when going from two to one monitor, makes hot-plug

[Intel-gfx] [ANCIENT PATCH] Enable 30-bit depth

Signed-off-by: Andy Lutomirski l...@mit.edu --- This patch is over a year old, caused problems, and probably doesn't even apply anymore. It worked at least a little bit, though. There's a lot more that needs doing, especially in relation to DirectColor mode. src/intel_driver.c |5

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

(!) before actually waiting. Signed-off-by: Andy Lutomirski l...@mit.edu --- Jesse, you asked for the deletion of the timer to be separate from reducing the timeout, but that seemed silly because I'm ripping out the entire old mechanism. If you're worried about the added time spent in the interrupt