Re: [Intel-gfx] [PATCH v.3 11/12] DRM/i915: Add bit field to record which pins have received HPD events (v3)

On Tue, Mar 05, 2013 at 08:00:30AM -0500, Egbert Eich wrote: This way it is possible to limit 're'-detect() of displays to connectors which have received an HPD event. v2: Reordered drm_i915_private: Move hpd_event_bits to hpd state tracking. v3: Fix patch. Oops, forget this patch. It's

[Intel-gfx] [PATCH v.3 12/12] DRM/i915: Only reprobe display on encoder which has received an HPD event.

Instead of calling into the DRM helper layer to poll all connectors for changes in connected displays probe only those connectors which have received a hotplug event. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 37 +++-- 1 files

[Intel-gfx] [PATCH] DRM/i915: On G45 enable cursor plane briefly after enabling the display plane.

briefly enabling the cursor plane. Signed-off-by: Egbert Eich e...@suse.com Bugzilla: https://bugs.freedesktop.org/attachment.cgi?bugid=61457 Acked-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_display.c | 28 +++- 1 files changed, 27 insertions

[Intel-gfx] [PATCH v.2 03/12] DRM/i915: Convert HPD interrupts to make use of HPD pin assignment in encoders (v2)

This allows to enable HPD interrupts for individual pins to only receive hotplug events from lines which are connected and working. v2: Restructured initailization of const arrays following a suggstion by Chris Wilson ch...@chris-wilson.co.uk Signed-off-by: Egbert Eich e...@suse.de Acked

[Intel-gfx] [PATCH v.2 06/12] DRM/i915: Add HPD IRQ storm detection (v2)

duing battery charging when the battery is at a certain charge levels. Thus we add a simple algorithm here that detects an 'interrupt storm' condition. v2: Fixed comment. Signed-off-by: Egbert Eich e...@suse.de Acked-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH v.2 00/12] Detect and deal with Interrupt 'Storms' from noisy Hotplug Lines.

at a later time. Egbert Eich (12): DRM/i915: Remove valleyview_hpd_irq_setup. DRM/I915: Add enum hpd_pin to intel_encoder. DRM/i915: Convert HPD interrupts to make use of HPD pin assignment in encoders. DRM/i915: Remove i965_hpd_irq_setup. DRM/i915: Get rid if the 'hotplug_supported_mask

[Intel-gfx] [PATCH v.2 04/12] DRM/i915: Remove i965_hpd_irq_setup.

code path. These are considered harmless. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 53 +- 1 files changed, 18 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] [PATCH v.2 03/12] DRM/i915: Convert HPD interrupts to make use of HPD pin assignment in encoders.

This allows to enable HPD interrupts for individual pins to only receive hotplug events from lines which are connected and working. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 160 -- drivers/gpu/drm/i915/i915_reg.h | 32

[Intel-gfx] [PATCH v.2 06/12] DRM/i915: Add HPD IRQ storm detection.

on the selected video mode. Also on certain laptops interrupt noise seems to occur duing battery charging when the battery is at a certain charge levels. Thus we add a simple algorithm here that detects an 'interrupt storm' condition. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v.2 07/12] DRM/i915: (re)init HPD interrupt storm statistics.

to the default value, the HPD interrupts are marked enabled. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 13 + drivers/gpu/drm/i915/intel_crt.c |6 ++ drivers/gpu/drm/i915/intel_dp.c |1 - drivers/gpu/drm/i915/intel_drv.h |4

[Intel-gfx] [PATCH v.2 05/12] DRM/i915: Get rid if the 'hotplug_supported_mask' in struct drm_i915_private.

Now since we have replaced the bits to show interest in hotplug IRQs we can go and nuke the 'hotplug_supported_mask'. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_drv.h |1 - drivers/gpu/drm/i915/intel_crt.c |2 -- drivers/gpu/drm/i915/intel_dp.c |3

[Intel-gfx] [PATCH v.2 08/12] DRM/i915: Treat hpd_irq_setup() for ironake and older generations the same way.

When switching to enabling HPD IRQs only for lines where needed and supported this will ensure that the right lines will be enabled on all generations when intel_hpd_init() is called. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 10 +- 1 files changed

[Intel-gfx] [PATCH v.2 09/12] DRM/i915: Disable HPD interrupt on pin when irq storm is detected.

back to periodic device polling. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 69 ++- 1 files changed, 53 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index e0cf629

[Intel-gfx] [PATCH v.2 10/12] DRM/i915: Add Reenable Timer to turn Hotplug Detection back on.

it after a certain grace period (2 minutes). Should the interrupt storm persist it will be detected immediately and it will be disabled again. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_drv.h |2 + drivers/gpu/drm/i915/i915_irq.c | 53

[Intel-gfx] [PATCH v.2 11/12] DRM/i915: Add bit field to record which pins have received HPD events.

This way it is possible to limit 're'-detect() of displays to connectors which have received an HPD event. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/i915_irq.c | 10 ++ 2 files changed, 11 insertions(+), 0 deletions

[Intel-gfx] [PATCH v.2 12/12] DRM/i915: Only reprobe display on encoder which has received an HPD event.

Instead of calling into the DRM helper layer to poll all connectors for changes in connected displays probe only those connectors which have received a hotplug event. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 37 +++-- 1 files

Re: [Intel-gfx] [PATCH 0/8] Detect and deal with Interrupt 'Storms' from noisy Hotplug Lines.

Hi Daniel, I've played around a bit now, and implemented your suggestions: On Thu, Jan 17, 2013 at 03:45:26PM +0100, Daniel Vetter wrote: On Thu, Jan 17, 2013 at 03:01:06PM +0100, Egbert Eich wrote: Hi Daniel, On Fri, Jan 11, 2013 at 09:34:08PM +0100, Daniel Vetter wrote: Nice

Re: [Intel-gfx] [PATCH 0/8] Detect and deal with Interrupt 'Storms' from noisy Hotplug Lines.

On Tue, Jan 22, 2013 at 02:48:29PM +0100, Daniel Vetter wrote: On Tue, Jan 22, 2013 at 2:22 PM, Egbert Eich e...@freedesktop.org wrote: Hm, I've thought the hw supports short dp pulses on eDP port A in case the panel needs our attention, but maybe I've mixed that up with the dp aux irq

Re: [Intel-gfx] [PATCH 0/8] Detect and deal with Interrupt 'Storms' from noisy Hotplug Lines.

Hi Daniel, On Fri, Jan 11, 2013 at 09:34:08PM +0100, Daniel Vetter wrote: Nice work, and we know that we need this since quite a while. But unfortunately we've not yet come around to implement something. Some high-level comments on how I think this should best be handled: - imo

[Intel-gfx] [PATCH 0/8] Detect and deal with Interrupt 'Storms' from noisy Hotplug Lines.

connector. - The interrupt enable functions needed to be separate, also they need to be able to enable interrupts for each hotplug line independently. Egbert Eich (8): drm/i915: Remove pch_rq_mask from struct drm_i915_private. drm/i915: Set hotplug_supported_flag for all chipset

[Intel-gfx] [PATCH 2/8] drm/i915: Set hotplug_supported_flag for all chipset generations.

So far the hotplug_supported_mask in the struct drm_i915_private is only used for pre-Ironlake chipsets. This patch sets up the correct value for all generations. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_drv.h |4 ++ drivers/gpu/drm/i915/i915_irq.c | 71

[Intel-gfx] [PATCH 4/8] drm/i915: Add Hotplug IRQ Storm detection.

on the selected video mode. Also on certain laptops interrupt noise seems to occur duing battery charging when the battery is at a certain charge levels. Thus we add a simple algorithm here that detects an 'interrupt storm' condition. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/8] drm/i915: Add hpd status bit to struct intel_connector.

To be able to map an HPD interrupt to a connector add the hpd status bit to the intel_connector structure. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_crt.c |3 ++- drivers/gpu/drm/i915/intel_dp.c |3 ++- drivers/gpu/drm/i915/intel_drv.h |3 +++ drivers

[Intel-gfx] [PATCH 8/8] drm/i915: Add Reenable Timer to turn Hotplug Detection back on.

it after a certain grace period (2 minutes). Should the interrupt storm persist it will be detected immediately and it will be disabled again. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_drv.h |2 + drivers/gpu/drm/i915/i915_irq.c | 58

[Intel-gfx] [PATCH 7/8] drm/i915: When detecting a hotplug IRQ storm disable respective IRQs.

back to periodic device polling. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 2da788f..aa4986d

[Intel-gfx] [PATCH 5/8] drm/i915: Move hotplug interrupt enable for i915/i965/valleyview into a separate function.

Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 178 ++ 1 files changed, 103 insertions(+), 75 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 4e75df0..356472f 100644

[Intel-gfx] [PATCH 6/8] drm/i915: Only enable hotplug irq when needed on Ironlake and later chips.

Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 89 -- 1 files changed, 47 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 356472f..2da788f 100644 --- a/drivers

[Intel-gfx] [PATCH] DRM/i915: Add QUIRK_INVERT_BRIGHTNESS for NCR machines.

NCR machines with LVDS panels using Intel chipsets need to have the QUIRK_INVERT_BRIGHTNESS bit set. Unfortunately NCR doesn't set a meaningful subvendor/subdevice ID, therefore we add a DMI dependent quirk list. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH] DRM/i915: Don't delete DPLL Multiplier during DAC init.

there was no setup for clone modes. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_crt.c | 15 +-- 1 files changed, 1 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c index c42b980..ae3a3d5 100644 --- a/drivers

[Intel-gfx] [PATCH] DRM/i915: Restore sdvo_flags after dtd-mode-dtd Roundrtrip.

6651819b4b4fc3caa6964c5d825eb4bb996f3905 Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Sun Apr 1 19:16:18 2012 +0200 drm/i915: handle input/output sdvo timings separately in mode_set Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_sdvo.c |8 1 files changed, 8

[Intel-gfx] [PATCH] DRM/i915: Don't clone SDVO LVDS with analog.

SDVO LVDS are not clonable as the input mode gets adjusted by the LVDS encoder. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_sdvo.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915

<    1   2