[Intel-gfx] [PULL] drm-intel-next-fixes

2019-11-22 Thread Joonas Lahtinen
Hi Dave & Daniel, A quick fixup amendment to the previous PR. gem_exec_reloc/basic-range got broken in CI, so we've issued a patch revert the offending commit for now. Once the results for CI_DINF_163 appear here, and the timeouts seen in last three CI_DINF_ are green, feel free to pull this: ht

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2019-11-22 Thread Joonas Lahtinen
Quoting Joonas Lahtinen (2019-11-20 22:40:35) > Hi Dave & Daniel, > > NOTE: CI shard results are delayed, bu I'm sending this > already because I'll travel tomorrow. I'll let you know > if the results look OK or not. Or you can look up > CI_DINF_162 results c

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Lock the request while validating it during promotion

2019-11-21 Thread Joonas Lahtinen
void and we need to ignore them. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112363 > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://

Re: [Intel-gfx] [PATCH 1/5] Revert "drm/i915/gt: Wait for new requests in intel_gt_retire_requests()"

2019-11-20 Thread Joonas Lahtinen
sts in > intel_gt_retire_requests()") > References: 1683d24c1470 ("drm/i915/gt: Move new timelines to the end of > active_list") > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas __

[Intel-gfx] [PULL] drm-intel-next-fixes

2019-11-20 Thread Joonas Lahtinen
drm/i915: Fix detection for a CMP-V PCH drm/i915: Restore GT coarse power gating workaround Jani Nikula (1): drm/i915: fix accidental static variable use Joonas Lahtinen (1): Merge tag 'gvt-next-fixes-2019-11-12' of https://github.com/intel/gvt-linux into drm-intel-next

Re: [Intel-gfx] [PATCH] drm/i915/gt: Fixup config ifdeffery for pm_suspend_target_state

2019-11-20 Thread Joonas Lahtinen
is Wilson > Fixes: a70a9e998e8e ("drm/i915: Defer rc6 shutdown to suspend_late") > Cc: Andi Shyti > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://l

Re: [Intel-gfx] [PULL] gvt-next-fixes

2019-11-20 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2019-11-12 08:20:32) > > Hi, > > Here's one fix to remove PVINFO read in initial state for extra > warning messages in debug. Pulled now. Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.fre

Re: [Intel-gfx] drm-next + i915 CVE yolo merge

2019-11-15 Thread Joonas Lahtinen
Quoting Dave Airlie (2019-11-14 03:33:24) > The landing of the i915 CVE fixes into Linus tree has created a bit of > a mess in linux-next and downstream in drm-next trees. > > I talked to Daniel and he had talked to Joonas a bit, and I decided to > go with what Daniel describes as the YOLO merge,

[Intel-gfx] [PULL] drm-intel-next-fixes

2019-11-14 Thread Joonas Lahtinen
Hi Dave & Daniel, Here comes the set of fixes for drm-intel-next. Quite a few fixes after a silent last week. I'll do the backmerge of the BCX fixes from Linus's tree next and send it as an extra PR. Regards, Joonas *** drm-intel-next-fixes-2019-11-14: - PMU "Frequency" is reported as accumul

[Intel-gfx] Patched that failed to cherry-pick for drm-intel-next-fixes

2019-11-12 Thread Joonas Lahtinen
Hi all, The following patches failed to cherry-pick to drm-intel-next-fixes: bd8c9cca8876 ("drm/i915: Split a setting of MSA to MST and SST") 31b61f0ef9af ("drm/i915/execlists: Move reset_active() from schedule-out to schedule-in") Please provide backported versions by tomorrow, to have them in

Re: [Intel-gfx] [PATCH 10/25] drm/i915/execlists: Reduce barrier on context switch to a wmb()

2019-11-11 Thread Joonas Lahtinen
; > References: cf66b8a0ba14 ("drm/i915/execlists: Apply a full mb before > execution for Braswell") > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas

Re: [Intel-gfx] [PATCH 13/25] drm/i915: Taint the kernel on dumping the GEM ftrace buffer

2019-11-11 Thread Joonas Lahtinen
o reboot the machine; fix the bug and move on. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Tvrtko Ursulin Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists

[Intel-gfx] [PULL] drm-intel-next-fixes

2019-11-07 Thread Joonas Lahtinen
Hi Dave & Daniel, A quiet start. Hopefully stays that way :) RCU tracking fix and suspend GEM_BUG_ON fix with dependencies. Regards, Joonas *** drm-intel-next-fixes-2019-11-07: One RCU fix and fix for suspend GEM_BUG_ON (with dependencies). The following changes since commit 8a86b00a437ec06b

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_mmap_gtt: Skip if we have no aperture and no mmap_gtt

2019-11-06 Thread Joonas Lahtinen
ecific tests. > > Signed-off-by: Chris Wilson > Cc: Abdiel Janulgue > Cc: Matthew Auld > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/gem: Early rejection of no-aperture map_ggtt

2019-11-06 Thread Joonas Lahtinen
d explicitly control the mmap type (viz > MMAP_OFFSET_IOCTL). > > Signed-off-by: Chris Wilson > Cc: Abdiel Janulgue > Cc: Matthew Auld > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-g

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

2019-11-06 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-11-05 23:13:36) > Quoting Daniel Vetter (2019-11-05 20:58:25) > > On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson > > wrote: > > > > > > Quoting Daniel Vetter (2019-11-05 19:38:29) > > > > It's broken. > > > > > > > > Reported-by: Stephen Rothwell > > > > References: > >

Re: [Intel-gfx] [RFC 1/2] drm/i915: add display uncore helpers

2019-11-05 Thread Joonas Lahtinen
TE() in display/ with these, to finally > be able to get rid of the implicit dev_priv local parameter use. > > The idea is that any non-u32 reads or writes are special enough that > they can use the intel_uncore_* functions directly. > > Cc: Chris Wilson > Cc: Daniele Ceraolo

Re: [Intel-gfx] [PATCH] drm/i915: Drop inspection of execbuf flags during evict

2019-11-05 Thread Joonas Lahtinen
ue to this execbuf or another. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Document locking guidelines

2019-11-05 Thread Joonas Lahtinen
Dave, ping for Acked-by here so we can merge? You already gave an early ack in IRC while travelling. Regards, Joonas Quoting Joonas Lahtinen (2019-08-30 13:50:53) > To ensure cross-driver locking compatibility, document the expected > guidelines for implementing the GEM locking in i915

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v5 1/4] lib/i915: Add minimum GTT alignment helper

2019-11-05 Thread Joonas Lahtinen
Quoting Janusz Krzysztofik (2019-11-04 19:13:27) > Some tests assume 4kB offset alignment while using softpin. That > assumption may be wrong on future GEM backends with possibly larger > minimum page sizes. As a result, those tests may either fail on > softpin at offsets which are incorrectly al

Re: [Intel-gfx] [PATCH 3/3] drm/i915: use might_lock_nested in get_pages annotation

2019-11-05 Thread Joonas Lahtinen
> Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Will Deacon > Cc: linux-ker...@vger.kernel.org Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-11-05 Thread Joonas Lahtinen
ppease checkpatch, no double empty lines (Chris) > > v6: More rebasing over selftest changes. Also somehow I forgot to > push this patch :-/ > > Also format comments consistently while at it. > > Cc: Chris Wilson > Cc: "Tang, CQ" > Cc: Tvrtko Ursulin >

[Intel-gfx] [PULL] drm-intel-next

2019-11-01 Thread Joonas Lahtinen
block definition Janusz Krzysztofik (2): drm/i915: Fix i915_inject_load_error() name to read *_probe_* drm/i915: Rename "inject_load_failure" module parameter Joonas Lahtinen (2): drm/i915: Update DRIVER_DATE to 20191101 drm/i915: Update DRIVER_DATE to 20191101

Re: [Intel-gfx] [PATCH RESEND 6/8] drm/print: convert debug category macros into an enum

2019-10-29 Thread Joonas Lahtinen
drm_debug_category { > + /** > +* @DRM_UT_CORE: Used in the generic drm code: drm_ioctl.c, drm_mm.c, > +* drm_memory.c, ... > +*/ > + DRM_UT_CORE = 0x01, While here, why not BIT() Reviewed-by: Joonas Lahtinen Regards, Joonas ___

Re: [Intel-gfx] [PATCH tip/core/rcu 03/10] drivers/gpu: Replace rcu_swap_protected() with rcu_replace()

2019-10-28 Thread Joonas Lahtinen
https://lore.kernel.org/lkml/CAHk-=wiAsJLw1egFEE=z7-ggtm6wcvtyytxza1+bhqta4gg...@mail.gmail.com/ > Reported-by: Linus Torvalds > [ paulmck: From rcu_replace() to rcu_replace_pointer() per Ingo Molnar. ] > Signed-off-by: Paul E. McKenney > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Simply walk back along request timeline on reset

2019-10-28 Thread Joonas Lahtinen
ctive = rq; > struct list_head *list; > > - if (!i915_request_is_active(rq)) /* unwound, but incomplete! */ > - return rq; > - Especially now with the above removed, the fact that we're only really interested in the timeline becomes bit obscure. Passi

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Check a few more fixed locations within the context image

2019-10-28 Thread Joonas Lahtinen
CTX_RING_TAIL - 1, > + "RING_TAIL" > + }, Quite repetitive. If you are not looking to add dissimilar patterns, could use a #define, but up to you. Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Adjust the location of RING_MI_MODE in the context image

2019-10-28 Thread Joonas Lahtinen
Cc: Mika Kuoppala Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 01/11] drm/i915/gem: Make context persistence optional

2019-10-25 Thread Joonas Lahtinen
sers who have been instructed to disable the hanghceck in the past. A couple of comments below. But anyway, with the uAPI comment and commit message clarified this is: Reviewed-by: Joonas Lahtinen Still needs the Link:, though. > Testcase: igt/gem_ctx_persistence > Signed-off-by: Chris

[Intel-gfx] [PULL] drm-intel-next

2019-10-21 Thread Joonas Lahtinen
GMP register size for GEN11 drm/i915/dp: Program an Infoframe SDP Header and DB for HDR Static Metadata drm/i915/dp: Attach HDR metadata property to DP connector James Ausmus (2): drm/i915: Move SAGV block time to dev_priv drm/i915/tgl: Read SAGV block time from PCODE Ja

[Intel-gfx] [PULL] drm-intel-next

2019-10-07 Thread Joonas Lahtinen
ntel_vga.[ch] drm/i915: use DRM_ERROR() instead of drm_err() drm/i915: use DRM_DEBUG_KMS() instead of drm_dbg(DRM_UT_KMS, ...) drm/i915/dp: remove static variable for aux last status drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() drm/i915: split

Re: [Intel-gfx] [Bug 205065] New: workqueue: PF_MEMALLOC task 173(kswapd0) is flushing !WQ_MEM_RECLAIM events:gen6_pm_rps_work [i915]

2019-10-02 Thread Joonas Lahtinen
+ Chris and Tvrtko Quoting Andrew Morton (2019-10-03 00:57:21) > > (switched to email. Please respond via emailed reply-to-all, not via the > bugzilla web interface). > > On Tue, 01 Oct 2019 17:06:35 + bugzilla-dae...@bugzilla.kernel.org wrote: > > > https://bugzilla.kernel.org/show_bug.cg

Re: [Intel-gfx] [PATCH 19/27] drm/i915: Replace hangcheck by heartbeats

2019-09-27 Thread Joonas Lahtinen
other users. > > v2: Couple in sysfs controls > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Tvrtko Ursulin > Cc: Jon Bloomfield > Reviewed-by: Jon Bloomfield > +++ b/drivers/gpu/drm/i915/Kconfig.profile > @@ -37,3 +37,14 @@ config DRM_I

Re: [Intel-gfx] [PATCH v3 00/37] Introduce memory region concept (including device local memory)

2019-09-12 Thread Joonas Lahtinen
Quoting Dave Airlie (2019-08-13 22:20:52) > On Sat, 10 Aug 2019 at 08:26, Matthew Auld wrote: > > > > In preparation for upcoming devices with device local memory, introduce the > > concept of different memory regions, and a simple buddy allocator to manage > > them in i915. > > > > One of the con

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add sysfs interface to control class-of-service

2019-09-09 Thread Joonas Lahtinen
Quoting Prathap Kumar Valsan (2019-08-26 01:48:01) > To provide shared last-level-cache isolation to cpu workloads running > concurrently with gpu workloads, the gpu allocation of cache lines needs > to be restricted to certain ways. Currently GPU hardware supports four > class-of-service(CLOS) lev

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Remove unused __engines_name()

2019-09-02 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-09-01 14:04:31) > This function was never used and probably will never be used, so remove > it. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing li

Re: [Intel-gfx] [PATCH] drm/i915: add plural() helper for logging plurals

2019-09-02 Thread Joonas Lahtinen
Quoting Jani Nikula (2019-09-02 21:29:16) > Add a helper instead of open coding the plurals in debug logs. Also > fixes the case for "0 display pipes available." > > Signed-off-by: Jani Nikula > > --- > > I stumbled upon the pipes one while working on ->num_pipes. I honestly > thought we'd have

[Intel-gfx] [PATCH] drm/i915: Document locking guidelines

2019-08-30 Thread Joonas Lahtinen
To ensure cross-driver locking compatibility, document the expected guidelines for implementing the GEM locking in i915. Note that this is a description of how things should end up after being reworked, and does not reflect the current state of things. Signed-off-by: Joonas Lahtinen Signed-off

[Intel-gfx] [PATCH 1/2] drm/i915: Remove link to missing "Batchbuffer Pools" documentation

2019-08-30 Thread Joonas Lahtinen
The referenced documentation section has been removed. Remove the link to avoid warning when building the documentation. Signed-off-by: Joonas Lahtinen Cc: Chris Wilson Cc: Matthew Auld --- Documentation/gpu/i915.rst | 9 - 1 file changed, 9 deletions(-) diff --git a/Documentation

[Intel-gfx] [PATCH 2/2] drm/i915: Indent GuC/WOPCM documentation sections

2019-08-30 Thread Joonas Lahtinen
Indent GuC/WOPCM documentation correctly to reside under "Memory Management and Command Submission" section to avoid it escaping to the upper level navigation. Signed-off-by: Joonas Lahtinen Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris Wilson --- Documentation/gpu/i91

Re: [Intel-gfx] [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c

2019-08-22 Thread Joonas Lahtinen
m-intel-next-queued") > Signed-off-by: Chris Wilson > Cc: Rodrigo Vivi Acked-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 33/39] drm/i915/perf: add a parameter to control the size of OA buffer

2019-08-22 Thread Joonas Lahtinen
o be available > through the i915 perf stream, we can set the OA buffer to the minimum > size to avoid consuming memory which won't be used by the driver. > > Cc: Joonas Lahtinen > Cc: Matthew Auld > Signed-off-by: Lionel Landwerlin > Signed-off-by: Lucas De

Re: [Intel-gfx] [igt-dev] [RFC PATCH 2/4] lib/i915/intel_memory_region: Add lib to manage memory regions

2019-08-14 Thread Joonas Lahtinen
+ Abdiel/intel-gfx Quoting Joonas Lahtinen (2019-08-14 15:46:01) > Quoting Chris Wilson (2019-08-14 13:31:10) > > Quoting Lukasz Kalamarz (2019-08-14 11:21:38) > > > +/** > > > + * gem_get_page_size: > > > + * @fd: open i915 drm file descriptor > > &

Re: [Intel-gfx] [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0

2019-08-14 Thread Joonas Lahtinen
Quoting dong.y...@intel.com (2019-08-14 10:54:05) > From: "Yang, Dong" > > Broxton steppings starting from GT E0 have fixed the bug, remove > WA since stepping GT E0. > > v2: add comment in code, by: > Joonas Lahtinen I didn't suggest any comments, I sugges

Re: [Intel-gfx] [PATCH] drm/i915: Serialise read/write of the barrier's engine

2019-08-14 Thread Joonas Lahtinen
r in llist_del_all(). > > Fixes: d8af05ff38ae ("drm/i915: Allow sharing the idle-barrier from other > kernel requests") > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists

Re: [Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E0

2019-08-14 Thread Joonas Lahtinen
Quoting Dong Yang (2019-08-14 03:44:48) > From: "Yang, Dong" > > Broxton steppings starting from GT E0 have fixed the bug, remove > WA since stepping GT E0. In i915 patches, we keep a changelog of what was changed compared to the previous iteration (see git log drivers/gpu/drm/i915 for example)

Re: [Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E

2019-08-14 Thread Joonas Lahtinen
Quoting Yang, Dong (2019-08-14 03:43:44) > comments updated, please review again. You seem to have missed the comments to the code itself. Regards, Joonas > > -Original Message- > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] > Sent: Tuesday, August 1

Re: [Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E

2019-08-13 Thread Joonas Lahtinen
Quoting Dong Yang (2019-08-12 05:36:16) > From: "Yang, Dong" > > The APL already fixed this bug since GT E, bug exist from > 0 to D, apply WA according GT stepping. "Broxton steppings starting from E0 have fixed the bug." > Signed-off-by: Yang, Dong You probably want to use "" here too. Or ju

Re: [Intel-gfx] [PATCH] drm/i915: Generalise BSD default selection

2019-08-09 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-08-09 11:38:20) > For the default I915_EXEC_BSD round robin selector, it may select any > available VCS engine. Make it so. > > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen We most likely want to share the code to count

Re: [Intel-gfx] [PATCH] drm/i915: Check for a second VCS engine more carefully

2019-08-09 Thread Joonas Lahtinen
15)->engine_mask >> VCS0) & > +(BIT(I915_MAX_VCS) - 1)) > 1) { /* silly abi is abi */ This is definitely not a hot path, so how about something like: hweight64(INTEL_INFO(i915)->engine_mask & GENMASK_ULL(

Re: [Intel-gfx] [PATCH] drm/i915: Replace global bsd_dispatch_index with random seed

2019-08-09 Thread Joonas Lahtinen
nce could be added about the test scenario. > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.fr

Re: [Intel-gfx] [PATCH 06/34] drm/i915: convert put_page() to put_user_page*()

2019-08-02 Thread Joonas Lahtinen
Quoting john.hubb...@gmail.com (2019-08-02 05:19:37) > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in

Re: [Intel-gfx] [PATCH v2] drm/i915/uc: Don't fail on HuC firmware failure

2019-07-30 Thread Joonas Lahtinen
Quoting Michal Wajdeczko (2019-07-29 14:26:12) > HuC is usually not a critical component, so we can safely ignore > firmware load or authentication failures unless HuC was explicitly > requested by the user. Do we have the fault injection and respective IGT patches somewhere? Regards, Joonas

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-29 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-07-29 12:45:52) > Quoting Joonas Lahtinen (2019-07-29 10:26:47) > > Ok, so just confirming here. The plan is still to have userspace set a > > per context (or per request) time limit for expected completion of a > > request. This will be useful fo

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-29 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-07-27 01:27:02) > Quoting Bloomfield, Jon (2019-07-26 23:19:38) > > Hmmn. We're still on orthogonal perspectives as far as our previous > > arguments stand. But it doesn't matter because while thinking through your > > replies, I realized there is one argument in favour

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Flush stale cachelines on set-cache-level

2019-07-19 Thread Joonas Lahtinen
y: Chris Wilson > Cc: Joonas Lahtinen > Cc: sta...@vger.kernel.org Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Flush all user surfaces prior to first use

2019-07-19 Thread Joonas Lahtinen
n > Cc: Joonas Lahtinen > Cc: stablevger.kernel.org Makes sense. If there is some platform where this absolutely can't happen and they need optimization, we can special case later. Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-

Re: [Intel-gfx] [PATCH 0/2] Revert GuC by default

2019-07-19 Thread Joonas Lahtinen
Acked-by: Joonas Lahtinen Regards, Joonas Quoting Tvrtko Ursulin (2019-07-19 12:48:43) > From: Tvrtko Ursulin > > It seems absence of GuC fimrware breaks the boot in a bad way: > > https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/? > https://intel-gfx-ci.01.org/tree/d

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

2019-07-12 Thread Joonas Lahtinen
y on Gen11+ platforms as HuC firmware is required to unlock > advanced video codecs in media driver. > > Legacy platforms with GuC/HuC are not affected by this change > as for them driver still defaults to disabled(0) in auto mode. > > Signed-off-by: Michal Wajdeczko > Cc:

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Don't enable GuC/HuC in auto mode on pre-Gen11

2019-07-12 Thread Joonas Lahtinen
le GuC/HuC on these > old platforms using explicit "enable_guc=2" modparam. > > Signed-off-by: Michal Wajdeczko > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Chris Wilson > Cc: Daniele Ceraolo Spurio Reviewed-by: Joonas Lahtinen Regards, J

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915: Introduce private PAT management"

2019-07-12 Thread Joonas Lahtinen
_ppat_get / intel_ppat_put never materialized. > > > > Time to remove it! > > > > v2: Unbreak suspend (Chris) > > v3: Rebase, drop fixes tag to avoid confusion > > > > Signed-off-by: MichaƂ Winiarski > > Cc: Chris Wilson > > Cc: Joonas Lahti

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915: Rename functions to match their entry points

2019-07-12 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-07-11 10:40:02) > Quoting Janusz Krzysztofik (2019-07-11 08:31:52) > > Need for this was identified while working on split of driver unbind > > path into _remove() and _release() parts. Consistency in function > > naming has been recognized as helpful when trying to work

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: Propagate "_remove" function name suffix down

2019-07-12 Thread Joonas Lahtinen
or "_driver_remove" > suffixes for better code readability. > > Signed-off-by: Janusz Krzysztofik Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 5/5] drm/i915: Propagate "_probe" function name suffix down

2019-07-12 Thread Joonas Lahtinen
> > Signed-off-by: Janusz Krzysztofik Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Propagate "_release" function name suffix down

2019-07-12 Thread Joonas Lahtinen
Quoting Janusz Krzysztofik (2019-07-11 10:31:55) > Replace mixed "_fini"/"_cleanup"/"_cleanup_hw" suffixes found in names > of fucntions called from i915_driver_release() with "_release" suffix ^- typo Regards, Joonas ___ Intel-gfx mailing list Int

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Propagate "_release" function name suffix down

2019-07-12 Thread Joonas Lahtinen
ith the "_release" suffix, while names > of functions coming from other source files have been suffixed with > "_driver_release" to avoid ambiguity with other possible .release entry > points. > > v2: early_probe pairs better with late_rele

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: Replace "_load" with "_probe" consequently

2019-07-12 Thread Joonas Lahtinen
untouched. Syncing with IGT, I think we could also change the module parameter name. > Signed-off-by: Janusz Krzysztofik Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.free

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Rename "_load"/"_unload" to match PCI entry points

2019-07-12 Thread Joonas Lahtinen
ilson > Signed-off-by: Janusz Krzysztofik Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PULL] drm-intel-fixes

2019-07-10 Thread Joonas Lahtinen
Hi Dave & Daniel, Some rather important fixes that appeared after -rc6 and missed v5.2. As a PR by request of Daniel. These avoid one WARN and potential dirty pointer deref, fix a regression on saturated media loads and add missing Icelake W/As. I've manually added Cc: stable to all of them. The

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

2019-07-09 Thread Joonas Lahtinen
list what kind of tests have been run to ensure that there are no regressions, and which platforms this change affects. Regards, Joonas > Note that today GuC is only used for HuC authentication. > > Signed-off-by: Michal Wajdeczko > Cc: Daniele Ceraolo Spurio > Cc: Joonas Lahtine

Re: [Intel-gfx] [PULL] gvt-fixes

2019-06-06 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2019-06-05 11:49:03) > > Hi, > > More gvt fixes for 5.2-rc. This fixed one regression when enabling > debug build of i915 guest, guest ring state fix after execution > for hang check, and with two misc fixes from klocwork check. Pulled this. Thanks for the PR. Regards, Joon

[Intel-gfx] [PULL] drm-intel-fixes

2019-06-06 Thread Joonas Lahtinen
drm/i915/gvt: Fix cmd length of VEB_DI_IECP Joonas Lahtinen (2): Merge tag 'gvt-fixes-2019-05-30' of https://github.com/intel/gvt-linux into drm-intel-fixes Merge tag 'gvt-fixes-2019-06-05' of https://github.com/intel/gvt-linux into drm-intel-fixes Tina Zh

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use unchecked unccore writes to flush the GTT

2019-06-04 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-05-31 19:11:30) > As the GTT is outside of the powerwell, we can simplify flushing the > GGTT writes by using an unchecked mmio write and post. > > Signed-off-by: Chris Wilson Ditto for s/unc/uncore/ Reviewed-by: Joonas Lahtinen Reg

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Use unchecked writes for setting up the fences

2019-06-04 Thread Joonas Lahtinen
ntime and is superfluous! > > In the process, retire the I915_WRITE() implicit macro with the new > intel_uncore_write interface. > > Signed-off-by: Chris Wilson I think 'uncore' isn't too long to write fully. Assuming I noticed all the code changes from the renames,

Re: [Intel-gfx] [PATCH 1/3] drm/i915/selftests: Flush partial-tiling object once

2019-06-04 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-05-31 19:11:28) > We only need to flush the object once prior to starting the partial > tiling test as inside the test we explicitly maintain coherency. > > Signed-off-by: Chris Wilson Checks out. Reviewed-by: Joonas Lahtinen Reg

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Replace struct_mutex serialisation for allocation

2019-06-04 Thread Joonas Lahtinen
); This seems to be lost, and it's definitely a valid check, still. With that retained, this is: Reviewed-by: Joonas Lahtinen Operations *_ppgtt_set_* + atomic_inc(used_*) and *_ppgtt_set_*(scratch) + atomic_dec() appear repetitive, but as they're for each differen

[Intel-gfx] [PULL] drm-intel-fixes

2019-06-03 Thread Joonas Lahtinen
n Xu (3): drm/i915/gvt: Update force-to-nonpriv register whitelist drm/i915/gvt: Fix GFX_MODE handling drm/i915/gvt: Fix vGPU CSFE_CHICKEN1_REG mmio handler Gao, Fred (1): drm/i915/gvt: Fix cmd length of VEB_DI_IECP Joonas Lahtinen (1): Merge tag 'gvt-fixes-2019

Re: [Intel-gfx] [PATCH 3/3] drm/i915/huc: Update HuC status codes

2019-05-31 Thread Joonas Lahtinen
Quoting Michal Wajdeczko (2019-05-23 01:25:00) > On Wed, 22 May 2019 22:19:47 +0200, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2019-05-22 20:00:57) > >> Without breaking existing usage, slightly update HuC status codes > >> to provide more info to the clients: > >> 1 if HuC firmwar

Re: [Intel-gfx] [PATCH] drm/i915: add force_probe module parameter to replace alpha_support

2019-05-31 Thread Joonas Lahtinen
ely, let the two coexist > for a while, with a deprecation message, for a transition period. > > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Signed-off-by: Jani Nikula Definitely in favor of this: Acked-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 12/22] gpu: i915.rst: Fix references to renamed files

2019-05-31 Thread Joonas Lahtinen
Quoting Mauro Carvalho Chehab (2019-05-30 02:23:43) > WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function > Hardware workarounds ./drivers/gpu/drm/i915/intel_workarounds.c' failed with > return code 1 > WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function >

Re: [Intel-gfx] [PULL] gvt-fixes

2019-05-31 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2019-05-30 06:41:37) > Sorry about that! Missed that.. Please check regenerated one below. > And I've dropped one commit for guest ring state update which had got > more thought that should be reworked. Pulled now. Thanks for the PR. Regards, Joonas __

Re: [Intel-gfx] [PATCH] drm/i915: Always enable mmio debugging for CI

2019-05-31 Thread Joonas Lahtinen
,12 @@ struct drm_printer; > #define ENABLE_GUC_SUBMISSION BIT(0) > #define ENABLE_GUC_LOAD_HUCBIT(1) > > +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO) > +#define MMIO_DEBUG_DFL -1 > +#else > +#define MMIO_DEBUG_DFL 0 > +#endif Jus

Re: [Intel-gfx] [PATCH] drm/i915: Drop non-NULL llist_for_each_entry_safe check for

2019-05-31 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-05-30 11:23:58) > Since the next entry is an offset from a pointer, it can not be NULL. > For simplicity, drop the extra conditional before calling cond_resched() > > Reported-by: Dan Carpenter > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lah

Re: [Intel-gfx] [PULL] gvt-fixes

2019-05-29 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2019-05-29 12:06:08) > > Hi, > > Here's more gvt fixes for 5.2. This includes fixes for recently > seen arbitrary DMA map fault with sane gtt entry initialization, > and several enforcement fixes for e.g ggtt range validation, some > mode register handler and one cmd length f

Re: [Intel-gfx] [PATCH v4 02/22] drm/i915/guc: Don't allow GuC submission

2019-05-27 Thread Joonas Lahtinen
rted configuration "enable_guc=3" or "enable_guc=1" clear > GuC submission bit. > > v2: force switch to non-GuC submission mode > > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: Daniele Ceraolo Sp

Re: [Intel-gfx] [PATCH v4 01/22] drm/i915/guc: Change platform default GuC mode

2019-05-27 Thread Joonas Lahtinen
tion is needed to enable all media codecs on the hardware. > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: Daniele Ceraolo Spurio > Cc: John Spotswood > Cc: Vinay Belgaumkar > Cc: Tony Ye > Cc: Anusha Srivatsa &

Re: [Intel-gfx] [PATCH v2] drm/i915/huc: Don't try to check HuC status if it's not loaded

2019-05-24 Thread Joonas Lahtinen
Quoting Ye, Tony (2019-05-22 14:32:41) > From UMD perspective, when HuC is not working as expected, usually we > look into the kernel log and i915_huc_load_status debugfs to find out > why it's not working. It will be helpful to know the reason of the > failure from the error code. The typicall

[Intel-gfx] [PULL] drm-intel-fixes

2019-05-23 Thread Joonas Lahtinen
by_guest_entry() Joonas Lahtinen (1): Merge tag 'gvt-fixes-2019-05-21' of https://github.com/intel/gvt-linux into drm-intel-fixes Weinan (1): drm/i915/gvt: emit init breadcrumb for gvt request Yan Zhao (4): drm/i915/gvt: use cmd to restore in-context mmios to hw for gen9 pla

[Intel-gfx] Comments in Fixes: line (Was: Re: linux-next: Fixes tag needs some work in the drm-intel tree)

2019-05-21 Thread Joonas Lahtinen
We also have an incoming patch where the Fixes: line has a comment in it. Does your tooling account for this when checking the Fixes: line? Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/l

Re: [Intel-gfx] linux-next: Fixes tag needs some work in the drm-intel tree

2019-05-21 Thread Joonas Lahtinen
Quoting Stephen Rothwell (2019-05-20 15:15:38) > Hi all, > > In commit > > 0d90ccb70211 ("drm/i915: Delay semaphore submission until the start of the > signaler") > > Fixes tag > > Fixes: e88619646971 ("drm/i915: Use HW semaphores for inter-engine synchroni > > has these problem(s): > >

Re: [Intel-gfx] [PULL] gvt-fixes

2019-05-21 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2019-05-21 09:24:08) > > Hi, > > Here's gvt-fixes for 5.2-rc. It contains vgpu reset fix with > proper timeline handling, fixes for guest TRTT setting which > should be handled in context state instead of pushing directly > to hardware and one error return fix. This is now p

[Intel-gfx] [PULL] drm-intel-next-fixes

2019-05-15 Thread Joonas Lahtinen
Hi Dave & Daniel, A fix to close a race opportunity between IRQ handler and RCU. Two fixes that are also stable, disabling FBC on GLK and HSW EDP fastset correction. These patches definitely caused conflicts when merged, resolutions should be all good. Regards, Joonas *** drm-intel-next-fixe

[Intel-gfx] [PULL] drm-intel-next-fixes

2019-05-09 Thread Joonas Lahtinen
sion until the start of the signaler drm/i915: Disable semaphore busywaits on saturated systems Colin Xu (1): drm/i915/gvt: Add in context mmio 0x20D8 to gen9 mmio list Joonas Lahtinen (1): Merge tag 'gvt-next-fixes-2019-05-07' of https://github.com/intel/gvt-linux into drm

Re: [Intel-gfx] [drm-tip:drm-tip /8] drivers/gpu/drm/i915/i915_request.c:842:1: error: redefinition of 'already_busywaiting'

2019-05-08 Thread Joonas Lahtinen
g: > 'i915_request_await_start' defined but not used [-Wunused-function] > i915_request_await_start(struct i915_request *rq, struct i915_request > *signal) > ^~~~ > > vim +/already_busywaiting +842 drivers/gpu/drm/i915/i915_request.c > > 47f4a142

Re: [Intel-gfx] [drm-tip:drm-tip 5/8] drivers/gpu/drm/i915/i915_request.c:827:1: error: redefinition of 'i915_request_await_start'

2019-05-08 Thread Joonas Lahtinen
drivers/gpu/drm/i915/i915_request.c Chris Wilson 2019-05-01 > 838 I915_FENCE_GFP); > e766fde65 drivers/gpu/drm/i915/i915_request.c Chris Wilson 2019-05-01 > 839 } > e766fde65 drivers/gpu/drm/i915/i915_request.c Chris Wilson 2019

Re: [Intel-gfx] [PULL] gvt-next-fixes

2019-05-07 Thread Joonas Lahtinen
Thanks, pulled this now. Regards, Joonas Quoting Zhenyu Wang (2019-05-07 12:05:58) > > Hi, > > Here's gvt-next-fixes for 5.2-rc, which includes one revert for BXT > regression, one missed context mmio reg after RCS renaming, sanitize > display buffer size calculation and some klocwork warning/e

[Intel-gfx] [PULL] drm-intel-next-fixes

2019-05-02 Thread Joonas Lahtinen
Hi Dave & Daniel, A quick fix to unbreak media driver, worthy inclusion before the merge window. Best Regards, Joonas *** drm-intel-next-fixes-2019-05-02: - Whitelist a register to avoid media driver from hanging The following changes since commit 879a4e70f96a26a9368a3caed2f552aa67105852:

Re: [Intel-gfx] [PATCH 19/21] drm/i915: move some leftovers to intel_pm.h from i915_drv.h

2019-04-30 Thread Joonas Lahtinen
Quoting Jani Nikula (2019-04-29 16:03:33) > On Mon, 29 Apr 2019, Chris Wilson wrote: > > Quoting Jani Nikula (2019-04-29 13:29:37) > >> Commit 696173b064c6 ("drm/i915: extract intel_pm.h from intel_drv.h") > >> missed the declarations in i915_drv.h. > > > > Fwiw, I want to pull these along with gt

[Intel-gfx] [PULL] drm-intel-next-fixes

2019-04-30 Thread Joonas Lahtinen
Hi Dave & Daniel, Just one fix to fix Icelake CSC programming (fixes loss of blue channel). Best Regards, Joonas *** drm-intel-next-fixes-2019-04-30: - Fix to Icelake CSC losing blue channel The following changes since commit 447811a686e8da7325516a78069ccfbd139ef1a7: drm/i915/icl: Fix MG_D

Re: [Intel-gfx] [PATCH v2] drm/i915/icl: Whitelist GEN9_SLICE_COMMON_ECO_CHICKEN1

2019-04-29 Thread Joonas Lahtinen
stable as Icelake is alpha_support before 5.2 With those changes this is: Reviewed-by: Joonas Lahtinen Regards, Joonas > > Signed-off-by: Tvrtko Ursulin > Cc: Lionel Landwerlin > Cc: kevin...@intel.com > Cc: xiaogang...@intel.com > --- > drivers/gpu/drm/i915/intel_w

<    1   2   3   4   5   6   7   8   9   10   >