Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Consolidate checks for engine stats availability

2017-11-29 Thread Joonas Lahtinen
(Chris Wilson) > v4: Move flag setting to intel_engines_reset_default_submission. > (Chris Wilson) > v5: Move flag setting to logical_ring_setup. > > Signed-off-by: Tvrtko Ursulin > Suggested-by: Sagar Arun Kamble > Cc: Sagar Arun Kamble > Reviewed-by: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A

2017-11-29 Thread Joonas Lahtinen
On Mon, 2017-11-27 at 13:36 +, Rantala, Valtteri wrote: > > -Original Message- > > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] > > Sent: Monday, November 27, 2017 11:13 AM > > To: Intel graphics driver community testing & development

Re: [Intel-gfx] [PATCH v2 0/3] drm/i915/guc: Update default GuC FW for SKL/BXT/KBL

2017-11-28 Thread Joonas Lahtinen
On Wed, 2017-11-29 at 11:47 +0530, Sagar Arun Kamble wrote: > With new GuC firmwares (SKL v9.33, BXT v9.29, KBL v9.39) available now > at 01.org downloads, let us update the default firmware versions. I thought the agreement was for them to be at linux-firmware repo? Regards, Joonas --

Re: [Intel-gfx] [GIT PULL] gvt fixes for 4.15-rc2

2017-11-28 Thread Joonas Lahtinen
t; drivers/gpu/drm/i915/gvt/scheduler.c | 33 +++--- > drivers/gpu/drm/i915/gvt/scheduler.h | 3 +++ > 6 files changed, 44 insertions(+), 51 deletions(-) > > -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v10 1/2] drm/i915/guc : Removing enable_guc_loading and enable_guc_submission module parameters

2017-11-28 Thread Joonas Lahtinen
Rebase > > v8: Change to NEEDS_GUC_FW (Chris) > Applying review comments (Michal) > Clarifying commit message (Joonas) > > v9: Applying review comments (Michal) > > v10: Introducing enable_guc modparam >Applying review comments (Michal) > > Signed-off-by:

[Intel-gfx] Fixes that failed to cleanly apply to v4.15-rc1

2017-11-28 Thread Joonas Lahtinen
pSegments:cnl, glk"") Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

2017-11-28 Thread Joonas Lahtinen
is doing good, not that the system is clogged in some way :) Regards, Joonas > > Any opinions? Any other ideas? > -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH igt] igt: Remove gem_ctx_basic

2017-11-28 Thread Joonas Lahtinen
trivial, it also is pointless as the test is of little merit. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gf

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Update shrinker drm_i915_private naming convention

2017-11-27 Thread Joonas Lahtinen
On Thu, 2017-11-23 at 11:53 +, Chris Wilson wrote: > Switch over from the non-descript dev_priv locals to i915. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen It's very much its own island of code anyway. Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joo

Re: [Intel-gfx] [PATCH] drm/i915: Rename i915_gem_timelines_mark_idle

2017-11-27 Thread Joonas Lahtinen
line.c:120: warning: No description found > for parameter 'i915' > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___

Re: [Intel-gfx] [PATCH] drm/i915: Record default HW state in the GPU error state

2017-11-27 Thread Joonas Lahtinen
rm_i915_gem_object *obj) > +{ > + if (obj && i915_gem_object_has_pages(obj)) { > + struct i915_vma vma = { fake_vma to put emphasis this is a trick? Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation __

Re: [Intel-gfx] [PATCH] drm/i915: Flush everything on switching to the kernel_context

2017-11-27 Thread Joonas Lahtinen
), having an extra layer of paranoia to ensure > everything is flushed to memory seems sensible. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning (rev2)

2017-11-27 Thread Joonas Lahtinen
u that. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags

2017-11-27 Thread Joonas Lahtinen
ds_cmd_parser(engine)) > + fini_hash_table(engine); Just keep the previous code flow. Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@li

Re: [Intel-gfx] [PATCH 1/9] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-11-27 Thread Joonas Lahtinen
On Fri, 2017-11-24 at 22:05 +, Chris Wilson wrote: > Quoting Matthew Auld (2017-11-24 21:29:22) > > From: Joonas Lahtinen > > > > In preparation for upcoming SKUs, allow more freedom in placement > > of the Intel graphics stolen memory by BIOS to full 64bit ran

[Intel-gfx] [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A

2017-11-27 Thread Joonas Lahtinen
about GPU bandwidths (Eero) - s/deny/never/ because that's why (Chris) Reported-by: Valtteri Rantala Fixes: b901bb89324a ("drm/i915/gemfs: enable THP") Signed-off-by: Joonas Lahtinen Cc: Matthew Auld Cc: Chris Wilson Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Valtteri Rantala Cc

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rename shrinker init/cleanup to match driver initialisation phase

2017-11-27 Thread Joonas Lahtinen
On Thu, 2017-11-23 at 11:53 +, Chris Wilson wrote: > Since the shrinker is registered and unregistered during > i915_driver_register and i915_driver_unregister, respectively, rename > the init/cleanup functions to match. > > Signed-off-by: Chris Wilson > Cc: Joonas Laht

Re: [Intel-gfx] [PATCH 1/9] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-11-27 Thread Joonas Lahtinen
On Sat, 2017-11-25 at 00:48 +0100, Thomas Gleixner wrote: > On Fri, 24 Nov 2017, Matthew Auld wrote: > > > From: Joonas Lahtinen > > Please CC the linux kernel mailinglist on patches related to x86. The > MAINTAINERS file says: > > X86 ARCHITECTURE (32-BIT AND 64-BIT

[Intel-gfx] [PATCH] drm/i915: Disable THP until we have a read BW W/A

2017-11-24 Thread Joonas Lahtinen
: b901bb89324a ("drm/i915/gemfs: enable THP") Signed-off-by: Joonas Lahtinen Cc: Matthew Auld Cc: Chris Wilson Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Valtteri Rantala Cc: Eero Tamminen --- drivers/gpu/drm/i915/i915_gemfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Update header guard name of intel_guc_submission.h

2017-11-24 Thread Joonas Lahtinen
_submission.c|h) + Jani There was lately a request from Jani to not to include "Fixes:" for purely stylistical fixes. So if there's no actual functional impact, no "Fixes:". I'm still unsure if we have alternative markup agreed upon? Regards, Joonas > Signed-

Re: [Intel-gfx] [PATCH] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-11-24 Thread Joonas Lahtinen
On Fri, 2017-11-24 at 08:35 +0100, Ingo Molnar wrote: > * Joonas Lahtinen wrote: > > > In preparation for upcoming SKUs, allow more freedom in placement > > of the Intel graphics stolen memory by BIOS to full 64bit range. > > > > Signed-off-by: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 1/6] drm/i915: export the stolen region as a resource

2017-11-23 Thread Joonas Lahtinen
in i915, > however if we just export the region as a resource from early-quirks we > can nuke the duplication. > > Suggested-by: Joonas Lahtinen > Suggested-by: Chris Wilson > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Chris Wilson > Cc: Paulo Zanoni >

[Intel-gfx] [PATCH] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-11-23 Thread Joonas Lahtinen
In preparation for upcoming SKUs, allow more freedom in placement of the Intel graphics stolen memory by BIOS to full 64bit range. Signed-off-by: Joonas Lahtinen Cc: Matthew Auld Cc: Chris Wilson Cc: Paulo Zanoni Cc: Ingo Molnar Cc: H. Peter Anvin Cc: x...@kernel.org --- arch/x86/kernel

Re: [Intel-gfx] [CI 1/6] drm/printer: Add drm_vprintf()

2017-11-23 Thread Joonas Lahtinen
to drm-misc and I'll wait for the backmerge. Applied to drm-misc-next. Thanks for the patch and review. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/6] drm/i915: export the stolen region as a resource

2017-11-22 Thread Joonas Lahtinen
can nuke the duplication. > > > > Suggested-by: Joonas Lahtinen > > Suggested-by: Chris Wilson > > Signed-off-by: Matthew Auld > > Cc: Joonas Lahtinen > > Cc: Chris Wilson > > Cc: Paulo Zanoni > > Cc: Ingo Molnar > > Cc: H. Peter Anvin > > Cc:

Re: [Intel-gfx] [PATCH] drm/i915: add support for specifying DMC firmware override by module param

2017-11-22 Thread Joonas Lahtinen
; > > } else if (IS_GEMINILAKE(dev_priv)) { > > > required_version = GLK_CSR_VERSION_REQUIRED; > > > @@ -451,7 +454,9 @@ void intel_csr_ucode_init(struct drm_i915_private > > > *dev_priv) > > > if (!HAS_CSR(dev_priv)) > > > return; > > > > > > -

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Avoid drm_gem_handle_create under struct_mutex

2017-11-21 Thread Joonas Lahtinen
eful, and in particular it turns out we are not allowed to nest > dev->object_name_lock (drm_gem_handle_create) inside dev->struct_mutex. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103830 > Signed-off-by: Chris Wilson > Cc: Matthew Auld > Cc: J

Re: [Intel-gfx] [PATCH i-g-t] gem_ctx_param: Update for context priorities

2017-11-21 Thread Joonas Lahtinen
how_bug.cgi?id=103107 > Cc: Daniel Vetter > Cc: Chris Wilson > Cc: Joonas Lahtinen Looks good to me for now, we can think of further steps then. Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___

Re: [Intel-gfx] [PATCH 1/2] lib/rbtree, drm/mm: Add rbtree_replace_node_cached()

2017-11-21 Thread Joonas Lahtinen
;) > > Testcase: igt/drm_mm/replace > > Signed-off-by: Chris Wilson > > Cc: Davidlohr Bueso > > Cc: Jérôme Glisse > > Cc: Andrew Morton > > Cc: Joonas Lahtinen > > Cc: Daniel Vetter > > Thanks! > > Acked-by: Davidlohr Bueso Would you l

Re: [Intel-gfx] [PATCH 2/2] drm/selftests/mm: Add callsite indicator to common asserts

2017-11-21 Thread Joonas Lahtinen
ertion error message (a single frame stacktrace). > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Daniel Vetter Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation __

Re: [Intel-gfx] [PATCH 2/4] drm/i915/execlists: Reduce completed event mask to COMPLETE | PREEMPTED

2017-11-20 Thread Joonas Lahtinen
ents. We can move the ELEMENT_SWITCH info message > from the COMPLETED_MASK into an assertion for when we are performing a > switch to port[1]. > > Suggested-by: Joonas Lahtinen > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Tvrtko Ursulin > Cc: Joonas La

Re: [Intel-gfx] [PATCH 3/4] drm/i915/execlists: Assert that we don't get mixed IDLE_ACTIVE | COMPLETE events

2017-11-20 Thread Joonas Lahtinen
On Mon, 2017-11-20 at 12:34 +, Chris Wilson wrote: > If IDLE_ACTIVE is set, then all other bits are invalid. For us, we can > assert that if we see a COMPLETE | PREEMPTED event, then it should be > impossible for it to also contain an IDLE_ACTIVE flag. > > Suggested-by:

Re: [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Listen to COMPLETE context event not ACTIVE_IDLE

2017-11-20 Thread Joonas Lahtinen
ning > to the COMPLETE event not ACTIVE_IDLE. > v3: Update preempt completion test to also use COMPLETE not ACTIVE_IDLE. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=103800 > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Tvrtko Ursulin > Cc: Joonas

Re: [Intel-gfx] [PATCH v2] drm/i915: Initialise entry in intel_ppat_get() for older compilers

2017-11-20 Thread Joonas Lahtinen
t: Wednesday, November 15, 2017 3:17 PM > To: intel-gfx@lists.freedesktop.org > Cc: Chris Wilson ; Joonas Lahtinen > ; Wang, Zhi A ; Ville > Syrjälä > Subject: [PATCH v2] drm/i915: Initialise entry in intel_ppat_get() for older > compilers > > gcc-4.7.3 is confused by th

Re: [Intel-gfx] [PATCH 1/3] drm/i915/selftests: Increase size for mock ringbuffer

2017-11-16 Thread Joonas Lahtinen
gbuffers (mock or real) of MIN_SPACE_FOR_ADD_REQUEST. Grow the > mock ringbuffer such that we allocate a single page for the struct+buffer, > satisfying the new condition without wasting too much space. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas --

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Remove i915.semaphores modparam

2017-11-16 Thread Joonas Lahtinen
On Tue, 2017-11-14 at 21:30 +, Chris Wilson wrote: > Having disabled the broken semaphores on Sandybridge, there is no need > for a modparam any more, so remove it in favour of a simple > HAS_LEGACY_SEMAPHORES() guard. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahti

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Move debugfs/i915_semaphore_status to i915_engine_info

2017-11-16 Thread Joonas Lahtinen
On Tue, 2017-11-14 at 21:30 +, Chris Wilson wrote: > As the semaphores is just part of the engine, include it with the > general pretty printer universally used for debugging. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Jo

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Disable semaphores on Sandybridge

2017-11-16 Thread Joonas Lahtinen
771us per cycle [expected > 4.923us] > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54226 > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Acked-by: Mika Kuoppala Might be worth mentioning that the bug casually has 110 duplicates... Reviewed-by: Joonas Lahtine

Re: [Intel-gfx] [PATCH] drm/i915: Clear breadcrumb node when cancelling signaling

2017-11-16 Thread Joonas Lahtinen
mb wait queue could only be done on behalf of i915_wait_request, > so this race could not happen). > > Reported-by: "He, Bo" > Fixes: 9eb143bbec7d ("drm/i915: Allow a request to be cancelled") > Signed-off-by: Chris Wilson > Cc: "He, Bo" > Cc:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove temporary allocation of dma addresses when rotating

2017-11-16 Thread Joonas Lahtinen
Matthew Auld > Cc: Joonas Lahtinen > Cc: Tvrtko Ursulin > @@ -3665,27 +3665,32 @@ void i915_gem_restore_gtt_mappings(struct > drm_i915_private *dev_priv) > } > > static struct scatterlist * > -rotate_pages(const dma_addr_t *in, unsigned int offset, > -

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Drop the unbound page cache upon idling

2017-11-16 Thread Joonas Lahtinen
on > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v4] drm/i915: Object w/o backing stroage is banned by -ENXIO

2017-11-13 Thread Joonas Lahtinen
Introduce GEM proxy" patch-set. (Joonas) > > v2: > - update the patch description and subject to just mention objects w/o > backing storage, instead of "GEM proxy". (Joonas) > > Signed-off-by: Tina Zhang > Reviewed-by: Chris Wilson v1 Reviewed-by: Joonas L

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Reduce the volume of the timeout message

2017-11-10 Thread Joonas Lahtinen
cessitates a warning, but to be expected. > > Signed-off-by: Chris Wilson > Cc: Matthew Auld > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation __

Re: [Intel-gfx] [RFC 0/3] GuC functions name/prototype update

2017-11-10 Thread Joonas Lahtinen
ernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/i915_guc_submission.c i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/i915_guc_submission.c i915.rst:.. kernel-

Re: [Intel-gfx] [PATCH 1/4] drm/i915: introduce query info uAPI

2017-11-09 Thread Joonas Lahtinen
v4: > * Made user_class_map static. > > v5: > * Example usage added to commit msg. (Chris Wilson) > * Report engine count in case of version mismatch. (Chris Wilson) > > v6: > * Return API to query_info to make it more generic (Lionel) > * Add query ID & que

Re: [Intel-gfx] [PATCH] drm/i915: Mark up i915_vma_unbind() as a potential sleeper

2017-11-09 Thread Joonas Lahtinen
ways implies a sleep, so mark it up with a > might_sleep(). > > Suggested-by: Tvrtko Ursulin > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen > Cc: Matthew Auld > Cc: Daniel Vetter > +++ b/drivers/gpu/drm/i915/i915_vma.c > @@ -74

Re: [Intel-gfx] [PATCH v2] drm/i915: Use trace_printk to provide a death rattle for GEM

2017-11-09 Thread Joonas Lahtinen
: > bcs0 out: ctx=4, seqno=168 > [ 72.201526] gem_conc-10661..s1 72117548us : intel_lrc_irq_handler: > bcs0 csb[1/2]: status=0x8002 > [ 72.201570] gem_conc-10661..s1 72117548us : intel_lrc_irq_handler: > bcs0 out: ctx=4, seqno=168 > [ 72.201578] -------

Re: [Intel-gfx] [PATCH] drm/i915: Prune the reservation shared fence array

2017-11-08 Thread Joonas Lahtinen
racking into a common > struct reservation_object") > Fixes: 80b204bce8f2 ("drm/i915: Enable multiple timelines") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > +++ b/drivers/gpu/drm/i915/i915_vma.c > @@ -54,6 +54,13 @@ i915_vma_retire(struct i915_gem_acti

Re: [Intel-gfx] [PATCH v2] drm/i915: Idle the GPU before shinking everything

2017-11-08 Thread Joonas Lahtinen
shrinker as it only uses ordinary allocations. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=102936 > Fixes: f2123818ffad ("drm/i915: Move dev_priv->mm.[un]bound_list to its own > lock") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen R

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Add WaVFEStateAfterPipeControlwithMediaStateClear

2017-11-08 Thread Joonas Lahtinen
> > + return ret; > > What is for exactly? This register is not context saved, so... > -Chris > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Include intel_engine_is_idle() status in engine pretty-printer

2017-11-08 Thread Joonas Lahtinen
quot;Idle? %s\n", yesno(intel_engine_is_idle(engine))); Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Save all MMIO WAs and apply them at a later time

2017-11-08 Thread Joonas Lahtinen
On Fri, 2017-11-03 at 15:56 -0700, Oscar Mateo wrote: > > On 10/16/2017 03:34 AM, Joonas Lahtinen wrote: > > On Fri, 2017-10-13 at 13:49 -0700, Oscar Mateo wrote: > > > On 10/12/2017 03:35 AM, Joonas Lahtinen wrote: > > > > On Wed, 2017-10-11 at 11:15 -0700, Osca

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: Add Guc/HuC firmware details to error state

2017-11-08 Thread Joonas Lahtinen
of custom paths (Chris) > > v4: improve 'why' comment (Joonas) > > trim output if no fw path (Michal) > > group code around uc error state (Michal) > > v5: use error in cleanup_uc (Michal) > > > > Suggested-by: Chris Wilson > > Signed-off-by: Mic

Re: [Intel-gfx] [PATCH] drm/selftests/mm: Insert cond_resched() between insert modes

2017-11-07 Thread Joonas Lahtinen
On Tue, 2017-11-07 at 14:51 +0200, Joonas Lahtinen wrote: > On Tue, 2017-11-07 at 10:41 +, Chris Wilson wrote: > > kbuilder has begun running the selftests and reported a soft-lockup > > inside __igt_insert(), so break up the test loop over different > > modes >

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Introduce GEM proxy

2017-11-07 Thread Joonas Lahtinen
On Tue, 2017-11-07 at 04:53 +, Zhang, Tina wrote: > > -Original Message- > > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > > Behalf Of Joonas Lahtinen > > Sent: Monday, November 6, 2017 7:24 PM > > To: Zhang, Tina ; zhen

Re: [Intel-gfx] [PATCH] drm/selftests/mm: Insert cond_resched() between insert modes

2017-11-07 Thread Joonas Lahtinen
f-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915: implemented dynamic WOPCM partition.

2017-11-07 Thread Joonas Lahtinen
about the i915 coding style conventions, it'll more efficient to go through rest of the code in more interactive manner for a better learning experience. We should try to avoid making even the simplest operations a function call (especially one that is not inline). And as far as I und

Re: [Intel-gfx] [RFC PATCH 02/20] drm/i915: Move a bunch of workaround-related code to its own file

2017-11-06 Thread Joonas Lahtinen
before we get the > universal solution? Nope, I was actually going to suggest getting the first patches merged first. Then it'll then be easier to spin RFCs. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _

Re: [Intel-gfx] [RFC PATCH 04/20] drm/i915: Transform context WAs into static tables

2017-11-06 Thread Joonas Lahtinen
wever that some amount is caching is needed for those things > that are dynamic (e.g. things that need some calculation, or have > a criteria different than the more obvious GEN + stepping). > > Also, this makes very explicit which WAs live in the context. > > Suggested-by: Joona

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Introduce GEM proxy

2017-11-06 Thread Joonas Lahtinen
> i915_gem_set_tiling_ioctl > i915_gem_madvise_ioctl > > Signed-off-by: Tina Zhang > Reviewed-by: Joonas Lahtinen > Reviewed-by: Chris Wilson > Cc: Daniel Vetter > @@ -1649,6 +1659,10 @@ i915_gem_sw_finish_ioctl(struct drm_device *dev, void > *data, >

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Object w/o backing stroage is banned by -ENXIO

2017-11-06 Thread Joonas Lahtinen
ned from changing > backing storage of objects without backing storage. > > v2: > - update the patch description and subject to just mention objects w/o > backing storage, instead of "GEM proxy". (Joonas) > > Signed-off-by: Tina Zhang > Reviewed-by: Chris Wilson >

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Hide dangerous tests

2017-11-06 Thread Joonas Lahtinen
> References: https://bugs.freedesktop.org/show_bug.cgi?id=103453 > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx m

[Intel-gfx] Patch tag ordering (Was: Re: [PATCH v5 2/5] drm/i915/guc : Removing i915_modparams.enable_guc_loading module)

2017-11-06 Thread Joonas Lahtinen
+ Jani (and Daniel as emeritus maintainer) On Fri, 2017-11-03 at 10:08 -0700, Rodrigo Vivi wrote: > On Fri, Nov 03, 2017 at 08:36:01AM +0000, Joonas Lahtinen wrote: > > On Fri, 2017-11-03 at 00:03 +, Chris Wilson wrote: > > > Quoting Rodrigo Vivi (2017-11-02 23:52:45) >

Re: [Intel-gfx] [PATCH v8 2/6] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-11-03 Thread Joonas Lahtinen
On Fri, 2017-11-03 at 12:33 +0200, Jani Nikula wrote: > On Fri, 03 Nov 2017, Joonas Lahtinen wrote: > > On Thu, 2017-11-02 at 09:34 -0700, Sujaritha wrote: > > > > > > On 10/25/2017 08:26 AM, Michal Wajdeczko wrote: > > > > On Tue, 24 Oct 2017 19:21:21 +020

Re: [Intel-gfx] [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-11-03 Thread Joonas Lahtinen
2017 at 10:31 AM, Kenneth Graunke > wrote: > > On Wednesday, October 25, 2017 7:33:41 AM PDT Jason Ekstrand wrote: > > > On October 25, 2017 06:05:16 Joonas Lahtinen wrote: > > [snip] > > > > There indeed seems to be quite a lot of missing registers from the i915

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Stop caching the "golden" renderstate

2017-11-03 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 16:34 -0700, Rodrigo Vivi wrote: > On Thu, Nov 02, 2017 at 10:36:26PM +, Oscar Mateo wrote: > > > > > > On 11/02/2017 07:56 AM, Joonas Lahtinen wrote: > > > On Thu, 2017-11-02 at 07:54 -0700, Rodrigo Vivi wrote: > > > > On Thu

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915/guc : Removing i915_modparams.enable_guc_loading module

2017-11-03 Thread Joonas Lahtinen
On Fri, 2017-11-03 at 00:03 +, Chris Wilson wrote: > Quoting Rodrigo Vivi (2017-11-02 23:52:45) > > On Wed, Oct 4, 2017 at 6:07 AM, Joonas Lahtinen > > wrote: > > > On Tue, 2017-10-03 at 15:56 -0700, Sujaritha Sundaresan wrote: > > > > We currently have tw

Re: [Intel-gfx] [PATCH v8 2/6] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-11-03 Thread Joonas Lahtinen
rstanding is that we got three cases: 1. Load and use GuC, HuC goes on the side 2. Load GuC, just to get HuC 3. Don't load GuC at all Which could be mapped to .enable_guc: -1 = default (driver does as sees fit) 0 = no GuC, no nothing 1 = load and use GuC, HuC comes on the side 2 = Load GuC

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-11-02 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 07:47 -0700, Rodrigo Vivi wrote: > On Thu, Nov 02, 2017 at 08:06:29AM +, Jani Nikula wrote: > > On Wed, 01 Nov 2017, Rodrigo Vivi wrote: > > > On Wed, Nov 01, 2017 at 04:21:08PM +, Ben Widawsky wrote: > > > > On 17-11-01 1

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Stop caching the "golden" renderstate

2017-11-02 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 07:54 -0700, Rodrigo Vivi wrote: > On Thu, Nov 02, 2017 at 02:43:16PM +0000, Joonas Lahtinen wrote: > > On Thu, 2017-11-02 at 12:42 +, Chris Wilson wrote: > > > As we now record the default HW state and so only emit the "golden" > > &g

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Stop caching the "golden" renderstate

2017-11-02 Thread Joonas Lahtinen
gned-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Record the default hw state after reset upon load

2017-11-02 Thread Joonas Lahtinen
(defaults)) > + return PTR_ERR(defaults); > + > + memcpy(vaddr + LRC_HEADER_PAGES * PAGE_SIZE, > +defaults + LRC_HEADER_PAGES * PAGE_SIZE, Could use somethingsomething_offset variable. Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source T

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Inline intel_modeset_gem_init()

2017-11-02 Thread Joonas Lahtinen
ater. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Move GT powersaving init to i915_gem_init()

2017-11-02 Thread Joonas Lahtinen
isation into the purview of i915_gem_init(). > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.fre

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Force the switch to the i915->kernel_context

2017-11-02 Thread Joonas Lahtinen
hy dropping a comment that a nonexistent context is considered kernel context to the *cough*nonexistent*cough* kerneldoc. Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Remove redundant intel_autoenable_gt_powersave()

2017-11-02 Thread Joonas Lahtinen
to save > the default HW state. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://list

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-11-01 Thread Joonas Lahtinen
+ Kimmo and Paul On Wed, 2017-11-01 at 07:43 -0700, Ben Widawsky wrote: > On 17-11-01 14:07:28, Joonas Lahtinen wrote: > > On Mon, 2017-10-30 at 10:48 -0700, Rodrigo Vivi wrote: > > > On Mon, Oct 30, 2017 at 01:00:51PM +, David Weinehall wrote: > > > > On Fri, Oc

Re: [Intel-gfx] [PATCH] drm/i915: Check that the breadcrumb wasn't disarmed automatically before parking

2017-11-01 Thread Joonas Lahtinen
ob twice. Prevent this by checking that the irq > is still armed after flushing the interrupt (for the irq spinlock). > > Fixes: bcbd5c33a342 ("drm/i915/guc: Always enable the breadcrumbs irq") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Michał Winia

Re: [Intel-gfx] [resend] drm/i915: Check incoming alignment for unfenced buffers (on i915gm)

2017-11-01 Thread Joonas Lahtinen
y purpose in forcing unaligned unfenced access to be > rebound was forgotten. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103502 > Fixes: 2889caa92321 ("drm/i915: Eliminate lots of iterations over the > execobjects array") > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-11-01 Thread Joonas Lahtinen
> > > > always patch in the required setting without having to expose ourselves > > > > to random abuse. > > > > > > > > v2: Fixup NEEDS_WaRsDisableCoarsePowerGating fumble, and document the > > > > lack of ilk support better. > > &

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Save all GT WAs and apply them at a later time

2017-10-31 Thread Joonas Lahtinen
at respins that do not address the input given. Respins that ignore review are a waste of everyone's time. So, please react to the review instead of trying to brute force a series in as you see fit. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _

Re: [Intel-gfx] [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"

2017-10-31 Thread Joonas Lahtinen
i915: Add -Wall -Wextra to our build, set warnings > to full") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Jani Nikula Poor person who greps for "-Wno-", should we add comment "# -Wno-whatever" at the end of each line? Reviewed-by: Joonas Laht

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove i915.enable_execlists module parameter

2017-10-30 Thread Joonas Lahtinen
he two modes of execution is no longer > useful, so remove the debug tool. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Could use some more acks here. To me, the module parameters seem to be facing some abuse, so dropping makes sense especially as the features are not compa

Re: [Intel-gfx] [PATCH] drm/i915: Mention which driver is taking over the VGA console

2017-10-30 Thread Joonas Lahtinen
5.071879] i915 :00:02.0: [drm:i915_kick_out_vgacon] Replacing VGA > console driver > > which is a little ugly side for a user message. So just use a plain > dev_info() instead: > > [4.948501] i915 :00:02.0: Replacing VGA console driver > > Signed-off-by: Chr

Re: [Intel-gfx] [i-g-t] assembler: Fix bashism in run-test.sh

2017-10-30 Thread Joonas Lahtinen
#!/bin/bash to avoid having to babysit bashism > later. Just leave the shebang as it is, then this is; Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-10-26 Thread Joonas Lahtinen
ng to expose ourselves > to random abuse. > > v2: Fixup NEEDS_WaRsDisableCoarsePowerGating fumble, and document the > lack of ilk support better. > v3: Clear intel_info->rc6p if we don't support rc6 itself. > > Signed-off-by: Chris Wilson > Cc: Rodrigo Vivi > Cc: Joo

Re: [Intel-gfx] [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()"

2017-10-25 Thread Joonas Lahtinen
ed_fence_wake, 0); > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Acked-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedes

Re: [Intel-gfx] [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-10-25 Thread Joonas Lahtinen
ters we could quickly list, are missing"). You can see for yourself at execlists_init_reg_state() in "intel_lrc.c". So currently you can expect issues if some userspace sets fancy register values that the rest of the userspaces are not setting. We'll be providing a rework on the cont

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use same test for eviction and submitting kernel context

2017-10-25 Thread Joonas Lahtinen
believe that we are idle and keep trying to > flush the GGTT ad infinitum. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103438 > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Tvrtko Ursulin > Cc: Mika Kuoppala Reviewed-by: Joonas Lahtinen Regards

Re: [Intel-gfx] [PATCH v3] drm/i915/selftests: Don't try to queue a request with zero delay

2017-10-25 Thread Joonas Lahtinen
its own little function. > v3: Reorder testing so as not to immediately signal a delayed request. > > Signed-off-by: Chris Wilson > Link: > https://patchwork.freedesktop.org/patch/msgid/20171024220855.30155-1-ch...@chris-wilson.co.uk > Cc: Joonas Lahtinen Reviewed-by:

Re: [Intel-gfx] [PATCH] drm/i915: Call cond_resched() before repeating i915_gem_evict_something()

2017-10-25 Thread Joonas Lahtinen
ue in stress tests as the wait itself will normally give the chance > for the scheduler to intervene and make progress. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=103438 > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joon

[Intel-gfx] [CI] drm/i915: Disable lazy PPGTT page table optimization for vGPU

2017-10-23 Thread Joonas Lahtinen
initialize partially filled pagetables") Suggested-by: Xiaolin Zhang Signed-off-by: Xiaolin Zhang [Joonas: Rewrote the commit message and added tags.] Signed-off-by: Joonas Lahtinen Cc: Zhenyu Wang Cc: Zhi Wang Cc: Chris Wilson Cc: Matthew Auld Cc: Joonas Lahtinen Cc: Jani Nikula Cc: Rodr

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add a hook for making the engines idle (parking) and unparking

2017-10-23 Thread Joonas Lahtinen
engines_park() and provide the companion intel_engines_unpark(). > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Tvrtko Ursulin > Cc: Michał Winiarski Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technolo

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors

2017-10-20 Thread Joonas Lahtinen
ort array. > > v2: improved commit message, elsp_ready readability (Chris) > v3: s/execlist_port_index/execlist_port (Chris) > v4: rebase to new naming > v5: fix port_next indexing > > Cc: Michał Winiarski > Cc: Joonas Lahtinen > Cc: Chris Wilson > Signed-off-by: Mika

Re: [Intel-gfx] [PATCH v3] drm/i915: Add Guc/HuC firmware details to error state

2017-10-20 Thread Joonas Lahtinen
e_buf output. Also update > uc firmware pretty printer to accept const input. > > v2: don't rely on current caps (Chris) > dump correct fw info (Michal) > v3: simplify capture of custom paths (Chris) > > Suggested-by: Chris Wilson > Signed-off-by: Michal Wajdeczko

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_eio: Skip in-flight-suspend on snb

2017-10-20 Thread Joonas Lahtinen
verted as soon as we have a fix (similar to how we dealt with the > > snb-dies-in-blt-hangs issue). > > > > Cc: Joonas Lahtinen > > Cc: Chris Wilson > > Cc: "Lofstedt, Marta" > > Cc: Martin Peres > > References: > > https://

Re: [Intel-gfx] [PATCH] drm/i915: Disable lazy PPGTT page table optimization for vGPU

2017-10-20 Thread Joonas Lahtinen
Yesterday, Zhi was still looking if this could be fixed by a small modification in the GVT-g side, which would be much preferred. Zhi, What's the status there? Regards, Joonas On Thu, 2017-10-19 at 10:48 +0800, Zhenyu Wang wrote: > On 2017.10.18 13:25:43 +0300, Joonas Lahtinen wrote:

Re: [Intel-gfx] [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-10-18 Thread Joonas Lahtinen
On Wed, 2017-10-18 at 09:25 -0700, Sujaritha wrote: > > On 10/18/2017 03:58 AM, Joonas Lahtinen wrote: > > On Tue, 2017-10-17 at 15:50 -0700, Sujaritha Sundaresan wrote: > > > We currently have two module parameters that control GuC: > > > "enable_guc_

Re: [Intel-gfx] [PATCH igt 1/4] lib: Add DROP_IDLE

2017-10-18 Thread Joonas Lahtinen
On Wed, 2017-10-18 at 13:34 +0100, Chris Wilson wrote: > A new flag for an old API; now we can request that the driver flush its > idle_worker to release internal caches. > > Signed-off-by: Chris Wilson Whole series is; Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas L

Re: [Intel-gfx] [PATCH v2] drm/i915: Flush the idle-worker for debugfs/i915_drop_caches

2017-10-18 Thread Joonas Lahtinen
gh it should be used as part of a > DROP_ACTIVE | DROP_RETIRE | DROP_IDLE | DROP_FREED > sequence. > v3: Convert to BIT() to sell it to Joonas. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=102655 > Signed-off-by: Chris Wilson > Cc: Joon

<    5   6   7   8   9   10   11   12   13   14   >