Re: [Intel-gfx] [PATCH] drm/atomic: document and enforce rules around "spurious" EBUSY

On Wed, Sep 23, 2020 at 05:18:52PM +0200, Daniel Vetter wrote: > When doing an atomic modeset with ALLOW_MODESET drivers are allowed to > pull in arbitrary other resources, including CRTCs (e.g. when > reconfiguring global resources). > > But in nonblocking mode userspace has then no idea this

Re: [Intel-gfx] [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

On Wed, Sep 23, 2020 at 01:16:42PM +0200, Daniel Vetter wrote: > On Wed, Sep 23, 2020 at 1:14 PM Marius Vlad wrote: > > > > On Wed, Sep 23, 2020 at 12:58:30PM +0200, Daniel Vetter wrote: > > > On Tue, Sep 22, 2020 at 3:36 PM Marius Vlad > > > wrote: > > &g

Re: [Intel-gfx] [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

On Wed, Sep 23, 2020 at 12:58:30PM +0200, Daniel Vetter wrote: > On Tue, Sep 22, 2020 at 3:36 PM Marius Vlad wrote: > > > > On Fri, Jan 31, 2020 at 07:34:00AM +, Daniel Stone wrote: > > > On Thu, 5 Jul 2018 at 11:21, Daniel Vetter wrote: > > &g

Re: [Intel-gfx] [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

On Fri, Jan 31, 2020 at 07:34:00AM +, Daniel Stone wrote: > On Thu, 5 Jul 2018 at 11:21, Daniel Vetter wrote: > > When doing an atomic modeset with ALLOW_MODESET drivers are allowed to > > pull in arbitrary other resources, including CRTCs (e.g. when > > reconfiguring global resources). > > >

[Intel-gfx] [PATCH 4/4] drm/i915: Register GEM ioctls directly in i915_gem file.

From: Marius Vlad <marius.vl...@gmail.com> Signed-off-by: Marius Vlad <marius.vl...@gmail.com> Signed-off-by: Marius-Adrian Negreanu <gro...@gmail.com> --- drivers/gpu/drm/i915/i915_drv.c | 35 --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 2/4] drm/i915: Convert i915 to use ioctl_register/ioctl_deregister.

From: Marius Vlad <marius.vl...@gmail.com> Signed-off-by: Marius Vlad <marius.vl...@gmail.com> Signed-off-by: Marius-Adrian Negreanu <gro...@gmail.com> --- drivers/gpu/drm/i915/i915_drv.c | 145 +--- 1 file changed, 78 insertions(+), 67

[Intel-gfx] [PATCH 0/4] RFC: drm: Allow driver-specific ioctls to be registered

From: Marius Vlad <marius.vl...@gmail.com> Currently driver-specific ioctls have to be declared static and are confined to DRM core driver. This patch series provides the means to remove those constrains and allow to register driver-specific ioctls dynamically by keeping a list of regi

[Intel-gfx] [PATCH 1/4] drm/: Support registering driver-specific ioctls dynamically

From: Marius Vlad <marius.vl...@gmail.com> Signed-off-by: Marius Vlad <marius.vl...@gmail.com> Signed-off-by: Marius-Adrian Negreanu <gro...@gmail.com> --- drivers/gpu/drm/drm_drv.c | 1 + drivers/gpu/drm/drm_ioctl.c | 99 +++-- inc

[Intel-gfx] [PATCH 3/4] drm/i915: Register perf_ ioctls directly in i915_perf file.

From: Marius Vlad <marius.vl...@gmail.com> Signed-off-by: Marius Vlad <marius.vl...@gmail.com> Signed-off-by: Marius-Adrian Negreanu <gro...@gmail.com> --- drivers/gpu/drm/i915/i915_drv.c | 3 --- drivers/gpu/drm/i915/i915_perf.c | 21 + 2 files changed, 2

Re: [Intel-gfx] [PATCH 0/4] RFC: drm: Allow driver-specific ioctls to be registered

Indeed, we argued at first to let the driver handle the ioctls directly, but we would like to use the DRM interface if possible. On Mon, Sep 4, 2017 at 6:26 PM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Marius Vlad (2017-09-04 16:16:41) > > From: Marius

Re: [Intel-gfx] [PATCH 0/4] RFC: drm: Allow driver-specific ioctls to be registered

, 2017 at 6:25 PM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Mon, Sep 04, 2017 at 06:16:41PM +0300, Marius Vlad wrote: > > From: Marius Vlad <marius.vl...@gmail.com> > > > > Currently driver-specific ioctls have to be declared static and are > confined to &g

Re: [Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.17

ta that > should not fall into any patterns that may be optimised by the > drivers. (Chris Wilson) > > - Crashes in fixture blocks now print a stacktrace. (Marius Vlad) > > - Added support for various system suspend/resume options. (Imre Deak) > > - Added linked lis

[Intel-gfx] [PATCH i-g-t 2/4 v7] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

v2: - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson) - do not hard-fail when i915 module could not be loaded/unloaded (Chris Wilson) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- lib/igt_gvt.c | 37 ++--- tests/gvt_basic.c | 2

[Intel-gfx] [PATCH i-g-t 4/4 v7] tests/kms_sysfs_edid_timing: Convert sh to C version.

cached values (Chris Wilson) - warn on per connector, and fail per mean (Chris Wilson) These are synthetic: 10ms per connector, and 50ms for all. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.sources| 2 +- tests/kms_sysfs_edid_timing | 25 ---

[Intel-gfx] [PATCH i-g-t 1/4 v7] lib/igt_kmod: New library to support driver loading/unloading and additional helpers.

Wilson) - Removed useless function igt_kill() which acts just as kill(2) (Chris Wilson) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- configure.ac | 2 + .../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 + lib/Makef

[Intel-gfx] [PATCH i-g-t 0/4 v7] Convert sh scripts to C variants.

Wilson and Petri Latvala - tests/kms_sysfs_edid_timing: Addressed comments from Chris Wilson - (Hopefully): Addressed comments from Jani Nikula. Marius Vlad (4): lib/igt_kmod: New library to support driver loading/unloading and additional helpers. lib/igt_gvt: Make use of libkmod helpers

[Intel-gfx] [PATCH i-g-t 3/4 v7] tests/drv_module_reload: Convert sh script to C version.

sts/drv_module_reload_basic to tests/drv_module_reload (all subtests are basic and have been added to fast-feedback.testlist) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.am | 1 - tests/Makefile.sources| 2 +- tests/drv_module

Re: [Intel-gfx] [PATCH i-g-t 2/4 v6] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

On Wed, Nov 23, 2016 at 01:31:21PM +, Chris Wilson wrote: > On Wed, Nov 23, 2016 at 02:35:10PM +0200, Marius Vlad wrote: > > v2: > > - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson) > > - do not hard-fail when i915 module could not be loaded/unloa

[Intel-gfx] [PATCH i-g-t 2/4 v6] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

v2: - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson) - do not hard-fail when i915 module could not be loaded/unloaded (Chris Wilson) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- lib/igt_gvt.c | 37 ++--- tests/gvt_basic.c | 2

[Intel-gfx] [PATCH i-g-t 1/4 v6] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to lib/igt_aux, lib/igt_kmod.

the caller (Chris Wilson) - Removed useless function igt_kill() which acts just as kill(2) (Chris Wilson) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- configure.ac | 2 + .../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 + lib/Makef

[Intel-gfx] [PATCH i-g-t 3/4 v6] tests/drv_module_reload: Convert sh script to C version.

sts/drv_module_reload_basic to tests/drv_module_reload (all subtests are basic and have been added to fast-feedback.testlist) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.am | 1 - tests/Makefile.sources| 2 +- tests/drv_module

[Intel-gfx] [PATCH i-g-t 4/4 v6] tests/kms_sysfs_edid_timing: Convert sh to C version.

-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.sources| 2 +- tests/kms_sysfs_edid_timing | 25 --- tests/kms_sysfs_edid_timing.c | 96 +++ 3 files changed, 97 insertions(+), 26 deletions(-) delete mode 100755

[Intel-gfx] [PATCH i-g-t 0/4 v6] Convert sh scripts to C variants.

: - lib/igt_aux: Addressed comments from Chris Wilson - tests/drv_module_reload: Addressed comments from Chris Wilson and Petri Latvala - tests/kms_sysfs_edid_timing: Addressed comments from Chris Wilson - (Hopefully): Addressed comments from Jani Nikula. Marius Vlad (4): lib/{igt_sysfs,igt_aux

[Intel-gfx] [PATCH i-g-t 3/4 v5] tests/drv_module_reload: Convert sh script to C version.

sts/drv_module_reload_basic to tests/drv_module_reload (all subtests are basic and have been added to fast-feedback.testlist) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.am | 1 - tests/Makefile.sources| 2 +- tests/drv_module

[Intel-gfx] [PATCH i-g-t 4/4 v5] tests/kms_sysfs_edid_timing: Convert sh to C version.

-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.sources| 2 +- tests/kms_sysfs_edid_timing | 25 --- tests/kms_sysfs_edid_timing.c | 96 +++ 3 files changed, 97 insertions(+), 26 deletions(-) delete mode 100755

[Intel-gfx] [PATCH i-g-t 1/4 v5] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to lib/igt_aux, lib/igt_kmod.

Wilson) - Removed redundant check in igt_kmod_unload(), igt_module_in_use() (Chris Wilson) - Pass flags to igt_kmod_unload() from the caller (Chris Wilson) - Removed useless function igt_kill() which acts just as kill(2) (Chris Wilson) Signed-off-by: Marius Vlad <marius.c.v...@intel.

[Intel-gfx] [PATCH i-g-t 2/4 v5] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

v2: - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson) - do not hard-fail when i915 module could not be loaded/unloaded (Chris Wilson) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- lib/igt_gvt.c | 37 ++--- tests/gvt_basic.c | 2

[Intel-gfx] [PATCH i-g-t 0/4 v5] Convert sh scripts to C variants.

to igt_kmod_unload(). Changes since v1: - lib/igt_aux: Addressed comments from Chris Wilson - tests/drv_module_reload: Addressed comments from Chris Wilson and Petri Latvala - tests/kms_sysfs_edid_timing: Addressed comments from Chris Wilson - (Hopefully): Addressed comments from Jani Nikula. Marius Vlad (4

Re: [Intel-gfx] [PATCH i-g-t 2/4 v4] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

On Fri, Oct 28, 2016 at 11:08:19AM +0100, Chris Wilson wrote: > On Fri, Oct 28, 2016 at 12:31:27PM +0300, Marius Vlad wrote: > > Signed-off-by: Marius Vlad <marius.c.v...@intel.com> > > --- > > lib/igt_gvt.c | 42 +++--- > >

Re: [Intel-gfx] [PATCH i-g-t 4/4 v4] tests/kms_sysfs_edid_timing: Convert sh to C version.

On Fri, Oct 28, 2016 at 11:03:44AM +0100, Chris Wilson wrote: > On Fri, Oct 28, 2016 at 12:31:29PM +0300, Marius Vlad wrote: > > v2: > > - don't read cached values (Chris Wilson) > > - warn on per connector, and fail per mean (Chris Wilson) > > > > These

Re: [Intel-gfx] [PATCH i-g-t 3/4 v4] tests/drv_module_reload: Convert sh script to C version.

On Fri, Oct 28, 2016 at 10:48:33AM +0100, Chris Wilson wrote: > On Fri, Oct 28, 2016 at 12:31:28PM +0300, Marius Vlad wrote: > > + igt_subtest_group { > > + int fd; > > + > > + igt_fixture > > + fd

[Intel-gfx] [PATCH i-g-t 3/4 v4] tests/drv_module_reload: Convert sh script to C version.

off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.am | 1 - tests/Makefile.sources| 2 +- tests/drv_module_reload.c | 415 ++ tests/drv_module_reload_basic | 105 - tests/ge

[Intel-gfx] [PATCH i-g-t 2/4 v4] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- lib/igt_gvt.c | 42 +++--- tests/gvt_basic.c | 2 +- 2 files changed, 36 insertions(+), 8 deletions(-) diff --git a/lib/igt_gvt.c b/lib/igt_gvt.c index 8bbf9bd..d868cb3 100644 --- a/lib/igt

[Intel-gfx] [PATCH i-g-t 1/4 v4] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to lib/igt_aux, lib/igt_kmod.

as kill(2) (Chris Wilson) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- configure.ac | 2 + lib/Makefile.am | 2 + lib/Makefile.sources | 2 + lib/igt_aux.c| 40 + lib/igt_aux.h| 2 + lib/igt_gvt.c| 43 +- lib/igt_

[Intel-gfx] [PATCH i-g-t 4/4 v4] tests/kms_sysfs_edid_timing: Convert sh to C version.

v2: - don't read cached values (Chris Wilson) - warn on per connector, and fail per mean (Chris Wilson) These are synthetic: 5us per connector, and 600us for all (as threshold). Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.sources| 2 +-

[Intel-gfx] [PATCH i-g-t 0/4 v4] Convert sh scripts to C variants.

/drv_module_reload: Addressed comments from Chris Wilson and Petri Latvala - tests/kms_sysfs_edid_timing: Addressed comments from Chris Wilson - (Hopefully): Addressed comments from Jani Nikula. Marius Vlad (4): lib/{igt_sysfs,igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to igt_aux.

On Mon, Oct 24, 2016 at 10:40:37AM +0200, Daniel Vetter wrote: > On Thu, Oct 20, 2016 at 10:36:47PM +0300, Marius Vlad wrote: > > Previously under unbind_fbcon(), disable/enable framebuffer console. > > > > lib/igt_aux: Added helpers to help convert sh scripts

[Intel-gfx] [PATCH i-g-t 2/3 v3] tests/drv_module_reload: Convert sh script to C version.

ded hda_dynamic_debug() (Petri Latvala) - renamed from tests/drv_module_reload_basic to tests/drv_module_reload (all subtests are basic and have been added to fast-feedback.testlist) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> Fix igt kmod unload Signed-off-by: Marius Vlad &l

[Intel-gfx] [PATCH i-g-t 3/3 v3] tests/kms_sysfs_edid_timing: Convert sh to C version.

v2: - don't read cached values (Chris Wilson) - warn on per connector, and fail per mean (Chris Wilson) These are synthetic: 5us per connector, and 600us for all (as threshold). Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.sources| 2 +-

[Intel-gfx] [PATCH i-g-t 0/3 v3] Convert sh scripts to C variants.

tests/kms_sysfs_edid_timing: Addressed comments from Chris Wilson (Hopefully): Addressed comments from Jani Nikula. Marius Vlad (3): lib/{igt_sysfs,igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to igt_aux (module loading/unloading, pkill) tests

[Intel-gfx] [PATCH i-g-t 1/3 v3] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to igt_aux.

kill(2) once (Chris Wilson) - Removed redundant check in igt_kmod_unload(), igt_module_in_use() (Chris Wilson) - Pass flags to igt_kmod_unload() from the caller (Chris Wilson) - Removed useless function igt_kill() which acts just as kill(2) (Chris Wilson) Signed-off-by: Marius Vlad <marius.

[Intel-gfx] [PATCH i-g-t 2/3 v2] tests/drv_module_reload: Convert sh script to C version.

sts/drv_module_reload_basic to tests/drv_module_reload (all subtests are basic and have been added to fast-feedback.testlist) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.am | 1 - tests/Makefile.sources| 2 +- tests/drv_module

[Intel-gfx] [PATCH i-g-t 3/3 v3] tests/kms_sysfs_edid_timing: Convert sh to C version.

v2: - don't read cached values (Chris Wilson) - warn on per connector, and fail per mean (Chris Wilson) These are synthetic: 5us per connector, and 600us for all (as threshold). Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.sources| 2 +-

[Intel-gfx] [PATCH i-g-t 0/3 v2] Convert sh scripts to C variants.

: lib/igt_aux: Addressed comments from Chris Wilson tests/drv_module_reload: Addressed comments from Chris Wilson and Petri Latvala tests/kms_sysfs_edid_timing: Addressed comments from Chris Wilson (Hopefully): Addressed comments from Jani Nikula. Marius Vlad (3): lib/{igt_sysfs,igt_aux}: Make

[Intel-gfx] [PATCH i-g-t 1/3 v2] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to igt_aux.

: just call kill(2) once (Chris Wilson) - Removed redundant check in igt_kmod_unload(), igt_module_in_use() (Chris Wilson) - Pass flags to igt_kmod_unload() from the caller (Chris Wilson) - Removed useless function igt_kill() which acts just as kill(2) (Chris Wilson) Signed-off-by: Marius Vlad

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/drv_module_reload_basic: Convert sh script to C version.

On Fri, Oct 21, 2016 at 12:39:22PM +0300, Petri Latvala wrote: > > > On 10/20/2016 10:36 PM, Marius Vlad wrote: > > Signed-off-by: Marius Vlad <marius.c.v...@intel.com> > > --- > > tests/Makefile.sources | 2 +- > >

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/drv_module_reload_basic: Convert sh script to C version.

On Thu, Oct 20, 2016 at 08:52:23PM +0100, Chris Wilson wrote: > On Thu, Oct 20, 2016 at 10:36:48PM +0300, Marius Vlad wrote: > > +static const char *tests[] = { > > + "gem_alive", "gem_exec_store" > > +}; > > gem_alive is just a single ioctl qu

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to igt_aux.

On Thu, Oct 20, 2016 at 09:09:17PM +0100, Chris Wilson wrote: > On Thu, Oct 20, 2016 at 10:36:47PM +0300, Marius Vlad wrote: > > +int > > +igt_pkill(int sig, const char *comm) > > +{ > > + int err = 0, try = 5; > > + PROCTAB *proc; > > + proc_t *p

[Intel-gfx] [PATCH i-g-t 1/3] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to igt_aux.

Previously under unbind_fbcon(), disable/enable framebuffer console. lib/igt_aux: Added helpers to help convert sh scripts to C version. libkmod and procps interface. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- configure.ac| 2 + lib/Makefile.am | 2 + lib/igt_aux.c

[Intel-gfx] [PATCH i-g-t 0/3] Convert sh scripts to C variants.

This series adds some library support to help converting sh scripts to C version. Converted drv_module_reload_basic and kms_sysfs_edid_timing. Marius Vlad (3): lib/igt_sysfs: Make available to other users kick_fbcon() function (previously under unbind_fbcon()), to disable/enable framebuffer

[Intel-gfx] [PATCH i-g-t 3/3] tests/kms_sysfs_edid_timing: Convert sh script to C version.

While at it, make available time macros to other users. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- benchmarks/gem_syslatency.c | 4 --- lib/igt_core.c| 3 -- lib/igt_core.h| 3 ++ tests/Makefile.sources| 2 +- tests/drv_han

[Intel-gfx] [PATCH i-g-t 2/3] tests/drv_module_reload_basic: Convert sh script to C version.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.sources | 2 +- tests/drv_module_reload_basic | 97 --- tests/drv_module_reload_basic.c | 166 3 files changed, 167 insertions(+), 98 del

[Intel-gfx] [PATCH i-g-t] tests/kms_psr_sink_crc: Assert if we don't have a valid crtc.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Maarten Lankhorst <maarten.lankho...@linux.intel.com> CC: Rodrigo Vivi <rodrigo.v...@intel.com> CC: Daniel Vetter <dan...@ffwll.ch> --- lib/igt_kms.c| 10 +- tests/kms_psr_sink_crc.c | 1 + 2 files cha

[Intel-gfx] [PATCH i-g-t] lib/igt_core: Print stacktrace in initialization/fixture blocks.

Likely candidate for this behaviour is the igt_fixture block. Seen in the CI by running tests/kms_psr_sink_crc which is causing segfaults in the fixture block. While at it fix some minor printing bugs. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch

Re: [Intel-gfx] [RFC] Idleness DRRS test

On Wed, Aug 31, 2016 at 01:46:03PM +0530, Nautiyal Ankit wrote: > From: aknautiy > > Idleness DRRS: > By default the DRRS state will be at DRRS_HIGH_RR. When a Display > content is Idle for more than 1Sec Idleness will be declared and > DRRS_LOW_RR

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/gem_busy: Fix compile error

Applied. Thanks! On Tue, Sep 06, 2016 at 03:55:41PM +0100, Derek Morton wrote: > The benchmark was failing with: > gem_busy.c:158:8: error: implicit declaration of function 'intel_gen' > is invalid in C99 [-Werror,-Wimplicit-function-declaration] > gen = intel_gen(intel_get_drm_devid(fd)); > >

[Intel-gfx] [PATCH i-g-t] assembler, lib, overlay, tools, tests/: Fix warnings about unused variables.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- assembler/gen8_disasm.c | 5 - lib/intel_device_info.c | 6 -- overlay/igfx.c| 7 --- tests/testdisplay.c | 1 - tools/intel_bios_reader.c | 22 -- 5 files changed, 41 del

[Intel-gfx] [PATCH i-g-t] demo/Makefile.source: Compile intel_sprite_on when HAVE_LIBDRM_INTEL.

Introduced with commit cd86866dec. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Robert Foss <robert.f...@collabora.com> --- demos/Makefile.sources | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/demos/Makefile.sources b/demos/Makefile.sources i

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.16

Hello, A new intel-gpu-tools quarterly release is available with the following changes: - Build automatically tests required when issueing a make check, Tests/subtests that receive a crash signal should print a backtrace when i-g-t is built with libunwind support (Marius Vlad) - lib/igt_kms

Re: [Intel-gfx] [PATCH i-g-t] gem_busy: Remove from android builds without cairo

@Chris: I assume this is no longer necessary with the split to kms_busy? On Tue, Aug 23, 2016 at 09:44:14AM +, Gore, Tim wrote: > > > Tim Gore  > Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ > > > > -Original Message- > > From: Morton, Derek J > >

[Intel-gfx] [PATCH i-g-t v3] lib/igt_core: Print stacktrace when receiving one of the crash signals.

While at it add SIGFPE as a crash signal. v3: Remove calls to igt_assert_eq() as these are not async-safe. As one user of this method remove the function pointer and recursive call. (Chris Wilson) v2: Added some helpers to avoid printf() inside a signal handler. (Chris Wilson) --- lib/igt_core.c

[Intel-gfx] [PATCH i-g-t] tests/Makefile.am: Add -Wno-unused-result to tests

Removes useless warnings if a caller of a function does not use its returned value(s). Mostly aesthetic. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> CC: Daniel Vetter <dan...@ffwll.ch> --- tests/Makefile.am | 2 +- 1 file ch

[Intel-gfx] [PATCH i-g-t v2] lib/igt_core: Print stacktrace when receiving one of the crash signals.

While at it add SIGFPE as a crash signal. v2: Added some helpers to avoid printf() inside a signal handler. (Chris Wilson) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- lib/igt_

[Intel-gfx] [PATCH i-g-t] lib/igt_core: Print stacktrace when receiving one of the crash signals.

While at it add SIGFPE as a crash signal. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- lib/igt_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 801f02f..67

[Intel-gfx] [PATCH i-g-t] lib/intel_chipset: Fix compilation when enabling the debugger.

Add IS_SANDYBRIDGE() macro used by debugger/eudb. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- lib/intel_chipset.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 1003266..3c

Re: [Intel-gfx] [PATCH] Bump libdrm-intel dependency library to a newer version that support softpin.

y 2016 at 11:39, Marius Vlad <marius.c.v...@intel.com> wrote: > > Required by commit 2603b98ca (aubdump: Support softpin bos). > > > > Signed-off-by: Marius Vlad <marius.c.v...@intel.com> > > CC: Kristian Høgsberg Kristensen <kristian.h.kristen...@intel.com>

Re: [Intel-gfx] [PACTH i-g-t] lib/igt_kms: Fix different order of properties and their name strings

Applied. Thanks! On Mon, Jul 11, 2016 at 03:54:12PM -0400, Robert Foss wrote: > This is a reminder of this series. > > On 2016-06-29 07:22 AM, robert.f...@collabora.com wrote: > >From: Robert Foss > > > >igt_crtc_prop_names and igt_atomic_crtc_properties have different

[Intel-gfx] [PATCH] Bump libdrm-intel dependency library to a newer version that support softpin.

Required by commit 2603b98ca (aubdump: Support softpin bos). Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Kristian Høgsberg Kristensen <kristian.h.kristen...@intel.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/

Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

hda - remove dependency on i915 power well for > > > SKL") > > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > > > > Reviewed-by: Mika Kuoppala <mika.kuopp...@intel.com> > > > > > Cc: Libin Yang <libin.y...@intel.com&g

Re: [Intel-gfx] [PACTH i-g-t v1] lib/igt_gt: Fix unused variable warning for non-x86 targets

Applied. On Mon, Jun 27, 2016 at 06:58:24AM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Moved variable declaration inside #if case to avoid unused variable warnings > on non-x86 targets. > > Signed-off-by: Robert Foss >

Re: [Intel-gfx] [PATCH i-g-t] configure: update bugzilla URL

Applied. On Wed, Jun 22, 2016 at 07:08:03AM -0400, Mike Frysinger wrote: > Signed-off-by: Mike Frysinger > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 2e2c3ab7a7b0..d84508b5f6f5 100644 > ---

Re: [Intel-gfx] [PATCH v2 i-g-t] demos/intel_sprite_on: Fix connector iteration bug

Applied. On Wed, Jun 15, 2016 at 10:48:32AM -0700, Jim Bride wrote: > Instead of looping until the first disconnected port is found, > now go through all possible connectors, drawing the sprite on > any connected display. > > v2: Print a message if we don't find any valid connectors. > >

Re: [Intel-gfx] [PATCH i-g-t 2/2] overlay/Makefile.am: Use lib path for i915_pciids.h

On Fri, Jul 01, 2016 at 01:33:36PM +0100, Chris Wilson wrote: > On Fri, Jul 01, 2016 at 03:32:45PM +0300, Marius Vlad wrote: > > This is due to commit d308bb082d429eb25 (lib: Start weaning off defunct > > intel_chipset.h) which ``moved'' i915_pciids.h to lib/ from overlay/. >

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/gvt_basic: Test w/o sub-test requires simple_main

Right, but bare in mind that it can't be released as is... On Fri, Jul 01, 2016 at 01:33:02PM +0100, Chris Wilson wrote: > On Fri, Jul 01, 2016 at 03:32:44PM +0300, Marius Vlad wrote: > > Signed-off-by: Marius Vlad <marius.c.v...@intel.com> > > CC: Chris Wilson <

[Intel-gfx] [PATCH i-g-t 2/2] overlay/Makefile.am: Use lib path for i915_pciids.h

This is due to commit d308bb082d429eb25 (lib: Start weaning off defunct intel_chipset.h) which ``moved'' i915_pciids.h to lib/ from overlay/. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- overlay/Makefile.am | 2 +- 1 fil

[Intel-gfx] [PATCH i-g-t 1/2] tests/gvt_basic: Test w/o sub-test requires simple_main

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- tests/gvt_basic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gvt_basic.c b/tests/gvt_basic.c index 9e17f29..056c472 100644 --- a/tests/gvt_basic.c

[Intel-gfx] [PATCH i-g-t 2/2] lib/drmtest: Report proper err message when opening the driver.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- lib/drmtest.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 1e28f60..d2ee2d1 100644 --- a/lib/drmtest.c +++ b/l

[Intel-gfx] [PATCH i-g-t 1/2] tests/{kms_cursor_legacy, drv_missed_irq}, lib/drmtest: Fix warnings about unused function return values.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- lib/drmtest.c | 8 +++- tests/drv_missed_irq.c| 2 +- tests/kms_cursor_legacy.c | 8 ++-- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/lib

Re: [Intel-gfx] [PATCH i-g-t] assembler/: Fix lex warnings for %empty and %nonassoc.

iau wrote: > > > On Mon, May 16, 2016 at 01:39:10PM +0300, Marius Vlad wrote: > > > > Signed-off-by: Marius Vlad <marius.c.v...@intel.com> > > > > --- > > > > assembler/gram.y | 74 > > > >

Re: [Intel-gfx] [RFC i-g-t v3 08/13] lib/stubs: Add stubs for intel_bufmgr.

On Mon, Jun 20, 2016 at 03:52:35PM +0100, Emil Velikov wrote: > Hi Rob, > > A couple of nitpicks and a case of missing git add :-) > > On 15 June 2016 at 10:51, wrote: > > > +if HAVE_LIBDRM_INTEL > > +else > > +libintel_tools_la_SOURCES += \ > > +

[Intel-gfx] [PATCH i-g-t v2] tests/drm_lib.sh: Extract fake getopt options so it can sourced into tests that require it.

This should allow tests/vgem_reload_basic to pass check target and it doesn't depend of i915 being present. v2: Do not source drm_lib.sh, only fake getopt parsing option to again access to --list-subtests option (Chris) Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wils

[Intel-gfx] [PATCH i-g-t] tests/vgem_reload_basic: Include drm_lib.sh to please check target.

Scripts are required to have it included. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- tests/vgem_reload_basic | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/vgem_reload_basic b/tests/vgem_reload_basic index b150

Re: [Intel-gfx] [PATCH i-g-t] demos/intel_sprite_on: Fix connector iteration bug

On Mon, Jun 13, 2016 at 07:51:06AM -0700, Jim Bride wrote: > Instead of looping until the first disconnected port is found, > now go through all possible connectors, drawing the sprite on > any connected display. > > Signed-off-by: Jim Bride > --- >

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_missed_irq_hang: Fix gem_blt path

On Mon, Jun 13, 2016 at 04:26:22PM +0300, Mika Kuoppala wrote: > Don't add SOURCE_DIR to the path for gem_blt as if this > script is invocated on some other directory, the path to > gem_blt will be concatenated two times. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=88437 > Cc:

Re: [Intel-gfx] iommu/vt-d: Use per-cpu IOVA caching, suspend-to-ram causes machine hang

Yes, that does it. Thanks. On Mon, Jun 06, 2016 at 12:02:30AM +0300, Adam Morrison wrote: > > Hi Omer the following commit introduced a regression when doing > > suspend-to-ram. The machine never wakes up. We have more than > > a few machines that hang: SNB-i7-2620m, IVB-3370, HSW-4470r,

[Intel-gfx] iommu/vt-d: Use per-cpu IOVA caching, suspend-to-ram causes machine hang

Hi Omer the following commit introduced a regression when doing suspend-to-ram. The machine never wakes up. We have more than a few machines that hang: SNB-i7-2620m, IVB-3370, HSW-4470r, BDW-5600u, BDW-525u. You can easily replicate by doing a rtcwake -s 10 -m mem.

[Intel-gfx] [PATCH i-g-t] lib/igt_kms: Fix passing invalid fd to openat(2).

Introduced by 0e11befe442. openat(2) uses a relative path. Fix by passing the correct fd. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- lib/igt_kms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/igt

Re: [Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915: Check VBT for port presence in addition to the strap on VLV/CHV

On Fri, Jun 03, 2016 at 03:28:52PM +0300, Ville Syrjälä wrote: > On Fri, Jun 03, 2016 at 10:06:54AM -, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Check VBT for port presence in addition to the strap on > > VLV/CHV > > URL :

[Intel-gfx] DMAR error -> GPU hang, [WAS Re: i915 bug]

Hi, Thanks for the feedback. Have you tried with drm-intel-nightly [1] to see if this still happens? [1] https://anongit.freedesktop.org/git/drm-intel.git CC'ing the list. Maybe someone is aware of this. Seems there are bunch of duplicates for it. On Thu, Jun 02, 2016 at 09:06:05PM +0300,

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.15

and other various fixes (Jani Nikula) - build: Add optional --enable-werror (hard-fail in case of compiler warnings) (Marius Vlad) - New KMS test: tests/prime_mmap_kms (show case dma-buf new API and processes restrictions) (Tiago Vignatti) - Several tests have gained to ability to be run

Re: [Intel-gfx] [PATCH i-g-t v2 1/8] tests/gem_exec_flush: Remove tests from BAT.

On Mon, May 30, 2016 at 11:50:00AM +0100, Chris Wilson wrote: > On Mon, May 30, 2016 at 01:44:52PM +0300, Marius Vlad wrote: > > The explanation is the same as in the previous series: the GEM tests are > > taking too long. Either I sack them under nightly runs or decrease the >

Re: [Intel-gfx] [PATCH i-g-t v2 1/8] tests/gem_exec_flush: Remove tests from BAT.

+0100, Chris Wilson wrote: > On Fri, May 27, 2016 at 07:27:46PM +0300, Marius Vlad wrote: > > You are lacking an explanation. Please tell me what this test is about > and why it is not suitable criteria for a basic acceptance test. > -Chris > > -- > Chris Wilson, Inte

[Intel-gfx] [PATCH i-g-t 8/8] tests/gem_exec_suspend: Remove hibernate from BAT.

We are already skipping this test in CI on more than one platform, so migrate them to nightly. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/gem_exec_suspend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_exec_suspend.c b/tests/gem_exec_sus

[Intel-gfx] [PATCH i-g-t v2 7/8] tests/gem_tile_pread_basic: Remove gem_tiled_pread_basic from BAT.

Test is renamed to gem_tiled_pread. Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/Makefile.sources| 2 +- tests/gem_tiled_pread.c | 228 ++ tests/gem_tiled_pread_basic.c | 215

[Intel-gfx] [PATCH i-g-t v2 2/8] tests/gem_ctx_switch: Remove test from BAT.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/gem_ctx_switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_ctx_switch.c b/tests/gem_ctx_switch.c index 7b27336..ce52365 100644 --- a/tests/gem_ctx_switch.c +++ b/tests/gem_ctx_switch.c @@

[Intel-gfx] [PATCH i-g-t v2 1/8] tests/gem_exec_flush: Remove tests from BAT.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/gem_exec_flush.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/tests/gem_exec_flush.c b/tests/gem_exec_flush.c index d08b843..2f271bb 100644 --- a/tests/gem_exec_flush.c +++ b

[Intel-gfx] [PATCH i-g-t v2 4/8] tests/gem_close_race: Remove basic-threads from BAT.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/gem_close_race.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_close_race.c b/tests/gem_close_race.c index 94fb905..80da731 100644 --- a/tests/gem_close_race.c +++ b/tests/gem_close_race.c @@

[Intel-gfx] [PATCH i-g-t v2 3/8] tests/gem_exec_nop: Remove test from BAT.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/gem_exec_nop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/gem_exec_nop.c b/tests/gem_exec_nop.c index e90d5eb..8b31b27 100644 --- a/tests/gem_exec_nop.c +++ b/tests/gem_exec_nop.c @@ -212,9 +212,6 @@ ig

[Intel-gfx] [PATCH i-g-t v2 6/8] tests/gem_storedw_loop: Remove from BAT.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/gem_storedw_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c index 317b8c6..a0c5af1 100644 --- a/tests/gem_storedw_loop.c +++ b/tests/gem_storedw_

[Intel-gfx] [PATCH i-g-t v2 5/8] tests/gem_sync: Remove basic tests.

Signed-off-by: Marius Vlad <marius.c.v...@intel.com> --- tests/gem_sync.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/gem_sync.c b/tests/gem_sync.c index 320bce3..a46f120 100644 --- a/tests/gem_sync.c +++ b/tests/gem_sync.c @@ -221,12 +221,12 @@ ig

  1   2   3   >