Re: [Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-17 Thread Timo Aaltonen
fei.y...@intel.com kirjoitti 17.4.2023 klo 9.24: From: Fei Yang The series includes patches needed to enable MTL. Also add new extension for GEM_CREATE uAPI to let user space set cache policy for buffer objects. if I'm counting right, this would be version 5 of the series, yet that is not

Re: [Intel-gfx] [CI] PR for DG2 DMC v2.06

2022-05-02 Thread Timo Aaltonen
Timo Aaltonen kirjoitti 13.4.2022 klo 13.48: Tolakanahalli Pradeep, Madhumitha kirjoitti 23.3.2022 klo 20.23: The following changes since commit 681281e49fb6778831370e5d94e6e1d97f0752d6:    amdgpu: update PSP 13.0.8 firmware (2022-03-18 07:35:54 -0400) are available in the Git repository

Re: [Intel-gfx] [PATCH 0/2] Initial GuC firmware release for DG2

2022-04-27 Thread Timo Aaltonen
john.c.harri...@intel.com kirjoitti 27.4.2022 klo 19.55: From: John Harrison Add GuC firmware for DG2. Note that an older version of this patch exists in the CI topic branch. Hence this set includes a revert of that patch before applying the new version. When merging, the revert would simply

Re: [Intel-gfx] [CI] PR for DG2 DMC v2.06

2022-04-13 Thread Timo Aaltonen
Tolakanahalli Pradeep, Madhumitha kirjoitti 23.3.2022 klo 20.23: The following changes since commit 681281e49fb6778831370e5d94e6e1d97f0752d6: amdgpu: update PSP 13.0.8 firmware (2022-03-18 07:35:54 -0400) are available in the Git repository at:

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Implement Wa_1508744258

2021-08-12 Thread Timo Aaltonen
On 12.8.2021 6.27, Timo Aaltonen wrote: On 9.7.2021 0.18, José Roberto de Souza wrote: Same bit was required for Wa_14012131227 in DG1 now it is also required as Wa_1508744258 to TGL, RKL, DG1, ADL-S and ADL-P. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza ---   drivers/gpu/drm

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Implement Wa_1508744258

2021-08-11 Thread Timo Aaltonen
On 9.7.2021 0.18, José Roberto de Souza wrote: Same bit was required for Wa_14012131227 in DG1 now it is also required as Wa_1508744258 to TGL, RKL, DG1, ADL-S and ADL-P. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 +++ 1

Re: [Intel-gfx] [PATCH RFC] Revert "drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure"

2021-05-10 Thread Timo Aaltonen
On 9.5.2021 7.43, Paul Zimmerman wrote: This reverts commit 2bbd6dba84d44219387df051a1c799b7bac46099. Since 5.12-rc2, my Dell XPS-15 laptop has had a blank screen on boot. The system seems to run fine other than having no display, I am able to ssh into the machine. I don't see anything

Re: [Intel-gfx] [PATCH v5] drm/i915/rkl: new rkl ddc map for different PCH

2020-12-16 Thread Timo Aaltonen
Hi, Progress here seems to have stalled, or did I miss something? On 20.11.2020 4.21, Lee, Shawn C wrote: On Thu, Nov. 19, 2020 at 11:51 PM, Matt Roper wrote: On Tue, Nov 17, 2020 at 10:26:29PM +0800, Lee Shawn C wrote: After boot into kernel. Driver configured ddc pin mapping based on

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure

2020-07-02 Thread Timo Aaltonen
est of both worlds by using both strategies. > > v2: Deal with output_bpp and uapi vs. hw state split > Reword some comments > > Cc: Jani Nikula > Cc: Rodrigo Vivi > Cc: Manasi Navare > Cc: Albert Astals Cid # v5.0 backport > Cc: Emanuele Panigati # v5.0 backport

Re: [Intel-gfx] [RESEND PATCH v2] drm: Add getfb2 ioctl

2019-11-21 Thread Timo Aaltonen
On 9.10.2019 18.50, Daniel Vetter wrote: > On Thu, Oct 03, 2019 at 11:31:25AM -0700, Juston Li wrote: >> From: Daniel Stone >> >> getfb2 allows us to pass multiple planes and modifiers, just like addfb2 >> over addfb. >> >> Changes since v1: >> - unused modifiers set to 0 instead of

Re: [Intel-gfx] [PATCH] drm/i915/cml: Add second PCH ID for CMP

2019-10-09 Thread Timo Aaltonen
On 17.9.2019 2.32, Matt Roper wrote: > The CMP PCH ID we have in the driver is correct for the CML-U machines we have > in our CI system, but the CML-S and CML-H CI machines appear to use a > different PCH ID, leading our driver to detect no PCH for them. > > Cc: Rodrigo Vivi > Cc: Anusha

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Enable hotplug retry

2019-07-09 Thread Timo Aaltonen
On 2.7.2019 23.41, Souza, Jose wrote: > On Tue, 2019-07-02 at 23:29 +0300, Timo Aaltonen wrote: >> On 2.7.2019 22.54, Souza, Jose wrote: >>> Here a dmesg output of this patch working in a unpowered type-c >>> dongle: >>> https://gist.github.com/zehortig

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Enable hotplug retry

2019-07-02 Thread Timo Aaltonen
On 2.7.2019 22.54, Souza, Jose wrote: > Here a dmesg output of this patch working in a unpowered type-c dongle: > https://gist.github.com/zehortigoza/93c54b03fb65237cc1a2e193acef61a8 > > With the latest type-c patches from Imre it is becoming really hard to > reproduce this but is still possible,

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)

2019-01-21 Thread Timo Aaltonen
me headline docs for the uapi usage. (Joonas/Chris) > > v25: > * Renamed class/instance to engine_class/engine_instance to avoid clash >with C++ keyword. (Tony Ye) > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100899 > Bugzilla: https://bugs.freedesktop.o

Re: [Intel-gfx] [PATCH v3 0/8] drm/i915: GTT remapping for display

2019-01-09 Thread Timo Aaltonen
On 25.9.2018 22.37, Ville Syrjala wrote: > From: Ville Syrjälä > > Another gtt remapping posting. > > Changes since the last time: > - split out the plane stride check function (already in) > - use add_overflows() (after massaging it a bit) > - include some selftests for the remapped/rotated

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use rmb() to order CSB reads

2018-05-08 Thread Timo Aaltonen
nux.intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Cc: Michał Winiarski <michal.winiar...@intel.com> > Cc: Rafael Antognolli <rafael.antogno...@intel.com> > Cc: Michel Thierry <michel.thie...@intel.com> > Cc: Timo Aaltonen <tjaal...@ubuntu.

Re: [Intel-gfx] [PATCH v2] drm/i915/edp: Do not do link training fallback or prune modes on EDP

2018-04-12 Thread Timo Aaltonen
On 30.01.2018 09:38, Jani Nikula wrote: > On Tue, 23 Jan 2018, Imre Deak wrote: >> On Tue, Jan 23, 2018 at 11:48:22AM +0200, Jani Nikula wrote: >>> On Mon, 22 Jan 2018, Imre Deak wrote: On Fri, Jan 19, 2018 at 05:45:16PM +0200, Imre Deak wrote:

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Properly handle VBT ddc pin out of bounds.

2018-03-23 Thread Timo Aaltonen
On 30.01.2018 00:12, Rodrigo Vivi wrote: > On Mon, Jan 29, 2018 at 05:42:53AM +, Kai Heng Feng wrote: >> >>> On 26 Jan 2018, at 6:25 AM, Rodrigo Vivi wrote: >>> >>> If the table result is out of bounds on the array map >>> there is something really wrong with VBT pin

Re: [Intel-gfx] [PATCH v2] x86/gpu: add CFL to early quirks

2018-01-11 Thread Timo Aaltonen
On 15.12.2017 23:19, Rodrigo Vivi wrote: > On Fri, Dec 15, 2017 at 04:39:25PM +, Ingo Molnar wrote: >> >> * Lucas De Marchi wrote: >> >>> CFL was missing from intel_early_ids[]. The PCI ID needs to be there to >>> allow the memory region to be stolen, otherwise we

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

2016-10-14 Thread Timo Aaltonen
On 14.08.2015 08:18, Zhang, Xiong Y wrote: >> On Mon, Aug 10, 2015 at 06:23:19PM +, Rodrigo Vivi wrote: >>> I believe this function could be added along with the next patch that >>> is the first to use it... >>> Or it would be good to have a good commit message explaining why this >>> function

Re: [Intel-gfx] [PATCH xf86-video-intel] Fix fd (and mem) leak when intel_scrn_create fails

2016-04-25 Thread Timo Aaltonen
22.04.2016, 21:04, Hans de Goede kirjoitti: > The probe functions in intel_module.c call intel_open_device() before > calling intel_scrn_create(), but if the later fails because of e.g. > an unsupported (new) pci-id they were not cleaning up the resources > claimed by intel_open_device(), esp.

Re: [Intel-gfx] [RFC/PATCH xf86-video-intel] sna: Let modestting + glamor handle gen9+

2016-04-22 Thread Timo Aaltonen
08.04.2016, 16:21, Hans de Goede kirjoitti: > Hi, Hi, sorry for the delay.. > On 11-03-16 11:07, Timo Aaltonen wrote: >> >> I've been trying to make this work, but there are cases where it fails >> bad: >> >> # a config file with a Device section that lo

Re: [Intel-gfx] [PATCH v6 0/3] drm/i915: Disable link training optimization if DP config has changed

2016-04-18 Thread Timo Aaltonen
05.01.2016, 15:49, Mika Kahola kirjoitti: > These three patches are fixes for DP link trainging failures and flickering > issues > reported by https://bugs.freedesktop.org/show_bug.cgi?id=91393 > > Mika Kahola (3): > drm/i915: Disable fast link training if DP config changes > drm/i915: Check

Re: [Intel-gfx] [PATCH 1/2] drm/i915/skl: Fix rc6 based gpu/system hang

2016-04-05 Thread Timo Aaltonen
lgue <abdiel.janul...@linux.intel.com> > Cc: Ben Widawsky <benjamin.widaw...@intel.com> > Cc: Timo Aaltonen <tjaal...@ubuntu.com> > Cc: <sta...@vger.kernel.org> > Reported-by: Mikael Djurfeldt <mik...@djurfeldt.com> > References: https://bugs.freedesktop.org/s

Re: [Intel-gfx] [RFC/PATCH xf86-video-intel] sna: Let modestting + glamor handle gen9+

2016-03-11 Thread Timo Aaltonen
29.02.2016, 16:47, Hans de Goede kirjoitti: > sna has no meaningfull accel for gen9+, this causes problems with i.e. > apps using XVideo since the sprite XVideo support does not work well > for many apps. > > Therefor it is better to just let the xserver fall back to modesetting + > glamor. This

Re: [Intel-gfx] [PATCH 7/6] drm/i915/skl: DDI-E and DDI-A shares 4 lanes.

2015-08-27 Thread Timo Aaltonen
On 27.08.2015 05:52, Zhang, Xiong Y wrote: On Wed, 2015-08-26 at 11:15 +0300, Jani Nikula wrote: On Thu, 13 Aug 2015, Jindal, Sonika sonika.jin...@intel.com wrote: On 8/13/2015 8:57 AM, Zhang, Xiong Y wrote: On Wed, 2015-08-12 at 02:20 +, Zhang, Xiong Y wrote: On Tue, 2015-08-11 at 07:05

Re: [Intel-gfx] [PATCH 1/2 v2 addendum v2] drm/i915: Allow parsing of variable size child device entries from VBT

2015-08-14 Thread Timo Aaltonen
On 13.08.2015 16:14, David Weinehall wrote: On Wed, Aug 12, 2015 at 05:19:35PM +0300, Jani Nikula wrote: On Wed, 12 Aug 2015, David Weinehall david.weineh...@linux.intel.com wrote: Some more fixup is needed; the bits from Antti's patch that actually expanded the struct to fully fit the newer

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Adding break for one case

2015-08-13 Thread Timo Aaltonen
On 13.08.2015 13:00, Xiong Zhang wrote: Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 65cc5b1..801187c

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Adding break for one case

2015-08-13 Thread Timo Aaltonen
On 13.08.2015 13:36, Timo Aaltonen wrote: On 13.08.2015 13:00, Xiong Zhang wrote: Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 7/6] drm/i915/skl: DDI-E and DDI-A shares 4 lanes.

2015-08-12 Thread Timo Aaltonen
== PORT_A + (intel_dig_port-saved_port_bits + DDI_A_4_LANES) == 0)) +source_max = 2; [Zhang, Xiong Y] it miss ')' at the end line. sink_max = drm_dp_max_lane_count(intel_dp-dpcd); with these build fixes the series is Tested-by: Timo

Re: [Intel-gfx] [PATCH v1 0/2] Enable legacy behaviour for Push constants

2015-08-11 Thread Timo Aaltonen
drivers/gpu/drm/i915/i915_reg.h | 5 + drivers/gpu/drm/i915/intel_ringbuffer.c | 14 -- 2 files changed, 17 insertions(+), 2 deletions(-) prw-blt-overwrite-source-read-rcs-forked runs fine with these, tested on SKL-Y -H Tested-by: Timo Aaltonen timo.aalto

Re: [Intel-gfx] linux-firmware-i915 pull request

2015-07-08 Thread Timo Aaltonen
On 20.06.2015 03:35, Vivi, Rodrigo wrote: Hi, Please consider pulling i915 to linux-firmware.git and let me know if there is anything else I should do differently on the pull request. Pretty please, pull this in. It's blocking things downstream. -- t

Re: [Intel-gfx] [PATCH] drm/i915/skl: changed the filename of csr firmware

2015-06-02 Thread Timo Aaltonen
On 27.05.2015 14:34, Daniel Vetter wrote: On Tue, May 26, 2015 at 05:21:56PM -0700, Rodrigo Vivi wrote: On Thu, May 21, 2015 at 5:04 AM, Animesh Manna animesh.ma...@intel.com wrote: Naming convention of csr firmware will be - platform_dmc_api-version_minor-version.bin Accordingly updated

Re: [Intel-gfx] Broadwell i915 VT behavior on resume from sleep

2015-04-04 Thread Timo Aaltonen
On 03.04.2015 23:59, Steven Noonan wrote: Running 3.19.3 on a Broadwell ThinkPad X250. I'm running into some unfortunate behaviour. When I resume from sleep, the GPU occasionally hangs: https://bugs.freedesktop.org/show_bug.cgi?id=89896 dupe of

Re: [Intel-gfx] Broadwell i915 VT behavior on resume from sleep

2015-04-04 Thread Timo Aaltonen
On 04.04.2015 10:47, Steven Noonan wrote: On Sat, Apr 4, 2015 at 12:05 AM, Timo Aaltonen tjaal...@ubuntu.com wrote: On 03.04.2015 23:59, Steven Noonan wrote: Running 3.19.3 on a Broadwell ThinkPad X250. I'm running into some unfortunate behaviour. When I resume from sleep, the GPU

Re: [Intel-gfx] [PATCH] sna: Use VMask in 3DSTATE_PS

2014-11-05 Thread Timo Aaltonen
. Reference: https://bugs.freedesktop.org/show_bug.cgi?id=83207 Cc: Timo Aaltonen tjaal...@ubuntu.com Cc: Gary Wang gary.c.w...@intel.com Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com works great, thanks! Tested-by: Timo Aaltonen timo.aalto...@canonical.com

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Restore PPAT on thaw

2014-03-19 Thread Timo Aaltonen
! Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76113 Tested-by: Timo Aaltonen timo.aalto...@canonical.com --- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe

2012-09-12 Thread Timo Aaltonen
On 12.09.2012 18:09, Jonathan Nieder wrote: Hi Timo, Timo Aaltonen wrote: commit d698c826bb93663e4b349a78fbd30443654d37cd upstream. oops, script-fail.. that's the local branch sha, real one is further down (0f91128d88bbb8b0a8e7bb93df2c40680871d45a). Please pull this for v3.2.x, should