[Intel-gfx] [GIT PULL] more GVT-g fixes for 4.11

2017-02-23 Thread Zhenyu Wang
regs Zhao, Xinda (3): drm/i915/gvt: handle fence reg access during GPU reset drm/i915/gvt: decrease priority of output msg for untracked mmio drm/i915/gvt: remove unnecessary error msg from gtt write Zhenyu Wang (4): drm/i915/gvt: Fix check error on opregion.c drm

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix superfluous newline in GVT_DISPLAY_READY env var

2017-02-20 Thread Zhenyu Wang
On 2017.02.20 14:58:25 +0100, Takashi Iwai wrote: > send_display_send_uevent() sends two environment variable, and the > first one GVT_DISPLAY_READY is set including a new line at the end of > the string; that is obviously superfluous and wrong -- at least, it > *looks* so when you only read the

[Intel-gfx] [GIT PULL] more GVT-g fixes for 4.11

2017-02-14 Thread Zhenyu Wang
(1): drm/i915/gvt: add sprite plane flip done support. Zhenyu Wang (2): drm/i915/gvt: Fix alignment for GTT allocation drm/i915/gvt: Fix shadow context descriptor drivers/gpu/drm/i915/gvt/aperture_gm.c | 15 +++ drivers/gpu/drm/i915/gvt/cmd_parser.c | 20

Re: [Intel-gfx] [patch v2] drm/i915/gvt/kvmgt: remove some dead code

2017-02-08 Thread Zhenyu Wang
On 2017.02.08 14:49:22 +0200, Joonas Lahtinen wrote: > On ti, 2017-02-07 at 17:53 +0300, Dan Carpenter wrote: > > "caps.buf" is always NULL here and "caps.size" is always zero.  The code > > is a no-op and can be removed. > > > > Signed-off-by: Dan Carpenter > >

[Intel-gfx] [GIT PULL] GVT-g fixes for 4.11 merge

2017-02-07 Thread Zhenyu Wang
in virtual edid Zhenyu Wang (5): drm/i915: make intel_gvt_init() later instead of too early drm/i915/gvt: move intel iommu detection to intel_gvt_init() drm/i915/gvt: remove detect_host() MPT hook drm/i915/gvt: use normal mmio read function for firmware exposure drm

Re: [Intel-gfx] [PATCH] MAINTAINERS: update new mail list for intel gvt driver

2017-01-25 Thread Zhenyu Wang
On 2017.01.25 12:49:48 +0200, Jani Nikula wrote: > Side note, in the admin interface, please allow anyone subscribed to > intel-gfx or dri-devel post to intel-gvt-dev without moderation. It's > under Privacy options... | Sender filters | List of non-member addresses > whose postings should be

[Intel-gfx] [GIT PULL] GVT-g fixes for 4.10-rc6

2017-01-24 Thread Zhenyu Wang
: Enable the shadow batch buffer Zhenyu Wang (1): MAINTAINERS: update new mail list for intel gvt driver MAINTAINERS | 2 +- drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 --- drivers/gpu/drm/i915/gvt/execlist.c | 66 ++- drivers/gpu/drm

[Intel-gfx] [PATCH] MAINTAINERS: update new mail list for intel gvt driver

2017-01-24 Thread Zhenyu Wang
We've moved to lists.freedesktop.org from lists.01.org. Update info in MAINTAINERS. Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5f0420a..5bd03d5 100644 --- a/MAINT

Re: [Intel-gfx] [igvt-g-dev] [PATCH] drm/i915/gvt: Fix kmem_cache_create() name

2017-01-24 Thread Zhenyu Wang
On 2017.01.24 13:15:43 -0700, Alex Williamson wrote: > According to kmem_cache_sanity_check(), spaces are not allowed in the > name of a cache and results in a kernel oops with CONFIG_DEBUG_VM. > Convert to underscores. > > Signed-off-by: Alex Williamson > --- Will

Re: [Intel-gfx] [igvt-g-dev] [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance

2017-01-24 Thread Zhenyu Wang
On 2017.01.24 12:53:45 -0700, Alex Williamson wrote: > Per the ABI specification[1], each mdev_supported_types entry should > have an available_instances, with an "s", not available_instance. > > [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev > > Signed-off-by: Alex Williamson

[Intel-gfx] [GIT PULL] GVT-g fixes for 4.10-rc5

2017-01-15 Thread Zhenyu Wang
Hi, This pull contains vGPU/mdev reset fixes from Changbin to fix vGPU hang for VM reboot and vGPU/mdev instance reuse issues that might impact usage. Several preparation patches are to align reset code for each functional part and actual fix is just to reset device model state for all

Re: [Intel-gfx] [igvt-g-dev] [PATCH v2 2/3] drm/i915: Extract reserving space in the GTT to a helper

2017-01-11 Thread Zhenyu Wang
t; > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > Cc: igvt-g-...@lists.01.org > Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > --- Looks good for vgpu balloon change. Acked-by: Zhenyu Wang <zhen...@linux.intel.com> > drivers/gpu/drm

Re: [Intel-gfx] [PATCH 1/5] drm/i915: make intel_gvt_init() later instead of too early

2017-01-10 Thread Zhenyu Wang
On 2017.01.11 11:13:06 +0800, Jike Song wrote: > On 01/10/2017 02:52 PM, Zhenyu Wang wrote: > > Previously intel_gvt_init() was called very early even before > > MMIO initialization which had several drawbacks: > > - Have to handle MMIO access for initial MMIO state dump

Re: [Intel-gfx] [PATCH 2/5] drm/i915/gvt: move intel iommu detection to intel_gvt_init()

2017-01-10 Thread Zhenyu Wang
On 2017.01.11 10:18:30 +0800, Jike Song wrote: > On 01/10/2017 02:52 PM, Zhenyu Wang wrote: > > Prepare to remove detect_host() hook. Move intel iommu detection early > > in intel_gvt_init(). > > > > Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> > >

[Intel-gfx] [PATCH 3/5] drm/i915/gvt: remove detect_host() MPT hook

2017-01-09 Thread Zhenyu Wang
We only depend on pvinfo register for GVT-g state detection, not require hypervisor host detect any more. Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/gvt/gvt.c | 7 --- drivers/gpu/drm/i915/gvt/hypercall.h | 1 - drivers/gpu/drm/i915/gvt/k

[Intel-gfx] [PATCH 5/5] drm/i915/gvt: fix vgpu type size init

2017-01-09 Thread Zhenyu Wang
As now gvt init after knowing hw resource info, we can determine vGPU type from machine size instead of pre-defined value. Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/gvt/vgpu.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff

[Intel-gfx] [PATCH 4/5] drm/i915/gvt: use normal mmio read function for firmware exposure

2017-01-09 Thread Zhenyu Wang
As now gvt init is late after MMIO initialization, use normal MMIO read function for initial firmware exposure if no available firmware loaded. Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/gvt/firmware.c | 47 - 1 file c

[Intel-gfx] [PATCH 0/5] Fix issues caused by gvt init timing

2017-01-09 Thread Zhenyu Wang
This trys to change origin gvt init time which was too early that caused several workarounds be applied in GVT-g device model driver. To move gvt init a bit later, we can fix up those without workarounds. First one in series touches i915 driver init path that need to be acked. thanks Zhenyu

[Intel-gfx] [PATCH 2/5] drm/i915/gvt: move intel iommu detection to intel_gvt_init()

2017-01-09 Thread Zhenyu Wang
Prepare to remove detect_host() hook. Move intel iommu detection early in intel_gvt_init(). Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/gvt/gvt.c | 7 +++ drivers/gpu/drm/i915/gvt/kvmgt.c | 6 -- 2 files changed, 7 insertions(+), 6 deletions(-)

[Intel-gfx] [PATCH 1/5] drm/i915: make intel_gvt_init() later instead of too early

2017-01-09 Thread Zhenyu Wang
status. - Don't know hw resource size e.g aperture, ggtt size to determine for vGPU type, etc. This trys to move intel_gvt_init() call late after required info has already been initialized for GVT host. Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/gvt

[Intel-gfx] [GIT PULL] GVT-g fixes for 4.10-rc4

2017-01-09 Thread Zhenyu Wang
ags Nicolas Iooss (1): drm/i915/gvt: verify functions types in new_mmio_info() Pei Zhang (1): drm/i915/gvt: print correct value for untracked mmio Zhenyu Wang (2): drm/i915/gvt: adjust high memory size for default vGPU type drm/i915/gvt: remove duplicated definition driv

[Intel-gfx] [PATCH v2] drm/i915: check ppgtt validity when init reg state

2017-01-09 Thread Zhenyu Wang
Check if ppgtt is valid for context when init reg state. For gvt context which has no i915 allocated ppgtt, failed to check that would cause kernel null ptr reference error. v2: remove !48bit ppgtt case as we'll always update before submit (Chris) Signed-off-by: Zhenyu Wang <z

[Intel-gfx] [PATCH] drm/i915: check ppgtt validity when init reg state

2017-01-09 Thread Zhenyu Wang
Check if ppgtt is valid for context when init reg state. For gvt context which has no i915 allocated ppgtt, failed to check that would cause kernel null ptr reference error. Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/intel_lrc.

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix relocation of shadow bb

2017-01-08 Thread Zhenyu Wang
of the most strange construction. > Looks fine to me. I'll pick up this after validating with batch buffer scan on. Thanks. > Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner") > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Zhenyu Wang <zhen.

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree

2017-01-03 Thread Zhenyu Wang
On 2017.01.02 21:48:57 -0700, Alex Williamson wrote: > > Alex, I liked to have kvmgt related mdev interface change be merged through > > vfio tree, but wasn't awared one of Jike's fix had conflict. Could you apply > > below fix in your tree? I think in general for possible interface change in > >

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree

2017-01-02 Thread Zhenyu Wang
On 2017.01.03 10:42:39 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel-fixes tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/i915/gvt/kvmgt.c: In function 'intel_vgpu_open': > drivers/gpu/drm/i915/gvt/kvmgt.c:511:32: error:

Re: [Intel-gfx] [igvt-g-dev] [PATCH 1/1] drm/i915/gvt: verify functions types in new_mmio_info()

2016-12-26 Thread Zhenyu Wang
On 2016.12.26 14:52:23 +0100, Nicolas Iooss wrote: > The current prototype of new_mmio_info() uses void* for parameters read > and write, which are functions with precise calling conventions > (argument types and return type). Write down these conventions in > new_mmio_info() definition. > > This

[Intel-gfx] [GIT PULL] GVT-g fixes for 4.10

2016-12-26 Thread Zhenyu Wang
Hi, This is current GVT-g device model fixes for 4.10. I need to base on v4.10-rc1 for merged vfio and KVMGT support. Thanks. Merry Christmas! --- The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77: Linux 4.10-rc1 (2016-12-25 16:13:08 -0800) are available in the git

[Intel-gfx] [git pull] GVT-g fixes for 4.10

2016-12-22 Thread Zhenyu Wang
Hi, This is currently GVT-g driver fixes for 4.10-rc2. Thanks. --- The following changes since commit 0f484e42baaf5a38fc79e99b917caa5431651fb1: Merge tag 'kvmgt-vfio-mdev-for-v4.10-rc1' of git://github.com/01org/gvt-linux (2016-12-17 16:47:31 -0800) are available in the git repository

Re: [Intel-gfx] [CI 4/7] drm/i915: Simplify releasing context reference

2016-12-19 Thread Zhenyu Wang
On 2016.12.18 15:37:21 +, Chris Wilson wrote: > A few users only take the struct_mutex in order to release a reference > to a context. We can expose a kref_put_mutex() wrapper in order to > simplify these users, and optimise taking of the mutex to the final > unref. > > Signed-off-by: Chris

[Intel-gfx] [RESEND][GIT PULL] i915/gvt KVMGT tree for 4.10

2016-12-16 Thread Zhenyu Wang
Hi, Linus This is KVMGT pull for 4.10 as explained by Daniel. The last minute rebase is to appease git pull-request since the diffstat was obvious bonghits and somehow included vfio/mdev again despite that was merged already. Thanks. The following changes since commit

Re: [Intel-gfx] Guc parameter Handling

2016-12-15 Thread Zhenyu Wang
On 2016.12.15 22:36:40 +, Srivatsa, Anusha wrote: > Hi All, > > > > I was wondering if we intend to keep -1 and 2 for the enable_guc_submission > parameter. Since now we are gating guc loads if either guc_submission or > enable_huc parameter is set, why have a -1(platform default) and

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path

2016-12-04 Thread Zhenyu Wang
On 2016.12.04 23:57:18 +, Eric Engestrom wrote: > 90d27a1 moved the lock before this error path but forgot to add an > unlock here. > > Fixes: 90d27a1b180e51ef0713 ("drm/i915/gvt: fix deadlock in workload_thread") > Cc: Pei Zhang <pei.zh...@intel.

[Intel-gfx] [PULL] GVT-g device model fix

2016-11-30 Thread Zhenyu Wang
param.primary Xiaoguang Chen (1): drm/i915/gvt: fix getting 64bit bar size error Zhenyu Wang (1): drm/i915/gvt: fix lock not released bug for dispatch_workload() err path drivers/gpu/drm/i915/gvt/gvt.h | 2 ++ drivers/gpu/drm/i915/gvt/scheduler.c | 10 ++ drivers/gpu

Re: [Intel-gfx] [igvt-g-dev] [bug report] drm/i915/gvt: fix deadlock in workload_thread

2016-11-23 Thread Zhenyu Wang
On 2016.11.24 01:17:06 +0300, Dan Carpenter wrote: > Hello Pei Zhang, > > The patch 90d27a1b180e: "drm/i915/gvt: fix deadlock in > workload_thread" from Nov 14, 2016, leads to the following static > checker warning: > > drivers/gpu/drm/i915/gvt/scheduler.c:217 dispatch_workload() >

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Zhenyu Wang
et the guest modify the PT entry in > > >upper level PT first, then release the PT page. > > > > > >Cc: Michał Winiarski <michal.winiar...@intel.com> > > >Cc: Michel Thierry <michel.thie...@intel.com> > > >Cc: Joonas Lahtinen &

Re: [Intel-gfx] [igvt-g-dev] [PULL] GVT-g device model fixes

2016-11-17 Thread Zhenyu Wang
fix deadlock in workload_thread drm/i915/gvt: check workload empty before real scan Ping Gao (2): drm/i915/gvt: emulate right behavior for tlb_control drm/i915/gvt: add more MMIO regs with command access flag Xiaoguang Chen (1): drm/i915/gvt: clear guest opregion Zh

Re: [Intel-gfx] [igvt-g-dev] [PULL] GVT-g device model fixes

2016-11-16 Thread Zhenyu Wang
On 2016.11.16 15:50:27 +0800, Zhenyu Wang wrote: > > Hi, > > Please pull current GVT-g device model fixes. > Sorry, pls hold on this as found a possible conflict, as this is supposed to be last pull before 4.10 merge window, like to include the fix for that, will send update l

Re: [Intel-gfx] [PATCH v3] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-16 Thread Zhenyu Wang
ntext render registers. > This patch is to implement the correct logic in execlists_dequeue. > > v2: optimized code by following Chris's advice, and added more comments to > explain the patch. > v3: followed the coding style. > > Signed-off-by: Min He <min...@intel.com

Re: [Intel-gfx] [PATCH] drm/i915/gvt: drop checks for early Skylake revisions

2016-11-16 Thread Zhenyu Wang
On 2016.11.16 12:13:59 +0200, Jani Nikula wrote: > We no longer cater for pre-production revisions of Skylake. > > Fixes: d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on stepping > info") > Cc: Ping Gao <ping.a....@intel.com> > Cc: Zhenyu Wang <zh

[Intel-gfx] [PULL] GVT-g device model fixes

2016-11-15 Thread Zhenyu Wang
drm/i915/gvt: add more MMIO regs with command access flag Xiaoguang Chen (1): drm/i915/gvt: clear guest opregion Zhenyu Wang (1): drm/i915/gvt: Fix static checker warning on intel_gvt_i2c_handle_aux_ch_write() drivers/gpu/drm/i915/gvt/cmd_parser.c | 3 ++- drivers/gpu/drm

Re: [Intel-gfx] [igvt-g-dev] [bug report] drm/i915/gvt: vGPU display virtualization

2016-11-11 Thread Zhenyu Wang
On 2016.11.11 08:28:28 +, Chris Wilson wrote: > On Fri, Nov 11, 2016 at 04:08:58PM +0800, Zhenyu Wang wrote: > > > > On 2016.11.10 15:54:51 +0300, Dan Carpenter wrote: > > > Hello Zhi Wang, > > > > > > The patch 04d348ae3f0a: "drm/i915/gvt:

Re: [Intel-gfx] [igvt-g-dev] [bug report] drm/i915/gvt: vGPU display virtualization

2016-11-11 Thread Zhenyu Wang
On 2016.11.10 15:54:51 +0300, Dan Carpenter wrote: > Hello Zhi Wang, > > The patch 04d348ae3f0a: "drm/i915/gvt: vGPU display virtualization" > from Apr 25, 2016, leads to the following static checker warning: > > drivers/gpu/drm/i915/gvt/edid.c:506 intel_gvt_i2c_handle_aux_ch_write() >

[Intel-gfx] [PULL] GVT-g KVMGT framework

2016-11-10 Thread Zhenyu Wang
to MPT drm/i915/gvt: allow several MPT methods to be NULL drm/i915/gvt: refactor intel_gvt_io_emulation_ops to be intel_gvt_ops drm/i915/gvt: add KVMGT support Xiaoguang Chen (1): drm/i915/gvt: use kmap instead of kmap_atomic around guest memory access Zhenyu Wang (1

Re: [Intel-gfx] [PATCH i-g-t 2/4 v5] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

2016-11-09 Thread Zhenyu Wang
On 2016.11.03 18:28:11 +0200, Marius Vlad wrote: > v2: > - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson) > - do not hard-fail when i915 module could not be loaded/unloaded (Chris > Wilson) > > Signed-off-by: Marius Vlad <marius.c.v...@intel.com> Looks fine

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Disable access to stolen memory as a guest

2016-11-09 Thread Zhenyu Wang
her quirk we want to tell the user what is happening. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Zhenyu Wang <zhen...@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_gem_st

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Disable access to stolen memory as a guest

2016-11-09 Thread Zhenyu Wang
r all OS gfx drivers. But I think Chris's change is fine and I would polish GMCH_CTL handling patch. > > > The actual size should be reported as zero, but > > like every other quirk we want to tell the user what is happening. > > > > Signed-off-by: Chris Wilson <ch...@c

Re: [Intel-gfx] [PATCH 0/2] extend page_track for external usage

2016-11-08 Thread Zhenyu Wang
On 2016.11.07 10:17:54 +0100, Daniel Vetter wrote: > >> Paolo, for this case, do you think it's feasible we pick them through > >> drm/i915 merge path? As currently initial KVMGT patch sets require these > >> exported symbols, that's why I ask how we should handle this dependency. > > > > Then

[Intel-gfx] [PULL] GVT-g device model fixes

2016-11-07 Thread Zhenyu Wang
vt: remove unused variable 'execlist' drm/i915/gvt: add write vreg in MMIO DMA_CTRL handler drm/i915/gvt: correct the emulation in TLB control handler drm/i915/gvt: update misc ctl regs base on stepping info drm/i915/gvt: implement scratch page table tree for shadow PPGTT Z

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix workload status after wait

2016-11-02 Thread Zhenyu Wang
On 2016.11.02 08:47:52 +0200, Joonas Lahtinen wrote: > On ke, 2016-11-02 at 13:41 +0800, Zhenyu Wang wrote: > > From commit e95433c73a11759203af1cae5958f998c9673370, workload status > > setting > > was changed to only capture on error path, but we need to set it properly i

[Intel-gfx] [PATCH v2] drm/i915/gvt: Fix workload status after wait

2016-11-02 Thread Zhenyu Wang
: e95433c73a11 ("drm/i915: Rearrange i915_wait_request() accounting with callers") Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/gvt/scheduler.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dr

[Intel-gfx] [PATCH] drm/i915/gvt: Fix workload status after wait

2016-11-01 Thread Zhenyu Wang
.uk> Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/gvt/scheduler.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c index 18acb45..bc4c14a 100644 --- a/drivers/

[Intel-gfx] [PULL] GVT-g device model

2016-10-27 Thread Zhenyu Wang
in skl_decode_mi_display_flip Ping Gao (3): drm/i915/gvt: add vreg write for GDRST handler drm/i915/gvt: correct the reset logic drm/i915/gvt: add full vGPU reset support Xiaoguang Chen (1): drm/i915/gvt: fix detect_host calling logic Zhenyu Wang (3): drm/i915/gvt: Fix failure when

Re: [Intel-gfx] fail to build on 32-bit x86 report

2016-10-26 Thread Zhenyu Wang
On 2016.10.26 11:14:26 +1000, Dave Airlie wrote: > http://kisskb.ellerman.id.au/kisskb/buildresult/12840554/ > > Since the GVT stuff it looks like some divide should be a do_div. > yeah, we will fix 32bit build later, I plan to send another pull tomorrow or the day after which will disable

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: fix compilation errors in gtt.c

2016-10-24 Thread Zhenyu Wang
On 2016.10.24 15:33:34 -0400, Jérémy Lefaure wrote: > On Mon, 24 Oct 2016 10:36:58 +0800 > Zhenyu Wang <zhen...@linux.intel.com> wrote: > > > On 2016.10.20 18:05:56 -0400, Jérémy Lefaure wrote: > > > This series fixes 2 compilations errors in gvt/gtt.c on 32-bits pl

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: fix compilation errors in gtt.c

2016-10-23 Thread Zhenyu Wang
On 2016.10.20 18:05:56 -0400, Jérémy Lefaure wrote: > This series fixes 2 compilations errors in gvt/gtt.c on 32-bits platform: > [PATCH 1/2] drm/i915/gvt: fix bad 32 bit shift in gtt > [PATCH 2/2] drm/i915/gvt: fix an error string format > > The file gtt.c still does not compile because of

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: fix compilation

2016-10-21 Thread Zhenyu Wang
On 2016.10.21 17:25:50 +0200, Arnd Bergmann wrote: > Two functions in the newly added gvt render code are obviously > broken, as they reference a variable without initialization and > don't reference another variable at all: > > drivers/gpu/drm/i915/gvt/render.c: In function >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: add ACPI and 64BIT dependencies

2016-10-21 Thread Zhenyu Wang
On 2016.10.21 17:25:49 +0200, Arnd Bergmann wrote: > The newly added gvt code produces lots of serious warnings and errors > when either built on 32-bit x86, or built with ACPI disabled, e.g. > > drivers/gpu/drm/i915/gvt/gtt.c: In function ???read_pte64???: > drivers/gpu/drm/i915/gvt/gtt.c:277:2:

Re: [Intel-gfx] [patch] drm/i915/gvt: cleanup a type issue in submit_context()

2016-10-21 Thread Zhenyu Wang
On 2016.10.21 13:27:22 +0300, Dan Carpenter wrote: > On Fri, Oct 21, 2016 at 04:27:38PM +0800, Zhenyu Wang wrote: > > On 2016.10.21 11:06:01 +0300, Dan Carpenter wrote: > > > submit_context() should return negative error codes and zero on success > > > but by mista

Re: [Intel-gfx] [patch] drm/i915/gvt: cleanup a type issue in submit_context()

2016-10-21 Thread Zhenyu Wang
On 2016.10.21 11:06:01 +0300, Dan Carpenter wrote: > submit_context() should return negative error codes and zero on success > but by mistake we made it a bool. I've changed it to int. Also I made > it static because this isn't referenced in any other files. > > This doesn't affect runtime

Re: [Intel-gfx] [PATCH] drm/i915: GVT-g driver depends on 64BIT kernel

2016-10-21 Thread Zhenyu Wang
On 2016.10.21 09:05:21 +0100, Chris Wilson wrote: > On Fri, Oct 21, 2016 at 12:38:59PM +0800, Zhenyu Wang wrote: > > We currently don't support GVT-g driver on i386 kernel. > > Add explicit dependence on 64bit kernel. > > Can we at least get clean compilation on 32bit? Tha

[Intel-gfx] [PULL] GVT-g fixes

2016-10-21 Thread Zhenyu Wang
kernel Zhenyu Wang (2): drm/i915/gvt: Fix failure when ACPI is not enabled drm/i915: GVT-g driver depends on 64BIT kernel drivers/gpu/drm/i915/Kconfig| 1 + drivers/gpu/drm/i915/gvt/opregion.c | 6 +++--- 2 files

[Intel-gfx] [PATCH] drm/i915: GVT-g driver depends on 64BIT kernel

2016-10-20 Thread Zhenyu Wang
We currently don't support GVT-g driver on i386 kernel. Add explicit dependence on 64bit kernel. Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/K

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Implement WaForceWakeRenderDuringMmioTLBInvalidate

2016-10-20 Thread Zhenyu Wang
t; > the process, therefore the need for render forcewake for the whole > > > procedure. > > > > > > This WA is needed for all production SKL SKUs. > > > > > > References: HSD#2136899, HSD#1404391274 > > > Cc: Mika Kuoppala <mika.kuopp...

Re: [Intel-gfx] linux-next: Tree for Oct 20 (gpu/drm/i915)

2016-10-20 Thread Zhenyu Wang
On 2016.10.20 21:25:03 +0300, Jani Nikula wrote: > On Thu, 20 Oct 2016, Daniel Vetter wrote: > > On Thu, Oct 20, 2016 at 7:37 PM, Randy Dunlap wrote: > >> On 10/19/16 20:20, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Changes since 20161019: > >>> >

Re: [Intel-gfx] i915 and GTV-g maintenance, workflows and CI

2016-10-20 Thread Zhenyu Wang
On 2016.10.20 11:01:02 +0100, Chris Wilson wrote: > On Thu, Oct 20, 2016 at 05:42:37PM +0800, Zhenyu Wang wrote: > > On 2016.10.20 11:24:21 +0200, Daniel Vetter wrote: > > > On Thu, Oct 20, 2016 at 12:02:54PM +0300, Jani Nikula wrote: > > > > > > > > We

[Intel-gfx] [PULL] GVT-g device model core fixes

2016-10-20 Thread Zhenyu Wang
, Changbin (4): drm/i915/gvt: fix sparse warnings on different address spaces drm/i915/gvt: mark symbols static where possible drm/i915/gvt: fix spare warnings on odd constant _Bool cast drm/i915/gvt: do not ignore return value of create_scratch_page Zhenyu Wang (5): drm/i915

Re: [Intel-gfx] i915 and GTV-g maintenance, workflows and CI

2016-10-20 Thread Zhenyu Wang
; Either that, or they need to send -fixes pull requests your way. I think > we could try out either approach, but yes in the end gvt maintainers need > to own this. We (i915 team here) won't take care of that. > yeah, I think we should follow that way. > > * Should GVT-g h

[Intel-gfx] [PATCH v3] drm/i915/gvt: clean up intel_gvt.h as interface for i915 core

2016-10-20 Thread Zhenyu Wang
dev_priv->gvt assignment - add necessary bracket for macro helper - forward declartion struct intel_gvt - keep free operation within same file handling alloc v3: fix use after free and remove intel_gvt.initialized Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm

Re: [Intel-gfx] [PATCH v2] drm/i915/gvt: clean up intel_gvt.h as interface for i915 core

2016-10-20 Thread Zhenyu Wang
On 2016.10.20 09:12:02 +0100, Chris Wilson wrote: > On Thu, Oct 20, 2016 at 04:02:39PM +0800, Zhenyu Wang wrote: > > void intel_gvt_clean_device(struct drm_i915_private *dev_priv) > > { > > - struct intel_gvt *gvt = _priv->gvt; > > + struct in

[Intel-gfx] [PATCH v2] drm/i915/gvt: clean up intel_gvt.h as interface for i915 core

2016-10-20 Thread Zhenyu Wang
dev_priv->gvt assignment - add necessary bracket for macro helper - forward declartion struct intel_gvt - keep free operation within same file handling alloc Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/gvt/aperture_gm.c | 1 + drivers/gpu/drm/i915/gvt/cf

Re: [Intel-gfx] [PATCH 07/12] drm/i915/gvt: Hold a reference on the request

2016-10-20 Thread Zhenyu Wang
On 2016.10.20 07:52:18 +0100, Chris Wilson wrote: > On Thu, Oct 20, 2016 at 08:22:00AM +0800, Zhenyu Wang wrote: > > On 2016.10.19 11:11:42 +0100, Chris Wilson wrote: > > > The workload took a pointer to the request, and even waited upon, > > > without holding a ref

[Intel-gfx] [PATCH] drm/i915/gvt: clean up intel_gvt.h as interface for i915 core

2016-10-20 Thread Zhenyu Wang
i915 core should only call functions and structures exposed through intel_gvt.h. Remove internal gvt.h and i915_pvinfo.h. Change for internal intel_gvt structure as private handler which not requires to expose gvt internal structure for i915 core. Signed-off-by: Zhenyu Wang <z

[Intel-gfx] [PATCH] Documentation/gpu: Add section for Intel GVT-g host support

2016-10-20 Thread Zhenyu Wang
Update with brief overview and reference for more detailed arch design documents. Add new section for Intel GVT-g host support. Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- Documentation/gpu/i915.rst | 9 + drivers/gpu/drm/i915/intel_gvt.c | 8 ++-- 2 files c

Re: [Intel-gfx] gvt gem fixes

2016-10-20 Thread Zhenyu Wang
On 2016.10.20 09:02:45 +0200, Daniel Vetter wrote: > Yeah, I think anything that touches i915 code should get merged through > drm-intel directly with the usual process. Only exception is when gvt has > a functional depency and it's a small patch, then I think we can sometimes > merge i915 core

Re: [Intel-gfx] gvt gem fixes

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 12:02:58 +0100, Chris Wilson wrote: > On Wed, Oct 19, 2016 at 06:45:51PM +0800, Zhenyu Wang wrote: > > On 2016.10.19 11:11:35 +0100, Chris Wilson wrote: > > > I think this is the set required to bring gvt into line, at least to > > > unblock myself. > &

Re: [Intel-gfx] [PATCH 07/12] drm/i915/gvt: Hold a reference on the request

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 11:11:42 +0100, Chris Wilson wrote: > The workload took a pointer to the request, and even waited upon, > without holding a reference on the request. Take that reference > explicitly and fix up the error path following request allocation that > missed flushing the request. > >

Re: [Intel-gfx] [PATCH -next] drm/i915/gvt: fix return value check

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 16:18:03 +, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function i915_gem_object_create() returns > ERR_PTR() not NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun

Re: [Intel-gfx] gvt gem fixes

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 11:11:35 +0100, Chris Wilson wrote: > I think this is the set required to bring gvt into line, at least to > unblock myself. Thanks a lot, Chris. I'd like to merge this in next pull request, or let me know you want to be picked up by drm-intel directly. If 4/12 would be picked up

Re: [Intel-gfx] [PATCH 07/12] drm/i915/gvt: Hold a reference on the request

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 11:11:42 +0100, Chris Wilson wrote: > The workload took a pointer to the request, and even waited upon, > without holding a reference on the request. Take that reference > explicitly and fix up the error path following request allocation that > missed flushing the request. > >

Re: [Intel-gfx] [PATCH 10/12] drm/i915/gvt: Use common mapping routines for indirect_ctx object

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 11:11:45 +0100, Chris Wilson wrote: > We have the ability to map an object, so use it rather than opencode it > badly. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Planned to fix these mapping too, obviously not fast than you.. Reviewed-by:

Re: [Intel-gfx] [PATCH v2] drm/i915/gvt: Stop waiting whilst holding struct_mutex

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 10:14:39 +0100, Chris Wilson wrote: > For whatever reason, the gvt scheduler runs synchronously. At the very > least, lets run synchronously without holding the struct_mutex. > > v2: cut'n'paste mutex_lock instead of unlock. > Replace long hold of struct_mutex with a mutex to

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Stop waiting whilst holding struct_mutex

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 09:12:28 +0100, Chris Wilson wrote: > For whatever reason, the gvt scheduler runs synchronously. At the very > least, lets run synchronously without holding the struct_mutex. > > Signed-off-by: Chris Wilson This will break current device model which

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Use the returned VMA to provide the virtual address

2016-10-19 Thread Zhenyu Wang
n.co.uk> Reviewed-by: Zhenyu Wang <zhen...@linux.intel.com> > --- > drivers/gpu/drm/i915/gvt/execlist.c | 20 +--- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c > b/drivers/gpu/drm/i915/gvt/execlis

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Stop checking for impossible interrupts from a kthread

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 09:12:27 +0100, Chris Wilson wrote: > The kthread will not be interrupted, don't even bother checking. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Reviewed-by: Zhenyu Wang <zhen...@linux.intel.com> > --- > drivers/gpu/drm/i915/gvt/sch

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 08:50:21 +0100, Chris Wilson wrote: > On Fri, Oct 14, 2016 at 06:30:30PM +0800, Zhenyu Wang wrote: > > > > Hi, > > > > This is first pull request to merge GVT-g device model in i915 > > which contains core GVT-g device model work to virtualize GPU

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: i915_gem_object_create() returns an error pointer

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 08:51:33 +0100, Chris Wilson wrote: > On Wed, Oct 19, 2016 at 03:45:19PM +0800, Zhenyu Wang wrote: > > On 2016.10.19 08:42:50 +0100, Chris Wilson wrote: > > > On failure from i915_gem_object_create(), we need to check for an error > > > pointer not NU

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: i915_gem_object_create() returns an error pointer

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 08:42:50 +0100, Chris Wilson wrote: > On failure from i915_gem_object_create(), we need to check for an error > pointer not NULL. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Reviewed-by: Zhenyu Wang <zhen...@linux.intel.com> Thanks, Chris. Lo

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: s/drm_gem_object_unreference/i915_gem_object_put/

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 08:42:49 +0100, Chris Wilson wrote: > Deprecated functions; it is also not clear whether these are called from > the right context. > > Signed-off-by: Chris Wilson Thanks, Chris. Already did a same fix on

Re: [Intel-gfx] linux-next: build warnings after merge of the drm-intel tree

2016-10-18 Thread Zhenyu Wang
On 2016.10.19 10:57:53 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel tree, today's linux-next build (x86_64 > allmodconfig) produced these warnings: > > drivers/gpu/drm/i915/gvt/execlist.c: In function > 'release_shadow_batch_buffer': >

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-18 Thread Zhenyu Wang
On 2016.10.18 14:59:14 +0300, Jani Nikula wrote: > On Mon, 17 Oct 2016, Jani Nikula wrote: > > On Mon, 17 Oct 2016, Daniel Vetter wrote: > >> Ok applied, but a few things to keep in mind before your next pull > >> request: > >> > >> - Dont rebase

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-18 Thread Zhenyu Wang
On 2016.10.18 09:47:56 +0300, Joonas Lahtinen wrote: > On ti, 2016-10-18 at 09:40 +0800, Zhenyu Wang wrote: > > @@ -134,7 +134,7 @@ static int render_mmio_to_ring_id(struct intel_gvt > > *gvt, unsigned int reg) > >   > >   reg &= ~GENMASK(11, 0); > >  

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Zhenyu Wang
On 2016.10.18 05:39:11 +, Saarinen, Jani wrote: > > == Series Details == > > > > Series: drm/i915/gvt: Fix build failure after intel_engine_cs change > > URL : https://patchwork.freedesktop.org/series/13910/ > > State : failure > > > > == Summary == > > > > Series 13910v1 drm/i915/gvt:

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-17 Thread Zhenyu Wang
On 2016.10.17 16:07:50 +0200, Daniel Vetter wrote: > Yeah might be best to have a new branch with upstreaming stuff (now you > need to at least split out bugfixes for the already merged stuff) and > treat that like a mostly stable branch. And the still unmerged features > (vfio and all that) would

[Intel-gfx] [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Zhenyu Wang
Change GVT-g code reference for intel_engine_cs from static array to allocated pointer after commit 3b3f1650b1ca ("drm/i915: Allocate intel_engine_cs structure only for the enabled engines"). Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/gvt

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-17 Thread Zhenyu Wang
On 2016.10.17 09:33:19 +0200, Daniel Vetter wrote: > On Mon, Oct 17, 2016 at 09:30:45AM +0200, Daniel Vetter wrote: > > On Fri, Oct 14, 2016 at 06:30:30PM +0800, Zhenyu Wang wrote: > > > > > > Hi, > > > > > > This is first pull request to merge GV

[Intel-gfx] [PULL] GVT-g device model core

2016-10-14 Thread Zhenyu Wang
Hi, This is first pull request to merge GVT-g device model in i915 which contains core GVT-g device model work to virtualize GPU resources. This tries to add feature of Intel GVT-g technology for full GPU virtualization. This version will support KVM based virtualization solution named as KVMGT.

Re: [Intel-gfx] [PATCH 0/2] GVT-g guest patch for 4.8

2016-09-06 Thread Zhenyu Wang
On 2016.09.06 11:33:57 +0300, Jani Nikula wrote: > On Tue, 06 Sep 2016, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > > On Tue, Sep 06, 2016 at 12:04:10PM +0800, Zhenyu Wang wrote: > >> Hi, > >> > >> Here're two patches for GVT-g guest to fix run ag

[Intel-gfx] [PATCH 2/2] drm/i915: disable 48bit full PPGTT when vGPU is active

2016-09-05 Thread Zhenyu Wang
From: Zhi Wang <zhi.a.w...@intel.com> Disable 48bit full PPGTT on vGPU too for now. Signed-off-by: Zhi Wang <zhi.a.w...@intel.com> Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 9 ++--- 1 file changed, 6 insertions(+), 3

[Intel-gfx] [PATCH 0/2] GVT-g guest patch for 4.8

2016-09-05 Thread Zhenyu Wang
Hi, Here're two patches for GVT-g guest to fix run against future GVT-g host driver, which try to ensure 4.8 will be ready to use for VM. thanks. Ping Gao (1): drm/i915: enable vGPU detection for all Zhi Wang (1): drm/i915: disable 48bit full PPGTT when vGPU is active

<    1   2   3   4   5   6   7   8   >