Re: [Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-11 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 7067 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -2

Re: [Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-10 Thread Daniel Vetter
On Thu, Aug 06, 2015 at 03:06:40PM +0200, Daniel Vetter wrote: We want to make sure that no one tries to acquire more locks and states, and ww mutexes provide debug facilities for that. So use them. v2: Only call acquire_done when -atomic_check was successful to avoid falling over an

[Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-06 Thread Daniel Vetter
We want to make sure that no one tries to acquire more locks and states, and ww mutexes provide debug facilities for that. So use them. v2: Only call acquire_done when -atomic_check was successful to avoid falling over an -EDEADLK (spotted by Maarten). Cc: Rob Clark robdcl...@gmail.com Cc:

Re: [Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-06 Thread Daniel Vetter
On Thu, Aug 06, 2015 at 06:17:28AM +0200, Maarten Lankhorst wrote: Op 06-08-15 om 00:25 schreef Daniel Vetter: On Wed, Aug 5, 2015 at 8:13 PM, Maarten Lankhorst maarten.lankho...@linux.intel.com wrote: Op 05-08-15 om 17:03 schreef Daniel Vetter: On Wed, Aug 5, 2015 at 4:57 PM, Maarten

[Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-05 Thread Daniel Vetter
We want to make sure that no one tries to acquire more locks and states, and ww mutexes provide debug facilities for that. So use them. Cc: Rob Clark robdcl...@gmail.com Cc: Maarten Lankhorst maarten.lankho...@linux.intel.com Signed-off-by: Daniel Vetter daniel.vet...@intel.com ---

Re: [Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-05 Thread Daniel Vetter
On Wed, Aug 5, 2015 at 4:57 PM, Maarten Lankhorst maarten.lankho...@linux.intel.com wrote: Op 05-08-15 om 15:08 schreef Daniel Vetter: We want to make sure that no one tries to acquire more locks and states, and ww mutexes provide debug facilities for that. So use them. Cc: Rob Clark

Re: [Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-05 Thread Maarten Lankhorst
Hey, Op 05-08-15 om 15:08 schreef Daniel Vetter: We want to make sure that no one tries to acquire more locks and states, and ww mutexes provide debug facilities for that. So use them. Cc: Rob Clark robdcl...@gmail.com Cc: Maarten Lankhorst maarten.lankho...@linux.intel.com Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-05 Thread Maarten Lankhorst
Op 05-08-15 om 17:03 schreef Daniel Vetter: On Wed, Aug 5, 2015 at 4:57 PM, Maarten Lankhorst maarten.lankho...@linux.intel.com wrote: Op 05-08-15 om 15:08 schreef Daniel Vetter: We want to make sure that no one tries to acquire more locks and states, and ww mutexes provide debug facilities

Re: [Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-05 Thread Maarten Lankhorst
Op 06-08-15 om 00:25 schreef Daniel Vetter: On Wed, Aug 5, 2015 at 8:13 PM, Maarten Lankhorst maarten.lankho...@linux.intel.com wrote: Op 05-08-15 om 17:03 schreef Daniel Vetter: On Wed, Aug 5, 2015 at 4:57 PM, Maarten Lankhorst maarten.lankho...@linux.intel.com wrote: Op 05-08-15 om 15:08

Re: [Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-05 Thread Daniel Vetter
On Wed, Aug 5, 2015 at 8:13 PM, Maarten Lankhorst maarten.lankho...@linux.intel.com wrote: Op 05-08-15 om 17:03 schreef Daniel Vetter: On Wed, Aug 5, 2015 at 4:57 PM, Maarten Lankhorst maarten.lankho...@linux.intel.com wrote: Op 05-08-15 om 15:08 schreef Daniel Vetter: We want to make sure