Re: [Intel-gfx] [PATCH] drm/i915/tgl: Put HDC flush pipe_control bit in the right dword

2020-05-05 Thread D Scott Phillips
Lionel Landwerlin writes: > On 05/05/2020 03:09, D Scott Phillips wrote: >> D Scott Phillips writes: >> >>> Previously we set HDC_PIPELINE_FLUSH in dword 1 of gen12 >>> pipe_control commands. HDC Pipeline flush actually resides in >>> dword 0, and the bit we were setting in dword 1 was Indirect

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Put HDC flush pipe_control bit in the right dword

2020-05-05 Thread Lionel Landwerlin
On 05/05/2020 03:09, D Scott Phillips wrote: D Scott Phillips writes: Previously we set HDC_PIPELINE_FLUSH in dword 1 of gen12 pipe_control commands. HDC Pipeline flush actually resides in dword 0, and the bit we were setting in dword 1 was Indirect State Pointers Disable, which invalidates in

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Put HDC flush pipe_control bit in the right dword

2020-05-04 Thread Kenneth Graunke
On Monday, May 4, 2020 5:01:46 PM PDT D Scott Phillips wrote: > Previously we set HDC_PIPELINE_FLUSH in dword 1 of gen12 > pipe_control commands. HDC Pipeline flush actually resides in > dword 0, and the bit we were setting in dword 1 was Indirect State > Pointers Disable, which invalidates indirec

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Put HDC flush pipe_control bit in the right dword

2020-05-04 Thread D Scott Phillips
D Scott Phillips writes: > Previously we set HDC_PIPELINE_FLUSH in dword 1 of gen12 > pipe_control commands. HDC Pipeline flush actually resides in > dword 0, and the bit we were setting in dword 1 was Indirect State > Pointers Disable, which invalidates indirect state in the render > context. Th

[Intel-gfx] [PATCH] drm/i915/tgl: Put HDC flush pipe_control bit in the right dword

2020-05-04 Thread D Scott Phillips
Previously we set HDC_PIPELINE_FLUSH in dword 1 of gen12 pipe_control commands. HDC Pipeline flush actually resides in dword 0, and the bit we were setting in dword 1 was Indirect State Pointers Disable, which invalidates indirect state in the render context. This causes failures for userspace, as