Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-18 Thread Daniel Vetter
On Thu, Aug 17, 2017 at 12:46:53PM -0700, Manasi Navare wrote: > On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > >On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare > ><[1]manasi.d.nav...@intel.com> wrote: > > > > In case of eDP because the panel has a fixed mode we

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Dhinakaran Pandiyan
On Thursday, August 17, 2017 1:44:14 PM PDT Rodrigo Vivi wrote: > On Thu, Aug 17, 2017 at 1:11 PM, Pandiyan, Dhinakaran > > wrote: > > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: > >> On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > >> >

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Manasi Navare
On Thu, Aug 17, 2017 at 01:44:14PM -0700, Rodrigo Vivi wrote: > On Thu, Aug 17, 2017 at 1:11 PM, Pandiyan, Dhinakaran > wrote: > > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: > >> On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > >> >On

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Manasi Navare
On Thu, Aug 17, 2017 at 02:01:05PM -0700, Manasi Navare wrote: > On Thu, Aug 17, 2017 at 01:11:00PM -0700, Pandiyan, Dhinakaran wrote: > > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: > > > On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > > > >On Wed, Aug 16, 2017 at

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Manasi Navare
On Thu, Aug 17, 2017 at 01:11:00PM -0700, Pandiyan, Dhinakaran wrote: > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: > > On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > > >On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare > > ><[1]manasi.d.nav...@intel.com> wrote: >

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Rodrigo Vivi
On Thu, Aug 17, 2017 at 1:11 PM, Pandiyan, Dhinakaran wrote: > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: >> On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: >> >On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare >> >

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Pandiyan, Dhinakaran
On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: > On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > >On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare > ><[1]manasi.d.nav...@intel.com> wrote: > > > > In case of eDP because the panel has a fixed mode we cannot > >

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Manasi Navare
On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: >On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare ><[1]manasi.d.nav...@intel.com> wrote: > > In case of eDP because the panel has a fixed mode we cannot > link train fallback and prune modes since this results in >

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Manasi Navare
On Thu, Aug 17, 2017 at 12:28:56PM -0700, Pandiyan, Dhinakaran wrote: > On Thu, 2017-08-17 at 12:29 -0700, Manasi Navare wrote: > > On Thu, Aug 17, 2017 at 12:51:27PM +0300, Jani Nikula wrote: > > > On Wed, 16 Aug 2017, Manasi Navare wrote: > > > > In case of eDP

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Pandiyan, Dhinakaran
On Thu, 2017-08-17 at 12:29 -0700, Manasi Navare wrote: > On Thu, Aug 17, 2017 at 12:51:27PM +0300, Jani Nikula wrote: > > On Wed, 16 Aug 2017, Manasi Navare wrote: > > > In case of eDP because the panel has a fixed mode we cannot > > > link train fallback and prune

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Manasi Navare
On Thu, Aug 17, 2017 at 12:51:27PM +0300, Jani Nikula wrote: > On Wed, 16 Aug 2017, Manasi Navare wrote: > > In case of eDP because the panel has a fixed mode we cannot > > link train fallback and prune modes since this results in > > no modes available for eDP

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Jani Nikula
On Wed, 16 Aug 2017, Manasi Navare wrote: > In case of eDP because the panel has a fixed mode we cannot > link train fallback and prune modes since this results in > no modes available for eDP connector. > Also since its a panel, link training should not fail

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Rodrigo Vivi
On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare wrote: > In case of eDP because the panel has a fixed mode we cannot > link train fallback and prune modes since this results in > no modes available for eDP connector. What about downclock modes?! > > Also since its a

[Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

2017-08-17 Thread Manasi Navare
In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector. Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP. Cc: Jani Nikula