Re: [Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-05 Thread Ben Widawsky
On Sun, 4 Sep 2011 20:52:42 -0700 Ben Widawsky b...@bwidawsk.net wrote: While I think the previous code is correct, it was hard to follow and hard to debug. Since we already have a ring abstraction, might as well use it to handle the semaphore updates and compares. I don't expect this code

[Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-04 Thread Ben Widawsky
While I think the previous code is correct, it was hard to follow and hard to debug. Since we already have a ring abstraction, might as well use it to handle the semaphore updates and compares. I don't expect this code to make semaphores better or worse, but you never know... Cc: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-03 Thread Ben Widawsky
On Fri, 02 Sep 2011 12:10:28 -0700 Eric Anholt e...@anholt.net wrote: On Thu, 1 Sep 2011 20:55:35 -0700, Ben Widawsky b...@bwidawsk.net wrote: While I think the previous code is correct, it was hard to follow and hard to debug. Since we already have a ring abstraction, might as well use

Re: [Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-03 Thread Keith Packard
On Sat, 3 Sep 2011 13:09:47 -0700, Ben Widawsky b...@bwidawsk.net wrote: Keith, worth cleaning this one up? Yes, I think so. If nothing else, we'll have more people who actually understand how the code is supposed to work, which should help with future maintenance. -- keith.pack...@intel.com

Re: [Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-02 Thread Chris Wilson
On Thu, 1 Sep 2011 20:55:35 -0700, Ben Widawsky b...@bwidawsk.net wrote: While I think the previous code is correct, it was hard to follow and hard to debug. Since we already have a ring abstraction, might as well use it to handle the semaphore updates and compares. I don't expect this code

Re: [Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-02 Thread Ben Widawsky
On Fri, Sep 02, 2011 at 09:54:32AM +0100, Chris Wilson wrote: On Thu, 1 Sep 2011 20:55:35 -0700, Ben Widawsky b...@bwidawsk.net wrote: While I think the previous code is correct, it was hard to follow and hard to debug. Since we already have a ring abstraction, might as well use it to

Re: [Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-02 Thread Eric Anholt
On Thu, 1 Sep 2011 20:55:35 -0700, Ben Widawsky b...@bwidawsk.net wrote: While I think the previous code is correct, it was hard to follow and hard to debug. Since we already have a ring abstraction, might as well use it to handle the semaphore updates and compares. I don't expect this code

[Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-01 Thread Ben Widawsky
While I think the previous code is correct, it was hard to follow and hard to debug. Since we already have a ring abstraction, might as well use it to handle the semaphore updates and compares. I don't expect this code to make semaphores better or worse, but you never know... Cc: Andrew