Re: [Intel-gfx] [PATCH] drm/i915: Fix runtime pm inbalance due to reg I/O forcewake dance

2014-03-14 Thread Jesse Barnes
On Fri, 14 Mar 2014 09:52:47 +0100 Daniel Vetter wrote: > On Fri, Mar 14, 2014 at 9:34 AM, Ville Syrjälä > wrote: > >> Heh, I went the other way round, dropped the runtime pm put from the > >> timer and flushed the forcewaker timer when we suspended the device... > > > > That's what I meant. No

Re: [Intel-gfx] [PATCH] drm/i915: Fix runtime pm inbalance due to reg I/O forcewake dance

2014-03-14 Thread Daniel Vetter
On Fri, Mar 14, 2014 at 9:34 AM, Ville Syrjälä wrote: >> Heh, I went the other way round, dropped the runtime pm put from the >> timer and flushed the forcewaker timer when we suspended the device... > > That's what I meant. No delayed runtime_pm_put. Well I've figured we want to keep this ... ha

Re: [Intel-gfx] [PATCH] drm/i915: Fix runtime pm inbalance due to reg I/O forcewake dance

2014-03-14 Thread Ville Syrjälä
On Fri, Mar 14, 2014 at 08:24:00AM +, Chris Wilson wrote: > On Fri, Mar 14, 2014 at 10:18:47AM +0200, Ville Syrjälä wrote: > > On Fri, Mar 14, 2014 at 08:48:46AM +0100, Daniel Vetter wrote: > > > This regression has been introduced in > > > > > > commit 8232644ccf099548710843e97360a3fcd6d28e04

Re: [Intel-gfx] [PATCH] drm/i915: Fix runtime pm inbalance due to reg I/O forcewake dance

2014-03-14 Thread Chris Wilson
On Fri, Mar 14, 2014 at 10:18:47AM +0200, Ville Syrjälä wrote: > On Fri, Mar 14, 2014 at 08:48:46AM +0100, Daniel Vetter wrote: > > This regression has been introduced in > > > > commit 8232644ccf099548710843e97360a3fcd6d28e04 > > Author: Chris Wilson > > Date: Wed Mar 5 12:00:39 2014 + > >

Re: [Intel-gfx] [PATCH] drm/i915: Fix runtime pm inbalance due to reg I/O forcewake dance

2014-03-14 Thread Ville Syrjälä
On Fri, Mar 14, 2014 at 08:48:46AM +0100, Daniel Vetter wrote: > This regression has been introduced in > > commit 8232644ccf099548710843e97360a3fcd6d28e04 > Author: Chris Wilson > Date: Wed Mar 5 12:00:39 2014 + > > drm/i915: Convert the forcewake worker into a timer func > > which s

[Intel-gfx] [PATCH] drm/i915: Fix runtime pm inbalance due to reg I/O forcewake dance

2014-03-14 Thread Daniel Vetter
This regression has been introduced in commit 8232644ccf099548710843e97360a3fcd6d28e04 Author: Chris Wilson Date: Wed Mar 5 12:00:39 2014 + drm/i915: Convert the forcewake worker into a timer func which started to use the delayed forcewake put also for the register I/O forcewake dance