Re: [Intel-gfx] [PATCH] drm/i915: support low power watermarks on Ironlake

2010-12-23 Thread Chris Wilson
On Tue, 21 Dec 2010 13:10:23 -0800, Jesse Barnes jbar...@virtuousgeek.org wrote: This patch actually makes the watermark code even uglier (if that's possible), but has the advantage of sharing code between SNB and ILK at least. Longer term we should refactor the watermark stuff into its own

Re: [Intel-gfx] [PATCH] drm/i915: support low power watermarks on Ironlake

2010-12-23 Thread Chris Wilson
On Thu, 23 Dec 2010 12:07:22 +, Chris Wilson ch...@chris-wilson.co.uk wrote: I tweaked the patch to pass the watermark structs through to the check routine. The box survives s2ram, but I have now also experienced the mysterious slow down after resuming. As Eric first said the cause for

Re: [Intel-gfx] [PATCH] drm/i915: support low power watermarks on Ironlake

2010-12-23 Thread Eric Anholt
On Thu, 23 Dec 2010 12:30:29 +, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, 23 Dec 2010 12:07:22 +, Chris Wilson ch...@chris-wilson.co.uk wrote: I tweaked the patch to pass the watermark structs through to the check routine. The box survives s2ram, but I have now also

[Intel-gfx] [PATCH] drm/i915: support low power watermarks on Ironlake

2010-12-21 Thread Jesse Barnes
This patch actually makes the watermark code even uglier (if that's possible), but has the advantage of sharing code between SNB and ILK at least. Longer term we should refactor the watermark stuff into its own file and clean it up now that we know how it's supposed to work. Supporting WM2 on my