Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: Fix the math in intel_dp_link_required

2011-10-17 Thread Adam Jackson
On Fri, 2011-10-14 at 23:11 -0700, Keith Packard wrote: On Fri, 14 Oct 2011 12:43:49 -0400, Adam Jackson a...@redhat.com wrote: The previous code was confused about units, which is pretty reasonable given that the units themselves are confusing. Thanks for actually figuring this out; the

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: Fix the math in intel_dp_link_required

2011-10-17 Thread Keith Packard
On Mon, 17 Oct 2011 13:03:02 -0400, Adam Jackson a...@redhat.com wrote: [drm:drm_mode_debug_printmodeline], Modeline 28: 0 154000 1920 1968 2000 2080 1200 1203 1209 1235 0x0 0x9 [drm:intel_dp_mode_fixup], Display port link bw 0a lane count 2 clock 27 Ok, nice to see that you've actually

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: Fix the math in intel_dp_link_required

2011-10-15 Thread Keith Packard
On Fri, 14 Oct 2011 12:43:49 -0400, Adam Jackson a...@redhat.com wrote: The previous code was confused about units, which is pretty reasonable given that the units themselves are confusing. Thanks for actually figuring this out; the comment before that function should have indicated to any

[Intel-gfx] [PATCH 1/2] drm/i915/dp: Fix the math in intel_dp_link_required

2011-10-14 Thread Adam Jackson
The previous code was confused about units, which is pretty reasonable given that the units themselves are confusing. Signed-off-by: Adam Jackson a...@redhat.com --- drivers/gpu/drm/i915/intel_dp.c | 26 +- 1 files changed, 21 insertions(+), 5 deletions(-) diff --git