Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

2017-09-18 Thread Wang, Zhi A
Sorry I changed the tittle of the patch with a fixes line. You have already given an r-b. :) -Original Message- From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] Sent: Monday, September 18, 2017 4:08 PM To: Wang, Zhi A ; Vivi, Rodrigo

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

2017-09-18 Thread Joonas Lahtinen
On Thu, 2017-09-14 at 17:51 +, Wang, Zhi A wrote: > Thanks for the comments. V2 has been sent. At least I never received V2, so the fix has still not been merged. Please (re-)send it ASAP. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

2017-09-14 Thread Wang, Zhi A
Oops. So it's like we have to create some entries with same cache attributes before perfect match test case. From: Widawsky, Benjamin Sent: Friday, September 15, 2017 8:02 AM To: Wang, Zhi A ; Chris Wilson ; Vivi, Rodrigo

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

2017-09-14 Thread Widawsky, Benjamin
Juvenile no 00 Original message From: "Wang, Zhi A" Date: 9/14/17 8:03 PM (GMT-08:00) To: Chris Wilson , "Vivi, Rodrigo" Cc: intel-gfx@lists.freedesktop.org, intel-gvt-...@lists.freedesktop.org,

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

2017-09-14 Thread Wang, Zhi A
Sorry for the trouble. It's because we have 4 different entries with different attributes and every time we match an entry by cache attribute, we got a perfect match... -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Thursday, September 14, 2017 9:41 PM

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

2017-09-14 Thread Chris Wilson
Quoting Rodrigo Vivi (2017-09-14 18:36:49) > > well, I wouldn't call this as a typo. > This is a logic fix and deserves a better subject a proper > commit message an also fixes tag: It should work either way, just the bug doesn't allow reuse. The question to ask is why didn't the selftest pick

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

2017-09-14 Thread Wang, Zhi A
Thanks for the comments. V2 has been sent. -Original Message- From: Vivi, Rodrigo Sent: Thursday, September 14, 2017 8:37 PM To: Wang, Zhi A Cc: intel-gfx@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org; joonas.lahti...@linux.intel.com;

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

2017-09-14 Thread Rodrigo Vivi
well, I wouldn't call this as a typo. This is a logic fix and deserves a better subject a proper commit message an also fixes tag: Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management") On Thu, Sep 14, 2017 at 05:24:09PM +, Zhi Wang wrote: > Cc: Chris Wilson

[Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

2017-09-14 Thread Zhi Wang
Cc: Chris Wilson Cc: Ben Widawsky Cc: Rodrigo Vivi Cc: Joonas Lahtinen Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- 1 file changed,

[Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

2017-09-14 Thread Zhi Wang
Cc: Chris Wilson Cc: Ben Widawsky Cc: Rodrigo Vivi Cc: Joonas Lahtinen Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- 1 file changed,