Re: [Intel-gfx] [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable

2013-08-10 Thread Chris Wilson
On Fri, Aug 09, 2013 at 10:12:12PM -0700, Ben Widawsky wrote: I just noticed in our code we don't really check the assertion, and given some of the code I am changing in this area, I feel a WARN is very nice to have. Signed-off-by: Ben Widawsky b...@bwidawsk.net This is BUG() class. A WARN

Re: [Intel-gfx] [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable

2013-08-10 Thread Daniel Vetter
On Sat, Aug 10, 2013 at 09:43:48AM +0100, Chris Wilson wrote: On Fri, Aug 09, 2013 at 10:12:12PM -0700, Ben Widawsky wrote: I just noticed in our code we don't really check the assertion, and given some of the code I am changing in this area, I feel a WARN is very nice to have.

Re: [Intel-gfx] [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable

2013-08-10 Thread Daniel Vetter
On Fri, Aug 09, 2013 at 10:12:12PM -0700, Ben Widawsky wrote: I just noticed in our code we don't really check the assertion, and given some of the code I am changing in this area, I feel a WARN is very nice to have. Signed-off-by: Ben Widawsky b...@bwidawsk.net ---

Re: [Intel-gfx] [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable

2013-08-10 Thread Ben Widawsky
On Sat, Aug 10, 2013 at 10:58:30AM +0200, Daniel Vetter wrote: On Fri, Aug 09, 2013 at 10:12:12PM -0700, Ben Widawsky wrote: I just noticed in our code we don't really check the assertion, and given some of the code I am changing in this area, I feel a WARN is very nice to have.

Re: [Intel-gfx] [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable

2013-08-10 Thread Daniel Vetter
On Sat, Aug 10, 2013 at 10:17:39AM -0700, Ben Widawsky wrote: On Sat, Aug 10, 2013 at 10:58:30AM +0200, Daniel Vetter wrote: On Fri, Aug 09, 2013 at 10:12:12PM -0700, Ben Widawsky wrote: I just noticed in our code we don't really check the assertion, and given some of the code I am

[Intel-gfx] [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable

2013-08-09 Thread Ben Widawsky
I just noticed in our code we don't really check the assertion, and given some of the code I am changing in this area, I feel a WARN is very nice to have. Signed-off-by: Ben Widawsky b...@bwidawsk.net --- drivers/gpu/drm/i915/i915_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git