On Sat, Aug 10, 2013 at 09:43:48AM +0100, Chris Wilson wrote: > On Fri, Aug 09, 2013 at 10:12:12PM -0700, Ben Widawsky wrote: > > I just noticed in our code we don't really check the assertion, and > > given some of the code I am changing in this area, I feel a WARN is very > > nice to have. > > > > Signed-off-by: Ben Widawsky <[email protected]> > > This is BUG() class. A WARN by itself here isn't going to prevent > calamity, so cleanup and let userspace die gracefully. The alternative > is random hw borkage (hopefully triggering an OOPS before it gets too > far).
I think WARN is ok, there should be enough time for it to hit the logs before the evenutal machine death. Generally if a WARN requires us to add more cleanup code it's imo not worth it. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
