Re: [Intel-gfx] [PATCH 4/4] drm/i915: Park before resetting the submission backend

2018-04-06 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-04-06 14:39:28) > On Fri, 06 Apr 2018 14:25:48 +0200, Chris Wilson > wrote: > > > Quoting Sagar Arun Kamble (2018-04-05 12:54:38) > >> > >> > >> On 4/5/2018 4:32 PM, Chris Wilson wrote: > >> > As different backends may have different

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Park before resetting the submission backend

2018-04-06 Thread Michal Wajdeczko
On Fri, 06 Apr 2018 14:25:48 +0200, Chris Wilson wrote: Quoting Sagar Arun Kamble (2018-04-05 12:54:38) On 4/5/2018 4:32 PM, Chris Wilson wrote: > As different backends may have different park/unpark callbacks, we > should only ever switch backends

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Park before resetting the submission backend

2018-04-06 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-04-05 12:54:38) > > > On 4/5/2018 4:32 PM, Chris Wilson wrote: > > As different backends may have different park/unpark callbacks, we > > should only ever switch backends (reset_default_submission on wedge > > recovery, or on enabling the guc) while parked. > > >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Park before resetting the submission backend

2018-04-05 Thread Chris Wilson
Quoting Chris Wilson (2018-04-05 13:17:24) > Quoting Sagar Arun Kamble (2018-04-05 12:54:38) > > With GuC, hitting the GEM_BUG_ON(awake) in guc_submission_enable. > > Hmm. We definitely need to keep park/unpark balanced. Brute force would > be to force idle at that point. Or we do if (awake)

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Park before resetting the submission backend

2018-04-05 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-04-05 12:54:38) > > > On 4/5/2018 4:32 PM, Chris Wilson wrote: > > As different backends may have different park/unpark callbacks, we > > should only ever switch backends (reset_default_submission on wedge > > recovery, or on enabling the guc) while parked. > > >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Park before resetting the submission backend

2018-04-05 Thread Sagar Arun Kamble
On 4/5/2018 4:32 PM, Chris Wilson wrote: As different backends may have different park/unpark callbacks, we should only ever switch backends (reset_default_submission on wedge recovery, or on enabling the guc) while parked. Signed-off-by: Chris Wilson Cc: Michal

[Intel-gfx] [PATCH 4/4] drm/i915: Park before resetting the submission backend

2018-04-05 Thread Chris Wilson
As different backends may have different park/unpark callbacks, we should only ever switch backends (reset_default_submission on wedge recovery, or on enabling the guc) while parked. Signed-off-by: Chris Wilson Cc: Michal Wajdeczko Cc: Sagar