Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-24 Thread Jani Nikula
On Tue, 23 Jan 2018, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-01-23 16:06:16) >> On Tue, Jan 23, 2018 at 08:48:01AM +, Chris Wilson wrote: >> > Quoting Michel Thierry (2018-01-23 00:41:07) >> > > On 1/22/2018 4:31 PM, Lucas De Marchi wrote: >> > > > So for

Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-23 Thread Chris Wilson
Quoting Lucas De Marchi (2018-01-23 16:06:16) > On Tue, Jan 23, 2018 at 08:48:01AM +, Chris Wilson wrote: > > Quoting Michel Thierry (2018-01-23 00:41:07) > > > On 1/22/2018 4:31 PM, Lucas De Marchi wrote: > > > > So for this file what I understand is that it should be: > > > > > > > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-23 Thread Lucas De Marchi
On Tue, Jan 23, 2018 at 05:18:36PM +0100, Michal Wajdeczko wrote: > On Tue, 23 Jan 2018 17:06:16 +0100, Lucas De Marchi > wrote: > > > On Tue, Jan 23, 2018 at 08:48:01AM +, Chris Wilson wrote: > > > Quoting Michel Thierry (2018-01-23 00:41:07) > > > > On 1/22/2018

Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-23 Thread Michal Wajdeczko
On Tue, 23 Jan 2018 17:06:16 +0100, Lucas De Marchi wrote: On Tue, Jan 23, 2018 at 08:48:01AM +, Chris Wilson wrote: Quoting Michel Thierry (2018-01-23 00:41:07) > On 1/22/2018 4:31 PM, Lucas De Marchi wrote: > > So for this file what I understand is that it

Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-23 Thread Lucas De Marchi
On Tue, Jan 23, 2018 at 08:48:01AM +, Chris Wilson wrote: > Quoting Michel Thierry (2018-01-23 00:41:07) > > On 1/22/2018 4:31 PM, Lucas De Marchi wrote: > > > So for this file what I understand is that it should be: > > > > > > // SPDX-License-Identifier: MIT > > > // Copyright

Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-23 Thread Chris Wilson
Quoting Michel Thierry (2018-01-23 00:41:07) > On 1/22/2018 4:31 PM, Lucas De Marchi wrote: > > So for this file what I understand is that it should be: > > > > // SPDX-License-Identifier: MIT > > // Copyright (C) 2014-2018 Intel Corporation > > So be it. Oh no, we don't do C++

Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-22 Thread Michel Thierry
On 1/22/2018 4:31 PM, Lucas De Marchi wrote: So for this file what I understand is that it should be: // SPDX-License-Identifier: MIT // Copyright (C) 2014-2018 Intel Corporation So be it. ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-22 Thread Lucas De Marchi
On Mon, Jan 22, 2018 at 01:49:19PM -0800, Michel Thierry wrote: > > > > diff --git a/drivers/gpu/drm/i915/intel_lrc_reg.h > > > > b/drivers/gpu/drm/i915/intel_lrc_reg.h > > > > new file mode 100644 > > > > index ..f50d63cb4b66 > > > > --- /dev/null > > > > +++

Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-22 Thread Michel Thierry
On 22/01/18 13:28, Michal Wajdeczko wrote: On Mon, 22 Jan 2018 21:56:36 +0100, Lucas De Marchi wrote: On Mon, Jan 22, 2018 at 12:32:57PM -0800, Michel Thierry wrote: Newer platforms may have subtle offset changes, which will increase the number of defines, so it is

Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-22 Thread Michal Wajdeczko
On Mon, 22 Jan 2018 21:56:36 +0100, Lucas De Marchi wrote: On Mon, Jan 22, 2018 at 12:32:57PM -0800, Michel Thierry wrote: Newer platforms may have subtle offset changes, which will increase the number of defines, so it is probably better to start moving them to

Re: [Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-22 Thread Lucas De Marchi
On Mon, Jan 22, 2018 at 12:32:57PM -0800, Michel Thierry wrote: > Newer platforms may have subtle offset changes, which will increase the > number of defines, so it is probably better to start moving them to its > own header file. Also move the macros used while setting the reg state. > > v2:

[Intel-gfx] [PATCH v2] drm/i915: Move LRC register offsets to a header file

2018-01-22 Thread Michel Thierry
Newer platforms may have subtle offset changes, which will increase the number of defines, so it is probably better to start moving them to its own header file. Also move the macros used while setting the reg state. v2: Rename to intel_lrc_reg.h, to be consistent with i915_reg.h and