Do not override TA_SURE timing parameter to
zero for DSI 8X frequency 800MHz or below on
TGL.

Signed-off-by: Vandita Kulkarni <vandita.kulka...@intel.com>
Reviewed-by: Uma Shankar <uma.shan...@intel.com>
---
 drivers/gpu/drm/i915/display/icl_dsi.c | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c 
b/drivers/gpu/drm/i915/display/icl_dsi.c
index 3185cb0bae41..c6cda529c5bb 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -530,18 +530,20 @@ static void gen11_dsi_setup_dphy_timings(struct 
intel_encoder *encoder)
         * a value '0' inside TA_PARAM_REGISTERS otherwise
         * leave all fields at HW default values.
         */
-       if (intel_dsi_bitrate(intel_dsi) <= 800000) {
-               for_each_dsi_port(port, intel_dsi->ports) {
-                       tmp = I915_READ(DPHY_TA_TIMING_PARAM(port));
-                       tmp &= ~TA_SURE_MASK;
-                       tmp |= TA_SURE_OVERRIDE | TA_SURE(0);
-                       I915_WRITE(DPHY_TA_TIMING_PARAM(port), tmp);
-
-                       /* shadow register inside display core */
-                       tmp = I915_READ(DSI_TA_TIMING_PARAM(port));
-                       tmp &= ~TA_SURE_MASK;
-                       tmp |= TA_SURE_OVERRIDE | TA_SURE(0);
-                       I915_WRITE(DSI_TA_TIMING_PARAM(port), tmp);
+       if (IS_GEN(dev_priv, 11)) {
+               if (intel_dsi_bitrate(intel_dsi) <= 800000) {
+                       for_each_dsi_port(port, intel_dsi->ports) {
+                               tmp = I915_READ(DPHY_TA_TIMING_PARAM(port));
+                               tmp &= ~TA_SURE_MASK;
+                               tmp |= TA_SURE_OVERRIDE | TA_SURE(0);
+                               I915_WRITE(DPHY_TA_TIMING_PARAM(port), tmp);
+
+                               /* shadow register inside display core */
+                               tmp = I915_READ(DSI_TA_TIMING_PARAM(port));
+                               tmp &= ~TA_SURE_MASK;
+                               tmp |= TA_SURE_OVERRIDE | TA_SURE(0);
+                               I915_WRITE(DSI_TA_TIMING_PARAM(port), tmp);
+                       }
                }
        }
 
-- 
2.21.0.5.gaeb582a

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to