== Series Details ==

Series: drm/i915: Explicit Raw and Adjusted WM latencies.
URL   : https://patchwork.freedesktop.org/series/38652/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8568ad0cbdd4 drm/i915: Explicit Raw and Adjusted WM latencies.
-:56: CHECK: braces {} should be used on all arms of this statement
#56: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3711:
+       if (INTEL_GEN(dev_priv) >= 9) {
[...]
+       } else
[...]

-:58: WARNING: line over 80 characters
#58: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3713:
+               wm_latency_show(m, dev_priv->wm.skl_latency.adjusted, 
"Adjusted");

-:59: CHECK: Unbalanced braces around else statement
#59: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3714:
+       } else

-:76: CHECK: braces {} should be used on all arms of this statement
#76: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3724:
+       if (INTEL_GEN(dev_priv) >= 9) {
[...]
+       } else
[...]

-:78: WARNING: line over 80 characters
#78: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3726:
+               wm_latency_show(m, dev_priv->wm.skl_latency.adjusted, 
"Adjusted");

-:79: CHECK: Unbalanced braces around else statement
#79: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3727:
+       } else

-:96: CHECK: braces {} should be used on all arms of this statement
#96: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3737:
+       if (INTEL_GEN(dev_priv) >= 9) {
[...]
+       } else
[...]

-:98: WARNING: line over 80 characters
#98: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3739:
+               wm_latency_show(m, dev_priv->wm.skl_latency.adjusted, 
"Adjusted");

-:99: CHECK: Unbalanced braces around else statement
#99: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3740:
+       } else

-:146: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#146: FILE: drivers/gpu/drm/i915/i915_drv.h:2150:
+                       uint16_t raw[8];

-:147: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#147: FILE: drivers/gpu/drm/i915/i915_drv.h:2151:
+                       uint16_t adjusted[8];

-:196: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#196: FILE: drivers/gpu/drm/i915/intel_pm.c:4503:
+       uint16_t latency = dev_priv->wm.skl_latency.raw[level];

-:223: WARNING: line over 80 characters
#223: FILE: drivers/gpu/drm/i915/intel_pm.c:4547:
+               else if (dev_priv->wm.skl_latency.adjusted[level] >= 
wp->linetime_us)

total: 0 errors, 4 warnings, 9 checks, 196 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to