== Series Details ==

Series: series starting with [1/4] drm/i915/icl: Add the ICL PCI IDs
URL   : https://patchwork.freedesktop.org/series/38604/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
976122bb3624 drm/i915/icl: Add the ICL PCI IDs
-:47: ERROR: Macros with complex values should be enclosed in parentheses
#47: FILE: include/drm/i915_pciids.h:435:
+#define INTEL_ICL_11_IDS(info) \
+       INTEL_VGA_DEVICE(0x8A50, info), \
+       INTEL_VGA_DEVICE(0x8A51, info), \
+       INTEL_VGA_DEVICE(0x8A5C, info), \
+       INTEL_VGA_DEVICE(0x8A5D, info), \
+       INTEL_VGA_DEVICE(0x8A52, info), \
+       INTEL_VGA_DEVICE(0x8A5A, info), \
+       INTEL_VGA_DEVICE(0x8A5B, info), \
+       INTEL_VGA_DEVICE(0x8A71, info), \
+       INTEL_VGA_DEVICE(0x8A70, info)

-:47: CHECK: Macro argument reuse 'info' - possible side-effects?
#47: FILE: include/drm/i915_pciids.h:435:
+#define INTEL_ICL_11_IDS(info) \
+       INTEL_VGA_DEVICE(0x8A50, info), \
+       INTEL_VGA_DEVICE(0x8A51, info), \
+       INTEL_VGA_DEVICE(0x8A5C, info), \
+       INTEL_VGA_DEVICE(0x8A5D, info), \
+       INTEL_VGA_DEVICE(0x8A52, info), \
+       INTEL_VGA_DEVICE(0x8A5A, info), \
+       INTEL_VGA_DEVICE(0x8A5B, info), \
+       INTEL_VGA_DEVICE(0x8A71, info), \
+       INTEL_VGA_DEVICE(0x8A70, info)

total: 1 errors, 0 warnings, 1 checks, 23 lines checked
03836e973026 drm/i915/icl: Show interrupt registers in debugfs
ecc8c181594e drm/i915/icl: Prepare for more rings
64d966e1377d drm/i915/icl: Interrupt handling
-:101: CHECK: Blank lines aren't necessary after an open brace '{'
#101: FILE: drivers/gpu/drm/i915/i915_irq.c:2781:
+               switch (engine_n) {
+

-:110: CHECK: Blank lines aren't necessary after an open brace '{'
#110: FILE: drivers/gpu/drm/i915/i915_irq.c:2790:
+               switch (engine_n) {
+

total: 0 errors, 0 warnings, 2 checks, 284 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to