Re: [Intel-gfx] [PATCH v2] drm/i915: Unwind conversion to i915_gem_phys_ops on failure

2017-02-16 Thread Mika Kuoppala
Chris Wilson writes: > The physical object is treated as permanently pinned. If we fail to take > this initial pin during i915_gem_object_attach_phys() we need to revert > it back to an ordinary shmemfs object before reporting the failure. > > v2: git-add > > Reported-by: Mika Kuoppala > Signed-

Re: [Intel-gfx] [PATCH] ALSA: x86: Fix spinlock usage in the trigger callback

2017-02-16 Thread Ville Syrjälä
On Wed, Feb 15, 2017 at 10:21:08PM +0100, Takashi Iwai wrote: > On Wed, 15 Feb 2017 20:15:50 +0100, > ville.syrj...@linux.intel.com wrote: > > > > From: Ville Syrjälä > > > > Simply doing 'xset dpms force off' while playback is active seems > > sufficient to anger lockdep [1]. And it's of course

[Intel-gfx] [PATCH v4 2/5] drm/atomic: Make drm_atomic_plane_disabling easier to understand.

2017-02-16 Thread Maarten Lankhorst
This function becomes a lot simpler when having passed both the old and new state to it. Looking at all callers, it seems that old_plane_state is never NULL so the check can be dropped. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic_helper.c | 7 --- drivers/gpu/drm/drm_pla

[Intel-gfx] [PATCH v4 5/5] drm/blend: Use new atomic iterator macros.

2017-02-16 Thread Maarten Lankhorst
There are new iterator macros that annotate whether the new or old state should be used. This is better than using a state that depends on whether it's called before or after swap. For clarity, also rename the variables from $obj_state to (old,new)_$obj_state as well. Signed-off-by: Maarten Lankho

Re: [Intel-gfx] [GLK MIPI DSI V5 1/8] drm/i915/glk: Program dphy param reg for GLK

2017-02-16 Thread Jani Nikula
On Tue, 14 Feb 2017, Madhav Chauhan wrote: > From: Deepak M > > For GEMINILAKE, dphy param reg values are programmed in terms > of HS byte clock count while for older platforms in terms of > HS ddr clk count. > > v2: Added comments to clarify ddr clock count calculation > v3: Use multiplier varia

[Intel-gfx] [PATCH v4 3/5] drm/atomic: Add macros to access existing old/new state, v2.

2017-02-16 Thread Maarten Lankhorst
After atomic commit, these macros should be used in place of get_existing_state. Also after commit get_xx_state should no longer be used because it may not have the required locks. The calls to drm_atomic_get_existing_$obj_state should no longer be used, and converted over to these new calls. Cha

[Intel-gfx] [PATCH v4 1/5] drm/atomic: Fix atomic helpers to use the new iterator macros, v2.

2017-02-16 Thread Maarten Lankhorst
There are new iterator macros that annotate whether the new or old state should be used. This is better than using a state that depends on whether it's called before or after swap. For clarity, also rename the variables from $obj_state to (old,new)_$obj_state as well. Changes since v1: - Use old/n

[Intel-gfx] [PATCH v4 0/5] drm/atomic: Add accessor macros for all atomic state.

2017-02-16 Thread Maarten Lankhorst
Fifth iteration. Instead of trying to convert all drivers straight away, implement all macros that are required to get state working. Old situation: Use obj->state, which can refer to old or new state. Use drm_atomic_get_(existing_)obj_state, which can refer to new or old state. Use for_each_obj_i

[Intel-gfx] [PATCH v4 4/5] drm/atomic: Convert get_existing_state callers to get_old/new_state, v3.

2017-02-16 Thread Maarten Lankhorst
This is a straightforward conversion that converts all the users of get_existing_state in atomic core to use get_old_state or get_new_state Changes since v1: - Fix using the wrong state in drm_atomic_helper_update_legacy_modeset_state. Changes since v2: - Use the correct state in disable_outputs()

Re: [Intel-gfx] [GLK MIPI DSI V5 2/8] drm/i915/glk: Program new MIPI DSI PHY registers for GLK

2017-02-16 Thread Jani Nikula
On Tue, 14 Feb 2017, Madhav Chauhan wrote: > From: Deepak M > > Program the clk lane and tlpx time count registers > to configure DSI PHY. > > v2: Addressed Jani's Review comments(renamed bit field macros) > v3: Program clk lane timing reg same as dphy param reg. > v4: Removed "line over 80 chara

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Call the sync_hw hook for power wells without a domain

2017-02-16 Thread Imre Deak
On Thu, Feb 16, 2017 at 11:31:01AM +0200, Ander Conselvan De Oliveira wrote: > On Wed, 2017-02-15 at 13:59 +0200, Imre Deak wrote: > > So far the sync_hw hook wasn't called for power wells not belonging to > > any power domain, that is the GEN9 PW1 and MISC_IO power wells. This > > wasn't a problem

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: handle override/firmware edid at the lowest level

2017-02-16 Thread Patchwork
== Series Details == Series: drm: handle override/firmware edid at the lowest level URL : https://patchwork.freedesktop.org/series/19764/ State : failure == Summary == Series 19764v1 drm: handle override/firmware edid at the lowest level https://patchwork.freedesktop.org/api/1.0/series/19764/r

Re: [Intel-gfx] [GLK MIPI DSI V5 3/8] drm/i915/glk: Add MIPIIO Enable/disable sequence

2017-02-16 Thread Jani Nikula
On Tue, 14 Feb 2017, Madhav Chauhan wrote: > From: Deepak M > > v2: Addressed Jani's Review comments(renamed bit field macros) > v3: Jani's Review comment for aligning code to platforms and added > wrapper functions. > v4: Corrected enable/disable seuqence as per BSPEC > > Signed-off-by: Deepak M

Re: [Intel-gfx] [GLK MIPI DSI V5 5/8] drm/i915/glk: Add DSI PLL divider range for glk

2017-02-16 Thread Jani Nikula
On Tue, 14 Feb 2017, Madhav Chauhan wrote: > From: Deepak M > > PLL divider range for GLK is different than that of > BXT, hence adding the GLK range check in this patch. > > v2: Code restructure using min and max ratio variables (Ander) > > Signed-off-by: Deepak M > Signed-off-by: Madhav Chauha

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gen9: Fix clearing of the BIOS power well request register

2017-02-16 Thread Imre Deak
On Thu, Feb 16, 2017 at 11:43:06AM +0200, Ander Conselvan De Oliveira wrote: > On Wed, 2017-02-15 at 13:59 +0200, Imre Deak wrote: > > Atm, in the power well sync_hw hook we are clearing all BIOS request > > bits, not just the one corresponding to the given power well. This could > > turn off an un

Re: [Intel-gfx] [GLK MIPI DSI V5 6/8] drm/i915i/glk: Program MIPI_CLOCK_CTRL only for BXT

2017-02-16 Thread Jani Nikula
On Tue, 14 Feb 2017, Madhav Chauhan wrote: > From: Deepak M > > Register MIPI_CLOCK_CTRL is applicable only > for BXT platform. Future platform have other > registers to program the escape clock dividers. > > Signed-off-by: Deepak M > Signed-off-by: Madhav Chauhan Reviewed-by: Jani Nikula >

Re: [Intel-gfx] [GLK MIPI DSI V5 4/8] drm/i915: Set the Z inversion overlap field

2017-02-16 Thread Jani Nikula
On Tue, 14 Feb 2017, Madhav Chauhan wrote: > From: Deepak M > > Dual link Z-inversion overlap field is present > in MIPI_CTRL register unlike the older platforms, > hence setting the same in this patch. > > Signed-off-by: Deepak M > Signed-off-by: Madhav Chauhan Pushed this one patch to dinq.

Re: [Intel-gfx] [PATCH 5/9] drm/i915/bxt: Fix BXT DSI ULPS sequence

2017-02-16 Thread Jani Nikula
On Wed, 15 Feb 2017, Bob Paauwe wrote: > On Wed, 8 Feb 2017 16:20:54 +0530 > Vidya Srinivas wrote: > >> From: Uma Shankar >> >> Fix the Sequence to program BXT DSI Latch and ULPS. >> >> Signed-off-by: Uma Shankar >> Signed-off-by: Vidya Srinivas > > Reviewed-by: Bob Paauwe Pushed this one

Re: [Intel-gfx] [PATCH 7/9] drm/i915/bxt: Disable device ready before shutdown command

2017-02-16 Thread Jani Nikula
On Wed, 15 Feb 2017, Bob Paauwe wrote: > On Wed, 8 Feb 2017 16:20:56 +0530 > Vidya Srinivas wrote: > >> From: Uma Shankar >> >> Disable device ready before MIPI port shutdown command. >> This helps to avoid mipi split screen issues. >> >> Signed-off-by: Uma Shankar >> Signed-off-by: Vidya Sri

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for GLK MIPI DSI VIDEO MODE PATCHES (rev5)

2017-02-16 Thread Jani Nikula
On Tue, 14 Feb 2017, Patchwork wrote: > drivers/gpu/drm/i915/intel_dsi_pll.c: In function ‘intel_compute_dsi_pll’: > drivers/gpu/drm/i915/intel_dsi_pll.c:513:45: error: ‘dsi_ratio_max’ may be > used uninitialized in this function [-Werror=maybe-uninitialized] > if (dsi_ratio < dsi_ratio_min ||

Re: [Intel-gfx] [PATCH 8/9] drm/i915/bxt: Enable BXT DSI dual link

2017-02-16 Thread Jani Nikula
On Wed, 15 Feb 2017, Bob Paauwe wrote: > On Wed, 8 Feb 2017 16:20:57 +0530 > Vidya Srinivas wrote: > >> From: Uma Shankar >> >> Enable support for BXT DSI dual link mode. >> >> Signed-off-by: Uma Shankar >> Signed-off-by: Vidya Srinivas > > Reviewed-by: Bob Paauwe This doesn't apply becaus

Re: [Intel-gfx] [PATCH] drm/i915: Fix DisplayPort Hotplug

2017-02-16 Thread Palmer Dabbelt
On Tue, Feb 14, 2017 at 11:00 AM, Ville Syrjälä wrote: > On Tue, Feb 14, 2017 at 10:48:10AM -0800, Palmer Dabbelt wrote: >> On Tue, 14 Feb 2017 07:01:54 PST (-0800), ville.syrj...@linux.intel.com >> wrote: >> > On Fri, Feb 10, 2017 at 02:44:20PM -0800, Palmer Dabbelt wrote: >> >> DisplayPort no l

Re: [Intel-gfx] [PATCH] drm/i915: Fix DisplayPort Hotplug

2017-02-16 Thread Ville Syrjälä
On Wed, Feb 15, 2017 at 06:58:13PM -0800, Palmer Dabbelt wrote: > On Tue, Feb 14, 2017 at 11:00 AM, Ville Syrjälä > wrote: > > On Tue, Feb 14, 2017 at 10:48:10AM -0800, Palmer Dabbelt wrote: > >> On Tue, 14 Feb 2017 07:01:54 PST (-0800), ville.syrj...@linux.intel.com > >> wrote: > >> > On Fri, Fe

[Intel-gfx] [PATCH] drm/i915: Perform link quality check unconditionally during long pulse

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Apparently some DP sinks are a little nuts and cause HPD to drop intermittently during modesets. This happens eg. on an ASUS PB287Q. In oder to recover from this we can't really use the previous connector status to determine if the link needs retraining, so let's just ignore t

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unwind conversion to i915_gem_phys_ops on failure (rev2)

2017-02-16 Thread Patchwork
== Series Details == Series: drm/i915: Unwind conversion to i915_gem_phys_ops on failure (rev2) URL : https://patchwork.freedesktop.org/series/19708/ State : failure == Summary == Series 19708v2 drm/i915: Unwind conversion to i915_gem_phys_ops on failure https://patchwork.freedesktop.org/api/1

[Intel-gfx] [PATCH] drm/i915: Defer declaration of missed-interrupt until the waiter is asleep

2017-02-16 Thread Chris Wilson
If the waiter was currently running, assume it hasn't had a chance to process the pending interupt (e.g, low priority task on a loaded system) and wait until it sleeps before declaring a missed interrupt. References: https://bugs.freedesktop.org/show_bug.cgi?id=99816 Signed-off-by: Chris Wilson C

Re: [Intel-gfx] [PATCH] drm/i915/glk: CDCLK calculation changes for glk

2017-02-16 Thread Jani Nikula
On Thu, 16 Feb 2017, Madhav Chauhan wrote: > As per BSPEC, valid cdclk values for glk are 79.2, 158.4, 316.8 Mhz. > Practically we can achive only 99% of these cdclk values(HW team > checking on this). So cdclk should be calculated for the given pixclk as > per that otherwise it may lead to screen

Re: [Intel-gfx] [PATCH 2/3] drm: reset ELD if NULL edid is passed to drm_edid_to_eld

2017-02-16 Thread Ville Syrjälä
On Thu, Feb 16, 2017 at 12:36:43PM +0200, Jani Nikula wrote: > Make the function useful for resetting, not just setting, the ELD. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915: Perform link quality check unconditionally during long pulse

2017-02-16 Thread Palmer Dabbelt
On Thu, 16 Feb 2017 07:30:07 PST (-0800), ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Apparently some DP sinks are a little nuts and cause HPD to drop > intermittently during modesets. This happens eg. on an ASUS PB287Q. > In oder to recover from this we can't really use the p

Re: [Intel-gfx] [PATCH 3/3] drm: handle override edid and firmware EDID at drm_do_get_edid() level

2017-02-16 Thread Ville Syrjälä
On Thu, Feb 16, 2017 at 12:36:45PM +0200, Jani Nikula wrote: > Handle debugfs override edid and firmware edid at the low level to > transparently and completely replace the real edid. Previously, we > practically only used the modes from the override EDID, and none of the > other data. This also pr

Re: [Intel-gfx] [PATCH] drm/i915: Perform link quality check unconditionally during long pulse

2017-02-16 Thread Ville Syrjälä
On Thu, Feb 16, 2017 at 07:39:29AM -0800, Palmer Dabbelt wrote: > On Thu, 16 Feb 2017 07:30:07 PST (-0800), ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Apparently some DP sinks are a little nuts and cause HPD to drop > > intermittently during modesets. This happens eg. on

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for GLK MIPI DSI VIDEO MODE PATCHES (rev5)

2017-02-16 Thread Chauhan, Madhav
> -Original Message- > From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > Sent: Thursday, February 16, 2017 8:49 PM > To: Patchwork ; Chauhan, Madhav > > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for GLK MIPI DSI VIDEO MODE > PATCHES (rev5) >

Re: [Intel-gfx] [PATCH v2] drm/i915: Sanitize GuC client initialization

2017-02-16 Thread Daniele Ceraolo Spurio
On 15/02/17 23:44, Chris Wilson wrote: On Wed, Feb 15, 2017 at 06:28:59PM -0800, Daniele Ceraolo Spurio wrote: On 14/02/17 05:53, Joonas Lahtinen wrote: -static void guc_disable_doorbell(struct intel_guc *guc, -struct i915_guc_client *client) +static int __dest

[Intel-gfx] [PATCH 1/2] drm/i915: Take forcewake for setting the RPS thresholds

2017-02-16 Thread Chris Wilson
Take forcewake for the entire duration of reprogramming the RPS thresholds. By itself it should not achieve much as instead of going into the FIFO, we force the device to wake for the reprograming, but it should help in regards to the next patch that introduces a read. Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 2/2] drm/i915: Restart RPS using the same RP_CONTROL as from initialisation

2017-02-16 Thread Chris Wilson
During initialisation, we set different flags for different architectures - these should be preserved when we reload the RPS thresholds. If we use a mmio read, it will first ensure that the threshold registers are written before we apply the latch in RP_CONTROL. Signed-off-by: Chris Wilson Cc: Mi

[Intel-gfx] [PATCH v2] drm/i915: Take forcewake for setting the RPS thresholds

2017-02-16 Thread Chris Wilson
Take forcewake for the entire duration of reprogramming the RPS thresholds. By itself it should not achieve much as instead of going into the FIFO, we force the device to wake for the reprograming, but it should help in regards to the next patch that introduces a read. Signed-off-by: Chris Wilson

[Intel-gfx] ✓ Fi.CI.BAT: success for Moving the common engine/ring code to intel_engine_cs.c (rev2)

2017-02-16 Thread Patchwork
== Series Details == Series: Moving the common engine/ring code to intel_engine_cs.c (rev2) URL : https://patchwork.freedesktop.org/series/19706/ State : success == Summary == Series 19706v2 Moving the common engine/ring code to intel_engine_cs.c https://patchwork.freedesktop.org/api/1.0/serie

Re: [Intel-gfx] i915: Dealing with 90° rotated display ?

2017-02-16 Thread Ville Syrjälä
On Thu, Feb 16, 2017 at 11:01:29AM +0100, Hans de Goede wrote: > Hi, > > On 15-02-17 15:59, Ville Syrjälä wrote: > > On Wed, Feb 15, 2017 at 03:54:17PM +0100, Hans de Goede wrote: > >> Hi Jani, > >> > >> As discussed here: > >> > >> https://bugs.freedesktop.org/show_bug.cgi?id=94894 > >> > >> I've

Re: [Intel-gfx] [PATCH] drm/i915: Perform link quality check unconditionally during long pulse

2017-02-16 Thread Manasi Navare
On Thu, Feb 16, 2017 at 05:30:07PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Apparently some DP sinks are a little nuts and cause HPD to drop > intermittently during modesets. This happens eg. on an ASUS PB287Q. > In oder to recover from this we can't really use the pr

Re: [Intel-gfx] [PATCH] drm/i915: Perform link quality check unconditionally during long pulse

2017-02-16 Thread Ville Syrjälä
On Thu, Feb 16, 2017 at 09:07:53AM -0800, Manasi Navare wrote: > On Thu, Feb 16, 2017 at 05:30:07PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Apparently some DP sinks are a little nuts and cause HPD to drop > > intermittently during modesets. This happens eg. on

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Squelch any ktime/jiffie rounding errors for wait-ioctl

2017-02-16 Thread Patchwork
== Series Details == Series: drm/i915: Squelch any ktime/jiffie rounding errors for wait-ioctl URL : https://patchwork.freedesktop.org/series/19780/ State : success == Summary == Series 19780v1 drm/i915: Squelch any ktime/jiffie rounding errors for wait-ioctl https://patchwork.freedesktop.org/

Re: [Intel-gfx] [PATCH] drm/i915: Perform link quality check unconditionally during long pulse

2017-02-16 Thread Manasi Navare
On Thu, Feb 16, 2017 at 07:18:57PM +0200, Ville Syrjälä wrote: > On Thu, Feb 16, 2017 at 09:07:53AM -0800, Manasi Navare wrote: > > On Thu, Feb 16, 2017 at 05:30:07PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Apparently some DP sinks are a little nuts

Re: [Intel-gfx] [PATCH] drm/i915: Perform link quality check unconditionally during long pulse

2017-02-16 Thread Ville Syrjälä
On Thu, Feb 16, 2017 at 09:24:09AM -0800, Manasi Navare wrote: > On Thu, Feb 16, 2017 at 07:18:57PM +0200, Ville Syrjälä wrote: > > On Thu, Feb 16, 2017 at 09:07:53AM -0800, Manasi Navare wrote: > > > On Thu, Feb 16, 2017 at 05:30:07PM +0200, ville.syrj...@linux.intel.com > > > wrote: > > > > From

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Track plane fifo sizes under intel_crtc

2017-02-16 Thread Ville Syrjälä
On Thu, Dec 15, 2016 at 03:58:44PM +0100, Maarten Lankhorst wrote: > Op 12-12-16 om 21:35 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > Track the plane fifo sizes under intel_crtc instead of under each > > intel_plane. Avoids looping over the planes in a bunch of places, >

Re: [Intel-gfx] [PATCH 3/3] drm: handle override edid and firmware EDID at drm_do_get_edid() level

2017-02-16 Thread Jani Nikula
On Thu, 16 Feb 2017, Ville Syrjälä wrote: > On Thu, Feb 16, 2017 at 12:36:45PM +0200, Jani Nikula wrote: >> Handle debugfs override edid and firmware edid at the low level to >> transparently and completely replace the real edid. Previously, we >> practically only used the modes from the override

Re: [Intel-gfx] [PATCH 08/14] drm/i915: Skip useless watermark/FIFO related work on VLV/CHV when not needed

2017-02-16 Thread Ville Syrjälä
On Thu, Dec 15, 2016 at 04:37:53PM +0100, Maarten Lankhorst wrote: > Op 12-12-16 om 21:35 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > Check whether anything relevant has actually change when we compute new > > watermarks for each plane in the state. If the watermarks for

Re: [Intel-gfx] [PATCH] ALSA: x86: Fix spinlock usage in the trigger callback

2017-02-16 Thread Takashi Iwai
On Thu, 16 Feb 2017 15:46:16 +0100, Ville Syrjälä wrote: > > On Wed, Feb 15, 2017 at 10:21:08PM +0100, Takashi Iwai wrote: > > On Wed, 15 Feb 2017 20:15:50 +0100, > > ville.syrj...@linux.intel.com wrote: > > > > > > From: Ville Syrjälä > > > > > > Simply doing 'xset dpms force off' while playba

Re: [Intel-gfx] [PATCH] drm/i915: Defer declaration of missed-interrupt until the waiter is asleep

2017-02-16 Thread kbuild test robot
Hi Chris, [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v4.10-rc8 next-20170216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Defer

[Intel-gfx] [PATCH v2 00/18] drm/i915: VLV/CHV two-stage watermarks (v2)

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä A rebased version of the two stage watermark support for VLV/CHV. Mostly just cosmetic changes due to churn. I did clear out that unused intel_plane_wm_parameters structure Maarten pointed out. The sticking point in the last series was the active_planes bitmask, but I've deci

[Intel-gfx] [PATCH 06/18] drm/i915: Compute VLV/CHV FIFO sizes based on the PM2 watermarks

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Let's compute the watermarks first and the FIFO size second. This way we can make sure the FIFO split is the most accommodating to the watermarks. Previously we could have potentially computed a FIFO split that couldn't accommodate the PM2 watermarks simply due to a bad split

[Intel-gfx] [PATCH 03/18] drm/i915: Move vlv wms from crtc->wm_state to crtc->wm.active.vlv

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä In an effort to make the vlv/chv wm code look and behave more like the ilk+ code, let's move the current active wms next to the corresponding ilk wms. Signed-off-by: Ville Syrjälä Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_drv.h | 3 +-- drivers/gpu/drm

[Intel-gfx] [PATCH 09/18] drm/i915: Compute proper intermediate wms for vlv/cvh

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Since the watermark registers arent double buffered on VLV/CHV, we'll need to play around with intermediate watermarks same was as we do on ILK-BDW. The watermark registers on VLV/CHV contain inverted values, so to find the intermediate watermark value we just take the minimu

[Intel-gfx] [PATCH 01/18] drm/i915: Track visible planes in a bitmask

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä In a lot of place we wish to know which planes on the crtc are actually visible, or how many of them there are. Let's start tracking that in a bitmask in the crtc state. We already track enabled planes (ie. ones with an fb and crtc specified by the user) but that's not quite

[Intel-gfx] [PATCH 05/18] drm/i915: Plop vlv/chv fifo sizes into crtc state

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Move the vlv/chv FIFO size tracking into the crtc_state. As with the wms for now this just acts as temporary storage. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_drv.h | 11 +-- drivers/gpu/drm/i915/intel_pm.c | 26 +++--- 2 file

[Intel-gfx] [PATCH 10/18] drm/i915: Nuke crtc->wm.cxsr_allowed

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Remove crtc->wm.cxsr_allowed and just rely on crtc_state->disable_cxsr instead. This was used only by vlv/chv to indicate whether to enable cxsr in the wm computation. That doesn't really work anymore, and as far as the optimal watermarks go we'll just consider the number of p

[Intel-gfx] [PATCH v2 02/18] drm/i915: Track plane fifo sizes under intel_crtc

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Track the plane fifo sizes under intel_crtc instead of under each intel_plane. Avoids looping over the planes in a bunch of places, and later we'll move this tracking into the crtc state properly. v2: Nuke intel_plane_wm_parameters (Maarten) Signed-off-by: Ville Syrjälä Rev

[Intel-gfx] [PATCH 12/18] drm/i915: Sanitize VLV/CHV watermarks properly

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Clear out the watermark for all disabled planes to 0. This is required to avoid falsely thinking that the inherited watermarks are bogus in case the watermark is actually higher than the FIFO size. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 17 +

[Intel-gfx] [PATCH 11/18] drm/i915: Only use update_wm_{pre, post} for pre-ilk platforms

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Now that vlv/chv have more proper wm programming support, let's reduce the the update_wm_{pre,post} flags to only cover the pre-ilk platforms. When we finally convert those as well we can drop these flags entirely. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 08/18] drm/i915: Skip useless watermark/FIFO related work on VLV/CHV when not needed

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Check whether anything relevant has actually change when we compute new watermarks for each plane in the state. If the watermarks for no primary/sprite planes changed we don't have to recompute the FIFO split or reprogram the DSBARB registers. And even the cursor watermarks di

[Intel-gfx] [PATCH 18/18] drm/i915: Add FIFO underrun tracepoints

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Add tracepoints for display FIFO underruns. Makes it more convenient to correlate the underruns with other display tracepoints. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_trace.h | 43 ++ drivers/gpu/drm/i915/intel_fifo_u

[Intel-gfx] [PATCH 13/18] drm/i915: Workaround VLV/CHV sprite1->sprite0 enable underrun

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä On VLV/CHV enabling sprite0 when sprite1 has already been enabled may lead to an underrun. This only happens when sprite0 FIFO size is zero prior to enabling it. Hence an effective workaround is to always allocate at least one cacheline for sprite0 when sprite1 is active. I'v

[Intel-gfx] [PATCH 15/18] drm/i915: Add plane update/disable tracepoints

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Add tracepoints for plane programming. The tracepoints will dump the frame and scanline counters, so this can be used to verify eg. that the plane gets reprogrammed at the right time with respect to watermark programming (if we have appropriate tracepoints for that as well).

[Intel-gfx] [PATCH 17/18] drm/i915: Add cxsr toggle tracepoint

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Add a tracepoint for observing changes in the cxsr state. The tracepoint will dump out the frame and scanline counters for each pipe so that the information can be compared with eg. plane update tracepoints. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_trace.h

[Intel-gfx] [PATCH 14/18] drm/i915: Kill level 0 wm hack for VLV/CHV

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä We now compute the watermarks correctly, so just return an error if we can't support the configuration. Signed-off-by: Ville Syrjälä Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_pm.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 16/18] drm/i915: Add VLV/CHV watermark/FIFO programming tracepoints

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Add tracepoints for observing the WM/FIFO programming on VLV/CHV. When compared with the plane and pipe update tracepoints this can be used to verify that everything is performed in the right sequence. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_trace.h | 71

[Intel-gfx] [PATCH 07/18] drm/i915: Compute vlv/chv wms the atomic way

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Start computing the vlv/chv watermarks the atomic way, from the .compute_pipe_wm() hook. We'll recompute the actual watermarks for only planes that are part of the state, the other planes will keep their watermark from the last time it was computed. And the actual watermark p

[Intel-gfx] [PATCH 04/18] drm/i915: Plop vlv wm state into crtc_state

2017-02-16 Thread ville . syrjala
From: Ville Syrjälä Relocate the vlv/chv wm state to live under intel_crtc_state. Note that for now this just behaves as a temporary storage. But it'll be easier to conver the thing over to properly pre-computing the state when it's already in the right place. Signed-off-by: Ville Syrjälä Revie

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for GLK MIPI DSI VIDEO MODE PATCHES (rev5)

2017-02-16 Thread Jani Nikula
On Thu, 16 Feb 2017, "Chauhan, Madhav" wrote: >> -Original Message- >> From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >> Sent: Thursday, February 16, 2017 8:49 PM >> To: Patchwork ; Chauhan, Madhav >> >> Cc: intel-gfx@lists.freedesktop.org >> Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT:

Re: [Intel-gfx] [PATCH 3/3] drm: handle override edid and firmware EDID at drm_do_get_edid() level

2017-02-16 Thread Ville Syrjälä
On Thu, Feb 16, 2017 at 07:54:00PM +0200, Jani Nikula wrote: > On Thu, 16 Feb 2017, Ville Syrjälä wrote: > > On Thu, Feb 16, 2017 at 12:36:45PM +0200, Jani Nikula wrote: > >> Handle debugfs override edid and firmware edid at the low level to > >> transparently and completely replace the real edid.

[Intel-gfx] ✓ Fi.CI.BAT: success for Assorted engine tidy (rev3)

2017-02-16 Thread Patchwork
== Series Details == Series: Assorted engine tidy (rev3) URL : https://patchwork.freedesktop.org/series/19774/ State : success == Summary == Series 19774v3 Assorted engine tidy https://patchwork.freedesktop.org/api/1.0/series/19774/revisions/3/mbox/ fi-bdw-5557u total:252 pass:241 dwarn

Re: [Intel-gfx] [PATCH v3 12/12] drm/i915: Listen for PMIC bus access notifications

2017-02-16 Thread Ville Syrjälä
On Fri, Feb 10, 2017 at 11:28:02AM +0100, Hans de Goede wrote: > Listen for PMIC bus access notifications and get FORCEWAKE_ALL while > the bus is accessed to avoid needing to do any forcewakes, which need > PMIC bus access, while the PMIC bus is busy: > > This fixes errors like these showing up i

Re: [Intel-gfx] [PATCH v2] drm/i915: Sanitize GuC client initialization

2017-02-16 Thread Oscar Mateo
On 02/14/2017 05:53 AM, Joonas Lahtinen wrote: Started adding proper teardown to guc_client_alloc, ended up removing quite a few dead ends where errors communicating with the GuC were silently ignored. There also seemed to be quite a few erronous teardown actions performed in case of an error (

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Postpone fake breadcrumb interrupt until real interrupts cease

2017-02-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Postpone fake breadcrumb interrupt until real interrupts cease URL : https://patchwork.freedesktop.org/series/19784/ State : success == Summary == Series 19784v1 Series without cover letter https://patchwork.freedesktop.org/api

Re: [Intel-gfx] [PATCH 3/3] drm: handle override edid and firmware EDID at drm_do_get_edid() level

2017-02-16 Thread Jani Nikula
On Thu, 16 Feb 2017, Ville Syrjälä wrote: > On Thu, Feb 16, 2017 at 07:54:00PM +0200, Jani Nikula wrote: >> On Thu, 16 Feb 2017, Ville Syrjälä wrote: >> > On Thu, Feb 16, 2017 at 12:36:45PM +0200, Jani Nikula wrote: >> >> Handle debugfs override edid and firmware edid at the low level to >> >> tr

Re: [Intel-gfx] [PATCH v3 12/12] drm/i915: Listen for PMIC bus access notifications

2017-02-16 Thread Jani Nikula
On Thu, 16 Feb 2017, Ville Syrjälä wrote: > On Fri, Feb 10, 2017 at 11:28:02AM +0100, Hans de Goede wrote: >> Listen for PMIC bus access notifications and get FORCEWAKE_ALL while >> the bus is accessed to avoid needing to do any forcewakes, which need >> PMIC bus access, while the PMIC bus is busy

Re: [Intel-gfx] [PATCH] lib/igt_kms: Fix regression on kms_plane_lowres test

2017-02-16 Thread Robert Foss
Applied and tested patch. Reviewed-by: Robert Foss On 2017-02-16 09:06 AM, Mika Kahola wrote: kms_plane_lowres subtest pipe-C-tiling-none crashes when reading out number of crtc. This patch fixes the bug on crtc readout. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99653 Fixes: 9de6

Re: [Intel-gfx] [PATCH 3/3] drm: handle override edid and firmware EDID at drm_do_get_edid() level

2017-02-16 Thread Ville Syrjälä
On Thu, Feb 16, 2017 at 08:59:13PM +0200, Jani Nikula wrote: > On Thu, 16 Feb 2017, Ville Syrjälä wrote: > > On Thu, Feb 16, 2017 at 07:54:00PM +0200, Jani Nikula wrote: > >> On Thu, 16 Feb 2017, Ville Syrjälä wrote: > >> > On Thu, Feb 16, 2017 at 12:36:45PM +0200, Jani Nikula wrote: > >> >> Hand

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic: Add accessor macros for all atomic state. (rev5)

2017-02-16 Thread Patchwork
== Series Details == Series: drm/atomic: Add accessor macros for all atomic state. (rev5) URL : https://patchwork.freedesktop.org/series/17745/ State : success == Summary == Series 17745v5 drm/atomic: Add accessor macros for all atomic state. https://patchwork.freedesktop.org/api/1.0/series/17

[Intel-gfx] [PATCH i-g-t v3] gitignore: Add files starting with .

2017-02-16 Thread Michel Thierry
I cant be the only one that have added .tags by mistake. v2: Do not ignore .gitignore v3: Move !.gitignore at the end, otherwise it'll ignore new .gitignore files in another directory (Petri) Cc: Petri Latvala Cc: Joonas Lahtinen Signed-off-by: Michel Thierry --- .gitignore | 6 ++ 1 file

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix DisplayPort Hotplug (rev2)

2017-02-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix DisplayPort Hotplug (rev2) URL : https://patchwork.freedesktop.org/series/19601/ State : success == Summary == Series 19601v2 drm/i915: Fix DisplayPort Hotplug https://patchwork.freedesktop.org/api/1.0/series/19601/revisions/2/mbox/ fi-bdw-5557u

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Defer declaration of missed-interrupt until the waiter is asleep

2017-02-16 Thread Patchwork
== Series Details == Series: drm/i915: Defer declaration of missed-interrupt until the waiter is asleep URL : https://patchwork.freedesktop.org/series/19791/ State : failure == Summary == CC [M] drivers/gpu/drm/i915/gvt/cfg_space.o CC [M] drivers/gpu/drm/i915/gvt/opregion.o CC [M] dr

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2] drm/i915: Take forcewake for setting the RPS thresholds (rev2)

2017-02-16 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Take forcewake for setting the RPS thresholds (rev2) URL : https://patchwork.freedesktop.org/series/19794/ State : failure == Summary == Series 19794v2 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH] drm/i915: Squelch any ktime/jiffie rounding errors for wait-ioctl

2017-02-16 Thread Chris Wilson
On Thu, Feb 16, 2017 at 03:42:20PM +0200, Joonas Lahtinen wrote: > On to, 2017-02-16 at 12:54 +, Chris Wilson wrote: > > We wait upon jiffies, but report the time elapsed using a > > high-resolution timer. This discrepancy can lead to us timing out the > > wait prior to us reporting the elapsed

Re: [Intel-gfx] [PATCH] i915/drm/HuC: Motivation behind having HuC

2017-02-16 Thread Rodrigo Vivi
This matches the description we got for release so, Reviewed-by: Rodrigo Vivi On Wed, Feb 15, 2017 at 5:29 PM, Anusha Srivatsa wrote: > Correct the comment in intel_huc.c that tells the motivation > behind having HuC, a dedicated firmware for media. > > Cc: Lyncoln Cheng > Cc: Rodrigo Vivi > S

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Remove struct_mutex for destroying framebuffers (rev2)

2017-02-16 Thread Chris Wilson
On Thu, Feb 16, 2017 at 02:21:55PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [v2] drm/i915: Remove struct_mutex for > destroying framebuffers (rev2) > URL : https://patchwork.freedesktop.org/series/19692/ > State : success > > == Summary == > > Series 196

[Intel-gfx] [PATCH v2] drm/i915/guc: Keep the ctx_pool_vaddr mapped, for easy access

2017-02-16 Thread Oscar Mateo
The GuC descriptor is big in size. If we use a local definition of guc_desc we have a chance to overflow stack, so avoid it. Also, Chris abhors scatterlists :) v2: Rebased, helper function to retrieve the context descriptor, s/ctx_pool_vma/ctx_pool/ Signed-off-by: Oscar Mateo --- drivers/gpu/d

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Keep the ctx_pool_vaddr mapped, for easy access

2017-02-16 Thread Oscar Mateo
Onion teardown in a separate patch (since it addresses a separate problem). On 02/16/2017 06:15 AM, Oscar Mateo wrote: The GuC descriptor is big in size. If we use a local definition of guc_desc we have a chance to overflow stack, so avoid it. Also, Chris abhors scatterlists :) v2: Rebased, h

[Intel-gfx] [PATCH] drm/i915/guc: Add onion teardown to the GuC setup

2017-02-16 Thread Oscar Mateo
Starting with intel_guc_loader, down to intel_guc_submission and finally to intel_guc_log. Signed-off-by: Oscar Mateo --- drivers/gpu/drm/i915/i915_guc_submission.c | 94 + drivers/gpu/drm/i915/intel_guc_loader.c| 19 +- drivers/gpu/drm/i915/intel_guc_log.c | 309

Re: [Intel-gfx] [PATCH] drm/i915/guc: Add onion teardown to the GuC setup

2017-02-16 Thread Oscar Mateo
This goes on top of "Keep the ctx_pool_vaddr mapped, for easy access", which is in turn goes on top of Joonas' "Sanitize GuC client initialization". If the reviews go well and once Joonas finishes his patch, I can resend everything as a series so that merging is easier. -- Oscar On 02/16/2017

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: VLV/CHV two-stage watermarks (rev2)

2017-02-16 Thread Patchwork
== Series Details == Series: drm/i915: VLV/CHV two-stage watermarks (rev2) URL : https://patchwork.freedesktop.org/series/16712/ State : success == Summary == Series 16712v2 drm/i915: VLV/CHV two-stage watermarks https://patchwork.freedesktop.org/api/1.0/series/16712/revisions/2/mbox/ fi-bdw-

[Intel-gfx] [PATCH i-g-t] tools/intel_guc_logger: Fix the assert for the verbosity level

2017-02-16 Thread Oscar Mateo
I guess no one has needed to change the verbosity level of the GuC logs. Signed-off-by: Oscar Mateo --- tools/intel_guc_logger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_guc_logger.c b/tools/intel_guc_logger.c index 159a54e..c9ea60d 100644 --- a/tools/intel

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Keep the ctx_pool_vaddr mapped, for easy access

2017-02-16 Thread Chris Wilson
On Thu, Feb 16, 2017 at 06:15:05AM -0800, Oscar Mateo wrote: > static void guc_ctx_desc_init(struct intel_guc *guc, > struct i915_guc_client *client) > { > struct drm_i915_private *dev_priv = guc_to_i915(guc); > struct intel_engine_cs *engine; > struc

[Intel-gfx] [PATCH v2] drm: Add DPCD definitions for DP 1.4 DSC feature

2017-02-16 Thread Manasi Navare
Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC. v2: * Rebased on drm-tip Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Paulo Zanoni Cc: dri-de...@lists.freedesktop.org --- include/drm/drm_dp_helper.h | 102 +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Add DPCD definitions for DP 1.4 DSC feature (rev3)

2017-02-16 Thread Patchwork
== Series Details == Series: drm: Add DPCD definitions for DP 1.4 DSC feature (rev3) URL : https://patchwork.freedesktop.org/series/19666/ State : success == Summary == Series 19666v3 drm: Add DPCD definitions for DP 1.4 DSC feature https://patchwork.freedesktop.org/api/1.0/series/19666/revisi

[Intel-gfx] [PATCH] i915/drm/HuC: Motivation behind having HuC

2017-02-16 Thread Anusha Srivatsa
Correct the comment in intel_huc.c that tells the motivation behind having HuC, a dedicated firmware for media. Cc: Lyncoln Cheng Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_huc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a

[Intel-gfx] [PATCH] drm/i915: DMC 1.03 for Geminilake

2017-02-16 Thread Rodrigo Vivi
There is a new version of DMC available for Geminilake. It's release notes only mention: - Enhancement in the FW to restore the PG2 state v2: Fixed the platform name on commit message. Noticed by Jani S. v3: cook on top of drm-tip without depending on kbl one so CI can check. v4: make v3

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/drm/HuC: Motivation behind having HuC (rev2)

2017-02-16 Thread Patchwork
== Series Details == Series: i915/drm/HuC: Motivation behind having HuC (rev2) URL : https://patchwork.freedesktop.org/series/19746/ State : success == Summary == Series 19746v2 i915/drm/HuC: Motivation behind having HuC https://patchwork.freedesktop.org/api/1.0/series/19746/revisions/2/mbox/

Re: [Intel-gfx] [PULL] drm-misc-next-fixes, take 2

2017-02-16 Thread Dave Airlie
On 16 February 2017 at 19:49, Jani Nikula wrote: > > Hi Dave, this one superseeds [1]. Better to flush out the single uapi > fix for v4.11 now so it's not forgotten. Looks like I had already pulled, I just reverted Maarten's patch on top of drm-next. Dave. ___

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: DMC 1.03 for Geminilake (rev5)

2017-02-16 Thread Patchwork
== Series Details == Series: drm/i915: DMC 1.03 for Geminilake (rev5) URL : https://patchwork.freedesktop.org/series/19081/ State : success == Summary == Series 19081v5 drm/i915: DMC 1.03 for Geminilake https://patchwork.freedesktop.org/api/1.0/series/19081/revisions/5/mbox/ fi-bdw-5557u

Re: [Intel-gfx] [GLK MIPI DSI V5 3/8] drm/i915/glk: Add MIPIIO Enable/disable sequence

2017-02-16 Thread Chauhan, Madhav
> -Original Message- > From: Nikula, Jani > Sent: Thursday, February 16, 2017 8:38 PM > To: Chauhan, Madhav ; intel- > g...@lists.freedesktop.org > Cc: Conselvan De Oliveira, Ander ; > Shankar, Uma ; Mukherjee, Indranil > ; Saarinen, Jani ; > Kamath, Sunil ; Deepak M > ; Chauhan, Madhav >

<    1   2   3   >