Re: [Intel-gfx] [PATCH] drm/i915/snb+: Remove incorrect forcewake check in debugfs/i915_drpc_info

On 08/02/18 11:23, Imre Deak wrote: FORCEWAKE_ACK is depricated by BSpec at least starting from BDW, referring to the multi-threaded version of it instead. Accessing FORCEWAKE_ACK triggers an unclaimed register access error - at least on GLK - see the Reference: below. The correct registers to

Re: [Intel-gfx] [PATCH] drm/i915: Fix kerneldoc warnings for i915_gem_internal

Quoting Chris Wilson (2018-02-08 11:42:24) > drivers/gpu/drm/i915/i915_gem_internal.c:183: warning: No description found > for parameter 'i915' > drivers/gpu/drm/i915/i915_gem_internal.c:183: warning: No description found > for parameter 'size' > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Fix kerneldoc warnings in i915_gem_execbuffer

Quoting Chris Wilson (2018-02-08 13:39:17) > drivers/gpu/drm/i915/i915_gem_execbuffer.c:1983: warning: No description > found for parameter 'dev_priv' > drivers/gpu/drm/i915/i915_gem_execbuffer.c:1983: warning: No description > found for parameter 'file' > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH v2] drm/i915/icl: Update subslice define for ICL 11

On 11/01/18 18:25, Oscar Mateo wrote: From: Kelvin Gardiner ICL 11 has a greater number of maximum subslices. This patch reflects this. v2: GEN11 updates to MCR_SELECTOR (Oscar) Bspec: 21139 BSpec: 21108 Reviewed-by: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH v6] drm/i915/userptr: Probe vma range before gup

We want to exclude any GGTT objects from being present on our internal lists to avoid the deadlock we may run into with our requirement for struct_mutex during invalidate. However, if the gup_fast fails, we put the userptr onto the workqueue and mark it as active, so that we remember to serialise

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/igt_debugfs: Add igt_pipe_crc_get_single and igt_pipe_crc_drain, v3.

== Series Details == Series: lib/igt_debugfs: Add igt_pipe_crc_get_single and igt_pipe_crc_drain, v3. URL : https://patchwork.freedesktop.org/series/37910/ State : success == Summary == IGT patchset tested on top of latest successful build 3af87d45da24015b7a6124b59b2c4b854381cab6

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Fix kerneldoc warnings for intel_ringbuffer

== Series Details == Series: drm/i915: Fix kerneldoc warnings for intel_ringbuffer URL : https://patchwork.freedesktop.org/series/37896/ State : warning == Summary == Test gem_exec_suspend: Subgroup basic-s4: fail -> SKIP (shard-snb) fdo#103375 +1 Test

Re: [Intel-gfx] [RFC] drm/i915: Use DOUBLE_BUFFER_CTL instead of vblank evasion for GEN9+.

On Thu, Feb 08, 2018 at 09:55:38AM +0100, Maarten Lankhorst wrote: > References: https://bugs.freedesktop.org/show_bug.cgi?id=104975 > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] [PATCH] drm/i915: Don't query PCODE RC6VIDS on platforms not supporting it

On Thu, Feb 08, 2018 at 06:33:03PM +, Chris Wilson wrote: > Quoting Imre Deak (2018-02-08 17:41:02) > > On BXT/GLK GEN6_PCODE_READ_RC6VIDS fails with > > MAILBOX_P24C_CC_ILLEGAL_CMD, so don't try to do the query on these > > platforms. Do it only on SNB, IVB and HSW, where we use this command

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/crt: Silence compiler warning for uninitialised status (rev2)

== Series Details == Series: drm/i915/crt: Silence compiler warning for uninitialised status (rev2) URL : https://patchwork.freedesktop.org/series/33365/ State : success == Summary == Series 33365v2 drm/i915/crt: Silence compiler warning for uninitialised status

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Handle RC6 counter wrap (rev4)

== Series Details == Series: drm/i915: Handle RC6 counter wrap (rev4) URL : https://patchwork.freedesktop.org/series/37824/ State : success == Summary == Series 37824v4 drm/i915: Handle RC6 counter wrap https://patchwork.freedesktop.org/api/1.0/series/37824/revisions/4/mbox/ Test

Re: [Intel-gfx] [PATCH v5] drm/i915: Handle RC6 counter wrap

Quoting Tvrtko Ursulin (2018-02-08 16:00:36) > From: Tvrtko Ursulin > > We can implement limited RC6 counter wrap-around protection under the > assumption that clients will be reading this value more frequently than > the wrap period on a given platform. > > With the

Re: [Intel-gfx] [PATCH] drm/i915: Fix kerneldoc warnings for i915_gem_internal

Quoting Chris Wilson (2018-02-08 13:42:24) > drivers/gpu/drm/i915/i915_gem_internal.c:183: warning: No description found > for parameter 'i915' > drivers/gpu/drm/i915/i915_gem_internal.c:183: warning: No description found > for parameter 'size' > > Signed-off-by: Chris Wilson

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable unused-but-set compiler warning

== Series Details == Series: drm/i915: Disable unused-but-set compiler warning URL : https://patchwork.freedesktop.org/series/37925/ State : success == Summary == Series 37925v1 drm/i915: Disable unused-but-set compiler warning

[Intel-gfx] [PATCH 1/8] include: Move ascii85 functions from i915 to linux/ascii85.h

The i915 DRM driver very cleverly used ascii85 encoding for their GPU state file. Move the encode functions to a general header file to support other drivers that might be interested in the same functionality. [v2 - Update the API to be cleaner for the caller suggested by Chris Wilson]

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix kerneldoc warnings for i915_gem_userptr

== Series Details == Series: drm/i915: Fix kerneldoc warnings for i915_gem_userptr URL : https://patchwork.freedesktop.org/series/37897/ State : success == Summary == Test perf_pmu: Subgroup semaphore-wait-idle-bcs0: pass -> FAIL (shard-apl) fdo#105011 Test

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Handle RC6 counter wrap (rev5)

== Series Details == Series: drm/i915: Handle RC6 counter wrap (rev5) URL : https://patchwork.freedesktop.org/series/37824/ State : success == Summary == Series 37824v5 drm/i915: Handle RC6 counter wrap https://patchwork.freedesktop.org/api/1.0/series/37824/revisions/5/mbox/ Test

[Intel-gfx] [PATCH] drm/i915/crt: Silence compiler warning for uninitialised status

clang is confused by our if-else-chain that abruptly exits before a final else: drivers/gpu/drm/i915/intel_crt.c:821:11: warning: variable 'status' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] else if (ret < 0) ^~~

Re: [Intel-gfx] [PATCH] drm/i915: Disable unused-but-set compiler warning

Op 08-02-18 om 17:16 schreef Chris Wilson: > The unused-but-set warning enabled by W=1 catches out a lot of the > atomic helper iterator macros and drown us in their noise (or trip over > Werror and die). Path of least resistance is to ignore the warning. > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 1/8] include: Move ascii85 functions from i915 to linux/ascii85.h

Quoting Jordan Crouse (2018-02-08 17:31:50) > The i915 DRM driver very cleverly used ascii85 encoding for their > GPU state file. Move the encode functions to a general header file to > support other drivers that might be interested in the same > functionality. > > [v2 - Update the API to be

Re: [Intel-gfx] [PATCH] drm/i915: Fix kerneldoc warnings for i915_gem_internal

Quoting Chris Wilson (2018-02-08 16:06:59) > Quoting Chris Wilson (2018-02-08 11:42:24) > > drivers/gpu/drm/i915/i915_gem_internal.c:183: warning: No description found > > for parameter 'i915' > > drivers/gpu/drm/i915/i915_gem_internal.c:183: warning: No description found > > for parameter

[Intel-gfx] [PATCH] drm/i915: Disable unused-but-set compiler warning

The unused-but-set warning enabled by W=1 catches out a lot of the atomic helper iterator macros and drown us in their noise (or trip over Werror and die). Path of least resistance is to ignore the warning. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen

[Intel-gfx] [PATCH] drm/i915: Don't query PCODE RC6VIDS on platforms not supporting it

On BXT/GLK GEN6_PCODE_READ_RC6VIDS fails with MAILBOX_P24C_CC_ILLEGAL_CMD, so don't try to do the query on these platforms. Do it only on SNB, IVB and HSW, where we use this command anyway for RC6 enabling. Based on my tests the command also succeeds on all LLC platforms, but it's not clear if

Re: [Intel-gfx] [PATCH] drm/i915/crt: Silence compiler warning for uninitialised status

On Thu, Feb 08, 2018 at 04:39:39PM +, Chris Wilson wrote: > clang is confused by our if-else-chain that abruptly exits before a > final else: > > drivers/gpu/drm/i915/intel_crt.c:821:11: warning: variable 'status' is used > uninitialized whenever 'if' condition is false

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't query PCODE RC6VIDS on platforms not supporting it

== Series Details == Series: drm/i915: Don't query PCODE RC6VIDS on platforms not supporting it URL : https://patchwork.freedesktop.org/series/37936/ State : success == Summary == Series 37936v1 drm/i915: Don't query PCODE RC6VIDS on platforms not supporting it

Re: [Intel-gfx] [PATCH] drm/i915: Don't query PCODE RC6VIDS on platforms not supporting it

Quoting Imre Deak (2018-02-08 17:41:02) > On BXT/GLK GEN6_PCODE_READ_RC6VIDS fails with > MAILBOX_P24C_CC_ILLEGAL_CMD, so don't try to do the query on these > platforms. Do it only on SNB, IVB and HSW, where we use this command > anyway for RC6 enabling. > > Based on my tests the command also

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/userptr: Probe vma range before gup (rev6)

== Series Details == Series: drm/i915/userptr: Probe vma range before gup (rev6) URL : https://patchwork.freedesktop.org/series/35394/ State : success == Summary == Series 35394v6 drm/i915/userptr: Probe vma range before gup

[Intel-gfx] [PATCH v5] drm/i915: Handle RC6 counter wrap

From: Tvrtko Ursulin We can implement limited RC6 counter wrap-around protection under the assumption that clients will be reading this value more frequently than the wrap period on a given platform. With the typical wrap-around period being ~90 minutes, even with the

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/snb+: Remove incorrect forcewake check in debugfs/i915_drpc_info

== Series Details == Series: drm/i915/snb+: Remove incorrect forcewake check in debugfs/i915_drpc_info URL : https://patchwork.freedesktop.org/series/37901/ State : warning == Summary == Test kms_flip: Subgroup basic-flip-vs-modeset: pass -> DMESG-WARN

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix kerneldoc warnings for i915_gem_request

== Series Details == Series: drm/i915: Fix kerneldoc warnings for i915_gem_request URL : https://patchwork.freedesktop.org/series/37898/ State : success == Summary == Test gem_eio: Subgroup in-flight-contexts: pass -> FAIL (shard-hsw) fdo#104676 Test

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Remove lost comment from i915_gem_context

== Series Details == Series: drm/i915: Remove lost comment from i915_gem_context URL : https://patchwork.freedesktop.org/series/37900/ State : warning == Summary == Test kms_sysfs_edid_timing: pass -> WARN (shard-apl) fdo#100047 Test kms_flip: Subgroup

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix kerneldoc warnings in i915_gem_execbuffer

== Series Details == Series: drm/i915: Fix kerneldoc warnings in i915_gem_execbuffer URL : https://patchwork.freedesktop.org/series/37907/ State : success == Summary == Test kms_cursor_crc: Subgroup cursor-64x64-suspend: pass -> FAIL (shard-snb) fdo#102365

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Fix kerneldoc warnings for i915_gem_internal

== Series Details == Series: drm/i915: Fix kerneldoc warnings for i915_gem_internal URL : https://patchwork.freedesktop.org/series/37908/ State : warning == Summary == Test kms_rotation_crc: Subgroup sprite-rotation-90-flip: pass -> FAIL (shard-apl)

Re: [Intel-gfx] [PATCH v2] drm/i915: Handle RC6 counter wrap

Quoting Tvrtko Ursulin (2018-02-08 07:04:37) > From: Tvrtko Ursulin > > We can implement limited RC6 counter wrap-around protection under the > assumption that clients will be reading this value more frequently than > the wrap period on a given platform. > > With the

Re: [Intel-gfx] [PATCH 08/16] drm/i915/skl+: nv12 workaround disable WM level 1-7

Regards Shashank On 2/6/2018 6:28 PM, Vidya Srinivas wrote: From: Mahesh Kumar Display Workaround #0826 (SKL:ALL BXT:ALL) & #1059(CNL:A) Hardware sometimes fails to wake memory from pkg C states fetching the last few lines of planar YUV 420 (NV12) planes. This

Re: [Intel-gfx] [PATCH 07/16] drm/i915/skl+: make sure higher latency level has higher wm value

Regards Shashank On 2/6/2018 6:28 PM, Vidya Srinivas wrote: From: Mahesh Kumar DDB allocation optimization algorithm requires/assumes ddb allocation for any memory C-state level DDB value to be as high as level below. this line / statement can be more clear, "DDB

Re: [Intel-gfx] [PATCH] drm/i915: add schedule out notification of completed request during unwind

-Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Thursday, February 8, 2018 3:37 PM To: Li, Weinan Z ; intel-gfx@lists.freedesktop.org Cc: intel-gvt-...@lists.freedesktop.org; Li, Weinan Z ; Zhenyu Wang

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: add schedule out notification of completed request during unwind

== Series Details == Series: drm/i915: add schedule out notification of completed request during unwind URL : https://patchwork.freedesktop.org/series/37860/ State : success == Summary == Warning: bzip CI_DRM_3739/shard-glkb6/results17.json.bz2 wasn't in correct JSON format Test

Re: [Intel-gfx] [PATCH] drm/i915: Mark the device as wedged from the beginning of set-wedged

Quoting Chris Wilson (2018-02-07 15:13:50) > Reduce the window of opportunity for set-wedged being called > concurrently with reset (after i915_reset() has performed the > i915_gem_unset_wedged()) by moving the set_bit(I915_WEDGED) to before we > complete the inflight requests. When i915_reset()

[Intel-gfx] [PATCH v3] drm/i915: Handle RC6 counter wrap

From: Tvrtko Ursulin We can implement limited RC6 counter wrap-around protection under the assumption that clients will be reading this value more frequently than the wrap period on a given platform. With the typical wrap-around period being ~90 minutes, even with the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: Sync PCI ID with Spec.

== Series Details == Series: drm/i915/cnl: Sync PCI ID with Spec. URL : https://patchwork.freedesktop.org/series/37873/ State : success == Summary == Series 37873v1 drm/i915/cnl: Sync PCI ID with Spec. https://patchwork.freedesktop.org/api/1.0/series/37873/revisions/1/mbox/ Test

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove redundant check on execlists interrupt

== Series Details == Series: drm/i915: Remove redundant check on execlists interrupt URL : https://patchwork.freedesktop.org/series/37923/ State : failure == Summary == Test kms_cursor_legacy: Subgroup cursor-vs-flip-legacy: fail -> PASS (shard-apl)

Re: [Intel-gfx] [PATCH v9 6/7] drm/i915/guc: Check the locking status of GuC WOPCM registers

Quoting Jackie Li (2018-02-08 23:03:54) > @@ -95,7 +97,11 @@ struct intel_guc_wopcm { > u32 offset; > u32 size; > u32 top; > - u32 valid; > + > + /* GuC WOPCM flags below. */ > + u32 valid:1; > + u32 hw_updated:1; > + u32 need_load_huc_fw:1;

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/crt: Silence compiler warning for uninitialised status (rev2)

== Series Details == Series: drm/i915/crt: Silence compiler warning for uninitialised status (rev2) URL : https://patchwork.freedesktop.org/series/33365/ State : success == Summary == Test kms_vblank: Subgroup pipe-a-ts-continuation-dpms-suspend: skip -> PASS

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Don't query PCODE RC6VIDS on platforms not supporting it

== Series Details == Series: drm/i915: Don't query PCODE RC6VIDS on platforms not supporting it URL : https://patchwork.freedesktop.org/series/37936/ State : success == Summary == Test kms_cursor_crc: Subgroup cursor-64x64-offscreen: skip -> PASS

Re: [Intel-gfx] [PATCH] drm/i915: Display WA #0827 for NV12 to RGB switch

Apologies. This patch was pushed wrongly. Not a part of the 16 patch series of NV12. Regards Vidya > -Original Message- > From: Sharma, Shashank > Sent: Thursday, February 8, 2018 6:08 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Cc:

Re: [Intel-gfx] [PATCH 14/16] drm/i915: Add NV12 as supported format for sprite plane

> -Original Message- > From: Sharma, Shashank > Sent: Thursday, February 8, 2018 4:21 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Cc: maarten.lankho...@linux.intel.com; Kamath, Sunil > ; Shankar, Uma

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Handle RC6 counter wrap (rev5)

== Series Details == Series: drm/i915: Handle RC6 counter wrap (rev5) URL : https://patchwork.freedesktop.org/series/37824/ State : success == Summary == Test gem_eio: Subgroup in-flight-contexts: pass -> FAIL (shard-hsw) fdo#104676 +1 Test kms_cursor_crc:

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

> On Feb 8, 2018, at 4:39 PM, Pandiyan, Dhinakaran > wrote: > > >> On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: >> Hi Andy, >> >> thanks for getting involved with PSR and sorry for not replying sooner. >> >> I first saw this patch on that bugzilla

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

"Pandiyan, Dhinakaran" writes: > On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: >> Hi Andy, >> >> thanks for getting involved with PSR and sorry for not replying sooner. >> >> I first saw this patch on that bugzilla entry but only now I stop to >> really

[Intel-gfx] Recall: [PATCH] drm/i915: NV12 changes for Gen10

Srinivas, Vidya would like to recall the message, "[PATCH] drm/i915: NV12 changes for Gen10". ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

Hi Andy, thanks for getting involved with PSR and sorry for not replying sooner. I first saw this patch on that bugzilla entry but only now I stop to really think why I have written the code that way. So some clarity below. On Mon, Feb 05, 2018 at 10:07:09PM +, Andy Lutomirski wrote: >

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: > Hi Andy, > > thanks for getting involved with PSR and sorry for not replying sooner. > > I first saw this patch on that bugzilla entry but only now I stop to > really think why I have written the code that way. > > So some clarity below.

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

On Thu, 2018-02-08 at 17:01 -0800, Andy Lutomirski wrote: > > > > On Feb 8, 2018, at 4:39 PM, Pandiyan, Dhinakaran > > wrote: > > > > > >> On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: > >> Hi Andy, > >> > >> thanks for getting involved with PSR

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Disable unused-but-set compiler warning

== Series Details == Series: drm/i915: Disable unused-but-set compiler warning URL : https://patchwork.freedesktop.org/series/37925/ State : success == Summary == Test kms_cursor_legacy: Subgroup cursor-vs-flip-legacy: fail -> PASS (shard-apl) fdo#103355

Re: [Intel-gfx] [PATCH] drm/i915: NV12 changes for Gen10

Apologies. This patch was pushed wrongly. Not a part of the 16 patch series of NV12. Regards Vidya > -Original Message- > From: Sharma, Shashank > Sent: Thursday, February 8, 2018 6:17 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Cc:

[Intel-gfx] [PATCH v9 3/7] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

Hardware may have specific restrictions on GuC WOPCM offset and size. On Gen9, the value of the GuC WOPCM size register needs to be larger than the value of GuC WOPCM offset register + a Gen9 specific offset (144KB) for reserved GuC WOPCM. Fail to enforce such a restriction on GuC WOPCM size will

[Intel-gfx] [PATCH v9 7/7] HAX Enable GuC Submission for CI

Signed-off-by: Jackie Li --- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_guc_wopcm.c | 6 ++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c

[Intel-gfx] [PATCH v9 4/7] drm/i915/guc: Add support to return CNL specific reserved GuC WOPCM size

CNL has its specific reserved GuC WOPCM size for RC6 and other hardware contexts. This patch updates the code to return CNL specific reserved GuC WOPCM size for RC6 and other hardware contexts so that the GuC WOPCM size can be calculated correctly for CNL. v9: - Created a new patch for these

[Intel-gfx] [PATCH v9 1/7] drm/i915/guc: Move GuC WOPCM related code into separate files

intel_guc_reg.h should only include definition for GuC registers and related register bits. Non-register related GuC WOPCM macro definitions should not be defined in intel_guc_reg.h. This patch cleans up intel_guc_reg.h and moves GuC WOPCM related code into new created separate files as future

[Intel-gfx] [PATCH v9 2/7] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

GuC related exported functions should start with "intel_guc_" prefix and pass intel_guc as the first parameter since its guc related. Current guc_ggtt_offset() failed to follow this code convention and this is a problem for future patches that needs to access intel_guc data to verify the GGTT

[Intel-gfx] [PATCH v9 5/7] drm/i915/guc: Add HuC firmware size related restriction for Gen9 and CNL A0

On CNL A0 and Gen9, there's a hardware restriction that requires the available GuC WOPCM size to be larger than or equal to HuC firmware size. This patch adds new verfication code to ensure the available GuC WOPCM size to be larger than or equal to HuC firmware size on both Gen9 and CNL A0. v6:

[Intel-gfx] [PATCH v9 6/7] drm/i915/guc: Check the locking status of GuC WOPCM registers

GuC WOPCM registers are write-once registers. Current driver code accesses these registers without checking the accessibility to these registers which will lead to unpredictable driver behaviors if these registers were touch by other components (such as faulty BIOS code). This patch moves the GuC

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v9,1/7] drm/i915/guc: Move GuC WOPCM related code into separate files

== Series Details == Series: series starting with [v9,1/7] drm/i915/guc: Move GuC WOPCM related code into separate files URL : https://patchwork.freedesktop.org/series/37957/ State : failure == Summary == Series 37957v1 series starting with [v9,1/7] drm/i915/guc: Move GuC WOPCM related code

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Rename drm_i915_gem_request to i915_request

== Series Details == Series: drm/i915: Rename drm_i915_gem_request to i915_request URL : https://patchwork.freedesktop.org/series/37958/ State : success == Summary == Series 37958v1 drm/i915: Rename drm_i915_gem_request to i915_request

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

> -Original Message- > From: Sharma, Shashank > Sent: Thursday, February 8, 2018 2:35 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Cc: maarten.lankho...@linux.intel.com; Kamath, Sunil > ; Shankar, Uma

Re: [Intel-gfx] [PATCH 08/16] drm/i915/skl+: nv12 workaround disable WM level 1-7

Hi, On 2/8/2018 2:01 PM, Sharma, Shashank wrote: Regards Shashank On 2/6/2018 6:28 PM, Vidya Srinivas wrote: From: Mahesh Kumar Display Workaround #0826 (SKL:ALL BXT:ALL) & #1059(CNL:A) Hardware sometimes fails to wake memory from pkg C states fetching the last

[Intel-gfx] [PATCH] drm/i915: Avoid truncation before clamping userspace's priority value

Userspace provides a 64b value for the priority, we need to be careful to preserve the full range before validation to prevent truncation (and letting an illegal value pass). Reported-by: Antonio Argenziano Fixes: ac14fbd460d0 ("drm/i915/scheduler: Support

[Intel-gfx] [RFC] drm/i915: Use DOUBLE_BUFFER_CTL instead of vblank evasion for GEN9+.

References: https://bugs.freedesktop.org/show_bug.cgi?id=104975 Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_display.c | 1 +

Re: [Intel-gfx] [PATCH v2] drm/i915: Handle RC6 counter wrap

Quoting Tvrtko Ursulin (2018-02-08 08:50:58) > > On 08/02/2018 08:00, Chris Wilson wrote: > > The other part of the puzzle was perhaps just using a timer to read the > > registers every 1/2 wrap period, but there was no clear picture on when > > to start and stop that timer for sysfs. However,

Re: [Intel-gfx] [RFC] drm/i915: Use DOUBLE_BUFFER_CTL instead of vblank evasion for GEN9+.

Quoting Maarten Lankhorst (2018-02-08 08:55:38) > References: https://bugs.freedesktop.org/show_bug.cgi?id=104975 > Signed-off-by: Maarten Lankhorst > --- > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index

[Intel-gfx] [PATCH 1/2] drm/i915/perf: Fix compiler warning for string truncation

drivers/gpu/drm/i915/i915_oa_cflgt3.c: In function ‘i915_perf_load_test_config_cflgt3’: drivers/gpu/drm/i915/i915_oa_cflgt3.c:87:2: error: ‘strncpy’ output truncated before terminating nul copying 36 bytes from a string of the same length [-Werror=stringop-truncation] Fixes: 4407eaa9b0cc

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

Regards Shashank On 2/6/2018 6:28 PM, Vidya Srinivas wrote: From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments

Re: [Intel-gfx] [PATCH 11/16] drm/i915: Update format_is_yuv() to include NV12

Regards Shashank On 2/6/2018 6:28 PM, Vidya Srinivas wrote: From: Chandra Konduru This patch adds NV12 to format_is_yuv() function for sprite planes. v2: -Use intel_ prefix for format_is_yuv (Ville) v3: Rebased (me) v4: Rebased and addressed review comments

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid truncation before clamping userspace's priority value

== Series Details == Series: drm/i915: Avoid truncation before clamping userspace's priority value URL : https://patchwork.freedesktop.org/series/37878/ State : success == Summary == Series 37878v1 drm/i915: Avoid truncation before clamping userspace's priority value

Re: [Intel-gfx] [PATCH 12/16] drm/i915: Upscale scaler max scale for NV12

Regards Shashank On 2/6/2018 6:28 PM, Vidya Srinivas wrote: From: Chandra Konduru This patch updates scaler max limit support for NV12 v2: Rebased (me) v3: Rebased (me) v4: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit

Re: [Intel-gfx] [PATCH 1/2] drm/i915/perf: Fix compiler warning for string truncation

Quoting Lionel Landwerlin (2018-02-08 10:18:05) > Arg... I don't know how this happened. > I thought we agreed upon using strlcpy()? The others are using sizeof() + strlcpy. I missed the strlcpy difference. char uuid[sizeof(test_config.uuid)] = "..."; memcpy(test_config.uuid, uuid,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Handle RC6 counter wrap (rev3)

== Series Details == Series: drm/i915: Handle RC6 counter wrap (rev3) URL : https://patchwork.freedesktop.org/series/37824/ State : success == Summary == Series 37824v3 drm/i915: Handle RC6 counter wrap https://patchwork.freedesktop.org/api/1.0/series/37824/revisions/3/mbox/ Test

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use DOUBLE_BUFFER_CTL instead of vblank evasion for GEN9+.

== Series Details == Series: drm/i915: Use DOUBLE_BUFFER_CTL instead of vblank evasion for GEN9+. URL : https://patchwork.freedesktop.org/series/37879/ State : success == Summary == Series 37879v1 drm/i915: Use DOUBLE_BUFFER_CTL instead of vblank evasion for GEN9+.

[Intel-gfx] [PATCH v2 1/2] drm/i915/perf: Fix compiler warning for string truncation

drivers/gpu/drm/i915/i915_oa_cflgt3.c: In function ‘i915_perf_load_test_config_cflgt3’: drivers/gpu/drm/i915/i915_oa_cflgt3.c:87:2: error: ‘strncpy’ output truncated before terminating nul copying 36 bytes from a string of the same length [-Werror=stringop-truncation] v2: strlcpy Fixes:

[Intel-gfx] [PATCH v2 2/2] drm/i915/perf: Fix compiler warning for string truncation

drivers/gpu/drm/i915/i915_oa_cnl.c: In function ‘i915_perf_load_test_config_cnl’: drivers/gpu/drm/i915/i915_oa_cnl.c:99:2: error: ‘strncpy’ output truncated before terminating nul copying 36 bytes from a string of the same length [-Werror=stringop-truncation] v2: strlcpy Fixes: 95690a02fb5d

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/perf: Fix compiler warning for string truncation

On 08/02/18 10:24, Chris Wilson wrote: drivers/gpu/drm/i915/i915_oa_cnl.c: In function ‘i915_perf_load_test_config_cnl’: drivers/gpu/drm/i915/i915_oa_cnl.c:99:2: error: ‘strncpy’ output truncated before terminating nul copying 36 bytes from a string of the same length

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/perf: Fix compiler warning for string truncation

On 08/02/18 10:24, Chris Wilson wrote: drivers/gpu/drm/i915/i915_oa_cflgt3.c: In function ‘i915_perf_load_test_config_cflgt3’: drivers/gpu/drm/i915/i915_oa_cflgt3.c:87:2: error: ‘strncpy’ output truncated before terminating nul copying 36 bytes from a string of the same length

Re: [Intel-gfx] [PATCH v2] drm/i915: Handle RC6 counter wrap

On 08/02/2018 08:00, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-02-08 07:04:37) From: Tvrtko Ursulin We can implement limited RC6 counter wrap-around protection under the assumption that clients will be reading this value more frequently than the wrap period

Re: [Intel-gfx] [PATCH 1/2] drm/i915/perf: Fix compiler warning for string truncation

Arg... I don't know how this happened. I thought we agreed upon using strlcpy()? On 08/02/18 10:09, Chris Wilson wrote: drivers/gpu/drm/i915/i915_oa_cflgt3.c: In function ‘i915_perf_load_test_config_cflgt3’: drivers/gpu/drm/i915/i915_oa_cflgt3.c:87:2: error: ‘strncpy’ output truncated before

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Improve PSR activation timing (rev2)

== Series Details == Series: drm/i915: Improve PSR activation timing (rev2) URL : https://patchwork.freedesktop.org/series/37693/ State : warning == Summary == Series 37693v2 drm/i915: Improve PSR activation timing https://patchwork.freedesktop.org/api/1.0/series/37693/revisions/2/mbox/ Test

[Intel-gfx] [PATCH 2/2] drm/i915/perf: Fix compiler warning for string truncation

drivers/gpu/drm/i915/i915_oa_cnl.c: In function ‘i915_perf_load_test_config_cnl’: drivers/gpu/drm/i915/i915_oa_cnl.c:99:2: error: ‘strncpy’ output truncated before terminating nul copying 36 bytes from a string of the same length [-Werror=stringop-truncation] Fixes: 95690a02fb5d

Re: [Intel-gfx] [PATCH 13/16] drm/i915: Add NV12 as supported format for primary plane

Regards Shashank On 2/6/2018 6:28 PM, Vidya Srinivas wrote: From: Chandra Konduru This patch adds NV12 to list of supported formats for primary plane v2: Rebased (Chandra Konduru) v3: Rebased (me) v4: Review comments by Ville addressed Removed the

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/perf: Fix compiler warning for string truncation

== Series Details == Series: series starting with [1/2] drm/i915/perf: Fix compiler warning for string truncation URL : https://patchwork.freedesktop.org/series/37890/ State : failure == Summary == Series 37890v1 series starting with [1/2] drm/i915/perf: Fix compiler warning for string

Re: [Intel-gfx] [PATCH 03/16] drm/i915/skl+: add NV12 in skl_format_to_fourcc

From: Sharma, Shashank Sent: Thursday, February 8, 2018 12:17 PM To: Srinivas, Vidya ; intel-gfx@lists.freedesktop.org Cc: maarten.lankho...@linux.intel.com; Kamath, Sunil ; Shankar, Uma ; Kumar, Mahesh1

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Rename drm_i915_gem_request to i915_request

== Series Details == Series: drm/i915: Rename drm_i915_gem_request to i915_request URL : https://patchwork.freedesktop.org/series/37958/ State : warning == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-primscrn-spr-indfb-draw-mmap-gtt: fail -> PASS

Re: [Intel-gfx] [PATCH v9 6/7] drm/i915/guc: Check the locking status of GuC WOPCM registers

On 02/08/2018 03:31 PM, Chris Wilson wrote: Quoting Jackie Li (2018-02-08 23:03:54) @@ -95,7 +97,11 @@ struct intel_guc_wopcm { u32 offset; u32 size; u32 top; - u32 valid; + + /* GuC WOPCM flags below. */ + u32 valid:1; + u32 hw_updated:1; +

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/userptr: Probe vma range before gup (rev6)

== Series Details == Series: drm/i915/userptr: Probe vma range before gup (rev6) URL : https://patchwork.freedesktop.org/series/35394/ State : failure == Summary == Test gem_userptr_blits: Subgroup coherency-sync: pass -> DMESG-WARN (shard-snb) Subgroup

[Intel-gfx] ✗ Fi.CI.IGT: failure for lib/igt_debugfs: Add igt_pipe_crc_get_single and igt_pipe_crc_drain, v3.

== Series Details == Series: lib/igt_debugfs: Add igt_pipe_crc_get_single and igt_pipe_crc_drain, v3. URL : https://patchwork.freedesktop.org/series/37910/ State : failure == Summary == Test kms_cursor_legacy: Subgroup cursor-vs-flip-legacy: fail -> PASS

Re: [Intel-gfx] [PATCH 12/16] drm/i915: Upscale scaler max scale for NV12

> -Original Message- > From: Sharma, Shashank > Sent: Thursday, February 8, 2018 3:16 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Cc: maarten.lankho...@linux.intel.com; Kamath, Sunil > ; Shankar, Uma

Re: [Intel-gfx] [RFC 14/15] drm/i915: Use new IS_GEN range helpers

On Thu, Feb 08, 2018 at 05:13:02PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > Quoting Tvrtko Ursulin (2018-02-08 14:34:38) > >> > >> On 08/02/2018 14:22, Ville Syrjälä wrote: > >> > On Thu, Feb 08, 2018 at 01:06:05PM +, Tvrtko Ursulin wrote: > >> >>

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Add missing kerneldoc for 'ent' in i915_driver_init_early

== Series Details == Series: series starting with [1/2] drm/i915: Add missing kerneldoc for 'ent' in i915_driver_init_early URL : https://patchwork.freedesktop.org/series/37893/ State : failure == Summary == Test kms_flip: Subgroup 2x-plain-flip-fb-recreate-interruptible:

Re: [Intel-gfx] [PATCH] drm/i915: Disable unused-but-set compiler warning

Quoting Maarten Lankhorst (2018-02-08 16:50:08) > Op 08-02-18 om 17:16 schreef Chris Wilson: > > The unused-but-set warning enabled by W=1 catches out a lot of the > > atomic helper iterator macros and drown us in their noise (or trip over > > Werror and die). Path of least resistance is to ignore

Re: [Intel-gfx] [PATCH] drm/i915: Avoid leaking lpe audio platdev.data

Quoting Jani Nikula (2018-01-19 14:11:29) > On Sat, 09 Dec 2017, Chris Wilson wrote: > > The struct platform_device memdups the provided data pointer requiring > > us to free the template we construct during lpe_audio_platdev_create(): > > > > unreferenced object

Re: [Intel-gfx] [PATCH] drm/i915: NV12 changes for Gen10

Apologies. This patch was pushed wrongly. Not a part of the 16 patch series of NV12. Regards Vidya > -Original Message- > From: Sharma, Shashank > Sent: Thursday, February 8, 2018 6:17 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Cc:

  1   2   >