Re: [Intel-gfx] [RFC] drm/i915/psr: Remove PSR active flag from debugfs

On Tue, Mar 13, 2018 at 10:20:58AM -0700, Souza, Jose wrote: > On Mon, 2018-03-12 at 21:42 -0700, Dhinakaran Pandiyan wrote: > > The flag becomes misleading with flips and cursor moves not modifying > > it's > > state as HW takes care of exiting PSR (when HW tracking is enabled) > > > > Cc:

Re: [Intel-gfx] [PATCH 3/3] drm: Store the calculated vrefresh in the user mode

Op 13-03-18 om 16:07 schreef Ville Syrjala: > From: Ville Syrjälä > > Ignore the vrefresh in the mode the user passed in and instead > calculate the value based on the actual timings. This way we can > actually trust mode->vrefresh to some degree. > > Or should we

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915/psr: Move PSR aux setup to it's own function.

== Series Details == Series: series starting with [1/2] drm/i915/psr: Move PSR aux setup to it's own function. URL : https://patchwork.freedesktop.org/series/39825/ State : warning == Summary == Series 39825v1 series starting with [1/2] drm/i915/psr: Move PSR aux setup to it's own function.

Re: [Intel-gfx] [PATCH] [v2] drm/i915/pmu: avoid -Wmaybe-uninitialized warning

On Tue, Mar 13, 2018 at 6:46 PM, Tvrtko Ursulin wrote: > > On 13/03/2018 16:19, Arnd Bergmann wrote: >> >> The conditional spinlock confuses gcc into thinking the 'flags' value >> might contain uninitialized data: >> >> drivers/gpu/drm/i915/i915_pmu.c: In function

Re: [Intel-gfx] [PATCH v3 2/6] cgroup: Introduce task_get_dfl_cgroup()

(cc'ing Roman) Hello, On Tue, Mar 06, 2018 at 03:46:56PM -0800, Matt Roper wrote: > +static inline struct cgroup * > +task_get_dfl_cgroup(struct task_struct *task) > +{ > + struct cgroup *cgrp; > + > + mutex_lock(_mutex); > + cgrp = task_dfl_cgroup(task); > + cgroup_get(cgrp); >

Re: [Intel-gfx] [PATCH v3 3/6] cgroup: Introduce cgroup_permission()

On Tue, Mar 06, 2018 at 03:46:57PM -0800, Matt Roper wrote: > Non-controller kernel subsystems may base access restrictions for > cgroup-related syscalls/ioctls on a process' access to the cgroup. > Let's make it easy for other parts of the kernel to check these cgroup > permissions. I'm not sure

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/cnl: Kill _MMIO_PORT6 macro

On Tue, Mar 13, 2018 at 09:46:22AM +0530, Mahesh Kumar wrote: > This patch replaces use of remaining _MMIO_PORT6 macro and removes the > macro. > > Signed-off-by: Mahesh Kumar > Reviewed-by: Rodrigo Vivi Sorry, but I noticed one more thing here

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove open-coded PSR AUX transactions for SKL+

On Mon, 2018-03-12 at 20:46 -0700, Dhinakaran Pandiyan wrote: > HSW and BDW have SRD_AUX_{CTL, STATUS} registers that the driver > needs to > setup for the HW to use whenever exiting PSR. SKL+ hardware use > hardcoded > values for the same and do not need any registers to be setup. So, > use >

Re: [Intel-gfx] [PATCH v3 1/6] cgroup: Allow registration and lookup of cgroup private data

Hello, Matt. cc'ing Roman and Alexei. On Tue, Mar 06, 2018 at 03:46:55PM -0800, Matt Roper wrote: > There are cases where other parts of the kernel may wish to store data > associated with individual cgroups without building a full cgroup > controller. Let's add interfaces to allow them to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reword warning for missing cases

== Series Details == Series: drm/i915: Reword warning for missing cases URL : https://patchwork.freedesktop.org/series/39821/ State : success == Summary == Known issues: Test gem_eio: Subgroup in-flight-contexts: incomplete -> PASS (shard-apl) fdo#105341 +1

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Remove variable length arrays from sseu debugfs printers

== Series Details == Series: series starting with [1/2] drm/i915: Remove variable length arrays from sseu debugfs printers URL : https://patchwork.freedesktop.org/series/39822/ State : failure == Summary == Possible new issues: Test kms_cursor_crc: Subgroup cursor-64x64-dpms:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+

== Series Details == Series: drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+ URL : https://patchwork.freedesktop.org/series/39826/ State : failure == Summary == Possible new issues: Test drv_suspend: Subgroup forcewake: pass -> SKIP

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove variable length arrays from sseu debugfs printers

On 13/03/2018 00:40, Chris Wilson wrote: In order to enable -Wvla to prevent new variable length arrays being used in i915.ko, we first must remove the existing VLA. Inside i915_print_sseu_info(), VLA are used as the actual size of the sseu depends on platform. Replace the VLA with the maximum

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Fix intel_edp_compare_alt_mode.

== Series Details == Series: drm/i915/dp: Fix intel_edp_compare_alt_mode. URL : https://patchwork.freedesktop.org/series/39841/ State : success == Summary == Series 39841v1 drm/i915/dp: Fix intel_edp_compare_alt_mode. https://patchwork.freedesktop.org/api/1.0/series/39841/revisions/1/mbox/

[Intel-gfx] [DIM PATCH 3/3] dim: loosen some drm-intel checkpatch rules

Set max line length to 100. I don't want to silence the LONG_LINE warning altogether, and I'd still prefer to keep lines under 80 characters, but I also don't want to see all the noise, and nor do I want to see silly code trying to arbitrarily squeeze under 80 when it doesn't make sense. 100 is a

[Intel-gfx] [DIM PATCH 1/3] dim: cleanup checkpatch_commit

Remove some old cruft. Pass checkpatch parameters via a variable. No functional changes. Cc: Arkadiusz Hiler Cc: Joonas Lahtinen Cc: Rodrigo Vivi Signed-off-by: Jani Nikula --- dim | 7

[Intel-gfx] [DIM PATCH 2/3] dim: add checkpatch profiles to allow different checkpatch options

To reduce noise on CI checkpatch reports, we want to silence some checkpatch warnings. Different branches may end up having different rules, and users may want to get unfiltered results, so introduce checkpatch profiles. Add some placeholder profiles to be filled later on. The idea is that CI

[Intel-gfx] [PATCH] drm/i915/pmu: avoid -Wmaybe-uninitialized warning

The conditional spinlock confuses gcc into thinking the 'flags' value might contain uninitialized data: drivers/gpu/drm/i915/i915_pmu.c: In function '__i915_pmu_event_read': arch/x86/include/asm/paravirt_types.h:573:3: error: 'flags' may be used uninitialized in this function

Re: [Intel-gfx] [PATCH v12 2/6] drm/i915: Implement dynamic GuC WOPCM offset and size calculation

Quoting Jackie Li (2018-03-02 02:16:42) > +/** > + * intel_guc_init_ggtt_pin_bias() - Initialize the GuC ggtt_pin_bias value. > + * @guc: intel_guc structure. > + * > + * This functional will calculate and initialize the ggtt_pin_bias value > based s/functional/function/ > + * on overall WOPCM

Re: [Intel-gfx] [PATCH] drm/i915/glk: Disable Guc and HuC on GLK

On Mon, Mar 12, 2018 at 03:34:57PM -0700, Rodrigo Vivi wrote: > From: Anusha Srivatsa > > commit 2afba81c7909ac259720c0d3e7616cf54d4a5368 upstream. > > Since the firmwares are not yet released to public repo, > disable them on Geminilake. > > v2: Remove the firmware

[Intel-gfx] [PATCH] drm/i915/dp: Fix intel_edp_compare_alt_mode.

On fi-cnl-y3 we have 2 modes that differ only by crtc_clock. This means that if we request the normal mode, we automatically get the downclocked mode. This can be seen during boot: [drm:drm_helper_probe_single_connector_modes] [CONNECTOR:101:eDP-1] probed modes :

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix intel_edp_compare_alt_mode.

Quoting Maarten Lankhorst (2018-03-13 09:28:55) > On fi-cnl-y3 we have 2 modes that differ only by crtc_clock. This means > that if we request the normal mode, we automatically get the downclocked > mode. > > This can be seen during boot: > [drm:drm_helper_probe_single_connector_modes]

[Intel-gfx] [PATCH] drm/i915: Split GPU commands definitions into separate header

We should not mix MMIO with MI_INSTR definitions. Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_reg.h | 263

Re: [Intel-gfx] [PATCH v12 1/6] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

Quoting Jackie Li (2018-03-02 02:16:41) > GuC related exported functions should start with "intel_guc_" prefix and > pass intel_guc as the first parameter since its GuC related. Current > guc_ggtt_offset() failed to follow this code convention and this is a > problem for future patches that needs

Re: [Intel-gfx] [DIM PATCH 2/3] dim: add checkpatch profiles to allow different checkpatch options

On Tue, Mar 13, 2018 at 01:30:09PM +0200, Jani Nikula wrote: > To reduce noise on CI checkpatch reports, we want to silence some > checkpatch warnings. Different branches may end up having different > rules, and users may want to get unfiltered results, so introduce > checkpatch profiles. Add some

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Warn against variable length arrays

On Tue, 13 Mar 2018, Chris Wilson wrote: > VLA are strongly discouraged in the kernel due to ambiguity they impose > on the limited stack space and security concerns over manipulating the > stack frame. Add -Wvla to our compiler flags so that CI rejects them. > >

[Intel-gfx] ✗ Fi.CI.IGT: warning for CNL port refactoring (rev3)

== Series Details == Series: CNL port refactoring (rev3) URL : https://patchwork.freedesktop.org/series/38334/ State : warning == Summary == Possible new issues: Test drv_suspend: Subgroup forcewake: pass -> SKIP (shard-snb) Known issues: Test

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Remove PSR active flag from debugfs

== Series Details == Series: drm/i915/psr: Remove PSR active flag from debugfs URL : https://patchwork.freedesktop.org/series/39829/ State : success == Summary == Known issues: Test gem_eio: Subgroup in-flight-contexts: incomplete -> PASS (shard-apl)

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove variable length arrays from sseu debugfs printers

Quoting Tvrtko Ursulin (2018-03-13 09:35:03) > > On 13/03/2018 00:40, Chris Wilson wrote: > > In order to enable -Wvla to prevent new variable length arrays being > > used in i915.ko, we first must remove the existing VLA. Inside > > i915_print_sseu_info(), VLA are used as the actual size of the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: Fix intel_edp_compare_alt_mode.

== Series Details == Series: drm/i915/dp: Fix intel_edp_compare_alt_mode. URL : https://patchwork.freedesktop.org/series/39841/ State : success == Summary == Known issues: Test gem_eio: Subgroup in-flight: pass -> INCOMPLETE (shard-apl) fdo#105341 Test

Re: [Intel-gfx] [PATCH] drm/i915: Split GPU commands definitions into separate header

Quoting Michal Wajdeczko (2018-03-13 11:21:21) > We should not mix MMIO with MI_INSTR definitions. > > Suggested-by: Chris Wilson > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson > --- > +#define

Re: [Intel-gfx] [DIM PATCH 3/3] dim: loosen some drm-intel checkpatch rules

On Tue, Mar 13, 2018 at 01:30:10PM +0200, Jani Nikula wrote: > Set max line length to 100. I don't want to silence the LONG_LINE > warning altogether, and I'd still prefer to keep lines under 80 > characters, but I also don't want to see all the noise, and nor do I > want to see silly code trying

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix intel_edp_compare_alt_mode.

Quoting Maarten Lankhorst (2018-03-13 09:28:55) > On fi-cnl-y3 we have 2 modes that differ only by crtc_clock. This means > that if we request the normal mode, we automatically get the downclocked > mode. > > This can be seen during boot: > [drm:drm_helper_probe_single_connector_modes]

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix intel_edp_compare_alt_mode.

Op 13-03-18 om 10:40 schreef Chris Wilson: > Quoting Maarten Lankhorst (2018-03-13 09:28:55) >> On fi-cnl-y3 we have 2 modes that differ only by crtc_clock. This means >> that if we request the normal mode, we automatically get the downclocked >> mode. >> >> This can be seen during boot: >>

[Intel-gfx] [PATCH] drm/i915: Use sseu size for determining eu_regs[]

eu_regs[] is written 2*max_slices times (like s_reg[]) but oddly read 2*max_slices + max_subslices/2 times. Allocate the array large enough for the writes to avoid overwriting our stack and worry about the logic later. Fixes: 7aa0b14ede64 ("drm/i915: Remove variable length arrays from sseu

Re: [Intel-gfx] i915 vs checkpatch

On Mon, 05 Mar 2018, Arkadiusz Hiler wrote: > On Mon, Mar 05, 2018 at 01:10:21PM +0200, Jani Nikula wrote: >> On Mon, 05 Mar 2018, Daniel Vetter wrote: >> > I'd recommend not making checkpatch ever fail CI, but at most warning. >> >> Agreed. But we

Re: [Intel-gfx] [RFC PATCH i-g-t 3/3] tests: Add vc4 test suite

On Mon, Mar 05, 2018 at 03:21:29PM +0100, Maxime Ripard wrote: > Add some various test suites relevant for the vc4 drm driver. > > Signed-off-by: Maxime Ripard > --- > tests/vc4_ci/vc4-chamelium-fast.testlist | 4 > tests/vc4_ci/vc4-chamelium.testlist | 9

Re: [Intel-gfx] [PATCH v12 3/6] drm/i915: Add support to return CNL specific reserved WOPCM size

Quoting Jackie Li (2018-03-02 02:16:43) > CNL has its specific reserved GuC WOPCM size for RC6 and other hardware > contexts. > > This patch updates the code to return CNL specific reserved GuC WOPCM size > for RC6 and other hardware contexts so that the GuC WOPCM size can be > calculated

Re: [Intel-gfx] [PATCH igt] igt: Add gem_ctx_freq to exercise requesting freq on a ctx

On 3/10/2018 3:05 AM, Chris Wilson wrote: Exercise some new API that allows applications to request that individual contexts are executed within a desired frequency range. v2: Split single/continuous set_freq subtests v3: Do an up/down ramp for individual freq request, check nothing changes

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: avoid -Wmaybe-uninitialized warning

== Series Details == Series: drm/i915/pmu: avoid -Wmaybe-uninitialized warning URL : https://patchwork.freedesktop.org/series/39857/ State : success == Summary == Series 39857v1 drm/i915/pmu: avoid -Wmaybe-uninitialized warning

Re: [Intel-gfx] [PATCH] drm/i915: Reword warning for missing cases

On Tue, Mar 13, 2018 at 12:17:13AM +, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-03-13 00:03:12) > > In some places we end up converting switch statements to a series of > > if/else, particularly when introducing helper functions to handle a > > group of cases. It's tempting to either

Re: [Intel-gfx] [PATCH] drm/i915: Reword warning for missing cases

Quoting Ville Syrjälä (2018-03-13 13:01:42) > On Tue, Mar 13, 2018 at 12:17:13AM +, Chris Wilson wrote: > > Quoting Lucas De Marchi (2018-03-13 00:03:12) > > > In some places we end up converting switch statements to a series of > > > if/else, particularly when introducing helper functions to

Re: [Intel-gfx] [PATCH v12 4/6] drm/i915: Add HuC firmware size related restriction for Gen9 and CNL A0

Quoting Jackie Li (2018-03-02 02:16:44) > On CNL A0 and Gen9, there's a hardware restriction that requires the > available GuC WOPCM size to be larger than or equal to HuC firmware size. > > This patch adds new verification code to ensure the available GuC WOPCM > size to be larger than or equal

[Intel-gfx] [PATCH igt 1/3] igt/gem_eio: Exercise set-wedging against request submission

Build up a large stockpile of requests, ~500,000, and feed them into the system at 20KHz whilst simultaneously triggering set-wedged in order to try and race i915_gem_set_wedged() against the engine->submit_request() callback. Signed-off-by: Chris Wilson Cc: Mika

[Intel-gfx] [PATCH igt 2/3] igt/gem_exec_fence: Exercise merging fences

Execute the same batch on each engine and check that the composite fence across all engines completes only after the batch is completed on every engine. Signed-off-by: Chris Wilson --- tests/gem_exec_fence.c | 127 + 1

[Intel-gfx] [PATCH igt 3/3] igt/gem_exec_schedule: Exercise "deep" preemption

In investigating the issue with having to force preemption within the executing ELSP[], we want to trigger preemption between all elements of that array. To that end, we issue a series of requests with different priorities to fill the in-flight ELSP[] and then demand preemption into the middle of

Re: [Intel-gfx] [PATCH] drm/i915/pmu: avoid -Wmaybe-uninitialized warning

Quoting Arnd Bergmann (2018-03-13 12:08:29) > The conditional spinlock confuses gcc into thinking the 'flags' value > might contain uninitialized data: > > drivers/gpu/drm/i915/i915_pmu.c: In function '__i915_pmu_event_read': > arch/x86/include/asm/paravirt_types.h:573:3: error: 'flags' may be

[Intel-gfx] [PATCH v2] drm/i915: Split GPU commands definitions into separate header

We should not mix MMIO with MI_INSTR definitions. v2: sanitize comment, change include order (Chris) Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Reviewed-by: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915/pmu: avoid -Wmaybe-uninitialized warning

On Tue, Mar 13, 2018 at 1:31 PM, Chris Wilson wrote: > Quoting Arnd Bergmann (2018-03-13 12:08:29) >> The conditional spinlock confuses gcc into thinking the 'flags' value >> might contain uninitialized data: >> >> drivers/gpu/drm/i915/i915_pmu.c: In function

Re: [Intel-gfx] [PATCH] drm/i915: Reword warning for missing cases

On Tue, Mar 13, 2018 at 01:06:49PM +, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-03-13 13:01:42) > > On Tue, Mar 13, 2018 at 12:17:13AM +, Chris Wilson wrote: > > > Quoting Lucas De Marchi (2018-03-13 00:03:12) > > > > In some places we end up converting switch statements to a

[Intel-gfx] [PATCH v3 2/4] drm/i915/uc: Use helper functions to detect fw load status

We don't have to check load status values. Signed-off-by: Michal Wajdeczko Cc: Sagar Arun Kamble Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_huc.c | 2 +- drivers/gpu/drm/i915/intel_uc.c | 4 ++-- 2 files

[Intel-gfx] [PATCH v3 1/4] drm/i915/uc: Use correct error code for GuC initialization failure

Since commit 6ca9a2beb54a ("drm/i915: Unwind i915_gem_init() failure") we believed that we correctly handle all errors encountered during GuC initialization, including special one that indicates request to run driver with disabled GPU submission (-EIO). Unfortunately since commit 121981fafe69

[Intel-gfx] [PATCH v3 4/4] HAX: Enable GuC for CI

v2: except running with HYPERVISOR Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_uc.c| 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h

[Intel-gfx] [PATCH igt] igt: Add gem_ctx_freq to exercise requesting freq on a ctx

Exercise some new API that allows applications to request that individual contexts are executed within a desired frequency range. v2: Split single/continuous set_freq subtests v3: Do an up/down ramp for individual freq request, check nothing changes after each invalid request v4: Check the

Re: [Intel-gfx] [PATCH v12 5/6] drm/i915/guc: Check the locking status of GuC WOPCM registers

Quoting Jackie Li (2018-03-02 02:16:45) > +++ b/drivers/gpu/drm/i915/intel_wopcm.c > @@ -219,3 +219,67 @@ int intel_wopcm_init(struct intel_wopcm *wopcm) > > return 0; > } > + > +static inline int write_and_verify(struct drm_i915_private *dev_priv, > +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use sseu size for determining eu_regs[]

== Series Details == Series: drm/i915: Use sseu size for determining eu_regs[] URL : https://patchwork.freedesktop.org/series/39853/ State : success == Summary == Series 39853v1 drm/i915: Use sseu size for determining eu_regs[]

Re: [Intel-gfx] [PATCH igt] igt: Add gem_ctx_freq to exercise requesting freq on a ctx

Quoting Sagar Arun Kamble (2018-03-13 12:38:04) > > > On 3/10/2018 3:05 AM, Chris Wilson wrote: > > +static void single(int fd, const struct intel_execution_engine *e) > > +{ > > +#define N_STEPS 10 > > + const unsigned int engine = e->exec_id | e->flags; > > + uint32_t ctx =

[Intel-gfx] [PATCH v3 3/4] drm/i915/uc: Trivial s/dev_priv/i915 in intel_uc.c

Some functions already use i915 name instead of dev_priv. Let's rename this param in all remaining functions, except those that still use legacy macros. Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_uc.c | 122

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/pmu: avoid -Wmaybe-uninitialized warning

== Series Details == Series: drm/i915/pmu: avoid -Wmaybe-uninitialized warning URL : https://patchwork.freedesktop.org/series/39857/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/pmu: avoid -Wmaybe-uninitialized warning -O:drivers/gpu/drm/i915/i915_pmu.c:442:47:

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use sseu size for determining eu_regs[]

Quoting Patchwork (2018-03-13 12:25:40) > == Series Details == > > Series: drm/i915: Use sseu size for determining eu_regs[] > URL : https://patchwork.freedesktop.org/series/39853/ > State : success > > Blacklisted hosts: > fi-cnl-drrs total:288 pass:257 dwarn:3 dfail:0 fail:0

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/pmu: avoid -Wmaybe-uninitialized warning

On Tue, Mar 13, 2018 at 1:29 PM, Patchwork wrote: > == Series Details == > > Series: drm/i915/pmu: avoid -Wmaybe-uninitialized warning > URL : https://patchwork.freedesktop.org/series/39857/ > State : warning > > == Summary == > > $ dim sparse origin/drm-tip >

[Intel-gfx] [PATCH] drm/i915/dp: Fix alt mode handling.

On fi-cnl-y3 we have 2 modes that differ only by crtc_clock. This means that if we request the normal mode, we automatically get the downclocked mode. This can be seen during boot: [drm:drm_helper_probe_single_connector_modes] [CONNECTOR:101:eDP-1] probed modes :

Re: [Intel-gfx] [PATCH] drm/i915: Use sseu size for determining eu_regs[]

Reviewed-by: Lionel Landwerlin On 13/03/18 11:31, Chris Wilson wrote: eu_regs[] is written 2*max_slices times (like s_reg[]) but oddly read 2*max_slices + max_subslices/2 times. Allocate the array large enough for the writes to avoid overwriting our stack and

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix intel_edp_compare_alt_mode.

On Tue, Mar 13, 2018 at 10:28:55AM +0100, Maarten Lankhorst wrote: > On fi-cnl-y3 we have 2 modes that differ only by crtc_clock. This means > that if we request the normal mode, we automatically get the downclocked > mode. > > This can be seen during boot: >

[Intel-gfx] [PATCH igt] igt: Add gem_ctx_freq to exercise requesting freq on a ctx

Exercise some new API that allows applications to request that individual contexts are executed within a desired frequency range. v2: Split single/continuous set_freq subtests v3: Do an up/down ramp for individual freq request, check nothing changes after each invalid request v4: Check the

Re: [Intel-gfx] [PATCH v2] drm/i915: Show GEM_TRACE when detecting a failed GPU idle

Quoting Chris Wilson (2018-03-09 12:11:14) > If we timeout waiting for the GPU to idle, something went seriously > wrong. We currently dump the engine state, but we can also dump the > ftrace buffer showing our last operations (when available). > > In passing, note that since commit 559e040f1f08

[Intel-gfx] [PATCH] drm/i915/guc: Update syntax of GuC log functions

We moved GuC log related data and code to separate files and definition but we didn't change functions syntax to follow object-verb pattern. Let's fix that before we continue with next round of code refactoring. Signed-off-by: Michal Wajdeczko Cc: Michal Winiarski

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use sseu size for determining eu_regs[]

== Series Details == Series: drm/i915: Use sseu size for determining eu_regs[] URL : https://patchwork.freedesktop.org/series/39853/ State : success == Summary == Known issues: Test gem_eio: Subgroup in-flight-contexts: pass -> INCOMPLETE (shard-apl)

[Intel-gfx] [PATCH v2 1/3] drm: Add the optional .fb_modifier() hook

From: Ville Syrjälä To make it possible for the core to check the fb pixel format and modifier, we need to first ask the driver to deduce the modifier when the request does not explicitly specify one. Add a new .fb_modifier() hook for that purpose and convert i915

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add the optional .fb_modifier() hook

On 2018-03-13 03:28 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > To make it possible for the core to check the fb pixel format and > modifier, we need to first ask the driver to deduce the modifier > when the request does not explicitly specify one. > > Add

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/guc: Update syntax of GuC log functions

== Series Details == Series: drm/i915/guc: Update syntax of GuC log functions URL : https://patchwork.freedesktop.org/series/39859/ State : warning == Summary == Series 39859v1 drm/i915/guc: Update syntax of GuC log functions

Re: [Intel-gfx] [RFC PATCH i-g-t 2/3] tests/chamelium: Add test case for plane formats

Hi Eric, On Mon, Mar 12, 2018 at 12:02:26PM -0700, Eric Anholt wrote: > > +static pixman_image_t *convert_frame_format(pixman_image_t *src, > > + int format) > > +{ > > + pixman_image_t *converted; > > + unsigned int w = pixman_image_get_width(src); > > +

Re: [Intel-gfx] [DIM PATCH 2/3] dim: add checkpatch profiles to allow different checkpatch options

On Tue, 13 Mar 2018, Daniel Vetter wrote: > On Tue, Mar 13, 2018 at 01:30:09PM +0200, Jani Nikula wrote: >> To reduce noise on CI checkpatch reports, we want to silence some >> checkpatch warnings. Different branches may end up having different >> rules, and users may want to get

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add the optional .fb_modifier() hook

On Tue, Mar 13, 2018 at 03:38:38PM +0100, Michel Dänzer wrote: > On 2018-03-13 03:28 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > To make it possible for the core to check the fb pixel format and > > modifier, we need to first ask the driver to deduce

[Intel-gfx] [PATCH 4.15 010/146] drm/i915/audio: fix check for av_enc_map overflow

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Jani Nikula commit 72a6d72c2cd03bba7b70117b63dea83d2de88057 upstream. Turns out -1 >= ARRAY_SIZE() is always true. Move the bounds check where we know pipe >= 0 and

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v3,1/4] drm/i915/uc: Use correct error code for GuC initialization failure

== Series Details == Series: series starting with [v3,1/4] drm/i915/uc: Use correct error code for GuC initialization failure URL : https://patchwork.freedesktop.org/series/39867/ State : warning == Summary == Series 39867v1 series starting with [v3,1/4] drm/i915/uc: Use correct error code

[Intel-gfx] [PATCH i-g-t] HACK: enable the chamelium HDMI-CRC-multiple test

It seems like there's a regression (at least using the vc4 DRM display driver) when doing multiple calls to tests/kms_chamelium.c enable_output after a single prepare_output. Indeed, the DRM atomic_state doesn't seem to be full on the second run, especially for the CRTC that doesn't have any

[Intel-gfx] [PATCH 1/3] drm: Nuke the useless 'ret' variable from drm_mode_convert_umode()

From: Ville Syrjälä No need to store the return value in a variable since we don't have to do any unwinding. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 15 --- 1 file changed, 4 insertions(+), 11

[Intel-gfx] [PATCH 3/3] drm: Store the calculated vrefresh in the user mode

From: Ville Syrjälä Ignore the vrefresh in the mode the user passed in and instead calculate the value based on the actual timings. This way we can actually trust mode->vrefresh to some degree. Or should we compare the user's idea of vrefresh with the one we get

[Intel-gfx] [PATCH 2/3] drm: Make drm_mode_vrefresh() a bit more accurate

From: Ville Syrjälä Do the refresh rate calculation with a single division. This gives us slightly more accurate results, especially for interlaced since we don't just double the final truncated result. We do lose one bit compared to the old way, so with an

Re: [Intel-gfx] [RFC v3 09/12] drm: Add API for in-kernel clients

On Mon, Mar 12, 2018 at 09:21:40PM +0100, Noralf Tr??nnes wrote: > > Den 12.03.2018 17.51, skrev Daniel Vetter: > > On Thu, Mar 08, 2018 at 06:12:11PM +0100, Noralf Tr??nnes wrote: > > > Den 06.03.2018 09.56, skrev Daniel Vetter: > > > > On Thu, Feb 22, 2018 at 09:06:50PM +0100, Noralf Tr??nnes

[Intel-gfx] [PATCH 4.14 057/140] drm/i915/perf: fix perf stream opening lock

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Lionel Landwerlin commit f616f2830c1ed79245cfeca900f7e8a3b3c08c06 upstream. We're seeing on CI that some contexts don't have the programmed OA period timer that

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix alt mode handling.

Op 13-03-18 om 15:27 schreef Ville Syrjälä: > On Tue, Mar 13, 2018 at 02:52:35PM +0100, Maarten Lankhorst wrote: >> On fi-cnl-y3 we have 2 modes that differ only by crtc_clock. This means >> that if we request the normal mode, we automatically get the downclocked >> mode. >> >> This can be seen

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add the optional .fb_modifier() hook

On 2018-03-13 04:12 PM, Ville Syrjälä wrote: > On Tue, Mar 13, 2018 at 03:38:38PM +0100, Michel Dänzer wrote: >> On 2018-03-13 03:28 PM, Ville Syrjala wrote: >>> From: Ville Syrjälä >>> >>> To make it possible for the core to check the fb pixel format and >>>

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add the optional .fb_modifier() hook

On 2018-03-13 04:20 PM, Daniel Vetter wrote: > On Tue, Mar 13, 2018 at 03:38:38PM +0100, Michel Dänzer wrote: >> On 2018-03-13 03:28 PM, Ville Syrjala wrote: >>> From: Ville Syrjälä >>> >>> To make it possible for the core to check the fb pixel format and >>>

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add the optional .fb_modifier() hook

On Tue, Mar 13, 2018 at 04:35:02PM +0100, Michel Dänzer wrote: > On 2018-03-13 04:20 PM, Daniel Vetter wrote: > > On Tue, Mar 13, 2018 at 03:38:38PM +0100, Michel Dänzer wrote: > >> On 2018-03-13 03:28 PM, Ville Syrjala wrote: > >>> From: Ville Syrjälä > >>> > >>>

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix alt mode handling.

On Tue, Mar 13, 2018 at 03:37:05PM +0100, Maarten Lankhorst wrote: > Op 13-03-18 om 15:27 schreef Ville Syrjälä: > > On Tue, Mar 13, 2018 at 02:52:35PM +0100, Maarten Lankhorst wrote: > >> On fi-cnl-y3 we have 2 modes that differ only by crtc_clock. This means > >> that if we request the normal

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix alt mode handling.

On Tue, Mar 13, 2018 at 02:52:35PM +0100, Maarten Lankhorst wrote: > On fi-cnl-y3 we have 2 modes that differ only by crtc_clock. This means > that if we request the normal mode, we automatically get the downclocked > mode. > > This can be seen during boot: >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: avoid -Wmaybe-uninitialized warning

== Series Details == Series: drm/i915/pmu: avoid -Wmaybe-uninitialized warning URL : https://patchwork.freedesktop.org/series/39857/ State : success == Summary == Known issues: Test drv_selftest: Subgroup live_gtt: pass -> INCOMPLETE (shard-apl) fdo#103927

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add the optional .fb_modifier() hook

On Tue, Mar 13, 2018 at 03:38:38PM +0100, Michel Dänzer wrote: > On 2018-03-13 03:28 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > To make it possible for the core to check the fb pixel format and > > modifier, we need to first ask the driver to deduce

Re: [Intel-gfx] [RFC PATCH i-g-t 3/3] tests: Add vc4 test suite

Hi, On Tue, Mar 13, 2018 at 12:42:02PM +0200, Petri Latvala wrote: > On Mon, Mar 05, 2018 at 03:21:29PM +0100, Maxime Ripard wrote: > > Add some various test suites relevant for the vc4 drm driver. > > > > Signed-off-by: Maxime Ripard > > --- > >

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/dp: Fix intel_edp_compare_alt_mode. (rev2)

== Series Details == Series: drm/i915/dp: Fix intel_edp_compare_alt_mode. (rev2) URL : https://patchwork.freedesktop.org/series/39841/ State : warning == Summary == Series 39841v2 drm/i915/dp: Fix intel_edp_compare_alt_mode.

[Intel-gfx] [PATCH 4.15 016/146] drm/i915/perf: fix perf stream opening lock

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Lionel Landwerlin commit f616f2830c1ed79245cfeca900f7e8a3b3c08c06 upstream. We're seeing on CI that some contexts don't have the programmed OA period timer that

Re: [Intel-gfx] [PATCH 1/3] drm: Nuke the useless 'ret' variable from drm_mode_convert_umode()

On Tue, Mar 13, 2018 at 05:07:57PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > No need to store the return value in a variable since we don't have to > do any unwinding. > > Signed-off-by: Ville Syrjälä Reviewed-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm: Nuke the useless 'ret' variable from drm_mode_convert_umode()

== Series Details == Series: series starting with [1/3] drm: Nuke the useless 'ret' variable from drm_mode_convert_umode() URL : https://patchwork.freedesktop.org/series/39875/ State : success == Summary == Series 39875v1 series starting with [1/3] drm: Nuke the useless 'ret' variable from

[Intel-gfx] [PATCH] [v2] drm/i915/pmu: avoid -Wmaybe-uninitialized warning

The conditional spinlock confuses gcc into thinking the 'flags' value might contain uninitialized data: drivers/gpu/drm/i915/i915_pmu.c: In function '__i915_pmu_event_read': arch/x86/include/asm/paravirt_types.h:573:3: error: 'flags' may be used uninitialized in this function

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/pmu: avoid -Wmaybe-uninitialized warning (rev2)

== Series Details == Series: drm/i915/pmu: avoid -Wmaybe-uninitialized warning (rev2) URL : https://patchwork.freedesktop.org/series/39857/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/pmu: avoid -Wmaybe-uninitialized warning

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/pmu: avoid -Wmaybe-uninitialized warning (rev2)

== Series Details == Series: drm/i915/pmu: avoid -Wmaybe-uninitialized warning (rev2) URL : https://patchwork.freedesktop.org/series/39857/ State : warning == Summary == Series 39857v2 drm/i915/pmu: avoid -Wmaybe-uninitialized warning

Re: [Intel-gfx] [PATCH] [v2] drm/i915/pmu: avoid -Wmaybe-uninitialized warning

Quoting Arnd Bergmann (2018-03-13 16:19:31) > The conditional spinlock confuses gcc into thinking the 'flags' value > might contain uninitialized data: > > drivers/gpu/drm/i915/i915_pmu.c: In function '__i915_pmu_event_read': > arch/x86/include/asm/paravirt_types.h:573:3: error: 'flags' may be

Re: [Intel-gfx] [PATCH v12 5/6] drm/i915/guc: Check the locking status of GuC WOPCM registers

Failed to receive this mail for 5/6 patch (couldn't find it in my mailbox). So pasted the comments from patchwork. Quoting Jackie Li (2018-03-02 02:16:45) > +++ b/drivers/gpu/drm/i915/intel_wopcm.c > @@ -219,3 +219,67 @@ int intel_wopcm_init(struct intel_wopcm *wopcm) > > return 0; >

  1   2   >