Re: [Intel-gfx] [PATCH 7/7] drm/i915: Stop parking the signaler around reset

2018-05-16 Thread Tvrtko Ursulin
On 16/05/2018 10:25, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-05-16 10:15:34) On 16/05/2018 07:47, Chris Wilson wrote: We cannot call kthread_park() from softirq context, so let's avoid it entirely during the reset. We wanted to suspend the signaler so that it would not mark a

[Intel-gfx] [PATCH v2] drm/i915: Stop parking the signaler around reset

2018-05-16 Thread Chris Wilson
We cannot call kthread_park() from softirq context, so let's avoid it entirely during the reset. We wanted to suspend the signaler so that it would not mark a request as complete at the same time as we marked it as being in error. Instead of parking the signaling, stop the engine from advancing so

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-16 Thread Jani Nikula
On Wed, 16 May 2018, vathsala nagaraju wrote: > On Wednesday 16 May 2018 04:33 AM, Dhinakaran Pandiyan wrote: >> On Mon, 2018-05-14 at 09:02 +0530, vathsala nagaraju wrote: >>> From: Vathsala Nagaraju >>> >>> For psr block #9, the vbt

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Remove tasklet flush before disable URL : https://patchwork.freedesktop.org/series/43235/ State : warning == Summary == $ dim checkpatch origin/drm-tip 823d4421c732 drm/i915: Remove tasklet flush before disable 97032fea8040

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-16 Thread Neil Armstrong
Hi Ville, On 15/05/2018 17:35, Ville Syrjälä wrote: > On Tue, May 15, 2018 at 04:42:19PM +0200, Neil Armstrong wrote: >> This patchs adds the cec_notifier feature to the intel_hdmi part >> of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate >> between each HDMI ports. >>

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915/edp: Allow alternate fixed mode for eDP if available."

2018-05-16 Thread Patchwork
== Series Details == Series: Revert "drm/i915/edp: Allow alternate fixed mode for eDP if available." URL : https://patchwork.freedesktop.org/series/43239/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4191 -> Patchwork_9011 = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] [PATCH 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-16 Thread Hans Verkuil
On 05/15/18 14:46, Neil Armstrong wrote: > This patchs adds the cec_notifier feature to the intel_hdmi part > of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate > between each HDMI ports. > The changes will allow the i915 HDMI code to notify EDID and HPD changes > to an

Re: [Intel-gfx] [PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-16 Thread Hans Verkuil
Some small comments below: On 05/15/18 14:47, Neil Armstrong wrote: > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the > driver for such feature of the Embedded Controller. > > This driver is part of the cros-ec MFD and will be add as a sub-device when > the feature bit

Re: [Intel-gfx] [PATCH 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-16 Thread Hans Verkuil
Hi Neil, Two small comments below: On 05/15/18 14:46, Neil Armstrong wrote: > In non device-tree world, we can need to get the notifier by the driver > name directly and eventually defer probe if not yet created. > > This patch adds a variant of the get function by using the device name >

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Chris Wilson
Quoting Mika Kuoppala (2018-05-16 09:39:14) > Chris Wilson writes: > > > The idea was to try and let the existing tasklet run to completion > > before we began the reset, but it involves a racy check against anything > > else that tries to run the tasklet. Rather than

[Intel-gfx] [PATCH] drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2.

2018-05-16 Thread Maarten Lankhorst
Normally this is called on a modeset, but the call is missing when we inherit the mode from the BIOS, so make sure it's called somewhere in hardware readout. Changes since v1: - Unconditionally call intel_opregion_notify_encoder. (Ville) Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Stop parking the signaler around reset

2018-05-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-16 10:49:34) > > On 16/05/2018 10:25, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-05-16 10:15:34) > >> > >> On 16/05/2018 07:47, Chris Wilson wrote: > >>> We cannot call kthread_park() from softirq context, so let's avoid it > >>> entirely during the

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-05-16 09:39:14) >> Chris Wilson writes: >> >> > The idea was to try and let the existing tasklet run to completion >> > before we began the reset, but it involves a racy check against

Re: [Intel-gfx] [PATCH v2] drm/i915: Shrink search list for active timelines

2018-05-16 Thread Chris Wilson
Quoting Chris Wilson (2018-05-15 15:31:49) > When switching to the kernel context, we force the switch to occur after > all currently active requests (so that we know the GPU won't switch > immediately away and the kernel context remains current as we work). To > do so we have to inspect all the

Re: [Intel-gfx] [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-16 Thread Neil Armstrong
Hi Hans, On 15/05/2018 17:28, Hans Verkuil wrote: > On 05/15/2018 04:42 PM, Neil Armstrong wrote: >> The EC can expose a CEC bus, this patch adds the CEC related definitions >> needed by the cros-ec-cec driver. >> Having a 16 byte mkbp event size makes it possible to send CEC >> messages from the

Re: [Intel-gfx] [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-16 Thread Neil Armstrong
Hi Enric, On 15/05/2018 18:40, Enric Balletbo Serra wrote: > Hi Neil, > > I suspect that this patch will conflict with some patches that will be > queued for 4.18 that also introduces new devices, well, for now I > don't see these merged in the Lee's tree. Indeed, I found your patches, I'll

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Stop parking the signaler around reset

2018-05-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-16 10:15:34) > > On 16/05/2018 07:47, Chris Wilson wrote: > > We cannot call kthread_park() from softirq context, so let's avoid it > > entirely during the reset. We wanted to suspend the signaler so that it > > would not mark a request as complete at the same time

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-16 Thread Neil Armstrong
On 16/05/2018 09:31, Neil Armstrong wrote: > Hi Ville, > > On 15/05/2018 17:35, Ville Syrjälä wrote: >> On Tue, May 15, 2018 at 04:42:19PM +0200, Neil Armstrong wrote: >>> This patchs adds the cec_notifier feature to the intel_hdmi part >>> of the i915 DRM driver. It uses the HDMI DRM connector

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-16 Thread Jani Nikula
On Wed, 16 May 2018, vathsala nagaraju wrote: > On Wednesday 16 May 2018 04:33 AM, Dhinakaran Pandiyan wrote: >> On Mon, 2018-05-14 at 09:02 +0530, vathsala nagaraju wrote: >>> From: Vathsala Nagaraju >>> >>> For psr block #9, the vbt

[Intel-gfx] [PATCH] doc: how to become a drm-intel committer

2018-05-16 Thread Jani Nikula
Until now, the drm-intel commit access have been handed out ad hoc, without transparency, consistency, or fairness. With pressure to add more committers, this is no longer tenable, if it ever was. Document the requirements and expectations around becoming a drm-intel committer. The drm-intel

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Stop parking the signaler around reset

2018-05-16 Thread Tvrtko Ursulin
On 16/05/2018 07:47, Chris Wilson wrote: We cannot call kthread_park() from softirq context, so let's avoid it entirely during the reset. We wanted to suspend the signaler so that it would not mark a request as complete at the same time as we marked it as being in error. Instead of parking the

[Intel-gfx] [PATCH] Revert "drm/i915/edp: Allow alternate fixed mode for eDP if available."

2018-05-16 Thread Jani Nikula
This reverts commit dc911f5bd8aacfcf8aabd5c26c88e04c837a938e. Per the report, no matter what display mode you select with xrandr, the i915 driver will always select the alternate fixed mode. For the reporter this means that the display will always run at 40Hz which is quite annoying. This may be

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Only sync tasklets once for recursive reset preparation

2018-05-16 Thread Mika Kuoppala
Chris Wilson writes: > When setting up reset, we may need to recursively prepare an engine. In > which case we should only synchronously flush the tasklets on the outer > most call, the inner calls will then be inside an atomic section where > the tasklet will never be

Re: [Intel-gfx] [PATCH 6/7] drm/i915/execlists: Flush pending preemption events during reset

2018-05-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-16 15:24:33) > > + /* > > + * The last active request can then be no later than the last request > > + * now in ELSP[0]. So search backwards from there, so that if the GPU > > + * has advanced beyond the last CSB update, it will be pardoned. > > +

[Intel-gfx] [CI 3/4] drm/i915/execlists: Refactor out complete_preempt_context()

2018-05-16 Thread Chris Wilson
As a complement to inject_preempt_context(), follow up with the function to handle its completion. This will be useful should we wish to extend the duties of the preempt-context for execlists. v2: And do the same for the guc. Signed-off-by: Chris Wilson Cc: Jeff McGee

[Intel-gfx] [CI 1/4] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Chris Wilson
The idea was to try and let the existing tasklet run to completion before we began the reset, but it involves a racy check against anything else that tries to run the tasklet. Rather than acknowledge and ignore the race, let it be and don't try and be too clever. The tasklet will resume execution

[Intel-gfx] [CI 2/4] drm/i915: Only sync tasklets once for recursive reset preparation

2018-05-16 Thread Chris Wilson
When setting up reset, we may need to recursively prepare an engine. In which case we should only synchronously flush the tasklets on the outer most call, the inner calls will then be inside an atomic section where the tasklet will never be run (and so the sync will never complete).

[Intel-gfx] [CI 4/4] drm/i915: Split execlists/guc reset preparations

2018-05-16 Thread Chris Wilson
In the next patch, we will make the execlists reset prepare callback take into account preemption by flushing the context-switch handler. This is not applicable to the GuC submission backend, so split the two into their own backend callbacks. Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 7/7] drm/i915: Stop parking the signaler around reset

2018-05-16 Thread Chris Wilson
We cannot call kthread_park() from softirq context, so let's avoid it entirely during the reset. We wanted to suspend the signaler so that it would not mark a request as complete at the same time as we marked it as being in error. Instead of parking the signaling, stop the engine from advancing so

[Intel-gfx] [PATCH 3/7] drm/i915/execlists: Refactor out complete_preempt_context()

2018-05-16 Thread Chris Wilson
As a complement to inject_preempt_context(), follow up with the function to handle its completion. This will be useful should we wish to extend the duties of the preempt-context for execlists. v2: And do the same for the guc. Signed-off-by: Chris Wilson Cc: Jeff McGee

[Intel-gfx] [PATCH 6/7] drm/i915/execlists: Flush pending preemption events during reset

2018-05-16 Thread Chris Wilson
Catch up with the inflight CSB events, after disabling the tasklet before deciding which request was truly guilty of hanging the GPU. Signed-off-by: Chris Wilson Cc: Michał Winiarski CC: Michel Thierry Cc: Jeff

[Intel-gfx] [PATCH 4/7] drm/i915: Split execlists/guc reset preparations

2018-05-16 Thread Chris Wilson
In the next patch, we will make the execlists reset prepare callback take into account preemption by flushing the context-switch handler. This is not applicable to the GuC submission backend, so split the two into their own backend callbacks. Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 5/7] drm/i915/execlists: Split out CSB processing

2018-05-16 Thread Chris Wilson
Pull the CSB event processing into its own routine so that we can reuse it during reset to flush any missed interrupts/events. Signed-off-by: Chris Wilson Cc: Michał Winiarski CC: Michel Thierry Cc: Jeff McGee

[Intel-gfx] [PATCH 1/7] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Chris Wilson
The idea was to try and let the existing tasklet run to completion before we began the reset, but it involves a racy check against anything else that tries to run the tasklet. Rather than acknowledge and ignore the race, let it be and don't try and be too clever. The tasklet will resume execution

[Intel-gfx] [PATCH 2/7] drm/i915: Only sync tasklets once for recursive reset preparation

2018-05-16 Thread Chris Wilson
When setting up reset, we may need to recursively prepare an engine. In which case we should only synchronously flush the tasklets on the outer most call, the inner calls will then be inside an atomic section where the tasklet will never be run (and so the sync will never complete).

Re: [Intel-gfx] [PATCH v3 07/40] linux/mei: Header for mei_hdcp driver interface

2018-05-16 Thread Ramalingam C
On Wednesday 09 May 2018 03:38 PM, Shankar, Uma wrote: -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Ramalingam C Sent: Tuesday, April 3, 2018 7:27 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH v5 7/7] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-05-16 Thread Lionel Landwerlin
On 16/05/18 16:40, Tvrtko Ursulin wrote: On 15/05/2018 10:05, Tvrtko Ursulin wrote: On 14/05/2018 16:56, Lionel Landwerlin wrote: From: Chris Wilson We want to allow userspace to reconfigure the subslice configuration for its own use case. To do so, we expose a

Re: [Intel-gfx] [PATCH v3 14/40] misc/mei/hdcp: Prepare Session Key

2018-05-16 Thread Ramalingam C
On Wednesday 09 May 2018 04:29 PM, Shankar, Uma wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Ramalingam C Sent: Tuesday, April 3, 2018 7:27 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Only sync tasklets once for recursive reset preparation

2018-05-16 Thread Chris Wilson
Quoting Mika Kuoppala (2018-05-16 15:24:56) > Chris Wilson writes: > > > When setting up reset, we may need to recursively prepare an engine. In > > which case we should only synchronously flush the tasklets on the outer > > most call, the inner calls will then be

[Intel-gfx] [CI 5/5] drm/i915: Split execlists/guc reset preparations

2018-05-16 Thread Chris Wilson
In the next patch, we will make the execlists reset prepare callback take into account preemption by flushing the context-switch handler. This is not applicable to the GuC submission backend, so split the two into their own backend callbacks. Signed-off-by: Chris Wilson

[Intel-gfx] [CI 1/5] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Chris Wilson
The idea was to try and let the existing tasklet run to completion before we began the reset, but it involves a racy check against anything else that tries to run the tasklet. Rather than acknowledge and ignore the race, let it be and don't try and be too clever. The tasklet will resume execution

[Intel-gfx] [CI 4/5] drm/i915: Move engine reset prepare/finish to backends

2018-05-16 Thread Chris Wilson
In preparation to more carefully handling incomplete preemption during reset by execlists, we move the existing code wholesale to the backends under a couple of new reset vfuncs. Signed-off-by: Chris Wilson Cc: Michał Winiarski CC: Michel

[Intel-gfx] [CI 3/5] drm/i915/execlists: Refactor out complete_preempt_context()

2018-05-16 Thread Chris Wilson
As a complement to inject_preempt_context(), follow up with the function to handle its completion. This will be useful should we wish to extend the duties of the preempt-context for execlists. v2: And do the same for the guc. Signed-off-by: Chris Wilson Cc: Jeff McGee

[Intel-gfx] [CI 2/5] drm/i915: Only sync tasklets once for recursive reset preparation

2018-05-16 Thread Chris Wilson
When setting up reset, we may need to recursively prepare an engine. In which case we should only synchronously flush the tasklets on the outer most call, the inner calls will then be inside an atomic section where the tasklet will never be run (and so the sync will never complete).

Re: [Intel-gfx] [PATCH 6/7] drm/i915/execlists: Flush pending preemption events during reset

2018-05-16 Thread Tvrtko Ursulin
On 16/05/2018 16:12, Chris Wilson wrote: Catch up with the inflight CSB events, after disabling the tasklet before deciding which request was truly guilty of hanging the GPU. Signed-off-by: Chris Wilson Cc: Michał Winiarski CC: Michel

Re: [Intel-gfx] [PATCH v3 10/40] misc/mei/hdcp: Verify H_prime

2018-05-16 Thread Ramalingam C
On Wednesday 09 May 2018 03:46 PM, Shankar, Uma wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Ramalingam C Sent: Tuesday, April 3, 2018 7:27 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Remove tasklet flush before disable URL : https://patchwork.freedesktop.org/series/43266/ State : warning == Summary == $ dim checkpatch origin/drm-tip 918420a1f591 drm/i915: Remove tasklet flush before disable c805538685f8

Re: [Intel-gfx] [PATCH v3 12/40] misc/mei/hdcp: Initiate Locality check

2018-05-16 Thread Ramalingam C
On Wednesday 09 May 2018 04:01 PM, Shankar, Uma wrote: -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Ramalingam C Sent: Tuesday, April 3, 2018 7:27 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

[Intel-gfx] [PATCH v3] gpu: drm: i915: Change return type to vm_fault_t

2018-05-16 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. commit 1c8f422059ae ("mm: change return type to vm_fault_t") Fixed one

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present

2018-05-16 Thread Ville Syrjälä
On Tue, May 08, 2018 at 05:08:35PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > VBT seems to have some bits to tell us whether the internal LVDS port > has something hooked up. In theory one might expect the VBT to not have > a child device for the LVDS

Re: [Intel-gfx] [PATCH] drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2.

2018-05-16 Thread Ville Syrjälä
On Wed, May 16, 2018 at 10:50:38AM +0200, Maarten Lankhorst wrote: > Normally this is called on a modeset, but the call is missing when > we inherit the mode from the BIOS, so make sure it's called somewhere > in hardware readout. > > Changes since v1: > - Unconditionally call

Re: [Intel-gfx] [PATCH 5/7] drm/i915/execlists: Split out CSB processing

2018-05-16 Thread Tvrtko Ursulin
On 16/05/2018 16:12, Chris Wilson wrote: Pull the CSB event processing into its own routine so that we can reuse it during reset to flush any missed interrupts/events. Signed-off-by: Chris Wilson Cc: Michał Winiarski CC: Michel Thierry

Re: [Intel-gfx] [PATCH v5 7/7] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-05-16 Thread Tvrtko Ursulin
On 15/05/2018 10:05, Tvrtko Ursulin wrote: On 14/05/2018 16:56, Lionel Landwerlin wrote: From: Chris Wilson We want to allow userspace to reconfigure the subslice configuration for its own use case. To do so, we expose a context parameter to allow adjustment of the

Re: [Intel-gfx] [PATCH v5 7/7] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-05-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-16 16:40:55) > > On 15/05/2018 10:05, Tvrtko Ursulin wrote: > > > > On 14/05/2018 16:56, Lionel Landwerlin wrote: > >> From: Chris Wilson > >> > >> We want to allow userspace to reconfigure the subslice configuration for > >> its own use

Re: [Intel-gfx] [PATCH v3 11/40] misc/mei/hdcp: Store the HDCP Pairing info

2018-05-16 Thread Ramalingam C
On Wednesday 09 May 2018 03:58 PM, Shankar, Uma wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Ramalingam C Sent: Tuesday, April 3, 2018 7:27 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH][V2] drm/i915/dp: fix spelling mistakes: "seqeuncer" and "seqeuencer"

2018-05-16 Thread Jani Nikula
On Wed, 09 May 2018, Jani Nikula wrote: > On Wed, 09 May 2018, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistakes in WARN warning message text and >> in comments: >> >> "seqeuncer",

Re: [Intel-gfx] [PATCH 6/7] drm/i915/execlists: Flush pending preemption events during reset

2018-05-16 Thread Tvrtko Ursulin
On 16/05/2018 07:47, Chris Wilson wrote: Catch up with the inflight CSB events, after disabling the tasklet before deciding which request was truly guilty of hanging the GPU. v2: Restore checking of use_csb_mmio on every loop, don't forget old vgpu. Signed-off-by: Chris Wilson

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Remove tasklet flush before disable URL : https://patchwork.freedesktop.org/series/43266/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4192 -> Patchwork_9018 = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] [PATCH v3 13/40] misc/mei/hdcp: Verify L_prime

2018-05-16 Thread Ramalingam C
On Wednesday 09 May 2018 04:06 PM, Shankar, Uma wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Ramalingam C Sent: Tuesday, April 3, 2018 7:27 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH v6 14/14] drm/i915: Enable platform support for vGPU huge gtt pages

2018-05-16 Thread Joonas Lahtinen
This is a purely a gvt patch too, so the patch subject should reflect that. Regards, Joonas Quoting changbin...@intel.com (2018-05-08 12:05:16) > From: Changbin Du > > Now GVTg supports shadowing both 2M/64K huge gtt pages. So let's turn on > the cap info bit

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-16 Thread Ville Syrjälä
On Wed, May 16, 2018 at 09:40:17AM +0200, Neil Armstrong wrote: > On 16/05/2018 09:31, Neil Armstrong wrote: > > Hi Ville, > > > > On 15/05/2018 17:35, Ville Syrjälä wrote: > >> On Tue, May 15, 2018 at 04:42:19PM +0200, Neil Armstrong wrote: > >>> This patchs adds the cec_notifier feature to the

[Intel-gfx] ✗ Fi.CI.BAT: failure for gpu: drm: i915: Change return type to vm_fault_t (rev3)

2018-05-16 Thread Patchwork
== Series Details == Series: gpu: drm: i915: Change return type to vm_fault_t (rev3) URL : https://patchwork.freedesktop.org/series/41893/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK

Re: [Intel-gfx] [PATCH v3 08/40] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2018-05-16 Thread Ramalingam C
On Wednesday 04 April 2018 12:15 PM, Usyskin, Alexander wrote: -Original Message- From: C, Ramalingam Sent: Tuesday, April 03, 2018 16:57 To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; seanp...@chromium.org; dan...@ffwll.ch; ch...@chris-wilson.co.uk;

[Intel-gfx] ✗ Fi.CI.BAT: failure for GuC, HuC Loading Support for Geminilake

2018-05-16 Thread Patchwork
== Series Details == Series: GuC, HuC Loading Support for Geminilake URL : https://patchwork.freedesktop.org/series/42437/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4192 -> Patchwork_9016 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9016

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/7] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Remove tasklet flush before disable URL : https://patchwork.freedesktop.org/series/43235/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4190_full -> Patchwork_9010_full = == Summary - FAILURE == Serious

Re: [Intel-gfx] [PATCH v3 05/40] misc/mei/hdcp: Notifier chain for mei cldev state change

2018-05-16 Thread Ramalingam C
On Tuesday 03 April 2018 09:00 PM, Daniel Vetter wrote: On Tue, Apr 03, 2018 at 07:27:18PM +0530, Ramalingam C wrote: Notifier Chain is defined to inform all its clients about the mei client device state change. Routine is defined for the clients to register and unregister for the

Re: [Intel-gfx] [CI 1/5] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Chris Wilson
Quoting Chris Wilson (2018-05-16 16:30:13) > The idea was to try and let the existing tasklet run to completion > before we began the reset, but it involves a racy check against anything > else that tries to run the tasklet. Rather than acknowledge and ignore > the race, let it be and don't try

Re: [Intel-gfx] [PATCH v3 08/40] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2018-05-16 Thread Ramalingam C
On Wednesday 09 May 2018 03:43 PM, Shankar, Uma wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Ramalingam C Sent: Tuesday, April 3, 2018 7:27 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Remove tasklet flush before disable URL : https://patchwork.freedesktop.org/series/43265/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4192 -> Patchwork_9017 = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH v2] drm/i915: Stop parking the signaler around reset

2018-05-16 Thread Tvrtko Ursulin
On 16/05/2018 11:13, Chris Wilson wrote: We cannot call kthread_park() from softirq context, so let's avoid it entirely during the reset. We wanted to suspend the signaler so that it would not mark a request as complete at the same time as we marked it as being in error. Instead of parking the

[Intel-gfx] [PATCH] drm/i915: Enable fastset by default, except on initial modeset

2018-05-16 Thread Maarten Lankhorst
We may not be perfect at reading out the initial mode, but when the mode is sanitized by our first modeset we know for sure the state is compatible, so we can compare with intel_pipe_config_compare. Signed-off-by: Maarten Lankhorst ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Add remaining registers and bitfields for MG PHY DDI

2018-05-16 Thread Patchwork
== Series Details == Series: drm/i915/icl: Add remaining registers and bitfields for MG PHY DDI URL : https://patchwork.freedesktop.org/series/43227/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4189_full -> Patchwork_9009_full = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] [PATCH 14/22] drm/i915/icl: WaDisableImprovedTdlClkGating

2018-05-16 Thread Mika Kuoppala
Oscar Mateo writes: > Revert to the legacy implementation. > > v2: GEN7_ROW_CHICKEN2 is masked > v3: > - Rebased > - Renamed to Wa_2006611047 > - A0 and B0 only > v4: > - Add spaces around '<<' (and fix the surrounding code as well) > - Mark the WA as pre-prod >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: split CNL platforms in GT1/2

2018-05-16 Thread kbuild test robot
Hi Lionel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on v4.17-rc5 next-20180516] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [Intel-gfx] [PATCH v3 05/40] misc/mei/hdcp: Notifier chain for mei cldev state change

2018-05-16 Thread Ramalingam C
Thanks Alexander for the review. Sorry for the delay in addressing the review comments On Wednesday 04 April 2018 11:42 AM, Usyskin, Alexander wrote: -Original Message- From: C, Ramalingam Sent: Tuesday, April 03, 2018 16:57 To: intel-gfx@lists.freedesktop.org;

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Remove tasklet flush before disable (rev2)

2018-05-16 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Remove tasklet flush before disable (rev2) URL : https://patchwork.freedesktop.org/series/43235/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4191 -> Patchwork_9013 = == Summary - WARNING == Minor

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable fastset by default, except on initial modeset

2018-05-16 Thread Patchwork
== Series Details == Series: drm/i915: Enable fastset by default, except on initial modeset URL : https://patchwork.freedesktop.org/series/43248/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4191 -> Patchwork_9014 = == Summary - WARNING == Minor unknown changes coming

Re: [Intel-gfx] [PATCH 1/2] drm/i915: split CNL platforms in GT1/2

2018-05-16 Thread kbuild test robot
/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-split-CNL-platforms-in-GT1-2/20180516-174705 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-a0-201819 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Remove tasklet flush before disable (rev2)

2018-05-16 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Remove tasklet flush before disable (rev2) URL : https://patchwork.freedesktop.org/series/43235/ State : warning == Summary == $ dim checkpatch origin/drm-tip fca038eedae4 drm/i915: Remove tasklet flush before disable

Re: [Intel-gfx] [PATCH 1/2] drm/i915: split CNL platforms in GT1/2

2018-05-16 Thread kbuild test robot
/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-split-CNL-platforms-in-GT1-2/20180516-174705 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-defconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "drm/i915/edp: Do not do link training fallback or prune modes on EDP"

2018-05-16 Thread Patchwork
== Series Details == Series: Revert "drm/i915/edp: Do not do link training fallback or prune modes on EDP" URL : https://patchwork.freedesktop.org/series/43278/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0b54952e8cb7 Revert "drm/i915/edp: Do not do link training fallback

Re: [Intel-gfx] [PATCH v3 17/40] misc/mei/hdcp: Enabling the HDCP authentication

2018-05-16 Thread Ramalingam C
On Wednesday 09 May 2018 07:25 PM, Shankar, Uma wrote: -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Ramalingam C Sent: Tuesday, April 3, 2018 7:28 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-16 Thread Dhinakaran Pandiyan
On Wed, 2018-05-16 at 11:08 +0300, Jani Nikula wrote: > On Wed, 16 May 2018, vathsala nagaraju > wrote: > > > > On Wednesday 16 May 2018 04:33 AM, Dhinakaran Pandiyan wrote: > > > > > > On Mon, 2018-05-14 at 09:02 +0530, vathsala nagaraju wrote: > > > > > > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2.

2018-05-16 Thread Patchwork
== Series Details == Series: drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2. URL : https://patchwork.freedesktop.org/series/43243/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4191_full -> Patchwork_9012_full = == Summary - WARNING == Minor

Re: [Intel-gfx] [PATCH v2 2/4] drm/dsc: Define Display Stream Compression PPS infoframe

2018-05-16 Thread Harry Wentland
On 2018-05-14 10:05 PM, Manasi Navare wrote: > This patch defines a new header file for all the DSC 1.2 structures > and creates a structure for PPS infoframe which will be used to send > picture parameter set secondary data packet for display stream compression. > All the PPS infoframe syntax

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/7] drm/i915: Remove tasklet flush before disable (rev2)

2018-05-16 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Remove tasklet flush before disable (rev2) URL : https://patchwork.freedesktop.org/series/43235/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4191_full -> Patchwork_9013_full = == Summary - FAILURE ==

Re: [Intel-gfx] [PATCH v3 16/40] misc/mei/hdcp: Verify M_prime

2018-05-16 Thread Ramalingam C
On Wednesday 09 May 2018 07:20 PM, Shankar, Uma wrote: -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Ramalingam C Sent: Tuesday, April 3, 2018 7:27 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH 5/7] drm/vmwgfx: Stop updating plane->fb

2018-05-16 Thread Deepak Singh Rawat
> > On Fri, Apr 06, 2018 at 10:35:00PM +0300, Ville Syrjälä wrote: > > On Fri, Apr 06, 2018 at 07:14:51PM +, Deepak Singh Rawat wrote: > > > This makes sense once we got rid of plane->fb > > > > > > Will this go to drm-next? > > > > The plan is to push to drm-misc-next once we get all > > the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/dp: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT

2018-05-16 Thread Patchwork
== Series Details == Series: drm/dp: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT URL : https://patchwork.freedesktop.org/series/43275/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4193 -> Patchwork_9020 = == Summary - WARNING == Minor unknown changes coming

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915/edp: Do not do link training fallback or prune modes on EDP"

2018-05-16 Thread Patchwork
== Series Details == Series: Revert "drm/i915/edp: Do not do link training fallback or prune modes on EDP" URL : https://patchwork.freedesktop.org/series/43278/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4193 -> Patchwork_9021 = == Summary - WARNING == Minor unknown

[Intel-gfx] [CI 1/8] drm/i915: Remove tasklet flush before disable

2018-05-16 Thread Chris Wilson
The idea was to try and let the existing tasklet run to completion before we began the reset, but it involves a racy check against anything else that tries to run the tasklet. Rather than acknowledge and ignore the race, let it be and don't try and be too clever. The tasklet will resume execution

[Intel-gfx] [CI 7/8] drm/i915/execlists: Flush pending preemption events during reset

2018-05-16 Thread Chris Wilson
Catch up with the inflight CSB events, after disabling the tasklet before deciding which request was truly guilty of hanging the GPU. Signed-off-by: Chris Wilson Cc: Michał Winiarski CC: Michel Thierry Cc: Jeff

[Intel-gfx] [CI 4/8] drm/i915: Move engine reset prepare/finish to backends

2018-05-16 Thread Chris Wilson
In preparation to more carefully handling incomplete preemption during reset by execlists, we move the existing code wholesale to the backends under a couple of new reset vfuncs. Signed-off-by: Chris Wilson Cc: Michał Winiarski CC: Michel

[Intel-gfx] [CI 6/8] drm/i915/execlists: Split out CSB processing

2018-05-16 Thread Chris Wilson
Pull the CSB event processing into its own routine so that we can reuse it during reset to flush any missed interrupts/events. Signed-off-by: Chris Wilson Cc: Michał Winiarski CC: Michel Thierry Cc: Jeff McGee

[Intel-gfx] [CI 8/8] drm/i915: Stop parking the signaler around reset

2018-05-16 Thread Chris Wilson
We cannot call kthread_park() from softirq context, so let's avoid it entirely during the reset. We wanted to suspend the signaler so that it would not mark a request as complete at the same time as we marked it as being in error. Instead of parking the signaling, stop the engine from advancing so

[Intel-gfx] [CI 2/8] drm/i915: Only sync tasklets once for recursive reset preparation

2018-05-16 Thread Chris Wilson
When setting up reset, we may need to recursively prepare an engine. In which case we should only synchronously flush the tasklets on the outer most call, the inner calls will then be inside an atomic section where the tasklet will never be run (and so the sync will never complete).

[Intel-gfx] [CI 5/8] drm/i915: Split execlists/guc reset preparations

2018-05-16 Thread Chris Wilson
In the next patch, we will make the execlists reset prepare callback take into account preemption by flushing the context-switch handler. This is not applicable to the GuC submission backend, so split the two into their own backend callbacks. Signed-off-by: Chris Wilson

[Intel-gfx] [CI 3/8] drm/i915/execlists: Refactor out complete_preempt_context()

2018-05-16 Thread Chris Wilson
As a complement to inject_preempt_context(), follow up with the function to handle its completion. This will be useful should we wish to extend the duties of the preempt-context for execlists. v2: And do the same for the guc. Signed-off-by: Chris Wilson Cc: Jeff McGee

Re: [Intel-gfx] [PATCH v2 3/4] drm/dsc: Define VESA Display Stream Compression Capabilities

2018-05-16 Thread Harry Wentland
On 2018-05-14 10:05 PM, Manasi Navare wrote: > From: Gaurav K Singh > > This defines all the DSC parameters as per the VESA DSC spec > that will be required for DSC encoder/decoder > > v2: Define this struct in DRM (From Manasi) > * Changed the data types to u8/u16

[Intel-gfx] [PATCH] drm/dp: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT

2018-05-16 Thread matthew . s . atwood
From: Matt Atwood According to DP spec (2.9.3.1 of DP 1.4) if EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT is set the addresses in DPCD 02200h through 0220Fh shall contain the DPRX's true capability. These values will match 0h through Fh, except for DPCD_REV,

  1   2   >