[Intel-gfx] [PATCH 4.20 regression fix] drm/i915: Revert "Fix assert_plane() warning on bootup with external display"

2018-11-19 Thread Hans de Goede
Starting with 4.20-rc1 I'm seeing the LCD screen briefly turn mostly purple on devices with a DSI panel (seen on 2 different devices with a DSI panel). This happens both with and without fastboot=1. This is caused by commit 516a49cc1946 ("drm/i915: Fix assert_plane() warning on bootup with

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add code comment on assumption of pipe==transcoder

2018-11-19 Thread Imre Deak
On Mon, Nov 19, 2018 at 02:06:31PM -0800, Lucas De Marchi wrote: > On Mon, Nov 19, 2018 at 08:43:27PM +0200, Imre Deak wrote: > > On Mon, Nov 19, 2018 at 05:51:31PM +0200, Ville Syrjälä wrote: > > > On Mon, Nov 19, 2018 at 04:41:09PM +0200, Imre Deak wrote: > > > > Add a comment to the pipe and

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Revert "Fix assert_plane() warning on bootup with external display"

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Revert "Fix assert_plane() warning on bootup with external display" URL : https://patchwork.freedesktop.org/series/52720/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5166 -> Patchwork_10855 = == Summary - SUCCESS == No

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: allow to load DMC firmware on next gen

2018-11-19 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: allow to load DMC firmware on next gen URL : https://patchwork.freedesktop.org/series/52639/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5162_full -> Patchwork_10850_full = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-19 Thread Lucas De Marchi
On Thu, Nov 08, 2018 at 11:23:46AM +, Tvrtko Ursulin wrote: > > On 08/11/2018 00:57, Lucas De Marchi wrote: > > On Wed, Nov 07, 2018 at 10:05:19AM +, Tvrtko Ursulin wrote: > > > > > > On 06/11/2018 21:51, Lucas De Marchi wrote: > > > > This is the second version of the series trying to

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values (rev4)

2018-11-19 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values (rev4) URL : https://patchwork.freedesktop.org/series/52693/ State : failure == Summary == Applying: drm/i915: Make pipe/transcoder offsets not depend on enum values

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Add and export function to parse manufacturer id

2018-11-19 Thread Souza, Jose
On Tue, 2018-11-13 at 22:07 +0200, Jani Nikula wrote: > On Thu, 08 Nov 2018, Daniel Vetter wrote: > > On Thu, Nov 08, 2018 at 08:42:52PM +, Souza, Jose wrote: > > > On Thu, 2018-11-08 at 09:31 +0100, Daniel Vetter wrote: > > > > On Wed, Nov 07, 2018 at 04:23:52PM -0800, José Roberto de Souza

Re: [Intel-gfx] [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output

2018-11-19 Thread Rodrigo Vivi
On Mon, Nov 19, 2018 at 03:01:01PM -0800, José Roberto de Souza wrote: > When there is no output no one will hold a runtime_pm reference > causing a warning when trying to read emom_status in debugfs. > > [22.756480] [ cut here ] > [22.756489] RPM wakelock ref not held

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Program SKL+ watermarks/ddb more carefully (rev8)

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev8) URL : https://patchwork.freedesktop.org/series/51878/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5162_full -> Patchwork_10852_full = == Summary - FAILURE == Serious unknown

[Intel-gfx] [PATCH v2 3/3] drm/i915: Add code comment on assumption of pipe==transcoder

2018-11-19 Thread Imre Deak
Add a comment to the pipe and transcoder enum definitions about our assumption in the code about enum values for pipes and transcoders with a 1:1 transcoder->pipe mapping. v2: - Clarify more what are the assumptions about the enum values. (Ville) Cc: Ville Syrjälä Cc: Lucas De Marchi Cc: Mika

[Intel-gfx] [PATCH v3 2/3] drm/i915: Make EDP PSR flags not depend on enum values

2018-11-19 Thread Imre Deak
Depending on the transcoder enum values to translate from transcoder to EDP PSR flags can easily break if we add a new transcoder. So remove the dependency by using an explicit mapping. While at it also add a WARN for unexpected trancoders. v2: - Simplify things by defining flag shift values

Re: [Intel-gfx] [PATCH v9 20/24] drm/i915/dsc: Add Per connector debugfs node for DSC support/enable

2018-11-19 Thread Manasi Navare
On Mon, Nov 19, 2018 at 10:27:44PM +0200, Ville Syrjälä wrote: > On Thu, Nov 15, 2018 at 05:39:42PM -0800, Manasi Navare wrote: > > On Tue, Nov 13, 2018 at 05:52:28PM -0800, Manasi Navare wrote: > > > DSC can be supported per DP connector. This patch adds a per connector > > > debugfs node to

Re: [Intel-gfx] [PATCH v9 22/24] drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION

2018-11-19 Thread Manasi Navare
On Mon, Nov 19, 2018 at 10:19:42PM +0200, Ville Syrjälä wrote: > On Tue, Nov 13, 2018 at 05:52:30PM -0800, Manasi Navare wrote: > > From: Anusha Srivatsa > > > > If the panel supports FEC, the driver has to > > set the FEC_READY bit in the dpcd register: > > FEC_CONFIGURATION. > > > > This has

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make CHICKEN_TRANS reg not depend on enum value (rev2)

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Make CHICKEN_TRANS reg not depend on enum value (rev2) URL : https://patchwork.freedesktop.org/series/52700/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5162_full -> Patchwork_10851_full = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add code comment on assumption of pipe==transcoder

2018-11-19 Thread Lucas De Marchi
On Mon, Nov 19, 2018 at 08:43:27PM +0200, Imre Deak wrote: > On Mon, Nov 19, 2018 at 05:51:31PM +0200, Ville Syrjälä wrote: > > On Mon, Nov 19, 2018 at 04:41:09PM +0200, Imre Deak wrote: > > > Add a comment to the pipe and transcoder enum definitions about our > > > assumption in the code that

[Intel-gfx] "drm/i915: Use the correct crtc when sanitizing plane mapping" seems to cause the readback plane state to always be 0

2018-11-19 Thread Hans de Goede
Hi Ville, While debugging the briefly purple screen on DSI panels issue for which I just send a revert, I also noticed something odd with your commit 9b27390139db ("drm/i915: Use the correct crtc when sanitizing plane mapping"). When comparing drm.debug=0x1e logs between 4.19 and 4.20-rc1 I

Re: [Intel-gfx] [PATCH v2 03/13] drm/i915: Introduce crtc_state->update_planes bitmask

2018-11-19 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:07:19PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Keep track which planes need updating during the commit. For now this > is just (was_visible || is_visible) but I'll have need to update I still think it would be a good idea to mention was_slave ||

Re: [Intel-gfx] [PATCH v2 01/13] drm/i915: Reorganize plane register writes to make them more atomic

2018-11-19 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:07:17PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Some observations about the plane registers: > - the control register will self-arm if the plane is not already > enabled, thus we want to write it as close to (or ideally after) > the surface register >

Re: [Intel-gfx] [PATCH v2 04/13] drm/i915: Pass the new crtc_state to ->disable_plane()

2018-11-19 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:07:20PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We're going to need access to the new crtc state in ->disable_plane() > for SKL+ wm/ddb programming and pre-skl pipe gamma/csc control. Pass > the crtc state down. > > We'll also try to make

Re: [Intel-gfx] [PATCH v2 05/13] drm/i915: Fix latency==0 handling for level 0 watermark on skl+

2018-11-19 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:07:21PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > If the level 0 latency is 0 we can't do anything. Return an error > rather than success. > > While this can't happen due to WaWmMemoryReadLatency, it can > happen if the user clears out the level 0 latency

Re: [Intel-gfx] [PATCH v2 06/13] drm/i915: Remove some useless zeroing on skl+ wm calculations

2018-11-19 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:07:22PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We memset(0) the entire watermark struct the start, so there's no > need to clear things later on. > > v2: Rebase due to some stale w/a removal > > Reviewed-by: Rodrigo Vivi > Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH v2 02/13] drm/i915: Move single buffered plane register writes to the end

2018-11-19 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:07:18PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The plane color correction registers are single buffered. So > ideally we would write them at the start of vblank just after the > double buffered plane registers have been latched. Since we have > no

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ilk: Fix warning when reading emon_status with no output

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915/ilk: Fix warning when reading emon_status with no output URL : https://patchwork.freedesktop.org/series/52721/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5166 -> Patchwork_10856 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Write GPU relocs harder with gen3

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Write GPU relocs harder with gen3 URL : https://patchwork.freedesktop.org/series/52698/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5161_full -> Patchwork_10848_full = == Summary - WARNING == Minor unknown changes coming with

Re: [Intel-gfx] [PATCH v9 08/24] drm/i915/dp: Compute DSC pipe config in atomic check

2018-11-19 Thread Manasi Navare
Thanks for the comments, please some my answers below: On Mon, Nov 19, 2018 at 10:11:04PM +0200, Ville Syrjälä wrote: > On Tue, Nov 13, 2018 at 05:52:16PM -0800, Manasi Navare wrote: > > DSC params like the enable, compressed bpp, slice count and > > dsc_split are added to the intel_crtc_state.

Re: [Intel-gfx] [PATCH v9 01/24] drm/dsc: Modify DRM helper to return complete DSC color depth capabilities

2018-11-19 Thread Manasi Navare
On Mon, Nov 19, 2018 at 10:33:37PM +0200, Ville Syrjälä wrote: > On Mon, Nov 19, 2018 at 12:10:47PM -0800, Manasi Navare wrote: > > On Mon, Nov 19, 2018 at 09:43:38PM +0200, Ville Syrjälä wrote: > > > On Tue, Nov 13, 2018 at 05:52:09PM -0800, Manasi Navare wrote: > > > > DSC DPCD color depth

[Intel-gfx] [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output

2018-11-19 Thread José Roberto de Souza
When there is no output no one will hold a runtime_pm reference causing a warning when trying to read emom_status in debugfs. [22.756480] [ cut here ] [22.756489] RPM wakelock ref not held during HW access [22.756578] WARNING: CPU: 0 PID: 1058 at

Re: [Intel-gfx] [PATCH v2 07/13] drm/i915: Pass the entire skl_plane_wm to skl_compute_transition_wm()

2018-11-19 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:07:23PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We have to pass both level 0 watermark struct and the transition > watermark struct to skl_compute_transition_wm(). Make life less > confusing by just passing the entire plane watermark struct that >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values

2018-11-19 Thread Zhenyu Wang
On 2018.11.19 20:54:30 +0200, Imre Deak wrote: > On Mon, Nov 19, 2018 at 05:29:26PM +0200, Ville Syrjälä wrote: > > On Mon, Nov 19, 2018 at 04:41:07PM +0200, Imre Deak wrote: > > > Depending on the transcoder enum values to translate from transcoder > > > to pipe/transcoder register addresses can

Re: [Intel-gfx] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-19 Thread CK Hu
On Mon, 2018-11-12 at 16:01 +0100, Maarten Lankhorst wrote: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gpu reset hook, correct it. > Nouveau already implemented its own

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Revert "Fix assert_plane() warning on bootup with external display"

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Revert "Fix assert_plane() warning on bootup with external display" URL : https://patchwork.freedesktop.org/series/52720/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5166_full -> Patchwork_10855_full = == Summary - WARNING ==

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ilk: Fix warning when reading emon_status with no output

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915/ilk: Fix warning when reading emon_status with no output URL : https://patchwork.freedesktop.org/series/52721/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5166_full -> Patchwork_10856_full = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v2)

2018-11-19 Thread Chris Chiu
On Tue, Nov 13, 2018 at 1:18 PM Guang Bai wrote: > On Tue, 13 Nov 2018 09:04:37 +0800 > Chris Chiu wrote: > > > Gentle ping. Just want to know if you have time for this so far. > > Thanks > > > > Chris > Actually I'm still working on it right now with > DRM_MODE_CONNECTOR_HDMIA/HDMIB,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Make CHICKEN_TRANS reg not depend on enum value

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Make CHICKEN_TRANS reg not depend on enum value URL : https://patchwork.freedesktop.org/series/52700/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5e3143add138 drm/i915: Make CHICKEN_TRANS reg not depend on enum value -:11:

Re: [Intel-gfx] [PATCH] drm/amdgpu: Reorder uvd ring init before uvd resume

2018-11-19 Thread Christian König
Am 16.11.18 um 10:34 schrieb Chris Wilson: As amd_uvd_resume() accesses the uvd ring, it must be initialised first or else we trigger errors like: [5.595963] [drm] Found UVD firmware Version: 1.87 Family ID: 17 [5.595969] [drm] PSP loading UVD firmware [5.596266] [ cut

Re: [Intel-gfx] [PATCH v3 7/8] drm/i915/gvt: GVTg support context submission pvmmio optimization

2018-11-19 Thread Christophe de Dinechin
> On 13 Nov 2018, at 09:35, Xiaolin Zhang wrote: > > implemented context submission pvmmio optimizaiton with GVTg. > > GVTg to read context submission data (elsp_data) from the shared_page > directly without trap cost to improve guest GPU peformrnace. > > v0: RFC > v1: rebase > v2: rebase >

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915/perf: add a parameter to control the size of OA buffer"

2018-11-19 Thread Matthew Auld
On Fri, 16 Nov 2018 at 13:55, Joonas Lahtinen wrote: > > Userspace portion is still missing. > > This reverts commit cd956bfcd0f58d20485ac0a785415f7d9327a95f. > > Cc: Lionel Landwerlin > Cc: Matthew Auld > Signed-off-by: Joonas Lahtinen For both patches: Acked-by: Matthew Auld

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings

2018-11-19 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-11-19 00:01:57) > Quoting Lucas De Marchi (2018-11-17 00:42:34) > > Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown > > firmware warnings") for huc and guc: downgrade CSR firmware warnings. If > > we have released no firmware yet for a platform,

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915/perf: add a parameter to control the size of OA buffer"

2018-11-19 Thread Joonas Lahtinen
Quoting Matthew Auld (2018-11-19 12:36:00) > On Fri, 16 Nov 2018 at 13:55, Joonas Lahtinen > wrote: > > > > Userspace portion is still missing. > > > > This reverts commit cd956bfcd0f58d20485ac0a785415f7d9327a95f. > > > > Cc: Lionel Landwerlin > > Cc: Matthew Auld > > Signed-off-by: Joonas

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Hide enable_gvt modparam when not compiled in

2018-11-19 Thread Joonas Lahtinen
Thanks for the reviews, pushed now. Regards, Joonas Quoting Patchwork (2018-11-16 17:31:58) > == Series Details == > > Series: drm/i915: Hide enable_gvt modparam when not compiled in > URL : https://patchwork.freedesktop.org/series/52616/ > State : success > > == Summary == > > = CI Bug Log

Re: [Intel-gfx] [GVT-g] [ANNOUNCE] 2018-Q3 release of KVMGT (Intel GVT-g for KVM)

2018-11-19 Thread Xu, Terrence
Yes, if you find and problem on we mentioned platform, you can file a bug on fd. (https://bugs.freedesktop.org/) with component "DRM/iGVT-g". >-Original Message- >From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] >Sent: Friday, November 16, 2018 10:34 PM >To:

Re: [Intel-gfx] [LKP] dad4f140ed [ 7.709376] WARNING:suspicious_RCU_usage

2018-11-19 Thread Matthew Wilcox
On Sun, Nov 18, 2018 at 05:19:04PM -0800, Matthew Wilcox wrote: > On Mon, Nov 19, 2018 at 09:08:20AM +0800, kernel test robot wrote: > > Greetings, > > > > 0day kernel testing robot got the below dmesg and the first bad commit is > > Umm. I don't see a 'suspicious RCU usage' message in here. I

[Intel-gfx] [PATCH 2/3] drm/i915: Make EDP PSR flags not depend on enum values

2018-11-19 Thread Imre Deak
Depending on the transcoder enum values to translate from transcoder to EDP PSR flags can easily break if we add a new transcoder. So remove the dependency by using an explicit mapping. While at it also add a WARN for unexpected trancoders. Cc: Ville Syrjälä Cc: Lucas De Marchi Cc: Mika Kahola

[Intel-gfx] [PATCH 1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values

2018-11-19 Thread Imre Deak
Depending on the transcoder enum values to translate from transcoder to pipe/transcoder register addresses can easily break if we add a new transcoder. So remove the dependency by using named initializers. Suggested-by: Ville Syrjälä Cc: Ville Syrjälä Signed-off-by: Imre Deak ---

[Intel-gfx] [PATCH 3/3] drm/i915: Add code comment on assumption of pipe==transcoder

2018-11-19 Thread Imre Deak
Add a comment to the pipe and transcoder enum definitions about our assumption in the code that pipe==transcoder for PIPE_A-C / TRANSCODER_A-C. This means we have to keep the values for these pipe/transcoder enums fixed. Cc: Ville Syrjälä Cc: Lucas De Marchi Cc: Mika Kahola Signed-off-by: Imre

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values

2018-11-19 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values URL : https://patchwork.freedesktop.org/series/52693/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5160 -> Patchwork_10847 = == Summary - SUCCESS ==

[Intel-gfx] [PATCH i-g-t 2/2] tests/gem_exec_await: Add a memory pressure subtest

2018-11-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Memory pressure subtest attempts to provoke system overload which can cause GPU hangs, especially when combined with spin batches which do not allow for some nop instructions to provide relief. Signed-off-by: Tvrtko Ursulin --- tests/i915/gem_exec_await.c | 107

[Intel-gfx] [PATCH i-g-t 1/2] tests/gem_exec_await: Relax the busy spinner

2018-11-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add some nop instructions between recursive batch buffer start calls to give system some breathing room. Without these, especially when coupled with memory pressure, false GPU hangs can be observed caused by the inability of the chip to cope. Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] tests/gem_exec_await: Relax the busy spinner

2018-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-11-19 15:22:28) > From: Tvrtko Ursulin > > Add some nop instructions between recursive batch buffer start calls to > give system some breathing room. Without these, especially when coupled > with memory pressure, false GPU hangs can be observed caused by the >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values

2018-11-19 Thread Ville Syrjälä
On Mon, Nov 19, 2018 at 04:41:07PM +0200, Imre Deak wrote: > Depending on the transcoder enum values to translate from transcoder > to pipe/transcoder register addresses can easily break if we add a new > transcoder. So remove the dependency by using named initializers. > > Suggested-by: Ville

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] tests/gem_exec_await: Relax the busy spinner

2018-11-19 Thread Tvrtko Ursulin
On 19/11/2018 15:28, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-11-19 15:22:28) From: Tvrtko Ursulin Add some nop instructions between recursive batch buffer start calls to give system some breathing room. Without these, especially when coupled with memory pressure, false GPU hangs can

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] tests/gem_exec_await: Add a memory pressure subtest

2018-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-11-19 15:22:29) > From: Tvrtko Ursulin > > Memory pressure subtest attempts to provoke system overload which can > cause GPU hangs, especially when combined with spin batches which do > not allow for some nop instructions to provide relief. > > Signed-off-by: Tvrtko

[Intel-gfx] [PATCH] drm/i915: Write GPU relocs harder with gen3

2018-11-19 Thread Chris Wilson
Under moderate amounts of GPU stress, we can observe on Bearlake and Pineview (later gen3 models) that we execute the following batch buffer before the write into the batch is coherent. Adding extra (tested with upto 32x) MI_FLUSH to either the invalidation, flush or both phases does not solve the

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add code comment on assumption of pipe==transcoder

2018-11-19 Thread Ville Syrjälä
On Mon, Nov 19, 2018 at 04:41:09PM +0200, Imre Deak wrote: > Add a comment to the pipe and transcoder enum definitions about our > assumption in the code that pipe==transcoder for PIPE_A-C / > TRANSCODER_A-C. This means we have to keep the values for these > pipe/transcoder enums fixed. > > Cc:

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] tests/gem_exec_await: Add a memory pressure subtest

2018-11-19 Thread Tvrtko Ursulin
On 19/11/2018 15:36, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-11-19 15:22:29) From: Tvrtko Ursulin Memory pressure subtest attempts to provoke system overload which can cause GPU hangs, especially when combined with spin batches which do not allow for some nop instructions to provide

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] tests/gem_exec_await: Relax the busy spinner

2018-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-11-19 15:33:56) > > On 19/11/2018 15:28, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-11-19 15:22:28) > >> From: Tvrtko Ursulin > >> > >> Add some nop instructions between recursive batch buffer start calls to > >> give system some breathing room. Without

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Write GPU relocs harder with gen3

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Write GPU relocs harder with gen3 URL : https://patchwork.freedesktop.org/series/52698/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5161 -> Patchwork_10848 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] [PATCH] drm/i915: Make CHICKEN_TRANS reg not depend on enum value

2018-11-19 Thread Imre Deak
Depending on the transcoder enum values to translate from transcoder to the corresponding CHICKEN_TRANS register can easily break if we add a new transcoder. Add an explicit mapping instead, by using helpers to look up the register instance either by transcoder or port (since unconveniently the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Make CHICKEN_TRANS reg not depend on enum value

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Make CHICKEN_TRANS reg not depend on enum value URL : https://patchwork.freedesktop.org/series/52700/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5161 -> Patchwork_10849 = == Summary - FAILURE == Serious unknown changes coming

Re: [Intel-gfx] [PATCH] drm/i915: Make CHICKEN_TRANS reg not depend on enum value

2018-11-19 Thread Ville Syrjälä
On Mon, Nov 19, 2018 at 06:33:26PM +0200, Imre Deak wrote: > Depending on the transcoder enum values to translate from transcoder to the > corresponding CHICKEN_TRANS register can easily break if we add a new > transcoder. Add an explicit mapping instead, by using helpers to look up the > register

Re: [Intel-gfx] [PATCH v3 2/3] drm: Add CRTC background color property (v3)

2018-11-19 Thread Brian Starkey
Hi Matt, On Thu, Nov 15, 2018 at 02:13:45PM -0800, Matt Roper wrote: >Some display controllers can be programmed to present non-black colors >for pixels not covered by any plane (or pixels covered by the >transparent regions of higher planes). Compositors that want a UI with >a solid color

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] tests/gem_exec_await: Add a memory pressure subtest

2018-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-11-19 15:54:44) > > On 19/11/2018 15:36, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-11-19 15:22:29) > >> From: Tvrtko Ursulin > >> +static unsigned long get_avail_ram_mb(void) > > > > intel_get_avail_ram_mb() ? > > I thought so but when things went slow I

Re: [Intel-gfx] [PATCH v9 01/24] drm/dsc: Modify DRM helper to return complete DSC color depth capabilities

2018-11-19 Thread Manasi Navare
On Mon, Nov 19, 2018 at 09:43:38PM +0200, Ville Syrjälä wrote: > On Tue, Nov 13, 2018 at 05:52:09PM -0800, Manasi Navare wrote: > > DSC DPCD color depth register advertises its color depth capabilities > > by setting each of the bits that corresponding to a specific color > > depth. This patch

Re: [Intel-gfx] [PATCH v9 08/24] drm/i915/dp: Compute DSC pipe config in atomic check

2018-11-19 Thread Ville Syrjälä
On Tue, Nov 13, 2018 at 05:52:16PM -0800, Manasi Navare wrote: > DSC params like the enable, compressed bpp, slice count and > dsc_split are added to the intel_crtc_state. These parameters > are set based on the requested mode and available link parameters > during the pipe configuration in atomic

Re: [Intel-gfx] [PATCH v9 14/24] drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling

2018-11-19 Thread Ville Syrjälä
On Tue, Nov 13, 2018 at 05:52:22PM -0800, Manasi Navare wrote: > After encoder->pre_enable() hook, after link training sequence is > completed, PPS registers for DSC encoder are configured using the > DSC state parameters in intel_crtc_state as part of DSC enabling > routine in the source. DSC

Re: [Intel-gfx] [PATCH v9 22/24] drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION

2018-11-19 Thread Ville Syrjälä
On Tue, Nov 13, 2018 at 05:52:30PM -0800, Manasi Navare wrote: > From: Anusha Srivatsa > > If the panel supports FEC, the driver has to > set the FEC_READY bit in the dpcd register: > FEC_CONFIGURATION. > > This has to happen before link training. > > v2:

Re: [Intel-gfx] [PATCH v9 20/24] drm/i915/dsc: Add Per connector debugfs node for DSC support/enable

2018-11-19 Thread Ville Syrjälä
On Thu, Nov 15, 2018 at 05:39:42PM -0800, Manasi Navare wrote: > On Tue, Nov 13, 2018 at 05:52:28PM -0800, Manasi Navare wrote: > > DSC can be supported per DP connector. This patch adds a per connector > > debugfs node to expose DSC support capability by the kernel. > > The same node can be used

Re: [Intel-gfx] [PATCH v9 01/24] drm/dsc: Modify DRM helper to return complete DSC color depth capabilities

2018-11-19 Thread Ville Syrjälä
On Mon, Nov 19, 2018 at 12:10:47PM -0800, Manasi Navare wrote: > On Mon, Nov 19, 2018 at 09:43:38PM +0200, Ville Syrjälä wrote: > > On Tue, Nov 13, 2018 at 05:52:09PM -0800, Manasi Navare wrote: > > > DSC DPCD color depth register advertises its color depth capabilities > > > by setting each of

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Program SKL+ watermarks/ddb more carefully (rev8)

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev8) URL : https://patchwork.freedesktop.org/series/51878/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5162 -> Patchwork_10852 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] tests/gem_exec_await: Relax the busy spinner

2018-11-19 Thread Tvrtko Ursulin
On 19/11/2018 16:18, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-11-19 15:33:56) On 19/11/2018 15:28, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-11-19 15:22:28) From: Tvrtko Ursulin Add some nop instructions between recursive batch buffer start calls to give system some

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values

2018-11-19 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values URL : https://patchwork.freedesktop.org/series/52693/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5160_full -> Patchwork_10847_full = == Summary -

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] tests/gem_exec_await: Relax the busy spinner

2018-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-11-19 19:18:52) > > On 19/11/2018 16:18, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-11-19 15:33:56) > >> > >> On 19/11/2018 15:28, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2018-11-19 15:22:28) > From: Tvrtko Ursulin > > Add some nop

Re: [Intel-gfx] [PATCH v9 01/24] drm/dsc: Modify DRM helper to return complete DSC color depth capabilities

2018-11-19 Thread Ville Syrjälä
On Tue, Nov 13, 2018 at 05:52:09PM -0800, Manasi Navare wrote: > DSC DPCD color depth register advertises its color depth capabilities > by setting each of the bits that corresponding to a specific color > depth. This patch defines those specific color depths and adds > a helper to return an array

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings

2018-11-19 Thread Rodrigo Vivi
On Mon, Nov 19, 2018 at 12:43:56PM +0200, Joonas Lahtinen wrote: > Quoting Chris Wilson (2018-11-19 00:01:57) > > Quoting Lucas De Marchi (2018-11-17 00:42:34) > > > Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown > > > firmware warnings") for huc and guc: downgrade CSR

[Intel-gfx] [PATCH v4 10/13] drm/i915: Move ddb/wm programming into plane update/disable hooks on skl+

2018-11-19 Thread Ville Syrjala
From: Ville Syrjälä On SKL+ the plane WM/BUF_CFG registers are a proper part of each plane's register set. That means accessing them will cancel any pending plane update, and we would need a PLANE_SURF register write to arm the wm/ddb change as well. To avoid all the problems with that let's

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: allow to load DMC firmware on next gen

2018-11-19 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: allow to load DMC firmware on next gen URL : https://patchwork.freedesktop.org/series/52639/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5162 -> Patchwork_10850 = == Summary - SUCCESS == No regressions

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Program SKL+ watermarks/ddb more carefully (rev8)

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev8) URL : https://patchwork.freedesktop.org/series/51878/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Reorganize plane register writes to make them more

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make CHICKEN_TRANS reg not depend on enum value (rev2)

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Make CHICKEN_TRANS reg not depend on enum value (rev2) URL : https://patchwork.freedesktop.org/series/52700/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5162 -> Patchwork_10851 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen

2018-11-19 Thread Rodrigo Vivi
On Fri, Nov 16, 2018 at 04:42:33PM -0800, Lucas De Marchi wrote: > Before commit d8a5b7d79fb7 ("drm/i915/csr: keep max firmware size together > with firmare name and version") it was possible to load the firmware for > testing purposes via parameter. Let's use the size of the last known > platform

[Intel-gfx] [PATCH v2] drm/i915: Make CHICKEN_TRANS reg not depend on enum value

2018-11-19 Thread Imre Deak
Depending on the transcoder enum values to translate from transcoder to the corresponding CHICKEN_TRANS register can easily break if we add a new transcoder. Add an explicit mapping instead, by using helpers to look up the register instance either by transcoder or port (since unconveniently the

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add code comment on assumption of pipe==transcoder

2018-11-19 Thread Imre Deak
On Mon, Nov 19, 2018 at 05:51:31PM +0200, Ville Syrjälä wrote: > On Mon, Nov 19, 2018 at 04:41:09PM +0200, Imre Deak wrote: > > Add a comment to the pipe and transcoder enum definitions about our > > assumption in the code that pipe==transcoder for PIPE_A-C / > > TRANSCODER_A-C. This means we have

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Program SKL+ watermarks/ddb more carefully (rev8)

2018-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev8) URL : https://patchwork.freedesktop.org/series/51878/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8bd133c09121 drm/i915: Reorganize plane register writes to make them more atomic

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values

2018-11-19 Thread Imre Deak
On Mon, Nov 19, 2018 at 05:29:26PM +0200, Ville Syrjälä wrote: > On Mon, Nov 19, 2018 at 04:41:07PM +0200, Imre Deak wrote: > > Depending on the transcoder enum values to translate from transcoder > > to pipe/transcoder register addresses can easily break if we add a new > > transcoder. So remove

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add code comment on assumption of pipe==transcoder

2018-11-19 Thread Ville Syrjälä
On Mon, Nov 19, 2018 at 08:43:27PM +0200, Imre Deak wrote: > On Mon, Nov 19, 2018 at 05:51:31PM +0200, Ville Syrjälä wrote: > > On Mon, Nov 19, 2018 at 04:41:09PM +0200, Imre Deak wrote: > > > Add a comment to the pipe and transcoder enum definitions about our > > > assumption in the code that

[Intel-gfx] [PATCH v2 2/3] drm/i915: Make EDP PSR flags not depend on enum values

2018-11-19 Thread Imre Deak
Depending on the transcoder enum values to translate from transcoder to EDP PSR flags can easily break if we add a new transcoder. So remove the dependency by using an explicit mapping. While at it also add a WARN for unexpected trancoders. v2: - Simplify things by defining flag shift values

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Make EDP PSR flags not depend on enum values

2018-11-19 Thread Ville Syrjälä
On Mon, Nov 19, 2018 at 10:46:37PM +0200, Imre Deak wrote: > Depending on the transcoder enum values to translate from transcoder > to EDP PSR flags can easily break if we add a new transcoder. So remove > the dependency by using an explicit mapping. > > While at it also add a WARN for unexpected

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values (rev2)

2018-11-19 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values (rev2) URL : https://patchwork.freedesktop.org/series/52693/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5165 -> Patchwork_10853 = == Summary -