XEHPSDV and DG2/ATS-M allow media IP blocks to run at frequencies different
from the GT frequency. i915 exposes sysfs controls for these frequency
multipliers. IGT's introduced in this patch exercise and verify these
per-gt (gt/gtN) sysfs controls starting with the media freq factor (factor
and
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev6)
URL : https://patchwork.freedesktop.org/series/102665/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11646 -> Patchwork_102665v6
On Thu, 12 May 2022 00:48:08 -0700, Tvrtko Ursulin wrote:
Hi Tvrtko,
> On 12/05/2022 00:15, Dixit, Ashutosh wrote:
> > On Tue, 10 May 2022 03:41:57 -0700, Andrzej Hajda wrote:
> >> On 10.05.2022 11:48, Tvrtko Ursulin wrote:
> >>> On 10/05/2022 10:39, Andrzej Hajda wrote:
> On 10.05.2022
All kmalloc'd kobjects need a kobject_put() to free memory. For example in
previous code, kobj_gt_release() never gets called. The requirement of
kobject_put() now results in a slightly different code organization.
v2: s/gtn/gt/ (Andi)
Fixes: b770bcfae9ad ("drm/i915/gt: create per-tile sysfs
Expose new sysfs to program and retrieve media freq factor. Factor values
of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point
representation (corresponding to integer values of 0, 128 and 256
respectively).
Media freq factor is converted to media_ratio_mode for GuC. It is
programmed
Each gt contains an independent instance of pcode. Extend pcode functions
to interface with pcode on different gt's. To avoid creating dependency of
display functionality on intel_gt, pcode function interfaces are exposed in
terms of uncore rather than intel_gt. Callers have been converted to pass
Extend pcode initialization to pcode on different gt's.
Cc: Tvrtko Ursulin
Cc: Jani Nikula
Signed-off-by: Ashutosh Dixit
---
drivers/gpu/drm/i915/i915_driver.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_driver.c
From: Dale B Stimson
Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt
sysfs. This patch adds the following files to gt/gtN sysfs:
* media_RP0_freq_mhz
* media_RPn_freq_mhz
v2: Fixed commit author (Rodrigo)
v3: Convert to new uncore interface for pcode functions
v4: Adapt
Media ratio mode (the ability for media IP to work at a different frequency
from the GT) is available for a subset of dGfx platforms supporting
GuC/SLPC. Introduce 'has_media_ratio_mode' flag in intel_device_info to
identify these platforms and set it for XEHPSDV and DG2/ATS-M.
Signed-off-by:
Some recent Intel dGfx platforms allow media IP to work at a different
frequency from the base GT. This patch series exposes sysfs controls for
this functionality in the new per-gt sysfs. Some enhancements and fixes to
previous per-gt functionality are also included to complete the new
From: Dale B Stimson
Some dGfx pcode commands take additional sub-commands and parameters. Add a
couple of helpers to help formatting these commands to improve code
readability.
v2: Fixed commit author (Rodrigo)
v3: Function rename and convert to new uncore interface for pcode functions
== Series Details ==
Series: drm/i915/display: Add a separate crtc_enable hook for SKL+ (rev2)
URL : https://patchwork.freedesktop.org/series/103896/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11644_full -> Patchwork_103896v2_full
On Thu, May 12, 2022 at 03:26:00PM +0200, Nirmoy Das wrote:
> From: Bommu Krishnaiah
>
> Enable Tile4 tiling mode on platform that supports
> Tile4 but no TileY like DG2.
>
> v2: disable X-tile for iGPU in fastblit
> fix checkpath --strict warnings
>
> Signed-off-by: Bommu Krishnaiah
>
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev6)
URL : https://patchwork.freedesktop.org/series/102665/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Hi Dave & Daniel,
One fix for memory corruption under heavy load (#5732, Cc: stable).
Regards, Joonas
***
drm-intel-fixes-2022-05-12:
Fix for #5732: (Cc stable) kernel memory corruption when running a lot of
OpenCL tests in parallel
The following changes since commit
On 12/05/2022 00:15, Dixit, Ashutosh wrote:
On Tue, 10 May 2022 03:41:57 -0700, Andrzej Hajda wrote:
On 10.05.2022 11:48, Tvrtko Ursulin wrote:
On 10/05/2022 10:39, Andrzej Hajda wrote:
On 10.05.2022 10:18, Tvrtko Ursulin wrote:
Was there closure/agreement on the matter of whether or not
On 12/05/2022 05:38, Dixit, Ashutosh wrote:
On Wed, 11 May 2022 19:32:13 -0700, Ashutosh Dixit wrote:
Some recent Intel dGfx platforms allow media IP to work at a different
frequency from the base GT. This patch series exposes sysfs controls for
this functionality in the new per-gt sysfs.
On Wed, 11 May 2022, Manasi Navare wrote:
> Currently we reuse hsw_crtc_enable for SKL+ platforms.
> But this has added a lot of platform checks for SKL+ platforms.
> So its time to move the code to a separate crtc_enable hook
> for SKL+ platforms.
This leaves behind a ton of unused code paths
On 12/05/2022 03:32, Ashutosh Dixit wrote:
Each gt contains an independent instance of pcode. Extend pcode functions
to interface with pcode on different gt's. To avoid creating dependency of
display functionality on intel_gt, pcode function interfaces are exposed in
terms of uncore rather
Hi Daniel,
An update on this
On Thu, Apr 28, 2022 at 02:09:40PM +0200, Daniel Vetter wrote:
> > We integrated this in the (downstream) RaspberryPi kernel, and it seems
> > to trigger some weird regressions:
> >
> > - If we move the cursor under X, the primary plane update is stuck:
> >
Based on a bspec update the DMC firmware's flip queue handling events
need to be disabled before enabling DC5/6. i915 doesn't use the flip
queue feature atm, so disable it already after loading the firmware.
This removes some overhead of the event handler which runs at a 1 kHz
frequency.
Bspec:
In vma destruction, the following race may occur:
Thread 1: Thread 2:
i915_vma_destroy();
...
list_del_init(vma->vm_link);
...
mutex_unlock(vma->vm->mutex);
__i915_vm_release();
release_references();
And in release_reference() we
From: Bommu Krishnaiah
Enable Tile4 tiling mode on platform that supports
Tile4 but no TileY like DG2.
v2: disable X-tile for iGPU in fastblit
fix checkpath --strict warnings
Signed-off-by: Bommu Krishnaiah
Co-developed-by: Nirmoy Das
Signed-off-by: Nirmoy Das
---
On Wed, 11 May 2022, Ashutosh Dixit wrote:
> Each gt contains an independent instance of pcode. Extend pcode functions
> to interface with pcode on different gt's. To avoid creating dependency of
> display functionality on intel_gt, pcode function interfaces are exposed in
> terms of uncore
On 11/05/2022 19:38, Maarten Lankhorst wrote:
Op 11-05-2022 om 20:23 schreef Matthew Auld:
On 11/05/2022 12:52, Maarten Lankhorst wrote:
Instead of its own path, use the common path when it doesn't result
in evicting any vma. This fixes the case where we don't wait for
binding.
Need to use pipe_name(pipe) instead of pipe directly.
Fixes: 1f31e35f2e88 ("drm/i915/audio: unify audio codec enable/disable debug
logging")
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_audio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On Thu, 12 May 2022 03:36:31 -0700, Jani Nikula wrote:
>
Hi Jani,
> On Wed, 11 May 2022, Ashutosh Dixit wrote:
> > Each gt contains an independent instance of pcode. Extend pcode functions
> > to interface with pcode on different gt's. To avoid creating dependency of
> > display functionality
On Thu, May 12, 2022 at 12:37:05PM +0300, Imre Deak wrote:
Based on a bspec update the DMC firmware's flip queue handling events
need to be disabled before enabling DC5/6. i915 doesn't use the flip
queue feature atm, so disable it already after loading the firmware.
This removes some overhead of
On Thu, 5 May 2022 21:08:38 -0300
Jason Gunthorpe wrote:
> Prior series have transformed other parts of VFIO from working on struct
> device or struct vfio_group into working directly on struct
> vfio_device. Based on that work we now have vfio_device's readily
> available in all the drivers.
>
== Series Details ==
Series: drm/i915/audio: fix audio code enable/disable pipe logging
URL : https://patchwork.freedesktop.org/series/103943/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11643 -> Patchwork_103943v1
== Series Details ==
Series: drm/i915: Fix vm use-after-free in vma destruction
URL : https://patchwork.freedesktop.org/series/103922/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11642 -> Patchwork_103922v1
Summary
== Series Details ==
Series: drm/i915: Enable Tile4 tiling mode (rev2)
URL : https://patchwork.freedesktop.org/series/103881/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11643 -> Patchwork_103881v2
Summary
---
On Thu, May 12, 2022 at 07:16:38PM +0300, Jani Nikula wrote:
> Need to use pipe_name(pipe) instead of pipe directly.
>
> Fixes: 1f31e35f2e88 ("drm/i915/audio: unify audio codec enable/disable debug
> logging")
> Cc: Ville Syrjälä
> Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
> ---
== Series Details ==
Series: drm/i915/d12+: Disable DMC firmware flip queue handlers (rev2)
URL : https://patchwork.freedesktop.org/series/103888/
State : warning
== Summary ==
Error: dim checkpatch failed
70a1baba7fa9 drm/i915/d12+: Disable DMC firmware flip queue handlers
-:156:
== Series Details ==
Series: drm/i915/d12+: Disable DMC firmware flip queue handlers (rev2)
URL : https://patchwork.freedesktop.org/series/103888/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11642 -> Patchwork_103888v2
== Series Details ==
Series: drm/i915: Fix vm use-after-free in vma destruction
URL : https://patchwork.freedesktop.org/series/103922/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11642_full -> Patchwork_103922v1_full
== Series Details ==
Series: drm/i915/d12+: Disable DMC firmware flip queue handlers (rev2)
URL : https://patchwork.freedesktop.org/series/103888/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11642_full -> Patchwork_103888v2_full
On Thu, 12 May 2022 00:59:11 -0700, Tvrtko Ursulin wrote:
Hi Tvrtko,
> On 12/05/2022 05:38, Dixit, Ashutosh wrote:
> > On Wed, 11 May 2022 19:32:13 -0700, Ashutosh Dixit wrote:
> >>
> >> Some recent Intel dGfx platforms allow media IP to work at a different
> >> frequency from the base GT. This
On Thu, May 12, 2022 at 10:56:11AM -0700, Lucas De Marchi wrote:
> On Thu, May 12, 2022 at 12:37:05PM +0300, Imre Deak wrote:
> > Based on a bspec update the DMC firmware's flip queue handling events
> > need to be disabled before enabling DC5/6. i915 doesn't use the flip
> > queue feature atm, so
On Thu, May 12, 2022 at 12:45:09PM +0300, Jani Nikula wrote:
> On Wed, 11 May 2022, Manasi Navare wrote:
> > Currently we reuse hsw_crtc_enable for SKL+ platforms.
> > But this has added a lot of platform checks for SKL+ platforms.
> > So its time to move the code to a separate crtc_enable hook
>
Currently we reuse hsw_crtc_enable for SKL+ platforms.
But this has added a lot of platform checks for SKL+ platforms.
So its time to move the code to a separate crtc_enable hook
for SKL+ platforms.
No functional changes here.
v2: Cleanup hsw_crtc_enable (Jani N)
Suggested-by: Jani Nikula
Cc:
== Series Details ==
Series: drm/i915/audio: fix audio code enable/disable pipe logging
URL : https://patchwork.freedesktop.org/series/103943/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11643_full -> Patchwork_103943v1_full
== Series Details ==
Series: drm/i915: Enable Tile4 tiling mode (rev2)
URL : https://patchwork.freedesktop.org/series/103881/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11643_full -> Patchwork_103881v2_full
Summary
On May 12, 2022 2:17:04 PM PDT, Nathan Chancellor wrote:
>When an attribute group is created with sysfs_create_group(), the
>->sysfs_ops() callback is set to kobj_sysfs_ops, which sets the ->show()
>callback to kobj_attr_show(). kobj_attr_show() uses container_of() to
>get the ->show()
== Series Details ==
Series: drm/i915/display: Add a separate crtc_enable hook for SKL+ (rev2)
URL : https://patchwork.freedesktop.org/series/103896/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11644 -> Patchwork_103896v2
On Thu, May 12, 2022 at 10:47:46PM +0300, Imre Deak wrote:
On Thu, May 12, 2022 at 10:56:11AM -0700, Lucas De Marchi wrote:
On Thu, May 12, 2022 at 12:37:05PM +0300, Imre Deak wrote:
> Based on a bspec update the DMC firmware's flip queue handling events
> need to be disabled before enabling
46 matches
Mail list logo
