[PATCH 5/6] drm/i915: Handle joined pipes inside hsw_crtc_enable()

2024-03-18 Thread Stanislav Lisovskiy
Handle only bigjoiner masters in skl_commit_modeset_enables/disables, slave crtcs should be handled by master hooks. Same for encoders. That way we can also remove a bunch of checks like intel_crtc_is_bigjoiner_slave. v2: - Moved skl_pfit_enable, intel_dsc_enable, intel_crtc_vblank_on to intel_e

Re: [PATCH] drm/i915: Do not match JSL in ehl_combo_pll_div_frac_wa_needed()

2024-03-18 Thread Jani Nikula
On Wed, 13 Mar 2024, Jani Nikula wrote: > On Wed, 13 Mar 2024, Jonathon Hall wrote: >> Since commit 0c65dc062611 ("drm/i915/jsl: s/JSL/JASPERLAKE for >> platform/subplatform defines"), boot freezes on a Jasper Lake tablet >> (Librem 11), usually with graphical corruption on the eDP display, >> bu

[PATCH i-g-t v3 0/5] lib/kunit: Execute test cases synchronously

2024-03-18 Thread Janusz Krzysztofik
Up to now we were loading a KUnit test module in test execution mode only once per subtest, in background, and then, in parallel with execution of test cases while the module was loading, we were looking through dmesg for KTAP results from each expected test case. As a consequence, our IGT message

[PATCH i-g-t v3 1/5] lib/kunit: Store igt_ktap_results pointer in a central location

2024-03-18 Thread Janusz Krzysztofik
To give more freedom to future enhancements of KUnit library (legacy path excluded) in using IGT fails and skips, maintain a pointer to struct igt_ktap_results, allocated by several functions, in a single central location, and free it from a closing igt_fixture section before return. Signed-off-by

[PATCH i-g-t v3 3/5] lib/kunit: Time out promptly on missing KTAP report

2024-03-18 Thread Janusz Krzysztofik
If a test provides a subtest name that doesn't match any test suites provided by the requested KUnit test module then no KTAP report appears in dmesg, not even an empty one as one may expect. As a consequence, we now loop endlessly around reading potential lines of the missing report from /dev/kms

[PATCH i-g-t v3 4/5] lib/kunit: Execute test cases synchronously

2024-03-18 Thread Janusz Krzysztofik
Up to now we were loading a KUnit test module in test execution mode only once per subtest, in background, and then, in parallel with execution of test cases while the module was loading, we were looking through dmesg for KTAP results from each expected test case. As a consequence, our IGT message

[PATCH i-g-t v3 2/5] lib/kunit: Let igt_ktap_free() take care of pointer reset

2024-03-18 Thread Janusz Krzysztofik
Users who store a pointer to struct igt_ktap_results, obtained from igt_ktap_alloc(), in a central location and then call igt_ktap_free() when no longer needed, now have to reset that pointer to NULL to avoid double free on final cleanup. For their convenience, teach igt_ktap_free() to accept that

[PATCH i-g-t v3 5/5] lib/kunit: Minimize code duplication

2024-03-18 Thread Janusz Krzysztofik
A new helper has been introduced recently, used for fetching KTAP results of a single test case. Since that helper is called for that purpose only after the test module is loaded with all other test cases filtered out, its actual implementation is as simple as collecting all results from a single

Re: drm/i915/dp: Enable AUX based backlight for HDR

2024-03-18 Thread Sebastian Wick
On Fri, Mar 15, 2024 at 01:56:19PM +0200, Ville Syrjälä wrote: > On Fri, Mar 15, 2024 at 12:33:52PM +0100, Sebastian Wick wrote: > > On Fri, Mar 15, 2024 at 10:35:30AM +0530, Suraj Kandpal wrote: > > > > @@ -318,11 +346,24 @@ intel_dp_aux_hdr_setup_backlight(struct > > > intel_connector *connecto

[PATCH] drm/xe/display: fix potential overflow when multiplying 2 u32

2024-03-18 Thread Arun R Murthy
Multiplying XE_PAGE_SIZE with another u32 and the product stored in u64 can potentially lead to overflow, use mul_u32_u32 instead. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/xe/display/xe_fb_pin.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v19 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-18 Thread Mitul Golani
Compute vrr_vsync_start/end, which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit) - Updated bit fields of VRR_VSYNC_START/END. (Ankit) --v3: - Add PIPE_CONF_CHECK_I(vrr.

Re: [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off

2024-03-18 Thread Dolan Liu
this case have been there so many years, it's time to fix it if possible. And user-space software may improved by themselves in we didn't realize place. even if not,  for the proof user-space setting  0, it's better to change to    if (level < min || level == 0 )    level =max; Int

Re: [PATCH] drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c

2024-03-18 Thread Vivi, Rodrigo
On Thu, 2024-03-14 at 14:48 +0200, Joonas Lahtinen wrote: > Quoting Rodrigo Vivi (2024-03-08 16:58:04) > > On Fri, Mar 08, 2024 at 04:46:43PM +0200, Joonas Lahtinen wrote: > > > Add standalone includes for BUG_ON and BUILD_BUG_ON to avoid > > > build failure > > > after linux-next include refactori

[PATCH v3 0/4] drm/i915/display: DMC wakelock implementation

2024-03-18 Thread Luca Coelho
Hi, This is the fifth version of my series, the third as a proper patchset. These are the changes: In v3: * Fixed some checkpatch issues. In v2: * Enable/disable the wakelocks on DC5-6 entry and exit instead of on DMC load and unload; * Added bspec link to the commit message; * A b

[PATCH v3 1/4] drm/i915/display: add support for DMC wakelocks

2024-03-18 Thread Luca Coelho
In order to reduce the DC5->DC2 restore time, wakelocks have been introduced in DMC so the driver can tell it when registers and other memory areas are going to be accessed and keep their respective blocks awake. Implement this in the driver by adding the concept of DMC wakelocks. When the driver

[PATCH v3 2/4] drm/i915/display: don't allow DMC wakelock on older hardware

2024-03-18 Thread Luca Coelho
Only allow running DMC wakelock code if the display version is 20 or greater. Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_dmc_wl.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dmc_wl.c b/drivers/gpu/drm/i915/display/i

[PATCH v3 3/4] drm/i915/display: add module parameter to enable DMC wakelock

2024-03-18 Thread Luca Coelho
This feature should be disabled by default until properly tested and mature. Add a module parameter to enable the feature for testing, while keeping it disabled by default for now. Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 5 + drivers/gpu/drm/i91

[PATCH v3 4/4] drm/i915/display: tie DMC wakelock to DC5/6 state transitions

2024-03-18 Thread Luca Coelho
We only need DMC wakelocks when we allow DC5 and DC6 states. Add the calls to enable and disable DMC wakelock accordingly. Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_power_well.c | 7 +++ drivers/gpu/drm/i915/display/intel_dmc.c| 4 2 file

Re: [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off

2024-03-18 Thread Jani Nikula
On Mon, 18 Mar 2024, Dolan Liu wrote: > this case have been there so many years, it's time to fix it if > possible. And user-space software may improved by themselves in we > didn't realize place. > > even if not,  for the proof user-space setting  0, it's better to change to > > >    if (level

[PATCH] drm/i915/gt: Reset queue_priority_hint on parking

2024-03-18 Thread Janusz Krzysztofik
From: Chris Wilson Originally, with strict in order execution, we could complete execution only when the queue was empty. Preempt-to-busy allows replacement of an active request that may complete before the preemption is processed by HW. If that happens, the request is retired from the queue, but

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-03-18 Thread Jani Nikula
On Mon, 11 Mar 2024, Mitul Golani wrote: > An Adaptive-Sync-capable DP protocol converter indicates its > support by setting the related bit in the DPCD register. This > is valid for DP and edp as well. > > Computes AS SDP values based on the display configuration, > ensuring proper handling of V

Re: [PATCH v4] Fix divide-by-zero regression on DP MST unplug with nouveau

2024-03-18 Thread Imre Deak
On Sat, Mar 16, 2024 at 12:05:59PM +, Chris Bainbridge wrote: > Fix a regression when using nouveau and unplugging a StarTech MSTDP122DP > DisplayPort 1.2 MST hub (the same regression does not appear when using > a Cable Matters DisplayPort 1.4 MST hub). Trace: Thanks for the report and fix, p

[PATCH] drm/i915/mtl: Add Wa_14020495402

2024-03-18 Thread Radhakrishna Sripada
Disable clockgating for TDL SVHS fub. Bspec: 46045 Cc: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.

Re: [PATCH] drm/i915/mtl: Add Wa_14020495402

2024-03-18 Thread Matt Roper
On Mon, Mar 18, 2024 at 12:35:58PM -0700, Radhakrishna Sripada wrote: > Disable clockgating for TDL SVHS fub. > > Bspec: 46045 > Cc: Matt Roper > Signed-off-by: Radhakrishna Sripada > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + > drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++

Re: [PATCH] drm/i915/gt: Reset queue_priority_hint on parking

2024-03-18 Thread Rodrigo Vivi
On Mon, Mar 18, 2024 at 02:58:47PM +0100, Janusz Krzysztofik wrote: > From: Chris Wilson > > Originally, with strict in order execution, we could complete execution > only when the queue was empty. Preempt-to-busy allows replacement of an > active request that may complete before the preemption i

✗ Fi.CI.CHECKPATCH: warning for Bigjoiner refactoring (rev12)

2024-03-18 Thread Patchwork
== Series Details == Series: Bigjoiner refactoring (rev12) URL : https://patchwork.freedesktop.org/series/128311/ State : warning == Summary == Error: dim checkpatch failed f7402570def3 drm/i915: Add a small helper to compute the set of pipes for crtc 7a0f16bdaae4 drm/i915: Extract intel_ddi_p

✗ Fi.CI.SPARSE: warning for Bigjoiner refactoring (rev12)

2024-03-18 Thread Patchwork
== Series Details == Series: Bigjoiner refactoring (rev12) URL : https://patchwork.freedesktop.org/series/128311/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warni

[PATCH v3 0/2] drm: Add plane SIZE_HINTS property

2024-03-18 Thread Ville Syrjala
From: Ville Syrjälä Final final version I hope. Mainly for CI to test against the new IGTs. Real userspace implementation: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3165 IGT: https://patchwork.freedesktop.org/series/131199

[PATCH v3 1/2] drm: Introduce plane SIZE_HINTS property

2024-03-18 Thread Ville Syrjala
From: Ville Syrjälä Add a new immutable plane property by which a plane can advertise a handful of recommended plane sizes. This would be mostly exposed by cursor planes as a slightly more capable replacement for the DRM_CAP_CURSOR_WIDTH/HEIGHT caps, which can only declare a one size fits all lim

[PATCH v3 2/2] drm/i915: Add SIZE_HINTS property for cursors

2024-03-18 Thread Ville Syrjala
From: Ville Syrjälä Advertize more suitable cursor sizes via the new SIZE_HINTS plane property. We can't really enumerate all supported cursor sizes on the platforms where the cursor height can vary freely, so for simplicity we'll just expose all square+POT sizes between each platform's min and

✗ Fi.CI.BAT: failure for Bigjoiner refactoring (rev12)

2024-03-18 Thread Patchwork
== Series Details == Series: Bigjoiner refactoring (rev12) URL : https://patchwork.freedesktop.org/series/128311/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14443 -> Patchwork_128311v12 Summary --- **FAILURE**

✗ Fi.CI.CHECKPATCH: warning for drm/xe/display: fix potential overflow when multiplying 2 u32 (rev2)

2024-03-18 Thread Patchwork
== Series Details == Series: drm/xe/display: fix potential overflow when multiplying 2 u32 (rev2) URL : https://patchwork.freedesktop.org/series/131014/ State : warning == Summary == Error: dim checkpatch failed 8f904ca289af drm/xe/display: fix potential overflow when multiplying 2 u32 -:20: W

[PATCH v2] drm/i915/xelpg: Add Wa_14020495402

2024-03-18 Thread Radhakrishna Sripada
Disable clockgating for TDL SVHS fub. v2: Implement in general render/compute wa's(MattR) Bspec: 46045 Cc: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +- 2 files changed, 6 insertions

✗ Fi.CI.BUILD: failure for Enable Adaptive Sync SDP Support for DP (rev19)

2024-03-18 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev19) URL : https://patchwork.freedesktop.org/series/126829/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/126829/revisions/19/mbox/ not applied Applying: drm/dp: Add support

✓ Fi.CI.BAT: success for drm/xe/display: fix potential overflow when multiplying 2 u32 (rev2)

2024-03-18 Thread Patchwork
== Series Details == Series: drm/xe/display: fix potential overflow when multiplying 2 u32 (rev2) URL : https://patchwork.freedesktop.org/series/131014/ State : success == Summary == CI Bug Log - changes from CI_DRM_14443 -> Patchwork_131014v2 ==

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: DMC wakelock implementation (rev2)

2024-03-18 Thread Patchwork
== Series Details == Series: drm/i915/display: DMC wakelock implementation (rev2) URL : https://patchwork.freedesktop.org/series/131124/ State : warning == Summary == Error: dim checkpatch failed eaf8c75d8c52 drm/i915/display: add support for DMC wakelocks Traceback (most recent call last):

✗ Fi.CI.SPARSE: warning for drm/i915/display: DMC wakelock implementation (rev2)

2024-03-18 Thread Patchwork
== Series Details == Series: drm/i915/display: DMC wakelock implementation (rev2) URL : https://patchwork.freedesktop.org/series/131124/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/i915/display: DMC wakelock implementation (rev2)

2024-03-18 Thread Patchwork
== Series Details == Series: drm/i915/display: DMC wakelock implementation (rev2) URL : https://patchwork.freedesktop.org/series/131124/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14443 -> Patchwork_131124v2 Summary

Re: [PATCH v2] drm/i915/xelpg: Add Wa_14020495402

2024-03-18 Thread Matt Roper
On Mon, Mar 18, 2024 at 02:00:25PM -0700, Radhakrishna Sripada wrote: > Disable clockgating for TDL SVHS fub. > > v2: Implement in general render/compute wa's(MattR) > > Bspec: 46045 > Cc: Matt Roper > Signed-off-by: Radhakrishna Sripada Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Reset queue_priority_hint on parking

2024-03-18 Thread Patchwork
== Series Details == Series: drm/i915/gt: Reset queue_priority_hint on parking URL : https://patchwork.freedesktop.org/series/131268/ State : warning == Summary == Error: dim checkpatch failed e1d8aba7c160 drm/i915/gt: Reset queue_priority_hint on parking -:19: WARNING:COMMIT_LOG_LONG_LINE: Pr

✓ Fi.CI.BAT: success for drm/i915/gt: Reset queue_priority_hint on parking

2024-03-18 Thread Patchwork
== Series Details == Series: drm/i915/gt: Reset queue_priority_hint on parking URL : https://patchwork.freedesktop.org/series/131268/ State : success == Summary == CI Bug Log - changes from CI_DRM_14443 -> Patchwork_131268v1 Summary ---

✓ Fi.CI.BAT: success for drm/i915/mtl: Add Wa_14020495402

2024-03-18 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Wa_14020495402 URL : https://patchwork.freedesktop.org/series/131284/ State : success == Summary == CI Bug Log - changes from CI_DRM_14443 -> Patchwork_131284v1 Summary --- **SUCCESS**

✗ Fi.CI.SPARSE: warning for drm: Add plane SIZE_HINTS property (rev6)

2024-03-18 Thread Patchwork
== Series Details == Series: drm: Add plane SIZE_HINTS property (rev6) URL : https://patchwork.freedesktop.org/series/113758/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm: Add plane SIZE_HINTS property (rev6)

2024-03-18 Thread Patchwork
== Series Details == Series: drm: Add plane SIZE_HINTS property (rev6) URL : https://patchwork.freedesktop.org/series/113758/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14443 -> Patchwork_113758v6 Summary --- **FA

✗ Fi.CI.BAT: failure for drm/i915/xelpg: Add Wa_14020495402

2024-03-18 Thread Patchwork
== Series Details == Series: drm/i915/xelpg: Add Wa_14020495402 URL : https://patchwork.freedesktop.org/series/131291/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14443 -> Patchwork_131291v1 Summary --- **FAILURE**

RE: [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off

2024-03-18 Thread Yu, Gareth
https://patchwork.freedesktop.org/patch/582411/?series=130780&rev=2 provides the scenario and the details of DMESG in the commit message on rev#1. I'll assume we'll go with rev#2. Thanks, Gareth -Original Message- From: Jani Nikula Sent: Monday, March 18, 2024 9:45 PM To: Dolan Liu ;

[PATCH] drm/xe/display: check for error on drmm_mutex_init

2024-03-18 Thread Arun R Murthy
Check return value for drmm_mutex_init as it can fail and return on failure. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/xe/display/xe_display.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/g

RE: ✗ Fi.CI.BAT: failure for drm/i915/xelpg: Add Wa_14020495402

2024-03-18 Thread Sripada, Radhakrishna
The failures are not related to the changes made. Regards, Radhakrishna Sripada From: Patchwork Sent: Monday, March 18, 2024 5:15 PM To: Sripada, Radhakrishna Cc: intel-gfx@lists.freedesktop.org Subject: ✗ Fi.CI.BAT: failure for drm/i915/xelpg: Add Wa_14020495402 Patch Details Series: drm/i915

✗ Fi.CI.BAT: failure for drm/xe/display: check for error on drmm_mutex_init

2024-03-18 Thread Patchwork
== Series Details == Series: drm/xe/display: check for error on drmm_mutex_init URL : https://patchwork.freedesktop.org/series/131301/ State : failure == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_131301v1 Summary --

Re: [PATCH v3 1/2] drm: Introduce plane SIZE_HINTS property

2024-03-18 Thread kernel test robot
Hi Ville, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8 next-20240319] [If your patch is applied to the wrong git tr