[Intel-gfx] [PATCH 1/2] drm: support routines for HDMI/DP ELD

2011-09-05 Thread Wu Fengguang
ELD (EDID-Like Data) describes to the HDMI/DP audio driver the audio capabilities of the plugged monitor. This adds drm_edid_to_eld() for converting EDID to ELD. The converted ELD will be saved in a new drm_connector.eld[128] data field. This is necessary because the graphics driver will need to

[Intel-gfx] [PATCH 2/2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
Add ELD support for Intel Eaglelake, IbexPeak/Ironlake, SandyBridge/CougarPoint and IvyBridge/PantherPoint chips. ELD (EDID-Like Data) describes to the HDMI/DP audio driver the audio capabilities of the plugged monitor. It's built and passed to audio driver in 2 steps: (1) at get_modes time,

Re: [Intel-gfx] [PATCH 2/3] drm/i915: close PM interrupt masking races in the rps work func

2011-09-05 Thread Daniel Vetter
On Sun, Sep 04, 2011 at 09:38:56PM +, Ben Widawsky wrote: Oops, you're totally right, I think I meant: - I915_WRITE(GEN6_PMIMR, pm_imr ~pm_iir); + I915_WRITE(GEN6_PMIMR, dev_priv-pm_iir); Imo still racy without the irqsafe rps_lock around it. gcc is free to compile that into a

Re: [Intel-gfx] [PATCH 2/2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
I'd like to do more cleanups: + int aud_cntl_st; + int aud_cntrl_st2; s/aud_cntrl_st2/aud_cntl_st2/ + if (IS_IVYBRIDGE(connector-dev)) { + hdmiw_hdmiedid = GEN7_HDMIW_HDMIEDID_A; + aud_cntl_st = GEN7_AUD_CNTRL_ST_A; + aud_cntrl_st2 =

Re: [Intel-gfx] [PATCH 2/3] drm/i915: close PM interrupt masking races in the rps work func

2011-09-05 Thread Ben Widawsky
On Mon, 5 Sep 2011 08:38:07 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Sun, Sep 04, 2011 at 09:38:56PM +, Ben Widawsky wrote: Oops, you're totally right, I think I meant: - I915_WRITE(GEN6_PMIMR, pm_imr ~pm_iir); + I915_WRITE(GEN6_PMIMR, dev_priv-pm_iir); Imo still

[Intel-gfx] [PATCH 2/2 v2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
Add ELD support for Intel Eaglelake, IbexPeak/Ironlake, SandyBridge/CougarPoint and IvyBridge/PantherPoint chips. ELD (EDID-Like Data) describes to the HDMI/DP audio driver the audio capabilities of the plugged monitor. It's built and passed to audio driver in 2 steps: (1) at get_modes time,

Re: [Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-05 Thread Ben Widawsky
On Sun, 4 Sep 2011 20:52:42 -0700 Ben Widawsky b...@bwidawsk.net wrote: While I think the previous code is correct, it was hard to follow and hard to debug. Since we already have a ring abstraction, might as well use it to handle the semaphore updates and compares. I don't expect this code

[Intel-gfx] [PATCH] drm/i915: properly cancel rps_work on module unload

2011-09-05 Thread Daniel Vetter
The rps disabling code wasn't properly cancelling outstanding work items. Also add a comment that explains why we're not racing with the work item that could unmask interrupts - that piece of code confused me quite a bit. v2: Ben Widawsky pointed out that the first patch would deadlock (and a few

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Chris Wilson
On Mon, 5 Sep 2011 09:14:00 +0800, Wu Fengguang fengguang...@intel.com wrote: On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote: On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang fengguang...@intel.com wrote: This patch should be split between adding the core drm functionality to

Re: [Intel-gfx] [PATCH 2/3] drm/i915: close PM interrupt masking races in the rps work func

2011-09-05 Thread Chris Wilson
On Sun, 4 Sep 2011 23:51:52 -0700, Ben Widawsky b...@bwidawsk.net wrote: On Mon, 5 Sep 2011 08:38:07 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Sun, Sep 04, 2011 at 09:38:56PM +, Ben Widawsky wrote: Oops, you're totally right, I think I meant: - I915_WRITE(GEN6_PMIMR,

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
On Mon, Sep 05, 2011 at 07:04:50PM +0800, Chris Wilson wrote: On Mon, 5 Sep 2011 09:14:00 +0800, Wu Fengguang fengguang...@intel.com wrote: On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote: On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang fengguang...@intel.com wrote:

Re: [Intel-gfx] [Xen-devel] Intel IGP VGA-passthrough to Ubuntu 11.04/openSUSE domU doesn't quite work

2011-09-05 Thread Martin Meier
On Mon, Aug 29, 2011 at 9:36 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Mon, Aug 29, 2011 at 05:50:23PM +0200, Martin Meier wrote: Hi, when comparing the dmesgs from a Ubuntu 11.04+xorg-edgers-ppa running on real hardware ver. running in a HVM-domU, I see this change in dmesg:

Re: [Intel-gfx] [PATCH] drm/i915: properly cancel rps_work on module unload

2011-09-05 Thread Ben Widawsky
On Mon, 5 Sep 2011 10:15:28 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: The rps disabling code wasn't properly cancelling outstanding work items. Also add a comment that explains why we're not racing with the work item that could unmask interrupts - that piece of code confused me quite

[Intel-gfx] [PATCH] intel_gpu_mon: continous CPU, GPU and power monitoring tool.

2011-09-05 Thread Eugeni Dodonov
From: Eugeni Dodonov eugeni.dodo...@intel.com This tool is based on ideas from intel_gpu_top, top and powertop applications, combining them into one continous profiler which generates human-readable output further processable by gnuplot and similar applications. It can be used either in

Re: [Intel-gfx] [PATCH] intel_gpu_mon: continous CPU, GPU and power monitoring tool.

2011-09-05 Thread Chris Wilson
On Mon, 5 Sep 2011 14:56:42 -0300, Eugeni Dodonov eug...@dodonov.net wrote: From: Eugeni Dodonov eugeni.dodo...@intel.com This tool is based on ideas from intel_gpu_top, top and powertop applications, combining them into one continous profiler which generates human-readable output further

Re: [Intel-gfx] [PATCH] intel_gpu_mon: continous CPU, GPU and power monitoring tool.

2011-09-05 Thread Eugeni Dodonov
On Mon, Sep 5, 2011 at 15:22, Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, 5 Sep 2011 14:56:42 -0300, Eugeni Dodonov eug...@dodonov.net wrote: From: Eugeni Dodonov eugeni.dodo...@intel.com This tool is based on ideas from intel_gpu_top, top and powertop applications, combining

[Intel-gfx] [PATCH] drm/i915: Enable dither whenever display bpc frame buffer bpc

2011-09-05 Thread Keith Packard
We want to enable dithering on any pipe where the frame buffer has more color resolution than the output device. The previous code was incorrectly clamping the frame buffer bpc to the display bpc, effectively disabling dithering all of the time as the computed frame buffer bpc would never be

[Intel-gfx] [PATCH 0/6] additional intel_gpu_top profiling features

2011-09-05 Thread Eugeni Dodonov
From: Eugeni Dodonov eugeni.dodo...@intel.com This patchset adds a number of small but useful features into intel_gpu_top tool, as asked by Chris Wilson: - support for getopt to customize internal parameters at runtime (such as number of samplings per second). - possibility of

[Intel-gfx] [PATCH 1/6] intel_gpu_top: account for time spent in syscalls

2011-09-05 Thread Eugeni Dodonov
From: Eugeni Dodonov eugeni.dodo...@intel.com This allows intel_gpu_top to properly account for time spent inside system calls. Effectively, with previous implementation, intel_gpu_top could spent longer than 1s between consecutive measures. This attempts to minimize the extra time spent while

[Intel-gfx] [PATCH 2/6] intel_gpu_top: suport command line parameters and variable samples per second

2011-09-05 Thread Eugeni Dodonov
From: Eugeni Dodonov eugeni.dodo...@intel.com This patch adds support for getopt, and adds two default parameters to it: -h to show usage notes; and -s to allow user to define number of samples to acquire per second. Manpage documentation is also adjusted accordingly. Signed-off-by: Eugeni

[Intel-gfx] [PATCH 3/6] intel_gpu_tool: initial support for non-screen output

2011-09-05 Thread Eugeni Dodonov
From: Eugeni Dodonov eugeni.dodo...@intel.com This patch adds initial support for non-stdio output, to be used for non-interactive monitoring. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- tools/intel_gpu_top.c | 28 +++- 1 files changed, 15 insertions(+),

[Intel-gfx] [PATCH 4/6] intel_gpu_top: initialize monitoring statistics at startup

2011-09-05 Thread Eugeni Dodonov
From: Eugeni Dodonov eugeni.dodo...@intel.com This patch initializes the last_stats[] for registers prior to starting the monitoring itself. This way, the first measure will already contain the difference from the previous value instead of non-initialized value. Signed-off-by: Eugeni Dodonov

[Intel-gfx] [PATCH 5/6] intel_gpu_top: support non-interactive mode

2011-09-05 Thread Eugeni Dodonov
From: Eugeni Dodonov eugeni.dodo...@intel.com This patch adds support for non-interactive mode, invoked by running with '-o output' switch. In this case, no interactive output is being performed, but the execution statistics are being saved into the output file. The output file is generated in

[Intel-gfx] [PATCH 6/6] intel_gpu_top: support profiling user-specified commands

2011-09-05 Thread Eugeni Dodonov
From: Eugeni Dodonov eugeni.dodo...@intel.com This patch adds support for running intel_gpu_top to profile specific commands. The required command will be carried out in separate process, and main intel_gpu_top will leave when the child process will exit. Signed-off-by: Eugeni Dodonov

Re: [Intel-gfx] [PATCH 2/6] intel_gpu_top: suport command line parameters and variable samples per second

2011-09-05 Thread Chris Wilson
On Mon, 5 Sep 2011 17:19:29 -0300, Eugeni Dodonov eug...@dodonov.net wrote: From: Eugeni Dodonov eugeni.dodo...@intel.com This patch adds support for getopt, and adds two default parameters to it: -h to show usage notes; and -s to allow user to define number of samples to acquire per

Re: [Intel-gfx] [PATCH 2/6] intel_gpu_top: suport command line parameters and variable samples per second

2011-09-05 Thread Eugeni Dodonov
On Mon, Sep 5, 2011 at 18:44, Chris Wilson ch...@chris-wilson.co.uk wrote: In the modules we own, we have adopted the kernel CODING_STYLE as our standard. 8 space indents, 80 cols line (except where readibility is improved by going over), braces on the same line as the control flow, Fixed,

Re: [Intel-gfx] [PATCH 3/6] intel_gpu_tool: initial support for non-screen output

2011-09-05 Thread Łukasz Kuryło
Is that really necessary? Isn't intel_gpu_tool logfile enough? signature.asc Description: This is a digitally signed message part. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/6] intel_gpu_tool: initial support for non-screen output

2011-09-05 Thread Łukasz Kuryło
My bad, it is necessary to add file. signature.asc Description: This is a digitally signed message part. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx