This is the functional backport of upstream commit
09ede5414f0215461c933032630bf9c3a61a8ba3 Original commit message
below. Backport has been tested by the bug reporter, please consider
applying to all stable kernels.
We need to track this correctly. While at it shovel the boolean
to track whether
This is the functional backport of upstream commit
09ede5414f0215461c933032630bf9c3a61a8ba3 Original commit message
below. Backport has been tested by the bug reporter, please consider
applying to all stable kernels.
We need to track this correctly. While at it shovel the boolean
to track whether
On Mon, Aug 05, 2013 at 06:02:32PM -0300, Paulo Zanoni wrote:
> 2013/8/5 Chris Wilson :
> > On Mon, Aug 05, 2013 at 05:25:55PM -0300, Paulo Zanoni wrote:
> >> From: Paulo Zanoni
> >>
> >> These messages are not really useful since it's very easy to check
> >> which mode is used for each port.
> >>
Like I've said in my previous mail I expect such discussions to be
hard and I also think stopping now and giving up is the wrong
approach. So another round.
On Tue, Aug 6, 2013 at 1:34 AM, Jesse Barnes wrote:
> On Tue, 6 Aug 2013 00:19:33 +0200
> Daniel Vetter wrote:
>> The only thing I read her
Hi Andrew,
Today's linux-next merge of the akpm tree got a conflict in
drivers/gpu/drm/i915/i915_gem.c between commit a70a3148b0c6 ("drm/i915:
Make proper functions for VMs") from the drm-intel tree and commit
e6950216e0af ("drivers: convert shrinkers to new count/scan API") from
the akpm tree.
I
From: Dave Airlie
Otherwise we'd fail saying DRI1 wasn't possible, when that
is exactly what we asked for.
Signed-off-by: Dave Airlie
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 104113e..88f29cc 100644
--- a/configure.a
> -Original Message-
> From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter
> Sent: Monday, August 05, 2013 1:42 PM
> To: Chris Wilson; Liu, Chuansheng; daniel.vet...@ffwll.ch; airl...@linux.ie;
> intel-gfx@lists.freedesktop.org; Li, Fei; dri-de...@lists.freedesk
On Tue, 6 Aug 2013 00:19:33 +0200
Daniel Vetter wrote:
> The only thing I read here, both in the paragraph above and in the
> rant is that we suck. I agree. My opinion is that this is because
> we've started late, had too few resources and didn't seriously
> estimate how much work is actually invo
On Thu, 1 Aug 2013 14:12:22 -0700
Furquan Shaikh wrote:
> @@ -1282,6 +1283,13 @@ static void intel_ddi_get_config(struct intel_encoder
> *encoder,
> flags |= DRM_MODE_FLAG_NVSYNC;
>
> pipe_config->adjusted_mode.flags |= flags;
> +
> + if (port == PORT_A) {
> +
On Mon, Aug 5, 2013 at 11:33 PM, Jesse Barnes wrote:
> On Sun, 4 Aug 2013 22:17:47 +0200
> Daniel Vetter wrote:
>> Imo the "unpredictable upstream" vs. "high quality kernel support in
>> upstream" is a false dichotomy. Afaics the "unpredictability" is _because_
>> I am not willing to compromise o
On Sun, 4 Aug 2013 22:17:47 +0200
Daniel Vetter wrote:
> Imo the "unpredictable upstream" vs. "high quality kernel support in
> upstream" is a false dichotomy. Afaics the "unpredictability" is _because_
> I am not willing to compromise on decent quality. I still claim that
> upstreaming is a fairl
On Mon, Aug 05, 2013 at 11:13:24PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> A bit more food for the cache discussions. My idea here is to track
> whether an object is part of any fb, and in case it is we assume it
> can be used for scanout, and thus may need some extr
2013/8/5 Chris Wilson :
> On Mon, Aug 05, 2013 at 05:25:55PM -0300, Paulo Zanoni wrote:
>> From: Paulo Zanoni
>>
>> These messages are not really useful since it's very easy to check
>> which mode is used for each port.
>>
> For those following along at home, a quick explanation of what to look
>
[Now without the confidential header which shouldn't have spilled to
public lists, please reply to this one here.]
On Mon, Aug 05, 2013 at 01:24:15PM -0700, Furquan Shaikh wrote:
> We tested the submitted patch on several systems here and it seems to be
> working fine. So, I'm not sure I understan
On Mon, Aug 05, 2013 at 05:25:55PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> These messages are not really useful since it's very easy to check
> which mode is used for each port.
>
For those following along at home, a quick explanation of what to look
for instead would be very useful.
On 05/08/2013 22:24, Furquan Shaikh wrote:
We tested the submitted patch on several systems here and it seems to
be working fine. So, I'm not sure I understand your comment. Can you
please provide more details?
You check for the bit DP_PLL_FREQ_160MHZ in the register DP_A when
calculating the
From: Paulo Zanoni
We set the mode based on the port, and we already pass the port as an
argument.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_ddi.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/
From: Paulo Zanoni
These messages are not really useful since it's very easy to check
which mode is used for each port.
Also, when we add the code to enable/disable PC8+,
intel_prepare_ddi_buffers will be called more often and will eat your
dmesg buffers.
While at it, fix the coding style of th
From: Ville Syrjälä
A bit more food for the cache discussions. My idea here is to track
whether an object is part of any fb, and in case it is we assume it
can be used for scanout, and thus may need some extra clflushes.
But otherwise we'd try to avoid clflushes on LLC plarforms.
I also included
On Fri, Aug 02, 2013 at 06:23:00PM +0100, Damien Lespiau wrote:
> All the HDMI infoframe code has been ported to use video/hdmi.c, so it's
> time to say bye bye to this code.
>
> Signed-off-by: Damien Lespiau
I'm no compiler, but fwiw:
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/
On Fri, Aug 02, 2013 at 06:22:59PM +0100, Damien Lespiau wrote:
> Signed-off-by: Damien Lespiau
> Signed-off-by: Paulo Zanoni
> Signed-off-by: Thierry Reding
Looks all right.
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_sdvo.c | 38 --
>
On Fri, Aug 02, 2013 at 06:22:58PM +0100, Damien Lespiau wrote:
> set_frame() wraps the write_frame() vfunc. Be consistent and name the
> wrapping function like the vfunc being called.
>
> It's doubly confusing as we also have a set_infoframes() vfunc and
> set_infoframe() doesn't wrap it.
I gues
On Fri, Aug 02, 2013 at 06:22:56PM +0100, Damien Lespiau wrote:
> First step in the move to the shared infoframe infrastructure, let's
> move the different infoframe helpers and the write_infoframe() vfunc to
> a type (enum hdmi_infoframe_type) and a buffer + len instead of using
> our struct dip_i
On Fri, Aug 02, 2013 at 06:22:55PM +0100, Damien Lespiau wrote:
> Cc: Thierry Reding
> Signed-off-by: Damien Lespiau
Reviewed-by: Ville Syrjälä
> ---
> include/linux/hdmi.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
> index 0f3f82e
On Fri, Aug 02, 2013 at 06:22:54PM +0100, Damien Lespiau wrote:
> And a way to pack hdmi_infoframe generically.
>
> Cc: Thierry Reding
> Signed-off-by: Damien Lespiau
> ---
> drivers/video/hdmi.c | 43 +++
> include/linux/hdmi.h | 17 +
>
On Mon, Aug 05, 2013 at 09:46:44AM -0700, Ben Widawsky wrote:
> The code itself is no longer accurate without updating once we have
> multiple address space since clearing the domains of every object
> requires scanning the inactive list for all VMs.
>
> "This code is dead. Just remove it rather t
On Fri, Aug 02, 2013 at 06:22:53PM +0100, Damien Lespiau wrote:
> Cc: Thierry Reding
> Signed-off-by: Damien Lespiau
Reviewed-by: Ville Syrjälä
> ---
> drivers/video/hdmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/hdmi.c b/drivers/video/hdm
The code itself is no longer accurate without updating once we have
multiple address space since clearing the domains of every object
requires scanning the inactive list for all VMs.
"This code is dead. Just remove it rather than port it to vma." - Chris
Wilson
Recommended-by: Chris Wilson
Signe
On Mon, Aug 05, 2013 at 06:25:54PM +0200, Daniel Vetter wrote:
> On Thu, Aug 01, 2013 at 03:23:56PM +0100, Chris Wilson wrote:
> > On Thu, Aug 01, 2013 at 04:18:50PM +0300, ville.syrj...@linux.intel.com
> > wrote:
> > > From: Ville Syrjälä
> > >
> > > Rather than having to read the latency value
On Fri, Aug 02, 2013 at 07:09:31PM +0300, Ville Syrjälä wrote:
> On Fri, Aug 02, 2013 at 12:58:07PM -0300, Paulo Zanoni wrote:
> > 2013/8/1 :
> > > From: Ville Syrjälä
> > >
> > > All the ILK+ WM compute functions take the latency values in 0.1us
> > > units. Add a few comments to remind people a
On Fri, Aug 02, 2013 at 11:48:29AM -0300, Paulo Zanoni wrote:
> 2013/8/1 :
> > From: Ville Syrjälä
> >
> > Return UINT_MAX for the calculated WM level if the latency is zero.
> > This will lead to marking the WM level as disabled.
> >
> > I'm not sure if latency==0 should mean that we want to dis
On Thu, Aug 01, 2013 at 03:23:56PM +0100, Chris Wilson wrote:
> On Thu, Aug 01, 2013 at 04:18:50PM +0300, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Rather than having to read the latency values out every time, just
> > store them in dev_priv.
> >
> > On ILK and IVB the
On Thu, Aug 01, 2013 at 04:18:39PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> For calculating watermarks we want to know whether sprites are
> scaled. Pass that information to update_sprite_watermarks() so that
> eventually we may do some watermark pre-computing.
>
> v
On Mon, Aug 5, 2013 at 3:04 PM, Chris Wilson wrote:
> On Mon, Aug 05, 2013 at 02:15:19PM +0200, Sedat Dilek wrote:
>> On Sun, Aug 4, 2013 at 2:08 PM, Sedat Dilek wrote:
>> > On Sun, Aug 4, 2013 at 1:53 PM, Sedat Dilek wrote:
>> >> Hi,
>> >>
>> >> I am here on Ubuntu/precise AMD64 and using the l
On Fri, Aug 02, 2013 at 04:22:24PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> If the power well is disabled VGA is guaranteed to be disabled.
>
> This fixes unclaimed register messages that happen on suspend/resume.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67517
> Sig
On Mon, Aug 05, 2013 at 05:57:48PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> The SDVO code tries to compare the encoder's and crtc's idea of the
> pixel_multiplier. Normally they have to match, but when transitioning
> to DPMS off, we turn off the pipe before reading o
On Mon, Aug 05, 2013 at 10:42:08AM -0300, Paulo Zanoni wrote:
> 2013/8/5 Daniel Vetter :
> > On Mon, Jul 29, 2013 at 05:53:27PM -0300, Paulo Zanoni wrote:
> >> From: Paulo Zanoni
> >>
> >> This test chekcs our code that enables Package C8+. The environment
> >> requirements for this test are quite
Hi,
wrt to $Subject, I get this with 3.10.5:
[4.342638] i915 :00:02.0: setting latency timer to 64
[4.409045] INFO: trying to register non-static key.
[4.409164] the code is fine but needs lockdep annotation.
[4.409278] turning off the locking correctness validator.
[4.409
On Mon, Aug 05, 2013 at 03:27:29PM +0200, Borislav Petkov wrote:
> On Mon, Aug 05, 2013 at 03:23:53PM +0200, Johannes Stezenbach wrote:
> > wrt to $Subject, I get this with 3.10.5:
> >
> > [4.342638] i915 :00:02.0: setting latency timer to 64
> > [4.409045] INFO: trying to register non
On Mon, Aug 05, 2013 at 03:23:53PM +0200, Johannes Stezenbach wrote:
> wrt to $Subject, I get this with 3.10.5:
>
> [4.342638] i915 :00:02.0: setting latency timer to 64
> [4.409045] INFO: trying to register non-static key.
> [4.409164] the code is fine but needs lockdep annotation
It's not actually Dan's coccinelle checker... He is just the (much
appreciated) messenger.
julia
On Mon, 5 Aug 2013, Daniel Vetter wrote:
Thanks for the report, I'll squash in the following fixup:
commit 36bf63c19eb46631fa4556ae54d91a5320a198b2
Author: Daniel Vetter
Date: Mon Aug 5 12:28
On Mon, Aug 05, 2013 at 01:06:35AM +0200, Daniel Vetter wrote:
> On Wed, Jul 31, 2013 at 6:22 PM, Borislav Petkov wrote:
> > Dudes,
> >
> > has anyone already reported this (happens on Linus of today +
> > tip/master):
>
> I think this should be fixed with
>
> commit e1b4d3036c07ff137955fb1c0197
Am Freitag, 26. Juli 2013, 14:40:58 schrieb Rafael J. Wysocki:
> On Friday, July 26, 2013 02:09:08 PM Martin Steigerwald wrote:
> > Am Donnerstag, 25. Juli 2013, 15:00:26 schrieb Rafael J. Wysocki:
> > > On Monday, July 22, 2013 09:54:21 PM Rafael J. Wysocki wrote:
> > > > On Monday, July 22, 2013
From: Ville Syrjälä
The SDVO code tries to compare the encoder's and crtc's idea of the
pixel_multiplier. Normally they have to match, but when transitioning
to DPMS off, we turn off the pipe before reading out the pipe_config,
so the pixel_multiplier in the pipe_config will be 0, whereas the
enc
2013/8/5 Daniel Vetter :
> On Mon, Jul 29, 2013 at 05:53:27PM -0300, Paulo Zanoni wrote:
>> From: Paulo Zanoni
>>
>> This test chekcs our code that enables Package C8+. The environment
>> requirements for this test are quite complicated:
>> - The machine needs to be properly configured to reach
2013/8/5 Daniel Vetter :
> On Tue, Jul 30, 2013 at 10:30:41AM +0100, Chris Wilson wrote:
>> On Mon, Jul 29, 2013 at 05:48:24PM -0300, Paulo Zanoni wrote:
>> > From: Paulo Zanoni
>> >
>> > If we're already allowing PC8, just don't use the IRQs, so we won't
>> > need to wake from PC8. Waking up from
On Fri, Aug 02, 2013 at 06:22:57PM +0100, Damien Lespiau wrote:
> Let's use the drivers/video/hmdi.c and drm infoframe helpers to build
> our infoframes.
>
> Signed-off-by: Damien Lespiau
> ---
> drivers/gpu/drm/i915/intel_hdmi.c | 94
> +--
> 1 file changed,
On Mon, Aug 05, 2013 at 02:15:19PM +0200, Sedat Dilek wrote:
> On Sun, Aug 4, 2013 at 2:08 PM, Sedat Dilek wrote:
> > On Sun, Aug 4, 2013 at 1:53 PM, Sedat Dilek wrote:
> >> Hi,
> >>
> >> I am here on Ubuntu/precise AMD64 and using the llvm/clang prebuilt
> >> toolchain from .
> >>
> >> From my b
Hi all,
I'm not using a docking station and would like to completely disable
all connectors / ports except the internal laptop monitor.
Can I do that with an option I pass to the driver through a kernel
commandline, or do I have to do this at compile time? If so, how?
I'd also be willing to pat
On Sun, Aug 4, 2013 at 2:08 PM, Sedat Dilek wrote:
> On Sun, Aug 4, 2013 at 1:53 PM, Sedat Dilek wrote:
>> Hi,
>>
>> I am here on Ubuntu/precise AMD64 and using the llvm/clang prebuilt
>> toolchain from .
>>
>> From my build.log:
>> ...
>> make[3]: Entering directory
>> `/home/wearefam/src/xserve
At the moment any command line option handling done by tests will
interfere with the option handling of the subtest interface. To fix this
add a new version of the subtest_init function accepting optional short
and long command line options. Merge these together with the subtest
interface's own lon
Based on irc discussions with Chris/Daniel we needed a new test case
that iterates through all clone output configurations, so this patchset
adds one.
I tested it on ilk, ivb, hsw. One case triggered a DP link training error
on ilk. Got some HW state readout/check WARNS on others. On my hsw
deskto
Signed-off-by: Imre Deak
---
lib/drmtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index d51f708..afbaa35 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -1309,7 +1309,7 @@ static int exit_handler_count;
static bool exit_handler_disable
Iterate through all valid/invalid crtc/connector combinations. At the
moment only clone configurations are tested as the single output cases
are tested already by testdisplay. Also from combinations where all
connectors are on the same crtc (clone-single-crtc) only those are
tested that are invalid
Signed-off-by: Imre Deak
---
lib/drmtest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index e599af7..d51f708 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -1254,11 +1254,11 @@ struct type_name connector_type_names[] = {
{ DRM_
Thanks for the report, I'll squash in the following fixup:
commit 36bf63c19eb46631fa4556ae54d91a5320a198b2
Author: Daniel Vetter
Date: Mon Aug 5 12:28:03 2013 +0200
fixup, reported by Dan Carpenter and his coccinelle checker
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/drivers/gpu/drm
On Sat, Aug 03, 2013 at 03:24:47PM -0700, Ben Widawsky wrote:
> On Sat, Aug 03, 2013 at 11:59:42AM +0100, Chris Wilson wrote:
> > On Wed, Jul 31, 2013 at 05:00:06PM -0700, Ben Widawsky wrote:
> > > Simply iterating over 1 inactive list is insufficient for the way we now
> > > track inactive (1 list
On Wed, Jul 31, 2013 at 05:00:04PM -0700, Ben Widawsky wrote:
> With multiple VMs, the eviction code benefits from being able to blindly
> put pages without needing to know if there are any entities still
> holding on to those pages. As such it's preferable to return the -EBUSY
> before the BUG.
>
On Wed, Jul 31, 2013 at 05:00:03PM -0700, Ben Widawsky wrote:
> For now, objects will maintain the same cache levels amongst all address
> spaces. This is to limit the risk of bugs, as playing with cacheability
> in the different domains can be very error prone.
>
> In the future, it may be optima
On Wed, Jul 31, 2013 at 05:00:02PM -0700, Ben Widawsky wrote:
> This represents the first half of hooking up VMs to execbuf. Here we
> basically pass an address space all around to the different internal
> functions. It should be much more readable, and have less risk than the
> second half, which
On Wed, Jul 31, 2013 at 05:00:01PM -0700, Ben Widawsky wrote:
> In order to do this for all VMs, it's convenient to rework the logic a
> bit. This should have no functional impact.
>
> Signed-off-by: Ben Widawsky
I didn't read ahead but I guess the actual shrink code here will move to
the unboun
On Sun, Aug 04, 2013 at 11:47:29PM -0700, Ben Widawsky wrote:
> The default LLC age was changed:
> commit 0d8ff15e9a15f2b393e53337a107b7a1e5919b6d
> Author: Ben Widawsky
> Date: Thu Jul 4 11:02:03 2013 -0700
>
> drm/i915/hsw: Set correct Haswell PTE encodings.
>
> On the surface it would seem
On Fri, Aug 02, 2013 at 09:16:03AM +0800, Aaron Lu wrote:
> Hi Jani & Daniel,
>
> It turned out there is an integer overflow problem, and the below patch
> fixed this problem on Acer Aspire 4732Z and thinkpad R61i.
>
> From: Aaron Lu
> Subject: [PATCH] drm/i915: avoid brightness overflow when do
On Thu, Aug 01, 2013 at 02:12:22PM -0700, Furquan Shaikh wrote:
> Enables getting correct mode clock when reading pipe config
>
> Signed-off-by: Furquan Shaikh
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 8
> drivers/gpu/drm/i915/intel_display.c | 9 -
> 2 files changed, 16 i
On Thu, Aug 01, 2013 at 06:21:28PM +0200, Peter Wu wrote:
> Since commit 29a241c (ACPICA: Add argument typechecking for all
> predefined ACPI names), _DSM parameters are validated which trigger the
> following warning:
>
> ACPI Warning: \_SB_.PCI0.GFX0._DSM: Argument #4 type mismatch - Found
On Fri, Aug 02, 2013 at 01:22:51PM -0300, Paulo Zanoni wrote:
> 2013/8/1 Chris Wilson :
> > Some of our macros we trying to convert from an drm_device to a
> > drm_i915_private and then use the pointer inline. This is not only
> > cumbersome but prone to error. Replacing it with a typesafe function
The default LLC age was changed:
commit 0d8ff15e9a15f2b393e53337a107b7a1e5919b6d
Author: Ben Widawsky
Date: Thu Jul 4 11:02:03 2013 -0700
drm/i915/hsw: Set correct Haswell PTE encodings.
On the surface it would seem setting a default age wouldn't matter
because all GEM BOs are aged similarly,
On Tue, Jul 30, 2013 at 04:27:57PM -0700, Ben Widawsky wrote:
> Upon some code refactoring, a hunk was missed. This was fixed for
> next, but missed the current trees, and hasn't yet been merged by Dave
> Airlie. It is fixed in:
> commit 907b28c56ea40629aa6595ddfa414ec2fc7da41c
> Author: Chris Wils
On Tue, Jul 30, 2013 at 05:23:53PM -0700, Stéphane Marchesin wrote:
> Signed-off-by: Stéphane Marchesin
Ben originally picked this up into his danvet-on-vactaion tree, but since
it's for core drm it needs to go in through Dave's tree.
-Daniel
> ---
> drivers/gpu/drm/drm_modes.c | 37 ---
On Tue, Jul 30, 2013 at 05:23:52PM -0700, Stéphane Marchesin wrote:
> Signed-off-by: Stéphane Marchesin
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
On Tue, Jul 30, 2013 at 11:58:10AM +0100, Chris Wilson wrote:
> On Tue, Jul 30, 2013 at 12:20:32PM +0300, Jani Nikula wrote:
> > VLV wants encoder enabling before the pipe is up. With the previously
> > rearranged VLV DP and HDMI ->pre_enable and ->enable callbacks in place,
> > this no longer depe
On Tue, Jul 30, 2013 at 11:57:06AM +0100, Chris Wilson wrote:
> On Tue, Jul 30, 2013 at 01:36:32PM +0300, Imre Deak wrote:
> > Userspace can pass a mode with an unspecified vsync/hsync polarity
> > setting. All encoders in the Intel driver take this to mean a negative
> > polarity setting. The HW r
72 matches
Mail list logo
