Re: [Intel-gfx] i915.fastboot bug report - not working on coreboot

2014-08-26 Thread Paul Menzel
Dear Charles, thanks a lot for following up on the intel-gfx mailing list. Am Dienstag, den 26.08.2014, 13:09 -0400 schrieb Charles Devereaux: > I'm trying to use i915.fastboot on a Thinkpad X60t. The bios has been > replaced by coreboot, which supports native video init. > > The goal is to b

Re: [Intel-gfx] [PATCH] shader-debugger: Force file/stdout IO as UTF-8

2014-08-26 Thread Rémi Cardona
Le 18/08/2014 01:09, Rémi Cardona a écrit : > Not all locales on linux are UTF-8, the most notable being the C locale. > Python will use the ASCII codec for stream IO in this case and will barf > on the Copyright sign at the top of .g4a files. > > Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Oliver Hartkopp
On 26.08.2014 22:51, Daniel Vetter wrote: > > > Oliver, can you please test the below diff? > > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index f19dbff0e73b..915a60b48159 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dm

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Add BDW support in the i915 debugfs entry

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 10:42:51AM -0700, vedang.pa...@intel.com wrote: > From: Vedang Patel > > The patch introduces fixes for the debugfs attributes emitted by > the i915 driver for GEN8. Currently, it is not emitting the correct > attributes which include the status of RC6 states. > > Change

Re: [Intel-gfx] [PATCH 1/2] tests/pm_psr: Update pm_psr for new psr debug interface.

2014-08-26 Thread Daniel Vetter
On Mon, Aug 25, 2014 at 10:58:44AM -0700, Rodrigo Vivi wrote: > Signed-off-by: Rodrigo Vivi > --- > tests/pm_psr.c | 27 --- > 1 file changed, 20 insertions(+), 7 deletions(-) > > diff --git a/tests/pm_psr.c b/tests/pm_psr.c > index 3ab7e7a..8b92d84 100644 > --- a/tests/p

Re: [Intel-gfx] [PATCH] drm/i915: Enable vblank interrupts for CRC generation

2014-08-26 Thread Daniel Vetter
On Mon, Aug 25, 2014 at 02:47:17PM +0100, Chris Wilson wrote: > On Mon, Aug 25, 2014 at 04:24:56PM +0300, Ville Syrjälä wrote: > > On Mon, Aug 25, 2014 at 01:28:11PM +0100, Chris Wilson wrote: > > > Pineview requires this. But this changes the debug API... > > > > > > References: https://bugs.free

Re: [Intel-gfx] [PATCH v2 0/7] Rename DP training vswing/pre-emph defines

2014-08-26 Thread Jindal, Sonika
Hi, Did anybody get a chance to review the patches? Adding respective owners for different drivers.. Thanks, Sonika -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Jindal, Sonika Sent: Tuesday, August 19, 2014 1:42 PM To: intel-gfx@lists.

Re: [Intel-gfx] [PATCH] drm/i915: Differentiate between LLC or snooped for the user

2014-08-26 Thread Daniel Vetter
On Mon, Aug 25, 2014 at 03:34:20PM +0300, Ville Syrjälä wrote: > On Fri, Aug 22, 2014 at 02:41:39PM +0100, Chris Wilson wrote: > > Rather than describing an object as either "snooped or LLC", we can do > > better as we should know what machine we are running on! > > > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 1/7] drm: Renaming DP training vswing pre emph defines

2014-08-26 Thread Jindal, Sonika
On 8/26/2014 4:58 PM, Thierry Reding wrote: On Fri, Aug 08, 2014 at 04:23:40PM +0530, sonika.jin...@intel.com wrote: From: Sonika Jindal Adding new defines, older one will be removed in the last patch in the series. This is to rename the defines to have levels instead of values for vswing an

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-26 Thread Eric Rannaud
On Tue, Aug 26, 2014 at 1:59 PM, Daniel Vetter wrote: >> Forcing FBC with i915.enable_fbc=1 brings the idle power consumption >> back to under 7W, however. >> This is all on 3.15.4-ARCH-00041-gf4db98240ac2. > > Any significant changes in package C state as reported in powertop? > Indeed fairly imp

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 11:18 PM, Jesse Barnes wrote: > Daniel Vetter wrote: > >> >> On Tue, Aug 26, 2014 at 8:52 PM, Jesse Barnes >> wrote: >> > On Tue, 26 Aug 2014 09:23:54 +0200 >> > Daniel Vetter wrote: >> > >> >> On Mon, Aug 25, 2014 at 04:24:55PM -0700, Jesse Barnes wrote: >> >> > This h

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Jesse Barnes
On Tue, 26 Aug 2014 22:51:13 +0200 Daniel Vetter wrote: > > On Tue, Aug 26, 2014 at 8:52 PM, Jesse Barnes > wrote: > > On Tue, 26 Aug 2014 09:23:54 +0200 > > Daniel Vetter wrote: > > > >> On Mon, Aug 25, 2014 at 04:24:55PM -0700, Jesse Barnes wrote: > >> > This happens in irq_postinstall befo

Re: [Intel-gfx] [PATCH 3/3] drm/i915: send PCI_D3hot adapter opregion message on BDW RPM suspend

2014-08-26 Thread Daniel Vetter
On Thu, Aug 21, 2014 at 10:47:12PM +0100, Damien Lespiau wrote: > On Thu, Aug 21, 2014 at 05:09:38PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > On BDW we're seeing a problem that after we runtime resume, the > > outputs connected to DDI C are not detected: they don't appear in the

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 4:57 PM, Eric Rannaud wrote: > On Tue, Aug 26, 2014 at 6:38 AM, Eric Rannaud wrote: >> Could the FBC commit somehow also disable RC6, or similar? > > I just tried these kernel arguments with no significant effect on > power consumption (i.e. still around 11W in idle, inste

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 8:52 PM, Jesse Barnes wrote: > On Tue, 26 Aug 2014 09:23:54 +0200 > Daniel Vetter wrote: > >> On Mon, Aug 25, 2014 at 04:24:55PM -0700, Jesse Barnes wrote: >> > This happens in irq_postinstall before we've set the pm._irqs_disabled >> > flag, >> > but shouldn't warn. So

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 8:38 PM, Rodrigo Vivi wrote: > On Tue, Aug 26, 2014 at 12:54 AM, Daniel Vetter wrote: >> On Tue, Aug 26, 2014 at 2:39 AM, Rodrigo Vivi >> wrote: >> > So I prefer to continue using the HW/ring version we have already >> > working >> > for HSW and merge this v3 to get FBC w

[Intel-gfx] [PATCH i-g-t 1/1] scripts: Add capability to resume interrupted run-tests.sh session

2014-08-26 Thread Mike Mason
Piglit provides a 'resume' feature that can restart an interrupted test run at the point where it stopped. This patch adds that feature to run_tests.sh. Signed-off-by: Mike Mason --- scripts/run-tests.sh | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/scripts

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Scot Doyle
On Tue, 26 Aug 2014, Daniel Vetter wrote: > On Tue, Aug 26, 2014 at 07:33:25PM +0200, Daniel Vetter wrote: >> Indeed the bios seems to just but gunk into that register. And if we add >> in all the knobs there's piles of them (you have semi-duplicated backlight >> registers on hsw on the PCH), so I

Re: [Intel-gfx] [PATCH 3/4] lib/igt_* Use igt macros in igt libaries

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 7:48 PM, Chris Wilson wrote: >> fflush(stdout); > > fflush(stdout) is a non-sequitur when converting to opaque logging. Indeed, I missed that one. Fixed up locally. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwl

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Jesse Barnes
On Tue, 26 Aug 2014 21:03:11 +0200 Oliver Hartkopp wrote: > On 26.08.2014 20:52, Jesse Barnes wrote: > > On Tue, 26 Aug 2014 09:23:54 +0200 > > Daniel Vetter wrote: > > >>> This happens in irq_postinstall before we've set the pm._irqs_disabled > >>> flag, > >>> but shouldn't warn. So add a no

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Oliver Hartkopp
On 26.08.2014 20:52, Jesse Barnes wrote: > On Tue, 26 Aug 2014 09:23:54 +0200 > Daniel Vetter wrote: >>> This happens in irq_postinstall before we've set the pm._irqs_disabled flag, >>> but shouldn't warn. So add a nowarn variant to allow this to happen w/o >>> a backtrace and keep the rest of t

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Jesse Barnes
On Tue, 26 Aug 2014 09:23:54 +0200 Daniel Vetter wrote: > On Mon, Aug 25, 2014 at 04:24:55PM -0700, Jesse Barnes wrote: > > This happens in irq_postinstall before we've set the pm._irqs_disabled flag, > > but shouldn't warn. So add a nowarn variant to allow this to happen w/o > > a backtrace and

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-26 Thread Rodrigo Vivi
On Tue, Aug 26, 2014 at 12:54 AM, Daniel Vetter wrote: > On Tue, Aug 26, 2014 at 2:39 AM, Rodrigo Vivi > wrote: > > So I prefer to continue using the HW/ring version we have already working > > for HSW and merge this v3 to get FBC working at BDW. > > Well for that we first need to fix up the psr

Re: [Intel-gfx] 3.17.0-rc1: WARNING: CPU: 1 PID: 1 at drivers/gpu/drm/i915/i915_irq.c:139 ironlake_enable_display_irq+0x7f/0x90()

2014-08-26 Thread Oliver Hartkopp
On 26.08.2014 13:09, Ville Syrjälä wrote: > > It's the PCU irq enable. I think I have a patch somewhere for it. Just > forgot to send it out. > As Daniel complained about Jesse's approach you are invited to post it here so that I can test it too. Regards, Oliver ___

Re: [Intel-gfx] [PATCH 3/4] lib/igt_* Use igt macros in igt libaries

2014-08-26 Thread Chris Wilson
On Tue, Aug 26, 2014 at 07:36:13PM +0200, Daniel Vetter wrote: > diff --git a/lib/igt_kms.c b/lib/igt_kms.c > index a414d960d24b..0497042eac0c 100644 > --- a/lib/igt_kms.c > +++ b/lib/igt_kms.c > @@ -202,23 +202,15 @@ void kmstest_dump_mode(drmModeModeInfo *mode) > { > const char *stereo = m

[Intel-gfx] [PATCH] drm/i915/bdw: Add BDW support in the i915 debugfs entry

2014-08-26 Thread vedang . patel
From: Vedang Patel The patch introduces fixes for the debugfs attributes emitted by the i915 driver for GEN8. Currently, it is not emitting the correct attributes which include the status of RC6 states. Change-Id: Ib2068a0cac9a5wq3f228e547fa1a097ad369d242df Signed-off-by: Vedang Patel --- dri

[Intel-gfx] [PATCH 4/4] lib: Use igt macros more

2014-08-26 Thread Daniel Vetter
Stragglers. Signed-off-by: Daniel Vetter --- lib/instdone.c | 5 +++-- lib/intel_batchbuffer.c | 32 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/lib/instdone.c b/lib/instdone.c index 99857e2033bd..51cdff9bd22b 100644 --- a/lib/instd

[Intel-gfx] [PATCH 1/4] lib/rendercopy*: Use igt_assert

2014-08-26 Thread Daniel Vetter
--- lib/media_fill_gen7.c | 8 lib/media_fill_gen8.c | 8 lib/media_fill_gen8lp.c | 8 lib/rendercopy_gen6.c | 4 ++-- lib/rendercopy_gen7.c | 8 lib/rendercopy_gen8.c | 10 +- 6 files changed, 23 insertions(+), 23 deletions(-) diff --git

[Intel-gfx] [PATCH 3/4] lib/igt_* Use igt macros in igt libaries

2014-08-26 Thread Daniel Vetter
Except in igt_core since that would lead to some hilarious recursions. Signed-off-by: Daniel Vetter --- lib/igt_aux.c | 9 - lib/igt_debugfs.c | 14 +++--- lib/igt_kms.c | 43 ++- 3 files changed, 29 insertions(+), 37 deletions(-)

[Intel-gfx] [PATCH 2/4] lib/intel_* Use igt checks and macros

2014-08-26 Thread Daniel Vetter
Various stuff all over. Most done with the igt.cocci spatch, but with a few fixups by hand. And add igt_core.h includes where needed. Signed-off-by: Daniel Vetter --- lib/igt_fb.c| 2 +- lib/intel_chipset.c | 17 ++--- lib/intel_iosf.c| 8 lib/intel_mmio.c|

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 07:33:25PM +0200, Daniel Vetter wrote: > On Tue, Aug 26, 2014 at 04:15:53PM +, Scot Doyle wrote: > > On Tue, 26 Aug 2014, Daniel Vetter wrote: > > > On Thu, Aug 21, 2014 at 07:12:59AM +, Scot Doyle wrote: > > >> When we enter intel_modeset_setup_hw_state during resum

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 04:15:53PM +, Scot Doyle wrote: > On Tue, 26 Aug 2014, Daniel Vetter wrote: > > On Thu, Aug 21, 2014 at 07:12:59AM +, Scot Doyle wrote: > >> When we enter intel_modeset_setup_hw_state during resume > >> - BLC_PWM_CPU_CTL2 == BLM_PWM_ENABLE > >> - the physical backlig

Re: [Intel-gfx] [PATCH 1/3] drm/i915: call lpt_init_clock_gating on BDW too

2014-08-26 Thread Damien Lespiau
On Tue, Aug 26, 2014 at 07:16:34PM +0200, Daniel Vetter wrote: > On Thu, Aug 21, 2014 at 10:50:38PM +0100, Damien Lespiau wrote: > > On Thu, Aug 21, 2014 at 05:09:36PM -0300, Paulo Zanoni wrote: > > > From: Paulo Zanoni > > > > > > Because BDW has WPT, which is equivalent to LPT. This is just lik

Re: [Intel-gfx] [PATCH 1/3] drm/i915: call lpt_init_clock_gating on BDW too

2014-08-26 Thread Daniel Vetter
On Thu, Aug 21, 2014 at 10:50:38PM +0100, Damien Lespiau wrote: > On Thu, Aug 21, 2014 at 05:09:36PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > Because BDW has WPT, which is equivalent to LPT. This is just like the > > CPT/PPT case. > > > > Signed-off-by: Paulo Zanoni > > It'd b

[Intel-gfx] i915.fastboot bug report - not working on coreboot

2014-08-26 Thread Charles Devereaux
Hello I'm trying to use i915.fastboot on a Thinkpad X60t. The bios has been replaced by coreboot, which supports native video init. The goal is to boot to a console on a debian in less than 2 seconds (kernel + systemd), systemd is just fine in 0.6s but the kernel takes a long time, with apparentl

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Scot Doyle
On Tue, 26 Aug 2014, Daniel Vetter wrote: > On Thu, Aug 21, 2014 at 07:12:59AM +, Scot Doyle wrote: >> When we enter intel_modeset_setup_hw_state during resume >> - BLC_PWM_CPU_CTL2 == BLM_PWM_ENABLE >> - the physical backlight is off > > Hm, this is actually interesting - we have some other ev

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Chris Wilson
On Tue, Aug 26, 2014 at 05:37:05PM +0300, Ville Syrjälä wrote: > On Tue, Aug 26, 2014 at 02:44:50PM +0100, Arun Siluvery wrote: > > For BDW workarounds are currently initialized in init_clock_gating() but > > they are lost during reset, suspend/resume etc; this patch moves the WAs > > that are part

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Ville Syrjälä
On Tue, Aug 26, 2014 at 03:47:52PM +0100, Siluvery, Arun wrote: > On 26/08/2014 15:37, Ville Syrjälä wrote: > > On Tue, Aug 26, 2014 at 02:44:50PM +0100, Arun Siluvery wrote: > >> For BDW workarounds are currently initialized in init_clock_gating() but > >> they are lost during reset, suspend/resum

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-26 Thread Eric Rannaud
On Tue, Aug 26, 2014 at 6:38 AM, Eric Rannaud wrote: > Could the FBC commit somehow also disable RC6, or similar? I just tried these kernel arguments with no significant effect on power consumption (i.e. still around 11W in idle, instead of under 7W): i915.enable_rc6=1 i915.lvds_downclock

Re: [Intel-gfx] Fwd: i915 (possibly): Suspend regression Macbook Pro 15 (late 2013)

2014-08-26 Thread Eric Rannaud
On Tue, Aug 26, 2014 at 12:17 AM, Daniel Vetter wrote: > Sounds new. Anything interesting going on in dmesg while the on/off > flickering goes on if you crank up output with drm.debug=0xe? I actually get some traces. There appears to be 2 different traces that repeat whenever the screen goes thro

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Ville Syrjälä
On Tue, Aug 26, 2014 at 02:44:50PM +0100, Arun Siluvery wrote: > For BDW workarounds are currently initialized in init_clock_gating() but > they are lost during reset, suspend/resume etc; this patch moves the WAs > that are part of register state context to render ring init fn otherwise > default c

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Siluvery, Arun
On 26/08/2014 15:37, Ville Syrjälä wrote: On Tue, Aug 26, 2014 at 02:44:50PM +0100, Arun Siluvery wrote: For BDW workarounds are currently initialized in init_clock_gating() but they are lost during reset, suspend/resume etc; this patch moves the WAs that are part of register state context to re

Re: [Intel-gfx] [PATCH 2/2] drm/i915: improve assert_panel_unlocked

2014-08-26 Thread Daniel Vetter
On Fri, Aug 22, 2014 at 11:00:15AM +0300, Ville Syrjälä wrote: > On Thu, Aug 21, 2014 at 12:01:07PM -0300, Paulo Zanoni wrote: > > 2014-08-21 11:56 GMT-03:00 Ville Syrjälä : > > > On Thu, Aug 21, 2014 at 03:06:26PM +0300, Jani Nikula wrote: > > >> Fix assert_panel_unlocked for vlv/chv, and improve

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Render moot context reset and switch with Execlists

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 02:54:39PM +0100, Siluvery, Arun wrote: > On 26/08/2014 06:59, Chris Wilson wrote: > >On Mon, Aug 25, 2014 at 10:39:39PM +0200, Daniel Vetter wrote: > >>On Wed, Aug 20, 2014 at 04:36:05PM +0100, Chris Wilson wrote: > >>>On Wed, Aug 20, 2014 at 04:29:24PM +0100, Thomas Daniel

Re: [Intel-gfx] [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 02:46:25PM +0100, Chris Wilson wrote: > On Tue, Aug 26, 2014 at 03:34:07PM +0200, Daniel Vetter wrote: > > On Tue, Aug 26, 2014 at 10:29:23AM -0300, Paulo Zanoni wrote: > > > 2014-08-26 10:18 GMT-03:00 Chris Wilson : > > > > On Tue, Aug 26, 2014 at 10:04:22AM -0300, Paulo Za

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Reorganize vlv eDP reboot notifier

2014-08-26 Thread Ville Syrjälä
On Tue, Aug 26, 2014 at 03:36:07PM +0200, Daniel Vetter wrote: > On Tue, Aug 26, 2014 at 04:21:00PM +0300, Jani Nikula wrote: > > On Tue, 26 Aug 2014, Ville Syrjälä wrote: > > > On Tue, Aug 19, 2014 at 10:00:55AM +0300, Jani Nikula wrote: > > >> On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com w

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Render moot context reset and switch with Execlists

2014-08-26 Thread Siluvery, Arun
On 26/08/2014 06:59, Chris Wilson wrote: On Mon, Aug 25, 2014 at 10:39:39PM +0200, Daniel Vetter wrote: On Wed, Aug 20, 2014 at 04:36:05PM +0100, Chris Wilson wrote: On Wed, Aug 20, 2014 at 04:29:24PM +0100, Thomas Daniel wrote: These two functions make no sense in an Logical Ring Context & Ex

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix to Enable GT/PM Interrupts for cherryview.

2014-08-26 Thread Daniel Vetter
On Fri, Aug 22, 2014 at 08:32:40AM +0530, deepa...@linux.intel.com wrote: > From: Deepak S > > Programing GT IER interrupts was fumbled while enabling Interrupts for > gen8 > > This is a regression from > commit abd58f0175915bed644aa67c8f69dc571b8280e0 > Author: Ben Widawsky > Date:

[Intel-gfx] [PATCH] igt/gem_workarounds: igt to test workaround registers

2014-08-26 Thread Arun Siluvery
Some of the workarounds are lost followed by a gpu reset, suspend/resume; this patch adds a test which compares register state before and after the test scenario. This test currently verifies only bdw workarounds. v2: address patch cleanup comments (ThomasW) Add binary to ignore list and use igt

Re: [Intel-gfx] [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code

2014-08-26 Thread Chris Wilson
On Tue, Aug 26, 2014 at 03:34:07PM +0200, Daniel Vetter wrote: > On Tue, Aug 26, 2014 at 10:29:23AM -0300, Paulo Zanoni wrote: > > 2014-08-26 10:18 GMT-03:00 Chris Wilson : > > > On Tue, Aug 26, 2014 at 10:04:22AM -0300, Paulo Zanoni wrote: > > >> Of course, we can also implement the one-shot thing

[Intel-gfx] [PATCH 2/2] drm/i915/bdw: Export workaround data to debugfs

2014-08-26 Thread Arun Siluvery
The workarounds that are applied are exported to a debugfs file; this is used to verify their state after the test case (reset or suspend/resume etc). This patch is only required to support i-g-t. Signed-off-by: Arun Siluvery --- drivers/gpu/drm/i915/i915_debugfs.c | 40 +

[Intel-gfx] [PATCH 0/2] Apply BDW workarounds using LRIs in render init fn

2014-08-26 Thread Arun Siluvery
Workarounds for BDW are applied using LRIs during render ring initialization. Only those WA registers that are part of register state are initialized in this fn, remaining are still in its current place init_clock_gating() which are not affected by a gpu reset. I can send another patch where they c

[Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Arun Siluvery
For BDW workarounds are currently initialized in init_clock_gating() but they are lost during reset, suspend/resume etc; this patch moves the WAs that are part of register state context to render ring init fn otherwise default context ends up with incorrect values as they don't get initialized unti

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib: add kmstest_edid_add_3d

2014-08-26 Thread Damien Lespiau
On Wed, Aug 20, 2014 at 11:54:07AM +0100, Thomas Wood wrote: > kmstest_edid_add_3d adds an EDID extension block with 3D support to a > copy of the specified EDID. > > Signed-off-by: Thomas Wood The series looks reasonable, ship it! -- Damien > --- > lib/igt_kms.c | 80 >

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests: add kms_3d test

2014-08-26 Thread Damien Lespiau
On Wed, Aug 20, 2014 at 11:54:09AM +0100, Thomas Wood wrote: > Add a test to verify creation and use of 3D stereo modes. > > Signed-off-by: Thomas Wood > --- > lib/igt_fb.c | 4 +- > tests/.gitignore | 1 + > tests/Android.mk | 1 + > tests/Makefile.sources | 1 + >

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-26 Thread Eric Rannaud
On Tue, Aug 26, 2014 at 4:06 AM, Ville Syrjälä wrote: > FBC works best when the screen contents don't change. The more activity > on the screen the less effective FBC becomes. 4W sounds way too much for > FBC however. 0.4W is closer to what one might expect from FBC based on my > observations. 4W

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds using the golden render state

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 01:57:19PM +0100, Siluvery, Arun wrote: > On 26/08/2014 13:53, Daniel Vetter wrote: > >On Fri, Aug 22, 2014 at 01:10:26PM +0100, Siluvery, Arun wrote: > >>On 22/08/2014 12:06, Mika Kuoppala wrote: > >>>Ville Syrjälä writes: > >>> > On Wed, Aug 20, 2014 at 03:19:17PM +01

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Reorganize vlv eDP reboot notifier

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 04:21:00PM +0300, Jani Nikula wrote: > On Tue, 26 Aug 2014, Ville Syrjälä wrote: > > On Tue, Aug 19, 2014 at 10:00:55AM +0300, Jani Nikula wrote: > >> On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: > >> > From: Ville Syrjälä > >> > > >> > Move the vlv_power_sequ

Re: [Intel-gfx] [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 10:29:23AM -0300, Paulo Zanoni wrote: > 2014-08-26 10:18 GMT-03:00 Chris Wilson : > > On Tue, Aug 26, 2014 at 10:04:22AM -0300, Paulo Zanoni wrote: > >> Of course, we can also implement the one-shot thing on top of the > >> above, but it won't really help us reducing the amo

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Reorganize vlv eDP reboot notifier

2014-08-26 Thread Ville Syrjälä
On Tue, Aug 26, 2014 at 04:21:00PM +0300, Jani Nikula wrote: > On Tue, 26 Aug 2014, Ville Syrjälä wrote: > > On Tue, Aug 19, 2014 at 10:00:55AM +0300, Jani Nikula wrote: > >> On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: > >> > From: Ville Syrjälä > >> > > >> > Move the vlv_power_sequ

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Add BDW support in the i915 debugfs entry

2014-08-26 Thread Daniel Vetter
On Wed, Aug 20, 2014 at 12:04:31PM -0700, vedang.pa...@intel.com wrote: > From: Vedang Patel > > The patch introduces fixes for the debugfs attributes emitted by > the i915 driver for GEN8. Currently, it is not emitting the correct > attributes which include the status of RC6 states. > > Change

Re: [Intel-gfx] [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code

2014-08-26 Thread Paulo Zanoni
2014-08-26 10:18 GMT-03:00 Chris Wilson : > On Tue, Aug 26, 2014 at 10:04:22AM -0300, Paulo Zanoni wrote: >> 2014-08-26 9:42 GMT-03:00 Chris Wilson : >> > On Tue, Aug 26, 2014 at 09:17:11AM -0300, Paulo Zanoni wrote: >> >> 2014-08-26 7:22 GMT-03:00 Chris Wilson : >> >> > On Wed, Jul 16, 2014 at 05:

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Do not initialize PPGTT in the legacy way for execlists

2014-08-26 Thread Daniel Vetter
On Wed, Aug 20, 2014 at 04:24:50PM +0100, Thomas Daniel wrote: > A pending commit removes synchronous mode from switch_mm. This breaks > execlists because switch_mm will always try to write to the legacy ring > buffer. > > Return immediately from i915_ppgtt_init_gw in execlists mode. > No longer

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Reorganize vlv eDP reboot notifier

2014-08-26 Thread Jani Nikula
On Tue, 26 Aug 2014, Ville Syrjälä wrote: > On Tue, Aug 19, 2014 at 10:00:55AM +0300, Jani Nikula wrote: >> On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: >> > From: Ville Syrjälä >> > >> > Move the vlv_power_sequencer_pipe() after the IS_VALLEYVIEW() check >> > and flatten the rest of

Re: [Intel-gfx] [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code

2014-08-26 Thread Chris Wilson
On Tue, Aug 26, 2014 at 10:04:22AM -0300, Paulo Zanoni wrote: > 2014-08-26 9:42 GMT-03:00 Chris Wilson : > > On Tue, Aug 26, 2014 at 09:17:11AM -0300, Paulo Zanoni wrote: > >> 2014-08-26 7:22 GMT-03:00 Chris Wilson : > >> > On Wed, Jul 16, 2014 at 05:49:29PM -0300, Paulo Zanoni wrote: > >> >> stat

Re: [Intel-gfx] [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code

2014-08-26 Thread Paulo Zanoni
2014-08-26 9:42 GMT-03:00 Chris Wilson : > On Tue, Aug 26, 2014 at 09:17:11AM -0300, Paulo Zanoni wrote: >> 2014-08-26 7:22 GMT-03:00 Chris Wilson : >> > On Wed, Jul 16, 2014 at 05:49:29PM -0300, Paulo Zanoni wrote: >> >> static void >> >> -hsw_unclaimed_reg_check(struct drm_i915_private *dev_priv

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Reorganize vlv eDP reboot notifier

2014-08-26 Thread Ville Syrjälä
On Tue, Aug 19, 2014 at 10:00:55AM +0300, Jani Nikula wrote: > On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Move the vlv_power_sequencer_pipe() after the IS_VALLEYVIEW() check > > and flatten the rest of the function. > > Please imagine adding another

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds using the golden render state

2014-08-26 Thread Siluvery, Arun
On 26/08/2014 13:53, Daniel Vetter wrote: On Fri, Aug 22, 2014 at 01:10:26PM +0100, Siluvery, Arun wrote: On 22/08/2014 12:06, Mika Kuoppala wrote: Ville Syrjälä writes: On Wed, Aug 20, 2014 at 03:19:17PM +0100, Arun Siluvery wrote: Workarounds for bdw are currently applied in init_clock_ga

Re: [Intel-gfx] [PATCH 2/2] igt/gem_workarounds: igt to test workaround registers

2014-08-26 Thread Daniel Vetter
On Wed, Aug 20, 2014 at 03:52:12PM +0100, Arun Siluvery wrote: > Some of the workarounds are lost followed by a gpu reset, suspend/resume; > this patch adds a test which compares register state before and after > the test scenario. > > This test currently verifies only bdw workarounds. > > Signed

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds using the golden render state

2014-08-26 Thread Daniel Vetter
On Fri, Aug 22, 2014 at 01:10:26PM +0100, Siluvery, Arun wrote: > On 22/08/2014 12:06, Mika Kuoppala wrote: > >Ville Syrjälä writes: > > > >>On Wed, Aug 20, 2014 at 03:19:17PM +0100, Arun Siluvery wrote: > >>>Workarounds for bdw are currently applied in init_clock_gating() but they > >>>are lost f

Re: [Intel-gfx] [PATCH] drm/i915: Make wait-for-pending-flips more defensive

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 02:49:07PM +0300, Jani Nikula wrote: > On Wed, 20 Aug 2014, Chris Wilson wrote: > > Be sure to always flush a stuck pageflip even if we couldn't possibly > > expect one to be there. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=82612 > > Signed-off-by: Ch

Re: [Intel-gfx] [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code

2014-08-26 Thread Chris Wilson
On Tue, Aug 26, 2014 at 09:17:11AM -0300, Paulo Zanoni wrote: > 2014-08-26 7:22 GMT-03:00 Chris Wilson : > > On Wed, Jul 16, 2014 at 05:49:29PM -0300, Paulo Zanoni wrote: > >> static void > >> -hsw_unclaimed_reg_check(struct drm_i915_private *dev_priv, u32 reg) > >> +hsw_unclaimed_reg_detect(struc

Re: [Intel-gfx] [PATCH 12/14] drm/i915: Turn on panel power before doing aux transfers

2014-08-26 Thread Daniel Vetter
On Tue, Aug 19, 2014 at 01:57:57PM +0300, Ville Syrjälä wrote: > On Tue, Aug 19, 2014 at 10:33:15AM +0300, Jani Nikula wrote: > > On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > On VLV/CHV the panel power sequencer may need to be "kicked" a bit to >

Re: [Intel-gfx] [PATCH v2] drm/i915: Handle i915_ppgtt_put correctly

2014-08-26 Thread Daniel Vetter
On Tue, Aug 19, 2014 at 03:49:41PM +0100, Michel Thierry wrote: > Unfortunately, the gem_obj/vma relationship is not symmetrical; a gem_obj > can look up for the same vma more than once (where the ppgtt refcount is > incremented), but will free the vma only once (i915_gem_free_object). > > This di

Re: [Intel-gfx] [PATCH] drm/i915: Ignore VBT backlight presence check on Acer C720 (4005U)

2014-08-26 Thread Jani Nikula
On Thu, 21 Aug 2014, Scot Doyle wrote: > commit c675949ec58ca50d5a3ae3c757892f1560f6e896 > drm/i915: do not setup backlight if not available according to VBT > > prevents backlight setup on the Acer C720 (Core i3 4005U CPU), which has a > misconfigured VBT. Apply quirk to ignore the VBT backli

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-26 Thread Jani Nikula
On Fri, 15 Aug 2014, Paulo Zanoni wrote: > From: Paulo Zanoni > > If we're runtime suspended and try to use the plane interfaces, we > will get a lot of WARNs saying we did the wrong thing. > > We need to get runtime PM references to pin the objects, and to > change the fences. The pin functions

Re: [Intel-gfx] [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code

2014-08-26 Thread Paulo Zanoni
2014-08-26 7:22 GMT-03:00 Chris Wilson : > On Wed, Jul 16, 2014 at 05:49:29PM -0300, Paulo Zanoni wrote: >> static void >> -hsw_unclaimed_reg_check(struct drm_i915_private *dev_priv, u32 reg) >> +hsw_unclaimed_reg_detect(struct drm_i915_private *dev_priv) >> { >> + if (i915.mmio_debug) >> +

Re: [Intel-gfx] [PATCH] drm/i915: Move intel_ddi_set_vc_payload_alloc(false) to haswell_crtc_disable()

2014-08-26 Thread Jani Nikula
On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Somehow the intel_ddi_set_vc_payload_alloc(false) call has ended up > in ironlake_crtc_disable() rather than haswell_crtc_disable(). Move it > to the correct place. > > intel_ddi_disable_transcoder_func() already d

Re: [Intel-gfx] [PATCH] drm/i915: Make wait-for-pending-flips more defensive

2014-08-26 Thread Chris Wilson
On Tue, Aug 26, 2014 at 02:49:07PM +0300, Jani Nikula wrote: > On Wed, 20 Aug 2014, Chris Wilson wrote: > > Be sure to always flush a stuck pageflip even if we couldn't possibly > > expect one to be there. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=82612 > > Signed-off-by: Ch

Re: [Intel-gfx] [PATCH] drm/i915: Make wait-for-pending-flips more defensive

2014-08-26 Thread Jani Nikula
On Wed, 20 Aug 2014, Chris Wilson wrote: > Be sure to always flush a stuck pageflip even if we couldn't possibly > expect one to be there. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=82612 > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/intel_display.c | 12 +-

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Siluvery, Arun
On 26/08/2014 11:34, Chris Wilson wrote: On Tue, Aug 26, 2014 at 11:16:29AM +0100, Siluvery, Arun wrote: On 26/08/2014 11:09, Chris Wilson wrote: On Tue, Aug 26, 2014 at 10:33:16AM +0100, Arun Siluvery wrote: For BDW workarounds are currently initialized in init_clock_gating() but they are los

Re: [Intel-gfx] [PATCH 1/7] drm: Renaming DP training vswing pre emph defines

2014-08-26 Thread Thierry Reding
On Fri, Aug 08, 2014 at 04:23:40PM +0530, sonika.jin...@intel.com wrote: > From: Sonika Jindal > > Adding new defines, older one will be removed in the last patch in the series. > This is to rename the defines to have levels instead of values for vswing and > pre-emph levels as the values may dif

Re: [Intel-gfx] 3.17.0-rc1: WARNING: CPU: 1 PID: 1 at drivers/gpu/drm/i915/i915_irq.c:139 ironlake_enable_display_irq+0x7f/0x90()

2014-08-26 Thread Ville Syrjälä
On Mon, Aug 25, 2014 at 03:36:15PM -0700, Jesse Barnes wrote: > On Mon, 25 Aug 2014 20:29:27 +0200 > Oliver Hartkopp wrote: > > > Hi Jesse, > > > > since the i915 stuff for 3.17 was merged I always get this > > warning on my core i7 with internal Intel HD graphics. > > > > Intel(R) Core(TM) i7

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-26 Thread Ville Syrjälä
On Mon, Aug 25, 2014 at 05:19:49AM -0700, Eric Rannaud wrote: > Hi Jani, > > Is there a way to restore the prior lower power consumption when > idling? As I understand it, FBC should not have a direct effect on > power consumption when idle, only when the FB is actively refreshed. > Is it understo

Re: [Intel-gfx] [PATCH v2] drm/i915: fix suspend/resume for GENs w/o runtime PM support

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 01:26:56PM +0300, Imre Deak wrote: > Before sharing common parts between the system and runtime s/r > handlers we WARNed if the runtime s/r handlers were called on GENs that > didn't support RPM. But this WARN is not correct if the same handler is > called from the system s/

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Daniel Vetter
On Thu, Aug 21, 2014 at 07:12:59AM +, Scot Doyle wrote: > > On Tue, 19 Aug 2014, Daniel Vetter wrote: > >On Tue, Aug 19, 2014 at 4:07 AM, Scot Doyle wrote: > >>BIOS or firmware can modify hardware state during suspend/resume, > >>for example on the Toshiba CB35 or Lenovo T400, so log a debug

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Chris Wilson
On Tue, Aug 26, 2014 at 11:16:29AM +0100, Siluvery, Arun wrote: > On 26/08/2014 11:09, Chris Wilson wrote: > >On Tue, Aug 26, 2014 at 10:33:16AM +0100, Arun Siluvery wrote: > >>For BDW workarounds are currently initialized in init_clock_gating() but > >>they are lost during reset, suspend/resume et

[Intel-gfx] [PATCH v2] drm/i915: fix suspend/resume for GENs w/o runtime PM support

2014-08-26 Thread Imre Deak
Before sharing common parts between the system and runtime s/r handlers we WARNed if the runtime s/r handlers were called on GENs that didn't support RPM. But this WARN is not correct if the same handler is called from the system s/r path, since that can happen on any platform. This also broke syst

Re: [Intel-gfx] [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code

2014-08-26 Thread Chris Wilson
On Wed, Jul 16, 2014 at 05:49:29PM -0300, Paulo Zanoni wrote: > static void > -hsw_unclaimed_reg_check(struct drm_i915_private *dev_priv, u32 reg) > +hsw_unclaimed_reg_detect(struct drm_i915_private *dev_priv) > { > + if (i915.mmio_debug) > + return; > + > if (__raw_i915_rea

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Siluvery, Arun
On 26/08/2014 11:09, Chris Wilson wrote: On Tue, Aug 26, 2014 at 10:33:16AM +0100, Arun Siluvery wrote: For BDW workarounds are currently initialized in init_clock_gating() but they are lost during reset, suspend/resume etc; this patch moves the WAs that are part of register state context to ren

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Chris Wilson
On Tue, Aug 26, 2014 at 10:33:16AM +0100, Arun Siluvery wrote: > For BDW workarounds are currently initialized in init_clock_gating() but > they are lost during reset, suspend/resume etc; this patch moves the WAs > that are part of register state context to render ring init fn otherwise > default c

Re: [Intel-gfx] [PATCH] drm/i915/dp: Backlight PWM enable before BL Enable assert

2014-08-26 Thread Daniel Vetter
On Fri, Aug 22, 2014 at 05:12:25PM +, Runyan, Arthur J wrote: > I'll check it out. I haven't heard any complaint about this before, but > it may be one of those things that started back on i745 and never got > documented. Only i855 and later started to have native lvds with all the surroundi

Re: [Intel-gfx] [PATCH 14/14] drm/i915: Move DP port disable to post_disable for pch platforms

2014-08-26 Thread Daniel Vetter
On Mon, Aug 18, 2014 at 10:16:09PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We need to turn the DP port off after the pipe, otherwise the pipe won't > turn off properly on certain pch platforms at least (happens on my ILK for > example). This also matches the BSpec m

Re: [Intel-gfx] [PATCH 00/14] drm/i915: edp vdd locking and prep for power sequencer kick

2014-08-26 Thread Daniel Vetter
On Tue, Aug 19, 2014 at 10:45:20AM +0300, Jani Nikula wrote: > On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > While wrestling with the VLV/CHV panel power sequencer I noticed the locking > > in our edp vdd code was rather broken. This series aims to fix t

Re: [Intel-gfx] [PATCH 00/14] drm/i915: edp vdd locking and prep for power sequencer kick

2014-08-26 Thread Daniel Vetter
On Tue, Aug 19, 2014 at 01:46:58PM +0300, Ville Syrjälä wrote: > On Tue, Aug 19, 2014 at 11:08:33AM +0300, Jani Nikula wrote: > > On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > While wrestling with the VLV/CHV panel power sequencer I noticed the >

[Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Arun Siluvery
For BDW workarounds are currently initialized in init_clock_gating() but they are lost during reset, suspend/resume etc; this patch moves the WAs that are part of register state context to render ring init fn otherwise default context ends up with incorrect values as they don't get initialized unti

[Intel-gfx] [PATCH 0/2] Apply BDW workarounds using LRIs in render init fn

2014-08-26 Thread Arun Siluvery
Workarounds for BDW are applied using LRIs during render ring initialization. Only those WA registers that are part of register state are initialized in this fn, remaining are still in its current place init_clock_gating() which are not affected by a gpu reset. I can send another patch where they c

[Intel-gfx] [PATCH 2/2] drm/i915/bdw: Export workaround data to debugfs

2014-08-26 Thread Arun Siluvery
The workarounds that are applied are exported to a debugfs file; this is used to verify their state after the test case (reset or suspend/resume etc). This patch is only required to support i-g-t. Signed-off-by: Arun Siluvery --- drivers/gpu/drm/i915/i915_debugfs.c | 40 +

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-26 Thread Siluvery, Arun
On 25/08/2014 13:18, Ville Syrjälä wrote: On Fri, Aug 22, 2014 at 08:39:11PM +0100, Arun Siluvery wrote: For BDW workarounds are currently initialized in init_clock_gating() but they are lost during reset, suspend/resume etc; this patch moves the WAs that are part of register state context to re

Re: [Intel-gfx] [PATCH 07/14] drm/i915: Warn about want_panel_vdd in edp_panel_vdd_off_sync()

2014-08-26 Thread Daniel Vetter
On Tue, Aug 19, 2014 at 04:37:03PM +0300, Jani Nikula wrote: > On Tue, 19 Aug 2014, Ville Syrjälä wrote: > > On Tue, Aug 19, 2014 at 10:36:52AM +0300, Jani Nikula wrote: > >> On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: > >> > From: Ville Syrjälä > >> > > >> > If we force vdd off war

  1   2   >